)]}'
{"specs/xena/approved/allow-special-characters-in-keypair-name.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb55ac6daa6605be813b1dea95acb0dedfb01a8b","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Allowing the ``@`` (at) and ``.`` (dot) characters in keypair names make it"},{"line_number":23,"context_line":"possible to use the format ``user.name@host.name``."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"---------"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"c0925058_1669e81c","line":24,"updated":"2021-04-09 17:30:21.000000000","message":"in this specific case i think this makes sense.\nmy default keypair on my work laptop is\n\nssh-rsa AAAAB3Nz...dJU3RzPj9Dz sean@pop-os\n\nand it would be nice if it could be listed in horizon/nova as sean@pop-os for example\n\nin other names in the api like server or flavor names blocking @ in particalar is probably still correct but this definitely seam like a valid usecase for  keypairs.","commit_id":"a4bdcd58af6808e283f2b6170152a4e01ee1a849"},{"author":{"_account_id":32637,"name":"Nicolas Parquet","email":"nicolas.parquet@gandi.net","username":"Nautik"},"change_message_id":"f1184af8e0576f67434c78a791a9eff2d9ca6065","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Allowing the ``@`` (at) and ``.`` (dot) characters in keypair names make it"},{"line_number":23,"context_line":"possible to use the format ``user.name@host.name``."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"---------"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ab951731_4e940fab","line":24,"in_reply_to":"c0925058_1669e81c","updated":"2021-04-20 09:40:38.000000000","message":"Ack","commit_id":"a4bdcd58af6808e283f2b6170152a4e01ee1a849"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb55ac6daa6605be813b1dea95acb0dedfb01a8b","unresolved":true,"context_lines":[{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Modify the list of safe characters to add the ``@`` (at) and ``.`` (dot)."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"40fed71b_831e1040","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":73},"updated":"2021-04-09 17:30:21.000000000","message":"we are currently using a common  normalize_name function for keypair names,\n we should introduce a new one for keyparis explictily \nto ensure that we do not allow @ and . in any other api.\n\nhttps://github.com/openstack/nova/blob/42c353bd2f1c1f1396def905e31b28ab6e216e9d/nova/api/openstack/compute/keypairs.py#L105\n\nThis is more of an implemetation detail but it would be nice to note it in the spec directly.","commit_id":"a4bdcd58af6808e283f2b6170152a4e01ee1a849"},{"author":{"_account_id":32637,"name":"Nicolas Parquet","email":"nicolas.parquet@gandi.net","username":"Nautik"},"change_message_id":"f1184af8e0576f67434c78a791a9eff2d9ca6065","unresolved":true,"context_lines":[{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Modify the list of safe characters to add the ``@`` (at) and ``.`` (dot)."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5219d02a_200e99a9","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":73},"in_reply_to":"40fed71b_831e1040","updated":"2021-04-20 09:40:38.000000000","message":"I am not sure I get what you mean; From what I see this `common.normalize_name` already allows @ and dot, as it only strips. Are you suggesting to make it more restrictive for all \u0027other apis\u0027 and use a permissive for keypairs?\n\nIf I get this right, isn\u0027t it out of scope of this spec to add more restrictive checks to other apis than keypairs?","commit_id":"a4bdcd58af6808e283f2b6170152a4e01ee1a849"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb55ac6daa6605be813b1dea95acb0dedfb01a8b","unresolved":true,"context_lines":[{"line_number":47,"context_line":"REST API impact"},{"line_number":48,"context_line":"---------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"This change will need a new microversion."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Security impact"},{"line_number":53,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4fe3de16_8d1b168b","line":50,"updated":"2021-04-09 17:30:21.000000000","message":"for the old microversion you should still call the old function and for the new microverion + call a new\nnormalize_keypair_name function.","commit_id":"a4bdcd58af6808e283f2b6170152a4e01ee1a849"},{"author":{"_account_id":32637,"name":"Nicolas Parquet","email":"nicolas.parquet@gandi.net","username":"Nautik"},"change_message_id":"f1184af8e0576f67434c78a791a9eff2d9ca6065","unresolved":false,"context_lines":[{"line_number":47,"context_line":"REST API impact"},{"line_number":48,"context_line":"---------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"This change will need a new microversion."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Security impact"},{"line_number":53,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7e1d5a74_68dbf829","line":50,"in_reply_to":"4fe3de16_8d1b168b","updated":"2021-04-20 09:40:38.000000000","message":"Thank you, I made this a bit more explicit (without entering into implementation details)","commit_id":"a4bdcd58af6808e283f2b6170152a4e01ee1a849"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb55ac6daa6605be813b1dea95acb0dedfb01a8b","unresolved":true,"context_lines":[{"line_number":105,"context_line":"----------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Verified by"},{"line_number":108,"context_line":"https://opendev.org/openstack/nova/src/branch/master/nova/compute/api.py#L6343"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Check introduced by"},{"line_number":111,"context_line":"https://opendev.org/openstack/nova/commit/c8b0a9a3be7ca276d91d470a629fdd0209812993,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7b129cd5_13d37e54","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":78},"updated":"2021-04-09 17:30:21.000000000","message":"this does not link to what you intend.\nwe also dont normally include links to code like this in this section or in genera so i woudld just remove this.\n\nby the way if you are viewing it on github at least you can pre y to get a perma link that include the commit id.","commit_id":"a4bdcd58af6808e283f2b6170152a4e01ee1a849"},{"author":{"_account_id":32637,"name":"Nicolas Parquet","email":"nicolas.parquet@gandi.net","username":"Nautik"},"change_message_id":"f1184af8e0576f67434c78a791a9eff2d9ca6065","unresolved":false,"context_lines":[{"line_number":105,"context_line":"----------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Verified by"},{"line_number":108,"context_line":"https://opendev.org/openstack/nova/src/branch/master/nova/compute/api.py#L6343"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Check introduced by"},{"line_number":111,"context_line":"https://opendev.org/openstack/nova/commit/c8b0a9a3be7ca276d91d470a629fdd0209812993,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"85f4a3e0_8109db9a","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":78},"in_reply_to":"7b129cd5_13d37e54","updated":"2021-04-20 09:40:38.000000000","message":"Moved these into problem description for more context, with a permalink. Thank you!","commit_id":"a4bdcd58af6808e283f2b6170152a4e01ee1a849"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb55ac6daa6605be813b1dea95acb0dedfb01a8b","unresolved":true,"context_lines":[{"line_number":110,"context_line":"Check introduced by"},{"line_number":111,"context_line":"https://opendev.org/openstack/nova/commit/c8b0a9a3be7ca276d91d470a629fdd0209812993,"},{"line_number":112,"context_line":"to resolve https://bugs.launchpad.net/nova/+bug/937408"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Only modified once since to include space in"},{"line_number":115,"context_line":"https://opendev.org/openstack/nova/commit/ec0a65d81fd11d26be77b45827a4dd7c77711675"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"4ec3a00e_de59514c","line":113,"updated":"2021-04-09 17:30:21.000000000","message":"this is not a work item but you could include it in the problem descrition for contex.","commit_id":"a4bdcd58af6808e283f2b6170152a4e01ee1a849"},{"author":{"_account_id":32637,"name":"Nicolas Parquet","email":"nicolas.parquet@gandi.net","username":"Nautik"},"change_message_id":"f1184af8e0576f67434c78a791a9eff2d9ca6065","unresolved":false,"context_lines":[{"line_number":110,"context_line":"Check introduced by"},{"line_number":111,"context_line":"https://opendev.org/openstack/nova/commit/c8b0a9a3be7ca276d91d470a629fdd0209812993,"},{"line_number":112,"context_line":"to resolve https://bugs.launchpad.net/nova/+bug/937408"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Only modified once since to include space in"},{"line_number":115,"context_line":"https://opendev.org/openstack/nova/commit/ec0a65d81fd11d26be77b45827a4dd7c77711675"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"729944f9_4672b3f9","line":113,"in_reply_to":"4ec3a00e_de59514c","updated":"2021-04-20 09:40:38.000000000","message":"Moved these into problem description for more context, with a permalink. Thank you!","commit_id":"a4bdcd58af6808e283f2b6170152a4e01ee1a849"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb55ac6daa6605be813b1dea95acb0dedfb01a8b","unresolved":true,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Only modified once since to include space in"},{"line_number":115,"context_line":"https://opendev.org/openstack/nova/commit/ec0a65d81fd11d26be77b45827a4dd7c77711675"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Dependencies"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"f13a7bfd_8c5fae74","line":116,"updated":"2021-04-09 17:30:21.000000000","message":"this is also not really relevent i would remove it or include it in the problem description.","commit_id":"a4bdcd58af6808e283f2b6170152a4e01ee1a849"},{"author":{"_account_id":32637,"name":"Nicolas Parquet","email":"nicolas.parquet@gandi.net","username":"Nautik"},"change_message_id":"f1184af8e0576f67434c78a791a9eff2d9ca6065","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Only modified once since to include space in"},{"line_number":115,"context_line":"https://opendev.org/openstack/nova/commit/ec0a65d81fd11d26be77b45827a4dd7c77711675"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Dependencies"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5dd3ebaf_bf6fd0e3","line":116,"in_reply_to":"f13a7bfd_8c5fae74","updated":"2021-04-20 09:40:38.000000000","message":"Same here","commit_id":"a4bdcd58af6808e283f2b6170152a4e01ee1a849"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb55ac6daa6605be813b1dea95acb0dedfb01a8b","unresolved":true,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Existing tests on keypair creation / import can be extended to include"},{"line_number":126,"context_line":"testing these special characters."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Documentation Impact"},{"line_number":129,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"69f84f38_6ef18890","line":127,"updated":"2021-04-09 17:30:21.000000000","message":"ya this can be tested with unit tests.\nwe could add a func test but unit test shoudl be enough in this case.","commit_id":"a4bdcd58af6808e283f2b6170152a4e01ee1a849"},{"author":{"_account_id":32637,"name":"Nicolas Parquet","email":"nicolas.parquet@gandi.net","username":"Nautik"},"change_message_id":"f1184af8e0576f67434c78a791a9eff2d9ca6065","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Existing tests on keypair creation / import can be extended to include"},{"line_number":126,"context_line":"testing these special characters."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Documentation Impact"},{"line_number":129,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"a410ae05_0bfd3519","line":127,"in_reply_to":"69f84f38_6ef18890","updated":"2021-04-20 09:40:38.000000000","message":"Modified to be more explicit.","commit_id":"a4bdcd58af6808e283f2b6170152a4e01ee1a849"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb55ac6daa6605be813b1dea95acb0dedfb01a8b","unresolved":true,"context_lines":[{"line_number":128,"context_line":"Documentation Impact"},{"line_number":129,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Could not find documentation explicitely explaining allowed characters, so None"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"References"},{"line_number":134,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"24dc0930_323d234d","line":131,"updated":"2021-04-09 17:30:21.000000000","message":"you could add docs for this\nproably in the api ref.\nhttps://docs.openstack.org/api-ref/compute/?expanded\u003dcreate-or-import-keypair-detail#create-or-import-keypair","commit_id":"a4bdcd58af6808e283f2b6170152a4e01ee1a849"},{"author":{"_account_id":32637,"name":"Nicolas Parquet","email":"nicolas.parquet@gandi.net","username":"Nautik"},"change_message_id":"f1184af8e0576f67434c78a791a9eff2d9ca6065","unresolved":false,"context_lines":[{"line_number":128,"context_line":"Documentation Impact"},{"line_number":129,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Could not find documentation explicitely explaining allowed characters, so None"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"References"},{"line_number":134,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6608730a_e68f4b7b","line":131,"in_reply_to":"24dc0930_323d234d","updated":"2021-04-20 09:40:38.000000000","message":"Thank you for pointing this out, I added it in the spec.","commit_id":"a4bdcd58af6808e283f2b6170152a4e01ee1a849"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2b4c7d00bd718fd1d5a09f4e4308785fa5540736","unresolved":true,"context_lines":[{"line_number":117,"context_line":"Work Items"},{"line_number":118,"context_line":"----------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"None"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Dependencies"},{"line_number":123,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"a05c28b2_32061274","line":120,"updated":"2021-05-04 15:37:52.000000000","message":"I think the only work item is to change the validation function to allow the new characters.","commit_id":"16fbb837d5f35ecfa9647c49ee94e6e0ee3bf616"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"28364a4f32c3462c23a642b11ff449812dd50bde","unresolved":true,"context_lines":[{"line_number":117,"context_line":"Work Items"},{"line_number":118,"context_line":"----------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"None"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Dependencies"},{"line_number":123,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"222cbfa1_a3d1160f","line":120,"in_reply_to":"a05c28b2_32061274","updated":"2021-05-04 16:46:05.000000000","message":"i agree although i am ok with leaving it blank in this case since its a trivial change.\n\n\"Modify the list of safe characters to add the ``@`` (at) and ``.`` (dot).\"","commit_id":"16fbb837d5f35ecfa9647c49ee94e6e0ee3bf616"}]}