)]}'
{"specs/xena/approved/cyborg-no-user-token.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bd6beb63a5ff4e5dea7cdb7b1285b2981a9917fa","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/cyborg-no-user-token"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Process no token info scenarios when call Cyborg api by cyborgclient."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfaaf60e_1fc152aa","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":69},"updated":"2021-04-20 12:01:23.000000000","message":"Add support for cyborg service credentials to create cyborg admin client instances.","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"3df285af0c2f92b732e13532ef16de3fae25ad20","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/cyborg-no-user-token"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Process no token info scenarios when call Cyborg api by cyborgclient."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3c75c7dd_52969dc7","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":69},"in_reply_to":"bfaaf60e_1fc152aa","updated":"2021-04-21 09:47:11.000000000","message":"Done","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bd6beb63a5ff4e5dea7cdb7b1285b2981a9917fa","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Nowadays, when we resume guest state with accelerator bound, we should pass"},{"line_number":19,"context_line":"the accel_info when the guest hard reboot, otherwise, the vm will lost"},{"line_number":20,"context_line":"connection with accelerator because the new vm xml not includes the"},{"line_number":21,"context_line":"accelerator hostdev."}],"source_content_type":"text/x-rst","patch_set":1,"id":"30bbc972_b59819a0","line":18,"range":{"start_line":18,"start_character":18,"end_line":18,"end_character":24},"updated":"2021-04-20 12:01:23.000000000","message":"resume in the context of guest state refers to the action of transtioning an instance form the suspended state to active. it is unrelated to reboot.","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"3df285af0c2f92b732e13532ef16de3fae25ad20","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Nowadays, when we resume guest state with accelerator bound, we should pass"},{"line_number":19,"context_line":"the accel_info when the guest hard reboot, otherwise, the vm will lost"},{"line_number":20,"context_line":"connection with accelerator because the new vm xml not includes the"},{"line_number":21,"context_line":"accelerator hostdev."}],"source_content_type":"text/x-rst","patch_set":1,"id":"35e89502_316a060d","line":18,"range":{"start_line":18,"start_character":18,"end_line":18,"end_character":24},"in_reply_to":"30bbc972_b59819a0","updated":"2021-04-21 09:47:11.000000000","message":"this is not the meaning of change instance from suspended state to active.\njust the function name at:\nhttps://review.opendev.org/c/openstack/nova/+/767273/1/nova/virt/libvirt/driver.py#3471","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bd6beb63a5ff4e5dea7cdb7b1285b2981a9917fa","unresolved":true,"context_lines":[{"line_number":19,"context_line":"the accel_info when the guest hard reboot, otherwise, the vm will lost"},{"line_number":20,"context_line":"connection with accelerator because the new vm xml not includes the"},{"line_number":21,"context_line":"accelerator hostdev."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In the process of getting accel info, we should add no user token auth to"},{"line_number":24,"context_line":"get Cyborg client by cyborg user password configured, or the VM will be set"},{"line_number":25,"context_line":"error because of lost communication with Cyborg."}],"source_content_type":"text/x-rst","patch_set":1,"id":"c3af04a9_facb515f","line":22,"updated":"2021-04-20 12:01:23.000000000","message":"you are combining your proposed solution here with the problem statement\n\n\"Today when a instance with a device profile request is rebooted accelerators\nare not attached to the instnace.\"\n\ni think that is the correct problem statement.","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"3df285af0c2f92b732e13532ef16de3fae25ad20","unresolved":false,"context_lines":[{"line_number":19,"context_line":"the accel_info when the guest hard reboot, otherwise, the vm will lost"},{"line_number":20,"context_line":"connection with accelerator because the new vm xml not includes the"},{"line_number":21,"context_line":"accelerator hostdev."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In the process of getting accel info, we should add no user token auth to"},{"line_number":24,"context_line":"get Cyborg client by cyborg user password configured, or the VM will be set"},{"line_number":25,"context_line":"error because of lost communication with Cyborg."}],"source_content_type":"text/x-rst","patch_set":1,"id":"0ac51952_c49bac38","line":22,"in_reply_to":"c3af04a9_facb515f","updated":"2021-04-21 09:47:11.000000000","message":"Done","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bd6beb63a5ff4e5dea7cdb7b1285b2981a9917fa","unresolved":true,"context_lines":[{"line_number":21,"context_line":"accelerator hostdev."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In the process of getting accel info, we should add no user token auth to"},{"line_number":24,"context_line":"get Cyborg client by cyborg user password configured, or the VM will be set"},{"line_number":25,"context_line":"error because of lost communication with Cyborg."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"So add user/project CONF with admin role at cyborg group, and when determine"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4832f5dd_4409b513","line":24,"range":{"start_line":24,"start_character":22,"end_line":24,"end_character":53},"updated":"2021-04-20 12:01:23.000000000","message":"technially we should be supporting all auth methods provide by keystoneauth\n\nso basic user and pasward auth\nhttps://opendev.org/openstack/keystoneauth/src/branch/master/keystoneauth1/tests/unit/identity/test_identity_v3.py#L260-L279\nis fine but more advanced types shold be supported too.\nhttps://opendev.org/openstack/keystoneauth/src/branch/master/keystoneauth1/tests/unit/identity/test_identity_v3.py#L436-L450\n\nthat is to say we should not explictly be adding username and password options to the cyborg section.\nwe should be enabling keystone auth to be used to define service credentails for cyborg interaction.\nthis would be similar to how we load the neutron credentials\n\nhttps://github.com/openstack/nova/blob/master/nova/network/neutron.py#L70-L88\n\nwe also should support the generic service user\n\nhttps://github.com/openstack/nova/blob/5cbb8413c76537d1e5382f19099e673988b299f6/nova/network/neutron.py#L205-L221\n\nbasically the pattern that we already user for cinder and neutron is that\nwhen we create an auth plugin then use that to generage a new client instnace \nwhich will invovle creating a new token and then use that client to make the approprate calls.\n\nso the simple get_client function in the cyborg module\n\nhttps://github.com/openstack/nova/blob/5cbb8413c76537d1e5382f19099e673988b299f6/nova/accelerator/cyborg.py#L58-L59\n\nshould be enhanced and the existing hardcoded authplugin \n\nhttps://github.com/openstack/nova/blob/5cbb8413c76537d1e5382f19099e673988b299f6/nova/accelerator/cyborg.py#L84-L85\n\nshould instead delegate to the service user as it does today or to the new admin credentials that we are adding.","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"3df285af0c2f92b732e13532ef16de3fae25ad20","unresolved":true,"context_lines":[{"line_number":21,"context_line":"accelerator hostdev."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In the process of getting accel info, we should add no user token auth to"},{"line_number":24,"context_line":"get Cyborg client by cyborg user password configured, or the VM will be set"},{"line_number":25,"context_line":"error because of lost communication with Cyborg."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"So add user/project CONF with admin role at cyborg group, and when determine"}],"source_content_type":"text/x-rst","patch_set":1,"id":"93e9ecb5_b1407ba6","line":24,"range":{"start_line":24,"start_character":22,"end_line":24,"end_character":53},"in_reply_to":"4832f5dd_4409b513","updated":"2021-04-21 09:47:11.000000000","message":"when exec nova compute period task and init work, nova compute service have no authetication to call other componets like cinder, neutron and cyborg, now we should add cyborg username and password to generate token to call cyborg api.","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bd6beb63a5ff4e5dea7cdb7b1285b2981a9917fa","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In the process of getting accel info, we should add no user token auth to"},{"line_number":24,"context_line":"get Cyborg client by cyborg user password configured, or the VM will be set"},{"line_number":25,"context_line":"error because of lost communication with Cyborg."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"So add user/project CONF with admin role at cyborg group, and when determine"},{"line_number":28,"context_line":"context is_admin and without token, do authenticaion with user/project info"}],"source_content_type":"text/x-rst","patch_set":1,"id":"10d1d3fc_f4c86458","line":25,"updated":"2021-04-20 12:01:23.000000000","message":"this paragraph and the next one are not part of the propblem statement you are suggesting a solution. is should be in Proposed changes","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"3df285af0c2f92b732e13532ef16de3fae25ad20","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In the process of getting accel info, we should add no user token auth to"},{"line_number":24,"context_line":"get Cyborg client by cyborg user password configured, or the VM will be set"},{"line_number":25,"context_line":"error because of lost communication with Cyborg."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"So add user/project CONF with admin role at cyborg group, and when determine"},{"line_number":28,"context_line":"context is_admin and without token, do authenticaion with user/project info"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ec026390_7fa1bd8e","line":25,"in_reply_to":"10d1d3fc_f4c86458","updated":"2021-04-21 09:47:11.000000000","message":"Done","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bd6beb63a5ff4e5dea7cdb7b1285b2981a9917fa","unresolved":true,"context_lines":[{"line_number":24,"context_line":"get Cyborg client by cyborg user password configured, or the VM will be set"},{"line_number":25,"context_line":"error because of lost communication with Cyborg."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"So add user/project CONF with admin role at cyborg group, and when determine"},{"line_number":28,"context_line":"context is_admin and without token, do authenticaion with user/project info"},{"line_number":29,"context_line":"to call cyborg api."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"51e1a11d_900353cb","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":56},"updated":"2021-04-20 12:01:23.000000000","message":"i do not understand why an admin role would be required in this case.\n\nis this for https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.resume_guests_state_on_host_boot\n\nfor a normal hard reboot in response to a user request we shoudl be able to use the users token to retrieve the ARQs since it is not an admin oonly api.\n\nhttps://docs.openstack.org/api-ref/accelerator/v2/index.html?expanded\u003dget-one-accelerator-request-detail#get-one-accelerator-request\nhttps://github.com/openstack/cyborg/blob/master/cyborg/api/controllers/v2/arqs.py#L170-L207\n\nalthough looking at cyborgs source code its not using policy in code for any endpoint other then device profiles so by default it should not require admin right for any other endpoint.","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"3df285af0c2f92b732e13532ef16de3fae25ad20","unresolved":true,"context_lines":[{"line_number":24,"context_line":"get Cyborg client by cyborg user password configured, or the VM will be set"},{"line_number":25,"context_line":"error because of lost communication with Cyborg."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"So add user/project CONF with admin role at cyborg group, and when determine"},{"line_number":28,"context_line":"context is_admin and without token, do authenticaion with user/project info"},{"line_number":29,"context_line":"to call cyborg api."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"714d3bc9_d835d07b","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":56},"in_reply_to":"51e1a11d_900353cb","updated":"2021-04-21 09:47:11.000000000","message":"it\u0027s not admin right, only for authentication to call api.","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bd6beb63a5ff4e5dea7cdb7b1285b2981a9917fa","unresolved":true,"context_lines":[{"line_number":25,"context_line":"error because of lost communication with Cyborg."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"So add user/project CONF with admin role at cyborg group, and when determine"},{"line_number":28,"context_line":"context is_admin and without token, do authenticaion with user/project info"},{"line_number":29,"context_line":"to call cyborg api."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ce84d066_bbf7c456","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":34},"updated":"2021-04-20 12:01:23.000000000","message":"how can you have an admin context without a token?\nif the vm reboot was triggred by an admin then the keystone context will have an admin token associated with it.\n\nif it was triggered by resume_guests_state_on_host_boot it should be using a non admin context as an admin context should not be required to retirve the ARQs although it would be required for retriving ARQs for other users which is why i assume we need an admin token in this case correct?","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"3df285af0c2f92b732e13532ef16de3fae25ad20","unresolved":false,"context_lines":[{"line_number":25,"context_line":"error because of lost communication with Cyborg."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"So add user/project CONF with admin role at cyborg group, and when determine"},{"line_number":28,"context_line":"context is_admin and without token, do authenticaion with user/project info"},{"line_number":29,"context_line":"to call cyborg api."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"0a952d4f_2677c0ed","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":34},"in_reply_to":"ce84d066_bbf7c456","updated":"2021-04-21 09:47:11.000000000","message":"yeah, triggered by resume_guests_state_on_host_boot to retirve the ARQs for other users, this is the main reason, sorry for not describing clearly.","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bd6beb63a5ff4e5dea7cdb7b1285b2981a9917fa","unresolved":true,"context_lines":[{"line_number":32,"context_line":"Use Cases"},{"line_number":33,"context_line":"---------"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"When we resume guest state with accelerator bound, we should pass the accel_info"},{"line_number":36,"context_line":"when the guest hard reboot. At this time to get accel_info from cyborg, nova"},{"line_number":37,"context_line":"call cyborg will fail with admin context which donot have token info."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"8642c752_45258a2e","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":14},"updated":"2021-04-20 12:01:23.000000000","message":"resume or reboot?\nsuspend is currently an unsupported operation\nhttps://github.com/openstack/nova/blob/master/api-guide/source/accelerator-support.rst\nso i think you ment rebooted.\n\nwith that said i dont think this paragraph is is written as a usecase.\na usecase should describe what you want to do not how you should do it.","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"3df285af0c2f92b732e13532ef16de3fae25ad20","unresolved":true,"context_lines":[{"line_number":32,"context_line":"Use Cases"},{"line_number":33,"context_line":"---------"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"When we resume guest state with accelerator bound, we should pass the accel_info"},{"line_number":36,"context_line":"when the guest hard reboot. At this time to get accel_info from cyborg, nova"},{"line_number":37,"context_line":"call cyborg will fail with admin context which donot have token info."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"eb270005_ff71e591","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":14},"in_reply_to":"8642c752_45258a2e","updated":"2021-04-21 09:47:11.000000000","message":"this is resume, just the function name at:\nhttps://review.opendev.org/c/openstack/nova/+/767273/1/nova/virt/libvirt/driver.py#3471","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bd6beb63a5ff4e5dea7cdb7b1285b2981a9917fa","unresolved":true,"context_lines":[{"line_number":35,"context_line":"When we resume guest state with accelerator bound, we should pass the accel_info"},{"line_number":36,"context_line":"when the guest hard reboot. At this time to get accel_info from cyborg, nova"},{"line_number":37,"context_line":"call cyborg will fail with admin context which donot have token info."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Proposed change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"38b715ef_9e32edc2","line":38,"updated":"2021-04-20 12:01:23.000000000","message":"As an operator, when i reboot a host and have ``[DEFAULT]/resume_guests_state_on_host_boot\u003dTrue``\ni would like my cyborg instance to retain access to there assigned accelerators.\n\nAs a user, i would like to be able to hard reboot a cyborg instance without loosing acess to its\nacclerators.\n\ni belive that this those are the two usecase you want to enable ?\nif so please replace the exising text with the 2 usecause above.","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"3df285af0c2f92b732e13532ef16de3fae25ad20","unresolved":true,"context_lines":[{"line_number":35,"context_line":"When we resume guest state with accelerator bound, we should pass the accel_info"},{"line_number":36,"context_line":"when the guest hard reboot. At this time to get accel_info from cyborg, nova"},{"line_number":37,"context_line":"call cyborg will fail with admin context which donot have token info."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Proposed change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"15fbb234_eff5f039","line":38,"in_reply_to":"38b715ef_9e32edc2","updated":"2021-04-21 09:47:11.000000000","message":"Right! This is host hard reboot, i am sorry.😞\nthe second case neednot enable as the user have certified token.","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bd6beb63a5ff4e5dea7cdb7b1285b2981a9917fa","unresolved":true,"context_lines":[{"line_number":39,"context_line":"Proposed change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Add Cyborg auth configuration in nova-cpu.conf."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"},{"line_number":45,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"610e87c9_5805cdaa","line":42,"range":{"start_line":42,"start_character":32,"end_line":42,"end_character":47},"updated":"2021-04-20 12:01:23.000000000","message":"nit: nova.conf\n\nnova-cpu.conf is a non default name we use in devstack to make it simpler to differentiate between what options are used by the compute agent and which are used by the control plan services.","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"3df285af0c2f92b732e13532ef16de3fae25ad20","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Proposed change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Add Cyborg auth configuration in nova-cpu.conf."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"},{"line_number":45,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"00348b86_53d918fc","line":42,"range":{"start_line":42,"start_character":32,"end_line":42,"end_character":47},"in_reply_to":"610e87c9_5805cdaa","updated":"2021-04-21 09:47:11.000000000","message":"Done","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bd6beb63a5ff4e5dea7cdb7b1285b2981a9917fa","unresolved":true,"context_lines":[{"line_number":44,"context_line":"Alternatives"},{"line_number":45,"context_line":"------------"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"None"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Data model impact"},{"line_number":50,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"72f878d8_215f15e0","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":4},"updated":"2021-04-20 12:01:23.000000000","message":"the existing cyborg clinets are created using the generic service user\nhttps://docs.openstack.org/nova/latest/configuration/config.html#service-user\nthat user could be configured with credentials that have the admin role for the cyborg service.\n\n\ngiven that we normally expect the service user to be a global admin i do not think that would be a bad alternitive, im not aginst adding cyborg credentials, but we should document a reason why this is not sufficient for your usecase.","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"3df285af0c2f92b732e13532ef16de3fae25ad20","unresolved":true,"context_lines":[{"line_number":44,"context_line":"Alternatives"},{"line_number":45,"context_line":"------------"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"None"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Data model impact"},{"line_number":50,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3c6f5647_74d995ec","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":4},"in_reply_to":"72f878d8_215f15e0","updated":"2021-04-21 09:47:11.000000000","message":"not sure the service user can work. if it works, we can use service user to call cyborg api.","commit_id":"e00b5eb624f6880be310376cb1d62c7a657fadeb"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b23d801407dbe1bb8b2ffab39068858ae675d1d2","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Today, if it was triggered by resume_guests_state_on_host_boot it should be"},{"line_number":20,"context_line":"using a non admin context as an admin context to retirve the ARQs although"},{"line_number":21,"context_line":"it would be required for retriving ARQs for other users."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"88ae8a1e_4f0f1dcb","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":55},"updated":"2021-05-25 14:34:40.000000000","message":"Is this what you mean?\n\nToday, if VM hard reboot is triggered by resume_guests_state_on_host_boot\u003dTrue during nova-compute, nova uses a non admin context to retrieve ARQs. Nova should you the cyborg service token to make such query instead.","commit_id":"4db9e5746461c7b371adf897032da543cca23cfe"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"89d396b9b5da5e825fe303358a0b10e049cdf943","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Today, if it was triggered by resume_guests_state_on_host_boot it should be"},{"line_number":20,"context_line":"using a non admin context as an admin context to retirve the ARQs although"},{"line_number":21,"context_line":"it would be required for retriving ARQs for other users."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"337978d3_417a23d4","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":55},"in_reply_to":"25672e39_448c0652","updated":"2021-05-26 01:56:33.000000000","message":"Good summary. Done.","commit_id":"4db9e5746461c7b371adf897032da543cca23cfe"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cee9224c77415eaa3fbdebc64e3ea779038384e0","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Today, if it was triggered by resume_guests_state_on_host_boot it should be"},{"line_number":20,"context_line":"using a non admin context as an admin context to retirve the ARQs although"},{"line_number":21,"context_line":"it would be required for retriving ARQs for other users."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"25672e39_448c0652","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":55},"in_reply_to":"88ae8a1e_4f0f1dcb","updated":"2021-05-25 15:04:21.000000000","message":"yes that is the current issue an a good summary","commit_id":"4db9e5746461c7b371adf897032da543cca23cfe"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b23d801407dbe1bb8b2ffab39068858ae675d1d2","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"As an operator, when I reboot a host and have"},{"line_number":27,"context_line":"``[DEFAULT]/resume_guests_state_on_host_boot\u003dTrue``"},{"line_number":28,"context_line":"I would like my cyborg instance to retain access to there assigned"},{"line_number":29,"context_line":"accelerators."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7175dd30_5375bea4","line":28,"range":{"start_line":28,"start_character":52,"end_line":28,"end_character":57},"updated":"2021-05-25 14:34:40.000000000","message":"their","commit_id":"4db9e5746461c7b371adf897032da543cca23cfe"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"89d396b9b5da5e825fe303358a0b10e049cdf943","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"As an operator, when I reboot a host and have"},{"line_number":27,"context_line":"``[DEFAULT]/resume_guests_state_on_host_boot\u003dTrue``"},{"line_number":28,"context_line":"I would like my cyborg instance to retain access to there assigned"},{"line_number":29,"context_line":"accelerators."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":4,"id":"00b85950_a868f76c","line":28,"range":{"start_line":28,"start_character":52,"end_line":28,"end_character":57},"in_reply_to":"7175dd30_5375bea4","updated":"2021-05-26 01:56:33.000000000","message":"Done","commit_id":"4db9e5746461c7b371adf897032da543cca23cfe"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b23d801407dbe1bb8b2ffab39068858ae675d1d2","unresolved":true,"context_lines":[{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Add Cyborg auth configuration in nova.conf."},{"line_number":35,"context_line":"Add Cyborg client generate for admin user with no token info."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fb56ca6a_6ab73fa1","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":60},"updated":"2021-05-25 14:34:40.000000000","message":"Sorry I cannot parse this. Do you mean: \n\nCreate a cyborg client with the service token for the hard reboot case.","commit_id":"4db9e5746461c7b371adf897032da543cca23cfe"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"89d396b9b5da5e825fe303358a0b10e049cdf943","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Add Cyborg auth configuration in nova.conf."},{"line_number":35,"context_line":"Add Cyborg client generate for admin user with no token info."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1df28331_7ce09159","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":60},"in_reply_to":"70a5387b_08c37e6e","updated":"2021-05-26 01:56:33.000000000","message":"Yes, this spec proposes to add support for creating cyborg admin client.","commit_id":"4db9e5746461c7b371adf897032da543cca23cfe"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cee9224c77415eaa3fbdebc64e3ea779038384e0","unresolved":true,"context_lines":[{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Add Cyborg auth configuration in nova.conf."},{"line_number":35,"context_line":"Add Cyborg client generate for admin user with no token info."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"70a5387b_08c37e6e","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":60},"in_reply_to":"fb56ca6a_6ab73fa1","updated":"2021-05-25 15:04:21.000000000","message":"i think they ment\n\nAdd supprot for create a cyborg admin client when no user\ntoken is present.","commit_id":"4db9e5746461c7b371adf897032da543cca23cfe"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b23d801407dbe1bb8b2ffab39068858ae675d1d2","unresolved":true,"context_lines":[{"line_number":105,"context_line":"----------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* Register Cyborg group conf."},{"line_number":108,"context_line":"* Add no user token when get Cyborg client."},{"line_number":109,"context_line":"* Add related tests."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"61387730_50f67b35","line":108,"updated":"2021-05-25 14:34:40.000000000","message":"This will make the cyborg client to use the new service user/pass from the conf?","commit_id":"4db9e5746461c7b371adf897032da543cca23cfe"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"89d396b9b5da5e825fe303358a0b10e049cdf943","unresolved":false,"context_lines":[{"line_number":105,"context_line":"----------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* Register Cyborg group conf."},{"line_number":108,"context_line":"* Add no user token when get Cyborg client."},{"line_number":109,"context_line":"* Add related tests."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"4ff3f4dd_3ae302db","line":108,"in_reply_to":"4f6e6ac6_6b553455","updated":"2021-05-26 01:56:33.000000000","message":"Yes, we will use the user/password from the conf file to genenrate the admin client.","commit_id":"4db9e5746461c7b371adf897032da543cca23cfe"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cee9224c77415eaa3fbdebc64e3ea779038384e0","unresolved":true,"context_lines":[{"line_number":105,"context_line":"----------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* Register Cyborg group conf."},{"line_number":108,"context_line":"* Add no user token when get Cyborg client."},{"line_number":109,"context_line":"* Add related tests."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"4f6e6ac6_6b553455","line":108,"in_reply_to":"61387730_50f67b35","updated":"2021-05-25 15:04:21.000000000","message":"they are refering to https://github.com/openstack/nova/blob/b0cd985f0c09088098f74cc0cb1df616cc0ef12b/nova/accelerator/cyborg.py#L58-L59\n\nextending nova.accelerator.cyborg.get_client to support admin tokens presumable by passing an admin\u003dTrue|False paramter which when true would load the auth info form teh conf.\n\nis this what was intended?\n\nthat description shoudl be put in the proposed change and here we just state\n\n* extend nova.accelerator.cyborg.get_client to create admin clients.","commit_id":"4db9e5746461c7b371adf897032da543cca23cfe"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"862d360c7ae835ac0535b99a844a39eee6b45642","unresolved":true,"context_lines":[{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Add Cyborg auth configuration in nova.conf."},{"line_number":35,"context_line":"Add supprot for create a cyborg admin client when no user token is present."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ec1a8086_91cb9ac5","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":11},"updated":"2021-05-26 11:32:46.000000000","message":"nit: support","commit_id":"039f00f892db61850fad1f8cd81edb781d6bfe5a"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"be68718b19bf1cb8eb55bbf137a703e141716214","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Add Cyborg auth configuration in nova.conf."},{"line_number":35,"context_line":"Add supprot for create a cyborg admin client when no user token is present."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"29a055be_7d7e79ba","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":11},"in_reply_to":"ec1a8086_91cb9ac5","updated":"2021-05-27 01:36:32.000000000","message":"Done","commit_id":"039f00f892db61850fad1f8cd81edb781d6bfe5a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a62db8443a3e85be520a9411cc60f9e7ef76c557","unresolved":true,"context_lines":[{"line_number":52,"context_line":"Security impact"},{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Introduce user information to obtain authentication, which"},{"line_number":56,"context_line":"will make Nova and Cyborg interaction more secure."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Notifications impact"},{"line_number":59,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1d432375_8f10ced7","line":56,"range":{"start_line":55,"start_character":53,"end_line":56,"end_character":50},"updated":"2021-05-26 11:35:22.000000000","message":"im not sure this is correct.\nit will infact make it less secure sicne we will not be useing a higher privladged token and the\ncyborg admin password will now be present on the compute node so if there was an  vm breakout or other vulnerability that allowed access to the host it would infact result in privldaged user names and password being avaiable that previously were not preent.\n\nso techinially this change makes it less secure in my view but not in a meaningful way.","commit_id":"039f00f892db61850fad1f8cd81edb781d6bfe5a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3f092f2c62269d1c720b5c36c84f1a7c42e06972","unresolved":true,"context_lines":[{"line_number":52,"context_line":"Security impact"},{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Introduce user information to obtain authentication, which"},{"line_number":56,"context_line":"will make Nova and Cyborg interaction more secure."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Notifications impact"},{"line_number":59,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"8672173a_170a8e29","line":56,"range":{"start_line":55,"start_character":53,"end_line":56,"end_character":50},"in_reply_to":"1d432375_8f10ced7","updated":"2021-05-26 11:44:02.000000000","message":"I agree. This is makes it less secure but it is an accepted compromise I think.","commit_id":"039f00f892db61850fad1f8cd81edb781d6bfe5a"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"be68718b19bf1cb8eb55bbf137a703e141716214","unresolved":true,"context_lines":[{"line_number":52,"context_line":"Security impact"},{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Introduce user information to obtain authentication, which"},{"line_number":56,"context_line":"will make Nova and Cyborg interaction more secure."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Notifications impact"},{"line_number":59,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"498515fe_84dbccb0","line":56,"range":{"start_line":55,"start_character":53,"end_line":56,"end_character":50},"in_reply_to":"8672173a_170a8e29","updated":"2021-05-27 01:36:32.000000000","message":"Agree, it\u0027s less secure. maybe we can config the encrypted password in the future.","commit_id":"039f00f892db61850fad1f8cd81edb781d6bfe5a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5aba017fd434dc985902fb66dd5409e1aa52f0ae","unresolved":true,"context_lines":[{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Introduce user information to obtain authentication, which will make Nova"},{"line_number":56,"context_line":"and Cyborg interaction less secure since we will not use a higher"},{"line_number":57,"context_line":"privladged token and the cyborg admin password will now be present on"},{"line_number":58,"context_line":"the compute node."},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"734a4f18_76349713","line":56,"range":{"start_line":56,"start_character":49,"end_line":56,"end_character":52},"updated":"2021-06-02 10:52:04.000000000","message":"now","commit_id":"00b6e00f4b54daa98f5323ccfa1e100684801cdc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"76395eab224037fb9ed1c5c7eee9e4db1da8bc7a","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Introduce user information to obtain authentication, which will make Nova"},{"line_number":56,"context_line":"and Cyborg interaction less secure since we will not use a higher"},{"line_number":57,"context_line":"privladged token and the cyborg admin password will now be present on"},{"line_number":58,"context_line":"the compute node."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"d8ce08f9_d80cac06","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":10},"updated":"2021-06-02 10:18:34.000000000","message":"nit: privileged","commit_id":"00b6e00f4b54daa98f5323ccfa1e100684801cdc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"09590fb22fb3ec72eecf9c47d8c739ceb72b8535","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Add no user token auth when get Cyborg client"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/cyborg-no-user-token"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add support for cyborg service credentials to create cyborg admin client"},{"line_number":14,"context_line":"instances."}],"source_content_type":"text/x-rst","patch_set":7,"id":"d8e4f4fa_7addc616","line":11,"updated":"2021-06-02 11:57:24.000000000","message":"Now I filed this bp as it was missing","commit_id":"3aa1374c261827a51a294d96708ffafc402ea207"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6a57d128a7779aba8ebad46a6e12a8010810c946","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Add no user token auth when get Cyborg client"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/cyborg-no-user-token"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add support for cyborg service credentials to create cyborg admin client"},{"line_number":14,"context_line":"instances."}],"source_content_type":"text/x-rst","patch_set":7,"id":"4854c376_3b4d1c43","line":11,"in_reply_to":"12a93598_62e5d034","updated":"2021-06-09 08:05:24.000000000","message":"OK. Fixed the spec up to point to the original bp and closed the my new bp.\n\nhttps://review.opendev.org/c/openstack/nova-specs/+/795493","commit_id":"3aa1374c261827a51a294d96708ffafc402ea207"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"66f6b294c687a41a819f8df167ef5f0d7992cdec","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Add no user token auth when get Cyborg client"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/cyborg-no-user-token"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add support for cyborg service credentials to create cyborg admin client"},{"line_number":14,"context_line":"instances."}],"source_content_type":"text/x-rst","patch_set":7,"id":"12a93598_62e5d034","line":11,"in_reply_to":"d8e4f4fa_7addc616","updated":"2021-06-03 05:40:25.000000000","message":"https://blueprints.launchpad.net/nova/+spec/cyborg-admin-user-client","commit_id":"3aa1374c261827a51a294d96708ffafc402ea207"}]}