)]}'
{"specs/xena/approved/unified-limits-nova.rst":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7201063c8facdace5401bbe7ce9d0e941f88c093","unresolved":true,"context_lines":[{"line_number":141,"context_line":"when the operator has migrated to unified limits, and the default will be"},{"line_number":142,"context_line":"to use the older quota system:"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"* ``quota.enforce_unified_limits \u003d False``"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"For further details on the transition, please see the update section of this"},{"line_number":147,"context_line":"specification. Note the new unified limits code will have a hard dependency"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4846dd42_bf542854","line":144,"range":{"start_line":144,"start_character":0,"end_line":144,"end_character":42},"updated":"2021-05-05 17:10:02.000000000","message":"Are we still going to do this or are we just going to use the:\n\n CONF.quota.driver \u003d\u003d nova.quota.UnifiedLimitsDriver\n\n?","commit_id":"a362ba4db7155d0fa84b0f2226d595d5d8888190"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0b904c53467c0434664e9b170c2498306da65098","unresolved":false,"context_lines":[{"line_number":141,"context_line":"when the operator has migrated to unified limits, and the default will be"},{"line_number":142,"context_line":"to use the older quota system:"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"* ``quota.enforce_unified_limits \u003d False``"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"For further details on the transition, please see the update section of this"},{"line_number":147,"context_line":"specification. Note the new unified limits code will have a hard dependency"}],"source_content_type":"text/x-rst","patch_set":1,"id":"520a2d16_2f26f56b","line":144,"range":{"start_line":144,"start_character":0,"end_line":144,"end_character":42},"in_reply_to":"0ac5e955_25583738","updated":"2021-06-07 13:04:23.000000000","message":"Done","commit_id":"a362ba4db7155d0fa84b0f2226d595d5d8888190"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"932d33d200b1e3b9c6f1f233ca65adcfc75f372c","unresolved":true,"context_lines":[{"line_number":141,"context_line":"when the operator has migrated to unified limits, and the default will be"},{"line_number":142,"context_line":"to use the older quota system:"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"* ``quota.enforce_unified_limits \u003d False``"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"For further details on the transition, please see the update section of this"},{"line_number":147,"context_line":"specification. Note the new unified limits code will have a hard dependency"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0ac5e955_25583738","line":144,"range":{"start_line":144,"start_character":0,"end_line":144,"end_character":42},"in_reply_to":"410678c5_ccba92d5","updated":"2021-06-07 10:55:48.000000000","message":"hmm, oops, I can fix that up.","commit_id":"a362ba4db7155d0fa84b0f2226d595d5d8888190"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b82ad59dd421ed2b7e532ab9abbea6b3a228148d","unresolved":true,"context_lines":[{"line_number":141,"context_line":"when the operator has migrated to unified limits, and the default will be"},{"line_number":142,"context_line":"to use the older quota system:"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"* ``quota.enforce_unified_limits \u003d False``"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"For further details on the transition, please see the update section of this"},{"line_number":147,"context_line":"specification. Note the new unified limits code will have a hard dependency"}],"source_content_type":"text/x-rst","patch_set":1,"id":"410678c5_ccba92d5","line":144,"range":{"start_line":144,"start_character":0,"end_line":144,"end_character":42},"in_reply_to":"4846dd42_bf542854","updated":"2021-05-26 16:20:52.000000000","message":"I think we\u0027re going with the driver now. The code seems the better source of truth. We could fix this in a follow-up?","commit_id":"a362ba4db7155d0fa84b0f2226d595d5d8888190"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7201063c8facdace5401bbe7ce9d0e941f88c093","unresolved":true,"context_lines":[{"line_number":199,"context_line":"------------------"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"Nova currently supports \"per user\" limits. They will no longer be supported"},{"line_number":202,"context_line":"when:  ``quota.enforce_unified_limits \u003d True``"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"There are no plans for migration tools, however it is expected that users"},{"line_number":205,"context_line":"that need a similar model can test out using the unified limits support for"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3b228dd8_dd8cc9dc","line":202,"updated":"2021-05-05 17:10:02.000000000","message":"Keypairs are an exception to this, yeah?","commit_id":"a362ba4db7155d0fa84b0f2226d595d5d8888190"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b82ad59dd421ed2b7e532ab9abbea6b3a228148d","unresolved":true,"context_lines":[{"line_number":199,"context_line":"------------------"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"Nova currently supports \"per user\" limits. They will no longer be supported"},{"line_number":202,"context_line":"when:  ``quota.enforce_unified_limits \u003d True``"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"There are no plans for migration tools, however it is expected that users"},{"line_number":205,"context_line":"that need a similar model can test out using the unified limits support for"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ddd3ed6a_ceba5321","line":202,"in_reply_to":"3b228dd8_dd8cc9dc","updated":"2021-05-26 16:20:52.000000000","message":"That would be my understanding, yes","commit_id":"a362ba4db7155d0fa84b0f2226d595d5d8888190"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0b904c53467c0434664e9b170c2498306da65098","unresolved":false,"context_lines":[{"line_number":199,"context_line":"------------------"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"Nova currently supports \"per user\" limits. They will no longer be supported"},{"line_number":202,"context_line":"when:  ``quota.enforce_unified_limits \u003d True``"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"There are no plans for migration tools, however it is expected that users"},{"line_number":205,"context_line":"that need a similar model can test out using the unified limits support for"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a50546d0_4a964b87","line":202,"in_reply_to":"ddd3ed6a_ceba5321","updated":"2021-06-07 13:04:23.000000000","message":"Well its not quite that simple. The limit will be in configuration, and global to each Nova API endpoint, but they will continue to be counted per user, just like metadata is counted per server. Let me add a note about that.","commit_id":"a362ba4db7155d0fa84b0f2226d595d5d8888190"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f7cc6d48382f622111cb17e9397aec823e18cd85","unresolved":true,"context_lines":[{"line_number":565,"context_line":"   * - Release Name"},{"line_number":566,"context_line":"     - Description"},{"line_number":567,"context_line":"   * - Victora"},{"line_number":568,"context_line":"     - Introduced"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5225683a_b7bafa55","line":568,"updated":"2021-05-10 14:54:09.000000000","message":"* - Xena\n  - Reproposed","commit_id":"a362ba4db7155d0fa84b0f2226d595d5d8888190"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0b904c53467c0434664e9b170c2498306da65098","unresolved":false,"context_lines":[{"line_number":565,"context_line":"   * - Release Name"},{"line_number":566,"context_line":"     - Description"},{"line_number":567,"context_line":"   * - Victora"},{"line_number":568,"context_line":"     - Introduced"}],"source_content_type":"text/x-rst","patch_set":1,"id":"31ef6ff8_48dc1054","line":568,"in_reply_to":"5225683a_b7bafa55","updated":"2021-06-07 13:04:23.000000000","message":"oops.","commit_id":"a362ba4db7155d0fa84b0f2226d595d5d8888190"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"751104e7fa15b51fb95092a68479ed7131c2c592","unresolved":true,"context_lines":[{"line_number":94,"context_line":"* ``server_group_members`` (counted per server group)"},{"line_number":95,"context_line":"* ``metadata_items`` (counted per server)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"The above are purely protecting database bloat (i.e to stop a denial"},{"line_number":98,"context_line":"of service attack that fills up the database). They are similar to the"},{"line_number":99,"context_line":"hardcoded limit of the number of tags you can attach to a server."},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"18aa0e94_4c1755fe","line":97,"range":{"start_line":97,"start_character":4,"end_line":97,"end_character":9},"updated":"2021-06-08 14:17:22.000000000","message":"nit: below","commit_id":"451b2c7e7196045be8b1f27410621f1034450ba9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c9469b8524cce6e32fe49a42687698298edc3e81","unresolved":false,"context_lines":[{"line_number":94,"context_line":"* ``server_group_members`` (counted per server group)"},{"line_number":95,"context_line":"* ``metadata_items`` (counted per server)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"The above are purely protecting database bloat (i.e to stop a denial"},{"line_number":98,"context_line":"of service attack that fills up the database). They are similar to the"},{"line_number":99,"context_line":"hardcoded limit of the number of tags you can attach to a server."},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"d074d2df_ae6a82c6","line":97,"range":{"start_line":97,"start_character":4,"end_line":97,"end_character":9},"in_reply_to":"18aa0e94_4c1755fe","updated":"2021-06-08 15:15:38.000000000","message":"This is correct as-is. He\u0027s referring to key_apirs, server_groups, server_group_members and metadata_items above.","commit_id":"451b2c7e7196045be8b1f27410621f1034450ba9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"751104e7fa15b51fb95092a68479ed7131c2c592","unresolved":true,"context_lines":[{"line_number":140,"context_line":"use of the existing quota driver sytem. The default will be unchanged,"},{"line_number":141,"context_line":"but operators can opt-into the new system in the following way:"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* ``[quota]driver\u003dnova.quota.UnifiedLimitsDriver``"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"For further details on the transition, please see the update section of this"},{"line_number":146,"context_line":"specification. Note the new unified limits code will have a hard dependency"}],"source_content_type":"text/x-rst","patch_set":2,"id":"828474b5_00e9b6ec","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":12},"updated":"2021-06-08 14:17:22.000000000","message":"micro-super-femto-nit : \u0027[quota]/driver\u0027 with a slash.","commit_id":"451b2c7e7196045be8b1f27410621f1034450ba9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c9469b8524cce6e32fe49a42687698298edc3e81","unresolved":false,"context_lines":[{"line_number":140,"context_line":"use of the existing quota driver sytem. The default will be unchanged,"},{"line_number":141,"context_line":"but operators can opt-into the new system in the following way:"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* ``[quota]driver\u003dnova.quota.UnifiedLimitsDriver``"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"For further details on the transition, please see the update section of this"},{"line_number":146,"context_line":"specification. Note the new unified limits code will have a hard dependency"}],"source_content_type":"text/x-rst","patch_set":2,"id":"644a59be_9d3fb9bd","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":12},"in_reply_to":"828474b5_00e9b6ec","updated":"2021-06-08 15:15:38.000000000","message":"disagree. The square brackets are already delimiting things here. This is simply an mriedem\u0027ism that _some_ people have clung to 😛","commit_id":"451b2c7e7196045be8b1f27410621f1034450ba9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"751104e7fa15b51fb95092a68479ed7131c2c592","unresolved":true,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* ``[quota]driver\u003dnova.quota.UnifiedLimitsDriver``"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"For further details on the transition, please see the update section of this"},{"line_number":146,"context_line":"specification. Note the new unified limits code will have a hard dependency"},{"line_number":147,"context_line":"on counting usage via placement; as such it will ignore the value of"},{"line_number":148,"context_line":"``CONF.quota.count_usage_from_placement``."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7ed1a45f_f42199fd","line":145,"range":{"start_line":145,"start_character":54,"end_line":145,"end_character":60},"updated":"2021-06-08 14:17:22.000000000","message":"nit: you could add some implicit hyperlink like `Upgrade Impact`_","commit_id":"451b2c7e7196045be8b1f27410621f1034450ba9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"751104e7fa15b51fb95092a68479ed7131c2c592","unresolved":true,"context_lines":[{"line_number":165,"context_line":"counting all the current resource usage using a callback we provide that makes"},{"line_number":166,"context_line":"use of placement to count the current resource usage."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Once resources are claimed in placement, we optionally recheck the limits"},{"line_number":169,"context_line":"to see if we were racing with other server builds to consume the last bits"},{"line_number":170,"context_line":"of available quota. The only change is using oslo.limit to do the recheck."},{"line_number":171,"context_line":"That is, we will still respect the config: `quota.recheck_quota`"}],"source_content_type":"text/x-rst","patch_set":2,"id":"70816595_8d8758f6","line":168,"range":{"start_line":168,"start_character":40,"end_line":168,"end_character":63},"updated":"2021-06-08 14:17:22.000000000","message":"where (I mean in which service) ? I guess this would be the responsibility of the nova-scheduler service as claims are done there but we had late old-fashioned claims in the compute service, hence the wording confusion.","commit_id":"451b2c7e7196045be8b1f27410621f1034450ba9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c9469b8524cce6e32fe49a42687698298edc3e81","unresolved":false,"context_lines":[{"line_number":165,"context_line":"counting all the current resource usage using a callback we provide that makes"},{"line_number":166,"context_line":"use of placement to count the current resource usage."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Once resources are claimed in placement, we optionally recheck the limits"},{"line_number":169,"context_line":"to see if we were racing with other server builds to consume the last bits"},{"line_number":170,"context_line":"of available quota. The only change is using oslo.limit to do the recheck."},{"line_number":171,"context_line":"That is, we will still respect the config: `quota.recheck_quota`"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d0aaf565_9319ac47","line":168,"range":{"start_line":168,"start_character":40,"end_line":168,"end_character":63},"in_reply_to":"70816595_8d8758f6","updated":"2021-06-08 15:15:38.000000000","message":"Ack","commit_id":"451b2c7e7196045be8b1f27410621f1034450ba9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"751104e7fa15b51fb95092a68479ed7131c2c592","unresolved":true,"context_lines":[{"line_number":169,"context_line":"to see if we were racing with other server builds to consume the last bits"},{"line_number":170,"context_line":"of available quota. The only change is using oslo.limit to do the recheck."},{"line_number":171,"context_line":"That is, we will still respect the config: `quota.recheck_quota`"},{"line_number":172,"context_line":"Note: we do the first check of limits in nova-api, and the recheck in"},{"line_number":173,"context_line":"nova-conductor after resource allocation in placement succeeds."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"It is a similar story with resize. Except in this case, we check that we can"},{"line_number":176,"context_line":"claim resources for both the new flavor and old flavor at the same time."}],"source_content_type":"text/x-rst","patch_set":2,"id":"77bc4311_ca3fd175","line":173,"range":{"start_line":172,"start_character":51,"end_line":173,"end_character":14},"updated":"2021-06-08 14:17:22.000000000","message":"later: whoops, OK, nevermind my L168 comment.","commit_id":"451b2c7e7196045be8b1f27410621f1034450ba9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c9469b8524cce6e32fe49a42687698298edc3e81","unresolved":false,"context_lines":[{"line_number":169,"context_line":"to see if we were racing with other server builds to consume the last bits"},{"line_number":170,"context_line":"of available quota. The only change is using oslo.limit to do the recheck."},{"line_number":171,"context_line":"That is, we will still respect the config: `quota.recheck_quota`"},{"line_number":172,"context_line":"Note: we do the first check of limits in nova-api, and the recheck in"},{"line_number":173,"context_line":"nova-conductor after resource allocation in placement succeeds."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"It is a similar story with resize. Except in this case, we check that we can"},{"line_number":176,"context_line":"claim resources for both the new flavor and old flavor at the same time."}],"source_content_type":"text/x-rst","patch_set":2,"id":"cf0575d2_806f20d7","line":173,"range":{"start_line":172,"start_character":51,"end_line":173,"end_character":14},"in_reply_to":"77bc4311_ca3fd175","updated":"2021-06-08 15:15:38.000000000","message":"Ack","commit_id":"451b2c7e7196045be8b1f27410621f1034450ba9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"751104e7fa15b51fb95092a68479ed7131c2c592","unresolved":true,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Should we choose to allow additional custom inventory entries"},{"line_number":189,"context_line":"from hypervisor based compute nodes, such as `{\u0027CUSTOM_GPU_V100\u0027:1}`"},{"line_number":190,"context_line":"we will be also be able to apply quotas on these resources."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"The oslo.limits library will likely add additional configuration options."},{"line_number":193,"context_line":"In particular, operators will need to specify the Nova API\u0027s endpoint uuid"}],"source_content_type":"text/x-rst","patch_set":2,"id":"48b415ba_cd11bb0e","line":190,"updated":"2021-06-08 14:17:22.000000000","message":"and that\u0027s cool. You mentioned custom resource class quotas implicitely with your example, no need to be explicitly saying this.","commit_id":"451b2c7e7196045be8b1f27410621f1034450ba9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c9469b8524cce6e32fe49a42687698298edc3e81","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Should we choose to allow additional custom inventory entries"},{"line_number":189,"context_line":"from hypervisor based compute nodes, such as `{\u0027CUSTOM_GPU_V100\u0027:1}`"},{"line_number":190,"context_line":"we will be also be able to apply quotas on these resources."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"The oslo.limits library will likely add additional configuration options."},{"line_number":193,"context_line":"In particular, operators will need to specify the Nova API\u0027s endpoint uuid"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d5e42013_3055e27b","line":190,"in_reply_to":"48b415ba_cd11bb0e","updated":"2021-06-08 15:15:38.000000000","message":"Ack","commit_id":"451b2c7e7196045be8b1f27410621f1034450ba9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"751104e7fa15b51fb95092a68479ed7131c2c592","unresolved":true,"context_lines":[{"line_number":204,"context_line":"that need a similar model can test out using the unified limits support for"},{"line_number":205,"context_line":"hierarchical limits, and report back on what could help others migrate."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Note: Keypairs will still have a max limit enforced, and that max limit"},{"line_number":208,"context_line":"will still be enforced per user. However, there will now only be a single"},{"line_number":209,"context_line":"global configuration value in Nova to set the max number of keypairs"},{"line_number":210,"context_line":"each user is allowed."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3e44b1f5_2ac1e813","line":207,"range":{"start_line":207,"start_character":0,"end_line":207,"end_character":5},"updated":"2021-06-08 14:17:22.000000000","message":"nit: well, keypairs are the only per-user quota resource from what you wrote above, so it\u0027s not really a note but just a rephrasing of the previous paragraph with the only example that applies to it.","commit_id":"451b2c7e7196045be8b1f27410621f1034450ba9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"751104e7fa15b51fb95092a68479ed7131c2c592","unresolved":true,"context_lines":[{"line_number":349,"context_line":"  We could extext the API to include a boolean to say if the limit has been"},{"line_number":350,"context_line":"  exceeded in the parent project, and as such the user is unable to consume"},{"line_number":351,"context_line":"  more resources even though their own usage is not over their own limits."},{"line_number":352,"context_line":"  We could consider extending the API to include the usage of the full tree"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"Migration to Unified Limits"},{"line_number":355,"context_line":"---------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4c179a6b_fda9e1ed","line":352,"updated":"2021-06-08 14:17:22.000000000","message":"all of this has already been approved earlier, I won\u0027t chime into it.","commit_id":"451b2c7e7196045be8b1f27410621f1034450ba9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"751104e7fa15b51fb95092a68479ed7131c2c592","unresolved":true,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"The setting ``quota.recheck_quota`` will be kept, and will be used in the same"},{"line_number":424,"context_line":"way with unified limits to avoid races when multiple instances are built at"},{"line_number":425,"context_line":"the same time."},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"Alternatives"},{"line_number":428,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"54aa9241_46331616","line":425,"updated":"2021-06-08 14:17:22.000000000","message":"ditto with my previous comment","commit_id":"451b2c7e7196045be8b1f27410621f1034450ba9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"751104e7fa15b51fb95092a68479ed7131c2c592","unresolved":true,"context_lines":[{"line_number":531,"context_line":"* Add calls to oslo_limits, guarded by config to enable it"},{"line_number":532,"context_line":"* Move quota APIs to proxy to Keystone when unified limit quotas enabled"},{"line_number":533,"context_line":"* Add tools to migrate default and tenant limits from Nova into Keystone"},{"line_number":534,"context_line":"* Upgrade checks to ensure above tooling is used"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"Dependencies"},{"line_number":537,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b689f21b_22864779","line":534,"updated":"2021-06-08 14:17:22.000000000","message":"++","commit_id":"451b2c7e7196045be8b1f27410621f1034450ba9"}]}