)]}'
{"specs/xena/approved/rework-security-group-retrieving.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"23e36a87077564369e10908d4ffd66a5c6f59216","unresolved":true,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Allow including @ and . (dot) characters in keypair name"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/rework-security-group-retrieving"}],"source_content_type":"text/x-rst","patch_set":1,"id":"47eaa47b_d8274879","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":56},"updated":"2021-05-18 14:39:15.000000000","message":"copy paste :)","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"96528910fcfe8c30a9eabd289d2ad1dcc0af3569","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Allow including @ and . (dot) characters in keypair name"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/rework-security-group-retrieving"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7040a8f8_5b499ee5","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":56},"in_reply_to":"47eaa47b_d8274879","updated":"2021-05-21 00:21:29.000000000","message":"Done","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"23e36a87077564369e10908d4ffd66a5c6f59216","unresolved":true,"context_lines":[{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Nova server details could be significantly slowed down if calling neutron"},{"line_number":17,"context_line":"plugin is used. The cause could be that retrieving security group id/name"},{"line_number":18,"context_line":"requires extra calls to neutron API and number of calls are linear to number"},{"line_number":19,"context_line":"of ports associated with instances divided by 100."}],"source_content_type":"text/x-rst","patch_set":1,"id":"c8d0aa06_07d2811b","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":19},"updated":"2021-05-18 14:39:15.000000000","message":"nit: Generating nova server details","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"96528910fcfe8c30a9eabd289d2ad1dcc0af3569","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Nova server details could be significantly slowed down if calling neutron"},{"line_number":17,"context_line":"plugin is used. The cause could be that retrieving security group id/name"},{"line_number":18,"context_line":"requires extra calls to neutron API and number of calls are linear to number"},{"line_number":19,"context_line":"of ports associated with instances divided by 100."}],"source_content_type":"text/x-rst","patch_set":1,"id":"2bc2fb24_1ec439ee","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":19},"in_reply_to":"c8d0aa06_07d2811b","updated":"2021-05-21 00:21:29.000000000","message":"Done","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"23e36a87077564369e10908d4ffd66a5c6f59216","unresolved":true,"context_lines":[{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Nova server details could be significantly slowed down if calling neutron"},{"line_number":17,"context_line":"plugin is used. The cause could be that retrieving security group id/name"},{"line_number":18,"context_line":"requires extra calls to neutron API and number of calls are linear to number"},{"line_number":19,"context_line":"of ports associated with instances divided by 100."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"827dad0c_368a7f7c","line":17,"range":{"start_line":16,"start_character":55,"end_line":17,"end_character":14},"updated":"2021-05-18 14:39:15.000000000","message":"nit: if neutron is used","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"96528910fcfe8c30a9eabd289d2ad1dcc0af3569","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Nova server details could be significantly slowed down if calling neutron"},{"line_number":17,"context_line":"plugin is used. The cause could be that retrieving security group id/name"},{"line_number":18,"context_line":"requires extra calls to neutron API and number of calls are linear to number"},{"line_number":19,"context_line":"of ports associated with instances divided by 100."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"19856368_da0e93cb","line":17,"range":{"start_line":16,"start_character":55,"end_line":17,"end_character":14},"in_reply_to":"827dad0c_368a7f7c","updated":"2021-05-21 00:21:29.000000000","message":"Done","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"23e36a87077564369e10908d4ffd66a5c6f59216","unresolved":true,"context_lines":[{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Add a new mircoversion and allow user to retrieve server detail list without"},{"line_number":35,"context_line":"security group."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Cache security group id in `info_cache`, so when directly retrieving security"},{"line_number":38,"context_line":"group from database without calling neutron API."}],"source_content_type":"text/x-rst","patch_set":1,"id":"33d30ea1_59ffd65d","line":35,"range":{"start_line":34,"start_character":69,"end_line":35,"end_character":15},"updated":"2021-05-18 14:39:15.000000000","message":"Please describe that the security group information is still available via the neutron API. The user can list the ports belonging to the nova server (i.e.$ openstack port list --server vm1) and then look at the security_group_ids of those ports.","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"96528910fcfe8c30a9eabd289d2ad1dcc0af3569","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Add a new mircoversion and allow user to retrieve server detail list without"},{"line_number":35,"context_line":"security group."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Cache security group id in `info_cache`, so when directly retrieving security"},{"line_number":38,"context_line":"group from database without calling neutron API."}],"source_content_type":"text/x-rst","patch_set":1,"id":"0fa8c2c7_7dda923d","line":35,"range":{"start_line":34,"start_character":69,"end_line":35,"end_character":15},"in_reply_to":"33d30ea1_59ffd65d","updated":"2021-05-21 00:21:29.000000000","message":"Done","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"23e36a87077564369e10908d4ffd66a5c6f59216","unresolved":true,"context_lines":[{"line_number":35,"context_line":"security group."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Cache security group id in `info_cache`, so when directly retrieving security"},{"line_number":38,"context_line":"group from database without calling neutron API."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Alternatives"},{"line_number":41,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c5287266_2387df3a","line":38,"updated":"2021-05-18 14:39:15.000000000","message":"Please add that this will be done to speed up the API when old microversion is used.","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"96528910fcfe8c30a9eabd289d2ad1dcc0af3569","unresolved":false,"context_lines":[{"line_number":35,"context_line":"security group."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Cache security group id in `info_cache`, so when directly retrieving security"},{"line_number":38,"context_line":"group from database without calling neutron API."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Alternatives"},{"line_number":41,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fe31d63e_e6f3027a","line":38,"in_reply_to":"245f3c18_ff0befef","updated":"2021-05-21 00:21:29.000000000","message":"Done","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0cea78840b20cd571b9853c9aefe29be35d0b393","unresolved":true,"context_lines":[{"line_number":35,"context_line":"security group."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Cache security group id in `info_cache`, so when directly retrieving security"},{"line_number":38,"context_line":"group from database without calling neutron API."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Alternatives"},{"line_number":41,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"245f3c18_ff0befef","line":38,"in_reply_to":"c5287266_2387df3a","updated":"2021-05-18 22:04:20.000000000","message":"yeah. for new microversion, APIs would not have sec group info at all.","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"23e36a87077564369e10908d4ffd66a5c6f59216","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"REST API impact"},{"line_number":51,"context_line":"---------------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Add a miroversion to stop returning security groups when using neutron"},{"line_number":54,"context_line":"network plugin."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a84735b_22ca4227","line":52,"updated":"2021-05-18 14:39:15.000000000","message":"Please list the affected APIs:\n\nGET /servers/details\nGET /servers/{server_uuid}\nPUT /servers/{server_uuid}\nPOST /servers/{server_id}/action where action is rebuild","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0cea78840b20cd571b9853c9aefe29be35d0b393","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"REST API impact"},{"line_number":51,"context_line":"---------------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Add a miroversion to stop returning security groups when using neutron"},{"line_number":54,"context_line":"network plugin."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dc539499_e5742859","line":52,"in_reply_to":"1a84735b_22ca4227","updated":"2021-05-18 22:04:20.000000000","message":"+1","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"96528910fcfe8c30a9eabd289d2ad1dcc0af3569","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"REST API impact"},{"line_number":51,"context_line":"---------------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Add a miroversion to stop returning security groups when using neutron"},{"line_number":54,"context_line":"network plugin."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1b424f08_315eda54","line":52,"in_reply_to":"dc539499_e5742859","updated":"2021-05-21 00:21:29.000000000","message":"Done","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"23e36a87077564369e10908d4ffd66a5c6f59216","unresolved":true,"context_lines":[{"line_number":51,"context_line":"---------------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Add a miroversion to stop returning security groups when using neutron"},{"line_number":54,"context_line":"network plugin."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Security impact"},{"line_number":57,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"efecc195_5a38e0d7","line":54,"updated":"2021-05-18 14:39:15.000000000","message":"What should we do with the GET /servers/{server_id}/os-security-groups ? I think we can keep it as is. But I can also accept if somebody says to drop it with the same reasoning, as it is a proxy API to neutron.","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0cea78840b20cd571b9853c9aefe29be35d0b393","unresolved":true,"context_lines":[{"line_number":51,"context_line":"---------------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Add a miroversion to stop returning security groups when using neutron"},{"line_number":54,"context_line":"network plugin."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Security impact"},{"line_number":57,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d80bff8a_02e4e4dd","line":54,"in_reply_to":"efecc195_5a38e0d7","updated":"2021-05-18 22:04:20.000000000","message":"yeah, that is proxy APIs but it is not dropped (dropped means for \u003e\u003d2.36 microversion and keep working for older microversion) in 2.36 where all other proxy APIs were.\n- https://github.com/openstack/nova/blob/82141b12c356fe374822038bdf0a6f0aaa32047b/nova/api/openstack/compute/security_groups.py#L375\n\nThis patch dropped other sec grp APIs but I could not find why GET /servers/{server_id}/os-security-groups is kept-  https://review.opendev.org/c/openstack/nova/+/333822\n\nI am fine to drop this in this microversion.","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"23e36a87077564369e10908d4ffd66a5c6f59216","unresolved":true,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Add a miroversion to stop returning security groups when using neutron"},{"line_number":54,"context_line":"network plugin."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Security impact"},{"line_number":57,"context_line":"---------------"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"b206cdfd_960bb41f","line":55,"updated":"2021-05-18 14:39:15.000000000","message":"What should we do with the POST /servers API? The POST /servers API allows specifying zero or more security group names when the server is created. And the response also has a security_groups field. \n\nI\u0027m not sure we can remove the security_groups from the server create request as that would be a major functionality loss, if the server is created with networks specified (instead of ports). But then it would be make sense to keep it in the response too.\n\nThis creates an asymmetry. The POST req/rsp will have security_groups while the rest of the server manipulation APIs will not have. I would like to see opinion from others about this as we missed this fact during the PTG.","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"96528910fcfe8c30a9eabd289d2ad1dcc0af3569","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Add a miroversion to stop returning security groups when using neutron"},{"line_number":54,"context_line":"network plugin."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Security impact"},{"line_number":57,"context_line":"---------------"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7c8e4130_ebb57d17","line":55,"in_reply_to":"6fde94cb_abd8e406","updated":"2021-05-21 00:21:29.000000000","message":"Done","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0cea78840b20cd571b9853c9aefe29be35d0b393","unresolved":true,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Add a miroversion to stop returning security groups when using neutron"},{"line_number":54,"context_line":"network plugin."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Security impact"},{"line_number":57,"context_line":"---------------"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"6fde94cb_abd8e406","line":55,"in_reply_to":"b206cdfd_960bb41f","updated":"2021-05-18 22:04:20.000000000","message":"This is good point. sec grp is POST /servers API is user requested functionality as you explained above and we return the same what was requested in response (we populate the response from request body itelf [1] though we do ask neutron about requested sec grp in server creation workflow.)\n\nreturning sec grps in GET APIs (actually proxy from neutron) is something API just return extra which can be fetched from neutron itself.\n\nIMO, we can leave POST/servers API as it is.\n\n[1] https://github.com/openstack/nova/blob/82141b12c356fe374822038bdf0a6f0aaa32047b/nova/api/openstack/compute/views/servers.py#L679","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0cea78840b20cd571b9853c9aefe29be35d0b393","unresolved":true,"context_lines":[{"line_number":66,"context_line":"Other end user impact"},{"line_number":67,"context_line":"---------------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"None"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Performance Impact"},{"line_number":72,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f74ee2f9_ba5c1b66","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":4},"updated":"2021-05-18 22:04:20.000000000","message":"with this end users need to fetch the sec grp from neutron for new microversion and cache data for older microversion so definitely this is end user impact.","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0cea78840b20cd571b9853c9aefe29be35d0b393","unresolved":true,"context_lines":[{"line_number":71,"context_line":"Performance Impact"},{"line_number":72,"context_line":"------------------"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"None"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Other deployer impact"},{"line_number":77,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fe00b12f_9458213f","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":4},"updated":"2021-05-18 22:04:20.000000000","message":"this is perf improvement so we should mention it here.","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"96528910fcfe8c30a9eabd289d2ad1dcc0af3569","unresolved":false,"context_lines":[{"line_number":71,"context_line":"Performance Impact"},{"line_number":72,"context_line":"------------------"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"None"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Other deployer impact"},{"line_number":77,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"cf080e76_4481931e","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":4},"in_reply_to":"fe00b12f_9458213f","updated":"2021-05-21 00:21:29.000000000","message":"Done","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"23e36a87077564369e10908d4ffd66a5c6f59216","unresolved":true,"context_lines":[{"line_number":103,"context_line":"Feature Liaison"},{"line_number":104,"context_line":"---------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Liaison Needed"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Work Items"},{"line_number":109,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"951904e8_9f9fd190","line":106,"updated":"2021-05-18 14:39:15.000000000","message":"just add me here I will try to help.","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0cea78840b20cd571b9853c9aefe29be35d0b393","unresolved":true,"context_lines":[{"line_number":103,"context_line":"Feature Liaison"},{"line_number":104,"context_line":"---------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Liaison Needed"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Work Items"},{"line_number":109,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"987b356a_3b7a498e","line":106,"in_reply_to":"951904e8_9f9fd190","updated":"2021-05-18 22:04:20.000000000","message":"add my name too.","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"96528910fcfe8c30a9eabd289d2ad1dcc0af3569","unresolved":false,"context_lines":[{"line_number":103,"context_line":"Feature Liaison"},{"line_number":104,"context_line":"---------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Liaison Needed"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Work Items"},{"line_number":109,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"77d3763c_e5668a60","line":106,"in_reply_to":"987b356a_3b7a498e","updated":"2021-05-21 00:21:29.000000000","message":"Done","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0cea78840b20cd571b9853c9aefe29be35d0b393","unresolved":true,"context_lines":[{"line_number":108,"context_line":"Work Items"},{"line_number":109,"context_line":"----------"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"None"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Dependencies"},{"line_number":114,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"51caa790_5bef98e7","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":4},"updated":"2021-05-18 22:04:20.000000000","message":"you can fill this with below:\n\n\n* API change to remove the security groups info from APIs mentioned in \u0027REST API impact\u0027 section\n* Cache security group id in `info_cache` and return cache sec grps for old microversion.\n* Unit and Functional tests\n* python-novaclient and osc change (? this is response field removal only so may be just updating the max version in client)","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"96528910fcfe8c30a9eabd289d2ad1dcc0af3569","unresolved":false,"context_lines":[{"line_number":108,"context_line":"Work Items"},{"line_number":109,"context_line":"----------"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"None"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Dependencies"},{"line_number":114,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ddf64cc_29a8151a","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":4},"in_reply_to":"51caa790_5bef98e7","updated":"2021-05-21 00:21:29.000000000","message":"Done","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"23e36a87077564369e10908d4ffd66a5c6f59216","unresolved":true,"context_lines":[{"line_number":118,"context_line":"Testing"},{"line_number":119,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Adding unit tests should be enough to test these special characters."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Documentation Impact"},{"line_number":124,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6523d009_f2f46c1e","line":121,"updated":"2021-05-18 14:39:15.000000000","message":"copy-paste","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"96528910fcfe8c30a9eabd289d2ad1dcc0af3569","unresolved":false,"context_lines":[{"line_number":118,"context_line":"Testing"},{"line_number":119,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Adding unit tests should be enough to test these special characters."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Documentation Impact"},{"line_number":124,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"63a73a11_22e1f55f","line":121,"in_reply_to":"22ffda18_5ea2dc2d","updated":"2021-05-21 00:21:29.000000000","message":"Done","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0cea78840b20cd571b9853c9aefe29be35d0b393","unresolved":true,"context_lines":[{"line_number":118,"context_line":"Testing"},{"line_number":119,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Adding unit tests should be enough to test these special characters."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Documentation Impact"},{"line_number":124,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"22ffda18_5ea2dc2d","line":121,"in_reply_to":"6523d009_f2f46c1e","updated":"2021-05-18 22:04:20.000000000","message":"API functional sample test also needed along with unit test.","commit_id":"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"84f50bbd8f3bdd34a13dfaf9ff5f72835a2a47e5","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Rework security group for server details"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3022fbe6_2bc23f50","line":7,"range":{"start_line":7,"start_character":40,"end_line":7,"end_character":56},"updated":"2021-05-26 00:46:11.000000000","message":"you can remove these extra lines","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"463a145fcd18f74573649149a41c2630074dd59c","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Rework security group for server details"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7560bd76_f8ea2a66","line":7,"range":{"start_line":7,"start_character":40,"end_line":7,"end_character":56},"in_reply_to":"3022fbe6_2bc23f50","updated":"2021-05-27 01:16:41.000000000","message":"Done","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"40ceace55276b4773d5aa09675675597d6dc7dbb","unresolved":true,"context_lines":[{"line_number":36,"context_line":"neutron API, for example"},{"line_number":37,"context_line":"`openstack port list --server ${VM_UUID} -c security_group_ids`"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Cache security group id in `info_cache`, so when directly retrieving security"},{"line_number":40,"context_line":"group from database without calling neutron API. This will hopefully speed up"},{"line_number":41,"context_line":"server detail query given that enough number of `info_cache` is populated"},{"line_number":42,"context_line":"with security group ids. Also note that, update bounded port will also cause"}],"source_content_type":"text/x-rst","patch_set":4,"id":"a18af244_c135d631","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":20},"updated":"2021-05-25 14:18:12.000000000","message":"For existing microversions cache security group...","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"84f50bbd8f3bdd34a13dfaf9ff5f72835a2a47e5","unresolved":true,"context_lines":[{"line_number":36,"context_line":"neutron API, for example"},{"line_number":37,"context_line":"`openstack port list --server ${VM_UUID} -c security_group_ids`"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Cache security group id in `info_cache`, so when directly retrieving security"},{"line_number":40,"context_line":"group from database without calling neutron API. This will hopefully speed up"},{"line_number":41,"context_line":"server detail query given that enough number of `info_cache` is populated"},{"line_number":42,"context_line":"with security group ids. Also note that, update bounded port will also cause"}],"source_content_type":"text/x-rst","patch_set":4,"id":"853a1669_68cf753f","line":39,"range":{"start_line":39,"start_character":21,"end_line":39,"end_character":24},"updated":"2021-05-26 00:46:11.000000000","message":"we need to cache sec group name which is what we return in GET server APIs. if we change that to id then it change the older microversion behavior.","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"463a145fcd18f74573649149a41c2630074dd59c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"neutron API, for example"},{"line_number":37,"context_line":"`openstack port list --server ${VM_UUID} -c security_group_ids`"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Cache security group id in `info_cache`, so when directly retrieving security"},{"line_number":40,"context_line":"group from database without calling neutron API. This will hopefully speed up"},{"line_number":41,"context_line":"server detail query given that enough number of `info_cache` is populated"},{"line_number":42,"context_line":"with security group ids. Also note that, update bounded port will also cause"}],"source_content_type":"text/x-rst","patch_set":4,"id":"b9cbb738_0620d59b","line":39,"range":{"start_line":39,"start_character":21,"end_line":39,"end_character":24},"in_reply_to":"853a1669_68cf753f","updated":"2021-05-27 01:16:41.000000000","message":"Done","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"463a145fcd18f74573649149a41c2630074dd59c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"neutron API, for example"},{"line_number":37,"context_line":"`openstack port list --server ${VM_UUID} -c security_group_ids`"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Cache security group id in `info_cache`, so when directly retrieving security"},{"line_number":40,"context_line":"group from database without calling neutron API. This will hopefully speed up"},{"line_number":41,"context_line":"server detail query given that enough number of `info_cache` is populated"},{"line_number":42,"context_line":"with security group ids. Also note that, update bounded port will also cause"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a6f9d68_d8832a79","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":20},"in_reply_to":"a18af244_c135d631","updated":"2021-05-27 01:16:41.000000000","message":"Done","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"a9fb1a47520862773bcab63f3b5fe33a8b1f9851","unresolved":true,"context_lines":[{"line_number":55,"context_line":"REST API impact"},{"line_number":56,"context_line":"---------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Add a miroversion to stop returning security groups when using neutron"},{"line_number":59,"context_line":"network plugin. In the meantime, also remove proxy APIs to query security"},{"line_number":60,"context_line":"groups, user should be able to use neutron API instead."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1cefc5a9_c60cbf4d","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":17},"updated":"2021-05-25 13:55:13.000000000","message":"nit, microversion","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"463a145fcd18f74573649149a41c2630074dd59c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"REST API impact"},{"line_number":56,"context_line":"---------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Add a miroversion to stop returning security groups when using neutron"},{"line_number":59,"context_line":"network plugin. In the meantime, also remove proxy APIs to query security"},{"line_number":60,"context_line":"groups, user should be able to use neutron API instead."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"87461a02_426a0437","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":17},"in_reply_to":"1cefc5a9_c60cbf4d","updated":"2021-05-27 01:16:41.000000000","message":"Done","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"40ceace55276b4773d5aa09675675597d6dc7dbb","unresolved":true,"context_lines":[{"line_number":59,"context_line":"network plugin. In the meantime, also remove proxy APIs to query security"},{"line_number":60,"context_line":"groups, user should be able to use neutron API instead."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* GET /servers/details"},{"line_number":63,"context_line":"* GET /servers/{server_uuid}"},{"line_number":64,"context_line":"* PUT /servers/{server_uuid}"},{"line_number":65,"context_line":"* POST /servers/{server_id}/action where action is rebuild"},{"line_number":66,"context_line":"* GET /servers/{server_id}/os-security-groups"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specifying security group when creating virtual machine will be untouched."}],"source_content_type":"text/x-rst","patch_set":4,"id":"e6ac2758_20874610","line":65,"range":{"start_line":62,"start_character":0,"end_line":65,"end_character":58},"updated":"2021-05-25 14:18:12.000000000","message":"Remove the security_groups filed from the APIs:\n\n* GET /servers/details\n* GET /servers/{server_uuid}\n* PUT /servers/{server_uuid}\n* POST /servers/{server_id}/action where action is rebuild","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"463a145fcd18f74573649149a41c2630074dd59c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"network plugin. In the meantime, also remove proxy APIs to query security"},{"line_number":60,"context_line":"groups, user should be able to use neutron API instead."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* GET /servers/details"},{"line_number":63,"context_line":"* GET /servers/{server_uuid}"},{"line_number":64,"context_line":"* PUT /servers/{server_uuid}"},{"line_number":65,"context_line":"* POST /servers/{server_id}/action where action is rebuild"},{"line_number":66,"context_line":"* GET /servers/{server_id}/os-security-groups"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specifying security group when creating virtual machine will be untouched."}],"source_content_type":"text/x-rst","patch_set":4,"id":"f8e7ba86_87382df4","line":65,"range":{"start_line":62,"start_character":0,"end_line":65,"end_character":58},"in_reply_to":"a3476b63_c5ca2626","updated":"2021-05-27 01:16:41.000000000","message":"Done","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"010d99016776bd95b69dffa837dc54678f50dcf1","unresolved":true,"context_lines":[{"line_number":59,"context_line":"network plugin. In the meantime, also remove proxy APIs to query security"},{"line_number":60,"context_line":"groups, user should be able to use neutron API instead."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* GET /servers/details"},{"line_number":63,"context_line":"* GET /servers/{server_uuid}"},{"line_number":64,"context_line":"* PUT /servers/{server_uuid}"},{"line_number":65,"context_line":"* POST /servers/{server_id}/action where action is rebuild"},{"line_number":66,"context_line":"* GET /servers/{server_id}/os-security-groups"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specifying security group when creating virtual machine will be untouched."}],"source_content_type":"text/x-rst","patch_set":4,"id":"a3476b63_c5ca2626","line":65,"range":{"start_line":62,"start_character":0,"end_line":65,"end_character":58},"in_reply_to":"e6ac2758_20874610","updated":"2021-05-26 15:02:40.000000000","message":"Can you format the URLs as ``literal`` also\n\n  * ``GET /servers/details``\n  * ``GET /servers/{server_uuid}``\n  ...","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"40ceace55276b4773d5aa09675675597d6dc7dbb","unresolved":true,"context_lines":[{"line_number":63,"context_line":"* GET /servers/{server_uuid}"},{"line_number":64,"context_line":"* PUT /servers/{server_uuid}"},{"line_number":65,"context_line":"* POST /servers/{server_id}/action where action is rebuild"},{"line_number":66,"context_line":"* GET /servers/{server_id}/os-security-groups"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specifying security group when creating virtual machine will be untouched."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"890cbaf6_099d9381","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":45},"updated":"2021-05-25 14:18:12.000000000","message":"Drop the whole API:\n\n* GET /servers/{server_id}/os-security-groups","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"010d99016776bd95b69dffa837dc54678f50dcf1","unresolved":true,"context_lines":[{"line_number":63,"context_line":"* GET /servers/{server_uuid}"},{"line_number":64,"context_line":"* PUT /servers/{server_uuid}"},{"line_number":65,"context_line":"* POST /servers/{server_id}/action where action is rebuild"},{"line_number":66,"context_line":"* GET /servers/{server_id}/os-security-groups"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specifying security group when creating virtual machine will be untouched."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"d31dc666_e39ce964","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":45},"in_reply_to":"78f3b07e_b8655ed0","updated":"2021-05-26 15:02:40.000000000","message":"What gmann said","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"84f50bbd8f3bdd34a13dfaf9ff5f72835a2a47e5","unresolved":true,"context_lines":[{"line_number":63,"context_line":"* GET /servers/{server_uuid}"},{"line_number":64,"context_line":"* PUT /servers/{server_uuid}"},{"line_number":65,"context_line":"* POST /servers/{server_id}/action where action is rebuild"},{"line_number":66,"context_line":"* GET /servers/{server_id}/os-security-groups"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specifying security group when creating virtual machine will be untouched."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"78f3b07e_b8655ed0","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":45},"in_reply_to":"890cbaf6_099d9381","updated":"2021-05-26 00:46:11.000000000","message":"Drop or we can say deprecate. or in better word\n\nDrop the below API for newer microversion but keep working for older microversion:\n\n* GET /servers/{server_id}/os-security-groups","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"463a145fcd18f74573649149a41c2630074dd59c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"* GET /servers/{server_uuid}"},{"line_number":64,"context_line":"* PUT /servers/{server_uuid}"},{"line_number":65,"context_line":"* POST /servers/{server_id}/action where action is rebuild"},{"line_number":66,"context_line":"* GET /servers/{server_id}/os-security-groups"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specifying security group when creating virtual machine will be untouched."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"2c71c559_87cc98a2","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":45},"in_reply_to":"d31dc666_e39ce964","updated":"2021-05-27 01:16:41.000000000","message":"Done","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"84f50bbd8f3bdd34a13dfaf9ff5f72835a2a47e5","unresolved":true,"context_lines":[{"line_number":65,"context_line":"* POST /servers/{server_id}/action where action is rebuild"},{"line_number":66,"context_line":"* GET /servers/{server_id}/os-security-groups"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specifying security group when creating virtual machine will be untouched."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Security impact"},{"line_number":71,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"cb0d99a1_c1637bd6","line":68,"range":{"start_line":68,"start_character":40,"end_line":68,"end_character":55},"updated":"2021-05-26 00:46:11.000000000","message":"server \n\nthat is what we refer VM in nova","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"010d99016776bd95b69dffa837dc54678f50dcf1","unresolved":true,"context_lines":[{"line_number":65,"context_line":"* POST /servers/{server_id}/action where action is rebuild"},{"line_number":66,"context_line":"* GET /servers/{server_id}/os-security-groups"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specifying security group when creating virtual machine will be untouched."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Security impact"},{"line_number":71,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"f54d7dc5_c5bd51bd","line":68,"range":{"start_line":68,"start_character":40,"end_line":68,"end_character":55},"in_reply_to":"cb0d99a1_c1637bd6","updated":"2021-05-26 15:02:40.000000000","message":"Let\u0027s reword this:\n\n  It will still be possible to specify a security group when creating an instance.\n  This behavior is not modified.","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"463a145fcd18f74573649149a41c2630074dd59c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"* POST /servers/{server_id}/action where action is rebuild"},{"line_number":66,"context_line":"* GET /servers/{server_id}/os-security-groups"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specifying security group when creating virtual machine will be untouched."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Security impact"},{"line_number":71,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"6a9614c7_8e82561b","line":68,"range":{"start_line":68,"start_character":40,"end_line":68,"end_character":55},"in_reply_to":"f54d7dc5_c5bd51bd","updated":"2021-05-27 01:16:41.000000000","message":"Done","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"40ceace55276b4773d5aa09675675597d6dc7dbb","unresolved":true,"context_lines":[{"line_number":80,"context_line":"Other end user impact"},{"line_number":81,"context_line":"---------------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Security group id will **always** be returned. before this change, user might"},{"line_number":84,"context_line":"see a mixture of security group id and security group name"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"With the new microversion, user will have to query neutorn API for"},{"line_number":87,"context_line":"security groups"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ab4c2da_febc3640","line":84,"range":{"start_line":83,"start_character":0,"end_line":84,"end_character":58},"updated":"2021-05-25 14:18:12.000000000","message":"Does this change effects existing microversions? Is it considered as a bugfix? Otherwise we cannot change existing microversions","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"84f50bbd8f3bdd34a13dfaf9ff5f72835a2a47e5","unresolved":true,"context_lines":[{"line_number":80,"context_line":"Other end user impact"},{"line_number":81,"context_line":"---------------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Security group id will **always** be returned. before this change, user might"},{"line_number":84,"context_line":"see a mixture of security group id and security group name"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"With the new microversion, user will have to query neutorn API for"},{"line_number":87,"context_line":"security groups"}],"source_content_type":"text/x-rst","patch_set":4,"id":"eeb6bdf2_dd767cf6","line":84,"range":{"start_line":83,"start_character":0,"end_line":84,"end_character":58},"in_reply_to":"1ab4c2da_febc3640","updated":"2021-05-26 00:46:11.000000000","message":"yeah, I am also confused with this line We need to cache sec grp name and return to keep older microversion unchanged.","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"463a145fcd18f74573649149a41c2630074dd59c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"Other end user impact"},{"line_number":81,"context_line":"---------------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Security group id will **always** be returned. before this change, user might"},{"line_number":84,"context_line":"see a mixture of security group id and security group name"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"With the new microversion, user will have to query neutorn API for"},{"line_number":87,"context_line":"security groups"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c1717b75_15251b0f","line":84,"range":{"start_line":83,"start_character":0,"end_line":84,"end_character":58},"in_reply_to":"d6f2d816_f3271550","updated":"2021-05-27 01:16:41.000000000","message":"Done","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"010d99016776bd95b69dffa837dc54678f50dcf1","unresolved":true,"context_lines":[{"line_number":80,"context_line":"Other end user impact"},{"line_number":81,"context_line":"---------------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Security group id will **always** be returned. before this change, user might"},{"line_number":84,"context_line":"see a mixture of security group id and security group name"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"With the new microversion, user will have to query neutorn API for"},{"line_number":87,"context_line":"security groups"}],"source_content_type":"text/x-rst","patch_set":4,"id":"d6f2d816_f3271550","line":84,"range":{"start_line":83,"start_character":0,"end_line":84,"end_character":58},"in_reply_to":"eeb6bdf2_dd767cf6","updated":"2021-05-26 15:02:40.000000000","message":"gmann caught this already above on line 39. The author is suggesting we always return the ID. Currently we only do that if the security group has no name. It wouldn\u0027t be a terrible change but it is a change and an unnecessary one at that.\n\n[1] https://github.com/openstack/nova/blob/b0cd985f0c09088098f74cc0cb1df616cc0ef12b/nova/network/security_group_api.py#L565-L566","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"a9fb1a47520862773bcab63f3b5fe33a8b1f9851","unresolved":true,"context_lines":[{"line_number":104,"context_line":"Upgrade impact"},{"line_number":105,"context_line":"--------------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"None"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Implementation"},{"line_number":110,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"cfb43756_8018464f","line":107,"updated":"2021-05-25 13:55:13.000000000","message":"the info_cache is refreshed at nova-compute, so when the update doesn\u0027t finished, you have to fallback to query neutron. So probably in the api layer, you should check if there is no security group info, then fallback to call the neutron.","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"463a145fcd18f74573649149a41c2630074dd59c","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Upgrade impact"},{"line_number":105,"context_line":"--------------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"None"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Implementation"},{"line_number":110,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"56831bfc_fb84967e","line":107,"in_reply_to":"cfb43756_8018464f","updated":"2021-05-27 01:16:41.000000000","message":"Done","commit_id":"3fe0713d9afd34921c2d01c5f3d28c7b363915e8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7a75194254f05530d927a242f4551447a7cf2a1b","unresolved":true,"context_lines":[{"line_number":87,"context_line":"Other end user impact"},{"line_number":88,"context_line":"---------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"With the new microversion, user will have to query neutorn API for"},{"line_number":91,"context_line":"security groups"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9af6732c_3aa0af80","line":90,"range":{"start_line":90,"start_character":51,"end_line":90,"end_character":58},"updated":"2021-06-10 14:10:35.000000000","message":"neutron","commit_id":"631b6902881e1d692e6fa119cc8a5feebfcf998e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"61ea91b61c26010ba8ce269accd5facdc9476d99","unresolved":true,"context_lines":[{"line_number":138,"context_line":"----------"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* API change to remove the security groups info for new microversion"},{"line_number":141,"context_line":"* Cache security group name in `info_cache`"},{"line_number":142,"context_line":"* Unit and Functional tests"},{"line_number":143,"context_line":"* python-novaclient and osc change"},{"line_number":144,"context_line":"    * add new microversion"}],"source_content_type":"text/x-rst","patch_set":6,"id":"59e69d52_2cf78a8a","line":141,"range":{"start_line":141,"start_character":2,"end_line":141,"end_character":43},"updated":"2021-06-02 09:54:12.000000000","message":"... for old microversion","commit_id":"631b6902881e1d692e6fa119cc8a5feebfcf998e"}]}