)]}'
{"id":"openstack%2Fnova-specs~791620","triplet_id":"openstack%2Fnova-specs~master~Iaa33cc561bcbeca78de9cf5c9f52745b87a32bc2","project":"openstack/nova-specs","branch":"master","topic":"change-791620-1","hashtags":[],"change_id":"Iaa33cc561bcbeca78de9cf5c9f52745b87a32bc2","subject":"Speed up server details","status":"MERGED","created":"2021-05-16 11:02:54.000000000","updated":"2021-06-10 14:24:17.000000000","submitted":"2021-06-10 14:22:02.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":56,"unresolved_comment_count":4,"has_review_started":true,"submission_id":"791620-change-791620-1","meta_rev_id":"312d0e48fdaccb33280ed72f6e00ce59e4a7c8d4","_number":791620,"virtual_id_number":791620,"owner":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-06-10 14:22:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2021-06-10 14:10:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-06-09 07:03:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":2,"date":"2021-06-09 22:24:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2021-06-10 14:10:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-16 11:17:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-18 14:39:15.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2021-05-18 14:39:15.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2021-05-18 14:39:15.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2021-05-25 13:55:13.000000000","updated_by":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"reviewer":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"state":"REVIEWER"}],"messages":[{"id":"f3fccaf2ea00611d4d0f59ab2025896cf37c959e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"date":"2021-05-16 11:02:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"278fb316519cf7d3a39de560cffc8f4cc15edf5a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-16 11:17:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/72325f00f9064370a8655ad0da5ffcf7 : SUCCESS in 8m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/20c69c02a1a240b3afe6e306abcc8fc7 : SUCCESS in 3m 31s","accounts_in_message":[],"_revision_number":1},{"id":"23e36a87077564369e10908d4ffd66a5c6f59216","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-05-18 14:39:15.000000000","message":"Patch Set 1: Code-Review-1\n\n(10 comments)\n\nThanks Norman for writing up a spec. I have couple of comments and open questions inline.","accounts_in_message":[],"_revision_number":1},{"id":"0cea78840b20cd571b9853c9aefe29be35d0b393","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-05-18 22:04:20.000000000","message":"Patch Set 1: Code-Review-1\n\n(9 comments)\n\nfew more things to fill in spec in addition to what gibi already pointed out. and my opinion on POST /servers and sec grp list APIs.","accounts_in_message":[],"_revision_number":1},{"id":"58ecf9f85275f262324ca719a4762f61a290e090","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"date":"2021-05-19 02:16:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"fb10c6fc18ef6e01c6fe9d301773f941bb4ce252","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-19 02:27:43.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4778d7ca857e4aa19b6a14ccd3557d1b : FAILURE in 4m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/db0b05b6095d4ddf8dd1461b88723dac : SUCCESS in 3m 38s\n\nWarning:\n  Job openstack-tox-docs: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path doc/source/specs/xena/approved/rework-security-group-retrieving.rst in the commit\u0027\n  Comments left for invalid file doc/source/specs/xena/approved/rework-security-group-retrieving.rst","accounts_in_message":[],"_revision_number":2},{"id":"b953709404ffc63f9596abe6e8861ea24d82d176","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"date":"2021-05-19 03:12:55.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"4d16454d191c360f3e07e931f66a17fb37f3d309","tag":"autogenerated:gerrit:setAssignee","author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"date":"2021-05-19 03:16:20.000000000","message":"Assignee added: norman shen \u003cyshxxsjt715@gmail.com\u003e","accounts_in_message":[],"_revision_number":3},{"id":"65fd76e62769c9bb82efc6547fcde136b8e2d7d9","tag":"autogenerated:gerrit:deleteAssignee","author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"date":"2021-05-19 03:24:01.000000000","message":"Assignee deleted: norman shen \u003cyshxxsjt715@gmail.com\u003e","accounts_in_message":[],"_revision_number":3},{"id":"b89402aaec7a4c7c6de46b7a74b7eecffa159754","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-19 03:24:04.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/45bb6df335964554a90d3fee1f04a1a1 : SUCCESS in 7m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b0505ff43d6d44a5abae5f0cb005ce79 : FAILURE in 3m 37s","accounts_in_message":[],"_revision_number":3},{"id":"a630eff3d45be7b8585df858b6dea9b261be243d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"date":"2021-05-19 03:37:58.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"73c737ab3bd08aa5f04571ea1de89b274d503837","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-19 03:52:47.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8c7af2e65bf94c2e88503179be9d5f7c : SUCCESS in 8m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2bf8756543904fd3b926de51adb80872 : SUCCESS in 3m 44s","accounts_in_message":[],"_revision_number":4},{"id":"96528910fcfe8c30a9eabd289d2ad1dcc0af3569","author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"date":"2021-05-21 00:21:29.000000000","message":"Patch Set 4:\n\n(11 comments)","accounts_in_message":[],"_revision_number":4},{"id":"a9fb1a47520862773bcab63f3b5fe33a8b1f9851","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2021-05-25 13:55:13.000000000","message":"Patch Set 4: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"40ceace55276b4773d5aa09675675597d6dc7dbb","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-05-25 14:18:12.000000000","message":"Patch Set 4: Code-Review-1\n\n(4 comments)\n\nCouple of style comments. The -1 is due to my question about changing how the old microversion behaves, i.e. it will return only ids instead of a mix of names and ids.","accounts_in_message":[],"_revision_number":4},{"id":"84f50bbd8f3bdd34a13dfaf9ff5f72835a2a47e5","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-05-26 00:46:11.000000000","message":"Patch Set 4: Code-Review-1\n\n(5 comments)","accounts_in_message":[],"_revision_number":4},{"id":"010d99016776bd95b69dffa837dc54678f50dcf1","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-05-26 15:02:40.000000000","message":"Patch Set 4: Code-Review-1\n\n(4 comments)\n\nGood idea. Couple of nits and you can\u0027t change from names to IDs for existing responses. Fix those and we\u0027re golden, IMO","accounts_in_message":[],"_revision_number":4},{"id":"8c352adb3de2772a731da41dfaab2febce28bf82","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"date":"2021-05-27 00:45:58.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"bbd5de33ada2a9138f1c52d75447bb900cf4d54f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-27 00:59:10.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4948a505c7374757806b26f63a1cdcfa : SUCCESS in 8m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/65dff9f0706541e389d7d85a79dee82b : SUCCESS in 4m 17s","accounts_in_message":[],"_revision_number":5},{"id":"ea04708b3e11d0fb4e9f98c22cbd98e88bb5123a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"date":"2021-05-27 01:15:25.000000000","message":"Uploaded patch set 6: Commit message was updated.","accounts_in_message":[],"_revision_number":6},{"id":"463a145fcd18f74573649149a41c2630074dd59c","author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"date":"2021-05-27 01:16:41.000000000","message":"Patch Set 5:\n\n(9 comments)\n\nthank you very much for the feedback. the original thought for caching security group\nid, although confusing, is to avoid extra call to security group ids, in the fear that \nit may cause other unexpected performance degrade.\n\nbesides, I am thinking returns security group id is more natural because neutron seems\nto allow security group having the same name..","accounts_in_message":[],"_revision_number":5},{"id":"991ed02110013220d1daac720ed6394992f7d618","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-27 01:23:45.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/59dc78421cb645a08c22a481e6929433 : SUCCESS in 7m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b852778af9ab41fc9a1c834ea2c9011f : SUCCESS in 3m 59s","accounts_in_message":[],"_revision_number":6},{"id":"61ea91b61c26010ba8ce269accd5facdc9476d99","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-06-02 09:54:12.000000000","message":"Patch Set 6: Code-Review+2\n\n(1 comment)\n\nLooks good to me.","accounts_in_message":[],"_revision_number":6},{"id":"3d1d7fd9c237b6fca0eccc3fd2c88a99430bebbb","author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"date":"2021-06-02 10:00:50.000000000","message":"Patch Set 6:\n\nI am doubting if caching security group is a good idea...\nwill extra serialization overhead makes the cpu even slower....","accounts_in_message":[],"_revision_number":6},{"id":"30409515b099a53ecccca6123a1c8b238fb43f3d","author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"date":"2021-06-02 10:02:15.000000000","message":"Patch Set 6:\n\nmoreover, notifications requires meta to be string values while new security groups will be string array which will cause problems for example, during upgrade...","accounts_in_message":[],"_revision_number":6},{"id":"b4ca6269a28c9319529ebece50d62bdc33c1034b","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-06-03 16:01:54.000000000","message":"Patch Set 6: -Code-Review\n\n\u003e Patch Set 6:\n\u003e \n\u003e I am doubting if caching security group is a good idea...\n\u003e will extra serialization overhead makes the cpu even slower....\n\nSo you say we should not add caching for the old microversion just drop the SG from the new microversion?","accounts_in_message":[],"_revision_number":6},{"id":"9b627c2e9ad9c09700c92626a99c833f51a7582a","author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"date":"2021-06-06 04:17:15.000000000","message":"Patch Set 6:\n\n\u003e Patch Set 6: -Code-Review\n\u003e \n\u003e \u003e Patch Set 6:\n\u003e \u003e \n\u003e \u003e I am doubting if caching security group is a good idea...\n\u003e \u003e will extra serialization overhead makes the cpu even slower....\n\u003e \n\u003e So you say we should not add caching for the old microversion just drop the SG from the new microversion?\n\nafter some basic testing (running serialization and deserialization in a roll 10,000,0000 times), it should save some time. but not as good as remove security groups completely. still need some further investigation though.","accounts_in_message":[],"_revision_number":6},{"id":"4fd56a8d604e9e6cc018c40d2d24baccb501533b","author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"date":"2021-06-06 04:18:17.000000000","message":"Patch Set 6:\n\n\u003e Patch Set 6:\n\u003e \n\u003e I am doubting if caching security group is a good idea...\n\u003e will extra serialization overhead makes the cpu even slower....\n\nI would like to recall this statement.... but apparently gerrit does not allow delete comments....","accounts_in_message":[],"_revision_number":6},{"id":"e68aad7fbf249b166601b694d3e19dce17807d55","author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"date":"2021-06-07 02:52:54.000000000","message":"Patch Set 6:\n\nI think caching security groups still works, apparently my demo code has a bug\nand after fixing it, server detail almost as fast as removing security groups\nfrom server detail.","accounts_in_message":[],"_revision_number":6},{"id":"fc605e96080a31267c00ca95d0fac6bf0d1179df","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-06-09 07:03:23.000000000","message":"Patch Set 6: Code-Review+2\n\n\u003e Patch Set 6:\n\u003e \n\u003e I think caching security groups still works, apparently my demo code has a bug\n\u003e and after fixing it, server detail almost as fast as removing security groups\n\u003e from server detail.\n\nThanks for the info. Then I\u0027m plugging back my +2","accounts_in_message":[],"_revision_number":6},{"id":"c02a4cefc9b2b72989e16c5611e5e203d2f7b23f","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-06-09 22:24:25.000000000","message":"Patch Set 6: Code-Review+2\n\nlgtm, thanks. leaving +W for stephenfin in case he has any comment on updated one.","accounts_in_message":[],"_revision_number":6},{"id":"7a75194254f05530d927a242f4551447a7cf2a1b","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-06-10 14:10:35.000000000","message":"Patch Set 6: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"7bfc747ee902139c3adc8119504e639bd6fe355f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-10 14:10:53.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"3d830957e290c83fe48a0519b81de8cad72bb2f6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-10 14:22:01.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8f772574d68f4cdda236e74e8089ab02 : SUCCESS in 9m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dab9a85f382f4f79bb5b391d2a3130e2 : SUCCESS in 5m 01s","accounts_in_message":[],"_revision_number":6},{"id":"970afc710deabb53e13e48f2d45555b3fb87c411","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-10 14:22:02.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":6},{"id":"312d0e48fdaccb33280ed72f6e00ce59e4a7c8d4","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-10 14:24:17.000000000","message":"Patch Set 6:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-specs https://zuul.opendev.org/t/openstack/build/a1bd8fc41d574b528f887e4ab4faff65 : SUCCESS in 1m 34s","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"631b6902881e1d692e6fa119cc8a5feebfcf998e","revisions":{"6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff":{"kind":"REWORK","_number":1,"created":"2021-05-16 11:02:54.000000000","uploader":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"ref":"refs/changes/20/791620/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/20/791620/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/1"}}},"commit":{"parents":[{"commit":"248cbfaba4cfbc6696786599ee9d7638f84fa386","subject":"Merge \"Adds spec for supporting @ and . in keypair name\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/248cbfaba4cfbc6696786599ee9d7638f84fa386"}]}],"author":{"name":"ushen","email":"yshxxsjt715@gmail.com","date":"2021-05-16 10:48:40.000000000","tz":480},"committer":{"name":"ushen","email":"yshxxsjt715@gmail.com","date":"2021-05-16 11:02:50.000000000","tz":480},"subject":"Speed up server details","message":"Speed up server details\n\nSpeed up server details by caching security group\nid in info_cache and also add a new microversion.\n\nChange-Id: Iaa33cc561bcbeca78de9cf5c9f52745b87a32bc2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/6d9e6de61dd14f25347ccf2f3f1a55ff1fcdfaff"}]},"branch":"refs/heads/master"},"354dd6551c5976067ad4bb95c6f11fe17cfb7fdf":{"kind":"REWORK","_number":2,"created":"2021-05-19 02:16:06.000000000","uploader":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"ref":"refs/changes/20/791620/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/20/791620/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/2"}}},"commit":{"parents":[{"commit":"248cbfaba4cfbc6696786599ee9d7638f84fa386","subject":"Merge \"Adds spec for supporting @ and . in keypair name\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/248cbfaba4cfbc6696786599ee9d7638f84fa386"}]}],"author":{"name":"ushen","email":"yshxxsjt715@gmail.com","date":"2021-05-16 10:48:40.000000000","tz":480},"committer":{"name":"shenjiatong","email":"yshxxsjt715@gmail.com","date":"2021-05-19 02:01:59.000000000","tz":480},"subject":"Speed up server details","message":"Speed up server details\n\nSpeed up server details by caching security group\nid in info_cache and also add a new microversion.\n\nChange-Id: Iaa33cc561bcbeca78de9cf5c9f52745b87a32bc2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/354dd6551c5976067ad4bb95c6f11fe17cfb7fdf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/354dd6551c5976067ad4bb95c6f11fe17cfb7fdf"}]},"branch":"refs/heads/master"},"87a505c76bf1f512ec7d9858b3a12517f1c3ca27":{"kind":"REWORK","_number":3,"created":"2021-05-19 03:12:55.000000000","uploader":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"ref":"refs/changes/20/791620/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/20/791620/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/3"}}},"commit":{"parents":[{"commit":"248cbfaba4cfbc6696786599ee9d7638f84fa386","subject":"Merge \"Adds spec for supporting @ and . in keypair name\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/248cbfaba4cfbc6696786599ee9d7638f84fa386"}]}],"author":{"name":"ushen","email":"yshxxsjt715@gmail.com","date":"2021-05-16 10:48:40.000000000","tz":480},"committer":{"name":"shenjiatong","email":"yshxxsjt715@gmail.com","date":"2021-05-19 03:08:35.000000000","tz":480},"subject":"Speed up server details","message":"Speed up server details\n\nSpeed up server details by caching security group\nid in info_cache and also add a new microversion.\n\nChange-Id: Iaa33cc561bcbeca78de9cf5c9f52745b87a32bc2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/87a505c76bf1f512ec7d9858b3a12517f1c3ca27"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/87a505c76bf1f512ec7d9858b3a12517f1c3ca27"}]},"branch":"refs/heads/master"},"3fe0713d9afd34921c2d01c5f3d28c7b363915e8":{"kind":"REWORK","_number":4,"created":"2021-05-19 03:37:58.000000000","uploader":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"ref":"refs/changes/20/791620/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/20/791620/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/4"}}},"commit":{"parents":[{"commit":"248cbfaba4cfbc6696786599ee9d7638f84fa386","subject":"Merge \"Adds spec for supporting @ and . in keypair name\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/248cbfaba4cfbc6696786599ee9d7638f84fa386"}]}],"author":{"name":"ushen","email":"yshxxsjt715@gmail.com","date":"2021-05-16 10:48:40.000000000","tz":480},"committer":{"name":"shenjiatong","email":"yshxxsjt715@gmail.com","date":"2021-05-19 03:32:20.000000000","tz":480},"subject":"Speed up server details","message":"Speed up server details\n\nSpeed up server details by caching security group\nid in info_cache and also add a new microversion.\n\nChange-Id: Iaa33cc561bcbeca78de9cf5c9f52745b87a32bc2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/3fe0713d9afd34921c2d01c5f3d28c7b363915e8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/3fe0713d9afd34921c2d01c5f3d28c7b363915e8"}]},"branch":"refs/heads/master"},"7a568d2e4c29b36798c22525a2c6537c768b4a85":{"kind":"REWORK","_number":5,"created":"2021-05-27 00:45:58.000000000","uploader":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"ref":"refs/changes/20/791620/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/20/791620/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/5"}}},"commit":{"parents":[{"commit":"248cbfaba4cfbc6696786599ee9d7638f84fa386","subject":"Merge \"Adds spec for supporting @ and . in keypair name\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/248cbfaba4cfbc6696786599ee9d7638f84fa386"}]}],"author":{"name":"ushen","email":"yshxxsjt715@gmail.com","date":"2021-05-16 10:48:40.000000000","tz":480},"committer":{"name":"shenjiatong","email":"yshxxsjt715@gmail.com","date":"2021-05-27 00:36:36.000000000","tz":480},"subject":"Speed up server details","message":"Speed up server details\n\nSpeed up server details by caching security group\nid in info_cache and also add a new microversion.\n\nChange-Id: Iaa33cc561bcbeca78de9cf5c9f52745b87a32bc2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/7a568d2e4c29b36798c22525a2c6537c768b4a85"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/7a568d2e4c29b36798c22525a2c6537c768b4a85"}]},"branch":"refs/heads/master"},"631b6902881e1d692e6fa119cc8a5feebfcf998e":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2021-05-27 01:15:25.000000000","uploader":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"ref":"refs/changes/20/791620/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/20/791620/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/20/791620/6"}}},"commit":{"parents":[{"commit":"248cbfaba4cfbc6696786599ee9d7638f84fa386","subject":"Merge \"Adds spec for supporting @ and . in keypair name\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/248cbfaba4cfbc6696786599ee9d7638f84fa386"}]}],"author":{"name":"ushen","email":"yshxxsjt715@gmail.com","date":"2021-05-16 10:48:40.000000000","tz":480},"committer":{"name":"shenjiatong","email":"yshxxsjt715@gmail.com","date":"2021-05-27 01:09:53.000000000","tz":480},"subject":"Speed up server details","message":"Speed up server details\n\nSpeed up server details by caching security group\nname in info_cache and also add a new microversion.\n\nChange-Id: Iaa33cc561bcbeca78de9cf5c9f52745b87a32bc2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/631b6902881e1d692e6fa119cc8a5feebfcf998e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/631b6902881e1d692e6fa119cc8a5feebfcf998e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}