)]}'
{"specs/xena/approved/add-attachmentId-to-responses-of-the-os-volume_attachments-api.rst":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"cfc8c4ab9a64c1564961fb39c9c9f0507192f1e4","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":".. note:: The ``id`` returned above responses is the id of Nova\u0027s block device"},{"line_number":74,"context_line":"          mapping record and not that of the volume attachment in Cinder."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"This renders the API useless in most volume attach troubleshooting scenarios,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"27854347_bb81ca70","line":73,"updated":"2021-06-04 13:34:58.000000000","message":"This is... confusing. Could we use this new microversion to rename the existing ID to something like block_device_mapping_id? Otherwise we\u0027re left with a volumeAttachment that has an \u0027id\u0027 field, and also an \u0027attachmentId\u0027 field, and it\u0027s not clear what represents what.","commit_id":"c0a6a8bb7f42086b3c5cf2d65e597deda2ec6acc"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"b1d6e8de61cfbd93eaa38095afe73f455b7a1be2","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":".. note:: The ``id`` returned above responses is the id of Nova\u0027s block device"},{"line_number":74,"context_line":"          mapping record and not that of the volume attachment in Cinder."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"This renders the API useless in most volume attach troubleshooting scenarios,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"30c3c341_64787662","line":73,"in_reply_to":"0a280fc1_ec746e2a","updated":"2021-06-04 18:18:19.000000000","message":"Out of curiosity, can we make the \u0027id\u0027 here equal to the Cinder attachment id, and thus avoid the need for the new \u0027attachmentId\u0027 field altogether?","commit_id":"c0a6a8bb7f42086b3c5cf2d65e597deda2ec6acc"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"4023cb45489f26fabc50ec23b7184e1b03f45aa3","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":".. note:: The ``id`` returned above responses is the id of Nova\u0027s block device"},{"line_number":74,"context_line":"          mapping record and not that of the volume attachment in Cinder."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"This renders the API useless in most volume attach troubleshooting scenarios,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"0a280fc1_ec746e2a","line":73,"in_reply_to":"1d473fda_7fc51f24","updated":"2021-06-04 13:59:31.000000000","message":"Right, I get that our resources usually have an id and/or a uuid, but I don\u0027t recall any other example where the resource is called \u0027foo\u0027, has an \u0027id\u0027 field, *and* a \u0027fooId\u0027 field. That\u0027s the part that I think could be clarified: volumeAttachment[\u0027id\u0027] and volumeAttachment[\u0027attachmentId\u0027] mean different things, and without being used to it or knowing the internals, it could be easy to confuse the two.\n\nAnyways, I\u0027m clearly not going to convince you of this, so I can remove my -1 :)","commit_id":"c0a6a8bb7f42086b3c5cf2d65e597deda2ec6acc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c9ff010f9cf020247a23a03598df272132b0016d","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":".. note:: The ``id`` returned above responses is the id of Nova\u0027s block device"},{"line_number":74,"context_line":"          mapping record and not that of the volume attachment in Cinder."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"This renders the API useless in most volume attach troubleshooting scenarios,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1d473fda_7fc51f24","line":73,"in_reply_to":"27854347_bb81ca70","updated":"2021-06-04 13:53:29.000000000","message":"Appreciate that it is confusing but I\u0027d rather not rename this from ``id``. We can easily call out in the docs that this is unique to the block device mapping record within Nova. It\u0027s also standard across most of our APIs to provide the index for a given resource (in this case block device mapping records) as the id.","commit_id":"c0a6a8bb7f42086b3c5cf2d65e597deda2ec6acc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"7ebed4ea94b76a551d2f6cea95759e6248d4f1db","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":".. note:: The ``id`` returned above responses is the id of Nova\u0027s block device"},{"line_number":74,"context_line":"          mapping record and not that of the volume attachment in Cinder."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"This renders the API useless in most volume attach troubleshooting scenarios,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"464369ec_eb784a3b","line":73,"in_reply_to":"30c3c341_64787662","updated":"2021-06-07 10:13:08.000000000","message":"I\u0027m also not a fan of this, having the BDM id is also useful IMHO, how about leaving id as it is and adding a duplicate BlockDeviceMappingId field to be explicit?","commit_id":"c0a6a8bb7f42086b3c5cf2d65e597deda2ec6acc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a5bbdf6b58be0869ba5fdd72d853e235d6a414df","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":".. note:: The ``id`` returned above responses is the id of Nova\u0027s block device"},{"line_number":74,"context_line":"          mapping record and not that of the volume attachment in Cinder."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"This renders the API useless in most volume attach troubleshooting scenarios,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"880a8eab_2a0ad120","line":73,"in_reply_to":"464369ec_eb784a3b","updated":"2021-08-18 23:48:14.000000000","message":"I am little confused, I do not think \u0027id\u0027 field return BlockDeviceMapping id it is always return as volumd_id - https://github.com/openstack/nova/blob/a6690e8a3e6e4b009fb821257170cf1bd06fab7d/nova/api/openstack/compute/volumes.py#L231\n\nI agree with Artom that either we should remove the id field or rename it to BlockDeviceMappingId and return \u0027id\u0027 of BlockDeviceMapping object.","commit_id":"c0a6a8bb7f42086b3c5cf2d65e597deda2ec6acc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c07748252936497595c7e145b9b103c0acb5b463","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Add attachmentId to responses of the os-volume_attachments API"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/example"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec aims to outline the use case for adding volume attachment ids to the"},{"line_number":14,"context_line":"responses of Nova\u0027s `os-volume_attachments APIs`__."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5d3124f7_5761e0a0","line":11,"updated":"2021-06-09 07:02:08.000000000","message":"please file a blueprint and reference it here and in the commit message for tracking.","commit_id":"89825aa34c0476f8d7629b90673f4f58d929500d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"e75935ee5a472219daf197c00754fc766907c4fb","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Add attachmentId to responses of the os-volume_attachments API"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/example"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec aims to outline the use case for adding volume attachment ids to the"},{"line_number":14,"context_line":"responses of Nova\u0027s `os-volume_attachments APIs`__."}],"source_content_type":"text/x-rst","patch_set":3,"id":"8d0e1064_ac9b2831","line":11,"in_reply_to":"5d3124f7_5761e0a0","updated":"2021-06-09 09:48:05.000000000","message":"Done","commit_id":"89825aa34c0476f8d7629b90673f4f58d929500d"}]}