)]}'
{"id":"openstack%2Fnova-specs~794799","triplet_id":"openstack%2Fnova-specs~master~Ifb3a14607faaebd2e63468e332089e4f1881e0a2","project":"openstack/nova-specs","branch":"master","hashtags":[],"change_id":"Ifb3a14607faaebd2e63468e332089e4f1881e0a2","subject":"Add attachmentId to responses of the os-volume_attachments API","status":"MERGED","created":"2021-06-04 12:45:31.000000000","updated":"2021-08-18 23:48:14.000000000","submitted":"2021-07-01 10:29:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":8,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"794799","meta_rev_id":"a5bbdf6b58be0869ba5fdd72d853e235d6a414df","_number":794799,"virtual_id_number":794799,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-07-01 10:29:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"recommended":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"all":[{"value":1,"date":"2021-06-18 13:38:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":2,"date":"2021-07-01 10:19:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":2,"date":"2021-06-09 10:46:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":1,"date":"2021-07-01 10:19:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-04 12:57:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-04 13:34:58.000000000","updated_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"reviewer":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"state":"REVIEWER"},{"updated":"2021-06-09 07:02:08.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2021-07-01 10:19:45.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2021-08-18 23:48:14.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"CC"}],"messages":[{"id":"42f76ccc19f501274c3b6d27b6ba3784aa96fce3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-06-04 12:45:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"beb4e94f87ce7a3ef233d9a2d01f0d112c5c59b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-06-04 12:47:53.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cb5d08fe4830096646f19e5e2b8a8b8ff083eaa3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-04 12:57:23.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f4081f1e4b58499dbc2ebbf2b222f2c3 : FAILURE in 7m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c41de421cc0a478189c12bdcb75bcad8 : SUCCESS in 4m 50s\n\nWarning:\n  Job openstack-tox-docs: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path doc/source/specs/xena/approved/add-attachmentId-to-responses-of-the-os-volume_attachments-api.rst in the commit\u0027\n  Comments left for invalid file doc/source/specs/xena/approved/add-attachmentId-to-responses-of-the-os-volume_attachments-api.rst","accounts_in_message":[],"_revision_number":2},{"id":"cfc8c4ab9a64c1564961fb39c9c9f0507192f1e4","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2021-06-04 13:34:58.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\n-1 for inline question visibility.","accounts_in_message":[],"_revision_number":2},{"id":"c9ff010f9cf020247a23a03598df272132b0016d","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-06-04 13:53:29.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4023cb45489f26fabc50ec23b7184e1b03f45aa3","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2021-06-04 13:59:31.000000000","message":"Patch Set 2: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b1d6e8de61cfbd93eaa38095afe73f455b7a1be2","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2021-06-04 18:18:19.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\n-1 for visibility, random suggestion inline.","accounts_in_message":[],"_revision_number":2},{"id":"7ebed4ea94b76a551d2f6cea95759e6248d4f1db","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-06-07 10:13:08.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"278be145ce410b3932b38a93021e5b4f563824ae","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2021-06-07 15:07:31.000000000","message":"Patch Set 2: Code-Review+1\n\nThe CI failure is legit, but assuming that\u0027ll get fixed I\u0027m +1 on this. I *still* think volumeAttachment having both an \u0027id\u0027 and an \u0027attachmentId\u0027 field to mean different things is super confusing, but I can\u0027t come up with a palatable solution, so I guess really explicit documentation will have to do.","accounts_in_message":[],"_revision_number":2},{"id":"bc96b86696cd49da72ce6d29f0da45aebd21a3ba","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-06-07 15:39:13.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Code-Review+1\n\u003e \n\u003e The CI failure is legit, but assuming that\u0027ll get fixed I\u0027m +1 on this. I *still* think volumeAttachment having both an \u0027id\u0027 and an \u0027attachmentId\u0027 field to mean different things is super confusing, but I can\u0027t come up with a palatable solution, so I guess really explicit documentation will have to do.\n\nThanks, weird about the error, fast-specs works but I guess docs is doing some additional validation of the JSON blobs? Anyway I\u0027ll take a look now.","accounts_in_message":[],"_revision_number":2},{"id":"5fcbefd0663b404b1b3370df99ff1971188b950d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-06-07 15:54:02.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"62eeac906aa180418f9eafb90c4fefa9df3b8af1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-07 16:09:44.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0d7af194383a462e9fcff50b0df50419 : SUCCESS in 10m 52s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/424810416cf9404ba5c2c85fb2749ac8 : SUCCESS in 4m 17s","accounts_in_message":[],"_revision_number":3},{"id":"6411050b057da66c5d98044ba8fa2146bf14aa04","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2021-06-07 16:34:07.000000000","message":"Patch Set 3: Code-Review+1\n\nSee previous note about volumeAttachment[\u0027id\u0027] and volumeAttachment[\u0027attachmentId\u0027] - but I don\u0027t have a better idea (that Lee can live with). Maybe someone else will come up with one :)","accounts_in_message":[],"_revision_number":3},{"id":"c07748252936497595c7e145b9b103c0acb5b463","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-06-09 07:02:08.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)\n\nThe proposal looks good to me. After you filed a bp and referenced in the spec I will +2 it.","accounts_in_message":[],"_revision_number":3},{"id":"e75935ee5a472219daf197c00754fc766907c4fb","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-06-09 09:48:05.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"7a65f5b204347642bc4094ab5cf53489ac1f7e93","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-06-09 09:49:41.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"b990c511e6a656623a8acb31339f4101cce11325","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-09 10:03:15.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d2bb005d55a0452dbf18033e3e18c4cd : SUCCESS in 8m 52s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0585ffd258c34c6a954d1b6aad25d4a5 : SUCCESS in 4m 32s","accounts_in_message":[],"_revision_number":4},{"id":"75973037d8cb2a0e37d4866e5b226998983bf432","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-06-09 10:46:40.000000000","message":"Patch Set 4: Code-Review+2\n\nAs promised :)","accounts_in_message":[],"_revision_number":4},{"id":"488793e93e4ee2ec765d31a79916da0a56100693","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2021-06-18 13:38:23.000000000","message":"Patch Set 4: Code-Review+1\n\nStill sad about the volumeAttachment[\u0027id\u0027] and volumeAttachment[\u0027attachmentId\u0027] confusion, and would ideally like for someone to come up with a less confusing API that\u0027s not a ton of work, but since so far no one (including me) has got anything, I\u0027m +1.","accounts_in_message":[],"_revision_number":4},{"id":"224fb85020a1eeb1d7bdd42d4ea08aec98a9f8a5","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2021-07-01 10:19:45.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\nsorry this took so long.\nthis makes a lot of sense to expose to me and i dont see any open question so +2+w from me","accounts_in_message":[],"_revision_number":4},{"id":"d9560265120bf45eb6d6ff27a45357cdc530a49d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-01 10:20:00.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"18f3afc074deed7cf2459c4cc4549e7fa535f13d","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2021-07-01 10:24:21.000000000","message":"Patch Set 4:\n\n\u003e Patch Set 4: Code-Review+1\n\u003e \n\u003e Still sad about the volumeAttachment[\u0027id\u0027] and volumeAttachment[\u0027attachmentId\u0027] confusion, and would ideally like for someone to come up with a less confusing API that\u0027s not a ton of work, but since so far no one (including me) has got anything, I\u0027m +1.\n\nwe coudl call it volumeAttachment[\u0027index\u0027] or volumeAttachment[\u0027internal_id\u0027] instead of volumeAttachment[\u0027id\u0027] but that feels like an api breakage for little benifit to me.\n\nif pepople think volumeAttachment[\u0027id\u0027] to volumeAttachment[\u0027internal_id\u0027] is a good idea i would be happy to do that in a follow up and include both changes in the same microversion to avoid the confusion that can be caused.\n\nvolumeAttachment[\u0027id\u0027] is just the pirmary key in the nova db i belive which normally is not exposed when we have a seperate uuid column but since this is kind of an internal data stucture i get ehy we exposed it in this case","accounts_in_message":[],"_revision_number":4},{"id":"89bb4373660c45939f46a2ec475b476971186e0b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-01 10:29:38.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e88a31ba7a464e0a9e9365f42633170a : SUCCESS in 8m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e3fa923268364a54b901b4d502fc0456 : SUCCESS in 4m 35s","accounts_in_message":[],"_revision_number":4},{"id":"bdfec09abac52d3cc2d8a56fdb4f5f509bf832ed","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-01 10:29:39.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"939fd12b24624ea03a4b136e40f320be38d76486","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-01 10:31:08.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-specs https://zuul.opendev.org/t/openstack/build/11a0582f480a4b02a5c9b384a2ed70be : SUCCESS in 1m 12s","accounts_in_message":[],"_revision_number":4},{"id":"a5bbdf6b58be0869ba5fdd72d853e235d6a414df","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-08-18 23:48:14.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"76c33047428ccb3d7573b22fffd93e609efa653c","revisions":{"219fc11a7835b7b541b9d3200b00330437b12a46":{"kind":"REWORK","_number":1,"created":"2021-06-04 12:45:31.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/99/794799/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/99/794799/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/99/794799/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/99/794799/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/99/794799/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/99/794799/1"}}},"commit":{"parents":[{"commit":"9cf1ed1100f8d2d57a94477c4bf70dfef5975670","subject":"Merge \"QoS minimum guaranteed packet rate\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/9cf1ed1100f8d2d57a94477c4bf70dfef5975670"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-04 12:43:47.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-04 12:44:07.000000000","tz":60},"subject":"Add attachmentId to responses of the os-volume_attachments API","message":"Add attachmentId to responses of the os-volume_attachments API\n\nA simple spec adding the id of Cinder volume attachments associated with\na given block device mapping record within Nova to the responses from\nthe os-volume_attachments API.\n\nChange-Id: Ifb3a14607faaebd2e63468e332089e4f1881e0a2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/219fc11a7835b7b541b9d3200b00330437b12a46"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/219fc11a7835b7b541b9d3200b00330437b12a46"}]},"branch":"refs/heads/master"},"c0a6a8bb7f42086b3c5cf2d65e597deda2ec6acc":{"kind":"REWORK","_number":2,"created":"2021-06-04 12:47:53.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/99/794799/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/99/794799/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/99/794799/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/99/794799/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/99/794799/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/99/794799/2"}}},"commit":{"parents":[{"commit":"9cf1ed1100f8d2d57a94477c4bf70dfef5975670","subject":"Merge \"QoS minimum guaranteed packet rate\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/9cf1ed1100f8d2d57a94477c4bf70dfef5975670"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-04 12:43:47.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-04 12:47:47.000000000","tz":60},"subject":"Add attachmentId to responses of the os-volume_attachments API","message":"Add attachmentId to responses of the os-volume_attachments API\n\nA simple spec adding the id of Cinder volume attachments associated with\na given block device mapping record within Nova to the responses from\nthe os-volume_attachments API.\n\nChange-Id: Ifb3a14607faaebd2e63468e332089e4f1881e0a2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/c0a6a8bb7f42086b3c5cf2d65e597deda2ec6acc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/c0a6a8bb7f42086b3c5cf2d65e597deda2ec6acc"}]},"branch":"refs/heads/master"},"89825aa34c0476f8d7629b90673f4f58d929500d":{"kind":"REWORK","_number":3,"created":"2021-06-07 15:54:02.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/99/794799/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/99/794799/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/99/794799/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/99/794799/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/99/794799/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/99/794799/3"}}},"commit":{"parents":[{"commit":"9cf1ed1100f8d2d57a94477c4bf70dfef5975670","subject":"Merge \"QoS minimum guaranteed packet rate\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/9cf1ed1100f8d2d57a94477c4bf70dfef5975670"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-04 12:43:47.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-07 15:53:24.000000000","tz":60},"subject":"Add attachmentId to responses of the os-volume_attachments API","message":"Add attachmentId to responses of the os-volume_attachments API\n\nA simple spec adding the id of Cinder volume attachments associated with\na given block device mapping record within Nova to the responses from\nthe os-volume_attachments API.\n\nChange-Id: Ifb3a14607faaebd2e63468e332089e4f1881e0a2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/89825aa34c0476f8d7629b90673f4f58d929500d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/89825aa34c0476f8d7629b90673f4f58d929500d"}]},"branch":"refs/heads/master"},"76c33047428ccb3d7573b22fffd93e609efa653c":{"kind":"REWORK","_number":4,"created":"2021-06-09 09:49:41.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/99/794799/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/99/794799/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/99/794799/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/99/794799/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/99/794799/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/99/794799/4"}}},"commit":{"parents":[{"commit":"451b2c7e7196045be8b1f27410621f1034450ba9","subject":"Re-propose Unified Limits in Nova","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/451b2c7e7196045be8b1f27410621f1034450ba9"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-04 12:43:47.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-06-09 09:47:55.000000000","tz":60},"subject":"Add attachmentId to responses of the os-volume_attachments API","message":"Add attachmentId to responses of the os-volume_attachments API\n\nA simple spec adding the id of Cinder volume attachments associated with\na given block device mapping record within Nova to the responses from\nthe os-volume_attachments API.\n\nChange-Id: Ifb3a14607faaebd2e63468e332089e4f1881e0a2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/76c33047428ccb3d7573b22fffd93e609efa653c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/76c33047428ccb3d7573b22fffd93e609efa653c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}