)]}'
{"specs/xena/approved/nova-manage-commands-to-update-libvirt-device-models.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5e502934dfd8dc8186a0590eea55848390114a5c","unresolved":true,"context_lines":[{"line_number":75,"context_line":"* ``hw_rng_model``"},{"line_number":76,"context_line":"* ``hw_scsi_model``"},{"line_number":77,"context_line":"* ``hw_video_model``"},{"line_number":78,"context_line":"* ``hw_vif_model``"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Provide nova-manage commands to update existing device buses and models"},{"line_number":81,"context_line":"-----------------------------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"967d3173_32779b04","line":78,"updated":"2021-07-07 13:07:29.000000000","message":"This looks pretty complete. There\u0027s also \u0027hw_floppy_bus\u0027 that\u0027s obviously mostly/entirely unused. There\u0027s also \u0027hw_tpm_version\u0027/\u0027hw_tpm_model\u0027 but I can\u0027t imagine support for either of these bring dropped nor do I know what the guest impact would be (they\u0027re mostly rather different things)","commit_id":"85ca28962007b54e4027bc34681eed28a2064531"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1b08faafbb84f1511f65312b349aed4743f5f276","unresolved":true,"context_lines":[{"line_number":75,"context_line":"* ``hw_rng_model``"},{"line_number":76,"context_line":"* ``hw_scsi_model``"},{"line_number":77,"context_line":"* ``hw_video_model``"},{"line_number":78,"context_line":"* ``hw_vif_model``"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Provide nova-manage commands to update existing device buses and models"},{"line_number":81,"context_line":"-----------------------------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b9110fe8_fc1e5cf4","line":78,"in_reply_to":"967d3173_32779b04","updated":"2021-07-07 14:41:52.000000000","message":"Happy to add ``hw_floppy_bus``, I can\u0027t imagine the tpm stuff will ever change that much but it\u0027s also valid to add I guess.","commit_id":"85ca28962007b54e4027bc34681eed28a2064531"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5e502934dfd8dc8186a0590eea55848390114a5c","unresolved":true,"context_lines":[{"line_number":83,"context_line":"With the bus and model types stored we can now provide commands to operators to"},{"line_number":84,"context_line":"inspect and update these per instance:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"``$ nova-manage libvirt device-model-list $instance``"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"``$ nova-manage libvirt device-model-show $instance $device``"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa513c00_586983cc","line":86,"range":{"start_line":86,"start_character":24,"end_line":86,"end_character":41},"updated":"2021-07-07 13:07:29.000000000","message":"A bus isn\u0027t a model though. Would it make sense to make this more generic, e.g. \u0027image-meta-list\u0027? We could return all known embedded image metadata properties but only allow updating of whitelisted keys (namely, what you listed above plus hw_machine_type)\n\nMight also be worth deprecating the machine-type-specific command, though that\u0027s by no means a necessity.","commit_id":"85ca28962007b54e4027bc34681eed28a2064531"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1b08faafbb84f1511f65312b349aed4743f5f276","unresolved":true,"context_lines":[{"line_number":83,"context_line":"With the bus and model types stored we can now provide commands to operators to"},{"line_number":84,"context_line":"inspect and update these per instance:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"``$ nova-manage libvirt device-model-list $instance``"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"``$ nova-manage libvirt device-model-show $instance $device``"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"0d1a2eeb_e1420af7","line":86,"range":{"start_line":86,"start_character":24,"end_line":86,"end_character":41},"in_reply_to":"fa513c00_586983cc","updated":"2021-07-07 14:41:52.000000000","message":"Yeah I had duplicate device-bus-$command commands but that seemed wasteful. \n\nI really don\u0027t mind what we call this I just wanted it to be generic to device buses and models only and I\u0027ve seen both used interchangeably now in a few places (like libosinfo etc). ``image-meta-list`` seems a little too generic unless we support stashing and updating everything. That\u0027s also something we\u0027ve spoken about in the past but that opens up a whole world of possibilities to bork things for operators.\n\nI\u0027d also rather not deprecate the machine type commands as there\u0027s specific logic in there for handling migrations between versions and types etc that I\u0027d rather not move.","commit_id":"85ca28962007b54e4027bc34681eed28a2064531"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5e502934dfd8dc8186a0590eea55848390114a5c","unresolved":true,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"``$ nova-manage libvirt device-model-show $instance $device``"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"``$ nova-manage libvirt device-model-update $instance $device $model``"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Alternatives"},{"line_number":93,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f5f22fb_8827eaaa","line":90,"updated":"2021-07-07 13:07:29.000000000","message":"What happens once this changes? The changes won\u0027t propagate until it\u0027s hard rebooted. Do we have any way to mark a guest as \"dirty\" or otherwise needing this hard reboot, or will we do the reboot automatically?","commit_id":"85ca28962007b54e4027bc34681eed28a2064531"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d4415c760e4a41863e44f47bd75bf4c9fc9a8355","unresolved":true,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"``$ nova-manage libvirt device-model-show $instance $device``"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"``$ nova-manage libvirt device-model-update $instance $device $model``"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Alternatives"},{"line_number":93,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"95357272_19e404da","line":90,"in_reply_to":"1f5f22fb_8827eaaa","updated":"2021-07-07 13:08:40.000000000","message":"We\u0027d probably want to block live migrations until this has happened, since I imagine (though need to verify) that this operation takes these metadata keys into account when updating the guest XML?","commit_id":"85ca28962007b54e4027bc34681eed28a2064531"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1b08faafbb84f1511f65312b349aed4743f5f276","unresolved":true,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"``$ nova-manage libvirt device-model-show $instance $device``"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"``$ nova-manage libvirt device-model-update $instance $device $model``"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Alternatives"},{"line_number":93,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0dedbd08_28bed5fa","line":90,"in_reply_to":"95357272_19e404da","updated":"2021-07-07 14:41:52.000000000","message":"I forgot to pad this out with some prerequisites such as the instance being SHUTOFF etc basically forcing the hard reboot (via power_on).\n\nI\u0027ll add this shortly.","commit_id":"85ca28962007b54e4027bc34681eed28a2064531"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5e502934dfd8dc8186a0590eea55848390114a5c","unresolved":true,"context_lines":[{"line_number":156,"context_line":"  lyarwood"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Other contributors:"},{"line_number":159,"context_line":"  \u003claunchpad-id or None\u003e"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Feature Liaison"},{"line_number":162,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2be6763c_2a1da5ed","line":159,"updated":"2021-07-07 13:07:29.000000000","message":"I can help with the code here during your PTO.\n\n  stephenfinucane\n\n(different Launchpad ID to IRC)","commit_id":"85ca28962007b54e4027bc34681eed28a2064531"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1b08faafbb84f1511f65312b349aed4743f5f276","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  lyarwood"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Other contributors:"},{"line_number":159,"context_line":"  \u003claunchpad-id or None\u003e"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Feature Liaison"},{"line_number":162,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"69c51af9_84c329a4","line":159,"in_reply_to":"2be6763c_2a1da5ed","updated":"2021-07-07 14:41:52.000000000","message":"ACK thanks, also PTO !\u003d sick leave, there will be no drinking of Mai Tai\u0027s on the beach /o\\","commit_id":"85ca28962007b54e4027bc34681eed28a2064531"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5e502934dfd8dc8186a0590eea55848390114a5c","unresolved":true,"context_lines":[{"line_number":167,"context_line":"Work Items"},{"line_number":168,"context_line":"----------"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"* Register existing device buses and models within system_metadata"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"* Provide nova-manage commands to update existing device buses and models"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"faf24fc2_9d0f8ed7","line":170,"range":{"start_line":170,"start_character":51,"end_line":170,"end_character":66},"updated":"2021-07-07 13:07:29.000000000","message":"nit: ``code``","commit_id":"85ca28962007b54e4027bc34681eed28a2064531"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1b08faafbb84f1511f65312b349aed4743f5f276","unresolved":false,"context_lines":[{"line_number":167,"context_line":"Work Items"},{"line_number":168,"context_line":"----------"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"* Register existing device buses and models within system_metadata"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"* Provide nova-manage commands to update existing device buses and models"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7bbbc409_87bc30ce","line":170,"range":{"start_line":170,"start_character":51,"end_line":170,"end_character":66},"in_reply_to":"faf24fc2_9d0f8ed7","updated":"2021-07-07 14:41:52.000000000","message":"Ack","commit_id":"85ca28962007b54e4027bc34681eed28a2064531"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e173c39d01a16ece92774bb34cf3ba6bc230b184","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Store and allow libvirt instance device buses and models to be updated"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/libvirt-device-bus-model-update"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"QEMU support for device buses and models can come and go dependent on the"},{"line_number":14,"context_line":"underlying instance machine type *and* QEMU version used within an environment."}],"source_content_type":"text/x-rst","patch_set":2,"id":"14e6eca2_ea6aeb27","line":11,"range":{"start_line":11,"start_character":44,"end_line":11,"end_character":52},"updated":"2021-07-09 11:57:21.000000000","message":"this should not be libvirt specific imo","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ab12080ca00c3591144ecfc98090e28e1955d9e0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Store and allow libvirt instance device buses and models to be updated"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/libvirt-device-bus-model-update"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"QEMU support for device buses and models can come and go dependent on the"},{"line_number":14,"context_line":"underlying instance machine type *and* QEMU version used within an environment."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5dfb26d0_89a3be5e","line":11,"range":{"start_line":11,"start_character":44,"end_line":11,"end_character":52},"in_reply_to":"14e6eca2_ea6aeb27","updated":"2021-07-09 12:44:07.000000000","message":"I appreciate that but I really want to keep this spec targeted at the libvirt specific bus and model updates.","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e173c39d01a16ece92774bb34cf3ba6bc230b184","unresolved":true,"context_lines":[{"line_number":34,"context_line":"host might suddenly invalidate the now stashed device bus or model image"},{"line_number":35,"context_line":"properties with no way of updating outside of a complete instance rebuild"},{"line_number":36,"context_line":"against a new image defining new image properties."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Additionally any changes to the defaults provided by libosinfo or the libvirt"},{"line_number":39,"context_line":"driver could result in unforeseen changes to existing instances. This has been"},{"line_number":40,"context_line":"encountered in the past as libosinfo assumes that libvirt domain definitions"}],"source_content_type":"text/x-rst","patch_set":2,"id":"cd733c05_a844d3c3","line":37,"updated":"2021-07-09 11:57:21.000000000","message":"yep prime example is if you had hw_disk_bus\u003dide but changed the machine_type to q35 in the nova.conf it would conflict\nand break the instance","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ab12080ca00c3591144ecfc98090e28e1955d9e0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"host might suddenly invalidate the now stashed device bus or model image"},{"line_number":35,"context_line":"properties with no way of updating outside of a complete instance rebuild"},{"line_number":36,"context_line":"against a new image defining new image properties."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Additionally any changes to the defaults provided by libosinfo or the libvirt"},{"line_number":39,"context_line":"driver could result in unforeseen changes to existing instances. This has been"},{"line_number":40,"context_line":"encountered in the past as libosinfo assumes that libvirt domain definitions"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d319ea7a_9fe1a9e8","line":37,"in_reply_to":"cd733c05_a844d3c3","updated":"2021-07-09 12:44:07.000000000","message":"Ack","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d05d5f0860c3a93f5e24ba37a228fc3abf42b8f0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"model types associated with an instance are stashed ensuring they remain"},{"line_number":63,"context_line":"stable during the lifetime of the instance. This already happens when these"},{"line_number":64,"context_line":"buses or models are defined by image properties so we only need to capture"},{"line_number":65,"context_line":"their value when these are not defined at either service startup or instance"},{"line_number":66,"context_line":"creation time."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"The following list of image properties outline the list of device buses and"}],"source_content_type":"text/x-rst","patch_set":2,"id":"821105a1_3ba37c50","line":65,"range":{"start_line":65,"start_character":42,"end_line":65,"end_character":64},"updated":"2021-07-09 11:24:40.000000000","message":"OK, so the upgrade case is covered by populating missing data during service startup.","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e173c39d01a16ece92774bb34cf3ba6bc230b184","unresolved":true,"context_lines":[{"line_number":77,"context_line":"* ``hw_scsi_model``"},{"line_number":78,"context_line":"* ``hw_video_model``"},{"line_number":79,"context_line":"* ``hw_vif_model``"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Provide nova-manage commands to update existing device buses and models"},{"line_number":82,"context_line":"-----------------------------------------------------------------------"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a0d61ac_c87585da","line":80,"updated":"2021-07-09 11:57:21.000000000","message":"while not a device model persay i think it would be nice to also record hw_firmware_type\nso that if we want to change to uefi boot as a default in the futrue this is already stored\n\nhw_vif_multiqueue_enabled  is in a similar state wheer while not a device model it does affect the device emulation directly allow addtional queue to be allcoated and we have had customers (psi) ask for a way to enabel this for all there exisitng vms without a rebuild.\n\nwe shoudl also include \n\nhw_input_bus since it descirbs how the pointer model is attached.\n\nos_secure_boot may also be desireable for the same reason as the firmware type.\nhw_video_ram may also want to be updatable after teh fact but a lower priorty we also have been asked to allow this to be tweaked.\n\nthat is my concervitive set of addtional filed although my actual preference is to recored\nall computeable image peropreties and allow overrided all that do not change resouce usage.\n\nso i woudl prefer to invert the reqtricion for updating and allow updating any image property expect a list of know image properties that we shoudl block. e.g. block numa change but allow people to populate os_distro","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ab12080ca00c3591144ecfc98090e28e1955d9e0","unresolved":false,"context_lines":[{"line_number":77,"context_line":"* ``hw_scsi_model``"},{"line_number":78,"context_line":"* ``hw_video_model``"},{"line_number":79,"context_line":"* ``hw_vif_model``"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Provide nova-manage commands to update existing device buses and models"},{"line_number":82,"context_line":"-----------------------------------------------------------------------"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"92b0672e_8faea59d","line":80,"in_reply_to":"7a0d61ac_c87585da","updated":"2021-07-09 12:44:07.000000000","message":"\u003e while not a device model persay i think it would be nice to also record hw_firmware_type\n\u003e so that if we want to change to uefi boot as a default in the futrue this is already stored\n\nAs above I\u0027m keeping this targeted at bus and model updates only.\n\n\u003e hw_vif_multiqueue_enabled  is in a similar state wheer while not a device model it does affect the device emulation directly allow addtional queue to be allcoated and we have had customers (psi) ask for a way to enabel this for all there exisitng vms without a rebuild.\n\u003e \n\u003e we shoudl also include \n\u003e \n\u003e hw_input_bus since it descirbs how the pointer model is attached.\n\nAh my bad I had the older hw_pointer_model.\n\n\u003e os_secure_boot may also be desireable for the same reason as the firmware type.\n\u003e hw_video_ram may also want to be updatable after teh fact but a lower priorty we also have been asked to allow this to be tweaked.\n\u003e \n\u003e that is my concervitive set of addtional filed although my actual preference is to recored\n\u003e all computeable image peropreties and allow overrided all that do not change resouce usage.\n\nAs above.\n\n\u003e so i woudl prefer to invert the reqtricion for updating and allow updating any image property expect a list of know image properties that we shoudl block. e.g. block numa change but allow people to populate os_distro\n\nYeah I\u0027m not going in that direction with this spec, limiting the scope to libvirt bus and model updates means we can offer better validation and command UX (IMHO). It\u0027s the same situation as the machine type commands in the last cycle.\n\nFeel free to propose some generic commands but I\u0027m sticking with this.","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"984dcbf6ea1a1da00a0b0b587c8a92e5564a256d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"* ``hw_scsi_model``"},{"line_number":78,"context_line":"* ``hw_video_model``"},{"line_number":79,"context_line":"* ``hw_vif_model``"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Provide nova-manage commands to update existing device buses and models"},{"line_number":82,"context_line":"-----------------------------------------------------------------------"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"f289944b_ed0ae326","line":80,"in_reply_to":"92b0672e_8faea59d","updated":"2021-07-09 13:29:55.000000000","message":"hw_pointer_model is tablet/trackpad or mouse\nbasically abosoltie postion vs relitive.\nhw_input_bus is usb or ps2\n\nso both are supported and both should be included as they provdie different things.\n\ni can propsoe a more generic spec but if i do ill be removeign your work and just using the new generic ones.\nthis is an incremenatl improvement over what we have today but honestly i know we are going to end up doing it again next cycle if we limit it.\n\ni guess ill just have to push forward with the recrate api  enhacnement next cycle if i ever get time to prototype that","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e173c39d01a16ece92774bb34cf3ba6bc230b184","unresolved":true,"context_lines":[{"line_number":84,"context_line":"With the bus and model types stored we can now provide commands to operators to"},{"line_number":85,"context_line":"inspect and update these per instance:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"``$ nova-manage libvirt device-model-list $instance``"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"List all stashed device buses and models for the instance."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"b7d1fae7_fd18411e","line":87,"range":{"start_line":87,"start_character":16,"end_line":87,"end_character":41},"updated":"2021-07-09 11:57:21.000000000","message":"image-property list","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbf50896ace62f303a4cfdd3a95f41d2e394eede","unresolved":true,"context_lines":[{"line_number":84,"context_line":"With the bus and model types stored we can now provide commands to operators to"},{"line_number":85,"context_line":"inspect and update these per instance:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"``$ nova-manage libvirt device-model-list $instance``"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"List all stashed device buses and models for the instance."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"c2f5b2ad_591e5f18","line":87,"range":{"start_line":87,"start_character":16,"end_line":87,"end_character":41},"in_reply_to":"5d1cdd91_a7baa519","updated":"2021-07-12 11:43:05.000000000","message":"i would be ok with that. if we initall just support the specific items noted by lee we could expand it later.\n\n``$ nova-manage image-property list``\n\nwould list all the keys we support\n\n\"nova-manage image-property show $instance [$property]\"\nthis would show the image proereist for an instance an optionally a singel value if property is specifed\n\n``nova-manage image-property set --property $name1\u003d$value1 --property $name2\u003d$value2 $instance  ``\n\nwould update the properteis potentially allowoing multiple to be updated at once.\ne.g. nova-manage image-property set --property hw_disk_bus\u003dscsi --property hw_scsi_model\u003dvirtio-scsi $instance\n\n\nif we just did that i would be happy to deferring expanding the list to another patch.","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c43e42dc425b9be5569fd3c13d2beec83d9d2df9","unresolved":true,"context_lines":[{"line_number":84,"context_line":"With the bus and model types stored we can now provide commands to operators to"},{"line_number":85,"context_line":"inspect and update these per instance:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"``$ nova-manage libvirt device-model-list $instance``"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"List all stashed device buses and models for the instance."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5d1cdd91_a7baa519","line":87,"range":{"start_line":87,"start_character":16,"end_line":87,"end_character":41},"in_reply_to":"9f991574_eb681482","updated":"2021-07-12 11:13:48.000000000","message":"I\u0027d also be in favor of this naming schema and suggested as much when we were doing the machine type work. To be clear, I just want the more generic command name. We can (and should) still limit operations to our specially selected list of device bus and device model-related options, meaning list will only list the libvirt\u0027y options that we can update, show will only allow you to show these options, and update will do option-specific validation. This just seems better than having to add yet another nova-manage command if/when we decide to expand the set further to handle the other non-bus/model options such as those that Sean has noted elsewhere here.","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ab12080ca00c3591144ecfc98090e28e1955d9e0","unresolved":false,"context_lines":[{"line_number":84,"context_line":"With the bus and model types stored we can now provide commands to operators to"},{"line_number":85,"context_line":"inspect and update these per instance:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"``$ nova-manage libvirt device-model-list $instance``"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"List all stashed device buses and models for the instance."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f991574_eb681482","line":87,"range":{"start_line":87,"start_character":16,"end_line":87,"end_character":41},"in_reply_to":"b7d1fae7_fd18411e","updated":"2021-07-09 12:44:07.000000000","message":"NACK.","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e173c39d01a16ece92774bb34cf3ba6bc230b184","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"List all stashed device buses and models for the instance."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"``$ nova-manage libvirt device-model-show $instance $device``"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Show a specific type stashed for a given device bus or model."},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"563a5609_2d4111c7","line":91,"range":{"start_line":91,"start_character":16,"end_line":91,"end_character":42},"updated":"2021-07-09 11:57:21.000000000","message":"image-property show","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ab12080ca00c3591144ecfc98090e28e1955d9e0","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"List all stashed device buses and models for the instance."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"``$ nova-manage libvirt device-model-show $instance $device``"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Show a specific type stashed for a given device bus or model."},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"d63122c6_aa005395","line":91,"range":{"start_line":91,"start_character":16,"end_line":91,"end_character":42},"in_reply_to":"563a5609_2d4111c7","updated":"2021-07-09 12:44:07.000000000","message":"NACK.","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e173c39d01a16ece92774bb34cf3ba6bc230b184","unresolved":true,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Show a specific type stashed for a given device bus or model."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"``$ nova-manage libvirt device-model-update $instance $device $model``"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Update the stashed type for a given bus or model. For this command however"},{"line_number":98,"context_line":"there are a few prerequisites to note."}],"source_content_type":"text/x-rst","patch_set":2,"id":"72a039ae_d5a6b6a3","line":95,"range":{"start_line":95,"start_character":16,"end_line":95,"end_character":43},"updated":"2021-07-09 11:57:21.000000000","message":"image-property set --property $name1\u003d$value1 --property $name2\u003d$value2 $instance  ``\n\nto allow multipel value to be updated at a time","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ab12080ca00c3591144ecfc98090e28e1955d9e0","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Show a specific type stashed for a given device bus or model."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"``$ nova-manage libvirt device-model-update $instance $device $model``"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Update the stashed type for a given bus or model. For this command however"},{"line_number":98,"context_line":"there are a few prerequisites to note."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5220750a_1ab0adad","line":95,"range":{"start_line":95,"start_character":16,"end_line":95,"end_character":43},"in_reply_to":"72a039ae_d5a6b6a3","updated":"2021-07-09 12:44:07.000000000","message":"NACK.","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e173c39d01a16ece92774bb34cf3ba6bc230b184","unresolved":true,"context_lines":[{"line_number":100,"context_line":"Prerequisites"},{"line_number":101,"context_line":"~~~~~~~~~~~~~"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"- The instance must be in a STOPPED vm_sate."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"- The provided type will be validated against the corresponding versioned"},{"line_number":106,"context_line":"  object feilds for the bus or model."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1952a72a_8da660c3","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":44},"updated":"2021-07-09 11:57:21.000000000","message":"i see. this is to avoid the hard reboot problem of knowing if the vm has been rebooted and to avoid breakages with live migration.\n\ncan i suggest widing this to include shelved/shelve_offloaded.","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ab12080ca00c3591144ecfc98090e28e1955d9e0","unresolved":false,"context_lines":[{"line_number":100,"context_line":"Prerequisites"},{"line_number":101,"context_line":"~~~~~~~~~~~~~"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"- The instance must be in a STOPPED vm_sate."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"- The provided type will be validated against the corresponding versioned"},{"line_number":106,"context_line":"  object feilds for the bus or model."}],"source_content_type":"text/x-rst","patch_set":2,"id":"18029a6a_0bfd59c5","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":44},"in_reply_to":"1952a72a_8da660c3","updated":"2021-07-09 12:44:07.000000000","message":"Ack","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d05d5f0860c3a93f5e24ba37a228fc3abf42b8f0","unresolved":true,"context_lines":[{"line_number":103,"context_line":"- The instance must be in a STOPPED vm_sate."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"- The provided type will be validated against the corresponding versioned"},{"line_number":106,"context_line":"  object feilds for the bus or model."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Once updated the user or admin can power on the instance, causing the"},{"line_number":109,"context_line":"underlying libvirt domain to be redefined using the new bus or model type."}],"source_content_type":"text/x-rst","patch_set":2,"id":"23d75f00_8f5d7d8b","line":106,"range":{"start_line":106,"start_character":9,"end_line":106,"end_character":15},"updated":"2021-07-09 11:24:40.000000000","message":"nit: fields","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ab12080ca00c3591144ecfc98090e28e1955d9e0","unresolved":false,"context_lines":[{"line_number":103,"context_line":"- The instance must be in a STOPPED vm_sate."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"- The provided type will be validated against the corresponding versioned"},{"line_number":106,"context_line":"  object feilds for the bus or model."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Once updated the user or admin can power on the instance, causing the"},{"line_number":109,"context_line":"underlying libvirt domain to be redefined using the new bus or model type."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7469bf58_ce642e40","line":106,"range":{"start_line":106,"start_character":9,"end_line":106,"end_character":15},"in_reply_to":"23d75f00_8f5d7d8b","updated":"2021-07-09 12:44:07.000000000","message":"Ack","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d05d5f0860c3a93f5e24ba37a228fc3abf42b8f0","unresolved":false,"context_lines":[{"line_number":106,"context_line":"  object feilds for the bus or model."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Once updated the user or admin can power on the instance, causing the"},{"line_number":109,"context_line":"underlying libvirt domain to be redefined using the new bus or model type."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Alternatives"},{"line_number":112,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"69b2e889_cd730fba","line":109,"updated":"2021-07-09 11:24:40.000000000","message":"This checks out. power on will call hard_reboot, and hard reboot will cause the domain to be redefined.","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e173c39d01a16ece92774bb34cf3ba6bc230b184","unresolved":true,"context_lines":[{"line_number":111,"context_line":"Alternatives"},{"line_number":112,"context_line":"------------"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"None, other than providing a generic API to allow stashed image properties to"},{"line_number":115,"context_line":"be updated by users over time without requiring a rebuild but that\u0027s out of"},{"line_number":116,"context_line":"scope for this basic nova-manage command spec."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Data model impact"},{"line_number":119,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"cd723cd3_bdf52797","line":116,"range":{"start_line":114,"start_character":0,"end_line":116,"end_character":46},"updated":"2021-07-09 11:57:21.000000000","message":"well we should do this eventually and its on our todo list but i think this approch is fine in the short term. long term i do belive we need a recreate api as i have siad in the past.\n\nwe have agreed that i need to write a spec to extend resize to provide the recreate fuctionality in general and to defer the image propty update for now but this would be workable.","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ab12080ca00c3591144ecfc98090e28e1955d9e0","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Alternatives"},{"line_number":112,"context_line":"------------"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"None, other than providing a generic API to allow stashed image properties to"},{"line_number":115,"context_line":"be updated by users over time without requiring a rebuild but that\u0027s out of"},{"line_number":116,"context_line":"scope for this basic nova-manage command spec."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Data model impact"},{"line_number":119,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"40ad054e_6ceb1d4e","line":116,"range":{"start_line":114,"start_character":0,"end_line":116,"end_character":46},"in_reply_to":"cd723cd3_bdf52797","updated":"2021-07-09 12:44:07.000000000","message":"Ack","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e173c39d01a16ece92774bb34cf3ba6bc230b184","unresolved":true,"context_lines":[{"line_number":114,"context_line":"None, other than providing a generic API to allow stashed image properties to"},{"line_number":115,"context_line":"be updated by users over time without requiring a rebuild but that\u0027s out of"},{"line_number":116,"context_line":"scope for this basic nova-manage command spec."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Data model impact"},{"line_number":119,"context_line":"-----------------"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"f6062e73_ec4a2305","line":117,"updated":"2021-07-09 11:57:21.000000000","message":"we could add a --hard-reboot flag to the update command to to allow the instance to be rebooted automatically if it suceeded in updating the values.","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c43e42dc425b9be5569fd3c13d2beec83d9d2df9","unresolved":false,"context_lines":[{"line_number":114,"context_line":"None, other than providing a generic API to allow stashed image properties to"},{"line_number":115,"context_line":"be updated by users over time without requiring a rebuild but that\u0027s out of"},{"line_number":116,"context_line":"scope for this basic nova-manage command spec."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Data model impact"},{"line_number":119,"context_line":"-----------------"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fff8a386_99c0f5f5","line":117,"in_reply_to":"93102f68_808ad432","updated":"2021-07-12 11:13:48.000000000","message":"Agreed","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ab12080ca00c3591144ecfc98090e28e1955d9e0","unresolved":false,"context_lines":[{"line_number":114,"context_line":"None, other than providing a generic API to allow stashed image properties to"},{"line_number":115,"context_line":"be updated by users over time without requiring a rebuild but that\u0027s out of"},{"line_number":116,"context_line":"scope for this basic nova-manage command spec."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Data model impact"},{"line_number":119,"context_line":"-----------------"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"93102f68_808ad432","line":117,"in_reply_to":"f6062e73_ec4a2305","updated":"2021-07-09 12:44:07.000000000","message":"I don\u0027t think that\u0027s required, it\u0027s simple enough for operators to automate that outside of the command if they really want that behaviour.","commit_id":"9ff1e894b0a92860257011c9ddc058161a349d1f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"adeb078e4fed12e715bd78ea2ac471df3438b318","unresolved":true,"context_lines":[{"line_number":72,"context_line":"* ``hw_disk_bus``"},{"line_number":73,"context_line":"* ``hw_floppy_bus``"},{"line_number":74,"context_line":"* ``hw_rescue_bus``"},{"line_number":75,"context_line":"* ``hw_input_bus``"},{"line_number":76,"context_line":"* ``hw_pointer_model``"},{"line_number":77,"context_line":"* ``hw_rng_model``"},{"line_number":78,"context_line":"* ``hw_scsi_model``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"4632ffff_00342317","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":16},"updated":"2021-07-12 13:12:26.000000000","message":"thanks for addign this","commit_id":"e7fbd7eb3179ac0e7b67640ab1e9ad619e6c70b2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"adeb078e4fed12e715bd78ea2ac471df3438b318","unresolved":true,"context_lines":[{"line_number":85,"context_line":"With the bus and model types stored we can now provide commands to operators to"},{"line_number":86,"context_line":"inspect and update only the list of allowed image properties above:"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"``$ nova-manage image-property list $instance``"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Will list the stashed image properties of an instance."},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"2cd5c38d_97e4ed86","line":88,"range":{"start_line":88,"start_character":31,"end_line":88,"end_character":35},"updated":"2021-07-12 13:12:26.000000000","message":"nit: i know this is nova manage and not osc but if we were to follow the osc convention this would be show\n\nlist would list all the properties supproted but show would show the values for a specifc instance.\n\nanyway this will work and its a seperate tool so not going to -1 over this its just a nit","commit_id":"e7fbd7eb3179ac0e7b67640ab1e9ad619e6c70b2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ca163bd45587e139feab4456ffe34e1129f88efe","unresolved":true,"context_lines":[{"line_number":85,"context_line":"With the bus and model types stored we can now provide commands to operators to"},{"line_number":86,"context_line":"inspect and update only the list of allowed image properties above:"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"``$ nova-manage image-property list $instance``"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Will list the stashed image properties of an instance."},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"8b7e3479_bbeec325","line":88,"updated":"2021-07-12 14:04:10.000000000","message":"style nit:\n\n  .. code-block:: shell\n\n     $ nova-manage ...\n\nwill render nicer in the final spec","commit_id":"e7fbd7eb3179ac0e7b67640ab1e9ad619e6c70b2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ca163bd45587e139feab4456ffe34e1129f88efe","unresolved":false,"context_lines":[{"line_number":85,"context_line":"With the bus and model types stored we can now provide commands to operators to"},{"line_number":86,"context_line":"inspect and update only the list of allowed image properties above:"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"``$ nova-manage image-property list $instance``"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Will list the stashed image properties of an instance."},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"a62ecb70_d820c326","line":88,"range":{"start_line":88,"start_character":31,"end_line":88,"end_character":35},"in_reply_to":"2cd5c38d_97e4ed86","updated":"2021-07-12 14:04:10.000000000","message":"This is okay IMO. This is listing all the (relevant) image properties of an instance. Show, if implemented, would show an individual image property of an instance. The resource is image properties which happens to be a child resource of an instance.","commit_id":"e7fbd7eb3179ac0e7b67640ab1e9ad619e6c70b2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ca163bd45587e139feab4456ffe34e1129f88efe","unresolved":true,"context_lines":[{"line_number":90,"context_line":"Will list the stashed image properties of an instance."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"``$ nova-manage image-property set --property hw_disk_bus\u003dscsi --property"},{"line_number":93,"context_line":"hw_scsi_model\u003dvirtio-scsi $instance``"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Will update image properties of an instance, only accepting the previously"},{"line_number":96,"context_line":"defined list of image properties for the time being."}],"source_content_type":"text/x-rst","patch_set":3,"id":"e837a3e8_d9e94ec7","line":93,"updated":"2021-07-12 14:04:10.000000000","message":"ditto, RE: rendering","commit_id":"e7fbd7eb3179ac0e7b67640ab1e9ad619e6c70b2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"adeb078e4fed12e715bd78ea2ac471df3438b318","unresolved":true,"context_lines":[{"line_number":101,"context_line":"The following prerequisites apply when attempting to update the image"},{"line_number":102,"context_line":"properties of an instance:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"- The instance must be in a STOPPED, SHELVED or SHELVED_OFFLOADED vm_sate."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"- The provided type will be validated against the corresponding versioned"},{"line_number":107,"context_line":"  object fields for the bus or model."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1cb778c2_535db9b6","line":104,"updated":"2021-07-12 13:12:26.000000000","message":"+1","commit_id":"e7fbd7eb3179ac0e7b67640ab1e9ad619e6c70b2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ca163bd45587e139feab4456ffe34e1129f88efe","unresolved":true,"context_lines":[{"line_number":101,"context_line":"The following prerequisites apply when attempting to update the image"},{"line_number":102,"context_line":"properties of an instance:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"- The instance must be in a STOPPED, SHELVED or SHELVED_OFFLOADED vm_sate."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"- The provided type will be validated against the corresponding versioned"},{"line_number":107,"context_line":"  object fields for the bus or model."}],"source_content_type":"text/x-rst","patch_set":3,"id":"e38a1c35_2c5ea19c","line":104,"range":{"start_line":104,"start_character":69,"end_line":104,"end_character":73},"updated":"2021-07-12 14:04:10.000000000","message":"state","commit_id":"e7fbd7eb3179ac0e7b67640ab1e9ad619e6c70b2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ca163bd45587e139feab4456ffe34e1129f88efe","unresolved":false,"context_lines":[{"line_number":101,"context_line":"The following prerequisites apply when attempting to update the image"},{"line_number":102,"context_line":"properties of an instance:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"- The instance must be in a STOPPED, SHELVED or SHELVED_OFFLOADED vm_sate."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"- The provided type will be validated against the corresponding versioned"},{"line_number":107,"context_line":"  object fields for the bus or model."}],"source_content_type":"text/x-rst","patch_set":3,"id":"a99089a2_d19689ac","line":104,"in_reply_to":"1cb778c2_535db9b6","updated":"2021-07-12 14:04:10.000000000","message":"Ack","commit_id":"e7fbd7eb3179ac0e7b67640ab1e9ad619e6c70b2"}]}