)]}'
{"specs/xena/approved/add-connection-info-to-responses-of-the-os-volume_attachments-api.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7817c6eb45b564feff36232546d30871d3148659","unresolved":true,"context_lines":[{"line_number":99,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Introduce a new microversion that will display the stashed connection_info of a"},{"line_number":102,"context_line":"given block device mapping record only to admins in the response of ``GET"},{"line_number":103,"context_line":"/servers/{server_id}/os-volume_attachments`` or ``GET"},{"line_number":104,"context_line":"/servers/{server_id}/os-volume_attachments/{volume_id}``."},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"e5f886cc_ed2c088b","line":102,"range":{"start_line":102,"start_character":42,"end_line":102,"end_character":48},"updated":"2021-07-09 11:19:21.000000000","message":"will this be drive by a new api policy?","commit_id":"6d8afb0545c59c5d7109e4346c7e23dd83d73d7c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6be332b00bf87794295cb5062f9812b60f4d362a","unresolved":true,"context_lines":[{"line_number":99,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Introduce a new microversion that will display the stashed connection_info of a"},{"line_number":102,"context_line":"given block device mapping record only to admins in the response of ``GET"},{"line_number":103,"context_line":"/servers/{server_id}/os-volume_attachments`` or ``GET"},{"line_number":104,"context_line":"/servers/{server_id}/os-volume_attachments/{volume_id}``."},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ece496cf_1d047c3c","line":102,"range":{"start_line":102,"start_character":42,"end_line":102,"end_character":48},"in_reply_to":"e5f886cc_ed2c088b","updated":"2021-07-09 11:48:04.000000000","message":"I\u0027m not sure, are there examples where the optional inclusion of something in a response is tied to policy?","commit_id":"6d8afb0545c59c5d7109e4346c7e23dd83d73d7c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7ae1b6fffe7a6f60e6f0fe974a32067a5cf959cb","unresolved":true,"context_lines":[{"line_number":99,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Introduce a new microversion that will display the stashed connection_info of a"},{"line_number":102,"context_line":"given block device mapping record only to admins in the response of ``GET"},{"line_number":103,"context_line":"/servers/{server_id}/os-volume_attachments`` or ``GET"},{"line_number":104,"context_line":"/servers/{server_id}/os-volume_attachments/{volume_id}``."},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"b9f6c495_c0187384","line":102,"range":{"start_line":102,"start_character":42,"end_line":102,"end_character":48},"in_reply_to":"ece496cf_1d047c3c","updated":"2021-07-12 11:10:09.000000000","message":"Yep, like os_compute_api:os-instance-actions:events:details","commit_id":"6d8afb0545c59c5d7109e4346c7e23dd83d73d7c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e16d954881b136ba932bdb5efa364c6082424e46","unresolved":true,"context_lines":[{"line_number":111,"context_line":"same information through the API, it stops short of providing a new"},{"line_number":112,"context_line":"``os-volume_attachments`` action API that could refresh the attachments that"},{"line_number":113,"context_line":"should happen in another spec in the future."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":".. __: https://review.opendev.org/c/openstack/nova-specs/+/799624"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"318c4aaa_71d5d6e5","line":114,"updated":"2021-07-09 12:22:44.000000000","message":"well we have discussed not stashing the connection_info in nova an always gettign if form cinder going forawed to eliminate this problem correct.\n\nwe do not store cyborg arqs in our db to make sure we cant get out of sync for a similar reason.\nwe always look them up when starting the instnce.\n\n\nso if our long term goal is to remove the storage of the connection info form the nova db then personally i would prefer to proceed with https://review.opendev.org/c/openstack/nova-specs/+/799624 instead.","commit_id":"6d8afb0545c59c5d7109e4346c7e23dd83d73d7c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d29c89332f5146ad6728126b1cce173756c586ed","unresolved":true,"context_lines":[{"line_number":111,"context_line":"same information through the API, it stops short of providing a new"},{"line_number":112,"context_line":"``os-volume_attachments`` action API that could refresh the attachments that"},{"line_number":113,"context_line":"should happen in another spec in the future."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":".. __: https://review.opendev.org/c/openstack/nova-specs/+/799624"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"412c8775_b18277e1","line":114,"in_reply_to":"318c4aaa_71d5d6e5","updated":"2021-07-09 13:02:34.000000000","message":"As discussed in IRC I couldn\u0027t disagree more. We should of course aim to eventually stop stashing connection_info but the amount of work required to do so is non-trivial and it could easily never happen given the direction of the project.\n\nRejecting this based on the possibility of things eventually changing seems pretty pedantic tbh, especially when we could return None and later remove it from the response under another microversion.","commit_id":"6d8afb0545c59c5d7109e4346c7e23dd83d73d7c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7817c6eb45b564feff36232546d30871d3148659","unresolved":true,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"In a new microversion, expose ``connection_info`` in the following responses to"},{"line_number":127,"context_line":"requests by admins:"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"* GET ``/servers/{server_id}/os-volume_attachments``"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":".. code-block:: json"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ee196d0b_f175da9c","line":128,"updated":"2021-07-09 11:19:21.000000000","message":"Does connection_info has any kind of defined structure or is it just a dict?","commit_id":"6d8afb0545c59c5d7109e4346c7e23dd83d73d7c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7ae1b6fffe7a6f60e6f0fe974a32067a5cf959cb","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"In a new microversion, expose ``connection_info`` in the following responses to"},{"line_number":127,"context_line":"requests by admins:"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"* GET ``/servers/{server_id}/os-volume_attachments``"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":".. code-block:: json"}],"source_content_type":"text/x-rst","patch_set":2,"id":"a49bdb7d_02ae1179","line":128,"in_reply_to":"0af4e45b_f7fc3c87","updated":"2021-07-12 11:10:09.000000000","message":"Ack","commit_id":"6d8afb0545c59c5d7109e4346c7e23dd83d73d7c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6be332b00bf87794295cb5062f9812b60f4d362a","unresolved":true,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"In a new microversion, expose ``connection_info`` in the following responses to"},{"line_number":127,"context_line":"requests by admins:"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"* GET ``/servers/{server_id}/os-volume_attachments``"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":".. code-block:: json"}],"source_content_type":"text/x-rst","patch_set":2,"id":"0af4e45b_f7fc3c87","line":128,"in_reply_to":"ee196d0b_f175da9c","updated":"2021-07-09 11:48:04.000000000","message":"Not outside of some basic first level keys like \u0027data\u0027 etc","commit_id":"6d8afb0545c59c5d7109e4346c7e23dd83d73d7c"}]}