)]}'
{"id":"openstack%2Fnova-specs~800569","triplet_id":"openstack%2Fnova-specs~master~I41ce8c336e9917de645faf94d5a31898b0fa0c81","project":"openstack/nova-specs","branch":"master","topic":"bp/support-consumer-types","hashtags":[],"change_id":"I41ce8c336e9917de645faf94d5a31898b0fa0c81","subject":"Repropose: Support Consumer Types in placement","status":"MERGED","created":"2021-07-12 21:35:17.000000000","updated":"2021-07-13 20:16:16.000000000","submitted":"2021-07-13 20:14:23.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"800569-bp/support-consumer-types","meta_rev_id":"9c021e2951e897c584c89bb24bf6c4a80505e56c","_number":800569,"virtual_id_number":800569,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-07-13 20:14:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":2,"date":"2021-07-13 19:36:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-07-13 09:08:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":1,"date":"2021-07-13 19:36:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-07-12 21:49:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-07-13 09:08:03.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2021-07-13 19:36:31.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"}],"messages":[{"id":"888410195d3e650b268f1a486c81f821b7a7d296","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-07-12 21:35:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6ae9c0f9bf0b98223a7cddfaae5500497425f9fd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-12 21:49:30.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c3cf9710d16f4bfda50df4293e225b61 : SUCCESS in 8m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/471f64222c00412cbec243cac78794ce : FAILURE in 3m 52s","accounts_in_message":[],"_revision_number":1},{"id":"9564ecf776f08b9f1351d27921f802b99febce5b","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-07-12 21:54:04.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"fde1bea831aec214cfa3afa2db3566405b04cea8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-07-12 22:01:53.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c1fed2a27f0e03d95d5aa3ae3375b1a13070a0ad","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-12 22:20:33.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6e66550b8972462296414412dec25f99 : SUCCESS in 9m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/77865e126257458780d4290123c527f0 : SUCCESS in 3m 48s","accounts_in_message":[],"_revision_number":2},{"id":"ff3411a6f557464ef2d5fa42bfcd823099207d09","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-07-13 09:08:03.000000000","message":"Patch Set 2: Code-Review+2\n\nLooks good and aligned with the proposed implementation as well.","accounts_in_message":[],"_revision_number":2},{"id":"e073af12115c1fd6c39fc5019339280b5383840f","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2021-07-13 19:36:31.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nthanks for reproposing this.\ni agree with the direction of this spec in general and\nthe implemation is already in flight so i think we should try and land this this cycle\nthanks for bining this up in the meeting today i had not seen this come in.","accounts_in_message":[],"_revision_number":2},{"id":"fa64e692ae99add3d3dc29a21c05d36014f3b2dc","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-13 19:37:04.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"bd3a0369588a2539368779cb3081ab27216a8166","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2021-07-13 19:38:04.000000000","message":"Patch Set 2:\n\nthe only other thing to note is techniall placement has its own specs in tree in the pacemetn repos in the docs folder so we can track this in nova since its not a deliverable fo comptue again but we might want to consider using the placement one in future","accounts_in_message":[],"_revision_number":2},{"id":"8df1e0bb2cffd2dd0e6ef4309daf7aa23fdeba83","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-13 20:03:18.000000000","message":"Patch Set 2:\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"4e4233a44bedfbf3db6646c680a7a392e4d55e6e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-13 20:14:22.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/768400dfffa74084bf075926743dd6ba : SUCCESS in 9m 52s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ccdec6be6ef74625b2007836e62cf0c2 : SUCCESS in 5m 20s","accounts_in_message":[],"_revision_number":2},{"id":"1b2f2fd9528a18bf820dfd58ced8d25856987173","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-13 20:14:23.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"9c021e2951e897c584c89bb24bf6c4a80505e56c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-13 20:16:16.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-specs https://zuul.opendev.org/t/openstack/build/bb4668cf268a45b6aea5697f9f9a72e5 : SUCCESS in 1m 37s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ac4c353cbdcd71a44c6ec50237a2b05dc5f8c4d8","revisions":{"96fc838c3813d241387271ca2982e55eead83b4a":{"kind":"REWORK","_number":1,"created":"2021-07-12 21:35:17.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/69/800569/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/69/800569/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/69/800569/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/69/800569/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/69/800569/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/69/800569/1"}}},"commit":{"parents":[{"commit":"e7fbd7eb3179ac0e7b67640ab1e9ad619e6c70b2","subject":"Store and allow libvirt instance device buses and models to be updated","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/e7fbd7eb3179ac0e7b67640ab1e9ad619e6c70b2"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-07-12 21:28:22.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-07-12 21:29:49.000000000","tz":0},"subject":"Repropose: Support Consumer Types in placement","message":"Repropose: Support Consumer Types in placement\n\nThis spec was previously proposed in Train [1] and the corresponding\nimplementation has been slowly worked on since. The implementation is\nnearly completed now having ironed out many wrinkles that were brought\nup during code review.\n\nThis contains updates to the design which were discussed and agreed\nupon during code review with the main difference being that there is no\nlonger a default consumer type proposed and that a value of ``NULL``\nwill indicate the absence of a consumer type for a consumer. Along with\nthis, no online data migration is now needed.\n\nStory: 2005473\nTask: 30554\n\n[1] https://docs.openstack.org/placement/latest/specs/train/approved/2005473-support-consumer-types.html\n\nChange-Id: I41ce8c336e9917de645faf94d5a31898b0fa0c81\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/96fc838c3813d241387271ca2982e55eead83b4a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/96fc838c3813d241387271ca2982e55eead83b4a"}]},"branch":"refs/heads/master"},"ac4c353cbdcd71a44c6ec50237a2b05dc5f8c4d8":{"kind":"REWORK","_number":2,"created":"2021-07-12 22:01:53.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/69/800569/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova-specs","ref":"refs/changes/69/800569/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/69/800569/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/69/800569/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova-specs refs/changes/69/800569/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova-specs refs/changes/69/800569/2"}}},"commit":{"parents":[{"commit":"e7fbd7eb3179ac0e7b67640ab1e9ad619e6c70b2","subject":"Store and allow libvirt instance device buses and models to be updated","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/e7fbd7eb3179ac0e7b67640ab1e9ad619e6c70b2"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-07-12 21:28:22.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-07-12 22:01:24.000000000","tz":0},"subject":"Repropose: Support Consumer Types in placement","message":"Repropose: Support Consumer Types in placement\n\nThis spec was previously proposed in Train [1] and the corresponding\nimplementation has been slowly worked on since. The implementation is\nnearly completed now having ironed out many wrinkles that were brought\nup during code review.\n\nThis contains updates to the design which were discussed and agreed\nupon during code review with the main difference being that there is no\nlonger a default consumer type proposed and that a value of ``NULL``\nwill indicate the absence of a consumer type for a consumer. Along with\nthis, no online data migration is now needed.\n\nPreviously-approved: Train\n\nStory: 2005473\nTask: 30554\n\n[1] https://docs.openstack.org/placement/latest/specs/train/approved/2005473-support-consumer-types.html\n\nChange-Id: I41ce8c336e9917de645faf94d5a31898b0fa0c81\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/ac4c353cbdcd71a44c6ec50237a2b05dc5f8c4d8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova-specs/commit/ac4c353cbdcd71a44c6ec50237a2b05dc5f8c4d8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}