)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"373f61fec71ff8c3de78e132fb1933c4d3a933d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"653f38f3_8d868458","updated":"2021-10-13 16:19:13.000000000","message":"I\u0027m going to fast-approve this change as it\u0027s a seamless reproposal but let\u0027s discuss melwitt\u0027s points in a separate change.","commit_id":"a5e78811c65d72870d4b758d9038398a3a1b11f7"}],"specs/yoga/approved/unified-limits-nova.rst":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6f76983c9206215c40d19e11e22723388e8d9f4f","unresolved":true,"context_lines":[{"line_number":422,"context_line":"Alternatives"},{"line_number":423,"context_line":"------------"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"Ideally we would not add any more proxy APIs, however, operators pushed back"},{"line_number":426,"context_line":"at the Train Forum session, requesting that their tooling continue to work"},{"line_number":427,"context_line":"across the transition. No operators reported using limits other than the"},{"line_number":428,"context_line":"instances, cores and ram limits."},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"We could implement hierarchical quotas in isolation, and not adopt unified"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1b801c24_03fdb842","line":427,"range":{"start_line":425,"start_character":0,"end_line":427,"end_character":22},"updated":"2021-09-15 00:22:44.000000000","message":"We may want to revisit this ... the current proposed implementation is proxying reads but do we really want to proxy writes as well?","commit_id":"a5e78811c65d72870d4b758d9038398a3a1b11f7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"373f61fec71ff8c3de78e132fb1933c4d3a933d4","unresolved":true,"context_lines":[{"line_number":422,"context_line":"Alternatives"},{"line_number":423,"context_line":"------------"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"Ideally we would not add any more proxy APIs, however, operators pushed back"},{"line_number":426,"context_line":"at the Train Forum session, requesting that their tooling continue to work"},{"line_number":427,"context_line":"across the transition. No operators reported using limits other than the"},{"line_number":428,"context_line":"instances, cores and ram limits."},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"We could implement hierarchical quotas in isolation, and not adopt unified"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b3f7b4fc_e8ca4f2c","line":427,"range":{"start_line":425,"start_character":0,"end_line":427,"end_character":22},"in_reply_to":"1b801c24_03fdb842","updated":"2021-10-13 16:19:13.000000000","message":"let\u0027s discuss this excellent point in a separate spec amendment patch, then.","commit_id":"a5e78811c65d72870d4b758d9038398a3a1b11f7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6f76983c9206215c40d19e11e22723388e8d9f4f","unresolved":true,"context_lines":[{"line_number":444,"context_line":"REST API impact"},{"line_number":445,"context_line":"---------------"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"When ``[quota]driver\u003dnova.quota.UnifiedLimitsDriver`` Nova will proxy the"},{"line_number":448,"context_line":"requests to Keystone\u0027s unified limits API, where possible. The aim will be to"},{"line_number":449,"context_line":"keep horizon functioning correctly during the transition."},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"Once using unified limits, operators should move to using Keystone\u0027s"},{"line_number":452,"context_line":"unified limit APIs to set and query limits. Usage information should be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"691de212_35543e6b","line":449,"range":{"start_line":447,"start_character":54,"end_line":449,"end_character":57},"updated":"2021-09-15 00:22:44.000000000","message":"The current proposed implementation is proxying quota limit reads from keystone but it\u0027s debatable whether we should proxy writes as well (?). The alternative would be to add functionality in horizon to write to keystone unified limits? But there\u0027s no way for horizon to discover whether nova is configured to use unified limits...","commit_id":"a5e78811c65d72870d4b758d9038398a3a1b11f7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"373f61fec71ff8c3de78e132fb1933c4d3a933d4","unresolved":true,"context_lines":[{"line_number":444,"context_line":"REST API impact"},{"line_number":445,"context_line":"---------------"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"When ``[quota]driver\u003dnova.quota.UnifiedLimitsDriver`` Nova will proxy the"},{"line_number":448,"context_line":"requests to Keystone\u0027s unified limits API, where possible. The aim will be to"},{"line_number":449,"context_line":"keep horizon functioning correctly during the transition."},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"Once using unified limits, operators should move to using Keystone\u0027s"},{"line_number":452,"context_line":"unified limit APIs to set and query limits. Usage information should be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d1daad30_43524a96","line":449,"range":{"start_line":447,"start_character":54,"end_line":449,"end_character":57},"in_reply_to":"691de212_35543e6b","updated":"2021-10-13 16:19:13.000000000","message":"ditto above.","commit_id":"a5e78811c65d72870d4b758d9038398a3a1b11f7"}]}