)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"2272244923d719da8a82fb609b961d279f6ce889","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c565ee62_4f848247","updated":"2022-01-10 18:51:06.000000000","message":"As requested, left liaison as TBD for the time being unless you are able to assist with that.","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"148f55867937f578a6c2b4c7db29332156d4fe0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bd2650ba_c79cf2bd","updated":"2022-01-10 22:29:29.000000000","message":"I wonder if I\u0027m missing something obvious, but what I\u0027ve understood from the spec seems no different than how we currently use the \u0027hw_architecture\u0027 image property. For instance, here\u0027s the `get_arch()` method from the libvirt driver utils:\n\n  def get_arch(image_meta: \u0027objects.ImageMeta\u0027) -\u003e str:\n    if image_meta:\n        image_arch \u003d image_meta.properties.get(\u0027hw_architecture\u0027)\n        if image_arch is not None:\n            return image_arch\n\n    return obj_fields.Architecture.from_host()\n\nThat reads exactly like what you\u0027re proposing for hw_emulation_architecture - use what\u0027s in the image property, otherwise fall back on the host arch.\n","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"1e61ce15a422fae2217a8d701cd152836ec3a15d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c5ede0a5_61111b39","updated":"2022-01-10 22:45:56.000000000","message":"clarification to question.","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb50dd54456b932aa5a49b8cf6318b10daf37dee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dadab217_1229515d","updated":"2022-01-11 14:50:24.000000000","message":"it woudl be good to expand on the schduling aspect of thisand there is a little too much implemnation detail in some parts but over all this is ok.\n\nill try an review again tomoorow but you have an unusial blance of both a lack of info mation and too much detail all at once. i need to think about how eto adjust it to get the right level of detail for the target audience.","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"fb81631219cfbb2d0eb6ee10dcae06645c3946dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"390264ae_cbfa5720","in_reply_to":"795c947c_9e1fa8d0","updated":"2022-01-11 19:00:53.000000000","message":"See patchset 2, as I hope that hits better.","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"1e61ce15a422fae2217a8d701cd152836ec3a15d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"794aa9e2_a379fd0c","in_reply_to":"bd2650ba_c79cf2bd","updated":"2022-01-10 22:45:56.000000000","message":"With using nova as-is, when you specify that field your instance will never get scheduled because it will find no matching hosts for the desired architecture if different from your physical hosts arch. our initial patching was for that, but that field is used and reused in multiple area\u0027s.\n\nSo using the hw_architecture field like you stated, it will work for physical support if you have aarch or ppc systems. So rather then changing core code and attempting to compensate, we pursued added functionality that targets qemu emulation specifically. as we are wanting to run aarch and ppc on x86_64 hosts and vice versa. hopefully that helps explain better.","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"72b074659cb9a9d315e82c775ae0cb37f9a0a1b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"795c947c_9e1fa8d0","in_reply_to":"dadab217_1229515d","updated":"2022-01-11 16:22:02.000000000","message":"Agree with Sean. Expand on the scheduling part and I think this is good to go","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"af574df35ebe4b3b7e06a15db5dd3c3d9fea7a1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9275ab3f_9d9f4b75","updated":"2022-01-12 10:32:57.000000000","message":"I have one question inline the rest is just nits. ","commit_id":"34f32834dd9a0110c322e85eddc1e0c28e25075b"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"fb81631219cfbb2d0eb6ee10dcae06645c3946dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e29a6039_65b49ec6","updated":"2022-01-11 19:00:53.000000000","message":"Patch set should cover and expand all comments. For the scheduler changes went the route suggested you suggested Sean, and have done some initial unit testing with it with success as I believe that will be the better route as well.","commit_id":"34f32834dd9a0110c322e85eddc1e0c28e25075b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"100273f33bbe3507980be41dc6c48ccee4c0547a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"af624846_7d505f5d","updated":"2022-01-12 17:16:51.000000000","message":"It looks good to me now","commit_id":"1cbba68eb7509c0dc4a32836ba69d5b9ee50ffde"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2d2c4bed7e90e17a93d661aef96cf9d5bd2cdc20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"77a8509c_155d9db1","updated":"2022-01-13 07:49:53.000000000","message":"Still good. ","commit_id":"ad31ed54d1a6ea91151032d6c4d8dd5c6960d9b3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"93ce70ed79d391ac5c742eeb8ad8152a215880ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"57be7fbb_2762bcf6","updated":"2022-01-13 14:24:37.000000000","message":"Still good","commit_id":"69ddbf090ef8c3c26aeb471a5c60bbf64536aa44"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bddd7b1351317a8fddb8bbb7489bc51aa4919610","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bc96a33b_815d967f","updated":"2022-01-13 13:36:36.000000000","message":"ack thanks for addressing my nits 😊\n\nim good with the current version as written.","commit_id":"69ddbf090ef8c3c26aeb471a5c60bbf64536aa44"}],"specs/yoga/approved/pick-guest-arch-based-on-host-arch-in-libvirt-driver.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4185a26ce43641a12bfb44bd2a4057b163f51dc1","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"* ``hw_emulation_architecture \u003d AARCH64``"},{"line_number":90,"context_line":"* ``hw_architecture \u003d X86_64``"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"**Example 2** When both image meta properties are set the emulation"},{"line_number":93,"context_line":"architecture will take precedent, and it will build on any host that"},{"line_number":94,"context_line":"supports emulating X86_64."}],"source_content_type":"text/x-rst","patch_set":5,"id":"32c4b4ac_7a3cd7cb","line":91,"updated":"2022-01-13 09:52:02.000000000","message":"i dont think this is the correct semantics\nthis should only build on x86_64 that support aarch64\n\nnot any host that emulates aarch64 based on how the prefilter works","commit_id":"ad31ed54d1a6ea91151032d6c4d8dd5c6960d9b3"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"012cf141edffb8cd7db91dffbaa46b6ff288ed74","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"* ``hw_emulation_architecture \u003d AARCH64``"},{"line_number":90,"context_line":"* ``hw_architecture \u003d X86_64``"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"**Example 2** When both image meta properties are set the emulation"},{"line_number":93,"context_line":"architecture will take precedent, and it will build on any host that"},{"line_number":94,"context_line":"supports emulating X86_64."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ca259215_29385895","line":91,"in_reply_to":"32c4b4ac_7a3cd7cb","updated":"2022-01-13 13:22:28.000000000","message":"Done, clarified the example better.","commit_id":"ad31ed54d1a6ea91151032d6c4d8dd5c6960d9b3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4185a26ce43641a12bfb44bd2a4057b163f51dc1","unresolved":true,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* ``hw_emulation_architecture \u003d X86_64``"},{"line_number":97,"context_line":"* ``hw_architecture \u003d AARCH64``"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"**Example 3** When the ``hw_emulation_architecture`` property is unset it"},{"line_number":100,"context_line":"will build on any host that natively supports the specified architecture."},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"0c5f0553_b274dc0d","line":98,"updated":"2022-01-13 09:52:02.000000000","message":"same this will only launch on host with both traits.\nthis will use x86 in prefernce to arm to run the vm but from a schduling perspective its going to look at both.\n\n\ni would change this example to drom the hw_architecutre requriement to just allow any host that can emulate x86 to cover the 3 options.","commit_id":"ad31ed54d1a6ea91151032d6c4d8dd5c6960d9b3"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"012cf141edffb8cd7db91dffbaa46b6ff288ed74","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* ``hw_emulation_architecture \u003d X86_64``"},{"line_number":97,"context_line":"* ``hw_architecture \u003d AARCH64``"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"**Example 3** When the ``hw_emulation_architecture`` property is unset it"},{"line_number":100,"context_line":"will build on any host that natively supports the specified architecture."},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9d6ff20e_fb324a17","line":98,"in_reply_to":"0c5f0553_b274dc0d","updated":"2022-01-13 13:22:28.000000000","message":"Done, clarified the example better.","commit_id":"ad31ed54d1a6ea91151032d6c4d8dd5c6960d9b3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4185a26ce43641a12bfb44bd2a4057b163f51dc1","unresolved":true,"context_lines":[{"line_number":129,"context_line":"           \u0027hw_emulation_architecture\u0027: \u0027COMPUTE_ARCH\u0027,"},{"line_number":130,"context_line":"       }"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Update os-traits"},{"line_number":134,"context_line":"----------------"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"14b2c7f7_02ca5064","line":132,"updated":"2022-01-13 09:52:02.000000000","message":"ack, so if you simply extend this prefilter in this way the requrements will be additive. meaning if you set both they will be anded together so\n\nhw_architechture \u003d x86_64 and hw_emulation_architecture \u003d aarach64\n\nwill only select x86 hosts that support arm emulation.\n\nthis is how i think it  should work in general\nunless we leverage the new any trait syntax that is being added to placement this cycle.\n\nif we do that you will need to make the filters slightly more complext to group these together. and use the in syntax to or the host/guest requests into one group.\n\nwe could change this in the future via a micor versiohnh to avoid the placemnt dep for this cycle or add an addtiontionl image prop next cycle to  specify if we should and or or the achitectures. or really only makes sense if both are the same.\n\ni dont thhink this is a block just pointing out the actual semantics","commit_id":"ad31ed54d1a6ea91151032d6c4d8dd5c6960d9b3"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"012cf141edffb8cd7db91dffbaa46b6ff288ed74","unresolved":false,"context_lines":[{"line_number":129,"context_line":"           \u0027hw_emulation_architecture\u0027: \u0027COMPUTE_ARCH\u0027,"},{"line_number":130,"context_line":"       }"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Update os-traits"},{"line_number":134,"context_line":"----------------"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"53bf6ae7_3bf894b5","line":132,"in_reply_to":"14b2c7f7_02ca5064","updated":"2022-01-13 13:22:28.000000000","message":"Agreed. and will make a personal dev note as the code is further developed to account for this. That was my thought process as well.","commit_id":"ad31ed54d1a6ea91151032d6c4d8dd5c6960d9b3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4185a26ce43641a12bfb44bd2a4057b163f51dc1","unresolved":true,"context_lines":[{"line_number":147,"context_line":"       \u0027RISCV64\u0027,"},{"line_number":148,"context_line":"       \u0027X86_64\u0027,"},{"line_number":149,"context_line":"   ]"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Perform architecture test against emulation"},{"line_number":152,"context_line":"-------------------------------------------"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5792eff2_2249a9fe","line":150,"updated":"2022-01-13 09:52:02.000000000","message":"you have kind of also made an implcit assumtion here that the virt driver will be updated to automatically report compute capablity traits for each emulated arch that it has a emulator aviable for on the host.\n\nit would be nice to state that explictly to capture that operators do not need to use provider.yaml to manually report them","commit_id":"ad31ed54d1a6ea91151032d6c4d8dd5c6960d9b3"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"012cf141edffb8cd7db91dffbaa46b6ff288ed74","unresolved":false,"context_lines":[{"line_number":147,"context_line":"       \u0027RISCV64\u0027,"},{"line_number":148,"context_line":"       \u0027X86_64\u0027,"},{"line_number":149,"context_line":"   ]"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Perform architecture test against emulation"},{"line_number":152,"context_line":"-------------------------------------------"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"aaab8c89_6e9faef8","line":150,"in_reply_to":"5792eff2_2249a9fe","updated":"2022-01-13 13:22:28.000000000","message":"that makes sense, I added a note capturing just that to avoid confusions.","commit_id":"ad31ed54d1a6ea91151032d6c4d8dd5c6960d9b3"}],"specs/yoga/implemented/pick-guest-arch-based-on-host-arch-in-libvirt-driver.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"72b074659cb9a9d315e82c775ae0cb37f9a0a1b8","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"So all of the said code needs to be reworked to make those decisions"},{"line_number":27,"context_line":"based on ``guest`` CPU architecture (i.e. ``guest.arch``, which should be"},{"line_number":28,"context_line":"set based on the image metadata property, ``hw_emualtion_architecture``)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"A related piece of work is to distinguish between hosts that can do AArch64,"},{"line_number":31,"context_line":"PPC64, Etc. via KVM (which is hardware-accelerated) vs. those that can only"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8942d842_123a528d","line":28,"range":{"start_line":28,"start_character":47,"end_line":28,"end_character":56},"updated":"2022-01-11 16:22:02.000000000","message":"nit: emulation?","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"1cce13809ea5e39a5ab4b7d49aa5fbe8098add89","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"So all of the said code needs to be reworked to make those decisions"},{"line_number":27,"context_line":"based on ``guest`` CPU architecture (i.e. ``guest.arch``, which should be"},{"line_number":28,"context_line":"set based on the image metadata property, ``hw_emualtion_architecture``)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"A related piece of work is to distinguish between hosts that can do AArch64,"},{"line_number":31,"context_line":"PPC64, Etc. via KVM (which is hardware-accelerated) vs. those that can only"}],"source_content_type":"text/x-rst","patch_set":1,"id":"773e94ed_fe23d2e0","line":28,"range":{"start_line":28,"start_character":47,"end_line":28,"end_character":56},"in_reply_to":"8942d842_123a528d","updated":"2022-01-11 18:47:40.000000000","message":"Done","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb50dd54456b932aa5a49b8cf6318b10daf37dee","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* As an admin/operator I want to deploy x86_64 as an emulated architecture"},{"line_number":46,"context_line":"  on AArch64."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Proposed change"},{"line_number":49,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"f02978f8_ade5dffe","line":47,"updated":"2022-01-11 14:50:24.000000000","message":"is there are reason you have not listed RISCV by the way\n\nqemu-system-riscv64 and  qemu-system-riscv32  both should be avaiabel in at least the debian/ubuntu based distor and likely others.\n\nlibvirt can in fact use them although the 8 cpus limit is less then i hoped.\nthey are reffective of the type of riscv hardware that exits today however.\n\n \u003cguest\u003e\n    \u003cos_type\u003ehvm\u003c/os_type\u003e\n    \u003carch name\u003d\u0027riscv32\u0027\u003e\n      \u003cwordsize\u003e32\u003c/wordsize\u003e\n      \u003cemulator\u003e/run/current-system/sw/bin/qemu-system-riscv32\u003c/emulator\u003e\n      \u003cmachine maxCpus\u003d\u00278\u0027\u003espike\u003c/machine\u003e\n      \u003cmachine maxCpus\u003d\u00271\u0027\u003eopentitan\u003c/machine\u003e\n      \u003cmachine maxCpus\u003d\u00275\u0027\u003esifive_u\u003c/machine\u003e\n      \u003cmachine maxCpus\u003d\u00271\u0027\u003esifive_e\u003c/machine\u003e\n      \u003cmachine maxCpus\u003d\u00278\u0027\u003evirt\u003c/machine\u003e\n      \u003cdomain type\u003d\u0027qemu\u0027/\u003e\n    \u003c/arch\u003e\n    \u003cfeatures\u003e\n      \u003ccpuselection/\u003e\n      \u003cdeviceboot/\u003e\n      \u003cdisksnapshot default\u003d\u0027on\u0027 toggle\u003d\u0027no\u0027/\u003e\n    \u003c/features\u003e\n  \u003c/guest\u003e\n\n  \u003cguest\u003e\n    \u003cos_type\u003ehvm\u003c/os_type\u003e\n    \u003carch name\u003d\u0027riscv64\u0027\u003e\n      \u003cwordsize\u003e64\u003c/wordsize\u003e\n      \u003cemulator\u003e/run/current-system/sw/bin/qemu-system-riscv64\u003c/emulator\u003e\n      \u003cmachine maxCpus\u003d\u00278\u0027\u003espike\u003c/machine\u003e\n      \u003cmachine maxCpus\u003d\u00275\u0027\u003emicrochip-icicle-kit\u003c/machine\u003e\n      \u003cmachine maxCpus\u003d\u00275\u0027\u003esifive_u\u003c/machine\u003e\n      \u003cmachine maxCpus\u003d\u00271\u0027\u003eshakti_c\u003c/machine\u003e\n      \u003cmachine maxCpus\u003d\u00271\u0027\u003esifive_e\u003c/machine\u003e\n      \u003cmachine maxCpus\u003d\u00278\u0027\u003evirt\u003c/machine\u003e\n      \u003cdomain type\u003d\u0027qemu\u0027/\u003e\n    \u003c/arch\u003e\n    \u003cfeatures\u003e\n      \u003ccpuselection/\u003e\n      \u003cdeviceboot/\u003e\n      \u003cdisksnapshot default\u003d\u0027on\u0027 toggle\u003d\u0027no\u0027/\u003e\n    \u003c/features\u003e\n  \u003c/guest\u003e","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"1cce13809ea5e39a5ab4b7d49aa5fbe8098add89","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* As an admin/operator I want to deploy x86_64 as an emulated architecture"},{"line_number":46,"context_line":"  on AArch64."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Proposed change"},{"line_number":49,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"56505a47_ab3e0cdb","line":47,"in_reply_to":"f02978f8_ade5dffe","updated":"2022-01-11 18:47:40.000000000","message":"understood in this respect. We did the testing based on readily available cloud images, we can definitely see about testing RISCV in the next week or so to determine any code considerations.","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"72b074659cb9a9d315e82c775ae0cb37f9a0a1b8","unresolved":true,"context_lines":[{"line_number":64,"context_line":"To enable defining the guest architecture the following string based image"},{"line_number":65,"context_line":"property will be introduced:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* ``hw_emulation_Architecture``"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"When this image property is not defined then instance provisioning will"},{"line_number":70,"context_line":"occur as normal."}],"source_content_type":"text/x-rst","patch_set":1,"id":"f15b8cae_a7e45d91","line":67,"range":{"start_line":67,"start_character":17,"end_line":67,"end_character":18},"updated":"2022-01-11 16:22:02.000000000","message":"is the capital A significant? The rest of the image properties are all lowercase afaik","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"1cce13809ea5e39a5ab4b7d49aa5fbe8098add89","unresolved":false,"context_lines":[{"line_number":64,"context_line":"To enable defining the guest architecture the following string based image"},{"line_number":65,"context_line":"property will be introduced:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* ``hw_emulation_Architecture``"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"When this image property is not defined then instance provisioning will"},{"line_number":70,"context_line":"occur as normal."}],"source_content_type":"text/x-rst","patch_set":1,"id":"f8825e15_e7012d8b","line":67,"range":{"start_line":67,"start_character":17,"end_line":67,"end_character":18},"in_reply_to":"40a1b447_45e45b65","updated":"2022-01-11 18:47:40.000000000","message":"Done","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"54ce83913ddb22e9a2de434c86e5f5c28568e240","unresolved":true,"context_lines":[{"line_number":64,"context_line":"To enable defining the guest architecture the following string based image"},{"line_number":65,"context_line":"property will be introduced:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* ``hw_emulation_Architecture``"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"When this image property is not defined then instance provisioning will"},{"line_number":70,"context_line":"occur as normal."}],"source_content_type":"text/x-rst","patch_set":1,"id":"40a1b447_45e45b65","line":67,"range":{"start_line":67,"start_character":17,"end_line":67,"end_character":18},"in_reply_to":"f15b8cae_a7e45d91","updated":"2022-01-11 16:34:05.000000000","message":"no i suspect this is a typo.\n\nthey should all be lowercase only.\n\nuppercase one shoudl be considered invalid","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb50dd54456b932aa5a49b8cf6318b10daf37dee","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"When this image property is not defined then instance provisioning will"},{"line_number":70,"context_line":"occur as normal."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Update os-traits"},{"line_number":73,"context_line":"----------------"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"a2b3f961_5eaa7d9e","line":71,"updated":"2022-01-11 14:50:24.000000000","message":"i think we need to expeand on this a bit more\n\ni suspect the semantics we want are as follows\n\n\nhw_emulation_Architecture \u003d AARCH64\nhw_Architecture \u003d \u003cunset\u003e\n\n-\u003e run on any host that support emulatating AARCH64\n\n\nhw_emulation_Architecture \u003d AARCH64\nhw_Architecture \u003d AARCH64\n\n-\u003e run on any host that support emulatating AARCH64 or is natively aarch64\n\n\nhw_emulation_Architecture \u003d \u003cunset\u003e\nhw_Architecture \u003d AARCH64\n\n-\u003e run on any host that is nativly AARCH64","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"1cce13809ea5e39a5ab4b7d49aa5fbe8098add89","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"When this image property is not defined then instance provisioning will"},{"line_number":70,"context_line":"occur as normal."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Update os-traits"},{"line_number":73,"context_line":"----------------"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"c0353125_e46e21f8","line":71,"in_reply_to":"a2b3f961_5eaa7d9e","updated":"2022-01-11 18:47:40.000000000","message":"Done","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb50dd54456b932aa5a49b8cf6318b10daf37dee","unresolved":true,"context_lines":[{"line_number":83,"context_line":"       \u0027MIPSEL\u0027,"},{"line_number":84,"context_line":"       \u0027S390X\u0027,"},{"line_number":85,"context_line":"       \u0027X86_64\u0027,"},{"line_number":86,"context_line":"   ]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Retrieve OS architecture for LibvirtConfigGuest"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a6defeac_1256090c","line":86,"updated":"2022-01-11 14:50:24.000000000","message":"i would proably also add \u0027RISCV64\u0027 at a miniutm but we shoudl consider do we want to just allow all archteture that qemu supports and premtivly add traits for them now.\n\nwe cancertely do that later when someone asks too. you have covered the main ones","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"1cce13809ea5e39a5ab4b7d49aa5fbe8098add89","unresolved":false,"context_lines":[{"line_number":83,"context_line":"       \u0027MIPSEL\u0027,"},{"line_number":84,"context_line":"       \u0027S390X\u0027,"},{"line_number":85,"context_line":"       \u0027X86_64\u0027,"},{"line_number":86,"context_line":"   ]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Retrieve OS architecture for LibvirtConfigGuest"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8f185dae_c33b111d","line":86,"in_reply_to":"a6defeac_1256090c","updated":"2022-01-11 18:47:40.000000000","message":"Done","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"72b074659cb9a9d315e82c775ae0cb37f9a0a1b8","unresolved":true,"context_lines":[{"line_number":100,"context_line":"-------------------------------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"To facilitate a simple check throughout the virt libvirt driver the"},{"line_number":103,"context_line":"following function does a check and will will set the appropriate guest"},{"line_number":104,"context_line":"architecture based on emulation, if defined."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2ed849fe_e71c312e","line":103,"range":{"start_line":103,"start_character":36,"end_line":103,"end_character":45},"updated":"2022-01-11 16:22:02.000000000","message":"nit: duplicate will","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"1cce13809ea5e39a5ab4b7d49aa5fbe8098add89","unresolved":false,"context_lines":[{"line_number":100,"context_line":"-------------------------------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"To facilitate a simple check throughout the virt libvirt driver the"},{"line_number":103,"context_line":"following function does a check and will will set the appropriate guest"},{"line_number":104,"context_line":"architecture based on emulation, if defined."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a5c4e1e0_9091c6c6","line":103,"range":{"start_line":103,"start_character":36,"end_line":103,"end_character":45},"in_reply_to":"2ed849fe_e71c312e","updated":"2022-01-11 18:47:40.000000000","message":"Done","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb50dd54456b932aa5a49b8cf6318b10daf37dee","unresolved":true,"context_lines":[{"line_number":171,"context_line":"by reducing reschedules. By passing a more constrained request to"},{"line_number":172,"context_line":"placement this feature should also reduce the resulting set of"},{"line_number":173,"context_line":"allocation_candidates that are returned."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"This will also ensure that native support is handled first over emulation"},{"line_number":176,"context_line":"as it requires a specific protperty to be set in order to perform the"},{"line_number":177,"context_line":"required checks."}],"source_content_type":"text/x-rst","patch_set":1,"id":"d336ed86_14c478e8","line":174,"updated":"2022-01-11 14:50:24.000000000","message":"we will need to impleent a placement request filter to enable this.\ncan you add a section describing how that will work.\n\nare you going to extend the image_metadata prefilter as i suggested or add a new ARCH prefilter so this capablity can be enabled/disabled seperatly?","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"1cce13809ea5e39a5ab4b7d49aa5fbe8098add89","unresolved":false,"context_lines":[{"line_number":171,"context_line":"by reducing reschedules. By passing a more constrained request to"},{"line_number":172,"context_line":"placement this feature should also reduce the resulting set of"},{"line_number":173,"context_line":"allocation_candidates that are returned."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"This will also ensure that native support is handled first over emulation"},{"line_number":176,"context_line":"as it requires a specific protperty to be set in order to perform the"},{"line_number":177,"context_line":"required checks."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf64b046_e70deae7","line":174,"in_reply_to":"d336ed86_14c478e8","updated":"2022-01-11 18:47:40.000000000","message":"Done","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb50dd54456b932aa5a49b8cf6318b10daf37dee","unresolved":true,"context_lines":[{"line_number":212,"context_line":"----------"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"- Add new traits"},{"line_number":215,"context_line":"- Update prefilter"},{"line_number":216,"context_line":"- Modify libvirt virt driver to perform checks for emulation architecture"},{"line_number":217,"context_line":"- Add new property to image_meta objects"},{"line_number":218,"context_line":"- Modify libvirt virt config to pull OS arch into LibvirtConfigGuest"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b8936ccd_11c442ec","line":215,"range":{"start_line":215,"start_character":1,"end_line":215,"end_character":18},"updated":"2022-01-11 14:50:24.000000000","message":"specificaly \n\nhttps://github.com/openstack/nova/blob/b49b7663e1c3073917d5844b81d38db8e86d05c4/nova/scheduler/request_filter.py#L200-L238\n\ncan you capture the detail of how you will update it in this spec.","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"1cce13809ea5e39a5ab4b7d49aa5fbe8098add89","unresolved":false,"context_lines":[{"line_number":212,"context_line":"----------"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"- Add new traits"},{"line_number":215,"context_line":"- Update prefilter"},{"line_number":216,"context_line":"- Modify libvirt virt driver to perform checks for emulation architecture"},{"line_number":217,"context_line":"- Add new property to image_meta objects"},{"line_number":218,"context_line":"- Modify libvirt virt config to pull OS arch into LibvirtConfigGuest"}],"source_content_type":"text/x-rst","patch_set":1,"id":"53d463b3_f239281e","line":215,"range":{"start_line":215,"start_character":1,"end_line":215,"end_character":18},"in_reply_to":"b8936ccd_11c442ec","updated":"2022-01-11 18:47:40.000000000","message":"Done","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb50dd54456b932aa5a49b8cf6318b10daf37dee","unresolved":true,"context_lines":[{"line_number":221,"context_line":"Dependencies"},{"line_number":222,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Adds the ``re`` python library to ``test_uefi.py`` to allow for the test"},{"line_number":225,"context_line":"to function properly against any cpu architecture. no specifc version is"},{"line_number":226,"context_line":"is required as it is the most basic of regex, ``.*``."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b26ba3d9_e18b0292","line":226,"range":{"start_line":224,"start_character":0,"end_line":226,"end_character":53},"updated":"2022-01-11 14:50:24.000000000","message":"this level of detail is not needed.\n\nif the re lib is not already a requirement then you could call it out \nbut it is part of the standard lib so we don\u0027t really need to list it and we do not need to specify for which file it is used in the spec\n\nhttps://docs.python.org/3/library/re.html","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"1cce13809ea5e39a5ab4b7d49aa5fbe8098add89","unresolved":false,"context_lines":[{"line_number":221,"context_line":"Dependencies"},{"line_number":222,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Adds the ``re`` python library to ``test_uefi.py`` to allow for the test"},{"line_number":225,"context_line":"to function properly against any cpu architecture. no specifc version is"},{"line_number":226,"context_line":"is required as it is the most basic of regex, ``.*``."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9b7d5144_0c95bb2b","line":226,"range":{"start_line":224,"start_character":0,"end_line":226,"end_character":53},"in_reply_to":"b26ba3d9_e18b0292","updated":"2022-01-11 18:47:40.000000000","message":"Done","commit_id":"4ed9e3fbc26b50224740a2503934711bf63d9b99"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"af574df35ebe4b3b7e06a15db5dd3c3d9fea7a1c","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"So all of the said code needs to be reworked to make those decisions"},{"line_number":27,"context_line":"based on ``guest`` CPU architecture (i.e. ``guest.arch``, which should be"},{"line_number":28,"context_line":"set based on the image metadata property, ``hw_emuulation_architecture``)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"A related piece of work is to distinguish between hosts that can do AArch64,"},{"line_number":31,"context_line":"PPC64, Etc. via KVM (which is hardware-accelerated) vs. those that can only"}],"source_content_type":"text/x-rst","patch_set":2,"id":"96124f82_f75a7547","line":28,"range":{"start_line":28,"start_character":47,"end_line":28,"end_character":57},"updated":"2022-01-12 10:32:57.000000000","message":"nit: emulation","commit_id":"34f32834dd9a0110c322e85eddc1e0c28e25075b"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"dc3cf6d17eb5a9439fed85c7cb05254b8a26749b","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"So all of the said code needs to be reworked to make those decisions"},{"line_number":27,"context_line":"based on ``guest`` CPU architecture (i.e. ``guest.arch``, which should be"},{"line_number":28,"context_line":"set based on the image metadata property, ``hw_emuulation_architecture``)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"A related piece of work is to distinguish between hosts that can do AArch64,"},{"line_number":31,"context_line":"PPC64, Etc. via KVM (which is hardware-accelerated) vs. those that can only"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bee87b6c_52079dde","line":28,"range":{"start_line":28,"start_character":47,"end_line":28,"end_character":57},"in_reply_to":"96124f82_f75a7547","updated":"2022-01-12 13:14:13.000000000","message":"Done","commit_id":"34f32834dd9a0110c322e85eddc1e0c28e25075b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"af574df35ebe4b3b7e06a15db5dd3c3d9fea7a1c","unresolved":true,"context_lines":[{"line_number":87,"context_line":"supports emulatating AARCH64."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"* ``hw_emulation_architecture \u003d AARCH64``"},{"line_number":90,"context_line":"* ``hw_Architecture \u003d X86_64``"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"**Example 2** When both image meta properties are set the emulation"},{"line_number":93,"context_line":"architecture will take precedent, and it will build on any host that"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ecc1bb59_c5003d7e","line":90,"range":{"start_line":90,"start_character":7,"end_line":90,"end_character":8},"updated":"2022-01-12 10:32:57.000000000","message":"nit: lower case here and below","commit_id":"34f32834dd9a0110c322e85eddc1e0c28e25075b"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"dc3cf6d17eb5a9439fed85c7cb05254b8a26749b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"supports emulatating AARCH64."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"* ``hw_emulation_architecture \u003d AARCH64``"},{"line_number":90,"context_line":"* ``hw_Architecture \u003d X86_64``"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"**Example 2** When both image meta properties are set the emulation"},{"line_number":93,"context_line":"architecture will take precedent, and it will build on any host that"}],"source_content_type":"text/x-rst","patch_set":2,"id":"018fa837_c19e286e","line":90,"range":{"start_line":90,"start_character":7,"end_line":90,"end_character":8},"in_reply_to":"ecc1bb59_c5003d7e","updated":"2022-01-12 13:14:13.000000000","message":"Done","commit_id":"34f32834dd9a0110c322e85eddc1e0c28e25075b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"af574df35ebe4b3b7e06a15db5dd3c3d9fea7a1c","unresolved":true,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"**Example 2** When both image meta properties are set the emulation"},{"line_number":93,"context_line":"architecture will take precedent, and it will build on any host that"},{"line_number":94,"context_line":"supports emulatating X86_64."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* ``hw_emulation_architecture \u003d X86_64``"},{"line_number":97,"context_line":"* ``hw_Architecture \u003d AARCH64``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"d3d3bf67_bfe70d20","line":94,"range":{"start_line":94,"start_character":9,"end_line":94,"end_character":20},"updated":"2022-01-12 10:32:57.000000000","message":"nit: emulating","commit_id":"34f32834dd9a0110c322e85eddc1e0c28e25075b"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"dc3cf6d17eb5a9439fed85c7cb05254b8a26749b","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"**Example 2** When both image meta properties are set the emulation"},{"line_number":93,"context_line":"architecture will take precedent, and it will build on any host that"},{"line_number":94,"context_line":"supports emulatating X86_64."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* ``hw_emulation_architecture \u003d X86_64``"},{"line_number":97,"context_line":"* ``hw_Architecture \u003d AARCH64``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"73c19ed0_45b11b77","line":94,"range":{"start_line":94,"start_character":9,"end_line":94,"end_character":20},"in_reply_to":"d3d3bf67_bfe70d20","updated":"2022-01-12 13:14:13.000000000","message":"Done","commit_id":"34f32834dd9a0110c322e85eddc1e0c28e25075b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"af574df35ebe4b3b7e06a15db5dd3c3d9fea7a1c","unresolved":true,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"   arch \u003d self._check_emulation_arch(image_meta)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Alternatives"},{"line_number":178,"context_line":"------------"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"2f2f1e74_e9e07435","line":176,"updated":"2022-01-12 10:32:57.000000000","message":"Do we know that libvirt support all the lifecycle actions for these emulated guests? I.e. can we pause, suspend, migrate, live-migrate these VMs? We at least need to document what is supported.","commit_id":"34f32834dd9a0110c322e85eddc1e0c28e25075b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"52840829a42daef3e5a5557befc25416b898ed8a","unresolved":true,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"   arch \u003d self._check_emulation_arch(image_meta)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Alternatives"},{"line_number":178,"context_line":"------------"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ae4fcd3d_9e1cec26","line":176,"in_reply_to":"2f2f1e74_e9e07435","updated":"2022-01-12 11:26:06.000000000","message":"yes we shoudl be able too.\n\nkeep in mind that we do all our testing upstream with qemu not kvm in the gate\nthe fact that its x86 on x86 is not really important from my understanding\n\nif it was arm on x86 i woudl expect the simple life cycle operatiosn to more or less work the same.\n\nwhere we may encounter difference are things liek volume or nic attach/detach as all archteure might\nnot support pci or hotplug or may have limits that differe form the x86 pc/q35 machine types.\n\nwe shoudl be able to do some level of testing in the first party ci just by useing an arm cirros image or simialr with tempest. im not sure we want to do that on every patch but we certenly could add a periodic nightly or weekly job to exercise tempest fully multinode  with all relevent emulated architetures.\n\nif we see an opteration is broken for a combination we can certenly block it but i woudl expect most to work.","commit_id":"34f32834dd9a0110c322e85eddc1e0c28e25075b"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"dc3cf6d17eb5a9439fed85c7cb05254b8a26749b","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"   arch \u003d self._check_emulation_arch(image_meta)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Alternatives"},{"line_number":178,"context_line":"------------"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"e6a8ae6f_79a43211","line":176,"in_reply_to":"ae4fcd3d_9e1cec26","updated":"2022-01-12 13:14:13.000000000","message":"added additional section stating that testing has been done and lifecycle action are not affected, also includes list of the archs and current states. I just validated that again this morning on our deployment. see patchset 3 for changes.","commit_id":"34f32834dd9a0110c322e85eddc1e0c28e25075b"}]}