)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9192fff0089683c1848eca8926ae71664b2ac9d4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"db8e26dd_e76ebc1a","updated":"2022-01-11 15:08:40.000000000","message":"as noted on teh code review this does not have enough detail.\n\n\nfor example the commit message of the implmenation states that \n\nThe Cinder driver for LightOS currently supports the following functionality:\n\nCreate volume\nDelete volume\nAttach volume\nDetach volume\nCreate image from volume\ncreate volume from image\nLive migration\nVolume replication\nThin provisioning\nMulti-attach\nExtend volume\nCreate snapshot\nDelete snapshot\nCreate volume from snapshot\nCreate volume from volume (clone)\n\nthat should be captured in teh spec.\n\nyou shoudl also make it clear however that you are refering to an out of tree cinder driver.\nyou need to ahva a second spec for adding the cinder driver in three and the nova spec need to depend on that before we can merged this.\n\n\n","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c5f0e49e_e6031a14","in_reply_to":"db8e26dd_e76ebc1a","updated":"2022-01-12 12:13:58.000000000","message":"Thank you, I have rewritten the spec per your feedback (version 3 will be posted in a bit). For what it\u0027s worth, the nova libvirt driver on its own is minuscule, most of the work is done in the cinder and os_brick parts. Therefore I kept the nova spec small, since the Nova part is just boiler plate and one important function. Makes sense?","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ed3960e9_36686194","updated":"2022-01-12 12:13:58.000000000","message":"Thank you for the feedback","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3fe6b7dcef9958fb761dd03893adb539000e501d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f4b5e4eb_421adcfa","updated":"2022-01-12 09:51:52.000000000","message":"This spec looks me a good use case, but I have a few thoughts at least for upgrading and how to verify this would work with documentation and tests.","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0d85379cbde7cef5f6cca180f29266f3c75f615e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"65500735_0dbbdf41","updated":"2022-01-12 13:13:34.000000000","message":"Sorry but I still have concerns.","commit_id":"b3ace207f2689627b313367b524b51d5c43df27f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"255ade5a52272a0ffb883b95ea19f22453f1abb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"94d0b6ed_16976c75","updated":"2022-01-12 12:49:18.000000000","message":"given the limited scope of the changes in nova\ni think im ok with this as proposed.\n\nwe should hold merging the nova code until the cinder and os-brick code lands but i think the spec \nis now fine to merge.","commit_id":"b3ace207f2689627b313367b524b51d5c43df27f"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"33b9380ecd2023683667f174d6f08f94ab3de782","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e6a7d644_3d9263cc","updated":"2022-01-12 12:54:21.000000000","message":"updated topic","commit_id":"b3ace207f2689627b313367b524b51d5c43df27f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7f62dbc49f937b0130cef8296f1ac0cd80cf66ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"78a384c6_d0eea9b9","updated":"2022-01-13 08:47:46.000000000","message":"Looks good to me.","commit_id":"f752ed139783416e2cefa53bda08d8100d685355"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"abfa47f656bfb4c8112a9830d555ef6dc0ff52f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"465c5aac_3143f89e","updated":"2022-01-13 11:55:57.000000000","message":"Thanks for fixing my nits. \nI see that https://blueprints.launchpad.net/cinder/+spec/cinder-lightos-driver is accepted, so eventually I\u0027m all good for this one, thanks ! ","commit_id":"f752ed139783416e2cefa53bda08d8100d685355"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"28a8929ddca3074f8b7fc8e8fa5ff3e366d79727","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7028a057_94c194d1","updated":"2022-01-13 10:46:17.000000000","message":"im going too upgrade to a +2 but i would still like sylvain to review and provide the +w\nif there issues have been addressed.","commit_id":"f752ed139783416e2cefa53bda08d8100d685355"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6f31696cb54ad46d5d092945369ed49bc83b2b49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"68819662_78fa1cb1","updated":"2022-01-12 17:59:15.000000000","message":"im still fine with this\ni think you have adress most of sylvains itmes but ill stay at +1 until they confirm.","commit_id":"f752ed139783416e2cefa53bda08d8100d685355"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"28fb5645b0ee4a4c433b01937be1d297dd8a95aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"76837b03_c83f8d89","in_reply_to":"68819662_78fa1cb1","updated":"2022-01-12 18:02:02.000000000","message":"Thanks Sean. Sylvain, let us know if there are any outstanding issues and we\u0027ll fix.","commit_id":"f752ed139783416e2cefa53bda08d8100d685355"}],"specs/yoga/approved/lightos_volume_driver.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3e09948df3805df94326f9426c333fd98ce08dec","unresolved":true,"context_lines":[{"line_number":1,"context_line":"This work is licensed under a Creative Commons Attribution 3.0"},{"line_number":2,"context_line":"Unported License."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"Lightbits LightOS(TM) Nova Spec"}],"source_content_type":"text/x-rst","patch_set":2,"id":"c41a3247_c12b9d98","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":52},"updated":"2022-01-12 10:09:36.000000000","message":"please use the format from the template\n\n..\n This work is licensed under a Creative Commons Attribution 3.0 Unported\n License.\n\n http://creativecommons.org/licenses/by/3.0/legalcode\n\nas this makes the pep8 failing with missing sections","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This work is licensed under a Creative Commons Attribution 3.0"},{"line_number":2,"context_line":"Unported License."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"Lightbits LightOS(TM) Nova Spec"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f6bf22da_c56ecaa9","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":52},"in_reply_to":"c41a3247_c12b9d98","updated":"2022-01-12 12:13:58.000000000","message":"Thanks, we fixed the formatting, will upload a new version in a bit.","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"522358eb440bf097fb95baea7d6079f42e1fcce2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"This work is licensed under a Creative Commons Attribution 3.0"},{"line_number":2,"context_line":"Unported License."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"Lightbits LightOS(TM) Nova Spec"}],"source_content_type":"text/x-rst","patch_set":2,"id":"c9549149_dc34e2e2","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":52},"in_reply_to":"c41a3247_c12b9d98","updated":"2022-01-12 11:17:07.000000000","message":"yep the format for the template is puting it in a comment so it wont be renderd in the html version","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3fe6b7dcef9958fb761dd03893adb539000e501d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Lightbits LightOS(TM) Nova Spec"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"https://blueprints.launchpad.net/nova/spec/nova-support-lightos-driver"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"100ca242_6e446704","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":1},"updated":"2022-01-12 09:51:52.000000000","message":"nit: not necessary line, you can remove it.","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Lightbits LightOS(TM) Nova Spec"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"https://blueprints.launchpad.net/nova/spec/nova-support-lightos-driver"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"d072c75b_6cf7a419","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":1},"in_reply_to":"100ca242_6e446704","updated":"2022-01-12 12:13:58.000000000","message":"Thank you, removed.","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3e09948df3805df94326f9426c333fd98ce08dec","unresolved":true,"context_lines":[{"line_number":12,"context_line":"https://blueprints.launchpad.net/nova/spec/nova-support-lightos-driver"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Lightbits Labs (http://www.lightbitslabs.com) LightOS(TM) is software-defined,"},{"line_number":15,"context_line":" cloud native, high-performance, scale-out and redundant clustered NVMe/TCP"},{"line_number":16,"context_line":"storage that performs like local NVMe flash."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The nova Lightbits LightOS libvirt volume driver works with LightOS"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b0a11889_f3c378ed","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":1},"updated":"2022-01-12 10:09:36.000000000","message":"drop the leading space, this makes the doc generation fail with https://zuul.opendev.org/t/openstack/build/91de57722fcc41c7870825e500ed815a/log/job-output.txt#1579","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"https://blueprints.launchpad.net/nova/spec/nova-support-lightos-driver"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Lightbits Labs (http://www.lightbitslabs.com) LightOS(TM) is software-defined,"},{"line_number":15,"context_line":" cloud native, high-performance, scale-out and redundant clustered NVMe/TCP"},{"line_number":16,"context_line":"storage that performs like local NVMe flash."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The nova Lightbits LightOS libvirt volume driver works with LightOS"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f2c3891_a1ec6532","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":1},"in_reply_to":"b0a11889_f3c378ed","updated":"2022-01-12 12:13:58.000000000","message":"Thank you, removed.","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3fe6b7dcef9958fb761dd03893adb539000e501d","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"We add a new libvirt volume driver to nova that will provide"},{"line_number":52,"context_line":"functionalities of attach, detach and extend to a LightOS cluster"},{"line_number":53,"context_line":"volume, as well as querying which instances exist on startup (e.g.,"},{"line_number":54,"context_line":"after reboot of power failure). This is being added concurrently with"},{"line_number":55,"context_line":"the LightOS support for cinder and for os_brick."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bc1273f2_f6cdb988","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":60},"updated":"2022-01-12 09:51:52.000000000","message":"this looks an implementation detail, but OK. What you mean is that when restarting the service, this volume driver will verify the instance XMLs,right?","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"We add a new libvirt volume driver to nova that will provide"},{"line_number":52,"context_line":"functionalities of attach, detach and extend to a LightOS cluster"},{"line_number":53,"context_line":"volume, as well as querying which instances exist on startup (e.g.,"},{"line_number":54,"context_line":"after reboot of power failure). This is being added concurrently with"},{"line_number":55,"context_line":"the LightOS support for cinder and for os_brick."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"cb7a7de5_7987311e","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":60},"in_reply_to":"3d1449df_c63c642b","updated":"2022-01-12 12:13:58.000000000","message":"Let me try to explain what we see happening. If there is a better way to solve it, we\u0027ll be happy to do it. Let\u0027s say for the sake of simplicity that there is one VM running and attached to a host-mounted NVMe/TCP volume connected to the LightOS cluster. When the compute host goes down and comes back up, something on the host needs to reattach to that LightOS volume so that the device file will show up and the VM will reattach to it. So on nova libvirt volume driver startup we scan the list of instances on the compute host, figure out which should be connected to LightOS volumes (and to which LightOS volumes), and then connect to them so that the device files will show up. Then nova reattaches those device files to the appropriate instances. Makes sense or is there some flow we are missing that should have caused this to happen \"automatically\" (i.e, without our libvirt volume driver involvement?)","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"522358eb440bf097fb95baea7d6079f42e1fcce2","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"We add a new libvirt volume driver to nova that will provide"},{"line_number":52,"context_line":"functionalities of attach, detach and extend to a LightOS cluster"},{"line_number":53,"context_line":"volume, as well as querying which instances exist on startup (e.g.,"},{"line_number":54,"context_line":"after reboot of power failure). This is being added concurrently with"},{"line_number":55,"context_line":"the LightOS support for cinder and for os_brick."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3d1449df_c63c642b","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":60},"in_reply_to":"bc1273f2_f6cdb988","updated":"2022-01-12 11:17:07.000000000","message":"will the volume driver actuly do this.\n\nthe way this normally works is the compute manageer loops over all current isntnace on agent startup and ensueres they are provisioned correctly fi they are active.\n\nif you have set the config option to resume guest on host reboot then the agent will start the instances that shoudl be running.\n\nthe voluem driver shoudl not need to query for any instances at start up as it will be invoked by the compute manage and libvirt drver for each instance that should be started.\n\nos-brick and the volume driver shoudl not proactivaly be trying to mount anything on the host unles nova asks it too.","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"522358eb440bf097fb95baea7d6079f42e1fcce2","unresolved":true,"context_lines":[{"line_number":57,"context_line":"NVMe/TCP volumes are host mounted. The os_brick connector connects as"},{"line_number":58,"context_line":"needed to the LightOS cluster via NVMe/TCP and exposes host device"},{"line_number":59,"context_line":"files to the nova node. From the libvirt/QEMU point of view, the files"},{"line_number":60,"context_line":"are then attached/detached to instances."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Although LightOS works with VMware and other container and"},{"line_number":63,"context_line":"virtualization environments as well, LightOS openstack support has"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7fa967a6_a6e290c7","line":60,"updated":"2022-01-12 11:17:07.000000000","message":"ack so form a qemu point of view its just attaching a local block device that the os_brick deiver \nhas already attach to the host","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"NVMe/TCP volumes are host mounted. The os_brick connector connects as"},{"line_number":58,"context_line":"needed to the LightOS cluster via NVMe/TCP and exposes host device"},{"line_number":59,"context_line":"files to the nova node. From the libvirt/QEMU point of view, the files"},{"line_number":60,"context_line":"are then attached/detached to instances."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Although LightOS works with VMware and other container and"},{"line_number":63,"context_line":"virtualization environments as well, LightOS openstack support has"}],"source_content_type":"text/x-rst","patch_set":2,"id":"8c6bd839_161b1506","line":60,"in_reply_to":"7fa967a6_a6e290c7","updated":"2022-01-12 12:13:58.000000000","message":"Exactly","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3fe6b7dcef9958fb761dd03893adb539000e501d","unresolved":true,"context_lines":[{"line_number":60,"context_line":"are then attached/detached to instances."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Although LightOS works with VMware and other container and"},{"line_number":63,"context_line":"virtualization environments as well, LightOS openstack support has"},{"line_number":64,"context_line":"only been tested and deployed in libvirt-based environments."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Live migration with multi-attach is fully supported and there are no"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4e05078a_5c362345","line":63,"range":{"start_line":63,"start_character":62,"end_line":63,"end_character":66},"updated":"2022-01-12 09:51:52.000000000","message":"nit: *will*","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"are then attached/detached to instances."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Although LightOS works with VMware and other container and"},{"line_number":63,"context_line":"virtualization environments as well, LightOS openstack support has"},{"line_number":64,"context_line":"only been tested and deployed in libvirt-based environments."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Live migration with multi-attach is fully supported and there are no"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ea0a25b1_ed9a371a","line":63,"range":{"start_line":63,"start_character":62,"end_line":63,"end_character":66},"in_reply_to":"4e05078a_5c362345","updated":"2022-01-12 12:13:58.000000000","message":"ack","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"522358eb440bf097fb95baea7d6079f42e1fcce2","unresolved":true,"context_lines":[{"line_number":63,"context_line":"virtualization environments as well, LightOS openstack support has"},{"line_number":64,"context_line":"only been tested and deployed in libvirt-based environments."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Live migration with multi-attach is fully supported and there are no"},{"line_number":67,"context_line":"network requirements. LightOS works via NVMe/TCP that works over any"},{"line_number":68,"context_line":"TCP/IP network."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Alternatives"},{"line_number":71,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b4a11788_53fd7a8c","line":68,"range":{"start_line":66,"start_character":51,"end_line":68,"end_character":15},"updated":"2022-01-12 11:17:07.000000000","message":".\n\ndelete the rest form here\n\ntechnically the storage server ip needs to be routable and what ever port needs to be used to connect the storage backend need to be open in the firwall.\n\nthat not really relevnet in this section but its relevent in Other deployer impact\nif you want to specify there are no speicl requirement beyond standard ip connectivity can you  specify it there.\n\nif they are doing a multi cell or multi az deployment they may need to factor in how lightos scales over lower bandwidth high latency links like a wan link between data centers or to an edge site. you typically do not want to streach any block storage backend over such a link, i assume the same is true here.","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"virtualization environments as well, LightOS openstack support has"},{"line_number":64,"context_line":"only been tested and deployed in libvirt-based environments."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Live migration with multi-attach is fully supported and there are no"},{"line_number":67,"context_line":"network requirements. LightOS works via NVMe/TCP that works over any"},{"line_number":68,"context_line":"TCP/IP network."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Alternatives"},{"line_number":71,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"2927c556_a9830b13","line":68,"range":{"start_line":66,"start_character":51,"end_line":68,"end_character":15},"in_reply_to":"b4a11788_53fd7a8c","updated":"2022-01-12 12:13:58.000000000","message":"Changed: \"Live migration with multi-attach is fully supported and there are no special network requirements. LightOS works via NVMe/TCP that works over any TCP/IP network. The LightOS cluster needs to be reachable (routable) over TCP/IP from the compute nodes and network bandwidhshould be provisioned to support the desired storage bandwidth and latency.\"","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"522358eb440bf097fb95baea7d6079f42e1fcce2","unresolved":true,"context_lines":[{"line_number":90,"context_line":"instances. A malicious instance which breaks out of the KVM/QEMU"},{"line_number":91,"context_line":"confinement and gains root privileges on the host could conceivably"},{"line_number":92,"context_line":"access other instances data."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Notifications impact"},{"line_number":95,"context_line":"--------------------"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"f176c910_389d19fa","line":93,"updated":"2022-01-12 11:17:07.000000000","message":"+1","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"instances. A malicious instance which breaks out of the KVM/QEMU"},{"line_number":91,"context_line":"confinement and gains root privileges on the host could conceivably"},{"line_number":92,"context_line":"access other instances data."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Notifications impact"},{"line_number":95,"context_line":"--------------------"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"6e30efec_ba31737c","line":93,"in_reply_to":"f176c910_389d19fa","updated":"2022-01-12 12:13:58.000000000","message":"Ack","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3fe6b7dcef9958fb761dd03893adb539000e501d","unresolved":true,"context_lines":[{"line_number":122,"context_line":"Upgrade impact"},{"line_number":123,"context_line":"--------------"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"None"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"115f5245_54126a39","line":125,"updated":"2022-01-12 09:51:52.000000000","message":"really ? What would happen if some operator rolling-upgrades [1] the nova-compute services and doesn\u0027t yet upgrade all of them, where some of them are then Xena ?\n\nHow can we be sure we won\u0027t then create instances in Xena computes if we use LightOS ?\n\n[1] https://docs.openstack.org/nova/latest/admin/upgrades.html#rolling-upgrade-process","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"36941f61865c539074ce4df04fe5973aef3b8979","unresolved":false,"context_lines":[{"line_number":122,"context_line":"Upgrade impact"},{"line_number":123,"context_line":"--------------"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"None"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5ac54805_42477c8d","line":125,"in_reply_to":"0805e719_17c47ec2","updated":"2022-01-12 12:35:41.000000000","message":"backend are mapped to volume types.\nso when you select a volume type when creating a volume it defines the backend that is used.\n\ncurrently there is no end to end supprot for schduling based on the availability of the volume type\n\nideally cinder would map the sotage backedn to placement resouce providers and use the mis_shares_via_aggreate trait. then you woudl map all the reachable compute to that aggreate using provider.yaml and the volume would then include a member_of \u003caggreate_uuid\u003e that would be passed to placment to schduler correctly.\n\n\nthat is the correct way to do that.\n\nthe cinder schduler does not really com into it most of the time.","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"Upgrade impact"},{"line_number":123,"context_line":"--------------"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"None"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"0805e719_17c47ec2","line":125,"in_reply_to":"115f5245_54126a39","updated":"2022-01-12 12:13:58.000000000","message":"That\u0027s a good point. Let me look into it. How do other external storage drivers deal with it? My (possibly naive) expectation is that the Cinder block scheduler will only try to use LightOS storage on compute hosts where nova and os_brick have been upgraded to Yoga with LightOS support, but I do not know that cinder actually does this?","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3fe6b7dcef9958fb761dd03893adb539000e501d","unresolved":true,"context_lines":[{"line_number":159,"context_line":"Documentation Impact"},{"line_number":160,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"None"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"References"},{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"50e05e58_ac6b2e47","line":162,"updated":"2022-01-12 09:51:52.000000000","message":"Hmmm, really ?","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":159,"context_line":"Documentation Impact"},{"line_number":160,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"None"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"References"},{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abfceec_97d7b5a1","line":162,"in_reply_to":"50e05e58_ac6b2e47","updated":"2022-01-12 12:13:58.000000000","message":"err.... perhaps not? :-) in the next revision we add a README to the cinder driver that explains how to set up the cinder.conf for LightOS. Is there a better location for it?","commit_id":"9b6d768249a82053cefd5d4178fc2d513581d083"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0d85379cbde7cef5f6cca180f29266f3c75f615e","unresolved":true,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"LightOS cluster must be installed and configured and the The Lightbits"},{"line_number":114,"context_line":"Labs discovery-client service must run on compute nodes. For more"},{"line_number":115,"context_line":"details, see the README included with the cinder driver."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Developer impact"},{"line_number":118,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"6f68958c_2e3a76c4","line":115,"range":{"start_line":115,"start_character":8,"end_line":115,"end_character":56},"updated":"2022-01-12 13:13:34.000000000","message":"I\u0027d prefer to provide a link here to the right Cinder upstream documentation.","commit_id":"b3ace207f2689627b313367b524b51d5c43df27f"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"afc76d03b934e751dd898b9b5221a8a45d795d1a","unresolved":true,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"LightOS cluster must be installed and configured and the The Lightbits"},{"line_number":114,"context_line":"Labs discovery-client service must run on compute nodes. For more"},{"line_number":115,"context_line":"details, see the README included with the cinder driver."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Developer impact"},{"line_number":118,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"4cd8ac6c_f17737b2","line":115,"range":{"start_line":115,"start_character":8,"end_line":115,"end_character":56},"in_reply_to":"6f68958c_2e3a76c4","updated":"2022-01-12 14:07:02.000000000","message":"ok I will place it under:\ncinder/doc/source/configuration/block-storage/drivers/lightos-volume-driver.rst","commit_id":"b3ace207f2689627b313367b524b51d5c43df27f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0d85379cbde7cef5f6cca180f29266f3c75f615e","unresolved":true,"context_lines":[{"line_number":123,"context_line":"Upgrade impact"},{"line_number":124,"context_line":"--------------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"None"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"27e598d7_3773782f","line":126,"updated":"2022-01-12 13:13:34.000000000","message":"as Sean said in his comment and as I asked for it, you should explain that even if we don\u0027t have upgrade impact, operators should use traits for the nova-computes supporting this backend or using a placement aggregate if they use rolling-upgrades (and the Nova documentation for it should do it again)","commit_id":"b3ace207f2689627b313367b524b51d5c43df27f"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"afc76d03b934e751dd898b9b5221a8a45d795d1a","unresolved":true,"context_lines":[{"line_number":123,"context_line":"Upgrade impact"},{"line_number":124,"context_line":"--------------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"None"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"b19d1a6c_9d6883da","line":126,"in_reply_to":"27e598d7_3773782f","updated":"2022-01-12 14:07:02.000000000","message":"Ok thank you, will add a note on this","commit_id":"b3ace207f2689627b313367b524b51d5c43df27f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"28a8929ddca3074f8b7fc8e8fa5ff3e366d79727","unresolved":true,"context_lines":[{"line_number":123,"context_line":"Upgrade impact"},{"line_number":124,"context_line":"--------------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"None"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"07a4ddfa_14939241","line":126,"in_reply_to":"7aa242ac_96700def","updated":"2022-01-13 10:46:17.000000000","message":"honestly even if you dont do this the wrost that will happen is a reschdule when it fail on the compute and possibel no valid host if that happens 3 times in a row.\n\nnot the best user experince but it wont actully break anything.","commit_id":"b3ace207f2689627b313367b524b51d5c43df27f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7f62dbc49f937b0130cef8296f1ac0cd80cf66ca","unresolved":true,"context_lines":[{"line_number":123,"context_line":"Upgrade impact"},{"line_number":124,"context_line":"--------------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"None"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa242ac_96700def","line":126,"in_reply_to":"b19d1a6c_9d6883da","updated":"2022-01-13 08:47:46.000000000","message":"If I were the operator upgrading to Yoga with this feature implemented I would upgrade first and then configure lightos volume support in the backend / cinder. This way there would be really zero upgrade impact on OpenStack.","commit_id":"b3ace207f2689627b313367b524b51d5c43df27f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0d85379cbde7cef5f6cca180f29266f3c75f615e","unresolved":true,"context_lines":[{"line_number":142,"context_line":"Work Items"},{"line_number":143,"context_line":"----------"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"None"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Dependencies"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5e7ddd04_de5f041f","line":145,"updated":"2022-01-12 13:13:34.000000000","message":"you should explain more which work items you have. Something like :\n\n- create a new volume driver for lightos\n- upgrade the os-brick version dependency to use the new one (which one ?)\n- modify somewhere in libvirt (maybe around init_host() ?) to verify the instances","commit_id":"b3ace207f2689627b313367b524b51d5c43df27f"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"afc76d03b934e751dd898b9b5221a8a45d795d1a","unresolved":true,"context_lines":[{"line_number":142,"context_line":"Work Items"},{"line_number":143,"context_line":"----------"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"None"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Dependencies"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5555a2d5_85b89675","line":145,"in_reply_to":"5e7ddd04_de5f041f","updated":"2022-01-12 14:07:02.000000000","message":"ok, thank you I will create:\n- create a new volume driver for lightos\n- upgrade the os-brick version dependency to \"yoga\"","commit_id":"b3ace207f2689627b313367b524b51d5c43df27f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbdb6865249c63e3dda2f62170bd502fcfb55679","unresolved":true,"context_lines":[{"line_number":142,"context_line":"Work Items"},{"line_number":143,"context_line":"----------"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"None"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Dependencies"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"035e7e06_526a6d21","line":145,"in_reply_to":"5e7ddd04_de5f041f","updated":"2022-01-12 14:00:14.000000000","message":"this is hte fully impleenmation of the nova change\nhttps://review.opendev.org/c/openstack/nova/+/821606\n\nso no init_host changes needed.\n\nthat is why i was not sure the statement was acurate with regardes to the init behaivor.\n\ni belive its really the compute manager that drives that.\n\nspeifcicly its this loop over the instnaces \nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1450-L1452\nthat checks the isntance state and then trivers the volumes to be set back up when starting the vms if they shoudl be started.\n\ni belive \nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1064-L1088\nwill start the instance that shoudl be runnign after the hsot reboot.\n\n\nthat will go through the hard reboot workflow and that shoudl set up the volumes again.","commit_id":"b3ace207f2689627b313367b524b51d5c43df27f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0d85379cbde7cef5f6cca180f29266f3c75f615e","unresolved":true,"context_lines":[{"line_number":160,"context_line":"Documentation Impact"},{"line_number":161,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Documentation for lightos will be added."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"References"},{"line_number":166,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"28bf188f_7ef20a49","line":163,"updated":"2022-01-12 13:13:34.000000000","message":"where ? Could you please explain that you need to modify the current Cinder documentation you would have and telling in Nova to look at it?","commit_id":"b3ace207f2689627b313367b524b51d5c43df27f"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"afc76d03b934e751dd898b9b5221a8a45d795d1a","unresolved":true,"context_lines":[{"line_number":160,"context_line":"Documentation Impact"},{"line_number":161,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Documentation for lightos will be added."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"References"},{"line_number":166,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dfa7b3b4_6d2d97c2","line":163,"in_reply_to":"28bf188f_7ef20a49","updated":"2022-01-12 14:07:02.000000000","message":"Ok, will add and link to:\ncinder/doc/source/configuration/block-storage/drivers/lightos-volume-driver.rst","commit_id":"b3ace207f2689627b313367b524b51d5c43df27f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"715a0f9948e4621e8a4d6429f3d97149c3c8d4d9","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The LightOS volumes are first mounted by the libvirt host, which then"},{"line_number":90,"context_line":"passes them to QEMU as local host files to attach/detach to"},{"line_number":91,"context_line":"instances. A malicious instance which breaks out of the KVM/QEMU"},{"line_number":92,"context_line":"confinement and gains root privileges on the host could conceivably"},{"line_number":93,"context_line":"access other instances data."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Notifications impact"},{"line_number":96,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9266feae_1ea1ab43","line":93,"range":{"start_line":91,"start_character":11,"end_line":93,"end_character":28},"updated":"2022-01-12 15:41:02.000000000","message":"like some other volume drivers... I\u0027m not really sure we need to say it here.","commit_id":"eac4f80c3868a6899583c072d73a27ccb55be608"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"73f89476648c095b883fa5d2ee3da7ba6e1de6ef","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The LightOS volumes are first mounted by the libvirt host, which then"},{"line_number":90,"context_line":"passes them to QEMU as local host files to attach/detach to"},{"line_number":91,"context_line":"instances. A malicious instance which breaks out of the KVM/QEMU"},{"line_number":92,"context_line":"confinement and gains root privileges on the host could conceivably"},{"line_number":93,"context_line":"access other instances data."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Notifications impact"},{"line_number":96,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"31b7bf60_39d6d68d","line":93,"range":{"start_line":91,"start_character":11,"end_line":93,"end_character":28},"in_reply_to":"9266feae_1ea1ab43","updated":"2022-01-12 17:03:07.000000000","message":"Ack","commit_id":"eac4f80c3868a6899583c072d73a27ccb55be608"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"715a0f9948e4621e8a4d6429f3d97149c3c8d4d9","unresolved":true,"context_lines":[{"line_number":113,"context_line":"LightOS cluster must be installed and configured and the The Lightbits"},{"line_number":114,"context_line":"Labs discovery-client service must run on compute nodes. For more"},{"line_number":115,"context_line":"details, see the README included with the cinder driver:"},{"line_number":116,"context_line":"cinder/doc/source/configuration/block-storage/drivers/lightos-volume-driver.rst"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Developer impact"},{"line_number":119,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3c8812fa_6ce2a074","line":116,"updated":"2022-01-12 15:41:02.000000000","message":"that\u0027s not worked. Use an hyperlink here or provide the change for Cinder. See other specs for examples.","commit_id":"eac4f80c3868a6899583c072d73a27ccb55be608"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"73f89476648c095b883fa5d2ee3da7ba6e1de6ef","unresolved":false,"context_lines":[{"line_number":113,"context_line":"LightOS cluster must be installed and configured and the The Lightbits"},{"line_number":114,"context_line":"Labs discovery-client service must run on compute nodes. For more"},{"line_number":115,"context_line":"details, see the README included with the cinder driver:"},{"line_number":116,"context_line":"cinder/doc/source/configuration/block-storage/drivers/lightos-volume-driver.rst"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Developer impact"},{"line_number":119,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"81fa2304_1a377b56","line":116,"in_reply_to":"3c8812fa_6ce2a074","updated":"2022-01-12 17:03:07.000000000","message":"Ack","commit_id":"eac4f80c3868a6899583c072d73a27ccb55be608"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"715a0f9948e4621e8a4d6429f3d97149c3c8d4d9","unresolved":true,"context_lines":[{"line_number":148,"context_line":"----------"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"- create a new volume driver for"},{"line_number":151,"context_line":"lightos (driver already available and posted for review)"},{"line_number":152,"context_line":"- upgrade os-brick to use a new os-brick with the LightOS"},{"line_number":153,"context_line":"connector (os_brick patches are available and posted for review)"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9de47fad_b66caf1a","line":151,"range":{"start_line":151,"start_character":7,"end_line":151,"end_character":56},"updated":"2022-01-12 15:41:02.000000000","message":"you don\u0027t need to say it, I\u0027ve seen your change https://review.opendev.org/c/openstack/nova/+/821606","commit_id":"eac4f80c3868a6899583c072d73a27ccb55be608"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"73f89476648c095b883fa5d2ee3da7ba6e1de6ef","unresolved":false,"context_lines":[{"line_number":148,"context_line":"----------"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"- create a new volume driver for"},{"line_number":151,"context_line":"lightos (driver already available and posted for review)"},{"line_number":152,"context_line":"- upgrade os-brick to use a new os-brick with the LightOS"},{"line_number":153,"context_line":"connector (os_brick patches are available and posted for review)"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"b17fe6e3_6c45163d","line":151,"range":{"start_line":151,"start_character":7,"end_line":151,"end_character":56},"in_reply_to":"9de47fad_b66caf1a","updated":"2022-01-12 17:03:07.000000000","message":"Ack","commit_id":"eac4f80c3868a6899583c072d73a27ccb55be608"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"715a0f9948e4621e8a4d6429f3d97149c3c8d4d9","unresolved":true,"context_lines":[{"line_number":150,"context_line":"- create a new volume driver for"},{"line_number":151,"context_line":"lightos (driver already available and posted for review)"},{"line_number":152,"context_line":"- upgrade os-brick to use a new os-brick with the LightOS"},{"line_number":153,"context_line":"connector (os_brick patches are available and posted for review)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Dependencies"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"91f58269_cfb1b17c","line":153,"range":{"start_line":153,"start_character":10,"end_line":153,"end_character":64},"updated":"2022-01-12 15:41:02.000000000","message":"same as above. You don\u0027t need to say it but you should provide the link.","commit_id":"eac4f80c3868a6899583c072d73a27ccb55be608"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"73f89476648c095b883fa5d2ee3da7ba6e1de6ef","unresolved":false,"context_lines":[{"line_number":150,"context_line":"- create a new volume driver for"},{"line_number":151,"context_line":"lightos (driver already available and posted for review)"},{"line_number":152,"context_line":"- upgrade os-brick to use a new os-brick with the LightOS"},{"line_number":153,"context_line":"connector (os_brick patches are available and posted for review)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Dependencies"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"06bc5770_d504c647","line":153,"range":{"start_line":153,"start_character":10,"end_line":153,"end_character":64},"in_reply_to":"91f58269_cfb1b17c","updated":"2022-01-12 17:03:07.000000000","message":"Ack","commit_id":"eac4f80c3868a6899583c072d73a27ccb55be608"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"715a0f9948e4621e8a4d6429f3d97149c3c8d4d9","unresolved":true,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"The LightOS libvirt volume driver requires the corresponding LightOS"},{"line_number":159,"context_line":"cinder driver and os_brick support.  Cinder blueprint is at:"},{"line_number":160,"context_line":"https://blueprints.launchpad.net/cinder/+spec/cinder-lightos-driver"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Testing"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"6c2b290f_a940308d","line":160,"updated":"2022-01-12 15:41:02.000000000","message":"Could you also add the os-brick change here ? I\u0027ve seen it : https://review.opendev.org/c/openstack/os-brick/+/821603","commit_id":"eac4f80c3868a6899583c072d73a27ccb55be608"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"73f89476648c095b883fa5d2ee3da7ba6e1de6ef","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"The LightOS libvirt volume driver requires the corresponding LightOS"},{"line_number":159,"context_line":"cinder driver and os_brick support.  Cinder blueprint is at:"},{"line_number":160,"context_line":"https://blueprints.launchpad.net/cinder/+spec/cinder-lightos-driver"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Testing"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"b03b54a9_7f29193b","line":160,"in_reply_to":"6c2b290f_a940308d","updated":"2022-01-12 17:03:07.000000000","message":"Ack","commit_id":"eac4f80c3868a6899583c072d73a27ccb55be608"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"715a0f9948e4621e8a4d6429f3d97149c3c8d4d9","unresolved":true,"context_lines":[{"line_number":158,"context_line":"The LightOS libvirt volume driver requires the corresponding LightOS"},{"line_number":159,"context_line":"cinder driver and os_brick support.  Cinder blueprint is at:"},{"line_number":160,"context_line":"https://blueprints.launchpad.net/cinder/+spec/cinder-lightos-driver"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Testing"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"866b212b_40139a29","line":161,"updated":"2022-01-12 15:41:02.000000000","message":"Please also provide the Cinder change themselves if you can.","commit_id":"eac4f80c3868a6899583c072d73a27ccb55be608"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"73f89476648c095b883fa5d2ee3da7ba6e1de6ef","unresolved":false,"context_lines":[{"line_number":158,"context_line":"The LightOS libvirt volume driver requires the corresponding LightOS"},{"line_number":159,"context_line":"cinder driver and os_brick support.  Cinder blueprint is at:"},{"line_number":160,"context_line":"https://blueprints.launchpad.net/cinder/+spec/cinder-lightos-driver"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Testing"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"e62eea5f_c21c161c","line":161,"in_reply_to":"866b212b_40139a29","updated":"2022-01-12 17:03:07.000000000","message":"Ack","commit_id":"eac4f80c3868a6899583c072d73a27ccb55be608"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"715a0f9948e4621e8a4d6429f3d97149c3c8d4d9","unresolved":true,"context_lines":[{"line_number":169,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Documentation for configuring lightos storage will be added to:"},{"line_number":172,"context_line":"cinder/doc/source/configuration/block-storage/drivers/lightos-volume-driver.rst"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"References"},{"line_number":175,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"d526a141_7c7c722a","line":172,"updated":"2022-01-12 15:41:02.000000000","message":"you need to make it an hyperlink. See other specs for examples.","commit_id":"eac4f80c3868a6899583c072d73a27ccb55be608"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"73f89476648c095b883fa5d2ee3da7ba6e1de6ef","unresolved":false,"context_lines":[{"line_number":169,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Documentation for configuring lightos storage will be added to:"},{"line_number":172,"context_line":"cinder/doc/source/configuration/block-storage/drivers/lightos-volume-driver.rst"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"References"},{"line_number":175,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"87cf10c1_8cedbe9d","line":172,"in_reply_to":"d526a141_7c7c722a","updated":"2022-01-12 17:03:07.000000000","message":"Ack","commit_id":"eac4f80c3868a6899583c072d73a27ccb55be608"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"715a0f9948e4621e8a4d6429f3d97149c3c8d4d9","unresolved":true,"context_lines":[{"line_number":183,"context_line":"Lightbits customers have been using (out-of-tree) cinder/nova/os_brick"},{"line_number":184,"context_line":"patches for LightOS support in openstack since 2019 or"},{"line_number":185,"context_line":"thereabouts. This spec is for the first public submission of the"},{"line_number":186,"context_line":"nova/cinder/os_brick LightOS support."}],"source_content_type":"text/x-rst","patch_set":4,"id":"b002f2f5_18e80e34","line":186,"updated":"2022-01-12 15:41:02.000000000","message":"No, you should just tell : \n\n  .. list-table:: Revisions\n     :header-rows: 1\n     * - Release Name\n       - Description\n     * - Yoga\n       - Introduced","commit_id":"eac4f80c3868a6899583c072d73a27ccb55be608"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"73f89476648c095b883fa5d2ee3da7ba6e1de6ef","unresolved":true,"context_lines":[{"line_number":183,"context_line":"Lightbits customers have been using (out-of-tree) cinder/nova/os_brick"},{"line_number":184,"context_line":"patches for LightOS support in openstack since 2019 or"},{"line_number":185,"context_line":"thereabouts. This spec is for the first public submission of the"},{"line_number":186,"context_line":"nova/cinder/os_brick LightOS support."}],"source_content_type":"text/x-rst","patch_set":4,"id":"8e4d6fe6_a99ff6d2","line":186,"in_reply_to":"b002f2f5_18e80e34","updated":"2022-01-12 17:03:07.000000000","message":"thanks, fixed","commit_id":"eac4f80c3868a6899583c072d73a27ccb55be608"}],"specs/yoga/lightos_volume_driver.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a19314fdb980263221acfa98f6f34a4689cf6194","unresolved":true,"context_lines":[{"line_number":20,"context_line":"Problem description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Nova does not support lightos cluster as backend storage."},{"line_number":24,"context_line":"A volume created throughCinder api is not exposed to Nova "},{"line_number":25,"context_line":"nodes and they can not consume it."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"467fdb17_4569b31d","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":34},"updated":"2022-01-11 15:26:45.000000000","message":"well, cinder does not support ligthos yet either.\n\nnova only support in-tree cinder drivers or protocols used by in tree\ndrivers.\n\n\nhow is the volume attached to the VM? is it host mounted or does qemu connect to it.\n\nfor that matter, you have not specified why virt driver you want to enable this for.\n\nI\u0027m assuming libvirt is based on https://review.opendev.org/c/openstack/nova/+/821606 but is lightos support with vmware or other drivers?","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Problem description"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Nova does not support lightos cluster as backend storage."},{"line_number":24,"context_line":"A volume created throughCinder api is not exposed to Nova "},{"line_number":25,"context_line":"nodes and they can not consume it."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ef694f13_754ad08d","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":34},"in_reply_to":"467fdb17_4569b31d","updated":"2022-01-12 12:13:58.000000000","message":"Our plan is to get both the cinder/os_brick and the nova parts merged for Yoga concurrently. We appreciate the feedback and are addressing it.\n\nWith regards to the volume attachment to the VM, I elaborated in the spec, but the short answer is that the host connects to the LightOS storage cluster via NVMe/TCP, leading to the creation of /dev/nvmeX device files, and those files are exposed to the VMs via the usual KVM/QEMU mechanisms (device hot plug). So unless I misunderstand what you mean by host mounted, it is host mounted.\n\nLightOS supports many different types of containerized and virtualized environments in addition to openstack, including VMware, but the LightOS openstack support has only been tested with libvirt.","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a19314fdb980263221acfa98f6f34a4689cf6194","unresolved":true,"context_lines":[{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"---------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"1. Attach a volume created by Cinder to a Nova node."},{"line_number":31,"context_line":"2. Detach a volume created by Cinder to a Nova node."},{"line_number":32,"context_line":"3. Extend an attached volume to provide higher capacity."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d5f5d5d9_97d62a16","line":32,"range":{"start_line":30,"start_character":1,"end_line":32,"end_character":56},"updated":"2022-01-11 15:26:45.000000000","message":"these are capablity that nova already has without lightos\n\nyou really should provide uscase that express why we shoudl add supprot for lightos\n\nwhat makes it differnt that would make it desirabel to support with nova for an operator.\n\nthese shoudl also be phased as usecases.\n\n\n\"As an operator i would like to leverage lightos with openstack to ....\"","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Use Cases"},{"line_number":28,"context_line":"---------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"1. Attach a volume created by Cinder to a Nova node."},{"line_number":31,"context_line":"2. Detach a volume created by Cinder to a Nova node."},{"line_number":32,"context_line":"3. Extend an attached volume to provide higher capacity."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"31a50dd9_efc46e39","line":32,"range":{"start_line":30,"start_character":1,"end_line":32,"end_character":56},"in_reply_to":"d5f5d5d9_97d62a16","updated":"2022-01-12 12:13:58.000000000","message":"Thank you, spec updated accordingly.","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a19314fdb980263221acfa98f6f34a4689cf6194","unresolved":true,"context_lines":[{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"We add a new plugin to Nova that will provide functionalities of attach,"},{"line_number":38,"context_line":" detach and extend to a lightos cluster volume."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Alternatives"},{"line_number":41,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8ffc57a8_8afb24ee","line":38,"updated":"2022-01-11 15:26:45.000000000","message":"you also intend to support Live migration with Multi-attach support\n\nare there constraint on how the network connectiy tot he stroage backend is implemented that woudl limit live migration.","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"We add a new plugin to Nova that will provide functionalities of attach,"},{"line_number":38,"context_line":" detach and extend to a lightos cluster volume."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Alternatives"},{"line_number":41,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"49353c91_fff3d830","line":38,"in_reply_to":"8ffc57a8_8afb24ee","updated":"2022-01-12 12:13:58.000000000","message":"Spec updated to address these. We do support live migration and also multi-attach.","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a19314fdb980263221acfa98f6f34a4689cf6194","unresolved":true,"context_lines":[{"line_number":55,"context_line":"Security impact"},{"line_number":56,"context_line":"---------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"None"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Notifications impact"},{"line_number":61,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"cdd3125b_29092a70","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":4},"updated":"2022-01-11 15:26:45.000000000","message":"if the volums are host mounted there are security impacts as they are avaiabel to the host to read.\n\nare they host mounted or conencted directly to the hypervior.","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Security impact"},{"line_number":56,"context_line":"---------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"None"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Notifications impact"},{"line_number":61,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5240311e_e32840e2","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":4},"in_reply_to":"cdd3125b_29092a70","updated":"2022-01-12 12:13:58.000000000","message":"Host mounted (see above). I clarified the security implications per your feedback.","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a19314fdb980263221acfa98f6f34a4689cf6194","unresolved":true,"context_lines":[{"line_number":76,"context_line":"---------------------"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Lightos cluster must be installed and configured. Lightbits labs "},{"line_number":79,"context_line":"discoverey-client service must run on compute nodes."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Developer impact"},{"line_number":82,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"465f4cee_903124bf","line":79,"updated":"2022-01-11 15:26:45.000000000","message":"can you provide a url ot documenation on how to do that.","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":76,"context_line":"---------------------"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Lightos cluster must be installed and configured. Lightbits labs "},{"line_number":79,"context_line":"discoverey-client service must run on compute nodes."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Developer impact"},{"line_number":82,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"91c7aa9f_9a90ce01","line":79,"in_reply_to":"465f4cee_903124bf","updated":"2022-01-12 12:13:58.000000000","message":"Updated the spec with a pointer to the README that will be included as part of the cinder driver. Please let me know if there is a better location for it.","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a19314fdb980263221acfa98f6f34a4689cf6194","unresolved":true,"context_lines":[{"line_number":81,"context_line":"Developer impact"},{"line_number":82,"context_line":"----------------"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Discuss things that will affect other developers working on OpenStack,"},{"line_number":85,"context_line":"such as:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* If the blueprint proposes a change to the driver API, discussion of how"},{"line_number":88,"context_line":"  other hypervisors would implement the feature is required."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Upgrade impact"},{"line_number":91,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f8b5b565_0d8ca102","line":88,"range":{"start_line":84,"start_character":0,"end_line":88,"end_character":60},"updated":"2022-01-11 15:26:45.000000000","message":"this is boiler plate and shoudl be remvoed.\n\nthere are no other developer impactes so far that i can see so set this to none.","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"Developer impact"},{"line_number":82,"context_line":"----------------"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Discuss things that will affect other developers working on OpenStack,"},{"line_number":85,"context_line":"such as:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* If the blueprint proposes a change to the driver API, discussion of how"},{"line_number":88,"context_line":"  other hypervisors would implement the feature is required."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Upgrade impact"},{"line_number":91,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c446c315_2d25ceb8","line":88,"range":{"start_line":84,"start_character":0,"end_line":88,"end_character":60},"in_reply_to":"f8b5b565_0d8ca102","updated":"2022-01-12 12:13:58.000000000","message":"Thanks, done.","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a19314fdb980263221acfa98f6f34a4689cf6194","unresolved":true,"context_lines":[{"line_number":114,"context_line":"Dependencies"},{"line_number":115,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"None"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Testing"},{"line_number":120,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"81ab42a9_f48bade7","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":4},"updated":"2022-01-11 15:26:45.000000000","message":"you need to list the cinder spec for the driver\nand this also has a depency on os-brick changes.","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Dependencies"},{"line_number":115,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"None"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Testing"},{"line_number":120,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"43d10683_84124b1d","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":4},"in_reply_to":"81ab42a9_f48bade7","updated":"2022-01-12 12:13:58.000000000","message":"Thanks, added a link to the cinder blueprint.","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a19314fdb980263221acfa98f6f34a4689cf6194","unresolved":true,"context_lines":[{"line_number":120,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Unittests were added to the patch."},{"line_number":123,"context_line":"third party ci hosted by lightbits."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"905aa856_5ef5db9b","line":123,"range":{"start_line":123,"start_character":0,"end_line":123,"end_character":35},"updated":"2022-01-11 15:26:45.000000000","message":"so we shoudl hold of merging any code in nova until cinder has merged the devier in tree and\nthe ci is up and runing yes so that we can use your third party ci to validat the code works end to end.","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"2f0683182fd6ca8298a0f6974c3137878743366e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Unittests were added to the patch."},{"line_number":123,"context_line":"third party ci hosted by lightbits."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6339eb9b_b25cdfc8","line":123,"range":{"start_line":123,"start_character":0,"end_line":123,"end_character":35},"in_reply_to":"905aa856_5ef5db9b","updated":"2022-01-12 12:13:58.000000000","message":"We are working on the third party CI and expect it will be running momentarily. Thanks!","commit_id":"682c81f5d0b60ba9f8b17cca7f8dd00ad16b9c0a"}]}