)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d8e437941b16d056da67614cb453a7636c826e72","unresolved":true,"context_lines":[{"line_number":10,"context_line":"``VNIC_SMARTNIC`` vnic type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"As discussed on IRC, this will run into a conflict with the existing"},{"line_number":13,"context_line":"Ironic use-case with SmartNICs since the remote_managed tag addition to"},{"line_number":14,"context_line":"an InstancePCIRequest is based the usage of ``VNIC_TYPE_SMARTNIC`` in"},{"line_number":15,"context_line":"the current design:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"https://meetings.opendev.org/irclogs/%23openstack-nova/%23openstack-nova.2022-02-07.log.html#t2022-02-07T15:49:56"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b397a106_c10b8656","line":14,"range":{"start_line":13,"start_character":36,"end_line":14,"end_character":66},"updated":"2022-02-08 10:47:45.000000000","message":"nit: the approved design adds a InstancePCIRequest based on the vnic type.\nironic nodes will not require or provide a virtual function and while therefor not\nschedule correctly with the approved design\n\n\n\nironic does not create a InstancePCIRequest so its the addtion of a InstancePCIRequest not the addtion of the remote_managed tag that is the problem\n\nInstancePCIRequest is not an sriov vnic type today.","commit_id":"2d33a9ec494fd352c6d436ad0be87e47e9b7a78c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"735b751e10a1c4f67e73119c02a7d8cc34bb41c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4ea33b89_af2ebc18","updated":"2022-02-08 12:09:31.000000000","message":"I\u0027m OK with this update. We found during the design that we need the new vnic type and this patch updates the spec to reflect the reality. ","commit_id":"2d33a9ec494fd352c6d436ad0be87e47e9b7a78c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"977b76ff85067e27742cce0e991dd5b7d72d346f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"68dc9fd3_7f772ebf","updated":"2022-02-08 13:27:08.000000000","message":"look like the docs failrue is real\nits not related to this patch so im going to upgrade to +2+w\nthen this can be rechecked when we fix whatever the issue is","commit_id":"2d33a9ec494fd352c6d436ad0be87e47e9b7a78c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"94c0a8ba5322ed076edd4ed5d5c26ceb2cfe3e49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6fa5dd55_8f4d9a6e","updated":"2022-02-08 12:08:23.000000000","message":"recheck (I cannot reproduce the doc build issue locally with the same sphinx versions so maybe it is resolved magically)","commit_id":"2d33a9ec494fd352c6d436ad0be87e47e9b7a78c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d8e437941b16d056da67614cb453a7636c826e72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"708a894e_63b38fcf","updated":"2022-02-08 10:47:45.000000000","message":"we need to fix the docs issue which is unrelated to your change then this might need a rebase but the updates look good +1 for now","commit_id":"2d33a9ec494fd352c6d436ad0be87e47e9b7a78c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"66f3cd44757f437ca429c7b9a8bdf309dbab0cd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"946087eb_21082fa8","in_reply_to":"6fa5dd55_8f4d9a6e","updated":"2022-02-08 15:42:00.000000000","message":"I can reproduce the doc build failure locally now. It is unrelated and I try to fix it with https://review.opendev.org/c/openstack/nova-specs/+/828368","commit_id":"2d33a9ec494fd352c6d436ad0be87e47e9b7a78c"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"7df40a962eb26cdb5d103cddcb47192c3a78b9aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ae6f1853_bf50978f","in_reply_to":"946087eb_21082fa8","updated":"2022-02-09 18:13:34.000000000","message":"Thanks, looks like that fixes it indeed. I rebased and it\u0027s good now but we\u0027ve lost the WF+1.","commit_id":"2d33a9ec494fd352c6d436ad0be87e47e9b7a78c"}]}