)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2c09daebe07265ce544d4b361fe443cf9e58b595","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Repropose volume backed server rebuild spec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec was proposed in Yoga cycle and now is retargeted for"},{"line_number":10,"context_line":"Zed cycle."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint volume-backed-server-rebuild"},{"line_number":13,"context_line":"Change-Id: I18287fabf5e0f52cbbe013dce55e4744bcce2bdd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"abed6338_623fcc90","line":10,"updated":"2022-05-10 09:35:36.000000000","message":"just a procedural note : you shouldn\u0027t move your Yoga spec to the Zed directory but you rather should create a new Zed file which is a copy of the Yoga spec, please.","commit_id":"889e0b94fe8c6c463845b1b068b96787f9a87b1e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7ce3375b3ac2595caa42a031724270d51893fdb7","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Repropose volume backed server rebuild spec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec was proposed in Yoga cycle and now is retargeted for"},{"line_number":10,"context_line":"Zed cycle."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint volume-backed-server-rebuild"},{"line_number":13,"context_line":"Change-Id: I18287fabf5e0f52cbbe013dce55e4744bcce2bdd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d89a971c_39c8309c","line":10,"in_reply_to":"abed6338_623fcc90","updated":"2022-05-10 23:11:27.000000000","message":"Yeah, need to copy the spec from yoga/ to zed/, please see this doc on how to do it:\nhttps://specs.openstack.org/openstack/nova-specs/readme.html#previously-approved-specifications\nNote that you will also need to update things in the spec that reference Yoga to say Zed and also at the bottom the Revisions table will need to be updated, example excerpt:\n\n  * - Yoga\n     - Introduced\n   * - Zed\n     - Reproposed","commit_id":"889e0b94fe8c6c463845b1b068b96787f9a87b1e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fc8046f9f0f9155335aa693aa3ab71e3194ac92a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Repropose volume backed server rebuild spec"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec was proposed in Yoga cycle and now is retargeted for"},{"line_number":10,"context_line":"Zed cycle."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint volume-backed-server-rebuild"},{"line_number":13,"context_line":"Change-Id: I18287fabf5e0f52cbbe013dce55e4744bcce2bdd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"48c63db4_9db915d2","line":10,"in_reply_to":"d89a971c_39c8309c","updated":"2022-05-11 12:22:47.000000000","message":"Done","commit_id":"889e0b94fe8c6c463845b1b068b96787f9a87b1e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2c09daebe07265ce544d4b361fe443cf9e58b595","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d4182fbd_ab9b4a44","updated":"2022-05-10 09:35:36.000000000","message":"Sorry for this harsh -1 but we need to keep track of specs we approved in previous releases.","commit_id":"889e0b94fe8c6c463845b1b068b96787f9a87b1e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"efaa90433c4de80342ba9b89d5e108d2baf692a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7f7acd5c_834c69de","updated":"2022-05-18 10:12:30.000000000","message":"Thanks Sean for the review. Replies inline.","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fc8046f9f0f9155335aa693aa3ab71e3194ac92a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2e17c5ff_dba4b839","updated":"2022-05-11 12:22:47.000000000","message":"Thanks Sylvian and Melanie for the review","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"884a91db368ac3f5cfad42d6b88a0f9304445e9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ab57684d_440be999","updated":"2022-05-24 17:34:46.000000000","message":"Just to summarize some of the IRC discussion (and MHO on the matter):\n\n1. We need a microversion to opt into the new behavior since the old behavior allows non-destructive rebuild of BFV instances if the image is not changing\n2. The new microversion should not require the \"yes I mean it\" flag and just assume that you know what you\u0027re doing if you have opted into the new behavior (i.e. always destroy the root disk in the new microversion)\n3. It would be ideal if the client side of this can require a little more confirmation from interactive users. If we know the server\u0027s current image, this would be ideal:\n\n if new_microversion and server.image_ref \u003d\u003d requested_image_ref:\n     if args.yes_really:\n         do_rebuild()\n     else:\n         raise UserError(\u0027Rebuilding always destroys the root disk in this version, pass --yes-really\u0027)\n\n4. We should have a test for the old and new microversions to make sure we continue to reject image changes on the old microversion and allow non-destructive ones on the new one.","commit_id":"15261ef15fb79b6662cae4986ee3f5c72ddc6127"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"01ff40c88b797fd81fb009c19045ff7e99b94674","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4144f53f_473d585b","in_reply_to":"ab57684d_440be999","updated":"2022-05-26 11:44:02.000000000","message":"yes i think this is workable.\n\nit avoid the need for end users to know if its boot form volume which is non tivial to discover after the fact form a nova show or similar as the bdms are not avoilabel as part of the nova server details reponce.\n\ni woudl be tempeted to make the osc chagne even simpler\n\nif new_microversion:\n     if args.yes_really:\n         do_rebuild()\n     else:\n         raise UserError(\u0027Rebuilding always destroys the root disk in this version, pass --yes-really\u0027)\n\n\nsince rebuidl is generally distructive but i under stand why you are limiting this to the new microversion.\n\nso +1 to this propsoal.","commit_id":"15261ef15fb79b6662cae4986ee3f5c72ddc6127"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"01ff40c88b797fd81fb009c19045ff7e99b94674","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c81f8b18_5879c8a6","updated":"2022-05-26 11:44:02.000000000","message":"some minor nits inlien but ya overall i guess im ok with this version.\ni still","commit_id":"c37af797d2462f77d5c6c753c6ea25a9c76a10d0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f8644b26dfcbddd863b143fa969a603f46a37179","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"02c71005_f848beff","updated":"2022-05-31 09:37:47.000000000","message":"Looks good to me but just a question about which client libraries would have this new parameter.","commit_id":"c90edf5adaec3a09c9f836fbb4cbdcd49d1224bf"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e46adfc5acfba31d700f1f34b78f96bc43190337","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"587c2531_678de44a","updated":"2022-06-01 16:26:59.000000000","message":"Thanks Rajat!","commit_id":"c90edf5adaec3a09c9f836fbb4cbdcd49d1224bf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1493367c964dd3d7fa1dffd8e3abf36c365e0670","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1076e313_ff6bb28b","updated":"2022-05-26 18:42:00.000000000","message":"Thanks Sean and Dan for the reviews.","commit_id":"c90edf5adaec3a09c9f836fbb4cbdcd49d1224bf"}],"specs/zed/approved/volume-backed-server-rebuild.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"600382b04bddc4d352916c0676df9a7aad4e4a86","unresolved":true,"context_lines":[{"line_number":37,"context_line":"First, change the existing API for rebuilding a volume-backed server."},{"line_number":38,"context_line":"Then the API flow would be:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"#. A new request parameter, ``reimage_boot_volume`` (boolean), will be added"},{"line_number":41,"context_line":"   to the existing reimage API call which, if ``True``, will indicate if the"},{"line_number":42,"context_line":"   user wants to reimage a volume backed instance. By default, it will be"},{"line_number":43,"context_line":"   ``False``."},{"line_number":44,"context_line":"#. Reject the request if ``reimage_boot_volume`` is passed as ``True`` and the"},{"line_number":45,"context_line":"   instance isn\u0027t booting from a volume."},{"line_number":46,"context_line":"#. Has the new API microversion been requested. If it is old API microversion"},{"line_number":47,"context_line":"   request, then it should be 400 returned."},{"line_number":48,"context_line":"#. Provide a COMPUTE_REBUILD_BFV trait for knowing if the compute node can"},{"line_number":49,"context_line":"   support volume-backed server rebuild."},{"line_number":50,"context_line":"   if not, will raise RebuildVolumeBackedServerNotSupport exception."}],"source_content_type":"text/x-rst","patch_set":2,"id":"eee7a0d3_5b542c2f","line":47,"range":{"start_line":40,"start_character":1,"end_line":47,"end_character":43},"updated":"2022-05-18 09:49:05.000000000","message":"i do not like this approch since it does not fulfile use-case 2\n\n\n* As a nova developer, I would like to have feature parity in the compute API\n  for volume-backed and image-backed servers.\n\nif i need to pass an addtional paramter to do this then its not feature partity its two similar but not identical feature.\n\njust as we now hide block vs non block migration behind an auto flag i think nova shoudl jsut handel this internally.\n\nwe know if an instance is BFV or not we can use that to determin what code path to take and just remove the api block.\n\nas a user i should not need to care if my instance is BFV or not if i do i think this feature has failed to provide partiy.\n\nim not sure we need an api micorverison to change from a 400 to a 200 either by the way.","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1674910328d20cf1c2838eff61a31b5c07bdefe3","unresolved":true,"context_lines":[{"line_number":37,"context_line":"First, change the existing API for rebuilding a volume-backed server."},{"line_number":38,"context_line":"Then the API flow would be:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"#. A new request parameter, ``reimage_boot_volume`` (boolean), will be added"},{"line_number":41,"context_line":"   to the existing reimage API call which, if ``True``, will indicate if the"},{"line_number":42,"context_line":"   user wants to reimage a volume backed instance. By default, it will be"},{"line_number":43,"context_line":"   ``False``."},{"line_number":44,"context_line":"#. Reject the request if ``reimage_boot_volume`` is passed as ``True`` and the"},{"line_number":45,"context_line":"   instance isn\u0027t booting from a volume."},{"line_number":46,"context_line":"#. Has the new API microversion been requested. If it is old API microversion"},{"line_number":47,"context_line":"   request, then it should be 400 returned."},{"line_number":48,"context_line":"#. Provide a COMPUTE_REBUILD_BFV trait for knowing if the compute node can"},{"line_number":49,"context_line":"   support volume-backed server rebuild."},{"line_number":50,"context_line":"   if not, will raise RebuildVolumeBackedServerNotSupport exception."}],"source_content_type":"text/x-rst","patch_set":2,"id":"df06ece1_7c3e41ef","line":47,"range":{"start_line":40,"start_character":1,"end_line":47,"end_character":43},"in_reply_to":"1d0d5057_9ef680ac","updated":"2022-05-18 11:01:27.000000000","message":"reading lees previous comment i dont aggree with it.\n\nif the intent is to provide partiy for exsitng behavior then we shoudl not intodocue a new parmater.\n\nthose two constriats are on conflict.\n\nthe user requsted a rebuild so we shoudl do what they said.\n\nthe expection of no boot form volume root disks is also that they are persitent.\n\nwe do not consider the root disk to be part of the instnaces ephmearl storage. it is persitent storage just as much as a cinder volume is espically if you use the rbd images backend or mount the instnace state dir on shared storage. \n\neven if you are using just qcow wiht no distributed storage its sill persitent storage.","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"01ff40c88b797fd81fb009c19045ff7e99b94674","unresolved":false,"context_lines":[{"line_number":37,"context_line":"First, change the existing API for rebuilding a volume-backed server."},{"line_number":38,"context_line":"Then the API flow would be:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"#. A new request parameter, ``reimage_boot_volume`` (boolean), will be added"},{"line_number":41,"context_line":"   to the existing reimage API call which, if ``True``, will indicate if the"},{"line_number":42,"context_line":"   user wants to reimage a volume backed instance. By default, it will be"},{"line_number":43,"context_line":"   ``False``."},{"line_number":44,"context_line":"#. Reject the request if ``reimage_boot_volume`` is passed as ``True`` and the"},{"line_number":45,"context_line":"   instance isn\u0027t booting from a volume."},{"line_number":46,"context_line":"#. Has the new API microversion been requested. If it is old API microversion"},{"line_number":47,"context_line":"   request, then it should be 400 returned."},{"line_number":48,"context_line":"#. Provide a COMPUTE_REBUILD_BFV trait for knowing if the compute node can"},{"line_number":49,"context_line":"   support volume-backed server rebuild."},{"line_number":50,"context_line":"   if not, will raise RebuildVolumeBackedServerNotSupport exception."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3c97fb6e_8c6f2865","line":47,"range":{"start_line":40,"start_character":1,"end_line":47,"end_character":43},"in_reply_to":"df06ece1_7c3e41ef","updated":"2022-05-26 11:44:02.000000000","message":"we discussed this at lenght on irc and the spec has now been updted to relect the outcome of that converstaion so marking this comment thread as resolved.","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"efaa90433c4de80342ba9b89d5e108d2baf692a0","unresolved":true,"context_lines":[{"line_number":37,"context_line":"First, change the existing API for rebuilding a volume-backed server."},{"line_number":38,"context_line":"Then the API flow would be:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"#. A new request parameter, ``reimage_boot_volume`` (boolean), will be added"},{"line_number":41,"context_line":"   to the existing reimage API call which, if ``True``, will indicate if the"},{"line_number":42,"context_line":"   user wants to reimage a volume backed instance. By default, it will be"},{"line_number":43,"context_line":"   ``False``."},{"line_number":44,"context_line":"#. Reject the request if ``reimage_boot_volume`` is passed as ``True`` and the"},{"line_number":45,"context_line":"   instance isn\u0027t booting from a volume."},{"line_number":46,"context_line":"#. Has the new API microversion been requested. If it is old API microversion"},{"line_number":47,"context_line":"   request, then it should be 400 returned."},{"line_number":48,"context_line":"#. Provide a COMPUTE_REBUILD_BFV trait for knowing if the compute node can"},{"line_number":49,"context_line":"   support volume-backed server rebuild."},{"line_number":50,"context_line":"   if not, will raise RebuildVolumeBackedServerNotSupport exception."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1d0d5057_9ef680ac","line":47,"range":{"start_line":40,"start_character":1,"end_line":47,"end_character":43},"in_reply_to":"eee7a0d3_5b542c2f","updated":"2022-05-18 10:12:30.000000000","message":"This has already been discussed in great lengths in the original spec where the latest occurrence of this question asked by Gorka and reply by Lee is here[1]\ntl;dr volumes have a precedent to be persistent storage and this will destroy all the data on the volume that is why an extra caution step is added here.\nLee suggested this option and Dan Smith suggested on the proposed changes to make this parameter travel down from api to conductor to the compute layer.\n\nI don\u0027t mind removing the use case 2 since it carries less value than providing the actual feature in a more precautionary way.\n\n[1] https://review.opendev.org/c/openstack/nova-specs/+/809621/8/specs/yoga/approved/volume-backed-server-rebuild.rst#40","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"600382b04bddc4d352916c0676df9a7aad4e4a86","unresolved":true,"context_lines":[{"line_number":45,"context_line":"   instance isn\u0027t booting from a volume."},{"line_number":46,"context_line":"#. Has the new API microversion been requested. If it is old API microversion"},{"line_number":47,"context_line":"   request, then it should be 400 returned."},{"line_number":48,"context_line":"#. Provide a COMPUTE_REBUILD_BFV trait for knowing if the compute node can"},{"line_number":49,"context_line":"   support volume-backed server rebuild."},{"line_number":50,"context_line":"   if not, will raise RebuildVolumeBackedServerNotSupport exception."},{"line_number":51,"context_line":"#. If the cinder microversion is new enough to support reimage"},{"line_number":52,"context_line":"   the boot volume. If not, will raise CinderAPIVersionNotAvailable"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b3170df3_61e33cae","line":49,"range":{"start_line":48,"start_character":3,"end_line":49,"end_character":40},"updated":"2022-05-18 09:49:05.000000000","message":"rebuild is not a move operation so this wont really help.\nthis should work for all veirt driver since this shoudl be implementable at teh compute manager level i woudl guess so im not conviced we need a compute capableity trait but we could add one.\n\ni would never exprect an operator or used to request this directly so im not sure this is useful.","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"efaa90433c4de80342ba9b89d5e108d2baf692a0","unresolved":true,"context_lines":[{"line_number":45,"context_line":"   instance isn\u0027t booting from a volume."},{"line_number":46,"context_line":"#. Has the new API microversion been requested. If it is old API microversion"},{"line_number":47,"context_line":"   request, then it should be 400 returned."},{"line_number":48,"context_line":"#. Provide a COMPUTE_REBUILD_BFV trait for knowing if the compute node can"},{"line_number":49,"context_line":"   support volume-backed server rebuild."},{"line_number":50,"context_line":"   if not, will raise RebuildVolumeBackedServerNotSupport exception."},{"line_number":51,"context_line":"#. If the cinder microversion is new enough to support reimage"},{"line_number":52,"context_line":"   the boot volume. If not, will raise CinderAPIVersionNotAvailable"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e66ecb8d_834d5395","line":49,"range":{"start_line":48,"start_character":3,"end_line":49,"end_character":40},"in_reply_to":"b3170df3_61e33cae","updated":"2022-05-18 10:12:30.000000000","message":"Ack, this is also not a part of the implementation so can remove this.","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"81308c1be85008702a4742c6990951c07847f72a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   instance isn\u0027t booting from a volume."},{"line_number":46,"context_line":"#. Has the new API microversion been requested. If it is old API microversion"},{"line_number":47,"context_line":"   request, then it should be 400 returned."},{"line_number":48,"context_line":"#. Provide a COMPUTE_REBUILD_BFV trait for knowing if the compute node can"},{"line_number":49,"context_line":"   support volume-backed server rebuild."},{"line_number":50,"context_line":"   if not, will raise RebuildVolumeBackedServerNotSupport exception."},{"line_number":51,"context_line":"#. If the cinder microversion is new enough to support reimage"},{"line_number":52,"context_line":"   the boot volume. If not, will raise CinderAPIVersionNotAvailable"}],"source_content_type":"text/x-rst","patch_set":2,"id":"65d670fc_7212a6fb","line":49,"range":{"start_line":48,"start_character":3,"end_line":49,"end_character":40},"in_reply_to":"e66ecb8d_834d5395","updated":"2022-05-18 10:14:28.000000000","message":"Done","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"600382b04bddc4d352916c0676df9a7aad4e4a86","unresolved":true,"context_lines":[{"line_number":48,"context_line":"#. Provide a COMPUTE_REBUILD_BFV trait for knowing if the compute node can"},{"line_number":49,"context_line":"   support volume-backed server rebuild."},{"line_number":50,"context_line":"   if not, will raise RebuildVolumeBackedServerNotSupport exception."},{"line_number":51,"context_line":"#. If the cinder microversion is new enough to support reimage"},{"line_number":52,"context_line":"   the boot volume. If not, will raise CinderAPIVersionNotAvailable"},{"line_number":53,"context_line":"   exception."},{"line_number":54,"context_line":"#. In case of multiattach volumes, n-api will reject the request since"},{"line_number":55,"context_line":"   rebuilding multiattach volumes require complex attachment handling and"},{"line_number":56,"context_line":"   the effort would outweigh the benefit."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Then the nova-compute manager will perform the following steps:"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7e6967b0_76696d29","line":56,"range":{"start_line":51,"start_character":2,"end_line":56,"end_character":41},"updated":"2022-05-18 09:49:05.000000000","message":"so in these two cases we woudl just return a 400 as we do today.","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"efaa90433c4de80342ba9b89d5e108d2baf692a0","unresolved":true,"context_lines":[{"line_number":48,"context_line":"#. Provide a COMPUTE_REBUILD_BFV trait for knowing if the compute node can"},{"line_number":49,"context_line":"   support volume-backed server rebuild."},{"line_number":50,"context_line":"   if not, will raise RebuildVolumeBackedServerNotSupport exception."},{"line_number":51,"context_line":"#. If the cinder microversion is new enough to support reimage"},{"line_number":52,"context_line":"   the boot volume. If not, will raise CinderAPIVersionNotAvailable"},{"line_number":53,"context_line":"   exception."},{"line_number":54,"context_line":"#. In case of multiattach volumes, n-api will reject the request since"},{"line_number":55,"context_line":"   rebuilding multiattach volumes require complex attachment handling and"},{"line_number":56,"context_line":"   the effort would outweigh the benefit."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Then the nova-compute manager will perform the following steps:"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"92a47677_a1b7b7d1","line":56,"range":{"start_line":51,"start_character":2,"end_line":56,"end_character":41},"in_reply_to":"7e6967b0_76696d29","updated":"2022-05-18 10:12:30.000000000","message":"Yes","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"01ff40c88b797fd81fb009c19045ff7e99b94674","unresolved":false,"context_lines":[{"line_number":48,"context_line":"#. Provide a COMPUTE_REBUILD_BFV trait for knowing if the compute node can"},{"line_number":49,"context_line":"   support volume-backed server rebuild."},{"line_number":50,"context_line":"   if not, will raise RebuildVolumeBackedServerNotSupport exception."},{"line_number":51,"context_line":"#. If the cinder microversion is new enough to support reimage"},{"line_number":52,"context_line":"   the boot volume. If not, will raise CinderAPIVersionNotAvailable"},{"line_number":53,"context_line":"   exception."},{"line_number":54,"context_line":"#. In case of multiattach volumes, n-api will reject the request since"},{"line_number":55,"context_line":"   rebuilding multiattach volumes require complex attachment handling and"},{"line_number":56,"context_line":"   the effort would outweigh the benefit."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Then the nova-compute manager will perform the following steps:"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ada4821_4a66acf4","line":56,"range":{"start_line":51,"start_character":2,"end_line":56,"end_character":41},"in_reply_to":"92a47677_a1b7b7d1","updated":"2022-05-26 11:44:02.000000000","message":"Ack","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"600382b04bddc4d352916c0676df9a7aad4e4a86","unresolved":true,"context_lines":[{"line_number":126,"context_line":"REST API impact"},{"line_number":127,"context_line":"---------------"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Add a new parameter ``reimage_boot_volume`` (boolean) to the existing rebuild"},{"line_number":130,"context_line":"API."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":".. code-block:: console"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    POST /servers/{server_id}/action"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":".. code-block:: json"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    {"},{"line_number":139,"context_line":"        \"rebuild\": {"},{"line_number":140,"context_line":"            \"reimage_boot_volume\": \"True\""},{"line_number":141,"context_line":"        }"},{"line_number":142,"context_line":"    }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Change the rebuild request response code from 400 to 202 if the conditions"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f2436cb8_0908eb68","line":142,"range":{"start_line":129,"start_character":0,"end_line":142,"end_character":5},"updated":"2022-05-18 09:49:05.000000000","message":"delete","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"01ff40c88b797fd81fb009c19045ff7e99b94674","unresolved":false,"context_lines":[{"line_number":126,"context_line":"REST API impact"},{"line_number":127,"context_line":"---------------"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Add a new parameter ``reimage_boot_volume`` (boolean) to the existing rebuild"},{"line_number":130,"context_line":"API."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":".. code-block:: console"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    POST /servers/{server_id}/action"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":".. code-block:: json"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    {"},{"line_number":139,"context_line":"        \"rebuild\": {"},{"line_number":140,"context_line":"            \"reimage_boot_volume\": \"True\""},{"line_number":141,"context_line":"        }"},{"line_number":142,"context_line":"    }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Change the rebuild request response code from 400 to 202 if the conditions"}],"source_content_type":"text/x-rst","patch_set":2,"id":"6646ba55_77dbc4b1","line":142,"range":{"start_line":129,"start_character":0,"end_line":142,"end_character":5},"in_reply_to":"aef9794f_c9e681a0","updated":"2022-05-26 11:44:02.000000000","message":"Done","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"efaa90433c4de80342ba9b89d5e108d2baf692a0","unresolved":true,"context_lines":[{"line_number":126,"context_line":"REST API impact"},{"line_number":127,"context_line":"---------------"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Add a new parameter ``reimage_boot_volume`` (boolean) to the existing rebuild"},{"line_number":130,"context_line":"API."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":".. code-block:: console"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    POST /servers/{server_id}/action"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":".. code-block:: json"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    {"},{"line_number":139,"context_line":"        \"rebuild\": {"},{"line_number":140,"context_line":"            \"reimage_boot_volume\": \"True\""},{"line_number":141,"context_line":"        }"},{"line_number":142,"context_line":"    }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Change the rebuild request response code from 400 to 202 if the conditions"}],"source_content_type":"text/x-rst","patch_set":2,"id":"aef9794f_c9e681a0","line":142,"range":{"start_line":129,"start_character":0,"end_line":142,"end_character":5},"in_reply_to":"f2436cb8_0908eb68","updated":"2022-05-18 10:12:30.000000000","message":"As mentioned above this was suggested in the original design with a reasoning mentioned above.","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"600382b04bddc4d352916c0676df9a7aad4e4a86","unresolved":true,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Change the rebuild request response code from 400 to 202 if the conditions"},{"line_number":146,"context_line":"described in the `Proposed change`_ section are met."},{"line_number":147,"context_line":"The API microversion and compute RPC version will also be incremented to"},{"line_number":148,"context_line":"indicate the new support."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Security impact"},{"line_number":151,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"cf8f1b74_808a6474","line":148,"range":{"start_line":147,"start_character":0,"end_line":148,"end_character":24},"updated":"2022-05-18 09:49:05.000000000","message":"delete","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"01ff40c88b797fd81fb009c19045ff7e99b94674","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Change the rebuild request response code from 400 to 202 if the conditions"},{"line_number":146,"context_line":"described in the `Proposed change`_ section are met."},{"line_number":147,"context_line":"The API microversion and compute RPC version will also be incremented to"},{"line_number":148,"context_line":"indicate the new support."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Security impact"},{"line_number":151,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dc99abe9_1b40fda8","line":148,"range":{"start_line":147,"start_character":0,"end_line":148,"end_character":24},"in_reply_to":"67fae58f_2ec9e31d","updated":"2022-05-26 11:44:02.000000000","message":"Ack","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"efaa90433c4de80342ba9b89d5e108d2baf692a0","unresolved":true,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Change the rebuild request response code from 400 to 202 if the conditions"},{"line_number":146,"context_line":"described in the `Proposed change`_ section are met."},{"line_number":147,"context_line":"The API microversion and compute RPC version will also be incremented to"},{"line_number":148,"context_line":"indicate the new support."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Security impact"},{"line_number":151,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"67fae58f_2ec9e31d","line":148,"range":{"start_line":147,"start_character":0,"end_line":148,"end_character":24},"in_reply_to":"cf8f1b74_808a6474","updated":"2022-05-18 10:12:30.000000000","message":"same","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"600382b04bddc4d352916c0676df9a7aad4e4a86","unresolved":true,"context_lines":[{"line_number":201,"context_line":"Work Items"},{"line_number":202,"context_line":"----------"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"* Add a new request parameter ``reimage_boot_volume`` to the rebuild API"},{"line_number":205,"context_line":"* Change the existing rebuild API."},{"line_number":206,"context_line":"* Create an empty attachment for the root volume so the volume"},{"line_number":207,"context_line":"  remains in-use during rebuild (we do this today already)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"aab0aaa2_2e4673b6","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":72},"updated":"2022-05-18 09:49:05.000000000","message":"delete","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"efaa90433c4de80342ba9b89d5e108d2baf692a0","unresolved":true,"context_lines":[{"line_number":201,"context_line":"Work Items"},{"line_number":202,"context_line":"----------"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"* Add a new request parameter ``reimage_boot_volume`` to the rebuild API"},{"line_number":205,"context_line":"* Change the existing rebuild API."},{"line_number":206,"context_line":"* Create an empty attachment for the root volume so the volume"},{"line_number":207,"context_line":"  remains in-use during rebuild (we do this today already)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"b0fb220b_1bd31c98","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":72},"in_reply_to":"aab0aaa2_2e4673b6","updated":"2022-05-18 10:12:30.000000000","message":"same","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"01ff40c88b797fd81fb009c19045ff7e99b94674","unresolved":false,"context_lines":[{"line_number":201,"context_line":"Work Items"},{"line_number":202,"context_line":"----------"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"* Add a new request parameter ``reimage_boot_volume`` to the rebuild API"},{"line_number":205,"context_line":"* Change the existing rebuild API."},{"line_number":206,"context_line":"* Create an empty attachment for the root volume so the volume"},{"line_number":207,"context_line":"  remains in-use during rebuild (we do this today already)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"70880a0b_52fa2d62","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":72},"in_reply_to":"b0fb220b_1bd31c98","updated":"2022-05-26 11:44:02.000000000","message":"Done","commit_id":"072eadba19278535077df8adccecd6128d3fed64"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"01ff40c88b797fd81fb009c19045ff7e99b94674","unresolved":true,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"The python-novaclient, python-openstackclient and SDK will be updated"},{"line_number":141,"context_line":"to support the new microversion."},{"line_number":142,"context_line":"An additional parameter ``reimage_boot_volume`` will be added as a check"},{"line_number":143,"context_line":"(along with the microversion check) on the client side that will determine"},{"line_number":144,"context_line":"if the user really wants to opt into the new functionality."},{"line_number":145,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5fd07eee_3c9a1ff7","line":142,"range":{"start_line":142,"start_character":26,"end_line":142,"end_character":45},"updated":"2022-05-26 11:44:02.000000000","message":"--confirm-reimage or --yes-really","commit_id":"c37af797d2462f77d5c6c753c6ea25a9c76a10d0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1493367c964dd3d7fa1dffd8e3abf36c365e0670","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"The python-novaclient, python-openstackclient and SDK will be updated"},{"line_number":141,"context_line":"to support the new microversion."},{"line_number":142,"context_line":"An additional parameter ``reimage_boot_volume`` will be added as a check"},{"line_number":143,"context_line":"(along with the microversion check) on the client side that will determine"},{"line_number":144,"context_line":"if the user really wants to opt into the new functionality."},{"line_number":145,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"8c649fe9_4a401b27","line":142,"range":{"start_line":142,"start_character":26,"end_line":142,"end_character":45},"in_reply_to":"5fd07eee_3c9a1ff7","updated":"2022-05-26 18:42:00.000000000","message":"Done","commit_id":"c37af797d2462f77d5c6c753c6ea25a9c76a10d0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"01ff40c88b797fd81fb009c19045ff7e99b94674","unresolved":true,"context_lines":[{"line_number":181,"context_line":"Work Items"},{"line_number":182,"context_line":"----------"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"* Add a new parameter ``reimage_boot_volume`` on the client side."},{"line_number":185,"context_line":"* Change the existing rebuild API to allow volume backed instance rebuild."},{"line_number":186,"context_line":"* Create an empty attachment for the root volume so the volume"},{"line_number":187,"context_line":"  remains in-use during rebuild (we do this today already)."}],"source_content_type":"text/x-rst","patch_set":4,"id":"c9f96a72_b749349a","line":184,"range":{"start_line":184,"start_character":23,"end_line":184,"end_character":43},"updated":"2022-05-26 11:44:02.000000000","message":"nit: we shoudl not call it this, this is not how we would want to format it style wise.  the cil parmater woudl be ``--some-name-with-hyphens``\n\nsomeing like ``--confirim-reimage`` woudl be better","commit_id":"c37af797d2462f77d5c6c753c6ea25a9c76a10d0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1493367c964dd3d7fa1dffd8e3abf36c365e0670","unresolved":false,"context_lines":[{"line_number":181,"context_line":"Work Items"},{"line_number":182,"context_line":"----------"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"* Add a new parameter ``reimage_boot_volume`` on the client side."},{"line_number":185,"context_line":"* Change the existing rebuild API to allow volume backed instance rebuild."},{"line_number":186,"context_line":"* Create an empty attachment for the root volume so the volume"},{"line_number":187,"context_line":"  remains in-use during rebuild (we do this today already)."}],"source_content_type":"text/x-rst","patch_set":4,"id":"773df622_e49360b7","line":184,"range":{"start_line":184,"start_character":23,"end_line":184,"end_character":43},"in_reply_to":"c9f96a72_b749349a","updated":"2022-05-26 18:42:00.000000000","message":"Done","commit_id":"c37af797d2462f77d5c6c753c6ea25a9c76a10d0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"01ff40c88b797fd81fb009c19045ff7e99b94674","unresolved":true,"context_lines":[{"line_number":182,"context_line":"----------"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"* Add a new parameter ``reimage_boot_volume`` on the client side."},{"line_number":185,"context_line":"* Change the existing rebuild API to allow volume backed instance rebuild."},{"line_number":186,"context_line":"* Create an empty attachment for the root volume so the volume"},{"line_number":187,"context_line":"  remains in-use during rebuild (we do this today already)."},{"line_number":188,"context_line":"* Delete the old volume attachment."}],"source_content_type":"text/x-rst","patch_set":4,"id":"32f834c3_e708cfe8","line":185,"range":{"start_line":185,"start_character":73,"end_line":185,"end_character":74},"updated":"2022-05-26 11:44:02.000000000","message":"with a new image.\n\nsince apprentnly we abuse this api already","commit_id":"c37af797d2462f77d5c6c753c6ea25a9c76a10d0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1493367c964dd3d7fa1dffd8e3abf36c365e0670","unresolved":false,"context_lines":[{"line_number":182,"context_line":"----------"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"* Add a new parameter ``reimage_boot_volume`` on the client side."},{"line_number":185,"context_line":"* Change the existing rebuild API to allow volume backed instance rebuild."},{"line_number":186,"context_line":"* Create an empty attachment for the root volume so the volume"},{"line_number":187,"context_line":"  remains in-use during rebuild (we do this today already)."},{"line_number":188,"context_line":"* Delete the old volume attachment."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3df45ae7_9b7904ec","line":185,"range":{"start_line":185,"start_character":73,"end_line":185,"end_character":74},"in_reply_to":"32f834c3_e708cfe8","updated":"2022-05-26 18:42:00.000000000","message":"Done","commit_id":"c37af797d2462f77d5c6c753c6ea25a9c76a10d0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f8644b26dfcbddd863b143fa969a603f46a37179","unresolved":true,"context_lines":[{"line_number":40,"context_line":"   Note that the old behaviour still allows to rebuild a volume backed"},{"line_number":41,"context_line":"   server with the same image in which we don\u0027t wipe out the data of the"},{"line_number":42,"context_line":"   volume so to prevent the user from accidently destroying all their data,"},{"line_number":43,"context_line":"   we require them to use the new microversion."},{"line_number":44,"context_line":"#. If the cinder microversion is new enough to support reimage"},{"line_number":45,"context_line":"   the boot volume. If not, will raise CinderAPIVersionNotAvailable"},{"line_number":46,"context_line":"   exception."}],"source_content_type":"text/x-rst","patch_set":5,"id":"a7351500_e8f2aab1","line":43,"updated":"2022-05-31 09:37:47.000000000","message":"++ that\u0027s what we agreed on the previous IRC meeting.","commit_id":"c90edf5adaec3a09c9f836fbb4cbdcd49d1224bf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f8644b26dfcbddd863b143fa969a603f46a37179","unresolved":true,"context_lines":[{"line_number":140,"context_line":"The python-novaclient, python-openstackclient and SDK will be updated"},{"line_number":141,"context_line":"to support the new microversion."},{"line_number":142,"context_line":"An additional parameter ``--confirm-reimage`` will be added as a check"},{"line_number":143,"context_line":"(along with the microversion check) on the client side that will determine"},{"line_number":144,"context_line":"if the user really wants to opt into the new functionality."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"b943749a_95d60845","line":143,"range":{"start_line":143,"start_character":36,"end_line":143,"end_character":54},"updated":"2022-05-31 09:37:47.000000000","message":"OK, so for OSC and novaclient, right?","commit_id":"c90edf5adaec3a09c9f836fbb4cbdcd49d1224bf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c136c296f7d53cfb7ba152cd253b84475a386d23","unresolved":true,"context_lines":[{"line_number":140,"context_line":"The python-novaclient, python-openstackclient and SDK will be updated"},{"line_number":141,"context_line":"to support the new microversion."},{"line_number":142,"context_line":"An additional parameter ``--confirm-reimage`` will be added as a check"},{"line_number":143,"context_line":"(along with the microversion check) on the client side that will determine"},{"line_number":144,"context_line":"if the user really wants to opt into the new functionality."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"f52078e0_6826af21","line":143,"range":{"start_line":143,"start_character":36,"end_line":143,"end_character":54},"in_reply_to":"8ac15f5e_fee7668f","updated":"2022-05-31 17:55:31.000000000","message":"Correct. The current implementation in OSC can remain as it is[1] and we will update novaclient patch[2] to only have the microversion check\n\n[1] https://review.opendev.org/c/openstack/python-openstackclient/+/831014\n[2] https://review.opendev.org/c/openstack/python-novaclient/+/827163","commit_id":"c90edf5adaec3a09c9f836fbb4cbdcd49d1224bf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"98f5b6d7c24822605ce085a628d149c2b8306c81","unresolved":true,"context_lines":[{"line_number":140,"context_line":"The python-novaclient, python-openstackclient and SDK will be updated"},{"line_number":141,"context_line":"to support the new microversion."},{"line_number":142,"context_line":"An additional parameter ``--confirm-reimage`` will be added as a check"},{"line_number":143,"context_line":"(along with the microversion check) on the client side that will determine"},{"line_number":144,"context_line":"if the user really wants to opt into the new functionality."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"8ac15f5e_fee7668f","line":143,"range":{"start_line":143,"start_character":36,"end_line":143,"end_character":54},"in_reply_to":"b943749a_95d60845","updated":"2022-05-31 09:45:50.000000000","message":"no just osc.\n\nthe python-novaclient python binding can be updated but the cli should not be.\nso i would expect the check to only be implented in osc.","commit_id":"c90edf5adaec3a09c9f836fbb4cbdcd49d1224bf"}]}