)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"54c634bff6a690ef9c96135343c1e302900bb334","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0a03b0be_bb8f6f0c","updated":"2022-05-06 09:42:30.000000000","message":"I\u0027m torn, we should maybe add some docs explaining how to review then graphviz specs, but given it\u0027s like ASCII, we can do it.","commit_id":"ac17d63e69b9be89a081a66d988ee3c96e33319f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6a93f315ebc18e170850bfd557339b05e3d40d86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e718db63_ffaf35e1","updated":"2022-05-10 14:52:04.000000000","message":"so i dont partcally like how this is encoded in the rst file and\nthe diagram it creat is not greate\n\nhttps://87a0fe2bf0e6c5e39c7f-478de6dffbc7939c063d04512c6aa14e.ssl.cf1.rackcdn.com/833669/6/check/openstack-tox-docs/47589e2/docs/specs/zed/approved/libvirt-virtiofs-attach-manila-shares.html\n\nwe also have supprot for seqdiag already\n\nwhich i also dont partcally like but i think a sequence diagram \nlike the one used in cyborg is better the that produced by graphviz\n\nhttps://87a0fe2bf0e6c5e39c7f-478de6dffbc7939c063d04512c6aa14e.ssl.cf1.rackcdn.com/833669/6/check/openstack-tox-docs/47589e2/docs/specs/ussuri/implemented/nova-cyborg-interaction.html#nova-changes-for-assignment-workflow\n\n\nso unless there is a very strong rason to allow this i would prefer if we use ascci diagrams or failing that seqdiag.\n\n","commit_id":"ac17d63e69b9be89a081a66d988ee3c96e33319f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9ba73c0c15670538b99af54f334e90f1d8a30c70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"533f4527_d681d00d","updated":"2022-05-10 14:44:07.000000000","message":"what does graphviz look like in a spec.\n\nwe tend to use assci diagram in specs so that they can be review inline in gerrit without renderign them so im not sure we want to do this.\n\nim going to go look at the followup but want to keep specs readable without rendering into html","commit_id":"ac17d63e69b9be89a081a66d988ee3c96e33319f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"43522c493b88724763a11aac6aa1a4fcffc46590","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b110c6e_3c16b42c","in_reply_to":"533f4527_d681d00d","updated":"2022-05-10 23:22:06.000000000","message":"Agree it\u0027s nice to be able to see the diagram without having to open it in a browser. I think there is a tool that can make them for you easily, I think it is https://asciiflow.com.","commit_id":"ac17d63e69b9be89a081a66d988ee3c96e33319f"}]}