)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"efffad3bccbf06fd91fd23d7eb640908e6c004eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d816b293_2f8f4ab4","updated":"2022-07-14 08:20:59.000000000","message":"Both comments are resolved. I hope that my reply to your comments cleared the doubts.\n\nThanks for reviewing the spec!","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"86c314f4606a17340f9e54e7f36ded017901e7a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a641c7ed_b448d87e","updated":"2022-07-14 12:30:56.000000000","message":"I\u0027m onboard with this effort. My only concern is how much of it we expose to end users.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5bd62cd68b6bcf93700b316b31f80fe48387ba15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2a11c320_924fa5b5","updated":"2022-07-15 09:54:34.000000000","message":"dropping to +1 until we get feedback form the author.\n\nby the way we are now technically pass the spec approval deadline.\nwe tentatively agreed on irc that if the author asks for a spec\nfreeze exception in the team meeting on tuesday i will sponsor it\nand others will likely approve this as in general we agree with adding the feature.\n\n\nso dont be alarmed if sylvan add a procedual -2 on monday when they are back form PTO. however if we have not resovled stephen outstanding issue on tuesday this likely will have to be defered until the AA release.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3f9ca11b52e0ce003ac7cafdf6442e7dc07ae9a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aa02fa25_0d27db82","updated":"2022-07-12 12:50:51.000000000","message":"in general i have no issue with this proposal\nThis woudl be a reltivly minor feature with limited scope\n\ni just want to clarify that compruession will actully work with the html5 client.\n\nif it will and you are aware we do not allow or supprot a direct conenction to the qemu instance then i think this something we could add.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"380ee8d8082edf8f22a7ea31558b1c709153d8dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f53dba7f_70518f2d","updated":"2022-07-14 08:56:53.000000000","message":"thanks for clarifying\n\nthis seams like a very simple extention that is inline with the nova project scope.\n\ni agree that config options are the correct approch rather then doing this as an extention to the console api since the capablity set will depend on the sepcifics of the capablitity of the spice html client the operator has deployed.\n\nif in a followup spec we gain the ablity to supprot native client or other vdi usescase we could expolre extending the console api to expose some of these options but for now i think this is the correct approch.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c62a4ac2187a08ef87dc2b95d9f3a78d58d27d00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cc64a720_019ec37b","in_reply_to":"2a11c320_924fa5b5","updated":"2022-07-15 11:22:32.000000000","message":"Hi Sean! Thank you for this insight, this is indeed good to know.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5948001bb6e24c80d75ec1aa18f4f086c49f0ec4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a51946eb_70b46687","in_reply_to":"3406e805_c268c300","updated":"2022-07-18 08:52:28.000000000","message":"im not convinced by the flaovr/image approch for this.\nwe might want to do that but i would defer flavor/image/api level changes to a future spec.\n\nmanuel woudl you mind updating the spec to incorperate some of the uses cases that motivate makign this configurable.\n\nif you are able to attend the nova team meeting tomorrow.\nit takes place on irc Tuesdays 16:00 UTC (#openstack-nova on OFTC)\nwe can discuss the spec in the open discussion section.\nbut it would help if you had already updated it.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e740687ed5509dbf0eb8f3b76043c161e2476fd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e221fbef_27ab9e7b","in_reply_to":"43b16480_4dd1fe66","updated":"2022-07-18 17:18:22.000000000","message":"it may be we have an existing problem with flavor/image explostion \nand since this required the spice backend to supprot it we would also need to schdule on it so if we were to include flavor or image propreties for this it would make the feature much bigger as you would need to cater for move oprations and intial placment based on the requested configuration and the capablities fo rboth the host and spice proxy depending on what defienes the valdie set.\n\n\nat least poentially so while that likely is not an issue today if new algortioms are added in teh futre for exampel zstd it could become a factor if that was host dependent.\n\nso for now it better to keep that out of scope.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b181e8bfbc23e5df393076ec02a8ff40c3fc7b4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dd937190_89fed712","in_reply_to":"68fee5d9_a62f27b9","updated":"2022-07-18 14:18:53.000000000","message":"Do note flavours are only managed by admins. I was thinking about not tying a particular hypervisor to a preset SPICE config but I imagine this might never need this level of flexibility anyway.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b535c3ecdfeb9ca16a21cc563503ff2aeab52eb9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aa1f4bc4_1e332f70","in_reply_to":"6a17fb52_b90ebde6","updated":"2022-07-18 07:40:47.000000000","message":"Ack, thanks for explaining your PoV.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5bd62cd68b6bcf93700b316b31f80fe48387ba15","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c9697eda_89542436","in_reply_to":"a4ed29fb_9adb89cb","updated":"2022-07-15 09:54:34.000000000","message":"openstack/nova is ment to be a high level absrcation laywer over multiple hyperviors and exposing all the lowlevel  libvirt options is explcitly not somethign we want to enable.\n\nthe specific cofig optiosn in question are also in the spcie group \nhttps://review.opendev.org/c/openstack/nova/+/828675/4/nova/conf/spice.py\nwhich means they should not actully assume libvirt is the virt driver.\n\nif hyperv or vmware wanted to support spice they should be able to resue those opeiton in general without needign to signifcantly change them.\nthis is codifed in our project scop doc\nhttps://docs.openstack.org/nova/latest/contributor/project-scope.html#driver-parity\n\nso just because libvirt expose something as a confritaion does not mean that nova should.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1f7be5e3b048ce09187603f87085019bc5c8e60c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b37efe0a_8283d0ee","in_reply_to":"a51946eb_70b46687","updated":"2022-07-18 08:57:33.000000000","message":"Yes, if it was not clear, I meant the flavour things to be a part of a future spec.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c68af170600cdfec4ccf7df7538a25a371e3e5af","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a4ed29fb_9adb89cb","in_reply_to":"a641c7ed_b448d87e","updated":"2022-07-14 15:21:36.000000000","message":"Hi Stephen! What\u0027s the issue with exposing the knobs to the end users? I think making a useful passthrough to libvirt options is nice since there is no other general framework to do this. Or is there?","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"efffad3bccbf06fd91fd23d7eb640908e6c004eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"44b0ef4f_b835017d","in_reply_to":"aa02fa25_0d27db82","updated":"2022-07-14 08:20:59.000000000","message":"\u003e in general i have no issue with this proposal\n\u003e This woudl be a reltivly minor feature with limited scope\n\nPerfect, sounds great.\n\n\n\u003e i just want to clarify that compruession will actully work with the html5 client.\n\u003e \n\u003e if it will and you are aware we do not allow or supprot a direct conenction to the qemu instance then i think this something we could add.\n\nYes, this proposed change works and I don\u0027t want to bypass the proxy server to establish a direct connection to a running QEMU instance. For more technical details, please look at my reply to your comment.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"9b2ad42db12bbd09d3797a6ae033360f719c0817","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"68fee5d9_a62f27b9","in_reply_to":"b37efe0a_8283d0ee","updated":"2022-07-18 13:34:46.000000000","message":"\u003e Mayhaps metadata on flavours could carry the necessary details then?\n\nI\u0027m also not convinced by the flavor/metadata idea for an more generic solution in the future. Flavors/metadata are mainly used to prescribe the resources provided to a virtual machine. In other words: The world within a VM is prescribed in more detail. For the SPICE compression settings, an operator requires more knowledge about the outside world (infrastructure). Therefore, it\u0027s more secure that only operators have the possibility to configure SPICE compression settings rather than users. A normal user has never the proper insight to configure the settings correctly, unless presets and limits are specified.\n\n\n\u003e manuel woudl you mind updating the spec to incorperate some of the uses cases that motivate makign this configurable.\n\nI\u0027ve added some motivation (use cases) for this proposed change to the spec.\n\n\n\u003e if you are able to attend the nova team meeting tomorrow.\n\u003e it takes place on irc Tuesdays 16:00 UTC (#openstack-nova on OFTC)\n\u003e we can discuss the spec in the open discussion section.\n\nI have time and I will attend the team meeting tomorrow.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"141b40e2fc8cae30e7086399a43a7b92103bd8e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"43b16480_4dd1fe66","in_reply_to":"b4c0fe4d_aefda3a7","updated":"2022-07-18 15:01:46.000000000","message":"Not quite. I believe it could be a different kind of VM (flavour) for desktop work and a different one for compute. Thus, being able to manipulate the display protocol via flavours makes sense to me.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c62a4ac2187a08ef87dc2b95d9f3a78d58d27d00","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fe227f1d_3235997e","in_reply_to":"c9697eda_89542436","updated":"2022-07-15 11:22:32.000000000","message":"Hmm, I see your point. However, these options are, in principle, general enough to be supported by other hypervisors as well should they support SPICE at some point. We take the naming from qemu because it is the only source of reference.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"54c189af564707e8ceff67b0a443e8fb8d0149b6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3406e805_c268c300","in_reply_to":"d57e6817_67b44bda","updated":"2022-07-18 08:30:33.000000000","message":"I think the use case you mention would also benefit from the more dynamic solution of letting each instance override the defaults. However, I agree it\u0027s considerably more complex and thus is more of a further plan rather than an enhancement to this. More so, considering that certain settings may impact the performance and it might not be the best idea to let just any end user tweak them. Mayhaps metadata on flavours could carry the necessary details then?","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"a2a243df71c2248dc893b6b18691eb901b35ffbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b4c0fe4d_aefda3a7","in_reply_to":"dd937190_89fed712","updated":"2022-07-18 14:32:15.000000000","message":"You\u0027re right, thanks for pointing out that the permission model would perfectly fit for such an idea. In my perspective regarding the software architecture of OpenStack, I focused more on the intention of flavors/metadata. Your idea can be solved technically without any problem, but such a solution might misuse the official intention of flavors/metadata.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"a97d6b6448a08e145e5d80160513c9f06dafdd05","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d57e6817_67b44bda","in_reply_to":"e165a112_a7db8821","updated":"2022-07-18 08:22:20.000000000","message":"I totally agree with Sean\u0027s presented use cases. Such use cases are my driving force for this proposed spec. The operator can decide how to configure a desktop (console) transport via SPICE. This is useful if different use cases have to be addressed. For example, if you only want to access some graphical instances for visualization of computation results locally, it is beneficial to explicitly disable all SPICE compression settings to keep latency as low as possible within a local (wired) network to improve the image quality and the quality of experience (QoE).","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"90b396de2af227e1ea21049216f5ac6301338d63","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e165a112_a7db8821","in_reply_to":"fe227f1d_3235997e","updated":"2022-07-18 08:07:55.000000000","message":"As Radosław already said, I took the names for the SPICE compression settings from libvirt/QEMU, as that is the only source of reference. But this does not mean that SPICE is a libvirt/QEMU feature. SPICE is a standalone component implemented in QEMU and configurable by Libvirt. E.g. VMware could implement SPICE, too. (But I don\u0027t think that will happen one day.) Therefore, we can also rename the options in the SPICE configuration group if the proposed ones are not that good.\n\nI also like Sean\u0027s idea which addresses a generic extension of the console API to set various settings for each console of an instance. However, such a dynamic solution involves a lot of changes and problems, especially when I think of regions, cells, and live migration.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ae06c29b718b6c3d862d12d8107e4b9cac7406fb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6a17fb52_b90ebde6","in_reply_to":"fe227f1d_3235997e","updated":"2022-07-18 07:33:42.000000000","message":"ya i agree these are pretty generic\n\ni thinks that the options proposed are fine to expose but that is based on the assumtion that the reason the current default are not sufficent is that there ara\na ragne of usecase that an opertor might want to optimise for.\n\noptimise for bandwidth\noptimize for latency\noptimize for cpu overhead\n\nand the correct optimisation might also depend on if its a public cloud, a private cloud and wethere you consume the spice console over a lan or wan connection.\n\n\nhowever the useace that modtivates allowing this to be configurable is not captured in the spec.\n\nso if they can add a use case and explin why you would want the operator to be able to tune these values im ok with exposing them.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"36d8443d38e924182f646eddd9d25dabef2f74ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4bcfc039_92ec47ab","updated":"2022-07-19 11:13:28.000000000","message":"I won\u0027t merge this because I\u0027m not sure I can without getting agreement from others (since we\u0027re past spec freeze), but I am happy enough based on the arguments given here that these should be configurable. It is deployment specific and I guess some folks will want a different configuration to others. Sorry for not getting to this yesterday.","commit_id":"899d048bf5e0869bd7fbe0e627d4358e7cafaaf2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e3f32ce9cbebb602585bd3fba723172c1418b4ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f7dce334_f0e1aa8c","updated":"2022-07-18 13:36:24.000000000","message":"i am still ok with this but will defer to stephen and sylvain on on this procedurally and form a design point of view with regards to the config options.","commit_id":"899d048bf5e0869bd7fbe0e627d4358e7cafaaf2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2c8794c78dd74e28965196354fa0949986054c9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bede2989_6a6c9876","updated":"2022-07-20 09:09:18.000000000","message":"I confirm it is as agreed during the Nova meeting.","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"d49d64b7e4c3e6d4dcf1337b519a2a4c67adb3dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d3ca1a09_4efe4c51","updated":"2022-07-20 07:12:47.000000000","message":"I\u0027ve change the behavior description of the configuration options according to the discussed change in the weekly meeting yesterday. Now, everything should be fine and ready for merging.","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a0bd4c6e6e4afee695ab5910b0e3ef84cb41526a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2608e22e_6ae7c4a2","updated":"2022-11-15 11:19:37.000000000","message":"Proposal looks good to me but you have to update it to target Antelope cycle.","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"e696adc7d22e3927b150e61e54359219ba76d529","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"220f6011_d6d052a5","updated":"2022-07-20 11:35:01.000000000","message":"The proposal itself to add support for existing config options sounds fine to me. Also it\u0027s less maintenance burden.\n\nAlthough, note that the upstream SPICE is totally inactive / \"dead\" at this point.  (And some downstream distributions such as RHEL and CentOS-Stream have completely removed its support.)","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"23615e97c6c8553ea8e1a8976f42b3e97dd58001","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dd3a70a1_9f2f42af","updated":"2022-11-15 12:03:03.000000000","message":"im still happy with this too so ill re add my +2 once this has been updated to the correct folder and release","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a128328441b7cfdfe6a86222fa6c51fd8f397d9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a24cf136_8b32ed6b","updated":"2022-10-26 21:48:17.000000000","message":"this need to be repoposed for 2023.1","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"afb5c75227b5b67b24ae433f47c2a5c9c4fef393","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"58fd29fa_9c8a7f5d","updated":"2022-07-20 11:26:48.000000000","message":"we approved the spec freeze excption so restoring +2","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"50343dd6967fcf22d99f187e67bfb111c528a4de","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f9156e11_79d0fdfc","in_reply_to":"203480a6_fea72bfa","updated":"2022-07-20 16:13:18.000000000","message":"Could you elaborate more on the \"upstream SPICE is totally inactive\"? They don\u0027t seem so in https://gitlab.freedesktop.org/spice","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"c82bef5a7ce624a7a184b675d9c019e7d12b807c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"203480a6_fea72bfa","in_reply_to":"220f6011_d6d052a5","updated":"2022-07-20 11:37:46.000000000","message":"\u003e The proposal itself to add support for existing config options sounds fine to me. Also it\u0027s less maintenance burden.\n\n(I should\u0027ve rephrased that last sentence this way: This is not that much of a maintenance burden, as it is mainly enabling existing config options.)\n\n\n\u003e Although, note that the upstream SPICE is totally inactive / \"dead\" at this point.  (And some downstream distributions such as RHEL and CentOS-Stream have completely removed its support.)","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"cd0dfd6d05e6384ed72c1f35c82cb8324d9eaf85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4557c65a_7e3d8611","in_reply_to":"662d006b_910d404a","updated":"2022-10-05 06:20:49.000000000","message":"Done","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a8dc95e4e916bbe2ab929c6620ea1bf0621d634e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"662d006b_910d404a","in_reply_to":"cebe0ce2_6a6788df","updated":"2022-07-21 15:36:33.000000000","message":"Eh, sorry, I have noticed later:\n\nS: Odd Fixes\n\nSo it\u0027s \"almost maintainerless\" in other words.","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"eb505949c793e9b14fc334970967f20f25d239ee","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cebe0ce2_6a6788df","in_reply_to":"da3ed1e6_1097dbae","updated":"2022-07-21 15:29:10.000000000","message":"Hmm, I still see:\n\nSPICE\nM: Gerd Hoffmann \u003ckraxel@redhat.com\u003e\n\nhttps://github.com/qemu/qemu/blob/fe16c833fdb74642c296fa96a472e39229cd4351/MAINTAINERS","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"71c06982b013c202d0e33468ff73f7412d0afa46","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"da3ed1e6_1097dbae","in_reply_to":"f9156e11_79d0fdfc","updated":"2022-07-21 13:18:09.000000000","message":"kashyap was refering to the qemu integration.\n\nspice suport has been remvoed form all rhel based qemu build\nand is not planned to be readded due to a lack of maintaienr ship of the qemu integration.","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3a6f56c7d1730bcbd908a0ffc2c53a369110b2fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ddab9d19_4de0b5b0","updated":"2022-12-14 11:34:13.000000000","message":"I have a small concern at the conf options names","commit_id":"826f0316d0dc7ff6ea95e20171e4e59143f7b051"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"4c83a0f068daf1bad8bd99c9df561baffb858144","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"54ecc18b_2288d531","updated":"2022-11-29 11:33:00.000000000","message":"Thanks for the notification. The Spec was originally agreed (in a meeting) as a late change for Zed, but was not merged due to a forgotten CR+2.\n\nNow, I moved the Spec to the new release location and changed the release name. Now, the Spec is ready for merging.","commit_id":"826f0316d0dc7ff6ea95e20171e4e59143f7b051"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5f3da729a84c4a943b0b1cccf084ddb6699dbdcf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2c04d9e5_dc18263f","updated":"2022-12-14 17:41:39.000000000","message":"Eventually accepting the spec, thanks for the time you took discussing with us. I\u0027d enjoy if you could provide a spec amendment later in the cycle but that\u0027s not a reason to hold the approval as of now.\n\nThanks again.","commit_id":"5c438fb82b9afe7db5947eef68e801976680346a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a7c0f11f78363b18836e7036527aad9ed0f3e6e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5f25c405_970c951f","updated":"2022-12-14 15:58:18.000000000","message":"I\u0027m quite OK with this spec but if you can provide a follow-up for changing the options values using the code, it would be super !\n\n","commit_id":"5c438fb82b9afe7db5947eef68e801976680346a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"207f190ded80e92847d51d0c262f60926cc2ae2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5ae81dcb_ed1fd476","updated":"2022-12-14 14:52:00.000000000","message":"looks good to me","commit_id":"5c438fb82b9afe7db5947eef68e801976680346a"}],"specs/2023.1/approved/spice-compression-support.rst":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3a6f56c7d1730bcbd908a0ffc2c53a369110b2fc","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Other deployer impact"},{"line_number":114,"context_line":"---------------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"The following SPICE-related options should be added to a Nova configuration:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* ``image_compression`` \u003d [ ``auto_glz`` \\| ``auto_lz`` \\| ``quic`` \\|"},{"line_number":119,"context_line":"  ``glz`` \\| ``lz`` \\| ``off`` ];"}],"source_content_type":"text/x-rst","patch_set":6,"id":"61f51c8c_11023550","line":116,"range":{"start_line":116,"start_character":36,"end_line":116,"end_character":42},"updated":"2022-12-14 11:34:13.000000000","message":"nit: s/should/will (if we merge this spec ;))","commit_id":"826f0316d0dc7ff6ea95e20171e4e59143f7b051"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"27033947f68806e75ce0a1a049bb0add1d44079b","unresolved":true,"context_lines":[{"line_number":120,"context_line":"* ``jpeg_compression`` \u003d [ ``auto`` \\| ``never`` \\| ``always`` ];"},{"line_number":121,"context_line":"* ``zlib_compression`` \u003d [ ``auto`` \\| ``never`` \\| ``always`` ];"},{"line_number":122,"context_line":"* ``playback_compression`` \u003d [ ``True`` \\| ``False`` ];"},{"line_number":123,"context_line":"* ``streaming_mode`` \u003d [ ``filter`` \\| ``all`` \\| ``off`` ];"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Each configuration option is optional and can be set explictly to configure the"},{"line_number":126,"context_line":"associated SPICE compression setting for libvirt. If all configuration options"}],"source_content_type":"text/x-rst","patch_set":6,"id":"0afba155_49077814","line":123,"updated":"2022-12-14 11:35:27.000000000","message":"btw. I guess those options would be StrOpt() and having a choices parameter for each being the values above.","commit_id":"826f0316d0dc7ff6ea95e20171e4e59143f7b051"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"cf38cd928acdc6ce1aad6babdec408c88a08e61e","unresolved":true,"context_lines":[{"line_number":120,"context_line":"* ``jpeg_compression`` \u003d [ ``auto`` \\| ``never`` \\| ``always`` ];"},{"line_number":121,"context_line":"* ``zlib_compression`` \u003d [ ``auto`` \\| ``never`` \\| ``always`` ];"},{"line_number":122,"context_line":"* ``playback_compression`` \u003d [ ``True`` \\| ``False`` ];"},{"line_number":123,"context_line":"* ``streaming_mode`` \u003d [ ``filter`` \\| ``all`` \\| ``off`` ];"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Each configuration option is optional and can be set explictly to configure the"},{"line_number":126,"context_line":"associated SPICE compression setting for libvirt. If all configuration options"}],"source_content_type":"text/x-rst","patch_set":6,"id":"33b2c659_9b6dde22","line":123,"in_reply_to":"0afba155_49077814","updated":"2022-12-14 15:03:40.000000000","message":"You guessed right :) I implemented this spec already where I used the predefined data types for configuration options.\n\nDo you have specific reStructuredText directives to highlight StrOpt() and their choice values?","commit_id":"826f0316d0dc7ff6ea95e20171e4e59143f7b051"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5f3da729a84c4a943b0b1cccf084ddb6699dbdcf","unresolved":false,"context_lines":[{"line_number":120,"context_line":"* ``jpeg_compression`` \u003d [ ``auto`` \\| ``never`` \\| ``always`` ];"},{"line_number":121,"context_line":"* ``zlib_compression`` \u003d [ ``auto`` \\| ``never`` \\| ``always`` ];"},{"line_number":122,"context_line":"* ``playback_compression`` \u003d [ ``True`` \\| ``False`` ];"},{"line_number":123,"context_line":"* ``streaming_mode`` \u003d [ ``filter`` \\| ``all`` \\| ``off`` ];"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Each configuration option is optional and can be set explictly to configure the"},{"line_number":126,"context_line":"associated SPICE compression setting for libvirt. If all configuration options"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7631c1a6_49fe36cf","line":123,"in_reply_to":"0dd7ed36_64f5bcd6","updated":"2022-12-14 17:41:39.000000000","message":"If so, I\u0027m OK merging this spec as it is, and you could later amend it by modifying the descriptions of the config options once you\u0027re done with the implementation.","commit_id":"826f0316d0dc7ff6ea95e20171e4e59143f7b051"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"a99dac30e6c8dcdf099554ba962a10e8d5e843c6","unresolved":false,"context_lines":[{"line_number":120,"context_line":"* ``jpeg_compression`` \u003d [ ``auto`` \\| ``never`` \\| ``always`` ];"},{"line_number":121,"context_line":"* ``zlib_compression`` \u003d [ ``auto`` \\| ``never`` \\| ``always`` ];"},{"line_number":122,"context_line":"* ``playback_compression`` \u003d [ ``True`` \\| ``False`` ];"},{"line_number":123,"context_line":"* ``streaming_mode`` \u003d [ ``filter`` \\| ``all`` \\| ``off`` ];"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Each configuration option is optional and can be set explictly to configure the"},{"line_number":126,"context_line":"associated SPICE compression setting for libvirt. If all configuration options"}],"source_content_type":"text/x-rst","patch_set":6,"id":"0dd7ed36_64f5bcd6","line":123,"in_reply_to":"0fb8bb61_ce9f013f","updated":"2022-12-14 16:14:58.000000000","message":"Thank you for providing this hint! Now I remember seeing it in another spec before. Next time I\u0027ll use it properly right away. Since you\u0027re already satisfied, I\u0027ll leave it as it is.","commit_id":"826f0316d0dc7ff6ea95e20171e4e59143f7b051"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a7c0f11f78363b18836e7036527aad9ed0f3e6e8","unresolved":true,"context_lines":[{"line_number":120,"context_line":"* ``jpeg_compression`` \u003d [ ``auto`` \\| ``never`` \\| ``always`` ];"},{"line_number":121,"context_line":"* ``zlib_compression`` \u003d [ ``auto`` \\| ``never`` \\| ``always`` ];"},{"line_number":122,"context_line":"* ``playback_compression`` \u003d [ ``True`` \\| ``False`` ];"},{"line_number":123,"context_line":"* ``streaming_mode`` \u003d [ ``filter`` \\| ``all`` \\| ``off`` ];"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Each configuration option is optional and can be set explictly to configure the"},{"line_number":126,"context_line":"associated SPICE compression setting for libvirt. If all configuration options"}],"source_content_type":"text/x-rst","patch_set":6,"id":"0fb8bb61_ce9f013f","line":123,"in_reply_to":"33b2c659_9b6dde22","updated":"2022-12-14 15:58:18.000000000","message":"Yes, you can use \n\n  .. code:: \n    # registered in group [spice]\n    cfg.StrOpt(\u0027image_compression\u0027,\n               choices\u003d[\u0027auto_glz\u0027, \u0027blah\u0027]\n               help\u003d\u0027What\u0027s doing\u0027)","commit_id":"826f0316d0dc7ff6ea95e20171e4e59143f7b051"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3a6f56c7d1730bcbd908a0ffc2c53a369110b2fc","unresolved":true,"context_lines":[{"line_number":122,"context_line":"* ``playback_compression`` \u003d [ ``True`` \\| ``False`` ];"},{"line_number":123,"context_line":"* ``streaming_mode`` \u003d [ ``filter`` \\| ``all`` \\| ``off`` ];"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Each configuration option is optional and can be set explictly to configure the"},{"line_number":126,"context_line":"associated SPICE compression setting for libvirt. If all configuration options"},{"line_number":127,"context_line":"are not set, then none of the SPICE compression settings will be configured for"},{"line_number":128,"context_line":"libvirt, which corresponds to the behavior before this proposed change. In this"},{"line_number":129,"context_line":"case, the built-in defaults from the libvirt backend (e.g. QEMU) are used."}],"source_content_type":"text/x-rst","patch_set":6,"id":"f17f47bd_7617cf20","line":126,"range":{"start_line":125,"start_character":0,"end_line":126,"end_character":48},"updated":"2022-12-14 11:34:13.000000000","message":"so I guess it should be using the libvirt config group, right?\n\nIf so, you should rename those config options to add a prefix like \u0027spice_\u0027.\nOr, you should create a specific config group like \u0027spice\" and just tell in the option help that they are only used by libvirt driver.\n\nActually, I even think I should prefer the latter, as those options could be used by another virt driver if they support spice.","commit_id":"826f0316d0dc7ff6ea95e20171e4e59143f7b051"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"cf38cd928acdc6ce1aad6babdec408c88a08e61e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"* ``playback_compression`` \u003d [ ``True`` \\| ``False`` ];"},{"line_number":123,"context_line":"* ``streaming_mode`` \u003d [ ``filter`` \\| ``all`` \\| ``off`` ];"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Each configuration option is optional and can be set explictly to configure the"},{"line_number":126,"context_line":"associated SPICE compression setting for libvirt. If all configuration options"},{"line_number":127,"context_line":"are not set, then none of the SPICE compression settings will be configured for"},{"line_number":128,"context_line":"libvirt, which corresponds to the behavior before this proposed change. In this"},{"line_number":129,"context_line":"case, the built-in defaults from the libvirt backend (e.g. QEMU) are used."}],"source_content_type":"text/x-rst","patch_set":6,"id":"a257ca4c_e0235318","line":126,"range":{"start_line":125,"start_character":0,"end_line":126,"end_character":48},"in_reply_to":"f17f47bd_7617cf20","updated":"2022-12-14 15:03:40.000000000","message":"\u003e [...]\n\u003e \n\u003e Or, you should create a specific config group like \u0027spice\" and just tell in the option help that they are only used by libvirt driver.\n\u003e \n\u003e Actually, I even think I should prefer the latter, as those options could be used by another virt driver if they support spice.\n\nExactly, that was my intention. I mentioned this information in the proposed changes section. To be on the safe side, I have added the information here again in the updated patch set.","commit_id":"826f0316d0dc7ff6ea95e20171e4e59143f7b051"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"207f190ded80e92847d51d0c262f60926cc2ae2f","unresolved":true,"context_lines":[{"line_number":122,"context_line":"* ``playback_compression`` \u003d [ ``True`` \\| ``False`` ];"},{"line_number":123,"context_line":"* ``streaming_mode`` \u003d [ ``filter`` \\| ``all`` \\| ``off`` ];"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Each configuration option is optional and can be set explictly to configure the"},{"line_number":126,"context_line":"associated SPICE compression setting for libvirt. If all configuration options"},{"line_number":127,"context_line":"are not set, then none of the SPICE compression settings will be configured for"},{"line_number":128,"context_line":"libvirt, which corresponds to the behavior before this proposed change. In this"},{"line_number":129,"context_line":"case, the built-in defaults from the libvirt backend (e.g. QEMU) are used."}],"source_content_type":"text/x-rst","patch_set":6,"id":"6e30c574_d631cb4b","line":126,"range":{"start_line":125,"start_character":0,"end_line":126,"end_character":48},"in_reply_to":"f17f47bd_7617cf20","updated":"2022-12-14 14:52:00.000000000","message":"We already have a spice group https://docs.openstack.org/nova/latest/configuration/config.html#spice and this proposal targeting to extend that. See L116.","commit_id":"826f0316d0dc7ff6ea95e20171e4e59143f7b051"}],"specs/zed/approved/spice-compression-support.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"86c314f4606a17340f9e54e7f36ded017901e7a7","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Add configuration options to set SPICE compression settings"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/nova-support-spice-compression-algorithm"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes to add SPICE-related options to a Nova configuration."},{"line_number":14,"context_line":"These options can be used to enable and set the SPICE compression settings for"}],"source_content_type":"text/x-rst","patch_set":3,"id":"93cc12df_1d2cf738","line":11,"updated":"2022-07-14 12:30:56.000000000","message":"I\u0027ll ask the same question here that I asked on the code review. Rather than exposing these knobs and dials and asking the user to do the research to determine which option to set, could we (nova) be opinionated and choose one that we enable by default? The defaults you\u0027ve proposed seem like good ones to use, perhaps?","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"a2a243df71c2248dc893b6b18691eb901b35ffbd","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Add configuration options to set SPICE compression settings"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/nova-support-spice-compression-algorithm"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes to add SPICE-related options to a Nova configuration."},{"line_number":14,"context_line":"These options can be used to enable and set the SPICE compression settings for"}],"source_content_type":"text/x-rst","patch_set":3,"id":"4f3895f0_a72d1cf3","line":11,"in_reply_to":"2c34906f_a9b009aa","updated":"2022-07-18 14:32:15.000000000","message":"Done","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"90b396de2af227e1ea21049216f5ac6301338d63","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Add configuration options to set SPICE compression settings"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/nova-support-spice-compression-algorithm"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes to add SPICE-related options to a Nova configuration."},{"line_number":14,"context_line":"These options can be used to enable and set the SPICE compression settings for"}],"source_content_type":"text/x-rst","patch_set":3,"id":"2c34906f_a9b009aa","line":11,"in_reply_to":"93cc12df_1d2cf738","updated":"2022-07-18 08:07:55.000000000","message":"\u003e Rather than exposing these knobs and dials and asking the user to do the research to determine which option to set, could we (nova) be opinionated and choose one that we enable by default?\n\nHere, I want to point out the following libvirt/QEMU fallacy: Many people think that if there is no SPICE compression setting in a libvirt config, then compression is completely turned off. However, this is not correct because libvirt only configures the specified compression settings for QEMU in such a case, which means that all other settings are set to QEMU\u0027s defaults (see https://github.com/qemu/qemu/blob/0ebf76aae58324b8f7bf6af798696687f5f4c2a9/ui/spice-core.c#L774). Long story short: I proposed the default compression settings from libvirt/QEMU.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3f9ca11b52e0ce003ac7cafdf6442e7dc07ae9a3","unresolved":true,"context_lines":[{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"This spec proposes to add configuration options for all transport protocols in"},{"line_number":45,"context_line":"OpenStack that support the explicit activation of builtin compression settings."},{"line_number":46,"context_line":"Currently only the integrated SPICE protocol allows the activation of various"},{"line_number":47,"context_line":"image [1]_ and video [2]_ compression settings to lower the network bandwidth"},{"line_number":48,"context_line":"while improving data transmission for graphic-intense desktops. Since SPICE is"},{"line_number":49,"context_line":"only supported by the libvirt hypervisor (through the QEMU backend), all other"},{"line_number":50,"context_line":"hypervisors and transport protocols are not affected by this proposed change."},{"line_number":51,"context_line":"Libvirt already provides an automatic configuration of SPICE-related"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d705290c_81df21ff","line":48,"range":{"start_line":44,"start_character":0,"end_line":48,"end_character":62},"updated":"2022-07-12 12:50:51.000000000","message":"does this work via the nova spciec proxy in teh web view.\n\nnova does not support user bypassing teh proxy and direclty connecting to the spice endpoint on the qemu isntance.\n\nthe only acces that is supported is via the nova spice html5 proxy.\nhttps://github.com/openstack/nova/blob/master/nova/cmd/spicehtml5proxy.py\n\nso if we configure spice compruesseion i guess websockify with convert the spcie tcp stream (which will now have compresss data) into a websocket connection which will be rendered using javascript and html 5 in your browaser corect.\n\n\nthis will not enabel endusers to connect form there home with a spice client like virt-viewer directly.\n\nhttps://www.spice-space.org/spice-html5.html is the only client we support in nova.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"380ee8d8082edf8f22a7ea31558b1c709153d8dd","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"This spec proposes to add configuration options for all transport protocols in"},{"line_number":45,"context_line":"OpenStack that support the explicit activation of builtin compression settings."},{"line_number":46,"context_line":"Currently only the integrated SPICE protocol allows the activation of various"},{"line_number":47,"context_line":"image [1]_ and video [2]_ compression settings to lower the network bandwidth"},{"line_number":48,"context_line":"while improving data transmission for graphic-intense desktops. Since SPICE is"},{"line_number":49,"context_line":"only supported by the libvirt hypervisor (through the QEMU backend), all other"},{"line_number":50,"context_line":"hypervisors and transport protocols are not affected by this proposed change."},{"line_number":51,"context_line":"Libvirt already provides an automatic configuration of SPICE-related"}],"source_content_type":"text/x-rst","patch_set":3,"id":"b0311267_126ff469","line":48,"range":{"start_line":44,"start_character":0,"end_line":48,"end_character":62},"in_reply_to":"550aa01d_6e50bc94","updated":"2022-07-14 08:56:53.000000000","message":"ack if that effort need changes in nova the design and implementation of such change will have to be discussed and reviewed as another spec in this repo in the future.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"efffad3bccbf06fd91fd23d7eb640908e6c004eb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"This spec proposes to add configuration options for all transport protocols in"},{"line_number":45,"context_line":"OpenStack that support the explicit activation of builtin compression settings."},{"line_number":46,"context_line":"Currently only the integrated SPICE protocol allows the activation of various"},{"line_number":47,"context_line":"image [1]_ and video [2]_ compression settings to lower the network bandwidth"},{"line_number":48,"context_line":"while improving data transmission for graphic-intense desktops. Since SPICE is"},{"line_number":49,"context_line":"only supported by the libvirt hypervisor (through the QEMU backend), all other"},{"line_number":50,"context_line":"hypervisors and transport protocols are not affected by this proposed change."},{"line_number":51,"context_line":"Libvirt already provides an automatic configuration of SPICE-related"}],"source_content_type":"text/x-rst","patch_set":3,"id":"550aa01d_6e50bc94","line":48,"range":{"start_line":44,"start_character":0,"end_line":48,"end_character":62},"in_reply_to":"d705290c_81df21ff","updated":"2022-07-14 08:20:59.000000000","message":"\u003e does this work via the nova spciec proxy in teh web view.\n\nYes, this approach works with the spice-html5 viewer. I\u0027ve tested it a few months ago. Currently, the spice-html5 viewer does not support the LZ4 compression (see open task at https://gitlab.freedesktop.org/spice/spice-html5/-/blob/56ddb3005e39a9e76670fec9676e667d44167bf3/TODO). But this fact does not limit the proposed change since LZ4 support is not enabled by default in the spice-server (see https://gitlab.freedesktop.org/spice/spice/-/blob/4a1e9a03f45770e29770b2eea3d996eb2972599c/meson.build#L152) and more important, it is not compiled by default into QEMU (see https://github.com/qemu/qemu/blob/8e3d85d36b77f11ad7bded3a2d48c1f0cc334f82/ui/spice-core.c#L333) nor supported by libvirt at all (see https://github.com/libvirt/libvirt/blob/b8e94066f078977906effad7e54e9320f5d1fd98/src/conf/domain_conf.h#L1836).\n\n\n\u003e nova does not support user bypassing teh proxy and direclty connecting to the spice endpoint on the qemu isntance.\n\nI\u0027m aware of that. A direct bypass of a proxy (access gateway) should never be allowed, otherwise the security can be leveraged and internal functionality can no longer be guaranteed (e.g. transparent access to a running instance that is live migrated if we do not consider the built-in SPICE migration support).\n\n\n\u003e so if we configure spice compruesseion i guess websockify with convert the spcie tcp stream (which will now have compresss data) into a websocket connection which will be rendered using javascript and html 5 in your browaser corect.\n\nYou\u0027re right. That happens behind the scenes. Since the data is not only compressed up to the proxy, but up to the client browser (e.g. home), the transport of desktop content should be improved, especially if there is a bottleneck (low bandwidth network) between the client and the cloud.\n\n\n\u003e this will not enabel endusers to connect form there home with a spice client like virt-viewer directly.\n\nThat\u0027s correct.\n\nFYI: We are planning an extended SPICE proxy server (access gateway) in the context of a VDI extension for OpenStack, so that the desktop of a running instance can also be transparently accessed by native clients (e.g. remote-viewer/virt-viewer). Such a plan is part of the major goal that we presented in a paper (see https://doi.org/10.1007/978-3-030-99191-3_12) and is already being discussed in the community (see https://lists.openstack.org/pipermail/openstack-discuss/2022-July/029381.html). A key challenge here will be to unite two different cloud infrastructure models, namely cloud computing and VDI. The code base of OpenStack itself should only be adapted as little as possible, so that a base installation of OpenStack does not depend on any VDI logic/features to preserve the intended functionality for pure cloud computing. Then, the VDI functionality (from the code point of view) is really just an extension for OpenStack (where additional service(s) and APIs are implemented which reuse APIs from available components). But that\u0027s another story and will lead to further discussions/blueprints/specs.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4a71f32a22ab00228e6d6ad0335fa74dcb55a77e","unresolved":true,"context_lines":[{"line_number":112,"context_line":"  | default \u003d ``off``"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"The default value for each option is set to libvirt\u0027s default to preserve"},{"line_number":115,"context_line":"compatibility with older Nova configurations where those options are missing."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Developer impact"},{"line_number":118,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5301e452_ab0479f5","line":115,"updated":"2022-07-14 12:40:31.000000000","message":"Sean just highlighted this to me. These look like pretty sane defaults. What\u0027s off with them that means this is not the case? Does \u0027auto\u0027 not do what you\u0027d think it does?","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"90b396de2af227e1ea21049216f5ac6301338d63","unresolved":true,"context_lines":[{"line_number":112,"context_line":"  | default \u003d ``off``"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"The default value for each option is set to libvirt\u0027s default to preserve"},{"line_number":115,"context_line":"compatibility with older Nova configurations where those options are missing."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Developer impact"},{"line_number":118,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"f41dacaa_c4d8a18d","line":115,"in_reply_to":"5301e452_ab0479f5","updated":"2022-07-18 08:07:55.000000000","message":"In older nova configurations (before this change) we have no possibility to set the SPICE compression options. The defaults of QEMU are used there, since no compression settings are explicitly configured by libvirt. But with the proposed spec, SPICE compression settings can be set explicitly, which can change the behavior. In the default case (no SPICE compression options specified in a Nova configuration), we should use the same defaults as before the proposed change (implicit configuration through libvirt/QEMU) to preserve the same SPICE behavior.","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"a2a243df71c2248dc893b6b18691eb901b35ffbd","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  | default \u003d ``off``"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"The default value for each option is set to libvirt\u0027s default to preserve"},{"line_number":115,"context_line":"compatibility with older Nova configurations where those options are missing."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Developer impact"},{"line_number":118,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"26b74a44_0f25b1b0","line":115,"in_reply_to":"f41dacaa_c4d8a18d","updated":"2022-07-18 14:32:15.000000000","message":"Done","commit_id":"b918ee51b45599f882de54f59c7b886c331fa8be"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a9179c54bfb62fffc7fb5fa8f0741cbe6aa1c0a8","unresolved":true,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"The following SPICE-related options should be added to a Nova configuration:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* | ``image_compression`` \u003d [ ``auto_glz`` \\| ``auto_lz`` \\| ``quic`` \\|"},{"line_number":119,"context_line":"    ``glz`` \\| ``lz`` \\| ``off`` ];"},{"line_number":120,"context_line":"  | default \u003d ``auto_glz``"},{"line_number":121,"context_line":"* | ``jpeg_compression`` \u003d [ ``auto`` \\| ``never`` \\| ``always`` ];"},{"line_number":122,"context_line":"  | default \u003d ``auto``"},{"line_number":123,"context_line":"* | ``zlib_compression`` \u003d [ ``auto`` \\| ``never`` \\| ``always`` ];"},{"line_number":124,"context_line":"  | default \u003d ``auto``"},{"line_number":125,"context_line":"* | ``playback_compression`` \u003d [ ``True`` \\| ``False`` ];"},{"line_number":126,"context_line":"  | default \u003d ``True``"},{"line_number":127,"context_line":"* | ``streaming_mode`` \u003d [ ``filter`` \\| ``all`` \\| ``off`` ];"},{"line_number":128,"context_line":"  | default \u003d ``off``"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The default value for each option is set to libvirt\u0027s default to preserve"},{"line_number":131,"context_line":"compatibility with older Nova configurations where those options are missing."}],"source_content_type":"text/x-rst","patch_set":4,"id":"a355fbfc_1f9624c3","line":128,"range":{"start_line":118,"start_character":0,"end_line":128,"end_character":21},"updated":"2022-07-19 17:01:15.000000000","message":"We agreed to turn these to unset by default and not touch the xml unless operator configures these parts.","commit_id":"899d048bf5e0869bd7fbe0e627d4358e7cafaaf2"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"d49d64b7e4c3e6d4dcf1337b519a2a4c67adb3dd","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"The following SPICE-related options should be added to a Nova configuration:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* | ``image_compression`` \u003d [ ``auto_glz`` \\| ``auto_lz`` \\| ``quic`` \\|"},{"line_number":119,"context_line":"    ``glz`` \\| ``lz`` \\| ``off`` ];"},{"line_number":120,"context_line":"  | default \u003d ``auto_glz``"},{"line_number":121,"context_line":"* | ``jpeg_compression`` \u003d [ ``auto`` \\| ``never`` \\| ``always`` ];"},{"line_number":122,"context_line":"  | default \u003d ``auto``"},{"line_number":123,"context_line":"* | ``zlib_compression`` \u003d [ ``auto`` \\| ``never`` \\| ``always`` ];"},{"line_number":124,"context_line":"  | default \u003d ``auto``"},{"line_number":125,"context_line":"* | ``playback_compression`` \u003d [ ``True`` \\| ``False`` ];"},{"line_number":126,"context_line":"  | default \u003d ``True``"},{"line_number":127,"context_line":"* | ``streaming_mode`` \u003d [ ``filter`` \\| ``all`` \\| ``off`` ];"},{"line_number":128,"context_line":"  | default \u003d ``off``"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The default value for each option is set to libvirt\u0027s default to preserve"},{"line_number":131,"context_line":"compatibility with older Nova configurations where those options are missing."}],"source_content_type":"text/x-rst","patch_set":4,"id":"69b846a8_dbf079db","line":128,"range":{"start_line":118,"start_character":0,"end_line":128,"end_character":21},"in_reply_to":"a355fbfc_1f9624c3","updated":"2022-07-20 07:12:47.000000000","message":"Done","commit_id":"899d048bf5e0869bd7fbe0e627d4358e7cafaaf2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e740687ed5509dbf0eb8f3b76043c161e2476fd6","unresolved":true,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The default value for each option is set to libvirt\u0027s default to preserve"},{"line_number":131,"context_line":"compatibility with older Nova configurations where those options are missing."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Developer impact"},{"line_number":134,"context_line":"----------------"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"d85fa5b3_0d0a8f34","line":132,"updated":"2022-07-18 17:18:22.000000000","message":"by the way im mainly ok with this because this feature is not a api viabel feature.\n\nas such there are no commitment or guarentees given to the user about if compression will be used and how.\n\nif this was to evolve into a per instnace (flavor/image property) or per console level feature then i would be more reticent to expose this level of detail to our endusers.","commit_id":"899d048bf5e0869bd7fbe0e627d4358e7cafaaf2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e8bb6b1b757888e84e9d21900c97b55fabd81fbf","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The default value for each option is set to libvirt\u0027s default to preserve"},{"line_number":131,"context_line":"compatibility with older Nova configurations where those options are missing."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Developer impact"},{"line_number":134,"context_line":"----------------"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fddc94d9_62babe17","line":132,"in_reply_to":"d85fa5b3_0d0a8f34","updated":"2022-07-18 17:20:56.000000000","message":"Ack","commit_id":"899d048bf5e0869bd7fbe0e627d4358e7cafaaf2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a0bd4c6e6e4afee695ab5910b0e3ef84cb41526a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"28509987_9dbeabd5","updated":"2022-11-15 11:19:37.000000000","message":"This should be moved to the director specs/2023.1/","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"4c83a0f068daf1bad8bd99c9df561baffb858144","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"31295dae_6f463b7e","in_reply_to":"28509987_9dbeabd5","updated":"2022-11-29 11:33:00.000000000","message":"Done","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"afb5c75227b5b67b24ae433f47c2a5c9c4fef393","unresolved":true,"context_lines":[{"line_number":127,"context_line":"are not set, then none of the SPICE compression settings will be configured for"},{"line_number":128,"context_line":"libvirt, which corresponds to the behavior before this proposed change. In this"},{"line_number":129,"context_line":"case, the built-in defaults from the libvirt backend (e.g. QEMU) are used."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Developer impact"},{"line_number":132,"context_line":"----------------"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"975dc9ce_d7514d38","line":130,"updated":"2022-07-20 11:26:48.000000000","message":"+1\nthis is the main change i raised in the meeting and its is as agreed.","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"cd0dfd6d05e6384ed72c1f35c82cb8324d9eaf85","unresolved":false,"context_lines":[{"line_number":127,"context_line":"are not set, then none of the SPICE compression settings will be configured for"},{"line_number":128,"context_line":"libvirt, which corresponds to the behavior before this proposed change. In this"},{"line_number":129,"context_line":"case, the built-in defaults from the libvirt backend (e.g. QEMU) are used."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Developer impact"},{"line_number":132,"context_line":"----------------"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"f7c45de7_35f2bac2","line":130,"in_reply_to":"975dc9ce_d7514d38","updated":"2022-10-05 06:20:49.000000000","message":"Ack","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a0bd4c6e6e4afee695ab5910b0e3ef84cb41526a","unresolved":true,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"   * - Release Name"},{"line_number":205,"context_line":"     - Description"},{"line_number":206,"context_line":"   * - Zed"},{"line_number":207,"context_line":"     - Introduced"}],"source_content_type":"text/x-rst","patch_set":5,"id":"04586f94_6153e3f0","line":206,"range":{"start_line":206,"start_character":7,"end_line":206,"end_character":10},"updated":"2022-11-15 11:19:37.000000000","message":"2023.1 - Antelope","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"},{"author":{"_account_id":34534,"name":"Manuel Bentele","email":"development@manuel-bentele.de","username":"bahnwaerter"},"change_message_id":"4c83a0f068daf1bad8bd99c9df561baffb858144","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"   * - Release Name"},{"line_number":205,"context_line":"     - Description"},{"line_number":206,"context_line":"   * - Zed"},{"line_number":207,"context_line":"     - Introduced"}],"source_content_type":"text/x-rst","patch_set":5,"id":"aa328fc7_fc573783","line":206,"range":{"start_line":206,"start_character":7,"end_line":206,"end_character":10},"in_reply_to":"04586f94_6153e3f0","updated":"2022-11-29 11:33:00.000000000","message":"Done","commit_id":"2b200d2bc47d0e4718735e96261b38a874c57e6a"}]}