)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbd94a163464060b77b42ced94f2a9b8eac5b3fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"10720fa2_4ad867aa","updated":"2022-07-14 12:52:27.000000000","message":"-1 for same reasons as Sean but in general +2 on the idea","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e92609af88fb85a43355088c274458dd4dedca06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"76d1807c_b89c8870","updated":"2022-07-18 14:47:30.000000000","message":"Boy, this got merged super fast with very little review. I know there\u0027s a deadline approaching, but it feels like there could have been some feedback on this with a little more exposure. Personally I\u0027m kinda mixed on the justification for this and it feels a bit like something nova really shouldn\u0027t be involved in, but it\u0027s the most convenient place to whack the mole.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7abcae630f825ef237afcf0cbf140e706476ad2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"13e00f91_cbd7381f","updated":"2022-07-18 17:31:33.000000000","message":"Feels to me like this deserves more discussion and I\u0027m rather unhappy that we\u0027re discussing this level of detail on a merged spec.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4b56f012746e229aa11c8d777f01c152f7e5a1dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6ee28cc3_8b70760d","updated":"2022-07-18 18:59:49.000000000","message":"Lots of discussion on a merged spec. It\u0027s quite frustrating that this will all be captured only on the merged one and not on the revert and re-propose :(\n\nSylvain, is that the plan? To revert?","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"772072b144362f59fab63c063f91b146fa8f1e91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"83b8b648_d0242918","updated":"2022-07-18 17:07:11.000000000","message":"given the discussion on this spec i suggest that \nsylvain propose a fast revert per our policy or we agree to continue the discussion with follow up patch.\n\nhttps://docs.openstack.org/nova/latest/contributor/policies.html#reverts-for-retrospective-vetos\n\nin either case i will volunteer to pick up the spec definition form artom since he is on PTO for the next week and resuse my self form reviewing it as a result.\n\nif we revert the spec before the team meeting ill propsoe it as a spec freeze excpetion and suggest that we set a deadline of the following meeting july 26th for reapproval. if the issues are not adress by then i suggerst we defer this to the AA release.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7a551ef53088c1642408498ab2b3561512cd3d73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"84b1e7ac_019781f0","in_reply_to":"430ebca6_9eebc3dd","updated":"2022-07-18 18:34:55.000000000","message":"re \"yes and no\",  yes was yes this would be out of scope if the neutron feature was integrated with nova and respresented in the metadata. currently, it is not\nintegrated with nova so if you set a default domain name on a network or port that info is only propagated to designate or used internally by neutron it is not consumed by nova or exposed in the instance metadata API.\n\ncloud-init and other host agents don\u0027t consume per port DNS info today with regards to determining the content of /etc/hostname. if we were to start including that info per port all of the tools would have to be updated to consume it. perhaps that is the right approach but the dns_doamin is not a new extention on the port or network but they have not been request for this info before.\n\ni kind of fundemantally disagree with the idea that hostname goes with the instnace and the domain is an an atribute of the newtork. at least to the extent that its inapproate to have a primary domain for an instance. the fact that we have hostname in the api was jsut for convinence and historical convenice due to how nova-network worked and some of the default behaivor of libvirt ectra. we could have entirly decoupled the isntance name form the hostname and alwasy declared that out of scope but since we did not we have this weired relationship where hostnames are instance specific FQDNs are not supported at all and doamins are network scoped?\n\nthat feels wrong to me and make me quetion if we should perhaps revert our prvious desion to sanitaise hostname.\n\n\nby default neutron networks do not have domains, and its not support by all ml2 drivers as far as im aware. Where the nutron backend supprot per port or per network dns_domsins its a default domain to use when creating ports on that network that dont otherwise have a domain specified.\n\nto me it seams rater restrictive to say that the only way to assocation a domain with a port is via neutron given its an optional part of there api. there would be no portable way to achive this across all clouds.\n\nwith that said i was orginally in the camp that this shoudl be done by neutron too.\n\nthat is where the \"no\" came in, if we agreed this was in scope of nova to do i think a top level instance domain is more appropriate then say addint the option to secicy a dns_domain per port when attaching a prot ro creating a vm in nova\u0027s api.\n\ni.e. i would not supprot treating this like device role tagging where we store that info per port in our db or just proxy it to neutron.\n\ni can see supporting it if its a per instance atibute.\n\nfailing that my prefernce would to be revisit the orginal desice to set hostname from a sanadtised verion fo displayname.\n\ni.e. just allow FQDNs and fix nova interaction with neutron so that we can split the hoatname and domain name correctly.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"de9432d5211d136e9479950e973d1b149d0275dc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cbef1b0d_70f5941a","in_reply_to":"6ee28cc3_8b70760d","updated":"2022-07-18 22:56:25.000000000","message":"ya im going to hold of  on commenting on this more i think until we do the revert or create a followup patch","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"772072b144362f59fab63c063f91b146fa8f1e91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f5a1e67d_4d67278a","in_reply_to":"76d1807c_b89c8870","updated":"2022-07-18 17:07:11.000000000","message":"yes and no. this feature has no depency on neutron or designate to achive its primary usecase of ensureing the metadtaa generated by nova contains an fqdn generate by combining the hostanem and domin name.\n\nwe have an optional dependency on the neutron per port dns name extention if and only if we want to propagate the domain name infor to neutron and transitivly to designate so that the vm is automatically resolvebale in dns.\n\nthis spec does not depend on the neutron extention however.\nit would be feature complete without updating the neutron prot as long as the metadata is generated properly so that cloud-init or other guest level agents can retrieve the cannonical guest name.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f5729552160065df5497406ca3f2fbaa0e731426","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"86da1c51_acf6ffdd","in_reply_to":"83b8b648_d0242918","updated":"2022-07-18 17:32:20.000000000","message":"\u003e given the discussion on this spec i suggest that \n\u003e sylvain propose a fast revert per our policy or we agree to continue the discussion with follow up patch.\n\u003e \n\u003e https://docs.openstack.org/nova/latest/contributor/policies.html#reverts-for-retrospective-vetos\n\n++ agree","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4b56f012746e229aa11c8d777f01c152f7e5a1dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a0a4ff09_fd8e650d","in_reply_to":"84b1e7ac_019781f0","updated":"2022-07-18 18:59:49.000000000","message":"\u003e i kind of fundemantally disagree with the idea that hostname goes with the instnace and the domain is an an atribute of the newtork. at least to the extent that its inapproate to have a primary domain for an instance. the fact that we have hostname in the api was jsut for convinence and historical convenice due to how nova-network worked and some of the default behaivor of libvirt ectra. we could have entirly decoupled the isntance name form the hostname and alwasy declared that out of scope but since we did not we have this weired relationship where hostnames are instance specific FQDNs are not supported at all and doamins are network scoped?\n\nIn almost all modern scenarios that I know of, the client has some notion of its own name (either from config or told to it) and the network tells it what the FQDN is. The client says \"I\u0027m bob\" and the network says \"Okay, here you are bob.example.com\". If that client goes to another network, the same thing happens, but for the other domain. In cases where clients tell the network that they already know their FQDN, either DDNS breaks or something along the line chops off the hostname, almost exclusively honoring only that part of what the client said.\n\n\u003e that feels wrong to me and make me quetion if we should perhaps revert our prvious desion to sanitaise hostname.\n\nWhat does the decision to sanitize the hostname have to do with the rest of the FQDN? Or are you saying we should have answered the sanitization question with dropping it entirely?\n\n\u003e by default neutron networks do not have domains, and its not support by all ml2 drivers as far as im aware. Where the nutron backend supprot per port or per network dns_domsins its a default domain to use when creating ports on that network that dont otherwise have a domain specified.\n\u003e \n\u003e to me it seams rater restrictive to say that the only way to assocation a domain with a port is via neutron given its an optional part of there api. there would be no portable way to achive this across all clouds.\n\nI guess, but I would also say that if a cloud is using a network driver without this support, then they just don\u0027t support managing this for users. \n\n\u003e with that said i was orginally in the camp that this shoudl be done by neutron too.\n\u003e \n\u003e that is where the \"no\" came in, if we agreed this was in scope of nova to do i think a top level instance domain is more appropriate then say addint the option to secicy a dns_domain per port when attaching a prot ro creating a vm in nova\u0027s api.\n\u003e \n\u003e i.e. i would not supprot treating this like device role tagging where we store that info per port in our db or just proxy it to neutron.\n\u003e \n\u003e i can see supporting it if its a per instance atibute.\n\u003e \n\u003e failing that my prefernce would to be revisit the orginal desice to set hostname from a sanadtised verion fo displayname.\n\u003e \n\u003e i.e. just allow FQDNs and fix nova interaction with neutron so that we can split the hoatname and domain name correctly.\n\nI dunno, I guess my point is that with displayname, it\u0027s truly the user\u0027s choice. Generating a hostname from that, if we know what works for the local network, makes sense to me either for nova or neutron to do with operator input. Letting people specify a rather critical network parameter with no input from the managed infrastructure that controls that just seems like a waste of time and invitation for confusion from users who are expecting this stuff to actually talk to each other. IMHO, well-behaved infrastructure would ensure that the hostname is set to *something* that is lookup-able in DNS and points back to us. Two instances with the same network config should have the same behavior. If the user wants to override it for vanity or other reasons, then either doing that through the network infrastructure (if possible) or through custom config seems like the right path to me.\n\nAdding another field to nova that is just a passthrough to the instance but that is totally un-correllated to the rest of the infrastructure just seems pointless to me for an IaaS setup. That\u0027s the benefit openstack should be providing over just bare VMs on libvirt, and IIRC, is something that k8s makes a more critical part of how stuff works there. For the better.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"de9432d5211d136e9479950e973d1b149d0275dc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"679ab6c2_943a2cc6","in_reply_to":"a0a4ff09_fd8e650d","updated":"2022-07-18 22:56:25.000000000","message":"i hate the resovled comment feature i acidentilly clicked it and lost what i had typed.\n\nim going to wait tiil we either create a follow up or revert and repoen.\n\nclip notes version of my respoce were yes we considered truncation in the past and if we had gone with that it would have allowed dns search domain from dhcp to be used to figure out the fqdn.\n\novn only got support for the dns-domain-ports extensions in yoga\nhttps://github.com/openstack/neutron/commit/8a890ed29c681847d930bdf5403926c2e1450f9d\nit was one of the many feature gaps in its dns support.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7abcae630f825ef237afcf0cbf140e706476ad2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"430ebca6_9eebc3dd","in_reply_to":"f5a1e67d_4d67278a","updated":"2022-07-18 17:31:33.000000000","message":"Yes and no what? I know that this is currently proposed as just a hack in nova to let people plumb a domain name through to metadata that cloud-init can handle. What I\u0027m saying is I think it\u0027s really not appropriate for us to be hacking around it in general.\n\nI understand the concern of not knowing which domain from multiple ports should be the canonical one, but I\u0027d much prefer to solve that than to just make more stuff that people have to pass in so that things work as they should. IIRC, our port list in our cache has to remain sorted for other reasons, so we could say \"the first one is primary\" or we could note the ID of the primary network or port in sysmeta to keep it consistent. Or we could add a flag to say \"this is the network I want to be my primary\" so that we can properly extract the domain name from it.\n\nIMHO, the hostname goes with the instance, the domain name goes with the network, and the choice of primary affinity is the only thing we should really be exposing in a managed infrastructure arrangement like openstack.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"}],"specs/zed/approved/configurable-instance-domains.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbd94a163464060b77b42ced94f2a9b8eac5b3fd","unresolved":true,"context_lines":[{"line_number":35,"context_line":"DHCP. Cloud-init uses the Nova metadata API - specifically the ``hostname``"},{"line_number":36,"context_line":"field - as an information source."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The Domain Names in Metadata spec [3] was originally proposed as a light weight"},{"line_number":39,"context_line":"way of addressing this gap. It proposed exposing an instance\u0027s network(s)\u0027s"},{"line_number":40,"context_line":"``dns_domain`` value(s) in the metadata. However, the only way of intelligently"},{"line_number":41,"context_line":"handling instances with multiple ports on different network is to expose every"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d2324dc2_d342aabc","line":38,"range":{"start_line":38,"start_character":67,"end_line":38,"end_character":79},"updated":"2022-07-14 12:52:27.000000000","message":"nit: lightweight","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1ec2211ef259e555b7ef412a8190d0cdc5d228a2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"DHCP. Cloud-init uses the Nova metadata API - specifically the ``hostname``"},{"line_number":36,"context_line":"field - as an information source."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The Domain Names in Metadata spec [3] was originally proposed as a light weight"},{"line_number":39,"context_line":"way of addressing this gap. It proposed exposing an instance\u0027s network(s)\u0027s"},{"line_number":40,"context_line":"``dns_domain`` value(s) in the metadata. However, the only way of intelligently"},{"line_number":41,"context_line":"handling instances with multiple ports on different network is to expose every"}],"source_content_type":"text/x-rst","patch_set":1,"id":"43415037_d429da5f","line":38,"range":{"start_line":38,"start_character":67,"end_line":38,"end_character":79},"in_reply_to":"d2324dc2_d342aabc","updated":"2022-07-14 18:09:08.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c052bfc4eb381f110ce6cc86d2d4b0bcf1367e3a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"DHCP. Cloud-init uses the Nova metadata API - specifically the ``hostname``"},{"line_number":36,"context_line":"field - as an information source."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The Domain Names in Metadata spec [3] was originally proposed as a light weight"},{"line_number":39,"context_line":"way of addressing this gap. It proposed exposing an instance\u0027s network(s)\u0027s"},{"line_number":40,"context_line":"``dns_domain`` value(s) in the metadata. However, the only way of intelligently"},{"line_number":41,"context_line":"handling instances with multiple ports on different network is to expose every"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f82cec7f_88e81315","line":38,"range":{"start_line":38,"start_character":67,"end_line":38,"end_character":79},"in_reply_to":"d2324dc2_d342aabc","updated":"2022-07-14 18:06:11.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"50fdd81831e6300790c26ecf41ffe2447573dd9a","unresolved":true,"context_lines":[{"line_number":36,"context_line":"field - as an information source."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The Domain Names in Metadata spec [3] was originally proposed as a light weight"},{"line_number":39,"context_line":"way of addressing this gap. It proposed exposing an instance\u0027s network(s)\u0027s"},{"line_number":40,"context_line":"``dns_domain`` value(s) in the metadata. However, the only way of intelligently"},{"line_number":41,"context_line":"handling instances with multiple ports on different network is to expose every"},{"line_number":42,"context_line":"network\u0027s ``dns_domain`` in its own subsection in the metadata. This is useless"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffcd9240_b47bad08","line":39,"updated":"2022-07-14 08:48:40.000000000","message":"s/network/port/g","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"772072b144362f59fab63c063f91b146fa8f1e91","unresolved":false,"context_lines":[{"line_number":36,"context_line":"field - as an information source."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The Domain Names in Metadata spec [3] was originally proposed as a light weight"},{"line_number":39,"context_line":"way of addressing this gap. It proposed exposing an instance\u0027s network(s)\u0027s"},{"line_number":40,"context_line":"``dns_domain`` value(s) in the metadata. However, the only way of intelligently"},{"line_number":41,"context_line":"handling instances with multiple ports on different network is to expose every"},{"line_number":42,"context_line":"network\u0027s ``dns_domain`` in its own subsection in the metadata. This is useless"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0044ab91_5ce97a23","line":39,"in_reply_to":"8ed74c3c_6dcde6c2","updated":"2022-07-18 17:07:11.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1ec2211ef259e555b7ef412a8190d0cdc5d228a2","unresolved":true,"context_lines":[{"line_number":36,"context_line":"field - as an information source."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The Domain Names in Metadata spec [3] was originally proposed as a light weight"},{"line_number":39,"context_line":"way of addressing this gap. It proposed exposing an instance\u0027s network(s)\u0027s"},{"line_number":40,"context_line":"``dns_domain`` value(s) in the metadata. However, the only way of intelligently"},{"line_number":41,"context_line":"handling instances with multiple ports on different network is to expose every"},{"line_number":42,"context_line":"network\u0027s ``dns_domain`` in its own subsection in the metadata. This is useless"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8ed74c3c_6dcde6c2","line":39,"in_reply_to":"ffcd9240_b47bad08","updated":"2022-07-14 18:09:08.000000000","message":"Ah, for some reason I thought dns_domain was on networks only. Fixed.","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c052bfc4eb381f110ce6cc86d2d4b0bcf1367e3a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"field - as an information source."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The Domain Names in Metadata spec [3] was originally proposed as a light weight"},{"line_number":39,"context_line":"way of addressing this gap. It proposed exposing an instance\u0027s network(s)\u0027s"},{"line_number":40,"context_line":"``dns_domain`` value(s) in the metadata. However, the only way of intelligently"},{"line_number":41,"context_line":"handling instances with multiple ports on different network is to expose every"},{"line_number":42,"context_line":"network\u0027s ``dns_domain`` in its own subsection in the metadata. This is useless"}],"source_content_type":"text/x-rst","patch_set":1,"id":"cb629da9_3aed6bf6","line":39,"in_reply_to":"ffcd9240_b47bad08","updated":"2022-07-14 18:06:11.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"50fdd81831e6300790c26ecf41ffe2447573dd9a","unresolved":true,"context_lines":[{"line_number":61,"context_line":"It is also exposed in the list detailed server (``GET /servers/detail``) and"},{"line_number":62,"context_line":"show server details (``GET /servers/{id}``) APIs."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The metadata API will use this new ``Instace.hostname`` where it currently uses"},{"line_number":65,"context_line":"the ``[api]dhcp_domain`` config option. If no ``Instance.hostname`` is set, the"},{"line_number":66,"context_line":"metadata API will continue to fallback on ``[api]dhcp_domain`` like it"},{"line_number":67,"context_line":"currently does."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9fd5a362_ba788fa3","line":64,"updated":"2022-07-14 08:48:40.000000000","message":"Instance.domain","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6efcb1a1bc7a8e6054c56cc3a0b5f17026926b20","unresolved":false,"context_lines":[{"line_number":61,"context_line":"It is also exposed in the list detailed server (``GET /servers/detail``) and"},{"line_number":62,"context_line":"show server details (``GET /servers/{id}``) APIs."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The metadata API will use this new ``Instace.hostname`` where it currently uses"},{"line_number":65,"context_line":"the ``[api]dhcp_domain`` config option. If no ``Instance.hostname`` is set, the"},{"line_number":66,"context_line":"metadata API will continue to fallback on ``[api]dhcp_domain`` like it"},{"line_number":67,"context_line":"currently does."}],"source_content_type":"text/x-rst","patch_set":1,"id":"54516082_861b728c","line":64,"in_reply_to":"506dc02b_58478d45","updated":"2022-07-14 18:13:23.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1ec2211ef259e555b7ef412a8190d0cdc5d228a2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"It is also exposed in the list detailed server (``GET /servers/detail``) and"},{"line_number":62,"context_line":"show server details (``GET /servers/{id}``) APIs."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The metadata API will use this new ``Instace.hostname`` where it currently uses"},{"line_number":65,"context_line":"the ``[api]dhcp_domain`` config option. If no ``Instance.hostname`` is set, the"},{"line_number":66,"context_line":"metadata API will continue to fallback on ``[api]dhcp_domain`` like it"},{"line_number":67,"context_line":"currently does."}],"source_content_type":"text/x-rst","patch_set":1,"id":"e2b08fdd_6464a342","line":64,"in_reply_to":"5edd4af2_62203dcf","updated":"2022-07-14 18:09:08.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c052bfc4eb381f110ce6cc86d2d4b0bcf1367e3a","unresolved":true,"context_lines":[{"line_number":61,"context_line":"It is also exposed in the list detailed server (``GET /servers/detail``) and"},{"line_number":62,"context_line":"show server details (``GET /servers/{id}``) APIs."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The metadata API will use this new ``Instace.hostname`` where it currently uses"},{"line_number":65,"context_line":"the ``[api]dhcp_domain`` config option. If no ``Instance.hostname`` is set, the"},{"line_number":66,"context_line":"metadata API will continue to fallback on ``[api]dhcp_domain`` like it"},{"line_number":67,"context_line":"currently does."}],"source_content_type":"text/x-rst","patch_set":1,"id":"506dc02b_58478d45","line":64,"in_reply_to":"5edd4af2_62203dcf","updated":"2022-07-14 18:06:11.000000000","message":"you missed hostname-\u003edomain but you did add the second n to Instance","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbd94a163464060b77b42ced94f2a9b8eac5b3fd","unresolved":true,"context_lines":[{"line_number":61,"context_line":"It is also exposed in the list detailed server (``GET /servers/detail``) and"},{"line_number":62,"context_line":"show server details (``GET /servers/{id}``) APIs."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The metadata API will use this new ``Instace.hostname`` where it currently uses"},{"line_number":65,"context_line":"the ``[api]dhcp_domain`` config option. If no ``Instance.hostname`` is set, the"},{"line_number":66,"context_line":"metadata API will continue to fallback on ``[api]dhcp_domain`` like it"},{"line_number":67,"context_line":"currently does."}],"source_content_type":"text/x-rst","patch_set":1,"id":"e85c2568_c3cbbd9a","line":64,"in_reply_to":"9fd5a362_ba788fa3","updated":"2022-07-14 12:52:27.000000000","message":"Ooh, Sean getting in on the spelling corrections... 🥷","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"03f9003a34c3ec57a58319d891c01158c1bd27c5","unresolved":true,"context_lines":[{"line_number":61,"context_line":"It is also exposed in the list detailed server (``GET /servers/detail``) and"},{"line_number":62,"context_line":"show server details (``GET /servers/{id}``) APIs."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The metadata API will use this new ``Instace.hostname`` where it currently uses"},{"line_number":65,"context_line":"the ``[api]dhcp_domain`` config option. If no ``Instance.hostname`` is set, the"},{"line_number":66,"context_line":"metadata API will continue to fallback on ``[api]dhcp_domain`` like it"},{"line_number":67,"context_line":"currently does."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5edd4af2_62203dcf","line":64,"in_reply_to":"e85c2568_c3cbbd9a","updated":"2022-07-14 12:58:59.000000000","message":":)","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"50fdd81831e6300790c26ecf41ffe2447573dd9a","unresolved":true,"context_lines":[{"line_number":62,"context_line":"show server details (``GET /servers/{id}``) APIs."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The metadata API will use this new ``Instace.hostname`` where it currently uses"},{"line_number":65,"context_line":"the ``[api]dhcp_domain`` config option. If no ``Instance.hostname`` is set, the"},{"line_number":66,"context_line":"metadata API will continue to fallback on ``[api]dhcp_domain`` like it"},{"line_number":67,"context_line":"currently does."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"621b9253_ab033c0b","line":65,"range":{"start_line":65,"start_character":56,"end_line":65,"end_character":65},"updated":"2022-07-14 08:48:40.000000000","message":"domain","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c052bfc4eb381f110ce6cc86d2d4b0bcf1367e3a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"show server details (``GET /servers/{id}``) APIs."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The metadata API will use this new ``Instace.hostname`` where it currently uses"},{"line_number":65,"context_line":"the ``[api]dhcp_domain`` config option. If no ``Instance.hostname`` is set, the"},{"line_number":66,"context_line":"metadata API will continue to fallback on ``[api]dhcp_domain`` like it"},{"line_number":67,"context_line":"currently does."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bd13d2e5_07bd3f10","line":65,"range":{"start_line":65,"start_character":56,"end_line":65,"end_character":65},"in_reply_to":"621b9253_ab033c0b","updated":"2022-07-14 18:06:11.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1ec2211ef259e555b7ef412a8190d0cdc5d228a2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"show server details (``GET /servers/{id}``) APIs."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The metadata API will use this new ``Instace.hostname`` where it currently uses"},{"line_number":65,"context_line":"the ``[api]dhcp_domain`` config option. If no ``Instance.hostname`` is set, the"},{"line_number":66,"context_line":"metadata API will continue to fallback on ``[api]dhcp_domain`` like it"},{"line_number":67,"context_line":"currently does."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"d4c90481_d3e3b9d2","line":65,"range":{"start_line":65,"start_character":56,"end_line":65,"end_character":65},"in_reply_to":"621b9253_ab033c0b","updated":"2022-07-14 18:09:08.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"50fdd81831e6300790c26ecf41ffe2447573dd9a","unresolved":true,"context_lines":[{"line_number":67,"context_line":"currently does."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Unlike with ``hostname`` and Neutron\u0027s ``dns_name`` field (which is on"},{"line_number":70,"context_line":"*ports*), Nova will *not* update Neutron networks with the value of the"},{"line_number":71,"context_line":"``domain`` field passed by the user. The explicit purpose of the ``domain``"},{"line_number":72,"context_line":"field is to allow users to set the instance domain to be exposed to the guest"},{"line_number":73,"context_line":"operating system. Using it to clobber Neutron\u0027s ``dns_domain`` field is"}],"source_content_type":"text/x-rst","patch_set":1,"id":"aba0d26d_a1368c12","line":70,"updated":"2022-07-14 08:48:40.000000000","message":"right because that would never have been correct to do,. we can set the dns_domain name on a neutron port created by nova and should longterm but it does not need to be in the inital version of this feature.","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"772072b144362f59fab63c063f91b146fa8f1e91","unresolved":false,"context_lines":[{"line_number":67,"context_line":"currently does."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Unlike with ``hostname`` and Neutron\u0027s ``dns_name`` field (which is on"},{"line_number":70,"context_line":"*ports*), Nova will *not* update Neutron networks with the value of the"},{"line_number":71,"context_line":"``domain`` field passed by the user. The explicit purpose of the ``domain``"},{"line_number":72,"context_line":"field is to allow users to set the instance domain to be exposed to the guest"},{"line_number":73,"context_line":"operating system. Using it to clobber Neutron\u0027s ``dns_domain`` field is"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3dc6774d_b983fb36","line":70,"in_reply_to":"363b444f_4946073b","updated":"2022-07-18 17:07:11.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c052bfc4eb381f110ce6cc86d2d4b0bcf1367e3a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"currently does."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Unlike with ``hostname`` and Neutron\u0027s ``dns_name`` field (which is on"},{"line_number":70,"context_line":"*ports*), Nova will *not* update Neutron networks with the value of the"},{"line_number":71,"context_line":"``domain`` field passed by the user. The explicit purpose of the ``domain``"},{"line_number":72,"context_line":"field is to allow users to set the instance domain to be exposed to the guest"},{"line_number":73,"context_line":"operating system. Using it to clobber Neutron\u0027s ``dns_domain`` field is"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2cf61330_4e6d16a5","line":70,"in_reply_to":"aba0d26d_a1368c12","updated":"2022-07-14 18:06:11.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1ec2211ef259e555b7ef412a8190d0cdc5d228a2","unresolved":true,"context_lines":[{"line_number":67,"context_line":"currently does."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Unlike with ``hostname`` and Neutron\u0027s ``dns_name`` field (which is on"},{"line_number":70,"context_line":"*ports*), Nova will *not* update Neutron networks with the value of the"},{"line_number":71,"context_line":"``domain`` field passed by the user. The explicit purpose of the ``domain``"},{"line_number":72,"context_line":"field is to allow users to set the instance domain to be exposed to the guest"},{"line_number":73,"context_line":"operating system. Using it to clobber Neutron\u0027s ``dns_domain`` field is"}],"source_content_type":"text/x-rst","patch_set":1,"id":"363b444f_4946073b","line":70,"in_reply_to":"aba0d26d_a1368c12","updated":"2022-07-14 18:09:08.000000000","message":"So if dns_domain exists on ports as well, I think it would make sense for Nova to set it, and to explicitly define the precedence of Neutron network dns_domain -\u003e port -\u003e instance.domain (where -\u003e means \"is overridden by\")","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"50fdd81831e6300790c26ecf41ffe2447573dd9a","unresolved":true,"context_lines":[{"line_number":71,"context_line":"``domain`` field passed by the user. The explicit purpose of the ``domain``"},{"line_number":72,"context_line":"field is to allow users to set the instance domain to be exposed to the guest"},{"line_number":73,"context_line":"operating system. Using it to clobber Neutron\u0027s ``dns_domain`` field is"},{"line_number":74,"context_line":"destructive. For example, what happens if two instances with different"},{"line_number":75,"context_line":"``domain`` values are booted with ports on the same network? Nova should not"},{"line_number":76,"context_line":"update the networks\u0027s ``dns_domain`` values with what it received from the user"},{"line_number":77,"context_line":"as the ``domain``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fb275dc7_b9a7a370","line":74,"updated":"2022-07-14 08:48:40.000000000","message":"you seam to be under the impression that dns_domain is only an atribute on the network its also an atribute on the port and when set it on the port it has precidence over the dns_domain on the network.\n\nthe network is just a conveince way to map domains to all port on a network by default but","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c052bfc4eb381f110ce6cc86d2d4b0bcf1367e3a","unresolved":false,"context_lines":[{"line_number":71,"context_line":"``domain`` field passed by the user. The explicit purpose of the ``domain``"},{"line_number":72,"context_line":"field is to allow users to set the instance domain to be exposed to the guest"},{"line_number":73,"context_line":"operating system. Using it to clobber Neutron\u0027s ``dns_domain`` field is"},{"line_number":74,"context_line":"destructive. For example, what happens if two instances with different"},{"line_number":75,"context_line":"``domain`` values are booted with ports on the same network? Nova should not"},{"line_number":76,"context_line":"update the networks\u0027s ``dns_domain`` values with what it received from the user"},{"line_number":77,"context_line":"as the ``domain``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"b5e3a263_9103d4e9","line":74,"in_reply_to":"fb275dc7_b9a7a370","updated":"2022-07-14 18:06:11.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"50fdd81831e6300790c26ecf41ffe2447573dd9a","unresolved":true,"context_lines":[{"line_number":74,"context_line":"destructive. For example, what happens if two instances with different"},{"line_number":75,"context_line":"``domain`` values are booted with ports on the same network? Nova should not"},{"line_number":76,"context_line":"update the networks\u0027s ``dns_domain`` values with what it received from the user"},{"line_number":77,"context_line":"as the ``domain``."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Alternatives"},{"line_number":80,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f9492bd0_8c9989f9","line":77,"updated":"2022-07-14 08:48:40.000000000","message":"i would just drop everything form link 69 to here as i dont think we ever suggested you should ever touch the network.\n\neven for the metadata appoch we are not proceeding with i pointed out several times that the network is not the souce of troute of the dns_name its a precidence relationship where port\u003enetwork\u003econfig","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbd6da453f32911ca31feeae157bfbbbc4cf8bb7","unresolved":true,"context_lines":[{"line_number":74,"context_line":"destructive. For example, what happens if two instances with different"},{"line_number":75,"context_line":"``domain`` values are booted with ports on the same network? Nova should not"},{"line_number":76,"context_line":"update the networks\u0027s ``dns_domain`` values with what it received from the user"},{"line_number":77,"context_line":"as the ``domain``."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Alternatives"},{"line_number":80,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"978f80e1_6ae55be7","line":77,"in_reply_to":"6548fdf9_2e1dea83","updated":"2022-07-14 13:02:52.000000000","message":"i just suggested droping it since the discusion was form perspecteive never about updating the dns_domain on the network. we did disucss updateing it on the neutorn port but i did not think the network was ever in scope.\nso im fine with it in alterniteive i just never tought this was going to be part of the proposed change.","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c052bfc4eb381f110ce6cc86d2d4b0bcf1367e3a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"destructive. For example, what happens if two instances with different"},{"line_number":75,"context_line":"``domain`` values are booted with ports on the same network? Nova should not"},{"line_number":76,"context_line":"update the networks\u0027s ``dns_domain`` values with what it received from the user"},{"line_number":77,"context_line":"as the ``domain``."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Alternatives"},{"line_number":80,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"34609ef8_bf9b4f39","line":77,"in_reply_to":"978f80e1_6ae55be7","updated":"2022-07-14 18:06:11.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f194eca561bc8d983057bf8071c201b9337c2166","unresolved":true,"context_lines":[{"line_number":74,"context_line":"destructive. For example, what happens if two instances with different"},{"line_number":75,"context_line":"``domain`` values are booted with ports on the same network? Nova should not"},{"line_number":76,"context_line":"update the networks\u0027s ``dns_domain`` values with what it received from the user"},{"line_number":77,"context_line":"as the ``domain``."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Alternatives"},{"line_number":80,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6548fdf9_2e1dea83","line":77,"in_reply_to":"f9492bd0_8c9989f9","updated":"2022-07-14 12:52:59.000000000","message":"Personally I think it\u0027s good context. We could put it in the alternatives section if you\u0027d prefer that.","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"50fdd81831e6300790c26ecf41ffe2447573dd9a","unresolved":true,"context_lines":[{"line_number":88,"context_line":"-----------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"The new ``domain`` field is added to the ``Instance`` object and its database"},{"line_number":91,"context_line":"table."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"REST API impact"},{"line_number":94,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c2e6bf2e_8f273269","line":91,"updated":"2022-07-14 08:48:40.000000000","message":"we could also store it in the instance_system_metadata to avoid the db migrtion.","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c052bfc4eb381f110ce6cc86d2d4b0bcf1367e3a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"-----------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"The new ``domain`` field is added to the ``Instance`` object and its database"},{"line_number":91,"context_line":"table."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"REST API impact"},{"line_number":94,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1724e6b0_c12966d2","line":91,"in_reply_to":"3d496014_faff9dca","updated":"2022-07-14 18:06:11.000000000","message":"Ack","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"03f9003a34c3ec57a58319d891c01158c1bd27c5","unresolved":true,"context_lines":[{"line_number":88,"context_line":"-----------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"The new ``domain`` field is added to the ``Instance`` object and its database"},{"line_number":91,"context_line":"table."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"REST API impact"},{"line_number":94,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3d496014_faff9dca","line":91,"in_reply_to":"c274f2c8_e6db5d53","updated":"2022-07-14 12:58:59.000000000","message":"Ack, just thought i would mention it as a possibility i have no issues with adding the new column.","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbd94a163464060b77b42ced94f2a9b8eac5b3fd","unresolved":true,"context_lines":[{"line_number":88,"context_line":"-----------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"The new ``domain`` field is added to the ``Instance`` object and its database"},{"line_number":91,"context_line":"table."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"REST API impact"},{"line_number":94,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c274f2c8_e6db5d53","line":91,"in_reply_to":"c2e6bf2e_8f273269","updated":"2022-07-14 12:52:27.000000000","message":"We could, but if hostname is a first class citizen then I think this should be too. It\u0027s also a way to test the DB migration machinery (which is something I\u0027m keen to do)","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbd94a163464060b77b42ced94f2a9b8eac5b3fd","unresolved":true,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* It cannot exceed 189 characters in length. This is calculated from the"},{"line_number":102,"context_line":"  maximum domain name length of 253 characters as stated in RFC 1035, minus"},{"line_number":103,"context_line":"  what Nova currenclty allows for the ``hostname`` field (63 characters), minus"},{"line_number":104,"context_line":"  1 character for the perdiod (``.``) to join them."},{"line_number":105,"context_line":"* It must consist of alphanumeric characters, dashes (``-``) and at least one"},{"line_number":106,"context_line":"  or more periods (``.``).  Characters outside this set will be rejected."}],"source_content_type":"text/x-rst","patch_set":1,"id":"faf29785_b0a84cb1","line":103,"range":{"start_line":103,"start_character":12,"end_line":103,"end_character":22},"updated":"2022-07-14 12:52:27.000000000","message":"nit: currently","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c052bfc4eb381f110ce6cc86d2d4b0bcf1367e3a","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* It cannot exceed 189 characters in length. This is calculated from the"},{"line_number":102,"context_line":"  maximum domain name length of 253 characters as stated in RFC 1035, minus"},{"line_number":103,"context_line":"  what Nova currenclty allows for the ``hostname`` field (63 characters), minus"},{"line_number":104,"context_line":"  1 character for the perdiod (``.``) to join them."},{"line_number":105,"context_line":"* It must consist of alphanumeric characters, dashes (``-``) and at least one"},{"line_number":106,"context_line":"  or more periods (``.``).  Characters outside this set will be rejected."}],"source_content_type":"text/x-rst","patch_set":1,"id":"04432dfc_6c2c67f8","line":103,"range":{"start_line":103,"start_character":12,"end_line":103,"end_character":22},"in_reply_to":"faf29785_b0a84cb1","updated":"2022-07-14 18:06:11.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1ec2211ef259e555b7ef412a8190d0cdc5d228a2","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* It cannot exceed 189 characters in length. This is calculated from the"},{"line_number":102,"context_line":"  maximum domain name length of 253 characters as stated in RFC 1035, minus"},{"line_number":103,"context_line":"  what Nova currenclty allows for the ``hostname`` field (63 characters), minus"},{"line_number":104,"context_line":"  1 character for the perdiod (``.``) to join them."},{"line_number":105,"context_line":"* It must consist of alphanumeric characters, dashes (``-``) and at least one"},{"line_number":106,"context_line":"  or more periods (``.``).  Characters outside this set will be rejected."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ebbefb6_041c6978","line":103,"range":{"start_line":103,"start_character":12,"end_line":103,"end_character":22},"in_reply_to":"faf29785_b0a84cb1","updated":"2022-07-14 18:09:08.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbd94a163464060b77b42ced94f2a9b8eac5b3fd","unresolved":true,"context_lines":[{"line_number":101,"context_line":"* It cannot exceed 189 characters in length. This is calculated from the"},{"line_number":102,"context_line":"  maximum domain name length of 253 characters as stated in RFC 1035, minus"},{"line_number":103,"context_line":"  what Nova currenclty allows for the ``hostname`` field (63 characters), minus"},{"line_number":104,"context_line":"  1 character for the perdiod (``.``) to join them."},{"line_number":105,"context_line":"* It must consist of alphanumeric characters, dashes (``-``) and at least one"},{"line_number":106,"context_line":"  or more periods (``.``).  Characters outside this set will be rejected."},{"line_number":107,"context_line":"* The top-level domain, what comes afer the last period, must be letters of the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ccd0d9fc_60aecd5a","line":104,"range":{"start_line":104,"start_character":22,"end_line":104,"end_character":29},"updated":"2022-07-14 12:52:27.000000000","message":"nit: period","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1ec2211ef259e555b7ef412a8190d0cdc5d228a2","unresolved":false,"context_lines":[{"line_number":101,"context_line":"* It cannot exceed 189 characters in length. This is calculated from the"},{"line_number":102,"context_line":"  maximum domain name length of 253 characters as stated in RFC 1035, minus"},{"line_number":103,"context_line":"  what Nova currenclty allows for the ``hostname`` field (63 characters), minus"},{"line_number":104,"context_line":"  1 character for the perdiod (``.``) to join them."},{"line_number":105,"context_line":"* It must consist of alphanumeric characters, dashes (``-``) and at least one"},{"line_number":106,"context_line":"  or more periods (``.``).  Characters outside this set will be rejected."},{"line_number":107,"context_line":"* The top-level domain, what comes afer the last period, must be letters of the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0233c74d_5afd7847","line":104,"range":{"start_line":104,"start_character":22,"end_line":104,"end_character":29},"in_reply_to":"ccd0d9fc_60aecd5a","updated":"2022-07-14 18:09:08.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c052bfc4eb381f110ce6cc86d2d4b0bcf1367e3a","unresolved":false,"context_lines":[{"line_number":101,"context_line":"* It cannot exceed 189 characters in length. This is calculated from the"},{"line_number":102,"context_line":"  maximum domain name length of 253 characters as stated in RFC 1035, minus"},{"line_number":103,"context_line":"  what Nova currenclty allows for the ``hostname`` field (63 characters), minus"},{"line_number":104,"context_line":"  1 character for the perdiod (``.``) to join them."},{"line_number":105,"context_line":"* It must consist of alphanumeric characters, dashes (``-``) and at least one"},{"line_number":106,"context_line":"  or more periods (``.``).  Characters outside this set will be rejected."},{"line_number":107,"context_line":"* The top-level domain, what comes afer the last period, must be letters of the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bd297d8a_97e9f420","line":104,"range":{"start_line":104,"start_character":22,"end_line":104,"end_character":29},"in_reply_to":"ccd0d9fc_60aecd5a","updated":"2022-07-14 18:06:11.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbd94a163464060b77b42ced94f2a9b8eac5b3fd","unresolved":true,"context_lines":[{"line_number":104,"context_line":"  1 character for the perdiod (``.``) to join them."},{"line_number":105,"context_line":"* It must consist of alphanumeric characters, dashes (``-``) and at least one"},{"line_number":106,"context_line":"  or more periods (``.``).  Characters outside this set will be rejected."},{"line_number":107,"context_line":"* The top-level domain, what comes afer the last period, must be letters of the"},{"line_number":108,"context_line":"  latin alphabet."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"A request for booting multiple instances with the same ``domain`` results in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4748a7e9_3bdc26fc","line":107,"range":{"start_line":107,"start_character":35,"end_line":107,"end_character":39},"updated":"2022-07-14 12:52:27.000000000","message":"nit: after","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c052bfc4eb381f110ce6cc86d2d4b0bcf1367e3a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  1 character for the perdiod (``.``) to join them."},{"line_number":105,"context_line":"* It must consist of alphanumeric characters, dashes (``-``) and at least one"},{"line_number":106,"context_line":"  or more periods (``.``).  Characters outside this set will be rejected."},{"line_number":107,"context_line":"* The top-level domain, what comes afer the last period, must be letters of the"},{"line_number":108,"context_line":"  latin alphabet."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"A request for booting multiple instances with the same ``domain`` results in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e1785936_95f0b53c","line":107,"range":{"start_line":107,"start_character":35,"end_line":107,"end_character":39},"in_reply_to":"4748a7e9_3bdc26fc","updated":"2022-07-14 18:06:11.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1ec2211ef259e555b7ef412a8190d0cdc5d228a2","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  1 character for the perdiod (``.``) to join them."},{"line_number":105,"context_line":"* It must consist of alphanumeric characters, dashes (``-``) and at least one"},{"line_number":106,"context_line":"  or more periods (``.``).  Characters outside this set will be rejected."},{"line_number":107,"context_line":"* The top-level domain, what comes afer the last period, must be letters of the"},{"line_number":108,"context_line":"  latin alphabet."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"A request for booting multiple instances with the same ``domain`` results in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e69d5953_0d38c587","line":107,"range":{"start_line":107,"start_character":35,"end_line":107,"end_character":39},"in_reply_to":"4748a7e9_3bdc26fc","updated":"2022-07-14 18:09:08.000000000","message":"Done","commit_id":"d8985d8bcf26cfca02da67bed50732a29f016d52"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0caff0064d934107d0fd75b570808fd2d58910e4","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Configurable instance domains"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/configurable-instance-domains"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Currently, there is no way for a user booting an instance to tell the"},{"line_number":14,"context_line":"instance\u0027s guest operating system what is the domain name of the instance."}],"source_content_type":"text/x-rst","patch_set":3,"id":"908945c9_51baf158","line":11,"updated":"2022-07-18 14:56:36.000000000","message":"this link gives me 404, please correct it ASAP so I could add the BP to the Zed cycle.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"772072b144362f59fab63c063f91b146fa8f1e91","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Configurable instance domains"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/configurable-instance-domains"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Currently, there is no way for a user booting an instance to tell the"},{"line_number":14,"context_line":"instance\u0027s guest operating system what is the domain name of the instance."}],"source_content_type":"text/x-rst","patch_set":3,"id":"4e4ba156_63e7b19a","line":11,"in_reply_to":"908945c9_51baf158","updated":"2022-07-18 17:07:11.000000000","message":"Done","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"10b08bb67acee2ef97eee9908efbf12c6581b19e","unresolved":true,"context_lines":[{"line_number":54,"context_line":"Proposed change"},{"line_number":55,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"A new ``Instance.domain`` object field is introduced, with its corresponding"},{"line_number":58,"context_line":"database migration. The value for this field is obtained from a new ``domain``"},{"line_number":59,"context_line":"API attribute. This attribute is added in a new microversion to the create"},{"line_number":60,"context_line":"server(s) (``POST /servers``) and update server (``PUT /servers/{id}``) APIs."}],"source_content_type":"text/x-rst","patch_set":3,"id":"eea2ad7d_45a076d2","line":57,"range":{"start_line":57,"start_character":17,"end_line":57,"end_character":23},"updated":"2022-07-14 18:50:27.000000000","message":"I\u0027m wondering is there a reason not to keep parity with the neutron name here, \u0027dns_domain\u0027? I ask because \"domain\" by itself is a pretty broad term and TBH when I hear it I think of libvirt domain or keystone domain before network domain. Just a thought.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"da1a583dff38fad1000bd65e4241b131143a7b50","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Proposed change"},{"line_number":55,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"A new ``Instance.domain`` object field is introduced, with its corresponding"},{"line_number":58,"context_line":"database migration. The value for this field is obtained from a new ``domain``"},{"line_number":59,"context_line":"API attribute. This attribute is added in a new microversion to the create"},{"line_number":60,"context_line":"server(s) (``POST /servers``) and update server (``PUT /servers/{id}``) APIs."}],"source_content_type":"text/x-rst","patch_set":3,"id":"0c406fa3_8b6452be","line":57,"in_reply_to":"0b1d2a70_64cca9e1","updated":"2022-07-14 21:11:23.000000000","message":"We definitely need to get it right the first time, so let\u0027s figure it out at implementation time.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e3cae69a62737b1586ffa88d80adb1c9b7f3909c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Proposed change"},{"line_number":55,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"A new ``Instance.domain`` object field is introduced, with its corresponding"},{"line_number":58,"context_line":"database migration. The value for this field is obtained from a new ``domain``"},{"line_number":59,"context_line":"API attribute. This attribute is added in a new microversion to the create"},{"line_number":60,"context_line":"server(s) (``POST /servers``) and update server (``PUT /servers/{id}``) APIs."}],"source_content_type":"text/x-rst","patch_set":3,"id":"4f2f6bb9_9480d7ca","line":57,"range":{"start_line":57,"start_character":17,"end_line":57,"end_character":23},"in_reply_to":"0c406fa3_8b6452be","updated":"2022-07-14 23:21:51.000000000","message":"\u003e We definitely need to get it right the first time, so let\u0027s figure it out at implementation time.\n\n+1","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"de9432d5211d136e9479950e973d1b149d0275dc","unresolved":true,"context_lines":[{"line_number":54,"context_line":"Proposed change"},{"line_number":55,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"A new ``Instance.domain`` object field is introduced, with its corresponding"},{"line_number":58,"context_line":"database migration. The value for this field is obtained from a new ``domain``"},{"line_number":59,"context_line":"API attribute. This attribute is added in a new microversion to the create"},{"line_number":60,"context_line":"server(s) (``POST /servers``) and update server (``PUT /servers/{id}``) APIs."}],"source_content_type":"text/x-rst","patch_set":3,"id":"8a24216e_efe426b0","line":57,"range":{"start_line":57,"start_character":17,"end_line":57,"end_character":23},"in_reply_to":"1e7acb50_ec4d98fe","updated":"2022-07-18 22:56:25.000000000","message":"i dont know why this was set to resolved so opening it agin","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e53e6bed3dd64c19c8ffe86ce1f189a84352d030","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Proposed change"},{"line_number":55,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"A new ``Instance.domain`` object field is introduced, with its corresponding"},{"line_number":58,"context_line":"database migration. The value for this field is obtained from a new ``domain``"},{"line_number":59,"context_line":"API attribute. This attribute is added in a new microversion to the create"},{"line_number":60,"context_line":"server(s) (``POST /servers``) and update server (``PUT /servers/{id}``) APIs."}],"source_content_type":"text/x-rst","patch_set":3,"id":"81711b44_2b96dc70","line":57,"range":{"start_line":57,"start_character":17,"end_line":57,"end_character":23},"in_reply_to":"4f2f6bb9_9480d7ca","updated":"2022-07-15 10:00:16.000000000","message":"well on the keystone issue we could have\n\nInstance.domain_id for keystone to kee it consitent with project_id\n\ni never think about kestone when i think domain i either think dns or libvirt.\nso\n\n\n Instance.project_id (keystone project)\n Instance.user_id (keystone user)\n Instance.domain_id (keystone domain)\n Instance.domain ( dns_domain)\n\nbut sure im fine with revisiting this in the impelmeatnion and then updating the spec to refectl that but i prefer Instance.domain  and Instance.hostname","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"62f59324b28358bb06495e6c78dc515bf4c70cb1","unresolved":true,"context_lines":[{"line_number":54,"context_line":"Proposed change"},{"line_number":55,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"A new ``Instance.domain`` object field is introduced, with its corresponding"},{"line_number":58,"context_line":"database migration. The value for this field is obtained from a new ``domain``"},{"line_number":59,"context_line":"API attribute. This attribute is added in a new microversion to the create"},{"line_number":60,"context_line":"server(s) (``POST /servers``) and update server (``PUT /servers/{id}``) APIs."}],"source_content_type":"text/x-rst","patch_set":3,"id":"0b1d2a70_64cca9e1","line":57,"range":{"start_line":57,"start_character":17,"end_line":57,"end_character":23},"in_reply_to":"5abbe4d7_972d3263","updated":"2022-07-14 20:31:07.000000000","message":"I think hostname is clear though, I can\u0027t think of what other things hostname could mean. I was thinking about how the word domain doesn\u0027t have any context in it, IMO.\n\n Instance.project_id (keystone project)\n Instance.user_id (keystone user)\n Instance.domain (not keystone domain)\n\nAt the same time, it doesn\u0027t feel like there is an obvious slam dunk word that ties to hostname. dns_domain? network_domain? hostdomain? I dunno.\n\nI don\u0027t want it to sound like I\u0027m making a big deal out of this but it\u0027s just like, once we add the field, it\u0027s forever. So that makes me think more about it.\n\nIf most prefer just domain, I won\u0027t complain about it 😊","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"772072b144362f59fab63c063f91b146fa8f1e91","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Proposed change"},{"line_number":55,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"A new ``Instance.domain`` object field is introduced, with its corresponding"},{"line_number":58,"context_line":"database migration. The value for this field is obtained from a new ``domain``"},{"line_number":59,"context_line":"API attribute. This attribute is added in a new microversion to the create"},{"line_number":60,"context_line":"server(s) (``POST /servers``) and update server (``PUT /servers/{id}``) APIs."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1e7acb50_ec4d98fe","line":57,"range":{"start_line":57,"start_character":17,"end_line":57,"end_character":23},"in_reply_to":"7e989bb3_9ac63d62","updated":"2022-07-18 17:07:11.000000000","message":"i suggested using the instance_system_metadata to avoid the migration in v1\n\nhttps://review.opendev.org/c/openstack/nova-specs/+/849765/1..3/specs/zed/approved/configurable-instance-domains.rst#b77\u003d\n\ni dont really think that we need a new column in the instance table for this.\n\nim not a fan of using dns_domain since it feel clunky to me to prefix or suffix this but if we do not update hostname i can live it.\n\ni understand that domain is an overloaded term but i would expect it to not have a prefix if i was using it as a user.\n\nthe fact that domain is what libvirt/xen calls the description of the instance might be confusing to operators yes, but the name of the libvirt/xen domain is actully stored in OS-EXT-SRV-ATTR:instance_name so i would hope that since that feild is already used for that reason we would not need to disambiguate.\n\ni see that most disagree so i guess we can go with dns_name unless tehre is another name people would prefer.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e92609af88fb85a43355088c274458dd4dedca06","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Proposed change"},{"line_number":55,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"A new ``Instance.domain`` object field is introduced, with its corresponding"},{"line_number":58,"context_line":"database migration. The value for this field is obtained from a new ``domain``"},{"line_number":59,"context_line":"API attribute. This attribute is added in a new microversion to the create"},{"line_number":60,"context_line":"server(s) (``POST /servers``) and update server (``PUT /servers/{id}``) APIs."}],"source_content_type":"text/x-rst","patch_set":3,"id":"8d590fc6_d67352a4","line":57,"range":{"start_line":57,"start_character":17,"end_line":57,"end_character":23},"in_reply_to":"81711b44_2b96dc70","updated":"2022-07-18 14:47:30.000000000","message":"Do we even need this to be a column in the database? If we\u0027re just storing something the user gave us to barf back up for them later (via metadata), then this could be in sysmeta without the migration and object mutation. We only need it as a column if we want to query and filter based on that value.\n\nAlso, I agree with melanie that \"domain\" is far too generic of a term for this. Xen (and this libvirt) actually call the instances themselves \"domains\" even. We should qualify this to indicate its relation to the DNS system.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0caff0064d934107d0fd75b570808fd2d58910e4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Proposed change"},{"line_number":55,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"A new ``Instance.domain`` object field is introduced, with its corresponding"},{"line_number":58,"context_line":"database migration. The value for this field is obtained from a new ``domain``"},{"line_number":59,"context_line":"API attribute. This attribute is added in a new microversion to the create"},{"line_number":60,"context_line":"server(s) (``POST /servers``) and update server (``PUT /servers/{id}``) APIs."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7e989bb3_9ac63d62","line":57,"range":{"start_line":57,"start_character":17,"end_line":57,"end_character":23},"in_reply_to":"8d590fc6_d67352a4","updated":"2022-07-18 14:56:36.000000000","message":"I do share same concern. \u0027Domain\u0027 seems too broad.\n\nThis *has* to be either \"domain_name\" or \"dns_domain\" to qualify what we speak...\n\nAnd then goes my other concern, below L73.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e04104a2a1697efd1e2d372450f9b57bb2fe4d80","unresolved":true,"context_lines":[{"line_number":54,"context_line":"Proposed change"},{"line_number":55,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"A new ``Instance.domain`` object field is introduced, with its corresponding"},{"line_number":58,"context_line":"database migration. The value for this field is obtained from a new ``domain``"},{"line_number":59,"context_line":"API attribute. This attribute is added in a new microversion to the create"},{"line_number":60,"context_line":"server(s) (``POST /servers``) and update server (``PUT /servers/{id}``) APIs."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5abbe4d7_972d3263","line":57,"range":{"start_line":57,"start_character":17,"end_line":57,"end_character":23},"in_reply_to":"eea2ad7d_45a076d2","updated":"2022-07-14 19:31:22.000000000","message":"Yeah... Stephen\u0027s spec used ``hostname`` for Neutron\u0027s ``dns_name``, though I guess we already had that in the DB since forever. I\u0027m torn between staying consistent with Neutron\u0027s ``dns_domain``and Nova\u0027s more barebones ``hostname``-style naming. I suppose internal consistency is better than external consistency?","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0caff0064d934107d0fd75b570808fd2d58910e4","unresolved":true,"context_lines":[{"line_number":66,"context_line":"the metadata API will continue to fallback on ``[api]dhcp_domain`` like it"},{"line_number":67,"context_line":"currently does."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"For ports auto-created by Nova, the port\u0027s ``dns_domain`` value will be kept in"},{"line_number":70,"context_line":"sync with the ``Instance.domain`` value. For other ports attached to instances,"},{"line_number":71,"context_line":"the port\u0027s ``dns_domain`` value will not be touched, and ``Instance.domain``"},{"line_number":72,"context_line":"will take prededence over the port\u0027s ``dns_domain``. Nova will never touch a"},{"line_number":73,"context_line":"network\u0027s ``dns_domain`` value."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Alternatives"},{"line_number":76,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ed196624_1c1040b8","line":73,"range":{"start_line":69,"start_character":0,"end_line":73,"end_character":31},"updated":"2022-07-18 14:56:36.000000000","message":"Honestly, I feel this being very confusing for our endusers.\nLet me clarify : \n - user didn\u0027t specify it, we use dns_domain\n - user did specify another domain, we gonna take over Neutron and send thru metadata a distinct value\n \nFrom a metadata API client perspective running as a application, it will be hard to know then why it would see a discrepancy with no indication how the attribute was set.\n\nDo we also want to take care of fat fingering ? Are users be able to know whether dns_domain is already good for their usage and not requiring them to fill the domain by an instance parameter ?","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7abcae630f825ef237afcf0cbf140e706476ad2d","unresolved":true,"context_lines":[{"line_number":66,"context_line":"the metadata API will continue to fallback on ``[api]dhcp_domain`` like it"},{"line_number":67,"context_line":"currently does."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"For ports auto-created by Nova, the port\u0027s ``dns_domain`` value will be kept in"},{"line_number":70,"context_line":"sync with the ``Instance.domain`` value. For other ports attached to instances,"},{"line_number":71,"context_line":"the port\u0027s ``dns_domain`` value will not be touched, and ``Instance.domain``"},{"line_number":72,"context_line":"will take prededence over the port\u0027s ``dns_domain``. Nova will never touch a"},{"line_number":73,"context_line":"network\u0027s ``dns_domain`` value."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Alternatives"},{"line_number":76,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"922730e0_d0af1719","line":73,"range":{"start_line":69,"start_character":0,"end_line":73,"end_character":31},"in_reply_to":"5d3d5bae_cf483b5a","updated":"2022-07-18 17:31:33.000000000","message":"\u003e in general the dns_domain is set by the user on the network or port so they should know if that is sufficient. with default policy it is discoverable by the user provided the cloud exposes the neutron api.\n\nIsn\u0027t this the exact reason why we shouldn\u0027t be taking this as a bare string in nova? Let me write the counter user story for this:\n\n Why (the heck) do I have to tell the network what my domain name is, and then\n when I wire up an instance...tell it again?\n \nIs the domain name mutable on the network? If so, surely the user is going to expect that they could change the domain name on the network and see that reflected on all related instances after a reboot right?","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"de9432d5211d136e9479950e973d1b149d0275dc","unresolved":true,"context_lines":[{"line_number":66,"context_line":"the metadata API will continue to fallback on ``[api]dhcp_domain`` like it"},{"line_number":67,"context_line":"currently does."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"For ports auto-created by Nova, the port\u0027s ``dns_domain`` value will be kept in"},{"line_number":70,"context_line":"sync with the ``Instance.domain`` value. For other ports attached to instances,"},{"line_number":71,"context_line":"the port\u0027s ``dns_domain`` value will not be touched, and ``Instance.domain``"},{"line_number":72,"context_line":"will take prededence over the port\u0027s ``dns_domain``. Nova will never touch a"},{"line_number":73,"context_line":"network\u0027s ``dns_domain`` value."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Alternatives"},{"line_number":76,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"e31a77d3_832d9af1","line":73,"range":{"start_line":69,"start_character":0,"end_line":73,"end_character":31},"in_reply_to":"922730e0_d0af1719","updated":"2022-07-18 22:56:25.000000000","message":"i belvie its mutable on thet network but changing it on the network will not propagate to ports.\n\nthe network value is only the inital value that is uses to set it on the port if not set. so if you change it on the netowrk it would not propagate on a reboot.\n\nthe domain is really assocated with the port or more specifically the ips on the port.\n\nthe dns-integration extention orgianlly added the dns_name and dns_domain attributes to floating IP  https://docs.openstack.org/api-ref/network/v2/index.html#id161 the the dns-integration extention also adds the dns_name and dns_assignment as attributes to port resources where dns_assignment is read-only and shows the hostname, ip_address and fqdn for the port’s internal DNS assignment\nhttps://docs.openstack.org/api-ref/network/v2/index.html#id52\nthe dns-domain-ports extention add a the ablity to over ride the network dns_domain on the port level.\n\nfinaanlly  on the network level the  dns-integration extention adds a dns_domain atibute which is only used when using designate and is used to sepcficy the default domain for a neutron port https://docs.openstack.org/api-ref/network/v2/index.html#dns-integration\n\nthe documentation for this is not the clearerst\n\nhttps://docs.openstack.org/neutron/latest/admin/config-dns-int.html\nis the introductory doc and \nhttps://docs.openstack.org/neutron/latest/admin/config-dns-int-ext-serv.html#the-port-s-dns-assignment-attribute-with-use-case-3\n\ndescribe how the confgi value for the domain can be overriden on the port or network. \n\nas descibed in https://docs.openstack.org/neutron/latest/admin/config-dns-int-ext-serv.html#use-case-3b-the-dns-domain-ports-extension\n\nopenstack port create --network 37aaff3a-6047-45ac-bf4f-a825e56fd2b3 --dns-name my-vm --dns-domain port-domain.org. test\n\nor \n\nhttps://docs.openstack.org/neutron/latest/admin/config-dns-int-ext-serv.html#use-case-3c-the-dns-extension\nopenstack network set --dns-domain example.org. 37aaff3a-6047-45ac-bf4f-a825e56fd2b3\n\nif you set the doamin on the netowrk and later change it it will only update new port that are created so it wont have the behaiour you were expecting.\n\nupdating the domain_name on the port would take effect asyncosly and woudl not really requrie a reboot since we dont currntly storate that info anywhere in nova\noutside of perhaps the network info cache but i am not sure its there today.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"772072b144362f59fab63c063f91b146fa8f1e91","unresolved":true,"context_lines":[{"line_number":66,"context_line":"the metadata API will continue to fallback on ``[api]dhcp_domain`` like it"},{"line_number":67,"context_line":"currently does."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"For ports auto-created by Nova, the port\u0027s ``dns_domain`` value will be kept in"},{"line_number":70,"context_line":"sync with the ``Instance.domain`` value. For other ports attached to instances,"},{"line_number":71,"context_line":"the port\u0027s ``dns_domain`` value will not be touched, and ``Instance.domain``"},{"line_number":72,"context_line":"will take prededence over the port\u0027s ``dns_domain``. Nova will never touch a"},{"line_number":73,"context_line":"network\u0027s ``dns_domain`` value."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Alternatives"},{"line_number":76,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5d3d5bae_cf483b5a","line":73,"range":{"start_line":69,"start_character":0,"end_line":73,"end_character":31},"in_reply_to":"ed196624_1c1040b8","updated":"2022-07-18 17:07:11.000000000","message":"if the user did not specify it then the value woudl be null/None in our db.\nwith this curren proposal we never read values form neutron.\n\nso there will be no change from today if the request does not include the new value.\n\nin general the dns_domain is set by the user on the network or port so they should know if that is sufficient. with default policy it is discoverable by the user provided the cloud exposes the neutron api.\nif the cloud does not then the only way to discover this today is look at the dhcp response.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6efcb1a1bc7a8e6054c56cc3a0b5f17026926b20","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"A request for booting multiple instances with the same ``domain`` results in"},{"line_number":107,"context_line":"all the instances receiving that ``domain`` (unlike the display name and"},{"line_number":108,"context_line":"hostname, which use an autoincrementing suffix)."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"A new ``domain`` attribute is displayed when listing detailed server (``GET"},{"line_number":111,"context_line":"/servers/detail``) and showing server details (``GET /servers/{id}``). This"}],"source_content_type":"text/x-rst","patch_set":3,"id":"a0f37f93_2ec6d836","line":108,"updated":"2022-07-14 18:13:23.000000000","message":"nice i did not think about this but this is the correct behaivor\n+1","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0cb9d818826399e16dd6d94c44d5079eed69caa8","unresolved":true,"context_lines":[{"line_number":110,"context_line":"A new ``domain`` attribute is displayed when listing detailed server (``GET"},{"line_number":111,"context_line":"/servers/detail``) and showing server details (``GET /servers/{id}``). This"},{"line_number":112,"context_line":"attribute is optional, and is only displayed if the server has a ``domain``"},{"line_number":113,"context_line":"(either from creation, or set afterwards with an update)."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Security impact"},{"line_number":116,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1efc9717_8619015c","line":113,"updated":"2022-07-18 14:48:04.000000000","message":"I don\u0027t see default policies for those new attributes. Please amend the spec about it.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"772072b144362f59fab63c063f91b146fa8f1e91","unresolved":true,"context_lines":[{"line_number":110,"context_line":"A new ``domain`` attribute is displayed when listing detailed server (``GET"},{"line_number":111,"context_line":"/servers/detail``) and showing server details (``GET /servers/{id}``). This"},{"line_number":112,"context_line":"attribute is optional, and is only displayed if the server has a ``domain``"},{"line_number":113,"context_line":"(either from creation, or set afterwards with an update)."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Security impact"},{"line_number":116,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c397d4c7_8c7e2717","line":113,"in_reply_to":"1efc9717_8619015c","updated":"2022-07-18 17:07:11.000000000","message":"the should require project_reader for read only access and project_member for update\n\ni will note that the exact policies were not specified in \n\nhttps://specs.openstack.org/openstack/nova-specs/specs/xena/implemented/configurable-instance-hostnames.html#rest-api-impact\n\neither other then the refernce that \"The OS-EXT-SRV-ATTR:hostname instance attribute, which is currently admin-only, will now be accessible by non-admin users.\"\n\ni infered that the intent that this was a normal user readable/writeable field was captured in teh usecase\n\"\"\"As a user, I want to pass my instance\u0027s domain name to the guest operating\nsystem\"\"\"\n\nand was not needed to be explcitly stated here but we can ammend the spec as you said.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6efcb1a1bc7a8e6054c56cc3a0b5f17026926b20","unresolved":true,"context_lines":[{"line_number":120,"context_line":"Notifications impact"},{"line_number":121,"context_line":"--------------------"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"None."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Other end user impact"},{"line_number":126,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"cb94c001_e2fa26c6","line":123,"range":{"start_line":123,"start_character":0,"end_line":123,"end_character":5},"updated":"2022-07-14 18:13:23.000000000","message":"nit the instnace notification object will be updated for the new domain field.\nbut i think its fine. it wont actully change notificaiton other then the trivial mechinaical version change that happens because we extend the internal nova object.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2fb41dbf9f6c4d65874452364ccdefbec79bc4c3","unresolved":true,"context_lines":[{"line_number":120,"context_line":"Notifications impact"},{"line_number":121,"context_line":"--------------------"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"None."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Other end user impact"},{"line_number":126,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"faca1300_10a2d102","line":123,"range":{"start_line":123,"start_character":0,"end_line":123,"end_character":5},"in_reply_to":"cb94c001_e2fa26c6","updated":"2022-07-14 18:22:07.000000000","message":"You have to explicitly map the new Instance.domain field to InstancePayload.domain to expose the new field in the notification.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e92609af88fb85a43355088c274458dd4dedca06","unresolved":true,"context_lines":[{"line_number":148,"context_line":"The new ``Instance.domain`` field and associated database column is optional,"},{"line_number":149,"context_line":"so existing instances are not affected. If no ``Instance.domain`` is set, Nova"},{"line_number":150,"context_line":"will continue to default to ``[api] dhcp_domain`` like it currently does when"},{"line_number":151,"context_line":"generating the metadata."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Implementation"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3eb6dcbb_52dd9fd3","line":151,"updated":"2022-07-18 14:47:30.000000000","message":"But, if your computes are not all updated when a new boot request comes in that asks for a domain, the value will be ignored. Are you going to restrict usage of this field to fully-updated deployments?","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"772072b144362f59fab63c063f91b146fa8f1e91","unresolved":true,"context_lines":[{"line_number":148,"context_line":"The new ``Instance.domain`` field and associated database column is optional,"},{"line_number":149,"context_line":"so existing instances are not affected. If no ``Instance.domain`` is set, Nova"},{"line_number":150,"context_line":"will continue to default to ``[api] dhcp_domain`` like it currently does when"},{"line_number":151,"context_line":"generating the metadata."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Implementation"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c65d0305_2201a3a6","line":151,"in_reply_to":"3acddad3_f691ca44","updated":"2022-07-18 17:07:11.000000000","message":"in terms of rooling upgrade support we have two options\n1 do min compute service version check in the api and reject if not met, this would be my perference \n2 allow the boot to proceed storing the value so that the instance metadata will evenutally be correct.\n\nthis really only matters for instances that are booted with config drive.\nif you get metadta form the api then once the api is updates all host will be able to get the new values.\n\nlooking at https://specs.openstack.org/openstack/nova-specs/specs/xena/implemented/configurable-instance-hostnames.html#upgrade-impact\n\nit did not adress this edgecase presumable because the field was already present in the db and we were jut allowing the api to update the value instead of derivering it form the displayname.\n\nin the absence of config drive domain will function the same as hostname did so we need to call that delta out in the upgrade section of the release notes.\n\nso that leave the question do we take appoch 1 and do a min compute service version check and only allow this if all hosts are updated or take approch 2 and document that until the cloud is fully updated new instance that use config drive will have the old behavior if they land on non upgraded hosts.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0caff0064d934107d0fd75b570808fd2d58910e4","unresolved":true,"context_lines":[{"line_number":148,"context_line":"The new ``Instance.domain`` field and associated database column is optional,"},{"line_number":149,"context_line":"so existing instances are not affected. If no ``Instance.domain`` is set, Nova"},{"line_number":150,"context_line":"will continue to default to ``[api] dhcp_domain`` like it currently does when"},{"line_number":151,"context_line":"generating the metadata."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Implementation"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3acddad3_f691ca44","line":151,"in_reply_to":"3eb6dcbb_52dd9fd3","updated":"2022-07-18 14:56:36.000000000","message":"Yup, I was about to write a comment on it, we need to tell what to do with old computes that aren\u0027t upgraded yet.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7abcae630f825ef237afcf0cbf140e706476ad2d","unresolved":true,"context_lines":[{"line_number":148,"context_line":"The new ``Instance.domain`` field and associated database column is optional,"},{"line_number":149,"context_line":"so existing instances are not affected. If no ``Instance.domain`` is set, Nova"},{"line_number":150,"context_line":"will continue to default to ``[api] dhcp_domain`` like it currently does when"},{"line_number":151,"context_line":"generating the metadata."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Implementation"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d2eeece2_f609a7e6","line":151,"in_reply_to":"c65d0305_2201a3a6","updated":"2022-07-18 17:31:33.000000000","message":"Right, the configdrive question is why it matters and why it should be spelled out here what the plan is.","commit_id":"35aaec78108fabd1961274250a8fa460abed6f90"}]}