)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3d6490aa7eb6c306b315663e93fca0ff7e0244f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"79ceef2c_533e4d95","updated":"2022-10-19 11:30:40.000000000","message":"some minor nits but i think this is a good update of the zed spec","commit_id":"2c949acad7658f5cc678abde48b0bc4c3b73e26f"}],"specs/zed/approved/pci-device-tracking-in-placement.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5c4d468fd29123784853577acac1d42361ac0dd7","unresolved":true,"context_lines":[{"line_number":357,"context_line":"will not change. Also, Nova will continue using the ``InstancePCIRequest`` to"},{"line_number":358,"context_line":"track the requested PCI devices for a VM."},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"Scheduling"},{"line_number":361,"context_line":"----------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"The ``RequestSpec`` creation logic is extended to translate"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8a2e6ac1_3d06e0db","line":360,"updated":"2022-09-01 08:23:45.000000000","message":"as I see we will not merge the scheduling part so I will add a note here","commit_id":"9778c712248b79d94a23eba1a71fe0e1fc3b9969"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8225f35a712deac5d8db2a3ab4beb49eb9632796","unresolved":false,"context_lines":[{"line_number":357,"context_line":"will not change. Also, Nova will continue using the ``InstancePCIRequest`` to"},{"line_number":358,"context_line":"track the requested PCI devices for a VM."},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"Scheduling"},{"line_number":361,"context_line":"----------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"The ``RequestSpec`` creation logic is extended to translate"}],"source_content_type":"text/x-rst","patch_set":1,"id":"aca1c55f_d509afee","line":360,"in_reply_to":"8a2e6ac1_3d06e0db","updated":"2022-09-02 12:46:37.000000000","message":"Done","commit_id":"9778c712248b79d94a23eba1a71fe0e1fc3b9969"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"71a370dd994d48025a87bc0b2f8ca19db395eb85","unresolved":true,"context_lines":[{"line_number":274,"context_line":"  ``[pci]device_spec`` configuration manually."},{"line_number":275,"context_line":""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"Reporting inventories from the ResourceTracker to Placement"},{"line_number":278,"context_line":"-----------------------------------------------------------"},{"line_number":279,"context_line":"The ResourceTracker and the PciDevTracker implements a virt driver agnostic"},{"line_number":280,"context_line":"PCI device inventory and allocation handling. This logic is extended to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"32d8b8af_1611788c","line":277,"updated":"2022-09-02 14:08:16.000000000","message":"this is the main change that happned.","commit_id":"55bdb12657149ea04f0e526cdc03a8b92cdd77de"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b20194bade6711e866d0721761554876d83bfee4","unresolved":false,"context_lines":[{"line_number":274,"context_line":"  ``[pci]device_spec`` configuration manually."},{"line_number":275,"context_line":""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"Reporting inventories from the ResourceTracker to Placement"},{"line_number":278,"context_line":"-----------------------------------------------------------"},{"line_number":279,"context_line":"The ResourceTracker and the PciDevTracker implements a virt driver agnostic"},{"line_number":280,"context_line":"PCI device inventory and allocation handling. This logic is extended to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"db955672_af32d6a4","line":277,"in_reply_to":"32d8b8af_1611788c","updated":"2022-10-17 11:51:18.000000000","message":"Ack","commit_id":"55bdb12657149ea04f0e526cdc03a8b92cdd77de"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"71a370dd994d48025a87bc0b2f8ca19db395eb85","unresolved":true,"context_lines":[{"line_number":282,"context_line":"PciDeviceSpec objects to Placement resource providers, resource inventories,"},{"line_number":283,"context_line":"and traits."},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"This new translator logic also capable of healing missing PCI resource"},{"line_number":286,"context_line":"allocations of existing instances based on the ``instance_uuid`` field of the"},{"line_number":287,"context_line":"allocated PciDevice objects. The missing allocations will be created in"},{"line_number":288,"context_line":"Placement via the ``/reshape`` API."}],"source_content_type":"text/x-rst","patch_set":2,"id":"2e1a1dc0_e49d66ea","line":285,"range":{"start_line":285,"start_character":26,"end_line":285,"end_character":30},"updated":"2022-09-02 14:08:16.000000000","message":"nit: is also","commit_id":"55bdb12657149ea04f0e526cdc03a8b92cdd77de"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b20194bade6711e866d0721761554876d83bfee4","unresolved":false,"context_lines":[{"line_number":282,"context_line":"PciDeviceSpec objects to Placement resource providers, resource inventories,"},{"line_number":283,"context_line":"and traits."},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"This new translator logic also capable of healing missing PCI resource"},{"line_number":286,"context_line":"allocations of existing instances based on the ``instance_uuid`` field of the"},{"line_number":287,"context_line":"allocated PciDevice objects. The missing allocations will be created in"},{"line_number":288,"context_line":"Placement via the ``/reshape`` API."}],"source_content_type":"text/x-rst","patch_set":2,"id":"d73fed31_28f792c2","line":285,"range":{"start_line":285,"start_character":26,"end_line":285,"end_character":30},"in_reply_to":"2e1a1dc0_e49d66ea","updated":"2022-10-17 11:51:18.000000000","message":"Done","commit_id":"55bdb12657149ea04f0e526cdc03a8b92cdd77de"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"71a370dd994d48025a87bc0b2f8ca19db395eb85","unresolved":true,"context_lines":[{"line_number":361,"context_line":"----------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":".. important::"},{"line_number":364,"context_line":"   The implementation of the scheduling support is missed the deadline and"},{"line_number":365,"context_line":"   therefore not part of the Zed release."},{"line_number":366,"context_line":""},{"line_number":367,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"4ba9d293_0de7df24","line":364,"range":{"start_line":364,"start_character":48,"end_line":364,"end_character":50},"updated":"2022-09-02 14:08:16.000000000","message":"has","commit_id":"55bdb12657149ea04f0e526cdc03a8b92cdd77de"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b20194bade6711e866d0721761554876d83bfee4","unresolved":false,"context_lines":[{"line_number":361,"context_line":"----------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":".. important::"},{"line_number":364,"context_line":"   The implementation of the scheduling support is missed the deadline and"},{"line_number":365,"context_line":"   therefore not part of the Zed release."},{"line_number":366,"context_line":""},{"line_number":367,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bc82387e_1717e530","line":364,"range":{"start_line":364,"start_character":48,"end_line":364,"end_character":50},"in_reply_to":"4ba9d293_0de7df24","updated":"2022-10-17 11:51:18.000000000","message":"Done","commit_id":"55bdb12657149ea04f0e526cdc03a8b92cdd77de"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3d6490aa7eb6c306b315663e93fca0ff7e0244f","unresolved":true,"context_lines":[{"line_number":623,"context_line":"The introduction of new PCI ``RequestGroup`` objects will make the computation"},{"line_number":624,"context_line":"of the placement query slightly longer and the resulting execution time may"},{"line_number":625,"context_line":"increase for instances with PCI requests but should have no effect for"},{"line_number":626,"context_line":"instances without PCI requests. This added complexity is expected to be offset"},{"line_number":627,"context_line":"the result of the offloading of the filtering to Placement and the removal of"},{"line_number":628,"context_line":"reschedules due to racing for the last PCI device on a host, the overall"},{"line_number":629,"context_line":"performance is expected to improve."},{"line_number":630,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7e2a1774_e50b91fe","line":627,"range":{"start_line":626,"start_character":66,"end_line":627,"end_character":28},"updated":"2022-10-19 11:30:40.000000000","message":"nit: to be offset by ...","commit_id":"2c949acad7658f5cc678abde48b0bc4c3b73e26f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3d6490aa7eb6c306b315663e93fca0ff7e0244f","unresolved":true,"context_lines":[{"line_number":625,"context_line":"increase for instances with PCI requests but should have no effect for"},{"line_number":626,"context_line":"instances without PCI requests. This added complexity is expected to be offset"},{"line_number":627,"context_line":"the result of the offloading of the filtering to Placement and the removal of"},{"line_number":628,"context_line":"reschedules due to racing for the last PCI device on a host, the overall"},{"line_number":629,"context_line":"performance is expected to improve."},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c57a64cb_8238231f","line":628,"range":{"start_line":628,"start_character":0,"end_line":628,"end_character":11},"updated":"2022-10-19 11:30:40.000000000","message":"nit: technically its a retry since we no longer reschedule but im ok with this i know what you ment.","commit_id":"2c949acad7658f5cc678abde48b0bc4c3b73e26f"}]}