)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3e1b734706e669b1de41399956448a4213216bd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4c6b6d5e_98f20e80","updated":"2022-10-04 07:56:27.000000000","message":"Thanks for all those comments I will get back with an updated version shortly.","commit_id":"f46417c45ff63387996476a6f37f733ce6daa6e8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"43b7b657a8807c49320fdc0732cb6cdffcd4a851","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"21be3ae0_868311b2","updated":"2022-09-15 11:49:43.000000000","message":"overall i understand why you want to do this in general.\nsome minor nits in line once those are adress ill re review and see if we need to add anythign else but i expect this to be a relitivly short spec.","commit_id":"f46417c45ff63387996476a6f37f733ce6daa6e8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cdb3b11b6fa772573270f63ee1fc64b319abc288","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"da4fd870_eea3092a","updated":"2022-10-19 10:50:57.000000000","message":"+1 for now as i want to see if dan is ok with the usecase.\n\non one hand this spec feels pretty light on content\non the other the change is relitivly simple and im not sure what elase i would like to see included.\n\nwe coudl list the rpc interfaces to be extended with the target state filed but im not sure that adds a lot of value to the spec. we are just adding an enum field to the exisitng functions.\n\ni have some comment in line that should be adressed in a new revision but directionally im ok with this i think.\n\n","commit_id":"fa65da285ba0aa8941db070cb0837046e1965cf7"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c98f3e903ee1b0bd0a457295d57aced32ecd0c7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ac1800b0_630c96b4","updated":"2022-10-11 07:51:05.000000000","message":"Thanks for your reviews. I have updated the use-case part. Please let me know if that makes better sense now.","commit_id":"fa65da285ba0aa8941db070cb0837046e1965cf7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0bde819ed6b53c3145654f4fa47eb5f60ae5897f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d0d4745e_74575f43","updated":"2022-10-27 09:12:44.000000000","message":"we decided to use 2023.1 as the specs directory for antelope in the ptg can you abandon the previous template patch and rebase/move this patch to master and move the spec to the 2023.1 folder.\notherwise im ok with this as written as its in line whit the ptg disucssion on the topic.","commit_id":"79579e61679b96ce1d1d483cb96630b3ab811c43"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b49cc5a03635bb160114f2b5b098467a4a27b98b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b163ec9c_9b2f8ef4","updated":"2022-10-27 12:21:40.000000000","message":"+1 there are some nits that would be nice to address when you fix the zuul issues","commit_id":"d69926db39bc099d1c74cd2aaf2cc19540da457c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"061c3040042ce4112a035ccc2a39d7e0ceb79841","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b4169cc2_2fff023f","updated":"2022-11-15 12:13:50.000000000","message":"I have couple of small additions and nits.","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"57d4c8da6bc8445f3c4ef47952b611c45ef37feb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f7f8c988_2d194968","updated":"2022-11-15 15:02:51.000000000","message":"dropping +2 based on the feedback form gibi and sylvain","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4e86a94b035e613896d3534efbaa5e66b1537c4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d3c13bdd_7d359c6e","updated":"2022-11-02 12:43:36.000000000","message":"i think this is sufficient and in line with the ptg topic.\nwe could add some more detail but i don\u0027t think we have any outstanding design questions so +2","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6929e51aac9f0cedffb8382cf859bf07f9fed9b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b5e7c5bd_f9fe0c47","updated":"2022-11-29 14:56:44.000000000","message":"Comments are just nits, don\u0027t hold this on my account.","commit_id":"66fe2b62853c5fe77a5c0622939f7c340f9a422e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"17bfab130f9d3af1719db39fddca011c77b23df0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"68075086_c0559b6e","updated":"2022-11-29 19:44:38.000000000","message":"Looks good to me too and I will go ahead and +A given the pile of +2s combined with Dan\u0027s comment not to hold this for the nits he noted.","commit_id":"66fe2b62853c5fe77a5c0622939f7c340f9a422e"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"06f6eb76079934b201150cb761e6023a396cd8be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"8419a13b_7928438e","updated":"2022-11-22 11:15:17.000000000","message":"Looks good.","commit_id":"66fe2b62853c5fe77a5c0622939f7c340f9a422e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ba3d574a6246288407efb40d8ce787d26a01e5ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a8748eaa_b94ed416","updated":"2022-11-21 16:28:33.000000000","message":"Looks good. I held +A to let Dan and Melanie check it as they had comments before. ","commit_id":"66fe2b62853c5fe77a5c0622939f7c340f9a422e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"10816a4f2e54c2f322819b58315bf204f84b77c1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3ef68406_87f9b0fa","updated":"2022-11-30 09:08:23.000000000","message":"Thank you Mel, Dan, for your eyes on it!\n\nI wanted to address last comments from Dan I hope that makes sense :-)\n\nhttps://review.opendev.org/c/openstack/nova-specs/+/866108","commit_id":"66fe2b62853c5fe77a5c0622939f7c340f9a422e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"39b23a8a71349ff19621696aa87416dc5c1a29ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4b20b5c7_be330f00","updated":"2022-11-16 18:00:20.000000000","message":"just added the context i remember hopefully that helps","commit_id":"66fe2b62853c5fe77a5c0622939f7c340f9a422e"}],"specs/2023.1/approved/allowing-target-state-for-evacuate.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b49cc5a03635bb160114f2b5b098467a4a27b98b","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"https://blueprints.launchpad.net/nova/+spec/allowing-target-state-for-evacuate"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In certain circumstances the operator may have desire when evacuating"},{"line_number":13,"context_line":"running instances from a service down to set target state as stop even"},{"line_number":14,"context_line":"if they were considered as running in the source host."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9bf5c9cc_7f8090c9","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":54},"updated":"2022-10-27 12:21:40.000000000","message":"nit: In certain circumstances the operator may desire to evacuating\nrunning instances to stopped state regardless of the current state of\nthe instance.","commit_id":"d69926db39bc099d1c74cd2aaf2cc19540da457c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"38918571a780d4c6df1b34a39c039dfc322f4734","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"https://blueprints.launchpad.net/nova/+spec/allowing-target-state-for-evacuate"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In certain circumstances the operator may have desire when evacuating"},{"line_number":13,"context_line":"running instances from a service down to set target state as stop even"},{"line_number":14,"context_line":"if they were considered as running in the source host."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"d88baf2c_115b59f9","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":54},"in_reply_to":"9bf5c9cc_7f8090c9","updated":"2022-10-31 10:59:39.000000000","message":"Done","commit_id":"d69926db39bc099d1c74cd2aaf2cc19540da457c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b49cc5a03635bb160114f2b5b098467a4a27b98b","unresolved":true,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The current evacuate instance API does not allow operators to set a"},{"line_number":20,"context_line":"desired target state to the evacuated instances. Having them kept"},{"line_number":21,"context_line":"running on destination may create issues especially when they need"},{"line_number":22,"context_line":"valid token to be started."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Use Cases"},{"line_number":25,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"e2bd10a0_d9f560c0","line":22,"range":{"start_line":20,"start_character":49,"end_line":22,"end_character":26},"updated":"2022-10-27 12:21:40.000000000","message":"Restoring the orginal state of the instance when it was active\non the source host may result in issues if the guest required\na valid token to be started or prevent evacuation when using encrypted\nvolumes.","commit_id":"d69926db39bc099d1c74cd2aaf2cc19540da457c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"38918571a780d4c6df1b34a39c039dfc322f4734","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The current evacuate instance API does not allow operators to set a"},{"line_number":20,"context_line":"desired target state to the evacuated instances. Having them kept"},{"line_number":21,"context_line":"running on destination may create issues especially when they need"},{"line_number":22,"context_line":"valid token to be started."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Use Cases"},{"line_number":25,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"496589c8_a6212e34","line":22,"range":{"start_line":20,"start_character":49,"end_line":22,"end_character":26},"in_reply_to":"e2bd10a0_d9f560c0","updated":"2022-10-31 10:59:39.000000000","message":"Done","commit_id":"d69926db39bc099d1c74cd2aaf2cc19540da457c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b49cc5a03635bb160114f2b5b098467a4a27b98b","unresolved":true,"context_lines":[{"line_number":24,"context_line":"Use Cases"},{"line_number":25,"context_line":"---------"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"For some specific use-cases related to security that refer to end"},{"line_number":28,"context_line":"users an operator of a private cloud may have necessity to evacuate"},{"line_number":29,"context_line":"instances to a destination host as stopped even if they were running"},{"line_number":30,"context_line":"on source host, since to be started instances should have valid token"},{"line_number":31,"context_line":"during boot start.  Some public clouds also prefer to evacuate"},{"line_number":32,"context_line":"instances as stopped, like Amazon AWS.  To better manage resources,"},{"line_number":33,"context_line":"private clouds may also prefer to evacuate instances as stopped since"},{"line_number":34,"context_line":"they may not be used anymore but kept active for some reason."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"a92912c4_9cd45776","line":34,"range":{"start_line":27,"start_character":0,"end_line":34,"end_character":61},"updated":"2022-10-27 12:21:40.000000000","message":"this is a little hard to follow\n\nI would rewrite it like this\n\nAs an operator, I would like to be able to evacuate instances to a shut-off state\nbecause my tenant workloads may have specific security requirements, that do not\nallow them to be started by the administrator\n\nAs an operator, I would like to be able to evacuate VMs with encrypted volumes without making the barbican secrete readable by admins and reducing the security.","commit_id":"d69926db39bc099d1c74cd2aaf2cc19540da457c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"38918571a780d4c6df1b34a39c039dfc322f4734","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Use Cases"},{"line_number":25,"context_line":"---------"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"For some specific use-cases related to security that refer to end"},{"line_number":28,"context_line":"users an operator of a private cloud may have necessity to evacuate"},{"line_number":29,"context_line":"instances to a destination host as stopped even if they were running"},{"line_number":30,"context_line":"on source host, since to be started instances should have valid token"},{"line_number":31,"context_line":"during boot start.  Some public clouds also prefer to evacuate"},{"line_number":32,"context_line":"instances as stopped, like Amazon AWS.  To better manage resources,"},{"line_number":33,"context_line":"private clouds may also prefer to evacuate instances as stopped since"},{"line_number":34,"context_line":"they may not be used anymore but kept active for some reason."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"375681b9_8584fd3f","line":34,"range":{"start_line":27,"start_character":0,"end_line":34,"end_character":61},"in_reply_to":"a92912c4_9cd45776","updated":"2022-10-31 10:59:39.000000000","message":"Done","commit_id":"d69926db39bc099d1c74cd2aaf2cc19540da457c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b49cc5a03635bb160114f2b5b098467a4a27b98b","unresolved":true,"context_lines":[{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"#. Start to version 2.94 the API will pass to compute a target_state"},{"line_number":40,"context_line":"   parameter to force the stopped state for evacuated instances. It is"},{"line_number":41,"context_line":"   expected that before 2.94 the behavior stay the same, instances"},{"line_number":42,"context_line":"   with state active or stopped will keep their state at destination."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"},{"line_number":45,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"f86e09c1_06a39ec3","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":69},"updated":"2022-10-27 12:21:40.000000000","message":"As of version 2.94 the API will pass to compute a target_state\nparameter to force the stopped state for evacuated instances. It is\nexpected that before 2.94 the behavior stay the same, instances\nwith state active or stopped will keep their state at destination.\n\n\nyou do not need the #. since there is only one item in the list.\n\nwe im ok with having the micro-version listed but it might need to be changed depending on the order things merge in. if it does you will need ot update the spec after the code merges.","commit_id":"d69926db39bc099d1c74cd2aaf2cc19540da457c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"38918571a780d4c6df1b34a39c039dfc322f4734","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"#. Start to version 2.94 the API will pass to compute a target_state"},{"line_number":40,"context_line":"   parameter to force the stopped state for evacuated instances. It is"},{"line_number":41,"context_line":"   expected that before 2.94 the behavior stay the same, instances"},{"line_number":42,"context_line":"   with state active or stopped will keep their state at destination."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"},{"line_number":45,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"993c7600_5b014d15","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":69},"in_reply_to":"f86e09c1_06a39ec3","updated":"2022-10-31 10:59:39.000000000","message":"Yes right I was not sure about what to do, I will try differently.","commit_id":"d69926db39bc099d1c74cd2aaf2cc19540da457c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b49cc5a03635bb160114f2b5b098467a4a27b98b","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"API will return either an HTTP 400 or 409 if the RCP version is clamp"},{"line_number":74,"context_line":"either manually or automaticaly to the required version for the"},{"line_number":75,"context_line":"targetState paramater."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"66757b26_ba8dbdcf","line":73,"range":{"start_line":73,"start_character":26,"end_line":73,"end_character":42},"updated":"2022-10-27 12:21:40.000000000","message":"when I said \"HTTP 400 or 409\" I originally meant you shoudl chose one or the other\nI think 409 is the more correct choice since the request body/micorverions is correct but the host the vm is on is not capably of processing it.\n\neither woudl be ok butwe should choose one of the two.","commit_id":"d69926db39bc099d1c74cd2aaf2cc19540da457c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"38918571a780d4c6df1b34a39c039dfc322f4734","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"API will return either an HTTP 400 or 409 if the RCP version is clamp"},{"line_number":74,"context_line":"either manually or automaticaly to the required version for the"},{"line_number":75,"context_line":"targetState paramater."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"090c0794_f3d7f3bc","line":73,"range":{"start_line":73,"start_character":26,"end_line":73,"end_character":42},"in_reply_to":"66757b26_ba8dbdcf","updated":"2022-10-31 10:59:39.000000000","message":"I was not sure to understand where this part should be handled actually. But I think it is not necessary to mention that point anymore as targetState will not be passed via Rest API.","commit_id":"d69926db39bc099d1c74cd2aaf2cc19540da457c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b49cc5a03635bb160114f2b5b098467a4a27b98b","unresolved":true,"context_lines":[{"line_number":110,"context_line":"virt-driver handling the case of building instances with regards of an"},{"line_number":111,"context_line":"expected state. Issue reported at:"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"  https://bugs.launchpad.net/nova/+bug/1994967"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Upgrade impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"99aeff3b_3cb93f16","line":113,"updated":"2022-10-27 12:21:40.000000000","message":"It has been agreed that this spec would not resolve the\ndesign issue whereby the `evacuate server` action starts the virtual machines and then stops it\nwhen the target state is stopped. An issue has been reported at:","commit_id":"d69926db39bc099d1c74cd2aaf2cc19540da457c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"38918571a780d4c6df1b34a39c039dfc322f4734","unresolved":false,"context_lines":[{"line_number":110,"context_line":"virt-driver handling the case of building instances with regards of an"},{"line_number":111,"context_line":"expected state. Issue reported at:"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"  https://bugs.launchpad.net/nova/+bug/1994967"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Upgrade impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"cf4c3eb6_ed3bb313","line":113,"in_reply_to":"99aeff3b_3cb93f16","updated":"2022-10-31 10:59:39.000000000","message":"Done","commit_id":"d69926db39bc099d1c74cd2aaf2cc19540da457c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e6f10f596b32d9cda3826a09948622d35b602be1","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"https://blueprints.launchpad.net/nova/+spec/allowing-target-state-for-evacuate"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In certain circumstances the operator may desire to evacuating running"},{"line_number":13,"context_line":"instances to stopped state regardless of the current state of the"},{"line_number":14,"context_line":"instance."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"c2577b51_115684bf","line":12,"range":{"start_line":12,"start_character":52,"end_line":12,"end_character":62},"updated":"2022-11-15 13:53:21.000000000","message":"nit: evacuate","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"82a0c1ff1dc3ece595fe8d026fe2e24b6e738dd9","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"https://blueprints.launchpad.net/nova/+spec/allowing-target-state-for-evacuate"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In certain circumstances the operator may desire to evacuating running"},{"line_number":13,"context_line":"instances to stopped state regardless of the current state of the"},{"line_number":14,"context_line":"instance."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ac7abbd6_1d5a0393","line":12,"range":{"start_line":12,"start_character":52,"end_line":12,"end_character":62},"in_reply_to":"c2577b51_115684bf","updated":"2022-11-16 09:02:40.000000000","message":"Done","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"061c3040042ce4112a035ccc2a39d7e0ceb79841","unresolved":true,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The current evacuate instance API does not allow operators to set a"},{"line_number":20,"context_line":"desired target state to the evacuated instances. Restoring the orginal"},{"line_number":21,"context_line":"state of the instance when it was active on the source host may result"},{"line_number":22,"context_line":"in issues if the guest required a valid token to be started or prevent"},{"line_number":23,"context_line":"evacuation when using encrypted volumes."}],"source_content_type":"text/x-rst","patch_set":8,"id":"a9d09ad0_00188c09","line":20,"range":{"start_line":20,"start_character":63,"end_line":20,"end_character":70},"updated":"2022-11-15 12:13:50.000000000","message":"nit:original","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"82a0c1ff1dc3ece595fe8d026fe2e24b6e738dd9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The current evacuate instance API does not allow operators to set a"},{"line_number":20,"context_line":"desired target state to the evacuated instances. Restoring the orginal"},{"line_number":21,"context_line":"state of the instance when it was active on the source host may result"},{"line_number":22,"context_line":"in issues if the guest required a valid token to be started or prevent"},{"line_number":23,"context_line":"evacuation when using encrypted volumes."}],"source_content_type":"text/x-rst","patch_set":8,"id":"37db1cf9_9617cbc0","line":20,"range":{"start_line":20,"start_character":63,"end_line":20,"end_character":70},"in_reply_to":"a9d09ad0_00188c09","updated":"2022-11-16 09:02:40.000000000","message":"Done","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"061c3040042ce4112a035ccc2a39d7e0ceb79841","unresolved":true,"context_lines":[{"line_number":41,"context_line":"expected that before the bumped version the behavior stay the same,"},{"line_number":42,"context_line":"instances with state active or stopped will keep their state at"},{"line_number":43,"context_line":"destination."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"},{"line_number":46,"context_line":"------------"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"348a67aa_86129ee3","line":44,"updated":"2022-11-15 12:13:50.000000000","message":"I would describe here that:\n1) With the new microversion nova will *always* evacuate the instance to SHUTOFF state.\n2) The only way to keep the instance state after the evacuation is to use an older microversion.","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7fdf11a4216d11c76c7e64d93fc890a291db5970","unresolved":false,"context_lines":[{"line_number":41,"context_line":"expected that before the bumped version the behavior stay the same,"},{"line_number":42,"context_line":"instances with state active or stopped will keep their state at"},{"line_number":43,"context_line":"destination."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"},{"line_number":46,"context_line":"------------"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"c48858be_41dd12c8","line":44,"in_reply_to":"11795af8_f20d3495","updated":"2022-11-16 18:00:30.000000000","message":"Consistency is one benefit. The other is that if the instance is on a downed compute, it\u0027s already \"off\". If the evacuate is performed by the admin and it suddenly becomes running again, that may be a surprise to the actual owner. So, if I have an application running somewhere that has some inbuilt HA stuff, it notices that one instance stops responding and respawns that work elsewhere. Then some admin comes along, trying to help, and evacuates the original to a running state, that may conflict with my replacement instance at best, and at worst, could result in some unexpected data sharing/corruption.\n\nSo, since the evacuation is generally not done by the owner of the instance, the thinking is that it\u0027s safer (and more consistent) to have it evacuated to off state, like it was (probably) on the dead compute and let the owner do what they want with it.","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"39b23a8a71349ff19621696aa87416dc5c1a29ec","unresolved":false,"context_lines":[{"line_number":41,"context_line":"expected that before the bumped version the behavior stay the same,"},{"line_number":42,"context_line":"instances with state active or stopped will keep their state at"},{"line_number":43,"context_line":"destination."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"},{"line_number":46,"context_line":"------------"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3072109f_1c39a0ab","line":44,"in_reply_to":"11795af8_f20d3495","updated":"2022-11-16 18:00:20.000000000","message":"there are a few reasons\n\none is the other host died so there might eb data currption or other fallout so its safe to evacuate to off so that the enduser can take remidial action if they want/need too.\n\nsecond is that if you have a trusted plathform there may be keys other then the volume encyption key that the guest will try to retrieve that may be in acceable if the vm was started by the admin.\n\nthat was shaid\u0027s orginal usecase not encypted volumes.\n\nthe final reason was to save power. some vms are left active when not needed anymore, aws and other public clouds have this problem more then a private cloud.\n\nso by evacuating to off we are not wasting energy on dormant vms.\n\nso in general it was prefered to just always evacute to off in the new microversion.","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e6f10f596b32d9cda3826a09948622d35b602be1","unresolved":true,"context_lines":[{"line_number":41,"context_line":"expected that before the bumped version the behavior stay the same,"},{"line_number":42,"context_line":"instances with state active or stopped will keep their state at"},{"line_number":43,"context_line":"destination."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"},{"line_number":46,"context_line":"------------"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"44c0f7f8_99a914cc","line":44,"in_reply_to":"348a67aa_86129ee3","updated":"2022-11-15 13:53:21.000000000","message":"Agreed with gibi. By reading \"the API will pass to compute a target_state\nparameter\", this would mean you could tell \u0027ACTIVE\u0027. No, the microversion is definitely about not starting the domain.","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ed1c2c7035d2200dff12af0110c29b8839b27866","unresolved":false,"context_lines":[{"line_number":41,"context_line":"expected that before the bumped version the behavior stay the same,"},{"line_number":42,"context_line":"instances with state active or stopped will keep their state at"},{"line_number":43,"context_line":"destination."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"},{"line_number":46,"context_line":"------------"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"11795af8_f20d3495","line":44,"in_reply_to":"429c49c9_c113e5b8","updated":"2022-11-16 17:53:58.000000000","message":"OK, sorry about that, I didn\u0027t read the previous comments thoroughly enough.\n\nOne thing that I\u0027m not finding in the comments or the PTG etherpad that maybe I missed ... In the previous comments it looks like we were thinking to evacuate the instance to a stopped state if we cannot retrieve the encryption key from barbican (better user experience than failing to evacuate or putting state responsibility on the user).\n\nBut the proposal now says evacuate will always put the instance into a stopped state, not only when the key can\u0027t be retrieved. I didn\u0027t see the reasoning for that in the comments -- is it to ensure the behavior is consistent regardless of whether evacuating to ACTIVE is possible? Just want to make sure I understand.","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"57d4c8da6bc8445f3c4ef47952b611c45ef37feb","unresolved":true,"context_lines":[{"line_number":41,"context_line":"expected that before the bumped version the behavior stay the same,"},{"line_number":42,"context_line":"instances with state active or stopped will keep their state at"},{"line_number":43,"context_line":"destination."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"},{"line_number":46,"context_line":"------------"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7102be1f_727218a3","line":44,"in_reply_to":"44c0f7f8_99a914cc","updated":"2022-11-15 15:02:51.000000000","message":"that not how i read it as we never said the api would accpet a target parmater just that we will modify the rpc so that the api can pass a target state to indicate which microversion was used.\n\nbut yes we can clarify as gibi suggests","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0172db4cacb820820184c6784b06696bf61cac36","unresolved":true,"context_lines":[{"line_number":41,"context_line":"expected that before the bumped version the behavior stay the same,"},{"line_number":42,"context_line":"instances with state active or stopped will keep their state at"},{"line_number":43,"context_line":"destination."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"},{"line_number":46,"context_line":"------------"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa836e87_8115be83","line":44,"in_reply_to":"7102be1f_727218a3","updated":"2022-11-16 04:50:08.000000000","message":"Are we saying we want there to be no choice about the target state? Is there no use case for evacuating in a non SHUTOFF state? I\u0027m wary about forcing SHUTOFF with no ability to use ACTIVE, if there are use cases for evacuating to ACTIVE (or previous state).","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"68747b8b2addc32cf18efc9b303d9fc6e7886aa8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"expected that before the bumped version the behavior stay the same,"},{"line_number":42,"context_line":"instances with state active or stopped will keep their state at"},{"line_number":43,"context_line":"destination."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"},{"line_number":46,"context_line":"------------"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"743b836d_78fb9389","line":44,"in_reply_to":"c48858be_41dd12c8","updated":"2022-11-16 18:23:40.000000000","message":"That makes it clear, thank you Sean and Dan for explaining!","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"82a0c1ff1dc3ece595fe8d026fe2e24b6e738dd9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"expected that before the bumped version the behavior stay the same,"},{"line_number":42,"context_line":"instances with state active or stopped will keep their state at"},{"line_number":43,"context_line":"destination."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"},{"line_number":46,"context_line":"------------"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"429c49c9_c113e5b8","line":44,"in_reply_to":"fa836e87_8115be83","updated":"2022-11-16 09:02:40.000000000","message":"mellwitt I think that has been discussed during PTG. The desire to force shutdown, for users that want previous behavior, they can use an older microversion.","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e6f10f596b32d9cda3826a09948622d35b602be1","unresolved":true,"context_lines":[{"line_number":70,"context_line":"             \"host\": \"b419863b7d814906a68fb31703c0dbd6\","},{"line_number":71,"context_line":"        }"},{"line_number":72,"context_line":"    }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Security impact"},{"line_number":76,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"4a37b6d7_49ecef2b","line":73,"updated":"2022-11-15 13:53:21.000000000","message":"this, I agree. I suppose you just forgot to modify L39.","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"82a0c1ff1dc3ece595fe8d026fe2e24b6e738dd9","unresolved":false,"context_lines":[{"line_number":70,"context_line":"             \"host\": \"b419863b7d814906a68fb31703c0dbd6\","},{"line_number":71,"context_line":"        }"},{"line_number":72,"context_line":"    }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Security impact"},{"line_number":76,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"60b294a6_05034bc8","line":73,"in_reply_to":"4a37b6d7_49ecef2b","updated":"2022-11-16 09:02:40.000000000","message":"Done","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e6f10f596b32d9cda3826a09948622d35b602be1","unresolved":true,"context_lines":[{"line_number":85,"context_line":"Other end user impact"},{"line_number":86,"context_line":"---------------------"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"- The nova api-ref will be updated to reflect the changes."},{"line_number":89,"context_line":"- Related to openstack client, nothing is expected to change instead"},{"line_number":90,"context_line":"  of a noop bump."},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"48146cf1_cd84a29f","line":88,"updated":"2022-11-15 13:53:21.000000000","message":"Yup, to be clear, you\u0027ll have to explain in https://docs.openstack.org/api-ref/compute/?expanded\u003devacuate-server-evacuate-action-detail#evacuate-server-evacuate-action that after microversion 2.xx the postcondition will be that the instance state is eventually STOPPED.","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"82a0c1ff1dc3ece595fe8d026fe2e24b6e738dd9","unresolved":false,"context_lines":[{"line_number":85,"context_line":"Other end user impact"},{"line_number":86,"context_line":"---------------------"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"- The nova api-ref will be updated to reflect the changes."},{"line_number":89,"context_line":"- Related to openstack client, nothing is expected to change instead"},{"line_number":90,"context_line":"  of a noop bump."},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ecffd063_185ce04b","line":88,"in_reply_to":"48146cf1_cd84a29f","updated":"2022-11-16 09:02:40.000000000","message":"Ack","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"061c3040042ce4112a035ccc2a39d7e0ceb79841","unresolved":true,"context_lines":[{"line_number":114,"context_line":"--------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- Upgrade note will be added describing new behavior."},{"line_number":117,"context_line":"- An RPC change is expected to make manager handling the new target"},{"line_number":118,"context_line":"  state parameter, resulting in the version being incremented."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":8,"id":"a9601ba7_24bd9236","line":117,"updated":"2022-11-15 12:13:50.000000000","message":"If we have a new RPC version to support the new microversion then we also need a minimum compute service version check to reject the evac with the new microversion if the computes in the cluster haven\u0027t upgraded to the latest RPC yet.","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3e3ecbf662a0cfb62412c1b6563003fc113ee153","unresolved":true,"context_lines":[{"line_number":114,"context_line":"--------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- Upgrade note will be added describing new behavior."},{"line_number":117,"context_line":"- An RPC change is expected to make manager handling the new target"},{"line_number":118,"context_line":"  state parameter, resulting in the version being incremented."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":8,"id":"c833f623_e2409845","line":117,"in_reply_to":"3e8d33ef_547a4f04","updated":"2022-11-15 17:44:18.000000000","message":"ya it is as i said im ok with a min version check\n\nbut when we do an rpc call we do something like this\n\nhttps://github.com/openstack/nova/blob/master/nova/compute/rpcapi.py#L585-L600\n\n   client \u003d self.router.client(ctxt)\n        version \u003d self._ver(ctxt, \u00275.3\u0027)\n        kwargs \u003d {\n            \u0027instance\u0027: instance,\n            \u0027block_migration\u0027: block_migration,\n            \u0027disk_over_commit\u0027: disk_over_commit,\n            \u0027migration\u0027: migration,\n            \u0027limits\u0027: limits\n        }\n        if not client.can_send_version(version):\n            kwargs.pop(\u0027migration\u0027)\n            kwargs.pop(\u0027limits\u0027)\n            version \u003d \u00275.0\u0027\n        cctxt \u003d client.prepare(server\u003ddestination, version\u003dversion,\n                               call_monitor_timeout\u003dCONF.rpc_response_timeout,\n                               timeout\u003dCONF.long_rpc_timeout)\n                               \n  we have two patthern etiehr we do a can_send_version check and backlevel\n  \n  or we call prepare with a hardcoded version and if it cant meet that i belive it raises an RPCVersionCapError if the versio nwe request is large then what is supported.\n  \ni agree this is very late if we do a per compute service verion check it will be just as late.\n\nso if we do a compute service verion bump then we should do a min service verion check in the api.","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f02d03f93878e9cae73c6843a365a54d8efcca09","unresolved":false,"context_lines":[{"line_number":114,"context_line":"--------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- Upgrade note will be added describing new behavior."},{"line_number":117,"context_line":"- An RPC change is expected to make manager handling the new target"},{"line_number":118,"context_line":"  state parameter, resulting in the version being incremented."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":8,"id":"90e97fd9_63dbce56","line":117,"in_reply_to":"70a1f17e_cecf1345","updated":"2022-11-16 09:21:16.000000000","message":"Done","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"074d3add840f7b0f20bd7f0e8c20d56fe8519a02","unresolved":true,"context_lines":[{"line_number":114,"context_line":"--------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- Upgrade note will be added describing new behavior."},{"line_number":117,"context_line":"- An RPC change is expected to make manager handling the new target"},{"line_number":118,"context_line":"  state parameter, resulting in the version being incremented."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3e8d33ef_547a4f04","line":117,"in_reply_to":"a1edb631_5409e77c","updated":"2022-11-15 16:11:07.000000000","message":"Do we get the reject from the RPC layer when the conductor tries to call to the target compute? If so that is pretty late as we already scheduled the instance unnecessarily.","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"57d4c8da6bc8445f3c4ef47952b611c45ef37feb","unresolved":true,"context_lines":[{"line_number":114,"context_line":"--------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- Upgrade note will be added describing new behavior."},{"line_number":117,"context_line":"- An RPC change is expected to make manager handling the new target"},{"line_number":118,"context_line":"  state parameter, resulting in the version being incremented."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":8,"id":"a1edb631_5409e77c","line":117,"in_reply_to":"a9601ba7_24bd9236","updated":"2022-11-15 15:02:51.000000000","message":"i am  not sure we do because the RPC verion check will fail when we attept to call it.\n\nif the conductor is not upgraded the conductor rpc woudl fail and if the selected compute is not update the compute rpc form the condcutor will fail.\n\ni guess we dont really want to wait that long to decided if we shoudl fail hence the intoduction fo a compute service version bump that we can check at the api.\n\nim not against that but i think our rpc handelign woudl be able to detect the compute was not new engough.\n\nso i guess your suggestign adding a min compute service check to the api so that this feature only enabels if all compute are upgraded for simplicty of upgrades.\n\nif fine with hat","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e03d2d4866b86fc25cf4df6a17bc53d5569f176d","unresolved":true,"context_lines":[{"line_number":114,"context_line":"--------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- Upgrade note will be added describing new behavior."},{"line_number":117,"context_line":"- An RPC change is expected to make manager handling the new target"},{"line_number":118,"context_line":"  state parameter, resulting in the version being incremented."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":8,"id":"70a1f17e_cecf1345","line":117,"in_reply_to":"b0c2c893_150bf9c5","updated":"2022-11-16 09:10:39.000000000","message":"I suggest (and seems like Sean is not against it) to do a minimum compute version check[1] in the nova-api level when evacuate is called with the new microversion. The RPC bump will mean we will have a compute service version bump as well. So the nova-api can check during evacuate what is the minimum service version across the compute cluster and if it is older than the one that introduced the new RPC then reject the evacuate call.\n\n[1] https://github.com/openstack/nova/blob/797779688f0515cfa5eb58f935a376cbc08d33e4/nova/objects/service.py#L556","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"82a0c1ff1dc3ece595fe8d026fe2e24b6e738dd9","unresolved":true,"context_lines":[{"line_number":114,"context_line":"--------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- Upgrade note will be added describing new behavior."},{"line_number":117,"context_line":"- An RPC change is expected to make manager handling the new target"},{"line_number":118,"context_line":"  state parameter, resulting in the version being incremented."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":8,"id":"b0c2c893_150bf9c5","line":117,"in_reply_to":"c833f623_e2409845","updated":"2022-11-16 09:02:40.000000000","message":"Not sure to get the point, could you give me a bit more detail of the desire here? Thanks","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e6f10f596b32d9cda3826a09948622d35b602be1","unresolved":true,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- Upgrade note will be added describing new behavior."},{"line_number":117,"context_line":"- An RPC change is expected to make manager handling the new target"},{"line_number":118,"context_line":"  state parameter, resulting in the version being incremented."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Implementation"},{"line_number":121,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"21284a56_5dc642aa","line":118,"updated":"2022-11-15 13:53:21.000000000","message":"I don\u0027t see where you\u0027re proposing a state parameter thru this API, I guess you forgot to modify this line too when you changed your REST API change section.","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"82a0c1ff1dc3ece595fe8d026fe2e24b6e738dd9","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- Upgrade note will be added describing new behavior."},{"line_number":117,"context_line":"- An RPC change is expected to make manager handling the new target"},{"line_number":118,"context_line":"  state parameter, resulting in the version being incremented."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Implementation"},{"line_number":121,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"61151445_cee9a51d","line":118,"in_reply_to":"21284a56_5dc642aa","updated":"2022-11-16 09:02:40.000000000","message":"Done","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"061c3040042ce4112a035ccc2a39d7e0ceb79841","unresolved":true,"context_lines":[{"line_number":149,"context_line":"Testing"},{"line_number":150,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"- Unit or functional testing for API change."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Documentation Impact"},{"line_number":155,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"208a2cb4_7615b947","line":152,"range":{"start_line":152,"start_character":7,"end_line":152,"end_character":9},"updated":"2022-11-15 12:13:50.000000000","message":"and :)","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"bb384b4e4f1d00ffce63f7d7a4b49c8057cc0472","unresolved":false,"context_lines":[{"line_number":149,"context_line":"Testing"},{"line_number":150,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"- Unit or functional testing for API change."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Documentation Impact"},{"line_number":155,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"2d19ee4a_0e2e6f1d","line":152,"range":{"start_line":152,"start_character":7,"end_line":152,"end_character":9},"in_reply_to":"208a2cb4_7615b947","updated":"2022-11-16 09:03:49.000000000","message":"Done","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e6f10f596b32d9cda3826a09948622d35b602be1","unresolved":true,"context_lines":[{"line_number":159,"context_line":"References"},{"line_number":160,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"* https://docs.openstack.org/api-ref/compute/?expanded\u003devacuate-server-evacuate-action-detail,inject-network-information-injectnetworkinfo-action-detail#evacuate-server-evacuate-action"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"History"},{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"457d50b5_7a08d8ce","line":162,"range":{"start_line":162,"start_character":94,"end_line":162,"end_character":152},"updated":"2022-11-15 13:53:21.000000000","message":"nit: unnecessary unfolding :-)","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"82a0c1ff1dc3ece595fe8d026fe2e24b6e738dd9","unresolved":false,"context_lines":[{"line_number":159,"context_line":"References"},{"line_number":160,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"* https://docs.openstack.org/api-ref/compute/?expanded\u003devacuate-server-evacuate-action-detail,inject-network-information-injectnetworkinfo-action-detail#evacuate-server-evacuate-action"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"History"},{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"c14a8d89_eb77ee5e","line":162,"range":{"start_line":162,"start_character":94,"end_line":162,"end_character":152},"in_reply_to":"457d50b5_7a08d8ce","updated":"2022-11-16 09:02:40.000000000","message":"Done","commit_id":"883ce5d4a77107fdb239cd34dbda1b42ef45135a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"347968cac350abe8d7732ed47a570de8a9f4133c","unresolved":true,"context_lines":[{"line_number":120,"context_line":"- Upgrade note will be added describing new behavior."},{"line_number":121,"context_line":"- An RPC change is expected to make manager handling the new target"},{"line_number":122,"context_line":"  state, resulting in the version being incremented."},{"line_number":123,"context_line":"- At API level, a min version check will ensure that the cluster as at"},{"line_number":124,"context_line":"  least one compute node able to accept the request."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Implementation"},{"line_number":127,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"2fa93819_90a67202","line":124,"range":{"start_line":123,"start_character":0,"end_line":124,"end_character":52},"updated":"2022-11-16 11:53:06.000000000","message":"no you shoudl ensure that all services are new enough\n\nthe min comptue service version check we normlaly add are there\nto ensure the could is fully upgraded before enabeling the functionality.","commit_id":"479f8c81a402b79617974dfe35acb984656b981d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f7b7c0249a496feb00d9f30ff5157e57702bf017","unresolved":false,"context_lines":[{"line_number":120,"context_line":"- Upgrade note will be added describing new behavior."},{"line_number":121,"context_line":"- An RPC change is expected to make manager handling the new target"},{"line_number":122,"context_line":"  state, resulting in the version being incremented."},{"line_number":123,"context_line":"- At API level, a min version check will ensure that the cluster as at"},{"line_number":124,"context_line":"  least one compute node able to accept the request."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Implementation"},{"line_number":127,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fc983ed7_73251459","line":124,"range":{"start_line":123,"start_character":0,"end_line":124,"end_character":52},"in_reply_to":"2fa93819_90a67202","updated":"2022-11-16 12:31:25.000000000","message":"Hum ok.. I\u0027m not clear with all of that but I guess It will be clarified for me during implementation. Thank you Sean","commit_id":"479f8c81a402b79617974dfe35acb984656b981d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6929e51aac9f0cedffb8382cf859bf07f9fed9b3","unresolved":true,"context_lines":[{"line_number":30,"context_line":"requirements, that do not allow them to be started by the"},{"line_number":31,"context_line":"administrator."},{"line_number":32,"context_line":"As an operator, I would like to be able to evacuate VMs with encrypted"},{"line_number":33,"context_line":"volumes without making the barbican secrete readable by admins and"},{"line_number":34,"context_line":"reducing the security."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":11,"id":"c3e75923_2a5c932f","line":33,"range":{"start_line":33,"start_character":36,"end_line":33,"end_character":43},"updated":"2022-11-29 14:56:44.000000000","message":"\"secret\"","commit_id":"66fe2b62853c5fe77a5c0622939f7c340f9a422e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"10816a4f2e54c2f322819b58315bf204f84b77c1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"requirements, that do not allow them to be started by the"},{"line_number":31,"context_line":"administrator."},{"line_number":32,"context_line":"As an operator, I would like to be able to evacuate VMs with encrypted"},{"line_number":33,"context_line":"volumes without making the barbican secrete readable by admins and"},{"line_number":34,"context_line":"reducing the security."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":11,"id":"bb12eb9b_86f44c39","line":33,"range":{"start_line":33,"start_character":36,"end_line":33,"end_character":43},"in_reply_to":"c3e75923_2a5c932f","updated":"2022-11-30 09:08:23.000000000","message":"Done","commit_id":"66fe2b62853c5fe77a5c0622939f7c340f9a422e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6929e51aac9f0cedffb8382cf859bf07f9fed9b3","unresolved":true,"context_lines":[{"line_number":32,"context_line":"As an operator, I would like to be able to evacuate VMs with encrypted"},{"line_number":33,"context_line":"volumes without making the barbican secrete readable by admins and"},{"line_number":34,"context_line":"reducing the security."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"12bb6153_a775e4c1","line":35,"updated":"2022-11-29 14:56:44.000000000","message":"Don\u0027t worry about it now, but another use case would have answered Melanie\u0027s question:\n\n\"As a user, if my instance is offline due to a host outage, I don\u0027t necessarily want an admin evacuating it and bringing it back online without my knowledge as I may have already replaced it and the zombie coming back may cause a conflict.\"","commit_id":"66fe2b62853c5fe77a5c0622939f7c340f9a422e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"10816a4f2e54c2f322819b58315bf204f84b77c1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"As an operator, I would like to be able to evacuate VMs with encrypted"},{"line_number":33,"context_line":"volumes without making the barbican secrete readable by admins and"},{"line_number":34,"context_line":"reducing the security."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"02f0eaf3_b02f0286","line":35,"in_reply_to":"12bb6153_a775e4c1","updated":"2022-11-30 09:08:23.000000000","message":"Done","commit_id":"66fe2b62853c5fe77a5c0622939f7c340f9a422e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6929e51aac9f0cedffb8382cf859bf07f9fed9b3","unresolved":true,"context_lines":[{"line_number":118,"context_line":"--------------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"- Upgrade note will be added describing new behavior."},{"line_number":121,"context_line":"- An RPC change is expected to make manager handling the new target"},{"line_number":122,"context_line":"  state, resulting in the version being incremented."},{"line_number":123,"context_line":"- At API level, a min version check will ensure that all services are"},{"line_number":124,"context_line":"  new enough to accept the request."}],"source_content_type":"text/x-rst","patch_set":11,"id":"b7bb64fc_4596799a","line":121,"range":{"start_line":121,"start_character":36,"end_line":121,"end_character":52},"updated":"2022-11-29 14:56:44.000000000","message":"\"the compute manager handle\"","commit_id":"66fe2b62853c5fe77a5c0622939f7c340f9a422e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"10816a4f2e54c2f322819b58315bf204f84b77c1","unresolved":false,"context_lines":[{"line_number":118,"context_line":"--------------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"- Upgrade note will be added describing new behavior."},{"line_number":121,"context_line":"- An RPC change is expected to make manager handling the new target"},{"line_number":122,"context_line":"  state, resulting in the version being incremented."},{"line_number":123,"context_line":"- At API level, a min version check will ensure that all services are"},{"line_number":124,"context_line":"  new enough to accept the request."}],"source_content_type":"text/x-rst","patch_set":11,"id":"916c6987_dcb277a0","line":121,"range":{"start_line":121,"start_character":36,"end_line":121,"end_character":52},"in_reply_to":"b7bb64fc_4596799a","updated":"2022-11-30 09:08:23.000000000","message":"Done","commit_id":"66fe2b62853c5fe77a5c0622939f7c340f9a422e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6929e51aac9f0cedffb8382cf859bf07f9fed9b3","unresolved":true,"context_lines":[{"line_number":120,"context_line":"- Upgrade note will be added describing new behavior."},{"line_number":121,"context_line":"- An RPC change is expected to make manager handling the new target"},{"line_number":122,"context_line":"  state, resulting in the version being incremented."},{"line_number":123,"context_line":"- At API level, a min version check will ensure that all services are"},{"line_number":124,"context_line":"  new enough to accept the request."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Implementation"},{"line_number":127,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":11,"id":"e5b1a4df_3517de66","line":124,"range":{"start_line":123,"start_character":2,"end_line":124,"end_character":35},"updated":"2022-11-29 14:56:44.000000000","message":"I think I missed this part of the discussion. If all the compute nodes are not upgraded, what are you going to do? Reject use of the new microversion entirely?","commit_id":"66fe2b62853c5fe77a5c0622939f7c340f9a422e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"10816a4f2e54c2f322819b58315bf204f84b77c1","unresolved":true,"context_lines":[{"line_number":120,"context_line":"- Upgrade note will be added describing new behavior."},{"line_number":121,"context_line":"- An RPC change is expected to make manager handling the new target"},{"line_number":122,"context_line":"  state, resulting in the version being incremented."},{"line_number":123,"context_line":"- At API level, a min version check will ensure that all services are"},{"line_number":124,"context_line":"  new enough to accept the request."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Implementation"},{"line_number":127,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":11,"id":"bdfd51f6_c61ed51c","line":124,"range":{"start_line":123,"start_character":2,"end_line":124,"end_character":35},"in_reply_to":"e5b1a4df_3517de66","updated":"2022-11-30 09:08:23.000000000","message":"The outcome what from my understanding that we have considered rejecting the request with an exception.\n\nI will add a note to make it clear, we could still update the spec if we change our mind.\n\nhttps://review.opendev.org/c/openstack/nova/+/858384/23/nova/api/openstack/compute/evacuate.py#105","commit_id":"66fe2b62853c5fe77a5c0622939f7c340f9a422e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6929e51aac9f0cedffb8382cf859bf07f9fed9b3","unresolved":true,"context_lines":[{"line_number":165,"context_line":"References"},{"line_number":166,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"* https://docs.openstack.org/api-ref/compute/?expanded\u003devacuate-server-evacuate-action-detai"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"History"},{"line_number":171,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":11,"id":"cbe8ae79_c2ad0028","line":168,"updated":"2022-11-29 14:56:44.000000000","message":"You\u0027re missing the \"l\" at the end of this URL, which means it doesn\u0027t actually activate the evacuate box.","commit_id":"66fe2b62853c5fe77a5c0622939f7c340f9a422e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"10816a4f2e54c2f322819b58315bf204f84b77c1","unresolved":false,"context_lines":[{"line_number":165,"context_line":"References"},{"line_number":166,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"* https://docs.openstack.org/api-ref/compute/?expanded\u003devacuate-server-evacuate-action-detai"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"History"},{"line_number":171,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7df11655_270467ca","line":168,"in_reply_to":"cbe8ae79_c2ad0028","updated":"2022-11-30 09:08:23.000000000","message":"Oops, thank you good catch ;-)","commit_id":"66fe2b62853c5fe77a5c0622939f7c340f9a422e"}],"specs/antelope-template.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d91c2ba812e24b4c58dec71d179fdb01f3a9aaac","unresolved":true,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"a1a55714_2d39f6a1","line":1,"updated":"2022-10-04 11:46:34.000000000","message":"this shoudl be in a spereate commit","commit_id":"f7fe3d8be06ac4c97d1eb8c69e6b5a5780f10e17"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e4877c5f873c051d1b72e4958ab01988c57e9494","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"51652276_35d53959","line":1,"in_reply_to":"a1a55714_2d39f6a1","updated":"2022-10-11 07:51:39.000000000","message":"Done","commit_id":"f7fe3d8be06ac4c97d1eb8c69e6b5a5780f10e17"}],"specs/antelope/approved/allowing-target-state-for-evacuate.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"43b7b657a8807c49320fdc0732cb6cdffcd4a851","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"   API will start accepting optional `targetState` argument in body of"},{"line_number":37,"context_line":"   type enum (stop, start). If nothing is specified the current"},{"line_number":38,"context_line":"   behavior stay the same."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Alternatives"},{"line_number":41,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"86072586_3633b4a6","line":38,"updated":"2022-09-15 11:49:43.000000000","message":"+1","commit_id":"f46417c45ff63387996476a6f37f733ce6daa6e8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1782dc065462c80cea48d9205ac2b9af65e242e4","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"   API will start accepting optional `targetState` argument in body of"},{"line_number":37,"context_line":"   type enum (stop, start). If nothing is specified the current"},{"line_number":38,"context_line":"   behavior stay the same."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Alternatives"},{"line_number":41,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fdc21c3_66fc9c45","line":38,"in_reply_to":"86072586_3633b4a6","updated":"2022-10-04 10:46:00.000000000","message":"Done","commit_id":"f46417c45ff63387996476a6f37f733ce6daa6e8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"43b7b657a8807c49320fdc0732cb6cdffcd4a851","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"It may be possible to enhance the API resetState to accept RUNNING and"},{"line_number":44,"context_line":"SHUTOFF."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Data model impact"},{"line_number":47,"context_line":"-----------------"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"756e7b56_91e4bccd","line":45,"updated":"2022-09-15 11:49:43.000000000","message":"another alternitive was to allow poweroff/stop to work when a compute node is down\nand have it just update the db. the compute agent when startign would then reconsile the state of the vm on the hsot with the db by stoping it once its functional agian.\n\n\nwe prefered extendign evacuate on irc to not allow this possibley untrue state to remain in our db (i.e. the vm is recored as stopped when its actully runnign)\n\n\nwe also prefereed doing this via evaucate because fo the existing checks that are already in place and interaction with thing liek forced down.","commit_id":"f46417c45ff63387996476a6f37f733ce6daa6e8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3e1b734706e669b1de41399956448a4213216bd1","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"It may be possible to enhance the API resetState to accept RUNNING and"},{"line_number":44,"context_line":"SHUTOFF."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Data model impact"},{"line_number":47,"context_line":"-----------------"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"d03bf63a_b5f4b79a","line":45,"in_reply_to":"756e7b56_91e4bccd","updated":"2022-10-04 07:56:27.000000000","message":"Yes rights, let me add note about that. thanks.","commit_id":"f46417c45ff63387996476a6f37f733ce6daa6e8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1782dc065462c80cea48d9205ac2b9af65e242e4","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"It may be possible to enhance the API resetState to accept RUNNING and"},{"line_number":44,"context_line":"SHUTOFF."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Data model impact"},{"line_number":47,"context_line":"-----------------"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ad4b55cf_3444ef47","line":45,"in_reply_to":"d03bf63a_b5f4b79a","updated":"2022-10-04 10:46:00.000000000","message":"Done","commit_id":"f46417c45ff63387996476a6f37f733ce6daa6e8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"43b7b657a8807c49320fdc0732cb6cdffcd4a851","unresolved":true,"context_lines":[{"line_number":60,"context_line":"    {"},{"line_number":61,"context_line":"        \"evacuate\": {"},{"line_number":62,"context_line":"             \"host\": \"b419863b7d814906a68fb31703c0dbd6\","},{"line_number":63,"context_line":"             \"onSharedStorage\": \"False\","},{"line_number":64,"context_line":"\t\t\t \"targetState\": \"stop\""},{"line_number":65,"context_line":"        }"},{"line_number":66,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":1,"id":"107464d6_2525f235","line":63,"range":{"start_line":63,"start_character":11,"end_line":63,"end_character":40},"updated":"2022-09-15 11:49:43.000000000","message":"this is not really a parmete rthat shoudl be passed anymore\n\nit decaults to auto and  admins should avoid using it so it wold be better ot not include itin this example","commit_id":"f46417c45ff63387996476a6f37f733ce6daa6e8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3e1b734706e669b1de41399956448a4213216bd1","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    {"},{"line_number":61,"context_line":"        \"evacuate\": {"},{"line_number":62,"context_line":"             \"host\": \"b419863b7d814906a68fb31703c0dbd6\","},{"line_number":63,"context_line":"             \"onSharedStorage\": \"False\","},{"line_number":64,"context_line":"\t\t\t \"targetState\": \"stop\""},{"line_number":65,"context_line":"        }"},{"line_number":66,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":1,"id":"99cbdde6_e0da1c39","line":63,"range":{"start_line":63,"start_character":11,"end_line":63,"end_character":40},"in_reply_to":"107464d6_2525f235","updated":"2022-10-04 07:56:27.000000000","message":"Ack","commit_id":"f46417c45ff63387996476a6f37f733ce6daa6e8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"43b7b657a8807c49320fdc0732cb6cdffcd4a851","unresolved":true,"context_lines":[{"line_number":79,"context_line":"Other end user impact"},{"line_number":80,"context_line":"---------------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"The nova api-ref will updated to reflect the changes."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Performance Impact"},{"line_number":85,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c79a4884_342cef98","line":82,"updated":"2022-09-15 11:49:43.000000000","message":"you will need to add the parmater to either the sdk or novaclient python binding \nand then add teh cli parmater to only the openstack client.\n\nthe shell provided by nova clinet is frozen and shoudl not be extended\n\neither the openstack sdk or novaclinet need to be exetend to provide the python bindigns to osc. you can to either or both.","commit_id":"f46417c45ff63387996476a6f37f733ce6daa6e8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1782dc065462c80cea48d9205ac2b9af65e242e4","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Other end user impact"},{"line_number":80,"context_line":"---------------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"The nova api-ref will updated to reflect the changes."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Performance Impact"},{"line_number":85,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8d8cd4_448336c5","line":82,"in_reply_to":"634ddfb2_0ab5e07a","updated":"2022-10-04 10:46:00.000000000","message":"Done","commit_id":"f46417c45ff63387996476a6f37f733ce6daa6e8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3e1b734706e669b1de41399956448a4213216bd1","unresolved":true,"context_lines":[{"line_number":79,"context_line":"Other end user impact"},{"line_number":80,"context_line":"---------------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"The nova api-ref will updated to reflect the changes."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Performance Impact"},{"line_number":85,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"634ddfb2_0ab5e07a","line":82,"in_reply_to":"c79a4884_342cef98","updated":"2022-10-04 07:56:27.000000000","message":"Oh yes!","commit_id":"f46417c45ff63387996476a6f37f733ce6daa6e8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"43b7b657a8807c49320fdc0732cb6cdffcd4a851","unresolved":true,"context_lines":[{"line_number":99,"context_line":"Upgrade impact"},{"line_number":100,"context_line":"--------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Upgrade notes will be added describing new option targetState."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Implementation"},{"line_number":105,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dbca2eef_7b0db777","line":102,"updated":"2022-09-15 11:49:43.000000000","message":"im never sure if this goes here or in developer/data model  impact\nbut you will need to extend the evacuate RPC call to take the new parmater and the api will need to catch the compute api verion unsupproted error and return a 400 explainign the target compute is too old in that case t cater for rolling upgrades.\n\nalternitively in the api you can add a min compute service version check if you only want to support this when the cloud is fully upgraded.","commit_id":"f46417c45ff63387996476a6f37f733ce6daa6e8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d37fa4afbc1ede3e5fa106096e6d1bbc292f115a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Upgrade impact"},{"line_number":100,"context_line":"--------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Upgrade notes will be added describing new option targetState."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Implementation"},{"line_number":105,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e7d93585_0ec2ae69","line":102,"in_reply_to":"59efc1fa_8fb225ee","updated":"2022-10-11 07:51:54.000000000","message":"Done","commit_id":"f46417c45ff63387996476a6f37f733ce6daa6e8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d91c2ba812e24b4c58dec71d179fdb01f3a9aaac","unresolved":true,"context_lines":[{"line_number":99,"context_line":"Upgrade impact"},{"line_number":100,"context_line":"--------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Upgrade notes will be added describing new option targetState."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Implementation"},{"line_number":105,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"59efc1fa_8fb225ee","line":102,"in_reply_to":"7c2fd250_be633080","updated":"2022-10-04 11:46:34.000000000","message":"adding a parameter is an rpc change that need a  new version so this change does require rpc changes https://review.opendev.org/c/openstack/nova/+/858383/4/nova/compute/api.py#5612\n\nfor exmapel in 6.1 we added the reimage_boot_volume parmater to rebuild\nthe compute rpc bump happened in \nhttps://github.com/openstack/nova/commit/30aab9c234035b49c7e2cdc940f624a63eeffc1b\nthe conductor rpc was bumped in \nhttps://review.opendev.org/c/openstack/nova/+/831219/22\nand api change happend in https://review.opendev.org/c/openstack/nova/+/830883/32\n\nshoudl shoudl only modify the comptue api module in the last change in the serise and the unit and functional tests shoudl be in the change patch that modifes the fucntions.","commit_id":"f46417c45ff63387996476a6f37f733ce6daa6e8"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3e1b734706e669b1de41399956448a4213216bd1","unresolved":true,"context_lines":[{"line_number":99,"context_line":"Upgrade impact"},{"line_number":100,"context_line":"--------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Upgrade notes will be added describing new option targetState."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Implementation"},{"line_number":105,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7c2fd250_be633080","line":102,"in_reply_to":"dbca2eef_7b0db777","updated":"2022-10-04 07:56:27.000000000","message":"Hum OK I will check that and update that part.\n\nAbout the RCP change normally it we don\u0027t have too.  I have started draft implementation here, if you have a moment to see whether I\u0027m in the good direction.\n\n  https://review.opendev.org/c/openstack/nova/+/858383","commit_id":"f46417c45ff63387996476a6f37f733ce6daa6e8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"41d06a22804a47fb96fe510f9ee9a91c5e62b539","unresolved":true,"context_lines":[{"line_number":26,"context_line":"private cloud may have necessity to evacuate instances to a"},{"line_number":27,"context_line":"destination host as stopped even if they were running on source host."},{"line_number":28,"context_line":"Some public cloud also prefer to evacuate instances as stopped, like"},{"line_number":29,"context_line":"Amazon AWS."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dc7a99ce_579ccda1","line":29,"updated":"2022-10-04 17:10:35.000000000","message":"Can you elaborate on the why for this? You say there\u0027s a \"necessity\" but I\u0027d like to know *why*.","commit_id":"f7fe3d8be06ac4c97d1eb8c69e6b5a5780f10e17"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"921fe9b2aa92303f686be871a20fb5cfe6bcf9e6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"private cloud may have necessity to evacuate instances to a"},{"line_number":27,"context_line":"destination host as stopped even if they were running on source host."},{"line_number":28,"context_line":"Some public cloud also prefer to evacuate instances as stopped, like"},{"line_number":29,"context_line":"Amazon AWS."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"490ef7a1_37d3acaf","line":29,"in_reply_to":"1374d4fe_7009dc21","updated":"2022-10-27 11:45:19.000000000","message":"I think we are good regarding the desires here.","commit_id":"f7fe3d8be06ac4c97d1eb8c69e6b5a5780f10e17"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f51e978827063eb236dbad4d1d4f8d07bee28e2d","unresolved":true,"context_lines":[{"line_number":26,"context_line":"private cloud may have necessity to evacuate instances to a"},{"line_number":27,"context_line":"destination host as stopped even if they were running on source host."},{"line_number":28,"context_line":"Some public cloud also prefer to evacuate instances as stopped, like"},{"line_number":29,"context_line":"Amazon AWS."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9878af53_75c8d3d8","line":29,"in_reply_to":"4bad3939_1df0e9dc","updated":"2022-10-05 15:29:43.000000000","message":"I guess that seems like a bit of a hack, because the non-owning person needs to know that (a) it\u0027s using an encrypted volume and (b) that they will need to do this in order for it to be evacuated properly. If that thing doing the evacuate is something like instanceHA then the script needs to be aware, and if the thing is some not-as-technical lab monkey kind of person, they might not know.\n\nSo, it\u0027s a reason to have this I guess, but it\u0027s not the greatest solution to that problem, IMHO. Just having evacuate work but leave it stopped if we can\u0027t trivially poke the key seems like a much more \"just works\" solution fro that actual issue.","commit_id":"f7fe3d8be06ac4c97d1eb8c69e6b5a5780f10e17"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5301646a3f36fae6fad277dc9320145f8622ae67","unresolved":true,"context_lines":[{"line_number":26,"context_line":"private cloud may have necessity to evacuate instances to a"},{"line_number":27,"context_line":"destination host as stopped even if they were running on source host."},{"line_number":28,"context_line":"Some public cloud also prefer to evacuate instances as stopped, like"},{"line_number":29,"context_line":"Amazon AWS."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1374d4fe_7009dc21","line":29,"in_reply_to":"9878af53_75c8d3d8","updated":"2022-10-10 10:12:33.000000000","message":"true i was not sure how open peole would be to doing the automatic power off if we cant retrieve the key but since i was just providign a usecase form our backlog im not sure if sahid has a usecasuse that requried manually selecting the target state.\n\nif sahid\u0027s usecase turns out to also be encrypted volume i would have no issue with making this automatic instead of doing the api change.\n\nfor instance ha as implemented by ooo you have to tag the vms with the action to perform to recorver. so i would expect that you could also extend that with a target state if needed but i get your point that if the openstack cloud is manitnated by seperatly form the server it runs on the lab tech that is doing the kernel patching might not know about the encrypted volume limitations. in which cases making it just work woudl be better.","commit_id":"f7fe3d8be06ac4c97d1eb8c69e6b5a5780f10e17"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f89bb479d11bd1ae18d670ee6740b703df7591f4","unresolved":true,"context_lines":[{"line_number":26,"context_line":"private cloud may have necessity to evacuate instances to a"},{"line_number":27,"context_line":"destination host as stopped even if they were running on source host."},{"line_number":28,"context_line":"Some public cloud also prefer to evacuate instances as stopped, like"},{"line_number":29,"context_line":"Amazon AWS."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4bad3939_1df0e9dc","line":29,"in_reply_to":"dc7a99ce_579ccda1","updated":"2022-10-05 11:19:09.000000000","message":"we have a downstream usecase fo this which might help\n\nim not sure of sahid\u0027s specific usecase but ours is for encypted volumes\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1860808\nwhen the encryption key is sotred in barbican by default policy its owned by the user that created the vm and not retirvable by an admin.\n\nif the vm is active then you cant evacuate it as we cant start it properly on the destination.\n\nif we allow evacuating to a target state e.g. Shutdown then the admin coudl evacuate an active instance to the powered off state and the user could later start it.\n\n@sahid\nwe will be closing this rfe and moving it to jira for tacking insted internally so if you see that closed as deferred when you click on it thats why but i am proposing we use this spec to adress that use case assuming we approve it.\n\n@dan do you know of a better way to adres the encypted volume case.\nto me this is a pretty nice way to do that without just making it automatic in that case. i kind of prefer documenting that for encypted voluem you shoudl evacuate to off rahter then automating it but both would enabel it to work.","commit_id":"f7fe3d8be06ac4c97d1eb8c69e6b5a5780f10e17"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cdb3b11b6fa772573270f63ee1fc64b319abc288","unresolved":true,"context_lines":[{"line_number":29,"context_line":"during boot start.  Some public clouds also prefer to evacuate"},{"line_number":30,"context_line":"instances as stopped, like Amazon AWS.  To better manage resources,"},{"line_number":31,"context_line":"private clouds may also prefer to evacuate instances as stopped since"},{"line_number":32,"context_line":"they may not be used anymore but kept active for some reason."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"86d3a767_d30bc152","line":32,"updated":"2022-10-19 10:50:57.000000000","message":"that will save a little power but form a schduler point of view the resouces are still in use so it wont alter the avaiable capasity but it will alter the actual used resouce on the hsot. so yes there is a savign but its not very dramatic.","commit_id":"fa65da285ba0aa8941db070cb0837046e1965cf7"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"921fe9b2aa92303f686be871a20fb5cfe6bcf9e6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"during boot start.  Some public clouds also prefer to evacuate"},{"line_number":30,"context_line":"instances as stopped, like Amazon AWS.  To better manage resources,"},{"line_number":31,"context_line":"private clouds may also prefer to evacuate instances as stopped since"},{"line_number":32,"context_line":"they may not be used anymore but kept active for some reason."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bb4cd763_21b0be64","line":32,"in_reply_to":"86d3a767_d30bc152","updated":"2022-10-27 11:45:19.000000000","message":"Ack","commit_id":"fa65da285ba0aa8941db070cb0837046e1965cf7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cdb3b11b6fa772573270f63ee1fc64b319abc288","unresolved":true,"context_lines":[{"line_number":69,"context_line":"             \"targetState\": \"stop\""},{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Security impact"},{"line_number":75,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1acf6791_3f6d22a9","line":72,"updated":"2022-10-19 10:50:57.000000000","message":"we should proably note that this will return either a 400 or 409 if the rpc version is clamp either manually or automaticaly to below the required version for the targetState parmater.\n\nthis would happen during a upgrade where the compute node has not been upgraded yet or if you manually set the rpc verison in the config.","commit_id":"fa65da285ba0aa8941db070cb0837046e1965cf7"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"921fe9b2aa92303f686be871a20fb5cfe6bcf9e6","unresolved":false,"context_lines":[{"line_number":69,"context_line":"             \"targetState\": \"stop\""},{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Security impact"},{"line_number":75,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"215d27e8_749e7d1c","line":72,"in_reply_to":"1acf6791_3f6d22a9","updated":"2022-10-27 11:45:19.000000000","message":"Done","commit_id":"fa65da285ba0aa8941db070cb0837046e1965cf7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cdb3b11b6fa772573270f63ee1fc64b319abc288","unresolved":true,"context_lines":[{"line_number":100,"context_line":"Developer impact"},{"line_number":101,"context_line":"----------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"None."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Upgrade impact"},{"line_number":106,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d15d7932_9b3aa057","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":4},"updated":"2022-10-19 10:50:57.000000000","message":"this will be changing the virt driver api.\n\nso presumabel your going to do this for the libvirt driver but ideally you should provide an implemantion for all in tree drivers.\n\nif not that should be called out here.","commit_id":"fa65da285ba0aa8941db070cb0837046e1965cf7"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"921fe9b2aa92303f686be871a20fb5cfe6bcf9e6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"Developer impact"},{"line_number":101,"context_line":"----------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"None."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Upgrade impact"},{"line_number":106,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5cf0930d_742aaae0","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":4},"in_reply_to":"c244497c_18218197","updated":"2022-10-27 11:45:19.000000000","message":"I think we are good with this point","commit_id":"fa65da285ba0aa8941db070cb0837046e1965cf7"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4ab30d812c335746dc4eecf7c472da1a744b7266","unresolved":true,"context_lines":[{"line_number":100,"context_line":"Developer impact"},{"line_number":101,"context_line":"----------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"None."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Upgrade impact"},{"line_number":106,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c244497c_18218197","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":4},"in_reply_to":"d15d7932_9b3aa057","updated":"2022-10-19 11:29:22.000000000","message":"Hey based on the current implementation I have done, it looks like we don\u0027t need to change virt driver API.\n\nhttps://review.opendev.org/c/openstack/nova/+/858383/14/nova/compute/manager.py\n\nEverything is working fine using this but let me know if you feel the implementation is not right.","commit_id":"fa65da285ba0aa8941db070cb0837046e1965cf7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0bde819ed6b53c3145654f4fa47eb5f60ae5897f","unresolved":true,"context_lines":[{"line_number":88,"context_line":"---------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"- The nova api-ref will be updated to reflect the changes."},{"line_number":91,"context_line":"- Related to openstack client, nothing is expected to change."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Performance Impact"},{"line_number":94,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c74e07bc_6fff027b","line":91,"updated":"2022-10-27 09:12:44.000000000","message":"you will technially need to add a noop micorversion to it.\nbut thats all its trivial","commit_id":"79579e61679b96ce1d1d483cb96630b3ab811c43"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"921fe9b2aa92303f686be871a20fb5cfe6bcf9e6","unresolved":false,"context_lines":[{"line_number":88,"context_line":"---------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"- The nova api-ref will be updated to reflect the changes."},{"line_number":91,"context_line":"- Related to openstack client, nothing is expected to change."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Performance Impact"},{"line_number":94,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"31e6195b_52166c76","line":91,"in_reply_to":"c74e07bc_6fff027b","updated":"2022-10-27 11:45:19.000000000","message":"Done","commit_id":"79579e61679b96ce1d1d483cb96630b3ab811c43"}]}