)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63a144a56824b1ac3a04fedaa4aaaf80976f7246","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for Napatech LinkVirt SmartNICs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Napatech LinkVirtualization SmartNICs offload network traffic switching, QoS, and tunnel encapsulation/decapsulation functions from the OVS running on the hypervisor to the on-board silicon. This patch updates the Nova source code to include support for a new VIF type corresponding to the virtual devices exposed by the LinkVirtualization SmartNIC."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I2df34bbf4031384e008cbc642ca15291501dfe53"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ea47e80f_07fce4a3","line":9,"updated":"2022-10-26 22:39:22.000000000","message":"so this needs to be wrapped proeprly\n\nbut in generall looking at the code in the https://github.com/napatech/linkvirt-ovs-openstack-plugin\n\nthe main question is why are you adding a new ml2 driver, os-vif plugin and vif_type\n\nwe we could trivially add supprot for virtio-forwarded to the normal ml2/ovs ml2 dirver or ml2/ovn driver for virtio-forwarder.\n\nas far as i can see there is noting vendeor specific so i would prefer to just support virtio-forwarder genericaly unless there is a strong reason not to do  that.\n\nim sure  that this will eventually get supported by upstream ovs so if we do it once now we wont need to update nova or neutron again when that happens with ovs-dpdk upstream","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"20f66cb7eb0e4bb07c74ab42591c1c2ee2802787","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for Napatech LinkVirt SmartNICs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Napatech LinkVirtualization SmartNICs offload network traffic switching, QoS, and tunnel encapsulation/decapsulation functions from the OVS running on the hypervisor to the on-board silicon. This patch updates the Nova source code to include support for a new VIF type corresponding to the virtual devices exposed by the LinkVirtualization SmartNIC."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I2df34bbf4031384e008cbc642ca15291501dfe53"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa1b1df0_baf0df76","line":9,"in_reply_to":"372ba885_e2b94293","updated":"2022-12-15 10:34:30.000000000","message":"the socket name could be computed by neutron and passed to nova as part of the vif binding details.\n\nso if that is all that is required i think the nova side can be kept generic.","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"0d3acdb1d32788ed50936802ee1b8806a161a21d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for Napatech LinkVirt SmartNICs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Napatech LinkVirtualization SmartNICs offload network traffic switching, QoS, and tunnel encapsulation/decapsulation functions from the OVS running on the hypervisor to the on-board silicon. This patch updates the Nova source code to include support for a new VIF type corresponding to the virtual devices exposed by the LinkVirtualization SmartNIC."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I2df34bbf4031384e008cbc642ca15291501dfe53"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"86bd5171_f71011d2","line":9,"in_reply_to":"7fa89459_9d210f53","updated":"2023-03-16 12:07:13.000000000","message":"Done","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2b6b7bf9b96de58d76c85e7f67dba33af27f405f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for Napatech LinkVirt SmartNICs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Napatech LinkVirtualization SmartNICs offload network traffic switching, QoS, and tunnel encapsulation/decapsulation functions from the OVS running on the hypervisor to the on-board silicon. This patch updates the Nova source code to include support for a new VIF type corresponding to the virtual devices exposed by the LinkVirtualization SmartNIC."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I2df34bbf4031384e008cbc642ca15291501dfe53"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f3c78726_56047f8e","line":9,"in_reply_to":"ea47e80f_07fce4a3","updated":"2022-10-26 22:52:20.000000000","message":"upstream ovs-dpdk already has experimental supprot for hardware offloads\n\nhttps://docs.openvswitch.org/en/latest/howto/dpdk/#flow-hardware-offload-experimental\n\nwhich woudl use virtio-forwarder/vhost-user correct.\n\nthe Napatech (NT200B01) is one of the validated drivers  for that\n\nhow does what this spec tries to enable differ from the upstream representor supprot \nhttps://docs.openvswitch.org/en/latest/topics/dpdk/phy/#representors\n\nhttps://github.com/napatech/linkvirt-ovs-openstack-plugin/blob/main/vif_plug_linkvirt_ovs/ovsdb/lv_ovsdb_lib.py#L102-L112\nseams to just be enabling that fucntionaltiy","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"40ba922813ba2da6d8604772fa88615a373c7f34","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for Napatech LinkVirt SmartNICs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Napatech LinkVirtualization SmartNICs offload network traffic switching, QoS, and tunnel encapsulation/decapsulation functions from the OVS running on the hypervisor to the on-board silicon. This patch updates the Nova source code to include support for a new VIF type corresponding to the virtual devices exposed by the LinkVirtualization SmartNIC."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I2df34bbf4031384e008cbc642ca15291501dfe53"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"372ba885_e2b94293","line":9,"in_reply_to":"f3c78726_56047f8e","updated":"2022-11-03 11:37:28.000000000","message":"Hello, Sean\n\nWe\u0027ve implemented a separate driver because we have next specific item in our solution:\n1. We have the next path to the socket: /usr/local/var/run/ and the socket name has the next configuration: stdvio + vf number. So for example, if we use PCI with virtual function 6 ( 0000.2b00.6 ) we will have socket name stdvio6\nYou can see implementation of that here:\nhttps://github.com/napatech/linkvirt-ovs-openstack-plugin/blob/main/networking_napatech/mech_linkvirt_ovs.py#L62","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"e46a090b12a2c2546c4a137cac2ebb5d3a8ee8b4","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for Napatech LinkVirt SmartNICs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Napatech LinkVirtualization SmartNICs offload network traffic switching, QoS, and tunnel encapsulation/decapsulation functions from the OVS running on the hypervisor to the on-board silicon. This patch updates the Nova source code to include support for a new VIF type corresponding to the virtual devices exposed by the LinkVirtualization SmartNIC."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I2df34bbf4031384e008cbc642ca15291501dfe53"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7fa89459_9d210f53","line":9,"in_reply_to":"fa1b1df0_baf0df76","updated":"2023-01-06 21:45:02.000000000","message":"We reworked our approach. \nAccording to the previous comments, custom plugin was removed and ovs driver with virtio-forwarder was extended","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"830ea684fad265b583376f408f37417b5aec2d9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5fb9e8ab_921a86d0","updated":"2022-10-03 13:29:54.000000000","message":"From Neutron perspective, it looks ok, and in sync with what we have for other smartnics. We quickly discussed this during the last drivers meeting:\nhttps://meetings.opendev.org/meetings/neutron_drivers/2022/neutron_drivers.2022-09-30-14.01.log.html#l-74\n\nThe team basically agreed to go this way, and accept nova-spec to continue with neutron patch.","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"023870060608309fe3bdb8485ec588e71abba2f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c07d20d0_a0760530","updated":"2023-01-10 09:32:21.000000000","message":"I don\u0027t see any blocker supporting it. Could you just review the spec to make it conform based on indications? Thanks a lot.","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f73076ea09d02ecf7481402c440d81f5d62b24b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4c499f87_5a3f3f04","updated":"2022-12-15 10:45:07.000000000","message":"if you still intend to proceed with this this cycle please try and rework this to adress the commets inline before teh end fo the week.\n\nTo set expectations most of the core team will be away until spec freeze so its unlikely this will get the rewiew attention required before sepc freeze to proceed this cycle.","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7d9f3f67696f473217df1b2a1e2c0d73ff1a3402","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"581e870e_c2227dcf","updated":"2022-10-18 12:10:28.000000000","message":"ill try and find time to review this in the next week or two\ndependitn on how the ptg goes.\n\ni just wanted to highlight that feature in os-vif are tracked as RFE bugs\nyou only need a spec if you need to change nova/neutron.\n\nso we might be able to do this as a specless blueprint in nova ill add it to the ptg agenda if you have not already done so and we can try and see if this requies a spec.\n\ni am expecting the nova change to be relitivly trivial just passign the extra info to os-vif since you already have an os-vif plugin.\n\na spec would be required if you need to modify the xml generation or do more invasive changes to nova but if its just passing the extra info to os-vif that proably doabel specless.","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":35239,"name":"Justas Poderys","email":"jpo@napatech.com","username":"justas_napa"},"change_message_id":"968b9070b931ef0d83855fd44242504872862a9d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a34fb566_b6403acb","in_reply_to":"5fb9e8ab_921a86d0","updated":"2022-10-03 13:38:31.000000000","message":"Thanks for the update. I will update the missing fields and also documentation (w/ rel. notes) as requested in neutron-lib change.","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"0d3acdb1d32788ed50936802ee1b8806a161a21d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2dbfe673_2999d68c","in_reply_to":"a34fb566_b6403acb","updated":"2023-03-16 12:07:13.000000000","message":"Done","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"432be1b08983c80d5424cb7f4f20bb692aec0064","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"074d7309_23fef572","updated":"2023-03-13 13:17:26.000000000","message":"i have not done a review of this today but i will re review when you update it with our conversation form irc\n\n","commit_id":"efa921b99b9a4a1fac42bef6f1b12866effa0ecb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"20484b65903d84bf4ab58d03dcf22bc2ae1d1af4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"67ace3bc_e1077449","updated":"2023-03-13 13:39:58.000000000","message":"this need a little more context and detail in general.\n\nhaving looked at the code for this feature which is pretty small we dont need the spec to be very long just need more detail to help other cores understand what you are trying to enable.\n\n","commit_id":"efa921b99b9a4a1fac42bef6f1b12866effa0ecb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b2475f07db1cff1e0fb40037ec231db4d92726c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"877c6db8_0f3b1c21","updated":"2023-03-16 13:53:07.000000000","message":"over all im ok with this.\ni would like to get input form other cores who are less familiar with this as they may want more detail on context.\n\ni have looked at the code so my perception on if there is enough detail in the spec is skewed by that extra knowledge \n\nsome minor comments in line","commit_id":"1ce288e9c590a481b6282c940853cdc903bcec24"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d3445e64b2b944818bbe1a4b02ec0dd470e0db08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b0a1749c_3768cdd7","updated":"2023-04-11 14:25:23.000000000","message":"holding +2 because i would like to have rodolfo or other form the neutron team review this and i would also like to see the neutron driver team approve the neutron RFE launchpad bug before approving the spec.\n\noverall the spec is pretty light weight on descirbing the change requried howver this is also a implemention proposed which looks complete and gerneally resaonable.\n\nso if other are ok with this high level overview we could proceed with this direction based on the implemenation.","commit_id":"63e83725eb06ddf7d019f9cb209b4c1081cf90ec"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a8d35205e6e5280657d0c734e4151cc3d2f02f0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c33da22a_941e35e9","updated":"2023-05-09 14:21:38.000000000","message":"Thank you to have applied suggested changes","commit_id":"5760ff2b9537f7d39e703cd612ce2d0b0844aa9a"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"a720ab723f4827789a90e47d40792b7d96716b90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"877694f3_6fb0017d","updated":"2023-05-26 21:59:49.000000000","message":"Other than the comments made by other, just a small nit","commit_id":"3f842fc98c4af3908d99a24b10d594b159f89930"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ee64913af6492a359a9ddef7a88e09b957d08af3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c2f0de1f_2af3b705","updated":"2023-05-31 06:42:26.000000000","message":"Thanks ++","commit_id":"882db8abab1b9b4b2b677a89a077cf5a7a10973f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d59a7c07fcec94ed967980ec35a5c8104cb23de3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"a87e26df_cce51fa5","updated":"2023-07-07 15:05:34.000000000","message":"Even if yesterday was the Spec Freeze, given the Neutron contributors accepted it, I\u0027ll also accept it for Nova.\nThanks.","commit_id":"f62bcfe652dc31e0047fc045b3f25be06bbe8d6a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e8b453ad2ee1016d128c298d950d0a65bde580b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"5e8d3ef3_70749d02","updated":"2023-07-06 18:07:20.000000000","message":"assumign the neutron team agree we can likely approve this and hold merging the code for the third party ci to be running.","commit_id":"f62bcfe652dc31e0047fc045b3f25be06bbe8d6a"}],"specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"023870060608309fe3bdb8485ec588e71abba2f8","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Support Napatech LinkVirtualization SmartNICs"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/example"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Napatech LinkVirtualization SmartNICs offload network traffic switching, QoS,"},{"line_number":14,"context_line":"and tunnel encapsulation/decapsulation functions from the OVS running on the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"31f251bf_bd683ec8","line":11,"updated":"2023-01-10 09:32:21.000000000","message":"nit: This need to be updated","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":35239,"name":"Justas Poderys","email":"jpo@napatech.com","username":"justas_napa"},"change_message_id":"f0d06b547653ffc8a1605249c9580a3f1df0653e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Support Napatech LinkVirtualization SmartNICs"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/example"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Napatech LinkVirtualization SmartNICs offload network traffic switching, QoS,"},{"line_number":14,"context_line":"and tunnel encapsulation/decapsulation functions from the OVS running on the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"97ae8eab_49dc7b3d","line":11,"in_reply_to":"31f251bf_bd683ec8","updated":"2023-01-10 10:00:55.000000000","message":"Done","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63a144a56824b1ac3a04fedaa4aaaf80976f7246","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Napatech LinkVirtualization SmartNICs offload network traffic switching, QoS,"},{"line_number":14,"context_line":"and tunnel encapsulation/decapsulation functions from the OVS running on the"},{"line_number":15,"context_line":"hypervisor to the on-board silicon. This patch updates the Nova source code to"},{"line_number":16,"context_line":"include support for a new VIF type corresponding to the virtual devices exposed"},{"line_number":17,"context_line":"by the LinkVirtualization SmartNIC."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Problem description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c9c4f33d_485ecc27","line":17,"range":{"start_line":15,"start_character":36,"end_line":17,"end_character":35},"updated":"2022-10-26 22:39:22.000000000","message":"this patch is to the spec repo, so no, it does not update the souce code to do that.\n\ni was just remove this final sentence","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"0d3acdb1d32788ed50936802ee1b8806a161a21d","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Napatech LinkVirtualization SmartNICs offload network traffic switching, QoS,"},{"line_number":14,"context_line":"and tunnel encapsulation/decapsulation functions from the OVS running on the"},{"line_number":15,"context_line":"hypervisor to the on-board silicon. This patch updates the Nova source code to"},{"line_number":16,"context_line":"include support for a new VIF type corresponding to the virtual devices exposed"},{"line_number":17,"context_line":"by the LinkVirtualization SmartNIC."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Problem description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dff8ea93_b863c499","line":17,"range":{"start_line":15,"start_character":36,"end_line":17,"end_character":35},"in_reply_to":"c9c4f33d_485ecc27","updated":"2023-03-16 12:07:13.000000000","message":"Done","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63a144a56824b1ac3a04fedaa4aaaf80976f7246","unresolved":true,"context_lines":[{"line_number":22,"context_line":"Napatech SmartNICs can offload several computational resource intensive tasks"},{"line_number":23,"context_line":"from the hypervisor, such as packet switching, QoS enforcement, and V(x)LAN"},{"line_number":24,"context_line":"tunnel encapsulation/decapsulation. This patch includes changes to Nova and"},{"line_number":25,"context_line":"Os-vif codebases to support Napatech SmartNICs out-of-the-box."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This change proposal does not add any new vnic types. The only vnic type"},{"line_number":28,"context_line":"supported by Napatech LinkVirtualization is `virtio-forwarder`."}],"source_content_type":"text/x-rst","patch_set":4,"id":"6899ffca_e61742da","line":25,"updated":"2022-10-26 22:39:22.000000000","message":"we currently supprot virtio_forwarder for AGILIO OVS\nhttps://github.com/openstack/nova/blob/master/nova/network/os_vif_util.py#L371-L394\n\ncan describe a littel how the napatech solution differs.\n\nalso this patch does not change anything.\n\nthe spec descirbes the cahnge required to enable the integration but does nothing by itself","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"0d3acdb1d32788ed50936802ee1b8806a161a21d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Napatech SmartNICs can offload several computational resource intensive tasks"},{"line_number":23,"context_line":"from the hypervisor, such as packet switching, QoS enforcement, and V(x)LAN"},{"line_number":24,"context_line":"tunnel encapsulation/decapsulation. This patch includes changes to Nova and"},{"line_number":25,"context_line":"Os-vif codebases to support Napatech SmartNICs out-of-the-box."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This change proposal does not add any new vnic types. The only vnic type"},{"line_number":28,"context_line":"supported by Napatech LinkVirtualization is `virtio-forwarder`."}],"source_content_type":"text/x-rst","patch_set":4,"id":"2da3bb13_1337f7b6","line":25,"in_reply_to":"6899ffca_e61742da","updated":"2023-03-16 12:07:13.000000000","message":"Done","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63a144a56824b1ac3a04fedaa4aaaf80976f7246","unresolved":true,"context_lines":[{"line_number":25,"context_line":"Os-vif codebases to support Napatech SmartNICs out-of-the-box."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This change proposal does not add any new vnic types. The only vnic type"},{"line_number":28,"context_line":"supported by Napatech LinkVirtualization is `virtio-forwarder`."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9c1131f2_f604182e","line":28,"updated":"2022-10-26 22:39:22.000000000","message":"correct new vnic_types shoudl only be added if it change the interface to the instance. differnt network vendors shoudl share vnic types if and when possibe.\n\nvif_type however can be vendor specific if requried.","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"0d3acdb1d32788ed50936802ee1b8806a161a21d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Os-vif codebases to support Napatech SmartNICs out-of-the-box."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This change proposal does not add any new vnic types. The only vnic type"},{"line_number":28,"context_line":"supported by Napatech LinkVirtualization is `virtio-forwarder`."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"be90372f_c0035947","line":28,"in_reply_to":"9c1131f2_f604182e","updated":"2023-03-16 12:07:13.000000000","message":"Done","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63a144a56824b1ac3a04fedaa4aaaf80976f7246","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* An end user of Napatech SmartNIC should be able to run VMs over the"},{"line_number":34,"context_line":"  hardware-offloaded switch fabric without having to patch OpenStack source"},{"line_number":35,"context_line":"  code."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1c2dd7f2_c81a3275","line":35,"updated":"2022-10-26 22:39:22.000000000","message":"thats not really a usecase.","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"023870060608309fe3bdb8485ec588e71abba2f8","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* An end user of Napatech SmartNIC should be able to run VMs over the"},{"line_number":34,"context_line":"  hardware-offloaded switch fabric without having to patch OpenStack source"},{"line_number":35,"context_line":"  code."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1296e4_4165f7ee","line":35,"in_reply_to":"1c2dd7f2_c81a3275","updated":"2023-01-10 09:32:21.000000000","message":"Yes :-) Please just indicate that as an user of blabla I want to use this super mega cool feature.","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":35239,"name":"Justas Poderys","email":"jpo@napatech.com","username":"justas_napa"},"change_message_id":"f0d06b547653ffc8a1605249c9580a3f1df0653e","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* An end user of Napatech SmartNIC should be able to run VMs over the"},{"line_number":34,"context_line":"  hardware-offloaded switch fabric without having to patch OpenStack source"},{"line_number":35,"context_line":"  code."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7645558a_fe966120","line":35,"in_reply_to":"fa1296e4_4165f7ee","updated":"2023-01-10 10:00:55.000000000","message":"Done","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63a144a56824b1ac3a04fedaa4aaaf80976f7246","unresolved":true,"context_lines":[{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* We propose to add a new VIF type `VIF_TYPE_LV_OVS` and the related VIF"},{"line_number":41,"context_line":"  handling code to a function `nova_to_osvif_vif()`."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* We propose to add a new os-vif `network` property called `network_type`. It"},{"line_number":44,"context_line":"  is used by the LinkVirtualization ML2 driver. Driver code is open-source and"}],"source_content_type":"text/x-rst","patch_set":4,"id":"2a58fab8_4e96a0ff","line":41,"updated":"2022-10-26 22:39:22.000000000","message":"other then the plugin \n\nthe change proposed in https://review.opendev.org/c/openstack/nova/+/859577/1/nova/network/os_vif_util.py apeare to be identical to \nhttps://github.com/openstack/nova/blob/master/nova/network/os_vif_util.py#L380-L390\n\n\ni think i woudl almost prefer to allow the vif plugin name to be passed form neutron to nova so that we can reuse as much of the code as possibel.\n\ni.e. make it so that you only need to change nova if you need to add a new vnic type not a new vif type.\n\n\nlooking at \nhttps://github.com/napatech/linkvirt-ovs-openstack-plugin\nim not sure why we would not just add supprot for virtio-forwarder to the ovs ml2 driver and/or ovn.\n\ni dont see anything napatec specific. \n\nwe also dont need to pass the network type here\nhttps://github.com/napatech/linkvirt-ovs-openstack-plugin/blob/main/networking_napatech/mech_linkvirt_ovs.py#L68\n\nwe can but nova can just get that from the network\nhere https://github.com/openstack/nova/blob/b1958b7cfa6b8aca5b76b3f133627bb733d29f00/nova/network/neutron.py#L3221","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"0d3acdb1d32788ed50936802ee1b8806a161a21d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* We propose to add a new VIF type `VIF_TYPE_LV_OVS` and the related VIF"},{"line_number":41,"context_line":"  handling code to a function `nova_to_osvif_vif()`."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* We propose to add a new os-vif `network` property called `network_type`. It"},{"line_number":44,"context_line":"  is used by the LinkVirtualization ML2 driver. Driver code is open-source and"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5d5dab82_75f30fff","line":41,"in_reply_to":"292faec0_96203172","updated":"2023-03-16 12:07:13.000000000","message":"Done","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"40ba922813ba2da6d8604772fa88615a373c7f34","unresolved":true,"context_lines":[{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* We propose to add a new VIF type `VIF_TYPE_LV_OVS` and the related VIF"},{"line_number":41,"context_line":"  handling code to a function `nova_to_osvif_vif()`."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* We propose to add a new os-vif `network` property called `network_type`. It"},{"line_number":44,"context_line":"  is used by the LinkVirtualization ML2 driver. Driver code is open-source and"}],"source_content_type":"text/x-rst","patch_set":4,"id":"78af0d0e_b987a046","line":41,"in_reply_to":"2a58fab8_4e96a0ff","updated":"2022-11-03 11:37:28.000000000","message":"If Agilio method rewriting is allowed, we can do it in the way, as you suggested.\n\n\nWe can remove the network_type variable from the neutron and does not use it in the OpenStack layer.","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"20f66cb7eb0e4bb07c74ab42591c1c2ee2802787","unresolved":true,"context_lines":[{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* We propose to add a new VIF type `VIF_TYPE_LV_OVS` and the related VIF"},{"line_number":41,"context_line":"  handling code to a function `nova_to_osvif_vif()`."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* We propose to add a new os-vif `network` property called `network_type`. It"},{"line_number":44,"context_line":"  is used by the LinkVirtualization ML2 driver. Driver code is open-source and"}],"source_content_type":"text/x-rst","patch_set":4,"id":"292faec0_96203172","line":41,"in_reply_to":"78af0d0e_b987a046","updated":"2022-12-15 10:34:30.000000000","message":"if the change is additive then yes if not then we need to have two ways of doing this.","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f73076ea09d02ecf7481402c440d81f5d62b24b","unresolved":true,"context_lines":[{"line_number":100,"context_line":"--------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Os-vif change includes code to handle differences object version 1.1 and 1.2 ("},{"line_number":103,"context_line":"addition of `network_type` key.)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Implementation"},{"line_number":106,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"e6c30d0f_0736fa31","line":103,"updated":"2022-12-15 10:45:07.000000000","message":"this isnt really and upgrade impact it should be moved the the propsoed changes section.  the min version of os-vif will need to be increased in nova requirements file to enable this but again that is not conisdered and upgrade impact so we can just list \"None\" here.","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"0d3acdb1d32788ed50936802ee1b8806a161a21d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"--------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Os-vif change includes code to handle differences object version 1.1 and 1.2 ("},{"line_number":103,"context_line":"addition of `network_type` key.)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Implementation"},{"line_number":106,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"469a2608_333d24fb","line":103,"in_reply_to":"e6c30d0f_0736fa31","updated":"2023-03-16 12:07:13.000000000","message":"Done","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"830ea684fad265b583376f408f37417b5aec2d9a","unresolved":true,"context_lines":[{"line_number":108,"context_line":"Assignee(s)"},{"line_number":109,"context_line":"-----------"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"TBD"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Feature Liaison"},{"line_number":114,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"15da236e_e9b6c0c3","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":3},"updated":"2022-10-03 13:29:54.000000000","message":"Please fill this field","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"023870060608309fe3bdb8485ec588e71abba2f8","unresolved":true,"context_lines":[{"line_number":108,"context_line":"Assignee(s)"},{"line_number":109,"context_line":"-----------"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"TBD"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Feature Liaison"},{"line_number":114,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"21ebf2ec_c892a681","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":3},"in_reply_to":"133025f9_0377a02e","updated":"2023-01-10 09:32:21.000000000","message":"is not the launchpad id?","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f73076ea09d02ecf7481402c440d81f5d62b24b","unresolved":true,"context_lines":[{"line_number":108,"context_line":"Assignee(s)"},{"line_number":109,"context_line":"-----------"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"TBD"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Feature Liaison"},{"line_number":114,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"133025f9_0377a02e","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":3},"in_reply_to":"15da236e_e9b6c0c3","updated":"2022-12-15 10:45:07.000000000","message":"yes please add you irc nic or gerrit username here.","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":35239,"name":"Justas Poderys","email":"jpo@napatech.com","username":"justas_napa"},"change_message_id":"f0d06b547653ffc8a1605249c9580a3f1df0653e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"Assignee(s)"},{"line_number":109,"context_line":"-----------"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"TBD"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Feature Liaison"},{"line_number":114,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c01fff85_ab32bf09","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":3},"in_reply_to":"21ebf2ec_c892a681","updated":"2023-01-10 10:00:55.000000000","message":"Done","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63a144a56824b1ac3a04fedaa4aaaf80976f7246","unresolved":true,"context_lines":[{"line_number":118,"context_line":"Work Items"},{"line_number":119,"context_line":"----------"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"* Nova change proposal:"},{"line_number":122,"context_line":"  https://review.opendev.org/c/openstack/nova/+/859577"},{"line_number":123,"context_line":"* Os-vif change proposal:"},{"line_number":124,"context_line":"  https://review.opendev.org/c/openstack/os-vif/+/859574"}],"source_content_type":"text/x-rst","patch_set":4,"id":"0220ebf0_c7b82371","line":121,"updated":"2022-10-26 22:39:22.000000000","message":"so technially you are not actully ment to start wrighting the code until after the spec is approved in general since the design can change radically in spec review.\nso in generally we dont include link to reviews in the spec.","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"0d3acdb1d32788ed50936802ee1b8806a161a21d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"Work Items"},{"line_number":119,"context_line":"----------"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"* Nova change proposal:"},{"line_number":122,"context_line":"  https://review.opendev.org/c/openstack/nova/+/859577"},{"line_number":123,"context_line":"* Os-vif change proposal:"},{"line_number":124,"context_line":"  https://review.opendev.org/c/openstack/os-vif/+/859574"}],"source_content_type":"text/x-rst","patch_set":4,"id":"210d6b74_4c70d478","line":121,"in_reply_to":"0220ebf0_c7b82371","updated":"2023-03-16 12:07:13.000000000","message":"Done","commit_id":"679d5f2b2f0a9faaa6689462442cd903ebb779dc"}],"specs/2023.2/approved/napatech-linkvirtualization-smartnic-support.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"20484b65903d84bf4ab58d03dcf22bc2ae1d1af4","unresolved":true,"context_lines":[{"line_number":23,"context_line":"from the hypervisor, such as packet switching, QoS enforcement, and V(x)LAN"},{"line_number":24,"context_line":"tunnel encapsulation/decapsulation. This patch includes changes to Nova and"},{"line_number":25,"context_line":"Os-vif codebases to support Napatech SmartNICs out-of-the-box."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This change proposal does not add any new vnic types. The only vnic type"},{"line_number":28,"context_line":"supported by Napatech LinkVirtualization is `virtio-forwarder`."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"f82f9bce_063aad4e","line":26,"updated":"2023-03-13 13:39:58.000000000","message":"Napatech SmartNICs can offload several computational resource-intensive tasks\nfrom the hypervisor, such as packet switching, QoS enforcement, and V(x)LAN\ntunnel encapsulation/decapsulation. Upstream and Out of tree OVS implementations can leverage these offloads when using dpdk via dpdk port representors.\nhttps://docs.openvswitch.org/en/latest/topics/dpdk/phy/#representors\n\nnova and os-vif currently support kernel-based vf representors but not dpdk vf representors which leverage vhost-user socket. This spec seeks to address that gap.","commit_id":"efa921b99b9a4a1fac42bef6f1b12866effa0ecb"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"3134fcd0e442f38d019b59df4ec1a646219ea17e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from the hypervisor, such as packet switching, QoS enforcement, and V(x)LAN"},{"line_number":24,"context_line":"tunnel encapsulation/decapsulation. This patch includes changes to Nova and"},{"line_number":25,"context_line":"Os-vif codebases to support Napatech SmartNICs out-of-the-box."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This change proposal does not add any new vnic types. The only vnic type"},{"line_number":28,"context_line":"supported by Napatech LinkVirtualization is `virtio-forwarder`."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"067790a4_489a2526","line":26,"in_reply_to":"f82f9bce_063aad4e","updated":"2023-03-16 12:06:51.000000000","message":"Done","commit_id":"efa921b99b9a4a1fac42bef6f1b12866effa0ecb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"20484b65903d84bf4ab58d03dcf22bc2ae1d1af4","unresolved":true,"context_lines":[{"line_number":24,"context_line":"tunnel encapsulation/decapsulation. This patch includes changes to Nova and"},{"line_number":25,"context_line":"Os-vif codebases to support Napatech SmartNICs out-of-the-box."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This change proposal does not add any new vnic types. The only vnic type"},{"line_number":28,"context_line":"supported by Napatech LinkVirtualization is `virtio-forwarder`."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1528a33b_197ace6a","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":63},"updated":"2023-03-13 13:39:58.000000000","message":"this shoudl be in proposed changes section.\n\nProblem description is the \"what we want to change\"\n\nUse Cases is the \"why we want to change it\"\n\nand  Proposed change is the \"how we want to change it\"\n\nso this is part of the \"how\" not the \"what\"","commit_id":"efa921b99b9a4a1fac42bef6f1b12866effa0ecb"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"3134fcd0e442f38d019b59df4ec1a646219ea17e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"tunnel encapsulation/decapsulation. This patch includes changes to Nova and"},{"line_number":25,"context_line":"Os-vif codebases to support Napatech SmartNICs out-of-the-box."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This change proposal does not add any new vnic types. The only vnic type"},{"line_number":28,"context_line":"supported by Napatech LinkVirtualization is `virtio-forwarder`."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"f2f690ad_8f3fb3c6","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":63},"in_reply_to":"1528a33b_197ace6a","updated":"2023-03-16 12:06:51.000000000","message":"Done","commit_id":"efa921b99b9a4a1fac42bef6f1b12866effa0ecb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"20484b65903d84bf4ab58d03dcf22bc2ae1d1af4","unresolved":true,"context_lines":[{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* We propose to add a new VIF type `VIF_TYPE_LV_OVS` and the related VIF"},{"line_number":40,"context_line":"  handling code to a function `nova_to_osvif_vif()`."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* We propose to add a new os-vif `network` property called `network_type`. It"},{"line_number":43,"context_line":"  is used by the LinkVirtualization ML2 driver. Driver code is open-source and"}],"source_content_type":"text/x-rst","patch_set":6,"id":"01d843e3_edc3d518","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":52},"updated":"2023-03-13 13:39:58.000000000","message":"right so this has change now we are not adding any new vnic or vif type just adding virtio-forwarder supprot to the ovs vif type","commit_id":"efa921b99b9a4a1fac42bef6f1b12866effa0ecb"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"3134fcd0e442f38d019b59df4ec1a646219ea17e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* We propose to add a new VIF type `VIF_TYPE_LV_OVS` and the related VIF"},{"line_number":40,"context_line":"  handling code to a function `nova_to_osvif_vif()`."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* We propose to add a new os-vif `network` property called `network_type`. It"},{"line_number":43,"context_line":"  is used by the LinkVirtualization ML2 driver. Driver code is open-source and"}],"source_content_type":"text/x-rst","patch_set":6,"id":"4ee61695_92a885b6","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":52},"in_reply_to":"01d843e3_edc3d518","updated":"2023-03-16 12:06:51.000000000","message":"Done","commit_id":"efa921b99b9a4a1fac42bef6f1b12866effa0ecb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"20484b65903d84bf4ab58d03dcf22bc2ae1d1af4","unresolved":true,"context_lines":[{"line_number":81,"context_line":"------------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Users will see a significant network performance increase when running over"},{"line_number":84,"context_line":"the hardware offloaded data-plane."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Other deployer impact"},{"line_number":87,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ede0903d_e6e063d2","line":84,"updated":"2023-03-13 13:39:58.000000000","message":"well it shoudl be about the same as normal hardware offloaded OVS\n\nbut yes vs kernel ovs or even tradtional vhost-user it should increase","commit_id":"efa921b99b9a4a1fac42bef6f1b12866effa0ecb"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"3134fcd0e442f38d019b59df4ec1a646219ea17e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"------------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Users will see a significant network performance increase when running over"},{"line_number":84,"context_line":"the hardware offloaded data-plane."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Other deployer impact"},{"line_number":87,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5bc7a591_9808309a","line":84,"in_reply_to":"ede0903d_e6e063d2","updated":"2023-03-16 12:06:51.000000000","message":"Done","commit_id":"efa921b99b9a4a1fac42bef6f1b12866effa0ecb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"20484b65903d84bf4ab58d03dcf22bc2ae1d1af4","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"In line with other SmartNIC offerings, the deployer will have to configure"},{"line_number":90,"context_line":"OVS-DPDK following the SmartNIC producer guidelines and update the PCI"},{"line_number":91,"context_line":"whitelist configuration."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Developer impact"},{"line_number":94,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"f26ad823_53d165b0","line":91,"updated":"2023-03-13 13:39:58.000000000","message":"we renamed the passthrough_whitelist\n[pci]\npassthrough_whitelist\nto\n[pci]\ndevice_spec\nso we shoudl use this instead\nhttps://docs.openstack.org/nova/latest/configuration/config.html#pci.device_spec\n\n\nThis solution is using dpdk vdevs\n\nin the past dpdk used to have a limit of 32 of these due to the number of bits allcoated to the the dpdk interface index in the the mbuf structure\n\nhas that been fixed yet?\n\nif there are limits in the number of ports imposed by ovs/dpdk beyond the number of VFs that can be allocated on a nic we should call this out.\n\nbascially we dont want operators thinkign if they need more prots they can just add an addtion nic if that wont actully work.","commit_id":"efa921b99b9a4a1fac42bef6f1b12866effa0ecb"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"3134fcd0e442f38d019b59df4ec1a646219ea17e","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"In line with other SmartNIC offerings, the deployer will have to configure"},{"line_number":90,"context_line":"OVS-DPDK following the SmartNIC producer guidelines and update the PCI"},{"line_number":91,"context_line":"whitelist configuration."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Developer impact"},{"line_number":94,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"01fa804d_b4eea7ac","line":91,"in_reply_to":"f26ad823_53d165b0","updated":"2023-03-16 12:06:51.000000000","message":"Done","commit_id":"efa921b99b9a4a1fac42bef6f1b12866effa0ecb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"20484b65903d84bf4ab58d03dcf22bc2ae1d1af4","unresolved":true,"context_lines":[{"line_number":99,"context_line":"--------------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Os-vif change includes code to handle differences object version 1.1 and 1.2 ("},{"line_number":102,"context_line":"addition of `network_type` key.)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Implementation"},{"line_number":105,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"53874112_02ecd861","line":102,"updated":"2023-03-13 13:39:58.000000000","message":"ack\nform a nova presepctive there really isnt any other than\nfor this to work you need to have updated nova, os-vif and neutorn to a version that supprot the feature.","commit_id":"efa921b99b9a4a1fac42bef6f1b12866effa0ecb"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"3134fcd0e442f38d019b59df4ec1a646219ea17e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"--------------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Os-vif change includes code to handle differences object version 1.1 and 1.2 ("},{"line_number":102,"context_line":"addition of `network_type` key.)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Implementation"},{"line_number":105,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"e4d510f3_a2f4729c","line":102,"in_reply_to":"53874112_02ecd861","updated":"2023-03-16 12:06:51.000000000","message":"Done","commit_id":"efa921b99b9a4a1fac42bef6f1b12866effa0ecb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"20484b65903d84bf4ab58d03dcf22bc2ae1d1af4","unresolved":true,"context_lines":[{"line_number":115,"context_line":"Feature Liaison"},{"line_number":116,"context_line":"---------------"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"TBD"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Work Items"},{"line_number":121,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7360d87d_436c1568","line":118,"updated":"2023-03-13 13:39:58.000000000","message":"i can act as a Liaison for this if you liek\n\n\"sean-k-mooney\"","commit_id":"efa921b99b9a4a1fac42bef6f1b12866effa0ecb"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"3134fcd0e442f38d019b59df4ec1a646219ea17e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"Feature Liaison"},{"line_number":116,"context_line":"---------------"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"TBD"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Work Items"},{"line_number":121,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"96b4c13b_5779c4bc","line":118,"in_reply_to":"7360d87d_436c1568","updated":"2023-03-16 12:06:51.000000000","message":"Done","commit_id":"efa921b99b9a4a1fac42bef6f1b12866effa0ecb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b74bf7f849b3ecf5b3b2a7cbc844a0d76c94a823","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Support Napatech LinkVirtualization SmartNICs"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/support-napatech-linkvirtualization-smartnic"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Napatech LinkVirtualization SmartNICs offload network traffic switching, QoS,"},{"line_number":14,"context_line":"and tunnel encapsulation/decapsulation functions from the OVS running on the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"d6881bc6_01cb95f3","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":88},"updated":"2023-04-01 14:43:26.000000000","message":"the file name shoudl match the last segment of the blueprint url\n\nso this file should be called support-napatech-linkvirtualization-smartnic.rst","commit_id":"1ce288e9c590a481b6282c940853cdc903bcec24"},{"author":{"_account_id":35239,"name":"Justas Poderys","email":"jpo@napatech.com","username":"justas_napa"},"change_message_id":"08f694434d94fc40c93954fe8d4590c1703f30c6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Support Napatech LinkVirtualization SmartNICs"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/support-napatech-linkvirtualization-smartnic"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Napatech LinkVirtualization SmartNICs offload network traffic switching, QoS,"},{"line_number":14,"context_line":"and tunnel encapsulation/decapsulation functions from the OVS running on the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"b92da5f9_7edff357","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":88},"in_reply_to":"d6881bc6_01cb95f3","updated":"2023-04-11 13:50:51.000000000","message":"Done","commit_id":"1ce288e9c590a481b6282c940853cdc903bcec24"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b2475f07db1cff1e0fb40037ec231db4d92726c8","unresolved":true,"context_lines":[{"line_number":150,"context_line":"* This blueprint is a prerequisite to update code in Neutron to support"},{"line_number":151,"context_line":"  LinkVirtualization SmartNICs. This is in-line with support of other"},{"line_number":152,"context_line":"  SmartNICs. Links to changes of all four components are given in the Work"},{"line_number":153,"context_line":"  Items section."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ca8ea537_0462a5ea","line":153,"updated":"2023-03-16 13:53:07.000000000","message":"well yes and no\n\nthe specs need to be accepted by nova and neutorn and then the nova code can be merged after the supprot in neutron lands.\n\nlets talks to the neutron team about this in the nova/neutron cross project session at the ptg.","commit_id":"1ce288e9c590a481b6282c940853cdc903bcec24"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b2475f07db1cff1e0fb40037ec231db4d92726c8","unresolved":true,"context_lines":[{"line_number":156,"context_line":"Testing"},{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Code changes include unit-tests."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"8a572495_e5904ca0","line":159,"updated":"2023-03-16 13:53:07.000000000","message":"you likely shoudl also add some level of functional tests coverage too.\n\nideally napatech would also try and provide third party ci for this\nto test it with real hardware on an ongoing basis.\n\ni dont think we should block on having it in place but its stongly encuraged.\n\nin the psat we have required this to be inplace\n\nwe required it for the orginal ovs-dpdk supprot and smatnic enabling but this is just a small tweak to hte current supprot not an entrily new feature so there is less risk.","commit_id":"1ce288e9c590a481b6282c940853cdc903bcec24"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"cbb93d3d01640dca37198358da7d781f4857c63e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"Testing"},{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Code changes include unit-tests."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ab39c07c_29b607a7","line":159,"in_reply_to":"82ed6d63_2b50c57c","updated":"2023-05-05 08:44:45.000000000","message":"Done","commit_id":"1ce288e9c590a481b6282c940853cdc903bcec24"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"9d3c1c352afe023c9708c8ed3c17df87f63483a7","unresolved":true,"context_lines":[{"line_number":156,"context_line":"Testing"},{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Code changes include unit-tests."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"e60c6ecf_ec1a9283","line":159,"in_reply_to":"8a572495_e5904ca0","updated":"2023-03-20 14:42:23.000000000","message":"Thank you for the comment. We will be able to address it in one of our future releases.","commit_id":"1ce288e9c590a481b6282c940853cdc903bcec24"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"f2bf29dbbef61f228b578a19b8db1b0efe8bab0d","unresolved":true,"context_lines":[{"line_number":156,"context_line":"Testing"},{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Code changes include unit-tests."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"82ed6d63_2b50c57c","line":159,"in_reply_to":"e60c6ecf_ec1a9283","updated":"2023-03-20 15:23:09.000000000","message":"Done","commit_id":"1ce288e9c590a481b6282c940853cdc903bcec24"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b2475f07db1cff1e0fb40037ec231db4d92726c8","unresolved":true,"context_lines":[{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"We are not introducing any new VNIC type, so there should be no impact on"},{"line_number":166,"context_line":"documentation."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":8,"id":"52ce9be3_2ecff32a","line":166,"updated":"2023-03-16 13:53:07.000000000","message":"not on existing documentation but i woudl epect new documenation to be writen to describe how to configure this.\n\nthis should likely be in neutron.\nhttps://docs.openstack.org/neutron/latest/admin/config-ovs-offload.html\n\nyou should extend that with any requriement for ovs-dpdk hardware offload.","commit_id":"1ce288e9c590a481b6282c940853cdc903bcec24"}],"specs/2023.2/approved/support-napatech-linkvirtualization-smartnic.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d3445e64b2b944818bbe1a4b02ec0dd470e0db08","unresolved":true,"context_lines":[{"line_number":25,"context_line":"implementations can leverage these offloads when using dpdk via DPDK port"},{"line_number":26,"context_line":"representors (https://docs.openvswitch.org/en/latest/topics/dpdk/phy/#representors)."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Nova and Os-vif currently support kernel-based VF representors, but not the"},{"line_number":29,"context_line":"DPDK VF representors which leverage vhost-user socket. This spec seeks to"},{"line_number":30,"context_line":"address this gap."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"402f3f99_8a4b0e97","line":28,"range":{"start_line":28,"start_character":9,"end_line":28,"end_character":16},"updated":"2023-04-11 14:25:23.000000000","message":"nit: os-vif\n\nwe do not capitalize the o but no need to fix this unless you respine the patch for some other reason","commit_id":"63e83725eb06ddf7d019f9cb209b4c1081cf90ec"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"cbb93d3d01640dca37198358da7d781f4857c63e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"implementations can leverage these offloads when using dpdk via DPDK port"},{"line_number":26,"context_line":"representors (https://docs.openvswitch.org/en/latest/topics/dpdk/phy/#representors)."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Nova and Os-vif currently support kernel-based VF representors, but not the"},{"line_number":29,"context_line":"DPDK VF representors which leverage vhost-user socket. This spec seeks to"},{"line_number":30,"context_line":"address this gap."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"f044ae21_cb1b87b1","line":28,"range":{"start_line":28,"start_character":9,"end_line":28,"end_character":16},"in_reply_to":"402f3f99_8a4b0e97","updated":"2023-05-05 08:44:45.000000000","message":"Done","commit_id":"63e83725eb06ddf7d019f9cb209b4c1081cf90ec"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d3445e64b2b944818bbe1a4b02ec0dd470e0db08","unresolved":true,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"An alternative is not to support LinkVirtualization adapters with DPDK VF"},{"line_number":65,"context_line":"representor port based on the hardware offloaded data-plane and require users"},{"line_number":66,"context_line":"to patch OpenStack source code."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Data model impact"},{"line_number":69,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"80627f60_5dd664bc","line":66,"updated":"2023-04-11 14:25:23.000000000","message":"this is not really an alternitive.\n\nrunning a fork of openstack is not a alternitive to adding a feature to it.\n\na valid but overly complicated alternitive would be to use cyborg to enabel this usecause.","commit_id":"63e83725eb06ddf7d019f9cb209b4c1081cf90ec"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"cbb93d3d01640dca37198358da7d781f4857c63e","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"An alternative is not to support LinkVirtualization adapters with DPDK VF"},{"line_number":65,"context_line":"representor port based on the hardware offloaded data-plane and require users"},{"line_number":66,"context_line":"to patch OpenStack source code."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Data model impact"},{"line_number":69,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"184e0478_a9d96ba1","line":66,"in_reply_to":"80627f60_5dd664bc","updated":"2023-05-05 08:44:45.000000000","message":"Done","commit_id":"63e83725eb06ddf7d019f9cb209b4c1081cf90ec"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6d3fb9bd46c622360a39b92df447ab9b4bf2e0c2","unresolved":true,"context_lines":[{"line_number":50,"context_line":"  virtio-forwarder vnic type:"},{"line_number":51,"context_line":"  https://docs.openvswitch.org/en/latest/topics/dpdk/phy/#representors."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* We propose to extend `OVS_DPDK_PORT_TYPES` with a new port type `dpdk`."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* We propose to update the `OvsPlugin` class to support plug and unplug of OVS"},{"line_number":56,"context_line":"  DPDK representor ports."}],"source_content_type":"text/x-rst","patch_set":10,"id":"c4347099_1236878c","line":53,"updated":"2023-05-05 14:31:04.000000000","message":"Already merged, right?","commit_id":"a95069d093d29e12379368120c1037d484d3eb63"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"c8c804e3da86977d8ef1d944ac8c5927933985e1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  virtio-forwarder vnic type:"},{"line_number":51,"context_line":"  https://docs.openvswitch.org/en/latest/topics/dpdk/phy/#representors."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* We propose to extend `OVS_DPDK_PORT_TYPES` with a new port type `dpdk`."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* We propose to update the `OvsPlugin` class to support plug and unplug of OVS"},{"line_number":56,"context_line":"  DPDK representor ports."}],"source_content_type":"text/x-rst","patch_set":10,"id":"f96051e8_4049d99f","line":53,"in_reply_to":"c4347099_1236878c","updated":"2023-05-08 14:11:40.000000000","message":"Yes, it was a part of this proposal ( neutron-lib library). This was merged yesterday by the Neutron team","commit_id":"a95069d093d29e12379368120c1037d484d3eb63"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6d3fb9bd46c622360a39b92df447ab9b4bf2e0c2","unresolved":true,"context_lines":[{"line_number":132,"context_line":"Work Items"},{"line_number":133,"context_line":"----------"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"* Nova change proposal:"},{"line_number":136,"context_line":"  https://review.opendev.org/c/openstack/nova/+/859577"},{"line_number":137,"context_line":"* Os-vif change proposal:"},{"line_number":138,"context_line":"  https://review.opendev.org/c/openstack/os-vif/+/859574"}],"source_content_type":"text/x-rst","patch_set":10,"id":"6979e435_315177b6","line":135,"updated":"2023-05-05 14:31:04.000000000","message":"nit: I think you want to refer the work  that will be needed but the not patches or gerrit changes related as you may need some more (this may happen).\n\nYou want for example indicate the kind of changes needed in Nova, Neutron, osvif...","commit_id":"a95069d093d29e12379368120c1037d484d3eb63"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"c8c804e3da86977d8ef1d944ac8c5927933985e1","unresolved":false,"context_lines":[{"line_number":132,"context_line":"Work Items"},{"line_number":133,"context_line":"----------"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"* Nova change proposal:"},{"line_number":136,"context_line":"  https://review.opendev.org/c/openstack/nova/+/859577"},{"line_number":137,"context_line":"* Os-vif change proposal:"},{"line_number":138,"context_line":"  https://review.opendev.org/c/openstack/os-vif/+/859574"}],"source_content_type":"text/x-rst","patch_set":10,"id":"20346974_a2f5a1aa","line":135,"in_reply_to":"6979e435_315177b6","updated":"2023-05-08 14:11:40.000000000","message":"Done","commit_id":"a95069d093d29e12379368120c1037d484d3eb63"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1c3850ff2d712265344d5f56847f75d48e896245","unresolved":true,"context_lines":[{"line_number":50,"context_line":"  virtio-forwarder vnic type:"},{"line_number":51,"context_line":"  https://docs.openvswitch.org/en/latest/topics/dpdk/phy/#representors."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* We propose to extend `OVS_DPDK_PORT_TYPES` with a new port type `dpdk`."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* We propose to update the `OvsPlugin` class to support plug and unplug of OVS"},{"line_number":56,"context_line":"  DPDK representor ports."}],"source_content_type":"text/x-rst","patch_set":11,"id":"7b798fab_87c0367d","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":73},"updated":"2023-05-18 13:37:50.000000000","message":"nit: be more explicit saying that this is the new VIF type you are proposing","commit_id":"5760ff2b9537f7d39e703cd612ce2d0b0844aa9a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1c3850ff2d712265344d5f56847f75d48e896245","unresolved":true,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* We propose to extend `OVS_DPDK_PORT_TYPES` with a new port type `dpdk`."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* We propose to update the `OvsPlugin` class to support plug and unplug of OVS"},{"line_number":56,"context_line":"  DPDK representor ports."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* We propose unit-tests pertinent to the proposed changes."}],"source_content_type":"text/x-rst","patch_set":11,"id":"91d82d79_e1b89679","line":55,"range":{"start_line":55,"start_character":27,"end_line":55,"end_character":38},"updated":"2023-05-18 13:37:50.000000000","message":"nit: what/where is this class? If you are referring to a library project (os-vif), please mention it\n\nnit2: ``OvsPlugin``\n\nnet3: please explain how a DPDK port representor is plugged and unplugged from OVS","commit_id":"5760ff2b9537f7d39e703cd612ce2d0b0844aa9a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1c3850ff2d712265344d5f56847f75d48e896245","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* We propose unit-tests pertinent to the proposed changes."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Alternatives"},{"line_number":62,"context_line":"------------"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"c4666423_80444dbc","line":60,"updated":"2023-05-18 13:37:50.000000000","message":"Just some questions:\n1) it seems to be a very short spec definition for such an important RFE. Would it be so transparent for OpenStack Nova/Neutron?\n\n2) What hardware does support this feature?","commit_id":"5760ff2b9537f7d39e703cd612ce2d0b0844aa9a"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"e6b3776200f2f70e3c05de587c75b6365207ad7b","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* We propose unit-tests pertinent to the proposed changes."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Alternatives"},{"line_number":62,"context_line":"------------"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"77687e82_3ea1bec6","line":60,"in_reply_to":"41ccbb16_57a63553","updated":"2023-06-01 14:36:13.000000000","message":"We will create a separate document with all the specific steps.\nSomething similar to this: https://docs.openstack.org/neutron/rocky/admin/config-ovs-offload.html\nWe agreed to create a new document because we will have custom NT NIC configuration steps and it will be based on the latest OpenStack release\nPlease take a look at the latest spec-file update and tell us your opinion.","commit_id":"5760ff2b9537f7d39e703cd612ce2d0b0844aa9a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c4af1d6dbbbe018fa459b1b38bd867cce2dffa6c","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* We propose unit-tests pertinent to the proposed changes."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Alternatives"},{"line_number":62,"context_line":"------------"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"e94a2909_775f25af","line":60,"in_reply_to":"77687e82_3ea1bec6","updated":"2023-07-06 16:02:26.000000000","message":"Thanks","commit_id":"5760ff2b9537f7d39e703cd612ce2d0b0844aa9a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d40c74135f961e010fe3282bc42dd7dc1245f1f4","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* We propose unit-tests pertinent to the proposed changes."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Alternatives"},{"line_number":62,"context_line":"------------"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"41ccbb16_57a63553","line":60,"in_reply_to":"c4666423_80444dbc","updated":"2023-05-30 08:00:08.000000000","message":"What about these questions?","commit_id":"5760ff2b9537f7d39e703cd612ce2d0b0844aa9a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1c3850ff2d712265344d5f56847f75d48e896245","unresolved":true,"context_lines":[{"line_number":153,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Code changes will require additional testing coverage:"},{"line_number":156,"context_line":"  New unit tests will be implented ot updated existing."},{"line_number":157,"context_line":"  New functional tests will be implemented."},{"line_number":158,"context_line":"  Napatech will provide third party ci for testing on the NT hardware."},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"8f980962_9965b7e1","line":156,"range":{"start_line":156,"start_character":0,"end_line":156,"end_character":2},"updated":"2023-05-18 13:37:50.000000000","message":"nit: each line should be a new bullet point","commit_id":"5760ff2b9537f7d39e703cd612ce2d0b0844aa9a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1c3850ff2d712265344d5f56847f75d48e896245","unresolved":true,"context_lines":[{"line_number":155,"context_line":"* Code changes will require additional testing coverage:"},{"line_number":156,"context_line":"  New unit tests will be implented ot updated existing."},{"line_number":157,"context_line":"  New functional tests will be implemented."},{"line_number":158,"context_line":"  Napatech will provide third party ci for testing on the NT hardware."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":11,"id":"5f2f0750_bb9f28bd","line":158,"updated":"2023-05-18 13:37:50.000000000","message":"do you know beforehand what are the tests that will be executed in this CI? Just a question, not a requirement for the spec","commit_id":"5760ff2b9537f7d39e703cd612ce2d0b0844aa9a"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"fa0523b13ebcdf3032c2a6c8076bc462427ce88a","unresolved":true,"context_lines":[{"line_number":155,"context_line":"* Code changes will require additional testing coverage:"},{"line_number":156,"context_line":"  New unit tests will be implented ot updated existing."},{"line_number":157,"context_line":"  New functional tests will be implemented."},{"line_number":158,"context_line":"  Napatech will provide third party ci for testing on the NT hardware."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":11,"id":"a7957e19_2d1e1168","line":158,"in_reply_to":"5f2f0750_bb9f28bd","updated":"2023-05-19 10:57:45.000000000","message":"This is a list of tests, which were mentined on the meetings with Neutron and Nova teams:\nTempest smoke tests - smoke  https://github.com/openstack/tempest/blob/master/tox.ini#L287\n\nNetwork API tests - integrated-network https://github.com/openstack/tempest/blob/master/tox.ini#L186\n\ncompute API tests - integrated-compute https://github.com/openstack/tempest/blob/master/tox.ini#L201\n\ntest cover span - cover https://github.com/openstack/tempest/blob/master/tox.ini#L56\n\nattach/detach and move operations - included to integrated-compute\n\nmigration tests - included to integrated-compute\n\nbasic tempest/neutron-tempest-plugin tests - https://github.com/openstack/neutron-tempest-plugin/blob/master/tox.ini\n\nDoes this list is appropriate for you, or we should add something else?\nAlso we will provide additional Unit/Funtional tests for code coverage after code review.","commit_id":"5760ff2b9537f7d39e703cd612ce2d0b0844aa9a"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"a720ab723f4827789a90e47d40792b7d96716b90","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Napatech LinkVirtualization SmartNICs offload network traffic switching, QoS,"},{"line_number":14,"context_line":"and tunnel encapsulation/decapsulation functions from the OVS running on the"},{"line_number":15,"context_line":"hypervisor to the on-board silicon. This patch updates the Nova source code to"},{"line_number":16,"context_line":"include support for a new VIF type corresponding to the virtual devices exposed"},{"line_number":17,"context_line":"by the LinkVirtualization SmartNIC."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"84239685_433b9bc5","line":15,"range":{"start_line":15,"start_character":36,"end_line":15,"end_character":54},"updated":"2023-05-26 21:59:49.000000000","message":"This spec proposes to update","commit_id":"3f842fc98c4af3908d99a24b10d594b159f89930"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ce352d59cefee882ad5893e18ff94c2dbb7f8012","unresolved":true,"context_lines":[{"line_number":54,"context_line":"  new port type `dpdk`."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* We propose to update the ``OvsPlugin`` class to support plug and unplug of"},{"line_number":57,"context_line":"  OVS DPDK representor ports https://encr.pw/uSQfn."},{"line_number":58,"context_line":"  Appropriate methods `plug()` and `unplug()` should be extended with"},{"line_number":59,"context_line":"  ability to plug VF if vif has `VIFPortProfileOVSRepresentor` port profile for"},{"line_number":60,"context_line":"  ``VIFVHostUser``."}],"source_content_type":"text/x-rst","patch_set":14,"id":"8623bc51_3e6fdc41","line":57,"range":{"start_line":57,"start_character":28,"end_line":57,"end_character":50},"updated":"2023-05-24 12:16:57.000000000","message":"this should be in references list, and just a reference here:\n`os_vif OVSPlugin code`_","commit_id":"3f842fc98c4af3908d99a24b10d594b159f89930"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e8b453ad2ee1016d128c298d950d0a65bde580b8","unresolved":true,"context_lines":[{"line_number":201,"context_line":"Code changes will require additional testing coverage:"},{"line_number":202,"context_line":"*  New unit tests will be implented or updated existing."},{"line_number":203,"context_line":"*  New functional tests will be implemented."},{"line_number":204,"context_line":"*  Napatech will provide third party ci for testing on the NT hardware."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":18,"id":"4027d8cd_efca160c","line":204,"updated":"2023-07-06 18:07:20.000000000","message":"+1 i think we should hold merging the code untill we see this but in the interim the unit/funcitonal test shoudl cover most uses cases.","commit_id":"f62bcfe652dc31e0047fc045b3f25be06bbe8d6a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e8b453ad2ee1016d128c298d950d0a65bde580b8","unresolved":true,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"We are not introducing any new VNIC type, so there should be no impact on"},{"line_number":211,"context_line":"documentation."},{"line_number":212,"context_line":""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"References"},{"line_number":215,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":18,"id":"7f3fd684_443c7ebe","line":212,"updated":"2023-07-06 18:07:20.000000000","message":"this is incorrect you need to document the configuration of nova/neutorn and ovs in either the nova docs neutron docs or networking guide.\n\nI\u0027m not going to hold the spec on this point but i do expect you to provide documentation that people could to replicate this with upstream OVS with dpdk","commit_id":"f62bcfe652dc31e0047fc045b3f25be06bbe8d6a"}]}