)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0dfde5c533777e9aeba54536f2e424a83421463a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f32f1285_3c333cbc","updated":"2023-01-10 10:38:12.000000000","message":"I\u0027m definitely OK with this spec, that being said, -1 just because of Sean\u0027s concern about using instance UUID instead of name.\n","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b39f9e31a8040f7db5a0d04c78020680b04978cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"59b2278a_59041e40","updated":"2023-01-12 10:37:04.000000000","message":"Honestly, I think we could have nits but I don\u0027t want to hold this spec until next cycle.","commit_id":"84f2d76e9df5207ae05bbdaf7861c654b339be31"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8c633650c757e86d415ddd913bed99b30c2596a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"19143283_521a889d","updated":"2023-01-12 12:49:36.000000000","message":"Looks good","commit_id":"84f2d76e9df5207ae05bbdaf7861c654b339be31"}],"specs/2023.1/approved/virtiofs_scaphandre.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"68f62aab9dada4e18aa471389f0c9cbca797f2ce","unresolved":true,"context_lines":[{"line_number":56,"context_line":".."},{"line_number":57,"context_line":"  Change the following link to spec website when the spec is approved."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"https://review.opendev.org/c/openstack/nova-specs/+/864206/2/specs/2023.1/approved/libvirt-virtiofs-attach-manila-shares.rst"},{"line_number":60,"context_line":"specification to build the VM XML file including virtiofs settings"},{"line_number":61,"context_line":"(mostly `driver part`__)."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"a6a273d2_bca50417","line":59,"updated":"2022-11-15 14:16:02.000000000","message":"It is approved now","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"fa4da16e7faba4b26969a761372eabcf53b59339","unresolved":true,"context_lines":[{"line_number":56,"context_line":".."},{"line_number":57,"context_line":"  Change the following link to spec website when the spec is approved."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"https://review.opendev.org/c/openstack/nova-specs/+/864206/2/specs/2023.1/approved/libvirt-virtiofs-attach-manila-shares.rst"},{"line_number":60,"context_line":"specification to build the VM XML file including virtiofs settings"},{"line_number":61,"context_line":"(mostly `driver part`__)."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"b9abdfb8_80f6bbcc","line":59,"in_reply_to":"a6a273d2_bca50417","updated":"2022-11-15 17:32:48.000000000","message":"yup","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"38d35fdf28048549c66d0cc99569bebea941d1b1","unresolved":false,"context_lines":[{"line_number":56,"context_line":".."},{"line_number":57,"context_line":"  Change the following link to spec website when the spec is approved."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"https://review.opendev.org/c/openstack/nova-specs/+/864206/2/specs/2023.1/approved/libvirt-virtiofs-attach-manila-shares.rst"},{"line_number":60,"context_line":"specification to build the VM XML file including virtiofs settings"},{"line_number":61,"context_line":"(mostly `driver part`__)."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"2a9b5b8f_b47cdfbe","line":59,"in_reply_to":"b9abdfb8_80f6bbcc","updated":"2023-01-03 13:45:15.000000000","message":"Done","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2eb2c2f05073811b79b188b46ae741d742050933","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. code-block:: text"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  share_local_fs \u003d { \"/var/lib/libvirt/scaphandre/###DOMAIN_NAME###\": \"scaphandre\", \"src_fs_02\": \"mount_tag_02\" }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- If the above configuration option is present starting the compute"},{"line_number":71,"context_line":"  node, add a compute trait ``COMPUTE_SHARE_LOCAL_FS`` specifying the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"96a43629_2c761f51","line":68,"range":{"start_line":68,"start_character":50,"end_line":68,"end_character":67},"updated":"2022-11-15 14:44:45.000000000","message":"we cant includ ethe domain name here\n\nwe can generate folder liek this but we cant take it as a config location.\n\nwe could take the parent director and create teh subfolder with the intance uuid","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"38d35fdf28048549c66d0cc99569bebea941d1b1","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. code-block:: text"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  share_local_fs \u003d { \"/var/lib/libvirt/scaphandre/###DOMAIN_NAME###\": \"scaphandre\", \"src_fs_02\": \"mount_tag_02\" }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- If the above configuration option is present starting the compute"},{"line_number":71,"context_line":"  node, add a compute trait ``COMPUTE_SHARE_LOCAL_FS`` specifying the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"cf8f8998_b3c95e0c","line":68,"range":{"start_line":68,"start_character":50,"end_line":68,"end_character":67},"in_reply_to":"96a43629_2c761f51","updated":"2023-01-03 13:45:15.000000000","message":"Done","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"68f62aab9dada4e18aa471389f0c9cbca797f2ce","unresolved":true,"context_lines":[{"line_number":66,"context_line":".. code-block:: text"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  share_local_fs \u003d { \"/var/lib/libvirt/scaphandre/###DOMAIN_NAME###\": \"scaphandre\", \"src_fs_02\": \"mount_tag_02\" }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- If the above configuration option is present starting the compute"},{"line_number":71,"context_line":"  node, add a compute trait ``COMPUTE_SHARE_LOCAL_FS`` specifying the"},{"line_number":72,"context_line":"  `virtiofs-scaphandre` feature is available on this compute."}],"source_content_type":"text/x-rst","patch_set":6,"id":"c3df1276_0f31e6ad","line":69,"updated":"2022-11-15 14:16:02.000000000","message":"I thought we agreed to only support a single mount per instance. But this example have multiple mounts listed if I understand correctly.","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"38d35fdf28048549c66d0cc99569bebea941d1b1","unresolved":false,"context_lines":[{"line_number":66,"context_line":".. code-block:: text"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  share_local_fs \u003d { \"/var/lib/libvirt/scaphandre/###DOMAIN_NAME###\": \"scaphandre\", \"src_fs_02\": \"mount_tag_02\" }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- If the above configuration option is present starting the compute"},{"line_number":71,"context_line":"  node, add a compute trait ``COMPUTE_SHARE_LOCAL_FS`` specifying the"},{"line_number":72,"context_line":"  `virtiofs-scaphandre` feature is available on this compute."}],"source_content_type":"text/x-rst","patch_set":6,"id":"734bfeb4_ab942596","line":69,"in_reply_to":"2e8b2a34_23add2c2","updated":"2023-01-03 13:45:15.000000000","message":"Done","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"fa4da16e7faba4b26969a761372eabcf53b59339","unresolved":true,"context_lines":[{"line_number":66,"context_line":".. code-block:: text"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  share_local_fs \u003d { \"/var/lib/libvirt/scaphandre/###DOMAIN_NAME###\": \"scaphandre\", \"src_fs_02\": \"mount_tag_02\" }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- If the above configuration option is present starting the compute"},{"line_number":71,"context_line":"  node, add a compute trait ``COMPUTE_SHARE_LOCAL_FS`` specifying the"},{"line_number":72,"context_line":"  `virtiofs-scaphandre` feature is available on this compute."}],"source_content_type":"text/x-rst","patch_set":6,"id":"c349cd97_040606f6","line":69,"in_reply_to":"bd5fb7e0_118871fb","updated":"2022-11-15 17:32:48.000000000","message":"I think we discussed this in the PTG about the the number of file descriptors and we said we only need to use *one* mount per compute.","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e2c4daa9d6f39fbb746d8e9c2f4891e73b573586","unresolved":true,"context_lines":[{"line_number":66,"context_line":".. code-block:: text"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  share_local_fs \u003d { \"/var/lib/libvirt/scaphandre/###DOMAIN_NAME###\": \"scaphandre\", \"src_fs_02\": \"mount_tag_02\" }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- If the above configuration option is present starting the compute"},{"line_number":71,"context_line":"  node, add a compute trait ``COMPUTE_SHARE_LOCAL_FS`` specifying the"},{"line_number":72,"context_line":"  `virtiofs-scaphandre` feature is available on this compute."}],"source_content_type":"text/x-rst","patch_set":6,"id":"2e8b2a34_23add2c2","line":69,"in_reply_to":"c349cd97_040606f6","updated":"2022-11-16 09:46:11.000000000","message":"Sorry, my bad, I misunderstood, for security reasons, let\u0027s just do one mount per instance.","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2eb2c2f05073811b79b188b46ae741d742050933","unresolved":true,"context_lines":[{"line_number":66,"context_line":".. code-block:: text"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  share_local_fs \u003d { \"/var/lib/libvirt/scaphandre/###DOMAIN_NAME###\": \"scaphandre\", \"src_fs_02\": \"mount_tag_02\" }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- If the above configuration option is present starting the compute"},{"line_number":71,"context_line":"  node, add a compute trait ``COMPUTE_SHARE_LOCAL_FS`` specifying the"},{"line_number":72,"context_line":"  `virtiofs-scaphandre` feature is available on this compute."}],"source_content_type":"text/x-rst","patch_set":6,"id":"bd5fb7e0_118871fb","line":69,"in_reply_to":"c3df1276_0f31e6ad","updated":"2022-11-15 14:44:45.000000000","message":"ya i read thsi as two mount too but im not sure how/when the second woudl be used.\n\nif we use a map type here i think we shoudl do automatically create a\nCUSTOM_LOCAL_FS_\u003cmount-name\u003e trait\n\ne.g. CUSTOM_LOCAL_FS_SCAPHANDRE and CUSTOM_LOCAL_FS_MOUNT_TAG_02 traits in this case\n\n\nthen in the flavor you woudl request hw:local_fs\u003dscaphandre,mount_tag_02\nto opt into this feature\n\na prefilter woudl then generate the required traits requsts for COMPUTE_SHARE_LOCAL_FS and any other mount that is requested.","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"fa4da16e7faba4b26969a761372eabcf53b59339","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- If the above configuration option is present starting the compute"},{"line_number":71,"context_line":"  node, add a compute trait ``COMPUTE_SHARE_LOCAL_FS`` specifying the"},{"line_number":72,"context_line":"  `virtiofs-scaphandre` feature is available on this compute."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"- Users can add ``trait:COMPUTE_SHARE_LOCAL_FS\u003drequired`` in either"},{"line_number":75,"context_line":"  extra spec or image properties, and thus nova will configure the VM XML"}],"source_content_type":"text/x-rst","patch_set":6,"id":"087555dc_aea9c1b7","line":72,"updated":"2022-11-15 17:32:48.000000000","message":"++","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"38d35fdf28048549c66d0cc99569bebea941d1b1","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- If the above configuration option is present starting the compute"},{"line_number":71,"context_line":"  node, add a compute trait ``COMPUTE_SHARE_LOCAL_FS`` specifying the"},{"line_number":72,"context_line":"  `virtiofs-scaphandre` feature is available on this compute."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"- Users can add ``trait:COMPUTE_SHARE_LOCAL_FS\u003drequired`` in either"},{"line_number":75,"context_line":"  extra spec or image properties, and thus nova will configure the VM XML"}],"source_content_type":"text/x-rst","patch_set":6,"id":"6f6bf2a1_e05a4d9d","line":72,"in_reply_to":"087555dc_aea9c1b7","updated":"2023-01-03 13:45:15.000000000","message":"Done","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"68f62aab9dada4e18aa471389f0c9cbca797f2ce","unresolved":true,"context_lines":[{"line_number":72,"context_line":"  `virtiofs-scaphandre` feature is available on this compute."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"- Users can add ``trait:COMPUTE_SHARE_LOCAL_FS\u003drequired`` in either"},{"line_number":75,"context_line":"  extra spec or image properties, and thus nova will configure the VM XML"},{"line_number":76,"context_line":"  configuration file to include virtiofs filesystem configuration as defined"},{"line_number":77,"context_line":"  by ``share_local_fs`` configuration option."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"73c8b51a_3d8c4b51","line":75,"range":{"start_line":75,"start_character":34,"end_line":75,"end_character":42},"updated":"2022-11-15 14:16:02.000000000","message":"two things will happen:\n1) nova will schedule the instance to a host that has share_local_fs\n2) nova will mount the directory to the guest","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"38d35fdf28048549c66d0cc99569bebea941d1b1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  `virtiofs-scaphandre` feature is available on this compute."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"- Users can add ``trait:COMPUTE_SHARE_LOCAL_FS\u003drequired`` in either"},{"line_number":75,"context_line":"  extra spec or image properties, and thus nova will configure the VM XML"},{"line_number":76,"context_line":"  configuration file to include virtiofs filesystem configuration as defined"},{"line_number":77,"context_line":"  by ``share_local_fs`` configuration option."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"95cff399_28eaa417","line":75,"range":{"start_line":75,"start_character":34,"end_line":75,"end_character":42},"in_reply_to":"2024835c_2f08a886","updated":"2023-01-03 13:45:15.000000000","message":"Done","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2eb2c2f05073811b79b188b46ae741d742050933","unresolved":true,"context_lines":[{"line_number":72,"context_line":"  `virtiofs-scaphandre` feature is available on this compute."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"- Users can add ``trait:COMPUTE_SHARE_LOCAL_FS\u003drequired`` in either"},{"line_number":75,"context_line":"  extra spec or image properties, and thus nova will configure the VM XML"},{"line_number":76,"context_line":"  configuration file to include virtiofs filesystem configuration as defined"},{"line_number":77,"context_line":"  by ``share_local_fs`` configuration option."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"2024835c_2f08a886","line":75,"range":{"start_line":75,"start_character":34,"end_line":75,"end_character":42},"in_reply_to":"73c8b51a_3d8c4b51","updated":"2022-11-15 14:44:45.000000000","message":"so they can add this but they shoudl not have to ideally.\n\nas noted above the extra_spec/image property that enabels this should be converted by a prefilter to add the trait automatically.\n\ntrait:COMPUTE_SHARE_LOCAL_FS\u003drequired woudl be sufficent to do step 1\n\nbut not step 2\n\nadding the extra spec or image property shoudl be suffiecnt to do step 1 and 2","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"68f62aab9dada4e18aa471389f0c9cbca797f2ce","unresolved":true,"context_lines":[{"line_number":88,"context_line":".. note::"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"   The ###DOMAIN_NAME### in the configuration option will be substitute by"},{"line_number":91,"context_line":"   the VM domain name allowing to pass host directories per domain name."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- As a result, user will be able to mount the compute source directory on"},{"line_number":94,"context_line":"  his VM using the following command line."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba71c94b_28587a2a","line":91,"updated":"2022-11-15 14:16:02.000000000","message":"If the only substitution we support is the DOMAIN_NAME then we can simply do that substitution automatically. I.e. the depolyer only need to specify `/var/lib/libvirt/scaphandre` and nova will make sure that `/var/lib/libvirt/scaphandre/\u003cDOMAIN_NAME\u003e` dir is passed to the guest if the guest is requested it.","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"38d35fdf28048549c66d0cc99569bebea941d1b1","unresolved":false,"context_lines":[{"line_number":88,"context_line":".. note::"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"   The ###DOMAIN_NAME### in the configuration option will be substitute by"},{"line_number":91,"context_line":"   the VM domain name allowing to pass host directories per domain name."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- As a result, user will be able to mount the compute source directory on"},{"line_number":94,"context_line":"  his VM using the following command line."}],"source_content_type":"text/x-rst","patch_set":6,"id":"64785540_0fc3fbfe","line":91,"in_reply_to":"68d4b595_cc998761","updated":"2023-01-03 13:45:15.000000000","message":"Done","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2eb2c2f05073811b79b188b46ae741d742050933","unresolved":true,"context_lines":[{"line_number":88,"context_line":".. note::"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"   The ###DOMAIN_NAME### in the configuration option will be substitute by"},{"line_number":91,"context_line":"   the VM domain name allowing to pass host directories per domain name."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- As a result, user will be able to mount the compute source directory on"},{"line_number":94,"context_line":"  his VM using the following command line."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ed2f2e95_e0456661","line":91,"in_reply_to":"ba71c94b_28587a2a","updated":"2022-11-15 14:44:45.000000000","message":"yep we shoudl take teh parent director to create the shared folder in.\n\nand we shoudl either using the instnace template to generate the folder name or the instnace uuid.\n\nhttps://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.instance_name_template","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"fa4da16e7faba4b26969a761372eabcf53b59339","unresolved":true,"context_lines":[{"line_number":88,"context_line":".. note::"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"   The ###DOMAIN_NAME### in the configuration option will be substitute by"},{"line_number":91,"context_line":"   the VM domain name allowing to pass host directories per domain name."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- As a result, user will be able to mount the compute source directory on"},{"line_number":94,"context_line":"  his VM using the following command line."}],"source_content_type":"text/x-rst","patch_set":6,"id":"68d4b595_cc998761","line":91,"in_reply_to":"ed2f2e95_e0456661","updated":"2022-11-15 17:32:48.000000000","message":"yup, I\u0027d rather prefer to have a specific directory name in the config option value if we do one.","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"68f62aab9dada4e18aa471389f0c9cbca797f2ce","unresolved":true,"context_lines":[{"line_number":123,"context_line":"Security impact"},{"line_number":124,"context_line":"---------------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"The compute node filesystem will be shared read-only."},{"line_number":127,"context_line":"This is to prevent any modification on the host by VM users."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"2b7fa0f7_a554bf6a","line":126,"range":{"start_line":126,"start_character":36,"end_line":126,"end_character":53},"updated":"2022-11-15 14:16:02.000000000","message":"+1","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2eb2c2f05073811b79b188b46ae741d742050933","unresolved":true,"context_lines":[{"line_number":123,"context_line":"Security impact"},{"line_number":124,"context_line":"---------------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"The compute node filesystem will be shared read-only."},{"line_number":127,"context_line":"This is to prevent any modification on the host by VM users."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"53584215_5148ea25","line":126,"range":{"start_line":126,"start_character":36,"end_line":126,"end_character":53},"in_reply_to":"2b7fa0f7_a554bf6a","updated":"2022-11-15 14:44:45.000000000","message":"if we enable this as read only im not sure there is a usecase for addtional mounts\n\nwhen i described usign other moutnts in the ptg i was assuming read/write access with a size contold by a reouce request in the flavor.\n\nso maybe we shoudl focus on the scaphandre usecase","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"38d35fdf28048549c66d0cc99569bebea941d1b1","unresolved":false,"context_lines":[{"line_number":123,"context_line":"Security impact"},{"line_number":124,"context_line":"---------------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"The compute node filesystem will be shared read-only."},{"line_number":127,"context_line":"This is to prevent any modification on the host by VM users."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"8166ced0_bc65505f","line":126,"range":{"start_line":126,"start_character":36,"end_line":126,"end_character":53},"in_reply_to":"3ba622eb_21f3ca6e","updated":"2023-01-03 13:45:15.000000000","message":"Done","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2bbcfde25853090f6713dbbff56fa6e62cd61bac","unresolved":true,"context_lines":[{"line_number":123,"context_line":"Security impact"},{"line_number":124,"context_line":"---------------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"The compute node filesystem will be shared read-only."},{"line_number":127,"context_line":"This is to prevent any modification on the host by VM users."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3ba622eb_21f3ca6e","line":126,"range":{"start_line":126,"start_character":36,"end_line":126,"end_character":53},"in_reply_to":"53584215_5148ea25","updated":"2022-11-15 16:08:38.000000000","message":"lets focus only on scaphandre now with a single read-only mount to keep this simple","commit_id":"c4b8d0e46a5feaf9d358157fee5b02fa457200aa"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"61b8496c4f73729be2afb7ff35e5e4f10297253f","unresolved":true,"context_lines":[{"line_number":25,"context_line":"running on the VM to correctly reports VM and VM associated processes"},{"line_number":26,"context_line":"consumption."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Scaphandre proposed solution to get these data is to mount the directory using"},{"line_number":29,"context_line":"virtiofs in the VM."},{"line_number":30,"context_line":"However, the user can not do that, as it requires the VM XML definition file"},{"line_number":31,"context_line":"to be modified. Nova fully manages this file, and as a result, only nova"}],"source_content_type":"text/x-rst","patch_set":7,"id":"2ea09a87_6a48f36d","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":28},"updated":"2023-01-10 11:04:44.000000000","message":"is it worth linking to the scaphandre docs for this? https://hubblo-org.github.io/scaphandre-documentation/how-to_guides/propagate-metrics-hypervisor-to-vm_qemu-kvm.html","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"7348bb3ce73ee7969599b68d2f889b7a96a44def","unresolved":false,"context_lines":[{"line_number":25,"context_line":"running on the VM to correctly reports VM and VM associated processes"},{"line_number":26,"context_line":"consumption."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Scaphandre proposed solution to get these data is to mount the directory using"},{"line_number":29,"context_line":"virtiofs in the VM."},{"line_number":30,"context_line":"However, the user can not do that, as it requires the VM XML definition file"},{"line_number":31,"context_line":"to be modified. Nova fully manages this file, and as a result, only nova"}],"source_content_type":"text/x-rst","patch_set":7,"id":"329672fe_32c7b4c5","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":28},"in_reply_to":"0a2f2248_526e8a05","updated":"2023-01-11 15:21:33.000000000","message":"Done","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bdf1c3fbbe141c6b118168c6221e902499f23d8c","unresolved":true,"context_lines":[{"line_number":25,"context_line":"running on the VM to correctly reports VM and VM associated processes"},{"line_number":26,"context_line":"consumption."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Scaphandre proposed solution to get these data is to mount the directory using"},{"line_number":29,"context_line":"virtiofs in the VM."},{"line_number":30,"context_line":"However, the user can not do that, as it requires the VM XML definition file"},{"line_number":31,"context_line":"to be modified. Nova fully manages this file, and as a result, only nova"}],"source_content_type":"text/x-rst","patch_set":7,"id":"0a2f2248_526e8a05","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":28},"in_reply_to":"2ea09a87_6a48f36d","updated":"2023-01-10 11:35:30.000000000","message":"it could certainly be added as a refernce","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"64f87b2e3122f6ecc74668fcacfca7fd3c90ccdc","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"To simplify specifications, the feature will be named"},{"line_number":48,"context_line":"`virtiofs-scaphandre`."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Although this feature is implemented to support scaphandre, other tools"},{"line_number":51,"context_line":"could require this need. So the implementation will try to be as generic"},{"line_number":52,"context_line":"as possible."}],"source_content_type":"text/x-rst","patch_set":7,"id":"b26cfe40_380496c8","line":49,"updated":"2023-01-09 21:32:10.000000000","message":"hw:virtiofs_scaphandre and hw_virtiofs_scaphandre\n\ni assume? for flavor extra spec and image property respecivily.\n\n\nim not sure we really want to allow this via image property allow\n\nso we might want to define this as\n\nhw:virtiofs_scaphandre\u003dyes|no|image\n\nand only support hw_virtiofs_scaphandre in the image\nif hw:virtiofs_scaphandre\u003dimage.\n\nthe reason for this restirction is the live migation imact.\n\nthat said we could just document it and allow it in the image but i would like to get input form other on this.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d95c6fdb252ead8297ba71afd3892ec4c8e48e98","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"To simplify specifications, the feature will be named"},{"line_number":48,"context_line":"`virtiofs-scaphandre`."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Although this feature is implemented to support scaphandre, other tools"},{"line_number":51,"context_line":"could require this need. So the implementation will try to be as generic"},{"line_number":52,"context_line":"as possible."}],"source_content_type":"text/x-rst","patch_set":7,"id":"5be1b24a_37944f60","line":49,"in_reply_to":"00a1aa3c_7212270c","updated":"2023-01-10 13:26:19.000000000","message":"we do not neeed to haver scaphandre in the name but we do need either a flavor extra spec of an image property\n\nwe could go with something like\n\nhw:virtiofs_power_metrics and hw_virtiofs_power_metrics\n\nwe could then have a prefilter convert that into a standard trait request when its enabled.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"7348bb3ce73ee7969599b68d2f889b7a96a44def","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"To simplify specifications, the feature will be named"},{"line_number":48,"context_line":"`virtiofs-scaphandre`."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Although this feature is implemented to support scaphandre, other tools"},{"line_number":51,"context_line":"could require this need. So the implementation will try to be as generic"},{"line_number":52,"context_line":"as possible."}],"source_content_type":"text/x-rst","patch_set":7,"id":"2df113f7_39426852","line":49,"in_reply_to":"43f8f598_d25762df","updated":"2023-01-11 15:21:33.000000000","message":"Done","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"9f2b4a09edfeaa2ea2679d20c6f28df97b3ccd43","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"To simplify specifications, the feature will be named"},{"line_number":48,"context_line":"`virtiofs-scaphandre`."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Although this feature is implemented to support scaphandre, other tools"},{"line_number":51,"context_line":"could require this need. So the implementation will try to be as generic"},{"line_number":52,"context_line":"as possible."}],"source_content_type":"text/x-rst","patch_set":7,"id":"43f8f598_d25762df","line":49,"in_reply_to":"5be1b24a_37944f60","updated":"2023-01-10 13:47:07.000000000","message":"I\u0027m OK with a specific image property instead of using the trait.\nThat being said, given virtiofs is related to only libvirt, I\u0027d prefer to just tell \"hw:power_metrics\" then.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0dfde5c533777e9aeba54536f2e424a83421463a","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"To simplify specifications, the feature will be named"},{"line_number":48,"context_line":"`virtiofs-scaphandre`."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Although this feature is implemented to support scaphandre, other tools"},{"line_number":51,"context_line":"could require this need. So the implementation will try to be as generic"},{"line_number":52,"context_line":"as possible."}],"source_content_type":"text/x-rst","patch_set":7,"id":"00a1aa3c_7212270c","line":49,"in_reply_to":"b26cfe40_380496c8","updated":"2023-01-10 10:38:12.000000000","message":"No, I\u0027m against telling \u0027scaphandre\u0027 directly for a image property. See the next phrase, please.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ef0e5c5c00353c5329d5e9a6c36847a8fa45007a","unresolved":true,"context_lines":[{"line_number":71,"context_line":"  extra specs or image properties, and thus 2 things will happen:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  1. Nova will schedule the instance to a host that has share_local_fs."},{"line_number":74,"context_line":"  2. Nova will add the virtiofs settings in the instance XML file as specified"},{"line_number":75,"context_line":"     by the following example."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":".. code-block:: xml"}],"source_content_type":"text/x-rst","patch_set":7,"id":"871d45bd_dfe58b3c","line":74,"updated":"2023-01-10 11:34:32.000000000","message":"1 is correct 2 is not correct.\n\nthe addtion or removal of a trait must never change how the xml is rendered.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"7348bb3ce73ee7969599b68d2f889b7a96a44def","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  extra specs or image properties, and thus 2 things will happen:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  1. Nova will schedule the instance to a host that has share_local_fs."},{"line_number":74,"context_line":"  2. Nova will add the virtiofs settings in the instance XML file as specified"},{"line_number":75,"context_line":"     by the following example."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":".. code-block:: xml"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f096bea_d2947512","line":74,"in_reply_to":"871d45bd_dfe58b3c","updated":"2023-01-11 15:21:33.000000000","message":"Done","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"64f87b2e3122f6ecc74668fcacfca7fd3c90ccdc","unresolved":true,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  \u003cfilesystem type\u003d\u0027mount\u0027 accessmode\u003d\u0027passthrough\u0027\u003e"},{"line_number":80,"context_line":"      \u003cdriver type\u003d\u0027virtiofs\u0027/\u003e"},{"line_number":81,"context_line":"      \u003csource dir\u003d\u0027/var/lib/libvirt/scaphandre/\u003cINSTANCE_NAME\u003e\u0027/\u003e"},{"line_number":82,"context_line":"      \u003ctarget dir\u003d\u0027mount_tag\u0027/\u003e"},{"line_number":83,"context_line":"      \u003creadonly /\u003e"},{"line_number":84,"context_line":"  \u003c/filesystem\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"a4ab912a_ff2cadcb","line":81,"range":{"start_line":81,"start_character":47,"end_line":81,"end_character":63},"updated":"2023-01-09 21:32:10.000000000","message":"i would prefer to use the instance uuid since we dont wnat this to change when the instnace is hard rebooted.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"7348bb3ce73ee7969599b68d2f889b7a96a44def","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  \u003cfilesystem type\u003d\u0027mount\u0027 accessmode\u003d\u0027passthrough\u0027\u003e"},{"line_number":80,"context_line":"      \u003cdriver type\u003d\u0027virtiofs\u0027/\u003e"},{"line_number":81,"context_line":"      \u003csource dir\u003d\u0027/var/lib/libvirt/scaphandre/\u003cINSTANCE_NAME\u003e\u0027/\u003e"},{"line_number":82,"context_line":"      \u003ctarget dir\u003d\u0027mount_tag\u0027/\u003e"},{"line_number":83,"context_line":"      \u003creadonly /\u003e"},{"line_number":84,"context_line":"  \u003c/filesystem\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"c3e26466_ed9426f6","line":81,"range":{"start_line":81,"start_character":47,"end_line":81,"end_character":63},"in_reply_to":"588a3a97_b8f460a9","updated":"2023-01-11 15:21:33.000000000","message":"Done","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0dfde5c533777e9aeba54536f2e424a83421463a","unresolved":true,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  \u003cfilesystem type\u003d\u0027mount\u0027 accessmode\u003d\u0027passthrough\u0027\u003e"},{"line_number":80,"context_line":"      \u003cdriver type\u003d\u0027virtiofs\u0027/\u003e"},{"line_number":81,"context_line":"      \u003csource dir\u003d\u0027/var/lib/libvirt/scaphandre/\u003cINSTANCE_NAME\u003e\u0027/\u003e"},{"line_number":82,"context_line":"      \u003ctarget dir\u003d\u0027mount_tag\u0027/\u003e"},{"line_number":83,"context_line":"      \u003creadonly /\u003e"},{"line_number":84,"context_line":"  \u003c/filesystem\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"588a3a97_b8f460a9","line":81,"range":{"start_line":81,"start_character":47,"end_line":81,"end_character":63},"in_reply_to":"a4ab912a_ff2cadcb","updated":"2023-01-10 10:38:12.000000000","message":"Agreed.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"64f87b2e3122f6ecc74668fcacfca7fd3c90ccdc","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. note::"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"   The \u003cINSTANCE_NAME\u003e is the name reported by `OS-EXT-SRV-ATTR:instance_name`"},{"line_number":89,"context_line":"   which is the common name between qemu(scaphandre) and openstack."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"   The instance name can be defined using the instance_name_template."},{"line_number":92,"context_line":"   https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.instance_name_template"}],"source_content_type":"text/x-rst","patch_set":7,"id":"8f481234_55d39f12","line":89,"range":{"start_line":88,"start_character":3,"end_line":89,"end_character":67},"updated":"2023-01-09 21:32:10.000000000","message":"it is but that change on every reboot with out default name template and it is not unique within a cloud.\n\n\nif scaphandre needs to parse this name in anyway its not a great choice if it also need to be stable.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"17ccbb31f482fbd0361a35c222de24c6f64306ac","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. note::"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"   The \u003cINSTANCE_NAME\u003e is the name reported by `OS-EXT-SRV-ATTR:instance_name`"},{"line_number":89,"context_line":"   which is the common name between qemu(scaphandre) and openstack."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"   The instance name can be defined using the instance_name_template."},{"line_number":92,"context_line":"   https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.instance_name_template"}],"source_content_type":"text/x-rst","patch_set":7,"id":"97b745c3_951061de","line":89,"range":{"start_line":88,"start_character":3,"end_line":89,"end_character":67},"in_reply_to":"1ac2cb6d_4822efcd","updated":"2023-01-10 14:04:35.000000000","message":"I don\u0027t see the problem : Scaphandre can know the instance UUID thanks to cloud-init :\n\nhttps://cloudinit.readthedocs.io/en/latest/topics/faq.html#data\n\n ubuntu@sbauza-devstack1:~$ cat /var/lib/cloud/data/instance-id \n e8408aef-7717-4c35-9298-828dee80906b\n\n\nI would prefer to NOT use instance names as they are mutable.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d95c6fdb252ead8297ba71afd3892ec4c8e48e98","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. note::"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"   The \u003cINSTANCE_NAME\u003e is the name reported by `OS-EXT-SRV-ATTR:instance_name`"},{"line_number":89,"context_line":"   which is the common name between qemu(scaphandre) and openstack."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"   The instance name can be defined using the instance_name_template."},{"line_number":92,"context_line":"   https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.instance_name_template"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ac2cb6d_4822efcd","line":89,"range":{"start_line":88,"start_character":3,"end_line":89,"end_character":67},"in_reply_to":"4459aa31_22af9c60","updated":"2023-01-10 13:26:19.000000000","message":"while i would like to chagne the default of the template it is not something that can be changed on a deployed cloud i am told.\n\nas such i guess we are stuck using the instance name here.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c0c0541685cd79109c035e0f57159d8532e418b1","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. note::"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"   The \u003cINSTANCE_NAME\u003e is the name reported by `OS-EXT-SRV-ATTR:instance_name`"},{"line_number":89,"context_line":"   which is the common name between qemu(scaphandre) and openstack."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"   The instance name can be defined using the instance_name_template."},{"line_number":92,"context_line":"   https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.instance_name_template"}],"source_content_type":"text/x-rst","patch_set":7,"id":"87a51a7d_6b9540a7","line":89,"range":{"start_line":88,"start_character":3,"end_line":89,"end_character":67},"in_reply_to":"57c5c91d_824621df","updated":"2023-01-11 12:02:28.000000000","message":"the name is not imuntable it will cahnge over the lifetime.\n\nwe are talking about the domins name right as seen in virsh list.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"786cba5a7e5c1725d80ccefaefccf918b670bb3f","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. note::"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"   The \u003cINSTANCE_NAME\u003e is the name reported by `OS-EXT-SRV-ATTR:instance_name`"},{"line_number":89,"context_line":"   which is the common name between qemu(scaphandre) and openstack."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"   The instance name can be defined using the instance_name_template."},{"line_number":92,"context_line":"   https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.instance_name_template"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dd1a68fe_2148be49","line":89,"range":{"start_line":88,"start_character":3,"end_line":89,"end_character":67},"in_reply_to":"87a51a7d_6b9540a7","updated":"2023-01-11 13:12:40.000000000","message":"we are talking about the domins name right as seen in virsh list. --\u003e yes","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"af2c5a9aeae7fcca978e12fb7c8fd63d649ceacc","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. note::"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"   The \u003cINSTANCE_NAME\u003e is the name reported by `OS-EXT-SRV-ATTR:instance_name`"},{"line_number":89,"context_line":"   which is the common name between qemu(scaphandre) and openstack."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"   The instance name can be defined using the instance_name_template."},{"line_number":92,"context_line":"   https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.instance_name_template"}],"source_content_type":"text/x-rst","patch_set":7,"id":"4459aa31_22af9c60","line":89,"range":{"start_line":88,"start_character":3,"end_line":89,"end_character":67},"in_reply_to":"8f481234_55d39f12","updated":"2023-01-10 11:42:32.000000000","message":"Scaphandre host agent is not aware of OpenStack. So currently, it relies on the qemu cmdline VM name to create the directory containing power data that the scaphandre agent on the guest will use.\nUnless I\u0027m wrong, if we change the instance_name_template to use the UUID, the qemu VM name will be the UUID. So we could use the UUID as a common reference name.\nSo we could instruct the admin to change instance_name_template accordingly.\nWould it be a possible solution ? Could we also change the default for instance_name_template to use the UUID ?","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"30763dc7f83302b7e86fb404c54d9d57adb404cf","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. note::"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"   The \u003cINSTANCE_NAME\u003e is the name reported by `OS-EXT-SRV-ATTR:instance_name`"},{"line_number":89,"context_line":"   which is the common name between qemu(scaphandre) and openstack."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"   The instance name can be defined using the instance_name_template."},{"line_number":92,"context_line":"   https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.instance_name_template"}],"source_content_type":"text/x-rst","patch_set":7,"id":"57c5c91d_824621df","line":89,"range":{"start_line":88,"start_character":3,"end_line":89,"end_character":67},"in_reply_to":"97b745c3_951061de","updated":"2023-01-11 10:42:55.000000000","message":"OK, after more testing, I now prefer using instance_name (not the display name, neither the hostname which are mutable fields during instance lifecycle) that\u0027s created using instance_name_template, because this field is immutable during the instance life.\n\nI tested with reboot, migrate and shelve, and everytime, the name wasn\u0027t changed.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"7348bb3ce73ee7969599b68d2f889b7a96a44def","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. note::"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"   The \u003cINSTANCE_NAME\u003e is the name reported by `OS-EXT-SRV-ATTR:instance_name`"},{"line_number":89,"context_line":"   which is the common name between qemu(scaphandre) and openstack."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"   The instance name can be defined using the instance_name_template."},{"line_number":92,"context_line":"   https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.instance_name_template"}],"source_content_type":"text/x-rst","patch_set":7,"id":"13c79890_e33b5446","line":89,"range":{"start_line":88,"start_character":3,"end_line":89,"end_character":67},"in_reply_to":"dd1a68fe_2148be49","updated":"2023-01-11 15:21:33.000000000","message":"Done","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"488f09deb53fbfa3619708aa1506acc11641f325","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. note::"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"   The \u003cINSTANCE_NAME\u003e is the name reported by `OS-EXT-SRV-ATTR:instance_name`"},{"line_number":89,"context_line":"   which is the common name between qemu(scaphandre) and openstack."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"   The instance name can be defined using the instance_name_template."},{"line_number":92,"context_line":"   https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.instance_name_template"}],"source_content_type":"text/x-rst","patch_set":7,"id":"de1538a3_57b29032","line":89,"range":{"start_line":88,"start_character":3,"end_line":89,"end_character":67},"in_reply_to":"dd1a68fe_2148be49","updated":"2023-01-11 13:27:12.000000000","message":"then those definetly change over the lift time of the vm as part of hard reboots and move operations.\n\nthat is not stable.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"64f87b2e3122f6ecc74668fcacfca7fd3c90ccdc","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":".. __: https://review.opendev.org/c/openstack/nova/+/833090"},{"line_number":112,"context_line":".. __: https://libvirt.org/kbase/virtiofs.html#other-options-for-vhost-user-memory-setup"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Alternatives"},{"line_number":115,"context_line":"------------"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5de8544a_28efd093","line":113,"updated":"2023-01-09 21:32:10.000000000","message":"using virtio-fs requires a share memory configtion for the vm.\n\ntoday that means using file backed memory or perferably hugepages.\n\nalternitively we coudl add supprot for the mem-fd memory backend.\n\n\ni belvie we already called this out in the manilla share spec but we need to call out these limitation again here.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"7348bb3ce73ee7969599b68d2f889b7a96a44def","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":".. __: https://review.opendev.org/c/openstack/nova/+/833090"},{"line_number":112,"context_line":".. __: https://libvirt.org/kbase/virtiofs.html#other-options-for-vhost-user-memory-setup"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Alternatives"},{"line_number":115,"context_line":"------------"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"c11c3cb5_69f68ee7","line":113,"in_reply_to":"5de8544a_28efd093","updated":"2023-01-11 15:21:33.000000000","message":"Done","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"64f87b2e3122f6ecc74668fcacfca7fd3c90ccdc","unresolved":true,"context_lines":[{"line_number":124,"context_line":"Data model impact"},{"line_number":125,"context_line":"-----------------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"NA"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Security impact"},{"line_number":130,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"68084662_27b08dc1","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":2},"updated":"2023-01-09 21:32:10.000000000","message":"you will need to add an image properlty ot opt into this and or a flavor extra spec.\n\nimage properties are version as ovo in nova flavor extra sepcs are not but you will\nneed to extend the flavor extra spec validation.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0dfde5c533777e9aeba54536f2e424a83421463a","unresolved":true,"context_lines":[{"line_number":124,"context_line":"Data model impact"},{"line_number":125,"context_line":"-----------------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"NA"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Security impact"},{"line_number":130,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"815d993b_b392a202","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":2},"in_reply_to":"68084662_27b08dc1","updated":"2023-01-10 10:38:12.000000000","message":"Well, René already explained : you need to add the trait to the flavor or the image if you want to use it, but here, this isn\u0027t a data model impact (we\u0027re not changing the DB)","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ef0e5c5c00353c5329d5e9a6c36847a8fa45007a","unresolved":true,"context_lines":[{"line_number":124,"context_line":"Data model impact"},{"line_number":125,"context_line":"-----------------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"NA"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Security impact"},{"line_number":130,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9680c1b6_80c70694","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":2},"in_reply_to":"815d993b_b392a202","updated":"2023-01-10 11:34:32.000000000","message":"i missed that in my last reading\n\nthat is not inline with the useage of traits in nova todate and i do not belive it is correct to use a request for a trait to enable a feature like this.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"7348bb3ce73ee7969599b68d2f889b7a96a44def","unresolved":false,"context_lines":[{"line_number":124,"context_line":"Data model impact"},{"line_number":125,"context_line":"-----------------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"NA"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Security impact"},{"line_number":130,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"e44f4ec9_104a7d79","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":2},"in_reply_to":"9680c1b6_80c70694","updated":"2023-01-11 15:21:33.000000000","message":"Done","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"64f87b2e3122f6ecc74668fcacfca7fd3c90ccdc","unresolved":true,"context_lines":[{"line_number":135,"context_line":"Notifications impact"},{"line_number":136,"context_line":"--------------------"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"NA"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Other end user impact"},{"line_number":141,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"529c0303_3b0a04ae","line":138,"updated":"2023-01-09 21:32:10.000000000","message":"adding image proeprties willl also modify the image properties in the notificaiton objects but no new notications would be requried for this change.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0dfde5c533777e9aeba54536f2e424a83421463a","unresolved":true,"context_lines":[{"line_number":135,"context_line":"Notifications impact"},{"line_number":136,"context_line":"--------------------"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"NA"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Other end user impact"},{"line_number":141,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"a2cf6513_bbf5990c","line":138,"in_reply_to":"529c0303_3b0a04ae","updated":"2023-01-10 10:38:12.000000000","message":"Not a problem.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"7348bb3ce73ee7969599b68d2f889b7a96a44def","unresolved":false,"context_lines":[{"line_number":135,"context_line":"Notifications impact"},{"line_number":136,"context_line":"--------------------"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"NA"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Other end user impact"},{"line_number":141,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"0c5e78d2_acf9a7d3","line":138,"in_reply_to":"a2cf6513_bbf5990c","updated":"2023-01-11 15:21:33.000000000","message":"Done","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"64f87b2e3122f6ecc74668fcacfca7fd3c90ccdc","unresolved":true,"context_lines":[{"line_number":153,"context_line":"Other deployer impact"},{"line_number":154,"context_line":"---------------------"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"None"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Developer impact"},{"line_number":159,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"f938249e_dbfa19e0","line":156,"updated":"2023-01-09 21:32:10.000000000","message":"qemu does not supprot live migration with virtio-fs currenlty so by using this operators need to be aware that live migration will not be aviable for maintnace.\n\nthis is a pretty big limiation that will rule out using this approch in some cloud envionments\n\nwe should detech and prevent live migraiton attempts at the api level until this is supported.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0dfde5c533777e9aeba54536f2e424a83421463a","unresolved":true,"context_lines":[{"line_number":153,"context_line":"Other deployer impact"},{"line_number":154,"context_line":"---------------------"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"None"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Developer impact"},{"line_number":159,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa4656ff_d7d58e61","line":156,"in_reply_to":"f938249e_dbfa19e0","updated":"2023-01-10 10:38:12.000000000","message":"Good point, we could first provide a documentation for telling about live-migration, but then we could also provide an exception when live-migrating if we want.","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"7348bb3ce73ee7969599b68d2f889b7a96a44def","unresolved":false,"context_lines":[{"line_number":153,"context_line":"Other deployer impact"},{"line_number":154,"context_line":"---------------------"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"None"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Developer impact"},{"line_number":159,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"a579e0e0_ee12f9be","line":156,"in_reply_to":"fa4656ff_d7d58e61","updated":"2023-01-11 15:21:33.000000000","message":"Done","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"64f87b2e3122f6ecc74668fcacfca7fd3c90ccdc","unresolved":true,"context_lines":[{"line_number":186,"context_line":"- New configuration option."},{"line_number":187,"context_line":"- Add new trait."},{"line_number":188,"context_line":"- Changes to share the compute node filesystem if requested by an image"},{"line_number":189,"context_line":"  specification or a flavor extra spec."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"Dependencies"},{"line_number":192,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"c85ffaf7_46a4df70","line":189,"range":{"start_line":189,"start_character":2,"end_line":189,"end_character":15},"updated":"2023-01-09 21:32:10.000000000","message":"property","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"7348bb3ce73ee7969599b68d2f889b7a96a44def","unresolved":false,"context_lines":[{"line_number":186,"context_line":"- New configuration option."},{"line_number":187,"context_line":"- Add new trait."},{"line_number":188,"context_line":"- Changes to share the compute node filesystem if requested by an image"},{"line_number":189,"context_line":"  specification or a flavor extra spec."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"Dependencies"},{"line_number":192,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"f87daa53_2116ba73","line":189,"range":{"start_line":189,"start_character":2,"end_line":189,"end_character":15},"in_reply_to":"c85ffaf7_46a4df70","updated":"2023-01-11 15:21:33.000000000","message":"Done","commit_id":"8f45e29dd6502ecf16b53ea5e0bd6a7e0e1e0675"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8c633650c757e86d415ddd913bed99b30c2596a2","unresolved":true,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":".. code-block:: xml"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  \u003cfilesystem type\u003d\u0027mount\u0027 accessmode\u003d\u0027passthrough\u0027\u003e"},{"line_number":90,"context_line":"      \u003cdriver type\u003d\u0027virtiofs\u0027/\u003e"},{"line_number":91,"context_line":"      \u003csource dir\u003d\u0027/var/lib/libvirt/scaphandre/\u003cDOMAIN_NAME\u003e\u0027/\u003e"},{"line_number":92,"context_line":"      \u003ctarget dir\u003d\u0027mount_tag\u0027/\u003e"}],"source_content_type":"text/x-rst","patch_set":9,"id":"81b764ab_7f1a3381","line":89,"range":{"start_line":89,"start_character":27,"end_line":89,"end_character":51},"updated":"2023-01-12 12:49:36.000000000","message":"below you note that this will always be read-only so would be nice to modify the example too. Can be done in a FUP","commit_id":"84f2d76e9df5207ae05bbdaf7861c654b339be31"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b39f9e31a8040f7db5a0d04c78020680b04978cb","unresolved":true,"context_lines":[{"line_number":96,"context_line":".. note::"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"   The \u003cDOMAIN_NAME\u003e is the name reported by `virsh list`"},{"line_number":99,"context_line":"   or `OS-EXT-SRV-ATTR:instance_name`."},{"line_number":100,"context_line":"   This is the common name between qemu process that scaphandre use to get the"},{"line_number":101,"context_line":"   vm name and openstack."},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"a0243f7f_88c07c90","line":99,"updated":"2023-01-12 10:37:04.000000000","message":"TBC, this is the instance.name value defined by the instance_name_template option, which is *NOT* changing during the instance lifecycle (this is not the hostname value or the display_name one). I tested it in an multinode enviroment and after shelving/unshelving, hardrebooting and migrating the instance, this value is not changed.","commit_id":"84f2d76e9df5207ae05bbdaf7861c654b339be31"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bd7d9cc82cb0564be3226b3f6b72af128c1cc765","unresolved":true,"context_lines":[{"line_number":96,"context_line":".. note::"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"   The \u003cDOMAIN_NAME\u003e is the name reported by `virsh list`"},{"line_number":99,"context_line":"   or `OS-EXT-SRV-ATTR:instance_name`."},{"line_number":100,"context_line":"   This is the common name between qemu process that scaphandre use to get the"},{"line_number":101,"context_line":"   vm name and openstack."},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"270bb386_adfe0c3a","line":99,"in_reply_to":"a0243f7f_88c07c90","updated":"2023-01-12 12:26:46.000000000","message":"that then its not the name of the domain when you do virsh list as that is not stable and never has been. so either we are talkign about two differnt thing or you are not testing the cases where it changes.\n\ndid you have mulitple vms.\n\nfor example in your multi node setup did you boot a vm on both host ensureign they had the same instance_name and then migrate the vm on the first host to the second.\nthis forces the domain xml name to change. \nthere are other cases too wehre that happens.\n\ni think we shoudl come back to this in the code review lets leave it for now.","commit_id":"84f2d76e9df5207ae05bbdaf7861c654b339be31"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bd7d9cc82cb0564be3226b3f6b72af128c1cc765","unresolved":true,"context_lines":[{"line_number":138,"context_line":"Data model impact"},{"line_number":139,"context_line":"-----------------"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Introduce `hw_powermetrics` image property as a new property object."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Extend the flavor extra spec validation to check `hw:power_metrics`."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"05f93fd5_1693123b","line":141,"updated":"2023-01-12 12:26:46.000000000","message":"nit: hw_power_metrics","commit_id":"84f2d76e9df5207ae05bbdaf7861c654b339be31"}]}