)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"79f2efbf_d06e3699","updated":"2022-10-27 16:28:59.000000000","message":"It would really be helpful to take at least an initial proofreading/spellchecking pass on a spec before submitting :)\n\nI think this is what we discussed as the minimal amount of work nova can do to facilitate passing an FQDN through, without getting too far in to the business of networking.","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"790125eb_7cef15a9","updated":"2022-11-15 11:01:56.000000000","message":"just running doc and pep8 locally and then ill push aa new revision","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5f94cdbb53656dcc409bfaa16066ccbdf0191d8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d5f6a41d_9e663570","updated":"2022-11-16 04:15:43.000000000","message":"Looks good to me too. Definitely +1 on solving this use case, it is a very common one from my experience. Approach makes sense and agree it\u0027s better to allow FQDN for --hostname instead of adding something like --FQDN for the sake of avoiding more confusion.","commit_id":"c5ab5bfa69a0b7f104e4d7735db8ac777868dab0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"53557028e41252c7b63ea1304cbd7316da43caca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c73724af_388442e2","updated":"2022-11-15 14:42:39.000000000","message":"Looks good to me.","commit_id":"c5ab5bfa69a0b7f104e4d7735db8ac777868dab0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4173828d76b145c97a3e28904dcb10eba2c1dbc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"606725c9_92f3a736","updated":"2022-11-21 16:21:10.000000000","message":"new version in bound soon just running tox on it now","commit_id":"c5ab5bfa69a0b7f104e4d7735db8ac777868dab0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3aa6e75e63a0dda971ae77b99ac2599dec9c542e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"841e1565_7d1f539a","updated":"2022-12-14 17:36:38.000000000","message":"Life is a matter of trade-offs and this spec is just one of the excerpts.","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"96d4f7c2a224cab7626478353bff0a2dc11d0960","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7f5ee2aa_79575cb9","updated":"2022-12-14 09:01:09.000000000","message":"So, while I think I\u0027m very +2 with the spec, I still have a concern about modifying the multi-create just because of this.\n\nThat\u0027s not that I\u0027m *against* changing the instance names for multi-creates, but maybe not by the *same* microversion so people would have time to change their scripts before.","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ccc761474affeed694856ffc4c7c30d80363530f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6f48a3ad_1c4fb8fc","updated":"2022-11-21 16:25:36.000000000","message":"Still looks good","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"}],"specs/2023.1/approved/fqdn-in-hostname.rst":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/nova/+spec/fqdn-in-hostname"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"enable end users to specify an FQDN as the instance hostname"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4904412e_29d8ba62","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":6},"updated":"2022-10-27 16:28:59.000000000","message":"Enable","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/nova/+spec/fqdn-in-hostname"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"enable end users to specify an FQDN as the instance hostname"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b33aa660_c1a4257d","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":6},"in_reply_to":"4904412e_29d8ba62","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":"Originally when nova was created the instance hostname was set from the"},{"line_number":21,"context_line":"instance display-name. Nova did not allow fqdns in the display name and"},{"line_number":22,"context_line":"explicitly blocked it but that was later removed as a bugfix."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6aabd0c7_7b9d9609","line":22,"range":{"start_line":22,"start_character":21,"end_line":22,"end_character":22},"updated":"2022-10-27 16:28:59.000000000","message":"nit: comma here for readability","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":"Originally when nova was created the instance hostname was set from the"},{"line_number":21,"context_line":"instance display-name. Nova did not allow fqdns in the display name and"},{"line_number":22,"context_line":"explicitly blocked it but that was later removed as a bugfix."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"}],"source_content_type":"text/x-rst","patch_set":1,"id":"92e5ae19_65308e00","line":22,"range":{"start_line":22,"start_character":21,"end_line":22,"end_character":22},"in_reply_to":"6aabd0c7_7b9d9609","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":21,"context_line":"instance display-name. Nova did not allow fqdns in the display name and"},{"line_number":22,"context_line":"explicitly blocked it but that was later removed as a bugfix."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a93c335c_a0ecbc54","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":5},"updated":"2022-10-27 16:28:59.000000000","message":"\"Since\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":21,"context_line":"instance display-name. Nova did not allow fqdns in the display name and"},{"line_number":22,"context_line":"explicitly blocked it but that was later removed as a bugfix."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"}],"source_content_type":"text/x-rst","patch_set":1,"id":"49bb18bf_6a590e48","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":10},"updated":"2022-10-27 16:28:59.000000000","message":"\"this\" meaning what? The removal of the filter blocking FQDN-like strings? Might be worth rephrasing to make it clearer.","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"instance display-name. Nova did not allow fqdns in the display name and"},{"line_number":22,"context_line":"explicitly blocked it but that was later removed as a bugfix."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3e11a2a4_094c986d","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":10},"in_reply_to":"49bb18bf_6a590e48","updated":"2022-11-15 11:01:56.000000000","message":"Ack","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"instance display-name. Nova did not allow fqdns in the display name and"},{"line_number":22,"context_line":"explicitly blocked it but that was later removed as a bugfix."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"}],"source_content_type":"text/x-rst","patch_set":1,"id":"cd1aff2b_f3db11c7","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":5},"in_reply_to":"a93c335c_a0ecbc54","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":22,"context_line":"explicitly blocked it but that was later removed as a bugfix."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."}],"source_content_type":"text/x-rst","patch_set":1,"id":"a3977a37_21ce34d5","line":25,"range":{"start_line":25,"start_character":56,"end_line":25,"end_character":65},"updated":"2022-10-27 16:28:59.000000000","message":"\"Following\", but I think it would be better to say \"After several...\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":22,"context_line":"explicitly blocked it but that was later removed as a bugfix."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."}],"source_content_type":"text/x-rst","patch_set":1,"id":"08b35b5b_e55544ff","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":8},"updated":"2022-10-27 16:28:59.000000000","message":"\"guarantee\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"explicitly blocked it but that was later removed as a bugfix."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ce4c62b_8911fe5d","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":8},"in_reply_to":"08b35b5b_e55544ff","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"explicitly blocked it but that was later removed as a bugfix."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."}],"source_content_type":"text/x-rst","patch_set":1,"id":"dce2d78e_ea40bb03","line":25,"range":{"start_line":25,"start_character":56,"end_line":25,"end_character":65},"in_reply_to":"a3977a37_21ce34d5","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"76e734ef_1a8e9625","line":26,"range":{"start_line":26,"start_character":57,"end_line":26,"end_character":63},"updated":"2022-10-27 16:28:59.000000000","message":"\"extend\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bbfd8652_2cb47887","line":26,"range":{"start_line":26,"start_character":16,"end_line":26,"end_character":27},"updated":"2022-10-27 16:28:59.000000000","message":"\"interactions\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"4939c2a2_9993f586","line":26,"range":{"start_line":26,"start_character":3,"end_line":26,"end_character":15},"updated":"2022-10-27 16:28:59.000000000","message":"\"undesirable\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"568182ea_e501e2d8","line":26,"range":{"start_line":26,"start_character":3,"end_line":26,"end_character":15},"in_reply_to":"4939c2a2_9993f586","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dcd02c9a_ad5e7814","line":26,"range":{"start_line":26,"start_character":57,"end_line":26,"end_character":63},"in_reply_to":"76e734ef_1a8e9625","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff9934ca_cb14effd","line":26,"range":{"start_line":26,"start_character":16,"end_line":26,"end_character":27},"in_reply_to":"bbfd8652_2cb47887","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"In the Xena release we also introduced configurable instance hostnames by"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d3aa3e70_32ba3aa5","line":27,"range":{"start_line":27,"start_character":37,"end_line":27,"end_character":50},"updated":"2022-10-27 16:28:59.000000000","message":"\"alpha-numeric\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"In the Xena release we also introduced configurable instance hostnames by"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4ada461a_8aeab523","line":27,"range":{"start_line":27,"start_character":51,"end_line":27,"end_character":59},"updated":"2022-10-27 16:28:59.000000000","message":"\"characters\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"In the Xena release we also introduced configurable instance hostnames by"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bd118dfa_38e9ce7a","line":27,"range":{"start_line":27,"start_character":27,"end_line":27,"end_character":36},"updated":"2022-10-27 16:28:59.000000000","message":"\"non-ASCII\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"In the Xena release we also introduced configurable instance hostnames by"}],"source_content_type":"text/x-rst","patch_set":1,"id":"56b3b10d_e21d8377","line":27,"range":{"start_line":27,"start_character":51,"end_line":27,"end_character":59},"in_reply_to":"4ada461a_8aeab523","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"In the Xena release we also introduced configurable instance hostnames by"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4de11ec5_ee6d0f0d","line":27,"range":{"start_line":27,"start_character":27,"end_line":27,"end_character":36},"in_reply_to":"bd118dfa_38e9ce7a","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"since this was not done as a spec or feature nova never provided an api"},{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"In the Xena release we also introduced configurable instance hostnames by"}],"source_content_type":"text/x-rst","patch_set":1,"id":"74386ff2_e64dfd2a","line":27,"range":{"start_line":27,"start_character":37,"end_line":27,"end_character":50},"in_reply_to":"d3aa3e70_32ba3aa5","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"In the Xena release we also introduced configurable instance hostnames by"},{"line_number":31,"context_line":"exposing the host name filed directly in the api but maintained our"}],"source_content_type":"text/x-rst","patch_set":1,"id":"506eba7c_28a97331","line":28,"range":{"start_line":28,"start_character":47,"end_line":28,"end_character":51},"updated":"2022-10-27 16:28:59.000000000","message":"\"from\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"In the Xena release we also introduced configurable instance hostnames by"},{"line_number":31,"context_line":"exposing the host name filed directly in the api but maintained our"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f66ea5e_870168d1","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":13},"updated":"2022-10-27 16:28:59.000000000","message":"\"periods from\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"In the Xena release we also introduced configurable instance hostnames by"},{"line_number":31,"context_line":"exposing the host name filed directly in the api but maintained our"}],"source_content_type":"text/x-rst","patch_set":1,"id":"964dc3f5_d6de12ec","line":28,"range":{"start_line":28,"start_character":47,"end_line":28,"end_character":51},"in_reply_to":"506eba7c_28a97331","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"gurentee that fqdns can be used when creating a server. following bug reports"},{"line_number":26,"context_line":"of undesireable interaction with designate we decided to extned the"},{"line_number":27,"context_line":"normalisation that removes non ascii alpha numeric charater to also remove"},{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"In the Xena release we also introduced configurable instance hostnames by"},{"line_number":31,"context_line":"exposing the host name filed directly in the api but maintained our"}],"source_content_type":"text/x-rst","patch_set":1,"id":"803807a8_752b97bd","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":13},"in_reply_to":"7f66ea5e_870168d1","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"In the Xena release we also introduced configurable instance hostnames by"},{"line_number":31,"context_line":"exposing the host name filed directly in the api but maintained our"},{"line_number":32,"context_line":"prohibition on FQDNs."},{"line_number":33,"context_line":"https://specs.openstack.org/openstack/nova-specs/specs/xena/implemented/configurable-instance-hostnames.html"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"b19a431c_3790412a","line":31,"range":{"start_line":31,"start_character":23,"end_line":31,"end_character":28},"updated":"2022-10-27 16:28:59.000000000","message":"\"field\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"period\u0027s form the hostname when initalising it form the display name."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"In the Xena release we also introduced configurable instance hostnames by"},{"line_number":31,"context_line":"exposing the host name filed directly in the api but maintained our"},{"line_number":32,"context_line":"prohibition on FQDNs."},{"line_number":33,"context_line":"https://specs.openstack.org/openstack/nova-specs/specs/xena/implemented/configurable-instance-hostnames.html"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"80568700_0189b9b5","line":31,"range":{"start_line":31,"start_character":23,"end_line":31,"end_character":28},"in_reply_to":"b19a431c_3790412a","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"In the Xena release we also introduced configurable instance hostnames by"},{"line_number":31,"context_line":"exposing the host name filed directly in the api but maintained our"},{"line_number":32,"context_line":"prohibition on FQDNs."},{"line_number":33,"context_line":"https://specs.openstack.org/openstack/nova-specs/specs/xena/implemented/configurable-instance-hostnames.html"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"This spec seeks to extend that filed to allow FQDNs to be used as the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"76d4e743_6b19a25d","line":32,"range":{"start_line":32,"start_character":15,"end_line":32,"end_character":20},"updated":"2022-10-27 16:28:59.000000000","message":"\"FQDNs\" is proper, can you fix it elsewhere in this spec? Also, \"API\" while you\u0027re at it :)","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"In the Xena release we also introduced configurable instance hostnames by"},{"line_number":31,"context_line":"exposing the host name filed directly in the api but maintained our"},{"line_number":32,"context_line":"prohibition on FQDNs."},{"line_number":33,"context_line":"https://specs.openstack.org/openstack/nova-specs/specs/xena/implemented/configurable-instance-hostnames.html"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"This spec seeks to extend that filed to allow FQDNs to be used as the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b9f43e44_894ed980","line":32,"range":{"start_line":32,"start_character":15,"end_line":32,"end_character":20},"in_reply_to":"76d4e743_6b19a25d","updated":"2022-11-15 11:01:56.000000000","message":"Ack","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":32,"context_line":"prohibition on FQDNs."},{"line_number":33,"context_line":"https://specs.openstack.org/openstack/nova-specs/specs/xena/implemented/configurable-instance-hostnames.html"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"This spec seeks to extend that filed to allow FQDNs to be used as the"},{"line_number":36,"context_line":"hostname of an instance."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"81ef14f1_2971724b","line":35,"range":{"start_line":35,"start_character":31,"end_line":35,"end_character":36},"updated":"2022-10-27 16:28:59.000000000","message":"\"field\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"prohibition on FQDNs."},{"line_number":33,"context_line":"https://specs.openstack.org/openstack/nova-specs/specs/xena/implemented/configurable-instance-hostnames.html"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"This spec seeks to extend that filed to allow FQDNs to be used as the"},{"line_number":36,"context_line":"hostname of an instance."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"43cd664a_0652ac82","line":35,"range":{"start_line":35,"start_character":31,"end_line":35,"end_character":36},"in_reply_to":"81ef14f1_2971724b","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":39,"context_line":"Use Cases"},{"line_number":40,"context_line":"---------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"As an operator i want to allocate domain to my tenants and use automation to"},{"line_number":43,"context_line":"validate that the VMs are created with an FQDN that is derived from that"},{"line_number":44,"context_line":"domain."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"94d64c0d_4ec1f523","line":42,"range":{"start_line":42,"start_character":15,"end_line":42,"end_character":16},"updated":"2022-10-27 16:28:59.000000000","message":"\"I\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":39,"context_line":"Use Cases"},{"line_number":40,"context_line":"---------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"As an operator i want to allocate domain to my tenants and use automation to"},{"line_number":43,"context_line":"validate that the VMs are created with an FQDN that is derived from that"},{"line_number":44,"context_line":"domain."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1d54c25d_50cb4bec","line":42,"range":{"start_line":42,"start_character":34,"end_line":42,"end_character":40},"updated":"2022-10-27 16:28:59.000000000","message":"\"domains\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Use Cases"},{"line_number":40,"context_line":"---------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"As an operator i want to allocate domain to my tenants and use automation to"},{"line_number":43,"context_line":"validate that the VMs are created with an FQDN that is derived from that"},{"line_number":44,"context_line":"domain."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"037a6739_1d3e9034","line":42,"range":{"start_line":42,"start_character":34,"end_line":42,"end_character":40},"in_reply_to":"1d54c25d_50cb4bec","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Use Cases"},{"line_number":40,"context_line":"---------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"As an operator i want to allocate domain to my tenants and use automation to"},{"line_number":43,"context_line":"validate that the VMs are created with an FQDN that is derived from that"},{"line_number":44,"context_line":"domain."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"03de554b_591aba02","line":42,"range":{"start_line":42,"start_character":15,"end_line":42,"end_character":16},"in_reply_to":"94d64c0d_4ec1f523","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":43,"context_line":"validate that the VMs are created with an FQDN that is derived from that"},{"line_number":44,"context_line":"domain."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"As a VNF vendor i want to set the value of /etc/hostname to an FQDN"},{"line_number":47,"context_line":"automatically when creating an instance via the api leveraging cloud-init"},{"line_number":48,"context_line":"or another tool without using user-data."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"6c42aa8e_352fc5bb","line":46,"range":{"start_line":46,"start_character":16,"end_line":46,"end_character":17},"updated":"2022-10-27 16:28:59.000000000","message":"\"I\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"validate that the VMs are created with an FQDN that is derived from that"},{"line_number":44,"context_line":"domain."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"As a VNF vendor i want to set the value of /etc/hostname to an FQDN"},{"line_number":47,"context_line":"automatically when creating an instance via the api leveraging cloud-init"},{"line_number":48,"context_line":"or another tool without using user-data."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"44bcc2b8_18985ece","line":46,"range":{"start_line":46,"start_character":16,"end_line":46,"end_character":17},"in_reply_to":"6c42aa8e_352fc5bb","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Proposed change"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":"- add a new api micoversion to opt into using an fqdn in the hostname field."},{"line_number":53,"context_line":"- increase the character lenght limit on the host name filed form 63 to 255"},{"line_number":54,"context_line":"- remove the rejection of \".\" and other leagal charaters in a fqdn."},{"line_number":55,"context_line":"- change multi create instance format to prefix with an index instead"}],"source_content_type":"text/x-rst","patch_set":1,"id":"16bacdae_05dc5a04","line":52,"range":{"start_line":52,"start_character":16,"end_line":52,"end_character":27},"updated":"2022-10-27 16:28:59.000000000","message":"\"microversion\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Proposed change"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":"- add a new api micoversion to opt into using an fqdn in the hostname field."},{"line_number":53,"context_line":"- increase the character lenght limit on the host name filed form 63 to 255"},{"line_number":54,"context_line":"- remove the rejection of \".\" and other leagal charaters in a fqdn."},{"line_number":55,"context_line":"- change multi create instance format to prefix with an index instead"}],"source_content_type":"text/x-rst","patch_set":1,"id":"05b10dc1_79bc15d6","line":52,"range":{"start_line":52,"start_character":16,"end_line":52,"end_character":27},"in_reply_to":"16bacdae_05dc5a04","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":50,"context_line":"Proposed change"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":"- add a new api micoversion to opt into using an fqdn in the hostname field."},{"line_number":53,"context_line":"- increase the character lenght limit on the host name filed form 63 to 255"},{"line_number":54,"context_line":"- remove the rejection of \".\" and other leagal charaters in a fqdn."},{"line_number":55,"context_line":"- change multi create instance format to prefix with an index instead"},{"line_number":56,"context_line":"  of suffixing.  This is allowed per section 2.1 of"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f859e404_9f5aeedc","line":53,"range":{"start_line":53,"start_character":55,"end_line":53,"end_character":65},"updated":"2022-10-27 16:28:59.000000000","message":"\"field from\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":50,"context_line":"Proposed change"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":"- add a new api micoversion to opt into using an fqdn in the hostname field."},{"line_number":53,"context_line":"- increase the character lenght limit on the host name filed form 63 to 255"},{"line_number":54,"context_line":"- remove the rejection of \".\" and other leagal charaters in a fqdn."},{"line_number":55,"context_line":"- change multi create instance format to prefix with an index instead"},{"line_number":56,"context_line":"  of suffixing.  This is allowed per section 2.1 of"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7df652ca_6208bdbc","line":53,"range":{"start_line":53,"start_character":25,"end_line":53,"end_character":31},"updated":"2022-10-27 16:28:59.000000000","message":"\"length\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Proposed change"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":"- add a new api micoversion to opt into using an fqdn in the hostname field."},{"line_number":53,"context_line":"- increase the character lenght limit on the host name filed form 63 to 255"},{"line_number":54,"context_line":"- remove the rejection of \".\" and other leagal charaters in a fqdn."},{"line_number":55,"context_line":"- change multi create instance format to prefix with an index instead"},{"line_number":56,"context_line":"  of suffixing.  This is allowed per section 2.1 of"}],"source_content_type":"text/x-rst","patch_set":1,"id":"33040906_001099f0","line":53,"range":{"start_line":53,"start_character":25,"end_line":53,"end_character":31},"in_reply_to":"7df652ca_6208bdbc","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Proposed change"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":"- add a new api micoversion to opt into using an fqdn in the hostname field."},{"line_number":53,"context_line":"- increase the character lenght limit on the host name filed form 63 to 255"},{"line_number":54,"context_line":"- remove the rejection of \".\" and other leagal charaters in a fqdn."},{"line_number":55,"context_line":"- change multi create instance format to prefix with an index instead"},{"line_number":56,"context_line":"  of suffixing.  This is allowed per section 2.1 of"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5d339dfe_bc4f2ef4","line":53,"range":{"start_line":53,"start_character":55,"end_line":53,"end_character":65},"in_reply_to":"f859e404_9f5aeedc","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":"- add a new api micoversion to opt into using an fqdn in the hostname field."},{"line_number":53,"context_line":"- increase the character lenght limit on the host name filed form 63 to 255"},{"line_number":54,"context_line":"- remove the rejection of \".\" and other leagal charaters in a fqdn."},{"line_number":55,"context_line":"- change multi create instance format to prefix with an index instead"},{"line_number":56,"context_line":"  of suffixing.  This is allowed per section 2.1 of"},{"line_number":57,"context_line":"  https://datatracker.ietf.org/doc/html/rfc1123#page-13"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fefaf62e_e04e5bef","line":54,"range":{"start_line":54,"start_character":40,"end_line":54,"end_character":46},"updated":"2022-10-27 16:28:59.000000000","message":"\"legal\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":"- add a new api micoversion to opt into using an fqdn in the hostname field."},{"line_number":53,"context_line":"- increase the character lenght limit on the host name filed form 63 to 255"},{"line_number":54,"context_line":"- remove the rejection of \".\" and other leagal charaters in a fqdn."},{"line_number":55,"context_line":"- change multi create instance format to prefix with an index instead"},{"line_number":56,"context_line":"  of suffixing.  This is allowed per section 2.1 of"},{"line_number":57,"context_line":"  https://datatracker.ietf.org/doc/html/rfc1123#page-13"}],"source_content_type":"text/x-rst","patch_set":1,"id":"511644a8_abe1f74f","line":54,"range":{"start_line":54,"start_character":40,"end_line":54,"end_character":46},"in_reply_to":"fefaf62e_e04e5bef","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":52,"context_line":"- add a new api micoversion to opt into using an fqdn in the hostname field."},{"line_number":53,"context_line":"- increase the character lenght limit on the host name filed form 63 to 255"},{"line_number":54,"context_line":"- remove the rejection of \".\" and other leagal charaters in a fqdn."},{"line_number":55,"context_line":"- change multi create instance format to prefix with an index instead"},{"line_number":56,"context_line":"  of suffixing.  This is allowed per section 2.1 of"},{"line_number":57,"context_line":"  https://datatracker.ietf.org/doc/html/rfc1123#page-13"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"281bfbc6_d33567cc","line":55,"range":{"start_line":55,"start_character":9,"end_line":55,"end_character":21},"updated":"2022-10-27 16:28:59.000000000","message":"\"the multi-create\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"- add a new api micoversion to opt into using an fqdn in the hostname field."},{"line_number":53,"context_line":"- increase the character lenght limit on the host name filed form 63 to 255"},{"line_number":54,"context_line":"- remove the rejection of \".\" and other leagal charaters in a fqdn."},{"line_number":55,"context_line":"- change multi create instance format to prefix with an index instead"},{"line_number":56,"context_line":"  of suffixing.  This is allowed per section 2.1 of"},{"line_number":57,"context_line":"  https://datatracker.ietf.org/doc/html/rfc1123#page-13"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"46d8c9b8_fdb7a865","line":55,"range":{"start_line":55,"start_character":9,"end_line":55,"end_character":21},"in_reply_to":"281bfbc6_d33567cc","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":54,"context_line":"- remove the rejection of \".\" and other leagal charaters in a fqdn."},{"line_number":55,"context_line":"- change multi create instance format to prefix with an index instead"},{"line_number":56,"context_line":"  of suffixing.  This is allowed per section 2.1 of"},{"line_number":57,"context_line":"  https://datatracker.ietf.org/doc/html/rfc1123#page-13"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  \"\"\""},{"line_number":60,"context_line":"  The syntax of a legal Internet host name was specified in RFC-952"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0e3b2f39_658207f9","line":57,"updated":"2022-10-27 16:28:59.000000000","message":"This means instead of instance42, we\u0027ll create 42instance.domain.com ?","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":true,"context_lines":[{"line_number":54,"context_line":"- remove the rejection of \".\" and other leagal charaters in a fqdn."},{"line_number":55,"context_line":"- change multi create instance format to prefix with an index instead"},{"line_number":56,"context_line":"  of suffixing.  This is allowed per section 2.1 of"},{"line_number":57,"context_line":"  https://datatracker.ietf.org/doc/html/rfc1123#page-13"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  \"\"\""},{"line_number":60,"context_line":"  The syntax of a legal Internet host name was specified in RFC-952"}],"source_content_type":"text/x-rst","patch_set":1,"id":"658bfc3b_0685500f","line":57,"in_reply_to":"0e3b2f39_658207f9","updated":"2022-11-15 11:01:56.000000000","message":"yes with a hyphen seperating the index from the provided fqdn","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4173828d76b145c97a3e28904dcb10eba2c1dbc6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"- remove the rejection of \".\" and other leagal charaters in a fqdn."},{"line_number":55,"context_line":"- change multi create instance format to prefix with an index instead"},{"line_number":56,"context_line":"  of suffixing.  This is allowed per section 2.1 of"},{"line_number":57,"context_line":"  https://datatracker.ietf.org/doc/html/rfc1123#page-13"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  \"\"\""},{"line_number":60,"context_line":"  The syntax of a legal Internet host name was specified in RFC-952"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e1dc7ea8_179b18ab","line":57,"in_reply_to":"658bfc3b_0685500f","updated":"2022-11-21 16:21:10.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  Today the instance.hostname field is propagated into the hostname field of"},{"line_number":70,"context_line":"  the instance metadata. With this change the instance.hostname field can be an"},{"line_number":71,"context_line":"  FQDN and that will also be propagated  as done today without alteration"},{"line_number":72,"context_line":"  other then the prefix for multi-create."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"b16e0b5c_6ab8bb73","line":71,"range":{"start_line":71,"start_character":40,"end_line":71,"end_character":41},"updated":"2022-10-27 16:28:59.000000000","message":"Extra space here.","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  Today the instance.hostname field is propagated into the hostname field of"},{"line_number":70,"context_line":"  the instance metadata. With this change the instance.hostname field can be an"},{"line_number":71,"context_line":"  FQDN and that will also be propagated  as done today without alteration"},{"line_number":72,"context_line":"  other then the prefix for multi-create."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"00f092d8_fed06449","line":71,"range":{"start_line":71,"start_character":40,"end_line":71,"end_character":41},"in_reply_to":"b16e0b5c_6ab8bb73","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":79,"context_line":"Nova could add a fqdn field"},{"line_number":80,"context_line":"e.g. openstack server create --fqdn ..."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"this raises ambiguity of when to use --hostname vs --fqdn and requires a"},{"line_number":83,"context_line":"change to the data model to store the new field."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Nova could add a domain filed"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e518f8a3_ab0a20c7","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":4},"updated":"2022-10-27 16:28:59.000000000","message":"\"This\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Nova could add a fqdn field"},{"line_number":80,"context_line":"e.g. openstack server create --fqdn ..."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"this raises ambiguity of when to use --hostname vs --fqdn and requires a"},{"line_number":83,"context_line":"change to the data model to store the new field."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Nova could add a domain filed"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f5b530f_7b8a0465","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":4},"in_reply_to":"e518f8a3_ab0a20c7","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":82,"context_line":"this raises ambiguity of when to use --hostname vs --fqdn and requires a"},{"line_number":83,"context_line":"change to the data model to store the new field."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Nova could add a domain filed"},{"line_number":86,"context_line":"e.g. openstack server create --hostname my-host --domain my.domain.com ..."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"This is better then --fqdn but still required db and object changes for"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8d5371e7_55c7382b","line":85,"range":{"start_line":85,"start_character":24,"end_line":85,"end_character":29},"updated":"2022-10-27 16:28:59.000000000","message":"\"field\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":82,"context_line":"this raises ambiguity of when to use --hostname vs --fqdn and requires a"},{"line_number":83,"context_line":"change to the data model to store the new field."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Nova could add a domain filed"},{"line_number":86,"context_line":"e.g. openstack server create --hostname my-host --domain my.domain.com ..."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"This is better then --fqdn but still required db and object changes for"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e302566d_99a5a2f1","line":85,"range":{"start_line":85,"start_character":24,"end_line":85,"end_character":29},"in_reply_to":"8d5371e7_55c7382b","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":85,"context_line":"Nova could add a domain filed"},{"line_number":86,"context_line":"e.g. openstack server create --hostname my-host --domain my.domain.com ..."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"This is better then --fqdn but still required db and object changes for"},{"line_number":89,"context_line":"little benefit."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Nova could block multi create."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1d01b283_83e110cf","line":88,"range":{"start_line":88,"start_character":37,"end_line":88,"end_character":45},"updated":"2022-10-27 16:28:59.000000000","message":"\"requires\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":85,"context_line":"Nova could add a domain filed"},{"line_number":86,"context_line":"e.g. openstack server create --hostname my-host --domain my.domain.com ..."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"This is better then --fqdn but still required db and object changes for"},{"line_number":89,"context_line":"little benefit."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Nova could block multi create."}],"source_content_type":"text/x-rst","patch_set":1,"id":"a056e979_98df962f","line":88,"range":{"start_line":88,"start_character":37,"end_line":88,"end_character":45},"in_reply_to":"1d01b283_83e110cf","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":86,"context_line":"e.g. openstack server create --hostname my-host --domain my.domain.com ..."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"This is better then --fqdn but still required db and object changes for"},{"line_number":89,"context_line":"little benefit."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Nova could block multi create."},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"6ae8e577_11f4b895","line":89,"updated":"2022-10-27 16:28:59.000000000","message":"It also puts nova a little more in the business of networking, IMHO.","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":86,"context_line":"e.g. openstack server create --hostname my-host --domain my.domain.com ..."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"This is better then --fqdn but still required db and object changes for"},{"line_number":89,"context_line":"little benefit."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Nova could block multi create."},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"783adfd3_589a9999","line":89,"in_reply_to":"6ae8e577_11f4b895","updated":"2022-11-15 11:01:56.000000000","message":"Ack","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Nova could block multi create."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"while this would avoid changing the hostname template form a suffix to prefix"},{"line_number":94,"context_line":"this in the new microversion it is a trivial code change and does not add much"},{"line_number":95,"context_line":"complexity vs multi create in general."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"f74ea43b_c5e903be","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":5},"updated":"2022-10-27 16:28:59.000000000","message":"\"While\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Nova could block multi create."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"while this would avoid changing the hostname template form a suffix to prefix"},{"line_number":94,"context_line":"this in the new microversion it is a trivial code change and does not add much"},{"line_number":95,"context_line":"complexity vs multi create in general."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"efd9d5a1_93a7bca9","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":5},"in_reply_to":"f74ea43b_c5e903be","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"while this would avoid changing the hostname template form a suffix to prefix"},{"line_number":94,"context_line":"this in the new microversion it is a trivial code change and does not add much"},{"line_number":95,"context_line":"complexity vs multi create in general."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Nova could try to propagate hostname change to neutron."},{"line_number":98,"context_line":"This is seen as risky, complex and hard to understand."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7266c3fc_f223cfc0","line":95,"updated":"2022-10-27 16:28:59.000000000","message":"This isn\u0027t really an alternative in itself, right? Maybe if you phrased it as \"we could do all of this minus the multicreate thing\"?","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"while this would avoid changing the hostname template form a suffix to prefix"},{"line_number":94,"context_line":"this in the new microversion it is a trivial code change and does not add much"},{"line_number":95,"context_line":"complexity vs multi create in general."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Nova could try to propagate hostname change to neutron."},{"line_number":98,"context_line":"This is seen as risky, complex and hard to understand."}],"source_content_type":"text/x-rst","patch_set":1,"id":"e2f650da_a0c2e077","line":95,"in_reply_to":"7266c3fc_f223cfc0","updated":"2022-11-15 11:01:56.000000000","message":"Ack","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":94,"context_line":"this in the new microversion it is a trivial code change and does not add much"},{"line_number":95,"context_line":"complexity vs multi create in general."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Nova could try to propagate hostname change to neutron."},{"line_number":98,"context_line":"This is seen as risky, complex and hard to understand."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"First nova was to propagate hostname changes  to the port dns_name field it"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6ad37881_ee766da1","line":97,"range":{"start_line":97,"start_character":37,"end_line":97,"end_character":43},"updated":"2022-10-27 16:28:59.000000000","message":"\"changes\"? Either way, I\u0027m having a hard time reading this and knowing what you really mean. We\u0027re \"propagating\" hostnames to neutron in this proposal, but the text below goes on to discuss using the existing field on ports to do it. Maybe reword this somehow?","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":94,"context_line":"this in the new microversion it is a trivial code change and does not add much"},{"line_number":95,"context_line":"complexity vs multi create in general."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Nova could try to propagate hostname change to neutron."},{"line_number":98,"context_line":"This is seen as risky, complex and hard to understand."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"First nova was to propagate hostname changes  to the port dns_name field it"}],"source_content_type":"text/x-rst","patch_set":1,"id":"90a394a6_219669b9","line":97,"range":{"start_line":97,"start_character":37,"end_line":97,"end_character":43},"in_reply_to":"6ad37881_ee766da1","updated":"2022-11-15 11:01:56.000000000","message":"Ack","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":97,"context_line":"Nova could try to propagate hostname change to neutron."},{"line_number":98,"context_line":"This is seen as risky, complex and hard to understand."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"First nova was to propagate hostname changes  to the port dns_name field it"},{"line_number":101,"context_line":"would only be able to do so on port that were created by nova not passed"},{"line_number":102,"context_line":"in. if we updated port that were passed in it could break excising use cases"},{"line_number":103,"context_line":"where an end user set the desired name."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ae30e4ab_a2465185","line":100,"range":{"start_line":100,"start_character":6,"end_line":100,"end_character":10},"updated":"2022-10-27 16:28:59.000000000","message":"\"if nova\" ?","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":97,"context_line":"Nova could try to propagate hostname change to neutron."},{"line_number":98,"context_line":"This is seen as risky, complex and hard to understand."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"First nova was to propagate hostname changes  to the port dns_name field it"},{"line_number":101,"context_line":"would only be able to do so on port that were created by nova not passed"},{"line_number":102,"context_line":"in. if we updated port that were passed in it could break excising use cases"},{"line_number":103,"context_line":"where an end user set the desired name."}],"source_content_type":"text/x-rst","patch_set":1,"id":"d29b56d7_089bb224","line":100,"range":{"start_line":100,"start_character":44,"end_line":100,"end_character":46},"updated":"2022-10-27 16:28:59.000000000","message":"Extra space here","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":97,"context_line":"Nova could try to propagate hostname change to neutron."},{"line_number":98,"context_line":"This is seen as risky, complex and hard to understand."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"First nova was to propagate hostname changes  to the port dns_name field it"},{"line_number":101,"context_line":"would only be able to do so on port that were created by nova not passed"},{"line_number":102,"context_line":"in. if we updated port that were passed in it could break excising use cases"},{"line_number":103,"context_line":"where an end user set the desired name."}],"source_content_type":"text/x-rst","patch_set":1,"id":"d0767604_f3a247de","line":100,"range":{"start_line":100,"start_character":6,"end_line":100,"end_character":10},"in_reply_to":"ae30e4ab_a2465185","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":97,"context_line":"Nova could try to propagate hostname change to neutron."},{"line_number":98,"context_line":"This is seen as risky, complex and hard to understand."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"First nova was to propagate hostname changes  to the port dns_name field it"},{"line_number":101,"context_line":"would only be able to do so on port that were created by nova not passed"},{"line_number":102,"context_line":"in. if we updated port that were passed in it could break excising use cases"},{"line_number":103,"context_line":"where an end user set the desired name."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ce962244_9ebafa02","line":100,"range":{"start_line":100,"start_character":44,"end_line":100,"end_character":46},"in_reply_to":"d29b56d7_089bb224","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":98,"context_line":"This is seen as risky, complex and hard to understand."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"First nova was to propagate hostname changes  to the port dns_name field it"},{"line_number":101,"context_line":"would only be able to do so on port that were created by nova not passed"},{"line_number":102,"context_line":"in. if we updated port that were passed in it could break excising use cases"},{"line_number":103,"context_line":"where an end user set the desired name."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"0b690e4d_f7c7a11c","line":101,"range":{"start_line":101,"start_character":57,"end_line":101,"end_character":72},"updated":"2022-10-27 16:28:59.000000000","message":"\"nova, not ports passed in by an API user\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":98,"context_line":"This is seen as risky, complex and hard to understand."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"First nova was to propagate hostname changes  to the port dns_name field it"},{"line_number":101,"context_line":"would only be able to do so on port that were created by nova not passed"},{"line_number":102,"context_line":"in. if we updated port that were passed in it could break excising use cases"},{"line_number":103,"context_line":"where an end user set the desired name."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"0900cce2_fcadf038","line":101,"range":{"start_line":101,"start_character":31,"end_line":101,"end_character":35},"updated":"2022-10-27 16:28:59.000000000","message":"\"ports\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":98,"context_line":"This is seen as risky, complex and hard to understand."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"First nova was to propagate hostname changes  to the port dns_name field it"},{"line_number":101,"context_line":"would only be able to do so on port that were created by nova not passed"},{"line_number":102,"context_line":"in. if we updated port that were passed in it could break excising use cases"},{"line_number":103,"context_line":"where an end user set the desired name."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"de1cac7e_0375fa70","line":101,"range":{"start_line":101,"start_character":31,"end_line":101,"end_character":35},"in_reply_to":"0900cce2_fcadf038","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":98,"context_line":"This is seen as risky, complex and hard to understand."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"First nova was to propagate hostname changes  to the port dns_name field it"},{"line_number":101,"context_line":"would only be able to do so on port that were created by nova not passed"},{"line_number":102,"context_line":"in. if we updated port that were passed in it could break excising use cases"},{"line_number":103,"context_line":"where an end user set the desired name."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"c6f4bc73_d0b1b6c4","line":101,"range":{"start_line":101,"start_character":57,"end_line":101,"end_character":72},"in_reply_to":"0b690e4d_f7c7a11c","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"First nova was to propagate hostname changes  to the port dns_name field it"},{"line_number":101,"context_line":"would only be able to do so on port that were created by nova not passed"},{"line_number":102,"context_line":"in. if we updated port that were passed in it could break excising use cases"},{"line_number":103,"context_line":"where an end user set the desired name."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Second the floating ip dns_name is typically not the same as the instance"}],"source_content_type":"text/x-rst","patch_set":1,"id":"643df4d0_c991ae1a","line":102,"range":{"start_line":102,"start_character":4,"end_line":102,"end_character":6},"updated":"2022-10-27 16:28:59.000000000","message":"\"If\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"First nova was to propagate hostname changes  to the port dns_name field it"},{"line_number":101,"context_line":"would only be able to do so on port that were created by nova not passed"},{"line_number":102,"context_line":"in. if we updated port that were passed in it could break excising use cases"},{"line_number":103,"context_line":"where an end user set the desired name."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Second the floating ip dns_name is typically not the same as the instance"}],"source_content_type":"text/x-rst","patch_set":1,"id":"68e2850b_f0405c21","line":102,"range":{"start_line":102,"start_character":58,"end_line":102,"end_character":66},"updated":"2022-10-27 16:28:59.000000000","message":"\"existing\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"First nova was to propagate hostname changes  to the port dns_name field it"},{"line_number":101,"context_line":"would only be able to do so on port that were created by nova not passed"},{"line_number":102,"context_line":"in. if we updated port that were passed in it could break excising use cases"},{"line_number":103,"context_line":"where an end user set the desired name."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Second the floating ip dns_name is typically not the same as the instance"}],"source_content_type":"text/x-rst","patch_set":1,"id":"692e133d_b6a44a2c","line":102,"range":{"start_line":102,"start_character":18,"end_line":102,"end_character":22},"updated":"2022-10-27 16:28:59.000000000","message":"\"ports\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"First nova was to propagate hostname changes  to the port dns_name field it"},{"line_number":101,"context_line":"would only be able to do so on port that were created by nova not passed"},{"line_number":102,"context_line":"in. if we updated port that were passed in it could break excising use cases"},{"line_number":103,"context_line":"where an end user set the desired name."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Second the floating ip dns_name is typically not the same as the instance"}],"source_content_type":"text/x-rst","patch_set":1,"id":"89204e23_81a92ebc","line":102,"range":{"start_line":102,"start_character":4,"end_line":102,"end_character":6},"in_reply_to":"643df4d0_c991ae1a","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"First nova was to propagate hostname changes  to the port dns_name field it"},{"line_number":101,"context_line":"would only be able to do so on port that were created by nova not passed"},{"line_number":102,"context_line":"in. if we updated port that were passed in it could break excising use cases"},{"line_number":103,"context_line":"where an end user set the desired name."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Second the floating ip dns_name is typically not the same as the instance"}],"source_content_type":"text/x-rst","patch_set":1,"id":"21233620_b059fd5e","line":102,"range":{"start_line":102,"start_character":58,"end_line":102,"end_character":66},"in_reply_to":"68e2850b_f0405c21","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"First nova was to propagate hostname changes  to the port dns_name field it"},{"line_number":101,"context_line":"would only be able to do so on port that were created by nova not passed"},{"line_number":102,"context_line":"in. if we updated port that were passed in it could break excising use cases"},{"line_number":103,"context_line":"where an end user set the desired name."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Second the floating ip dns_name is typically not the same as the instance"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c3c6255f_634ad09d","line":102,"range":{"start_line":102,"start_character":18,"end_line":102,"end_character":22},"in_reply_to":"692e133d_b6a44a2c","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":102,"context_line":"in. if we updated port that were passed in it could break excising use cases"},{"line_number":103,"context_line":"where an end user set the desired name."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Second the floating ip dns_name is typically not the same as the instance"},{"line_number":106,"context_line":"FQDN. The instance hostname or FQDN is typically an internal name used in the"},{"line_number":107,"context_line":"application and the floating ip is used to expose a public name for the"},{"line_number":108,"context_line":"service. i.e. the instance might be called ``webserver.cloud.com`` where"}],"source_content_type":"text/x-rst","patch_set":1,"id":"67865d1e_f759885d","line":105,"range":{"start_line":105,"start_character":35,"end_line":105,"end_character":44},"updated":"2022-10-27 16:28:59.000000000","message":"Not typically, but also not by definition right? If you have one (addressed) port, they could match, but if you have two, they shan\u0027t, and it\u0027s definitely not a requirement.","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":true,"context_lines":[{"line_number":102,"context_line":"in. if we updated port that were passed in it could break excising use cases"},{"line_number":103,"context_line":"where an end user set the desired name."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Second the floating ip dns_name is typically not the same as the instance"},{"line_number":106,"context_line":"FQDN. The instance hostname or FQDN is typically an internal name used in the"},{"line_number":107,"context_line":"application and the floating ip is used to expose a public name for the"},{"line_number":108,"context_line":"service. i.e. the instance might be called ``webserver.cloud.com`` where"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f9c020bd_50782abd","line":105,"range":{"start_line":105,"start_character":35,"end_line":105,"end_character":44},"in_reply_to":"67865d1e_f759885d","updated":"2022-11-15 11:01:56.000000000","message":"correct","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4173828d76b145c97a3e28904dcb10eba2c1dbc6","unresolved":false,"context_lines":[{"line_number":102,"context_line":"in. if we updated port that were passed in it could break excising use cases"},{"line_number":103,"context_line":"where an end user set the desired name."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Second the floating ip dns_name is typically not the same as the instance"},{"line_number":106,"context_line":"FQDN. The instance hostname or FQDN is typically an internal name used in the"},{"line_number":107,"context_line":"application and the floating ip is used to expose a public name for the"},{"line_number":108,"context_line":"service. i.e. the instance might be called ``webserver.cloud.com`` where"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4a11a439_6a2938aa","line":105,"range":{"start_line":105,"start_character":35,"end_line":105,"end_character":44},"in_reply_to":"f9c020bd_50782abd","updated":"2022-11-21 16:21:10.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":108,"context_line":"service. i.e. the instance might be called ``webserver.cloud.com`` where"},{"line_number":109,"context_line":"as the dns name of the floating ip might be ``blog.mysite.example.com``."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"given the two reasons above if nova was to propagate the name change we"},{"line_number":112,"context_line":"would need an attribute on the neutron port to opt into that behavior."},{"line_number":113,"context_line":"Since this is only useful when using designate and designate already"},{"line_number":114,"context_line":"monitors nova notification endpoint to update endpoint using the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"77689d70_689ff3c4","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":5},"updated":"2022-10-27 16:28:59.000000000","message":"\"Given\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":108,"context_line":"service. i.e. the instance might be called ``webserver.cloud.com`` where"},{"line_number":109,"context_line":"as the dns name of the floating ip might be ``blog.mysite.example.com``."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"given the two reasons above if nova was to propagate the name change we"},{"line_number":112,"context_line":"would need an attribute on the neutron port to opt into that behavior."},{"line_number":113,"context_line":"Since this is only useful when using designate and designate already"},{"line_number":114,"context_line":"monitors nova notification endpoint to update endpoint using the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"58e8c560_73108ea6","line":111,"range":{"start_line":111,"start_character":22,"end_line":111,"end_character":27},"updated":"2022-10-27 16:28:59.000000000","message":"\"above,\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":108,"context_line":"service. i.e. the instance might be called ``webserver.cloud.com`` where"},{"line_number":109,"context_line":"as the dns name of the floating ip might be ``blog.mysite.example.com``."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"given the two reasons above if nova was to propagate the name change we"},{"line_number":112,"context_line":"would need an attribute on the neutron port to opt into that behavior."},{"line_number":113,"context_line":"Since this is only useful when using designate and designate already"},{"line_number":114,"context_line":"monitors nova notification endpoint to update endpoint using the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"95d0fe6d_48722a8d","line":111,"range":{"start_line":111,"start_character":62,"end_line":111,"end_character":68},"updated":"2022-10-27 16:28:59.000000000","message":"\"change to the ports,\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":108,"context_line":"service. i.e. the instance might be called ``webserver.cloud.com`` where"},{"line_number":109,"context_line":"as the dns name of the floating ip might be ``blog.mysite.example.com``."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"given the two reasons above if nova was to propagate the name change we"},{"line_number":112,"context_line":"would need an attribute on the neutron port to opt into that behavior."},{"line_number":113,"context_line":"Since this is only useful when using designate and designate already"},{"line_number":114,"context_line":"monitors nova notification endpoint to update endpoint using the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4a861ffe_6a5ee793","line":111,"range":{"start_line":111,"start_character":22,"end_line":111,"end_character":27},"in_reply_to":"58e8c560_73108ea6","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":108,"context_line":"service. i.e. the instance might be called ``webserver.cloud.com`` where"},{"line_number":109,"context_line":"as the dns name of the floating ip might be ``blog.mysite.example.com``."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"given the two reasons above if nova was to propagate the name change we"},{"line_number":112,"context_line":"would need an attribute on the neutron port to opt into that behavior."},{"line_number":113,"context_line":"Since this is only useful when using designate and designate already"},{"line_number":114,"context_line":"monitors nova notification endpoint to update endpoint using the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d8eb8bf6_b6650dd4","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":5},"in_reply_to":"77689d70_689ff3c4","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":108,"context_line":"service. i.e. the instance might be called ``webserver.cloud.com`` where"},{"line_number":109,"context_line":"as the dns name of the floating ip might be ``blog.mysite.example.com``."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"given the two reasons above if nova was to propagate the name change we"},{"line_number":112,"context_line":"would need an attribute on the neutron port to opt into that behavior."},{"line_number":113,"context_line":"Since this is only useful when using designate and designate already"},{"line_number":114,"context_line":"monitors nova notification endpoint to update endpoint using the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b8e8e3fe_1f6bcfba","line":111,"range":{"start_line":111,"start_character":62,"end_line":111,"end_character":68},"in_reply_to":"95d0fe6d_48722a8d","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":109,"context_line":"as the dns name of the floating ip might be ``blog.mysite.example.com``."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"given the two reasons above if nova was to propagate the name change we"},{"line_number":112,"context_line":"would need an attribute on the neutron port to opt into that behavior."},{"line_number":113,"context_line":"Since this is only useful when using designate and designate already"},{"line_number":114,"context_line":"monitors nova notification endpoint to update endpoint using the"},{"line_number":115,"context_line":"designate-sink component, this functionality can be implemented using designate"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6b1e7a68_6a571463","line":112,"updated":"2022-10-27 16:28:59.000000000","message":"I\u0027m not sure why we\u0027d need an attribute on the port for this. Do you mean for user-created ports? Either way, I think you could just omit this as it\u0027s pretty clear by this point why this is not a good idea, IMHO.","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":109,"context_line":"as the dns name of the floating ip might be ``blog.mysite.example.com``."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"given the two reasons above if nova was to propagate the name change we"},{"line_number":112,"context_line":"would need an attribute on the neutron port to opt into that behavior."},{"line_number":113,"context_line":"Since this is only useful when using designate and designate already"},{"line_number":114,"context_line":"monitors nova notification endpoint to update endpoint using the"},{"line_number":115,"context_line":"designate-sink component, this functionality can be implemented using designate"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a6552808_e2e97b25","line":112,"in_reply_to":"6b1e7a68_6a571463","updated":"2022-11-15 11:01:56.000000000","message":"Ack","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":111,"context_line":"given the two reasons above if nova was to propagate the name change we"},{"line_number":112,"context_line":"would need an attribute on the neutron port to opt into that behavior."},{"line_number":113,"context_line":"Since this is only useful when using designate and designate already"},{"line_number":114,"context_line":"monitors nova notification endpoint to update endpoint using the"},{"line_number":115,"context_line":"designate-sink component, this functionality can be implemented using designate"},{"line_number":116,"context_line":"if they desire in the future."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"68d7b384_5170c7a6","line":114,"range":{"start_line":114,"start_character":9,"end_line":114,"end_character":13},"updated":"2022-10-27 16:28:59.000000000","message":"\"nova\u0027s\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":111,"context_line":"given the two reasons above if nova was to propagate the name change we"},{"line_number":112,"context_line":"would need an attribute on the neutron port to opt into that behavior."},{"line_number":113,"context_line":"Since this is only useful when using designate and designate already"},{"line_number":114,"context_line":"monitors nova notification endpoint to update endpoint using the"},{"line_number":115,"context_line":"designate-sink component, this functionality can be implemented using designate"},{"line_number":116,"context_line":"if they desire in the future."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"d20211f1_0ffe7320","line":114,"range":{"start_line":114,"start_character":46,"end_line":114,"end_character":54},"updated":"2022-10-27 16:28:59.000000000","message":"I think you meant some other word here?","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4173828d76b145c97a3e28904dcb10eba2c1dbc6","unresolved":false,"context_lines":[{"line_number":111,"context_line":"given the two reasons above if nova was to propagate the name change we"},{"line_number":112,"context_line":"would need an attribute on the neutron port to opt into that behavior."},{"line_number":113,"context_line":"Since this is only useful when using designate and designate already"},{"line_number":114,"context_line":"monitors nova notification endpoint to update endpoint using the"},{"line_number":115,"context_line":"designate-sink component, this functionality can be implemented using designate"},{"line_number":116,"context_line":"if they desire in the future."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"35b88c72_30a6cbd1","line":114,"range":{"start_line":114,"start_character":46,"end_line":114,"end_character":54},"in_reply_to":"58e2d83a_c7229e21","updated":"2022-11-21 16:21:10.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":111,"context_line":"given the two reasons above if nova was to propagate the name change we"},{"line_number":112,"context_line":"would need an attribute on the neutron port to opt into that behavior."},{"line_number":113,"context_line":"Since this is only useful when using designate and designate already"},{"line_number":114,"context_line":"monitors nova notification endpoint to update endpoint using the"},{"line_number":115,"context_line":"designate-sink component, this functionality can be implemented using designate"},{"line_number":116,"context_line":"if they desire in the future."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"cd2ff69d_13b05dea","line":114,"range":{"start_line":114,"start_character":9,"end_line":114,"end_character":13},"in_reply_to":"68d7b384_5170c7a6","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":true,"context_lines":[{"line_number":111,"context_line":"given the two reasons above if nova was to propagate the name change we"},{"line_number":112,"context_line":"would need an attribute on the neutron port to opt into that behavior."},{"line_number":113,"context_line":"Since this is only useful when using designate and designate already"},{"line_number":114,"context_line":"monitors nova notification endpoint to update endpoint using the"},{"line_number":115,"context_line":"designate-sink component, this functionality can be implemented using designate"},{"line_number":116,"context_line":"if they desire in the future."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"58e2d83a_c7229e21","line":114,"range":{"start_line":114,"start_character":46,"end_line":114,"end_character":54},"in_reply_to":"d20211f1_0ffe7320","updated":"2022-11-15 11:01:56.000000000","message":"ya the dns record for the fixed ip","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":113,"context_line":"Since this is only useful when using designate and designate already"},{"line_number":114,"context_line":"monitors nova notification endpoint to update endpoint using the"},{"line_number":115,"context_line":"designate-sink component, this functionality can be implemented using designate"},{"line_number":116,"context_line":"if they desire in the future."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"for these reasons updating the hostname in other service when its updated in"},{"line_number":119,"context_line":"nova is out of scope."}],"source_content_type":"text/x-rst","patch_set":1,"id":"91e29598_07e7129a","line":116,"range":{"start_line":116,"start_character":3,"end_line":116,"end_character":7},"updated":"2022-10-27 16:28:59.000000000","message":"I think there\u0027s no subject for this to match. Do you mean \"designate\" or \"the operator\" in this case?","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4173828d76b145c97a3e28904dcb10eba2c1dbc6","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Since this is only useful when using designate and designate already"},{"line_number":114,"context_line":"monitors nova notification endpoint to update endpoint using the"},{"line_number":115,"context_line":"designate-sink component, this functionality can be implemented using designate"},{"line_number":116,"context_line":"if they desire in the future."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"for these reasons updating the hostname in other service when its updated in"},{"line_number":119,"context_line":"nova is out of scope."}],"source_content_type":"text/x-rst","patch_set":1,"id":"2431e0c2_44e190af","line":116,"range":{"start_line":116,"start_character":3,"end_line":116,"end_character":7},"in_reply_to":"7615593a_32e3df30","updated":"2022-11-21 16:21:10.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":true,"context_lines":[{"line_number":113,"context_line":"Since this is only useful when using designate and designate already"},{"line_number":114,"context_line":"monitors nova notification endpoint to update endpoint using the"},{"line_number":115,"context_line":"designate-sink component, this functionality can be implemented using designate"},{"line_number":116,"context_line":"if they desire in the future."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"for these reasons updating the hostname in other service when its updated in"},{"line_number":119,"context_line":"nova is out of scope."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7615593a_32e3df30","line":116,"range":{"start_line":116,"start_character":3,"end_line":116,"end_character":7},"in_reply_to":"91e29598_07e7129a","updated":"2022-11-15 11:01:56.000000000","message":"yes designate","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":115,"context_line":"designate-sink component, this functionality can be implemented using designate"},{"line_number":116,"context_line":"if they desire in the future."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"for these reasons updating the hostname in other service when its updated in"},{"line_number":119,"context_line":"nova is out of scope."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"..NOTE::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a10a92a3_1ccef754","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":3},"updated":"2022-10-27 16:28:59.000000000","message":"\"For\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":115,"context_line":"designate-sink component, this functionality can be implemented using designate"},{"line_number":116,"context_line":"if they desire in the future."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"for these reasons updating the hostname in other service when its updated in"},{"line_number":119,"context_line":"nova is out of scope."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"..NOTE::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"445dd671_12197616","line":118,"range":{"start_line":118,"start_character":49,"end_line":118,"end_character":56},"updated":"2022-10-27 16:28:59.000000000","message":"\"services\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":115,"context_line":"designate-sink component, this functionality can be implemented using designate"},{"line_number":116,"context_line":"if they desire in the future."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"for these reasons updating the hostname in other service when its updated in"},{"line_number":119,"context_line":"nova is out of scope."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"..NOTE::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fb2acdba_30a381d1","line":118,"range":{"start_line":118,"start_character":49,"end_line":118,"end_character":56},"in_reply_to":"445dd671_12197616","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":115,"context_line":"designate-sink component, this functionality can be implemented using designate"},{"line_number":116,"context_line":"if they desire in the future."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"for these reasons updating the hostname in other service when its updated in"},{"line_number":119,"context_line":"nova is out of scope."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"..NOTE::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"706ac0a0_dc857174","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":3},"in_reply_to":"a10a92a3_1ccef754","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":121,"context_line":"..NOTE::"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"  As is done today, if the instance.hostname is updated on an instance it will"},{"line_number":124,"context_line":"  be updated in the metadata service but not in the config derive if one is"},{"line_number":125,"context_line":"  used. if the config-drive is ever regenerated such as via a cross cell"},{"line_number":126,"context_line":"  resize then the new value will be available to the guest via the"},{"line_number":127,"context_line":"  config drive. This does not change the behavior form before this change."}],"source_content_type":"text/x-rst","patch_set":1,"id":"049e0594_e361baf4","line":124,"range":{"start_line":124,"start_character":59,"end_line":124,"end_character":65},"updated":"2022-10-27 16:28:59.000000000","message":"\"drive\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":121,"context_line":"..NOTE::"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"  As is done today, if the instance.hostname is updated on an instance it will"},{"line_number":124,"context_line":"  be updated in the metadata service but not in the config derive if one is"},{"line_number":125,"context_line":"  used. if the config-drive is ever regenerated such as via a cross cell"},{"line_number":126,"context_line":"  resize then the new value will be available to the guest via the"},{"line_number":127,"context_line":"  config drive. This does not change the behavior form before this change."}],"source_content_type":"text/x-rst","patch_set":1,"id":"a59db939_54f2bb45","line":124,"range":{"start_line":124,"start_character":59,"end_line":124,"end_character":65},"in_reply_to":"049e0594_e361baf4","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"  As is done today, if the instance.hostname is updated on an instance it will"},{"line_number":124,"context_line":"  be updated in the metadata service but not in the config derive if one is"},{"line_number":125,"context_line":"  used. if the config-drive is ever regenerated such as via a cross cell"},{"line_number":126,"context_line":"  resize then the new value will be available to the guest via the"},{"line_number":127,"context_line":"  config drive. This does not change the behavior form before this change."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"517865ee_797d22ea","line":125,"updated":"2022-10-27 16:28:59.000000000","message":"\"If\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"  As is done today, if the instance.hostname is updated on an instance it will"},{"line_number":124,"context_line":"  be updated in the metadata service but not in the config derive if one is"},{"line_number":125,"context_line":"  used. if the config-drive is ever regenerated such as via a cross cell"},{"line_number":126,"context_line":"  resize then the new value will be available to the guest via the"},{"line_number":127,"context_line":"  config drive. This does not change the behavior form before this change."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"557526b6_bba2f2f0","line":125,"in_reply_to":"517865ee_797d22ea","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":124,"context_line":"  be updated in the metadata service but not in the config derive if one is"},{"line_number":125,"context_line":"  used. if the config-drive is ever regenerated such as via a cross cell"},{"line_number":126,"context_line":"  resize then the new value will be available to the guest via the"},{"line_number":127,"context_line":"  config drive. This does not change the behavior form before this change."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ee2ebd95_bc57cb30","line":127,"range":{"start_line":127,"start_character":50,"end_line":127,"end_character":54},"updated":"2022-10-27 16:28:59.000000000","message":"\"from\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  be updated in the metadata service but not in the config derive if one is"},{"line_number":125,"context_line":"  used. if the config-drive is ever regenerated such as via a cross cell"},{"line_number":126,"context_line":"  resize then the new value will be available to the guest via the"},{"line_number":127,"context_line":"  config drive. This does not change the behavior form before this change."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c926c39f_72cfa0b1","line":127,"range":{"start_line":127,"start_character":50,"end_line":127,"end_character":54},"in_reply_to":"ee2ebd95_bc57cb30","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"None"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"The database field is already large enough to hold any vlaid FQDN so no change"},{"line_number":136,"context_line":"are required to the db. The instance object declares the hostname field as a"},{"line_number":137,"context_line":"string and also requires no changes."},{"line_number":138,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"e026087a_8beba830","line":135,"range":{"start_line":135,"start_character":72,"end_line":135,"end_character":78},"updated":"2022-10-27 16:28:59.000000000","message":"\"changes\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"None"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"The database field is already large enough to hold any vlaid FQDN so no change"},{"line_number":136,"context_line":"are required to the db. The instance object declares the hostname field as a"},{"line_number":137,"context_line":"string and also requires no changes."},{"line_number":138,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"d6c3bde4_cef9cfb1","line":135,"range":{"start_line":135,"start_character":55,"end_line":135,"end_character":60},"updated":"2022-10-27 16:28:59.000000000","message":"\"valid\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"None"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"The database field is already large enough to hold any vlaid FQDN so no change"},{"line_number":136,"context_line":"are required to the db. The instance object declares the hostname field as a"},{"line_number":137,"context_line":"string and also requires no changes."},{"line_number":138,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"e36bee88_a44d83e5","line":135,"range":{"start_line":135,"start_character":55,"end_line":135,"end_character":60},"in_reply_to":"d6c3bde4_cef9cfb1","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"None"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"The database field is already large enough to hold any vlaid FQDN so no change"},{"line_number":136,"context_line":"are required to the db. The instance object declares the hostname field as a"},{"line_number":137,"context_line":"string and also requires no changes."},{"line_number":138,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fd6caac3_946255e6","line":135,"range":{"start_line":135,"start_character":72,"end_line":135,"end_character":78},"in_reply_to":"e026087a_8beba830","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"60233420ea2dcc40e59798f7711c8f2954219845","unresolved":true,"context_lines":[{"line_number":135,"context_line":"The database field is already large enough to hold any vlaid FQDN so no change"},{"line_number":136,"context_line":"are required to the db. The instance object declares the hostname field as a"},{"line_number":137,"context_line":"string and also requires no changes."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"REST API impact"},{"line_number":140,"context_line":"---------------"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff32c797_6bcd5932","line":138,"updated":"2022-10-27 10:45:26.000000000","message":"Will this fqdn get saved in hostname column of instances table ?\n      as mentioned right now by default it saves same value as display name.\n      will we have different display-name and hostname ?\n      or the value be same but now as a valid fqdn as well ?\n      \nOR as mentioned \"None impact\", so while creating instance set user passed name/fqdn as name in xml.","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1e76c1cb5ec8518ee8c53116b0a9f1630c791be3","unresolved":false,"context_lines":[{"line_number":135,"context_line":"The database field is already large enough to hold any vlaid FQDN so no change"},{"line_number":136,"context_line":"are required to the db. The instance object declares the hostname field as a"},{"line_number":137,"context_line":"string and also requires no changes."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"REST API impact"},{"line_number":140,"context_line":"---------------"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"59fb997d_f64ee744","line":138,"in_reply_to":"a57f4e78_e2f6555c","updated":"2022-10-27 12:11:03.000000000","message":"Ack","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dd604ab76798dc194d10a652d7ef7c025a3619e1","unresolved":true,"context_lines":[{"line_number":135,"context_line":"The database field is already large enough to hold any vlaid FQDN so no change"},{"line_number":136,"context_line":"are required to the db. The instance object declares the hostname field as a"},{"line_number":137,"context_line":"string and also requires no changes."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"REST API impact"},{"line_number":140,"context_line":"---------------"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"a57f4e78_e2f6555c","line":138,"in_reply_to":"ff32c797_6bcd5932","updated":"2022-10-27 11:48:57.000000000","message":"you can already have a differnt displayname and hostname today.\nthe hostnaem however is requried to not contain \".\" and limited to 63 characters\nso yes this will be stored in the instace.hostname filed\nhttps://github.com/openstack/nova/blob/master/nova/objects/instance.py#L129\nhttps://github.com/openstack/nova/blob/master/nova/db/main/models.py#L327\n\nthe hostname is not really stored in the xml today","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":140,"context_line":"---------------"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"A new api microverion will be introduced to allow FQDNs in the hostname field."},{"line_number":143,"context_line":"minor changes will be required to conditionally change the lenght restriction"},{"line_number":144,"context_line":"and disable some of the current validation when the new micorversion is used"},{"line_number":145,"context_line":"but the code will remain for older microverions."},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"28a7c9e1_490e5f91","line":143,"range":{"start_line":143,"start_character":59,"end_line":143,"end_character":65},"updated":"2022-10-27 16:28:59.000000000","message":"\"length\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":140,"context_line":"---------------"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"A new api microverion will be introduced to allow FQDNs in the hostname field."},{"line_number":143,"context_line":"minor changes will be required to conditionally change the lenght restriction"},{"line_number":144,"context_line":"and disable some of the current validation when the new micorversion is used"},{"line_number":145,"context_line":"but the code will remain for older microverions."},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"2bf3e4de_73ddd296","line":143,"range":{"start_line":143,"start_character":59,"end_line":143,"end_character":65},"in_reply_to":"28a7c9e1_490e5f91","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"A new api microverion will be introduced to allow FQDNs in the hostname field."},{"line_number":143,"context_line":"minor changes will be required to conditionally change the lenght restriction"},{"line_number":144,"context_line":"and disable some of the current validation when the new micorversion is used"},{"line_number":145,"context_line":"but the code will remain for older microverions."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"63cd13ae_146250f7","line":144,"range":{"start_line":144,"start_character":56,"end_line":144,"end_character":68},"updated":"2022-10-27 16:28:59.000000000","message":"\"microversion\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"A new api microverion will be introduced to allow FQDNs in the hostname field."},{"line_number":143,"context_line":"minor changes will be required to conditionally change the lenght restriction"},{"line_number":144,"context_line":"and disable some of the current validation when the new micorversion is used"},{"line_number":145,"context_line":"but the code will remain for older microverions."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"a52319c2_7c3ce43a","line":144,"range":{"start_line":144,"start_character":56,"end_line":144,"end_character":68},"in_reply_to":"63cd13ae_146250f7","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":142,"context_line":"A new api microverion will be introduced to allow FQDNs in the hostname field."},{"line_number":143,"context_line":"minor changes will be required to conditionally change the lenght restriction"},{"line_number":144,"context_line":"and disable some of the current validation when the new micorversion is used"},{"line_number":145,"context_line":"but the code will remain for older microverions."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fcc14df2_964fe197","line":145,"range":{"start_line":145,"start_character":35,"end_line":145,"end_character":47},"updated":"2022-10-27 16:28:59.000000000","message":"\"microversions\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":142,"context_line":"A new api microverion will be introduced to allow FQDNs in the hostname field."},{"line_number":143,"context_line":"minor changes will be required to conditionally change the lenght restriction"},{"line_number":144,"context_line":"and disable some of the current validation when the new micorversion is used"},{"line_number":145,"context_line":"but the code will remain for older microverions."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2458ce21_ab4aeb4f","line":145,"range":{"start_line":145,"start_character":35,"end_line":145,"end_character":47},"in_reply_to":"fcc14df2_964fe197","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":158,"context_line":"Other end user impact"},{"line_number":159,"context_line":"---------------------"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Enduser will be able to set the hostname of there vm to an FQDN however without"},{"line_number":162,"context_line":"using a external service like designate to advertise that FQDN it may not be"},{"line_number":163,"context_line":"resolvable without manual intervention."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"2121f8b5_d261d36e","line":161,"range":{"start_line":161,"start_character":0,"end_line":161,"end_character":7},"updated":"2022-10-27 16:28:59.000000000","message":"\"End users\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":158,"context_line":"Other end user impact"},{"line_number":159,"context_line":"---------------------"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Enduser will be able to set the hostname of there vm to an FQDN however without"},{"line_number":162,"context_line":"using a external service like designate to advertise that FQDN it may not be"},{"line_number":163,"context_line":"resolvable without manual intervention."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"0a92178c_d844cf2f","line":161,"range":{"start_line":161,"start_character":44,"end_line":161,"end_character":49},"updated":"2022-10-27 16:28:59.000000000","message":"\"their\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":158,"context_line":"Other end user impact"},{"line_number":159,"context_line":"---------------------"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Enduser will be able to set the hostname of there vm to an FQDN however without"},{"line_number":162,"context_line":"using a external service like designate to advertise that FQDN it may not be"},{"line_number":163,"context_line":"resolvable without manual intervention."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"813d411d_04ee171c","line":161,"range":{"start_line":161,"start_character":44,"end_line":161,"end_character":49},"in_reply_to":"0a92178c_d844cf2f","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":158,"context_line":"Other end user impact"},{"line_number":159,"context_line":"---------------------"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Enduser will be able to set the hostname of there vm to an FQDN however without"},{"line_number":162,"context_line":"using a external service like designate to advertise that FQDN it may not be"},{"line_number":163,"context_line":"resolvable without manual intervention."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"110ab268_24f26117","line":161,"range":{"start_line":161,"start_character":0,"end_line":161,"end_character":7},"in_reply_to":"2121f8b5_d261d36e","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":162,"context_line":"using a external service like designate to advertise that FQDN it may not be"},{"line_number":163,"context_line":"resolvable without manual intervention."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Nova provides no garentee of uniqueness or reachability of the FQDN provided"},{"line_number":166,"context_line":"by the end user."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"As is the case today, nova will only set the dns_name on a neutron port once"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7000d3c2_14c022a3","line":165,"range":{"start_line":165,"start_character":17,"end_line":165,"end_character":25},"updated":"2022-10-27 16:28:59.000000000","message":"\"guarantee\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":162,"context_line":"using a external service like designate to advertise that FQDN it may not be"},{"line_number":163,"context_line":"resolvable without manual intervention."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Nova provides no garentee of uniqueness or reachability of the FQDN provided"},{"line_number":166,"context_line":"by the end user."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"As is the case today, nova will only set the dns_name on a neutron port once"}],"source_content_type":"text/x-rst","patch_set":1,"id":"76ad0f1d_e32951fa","line":165,"range":{"start_line":165,"start_character":17,"end_line":165,"end_character":25},"in_reply_to":"7000d3c2_14c022a3","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"As is the case today, nova will only set the dns_name on a neutron port once"},{"line_number":169,"context_line":"when the server is first created. If the end user updates the instance.hostname"},{"line_number":170,"context_line":"it will be upated in the nova db and become visible in the metadata api"},{"line_number":171,"context_line":"hostname field. It is out of scope of the nova project to propagate this"},{"line_number":172,"context_line":"hostname change to any neutron ports, floating ips or dns records."},{"line_number":173,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"61caa430_dd44e83d","line":170,"range":{"start_line":170,"start_character":11,"end_line":170,"end_character":17},"updated":"2022-10-27 16:28:59.000000000","message":"\"updated\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"As is the case today, nova will only set the dns_name on a neutron port once"},{"line_number":169,"context_line":"when the server is first created. If the end user updates the instance.hostname"},{"line_number":170,"context_line":"it will be upated in the nova db and become visible in the metadata api"},{"line_number":171,"context_line":"hostname field. It is out of scope of the nova project to propagate this"},{"line_number":172,"context_line":"hostname change to any neutron ports, floating ips or dns records."},{"line_number":173,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"29875de6_a70e1fb0","line":170,"range":{"start_line":170,"start_character":11,"end_line":170,"end_character":17},"in_reply_to":"61caa430_dd44e83d","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"60233420ea2dcc40e59798f7711c8f2954219845","unresolved":true,"context_lines":[{"line_number":171,"context_line":"hostname field. It is out of scope of the nova project to propagate this"},{"line_number":172,"context_line":"hostname change to any neutron ports, floating ips or dns records."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Performance Impact"},{"line_number":176,"context_line":"------------------"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"82ed1c03_2583849d","line":174,"updated":"2022-10-27 10:45:26.000000000","message":"if nova save fqdn in hostname field in DB, nova-api can verify if instance with same hostname already exists or not.","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dd604ab76798dc194d10a652d7ef7c025a3619e1","unresolved":true,"context_lines":[{"line_number":171,"context_line":"hostname field. It is out of scope of the nova project to propagate this"},{"line_number":172,"context_line":"hostname change to any neutron ports, floating ips or dns records."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Performance Impact"},{"line_number":176,"context_line":"------------------"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ea8f0060_e3e3ddb2","line":174,"in_reply_to":"82ed1c03_2583849d","updated":"2022-10-27 11:48:57.000000000","message":"it will save it there but i don\u0027t really want nova to verify this.\ni think its out of scope of nova to do this which is why i wrote this to clearly call out that we wont attempt to do that.\n\nits not really in line with our project scoep to do orcstration or networkign\nhttps://docs.openstack.org/nova/latest/contributor/project-scope.html","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1e76c1cb5ec8518ee8c53116b0a9f1630c791be3","unresolved":false,"context_lines":[{"line_number":171,"context_line":"hostname field. It is out of scope of the nova project to propagate this"},{"line_number":172,"context_line":"hostname change to any neutron ports, floating ips or dns records."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Performance Impact"},{"line_number":176,"context_line":"------------------"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3d29900b_10a7d3e5","line":174,"in_reply_to":"ea8f0060_e3e3ddb2","updated":"2022-10-27 12:11:03.000000000","message":"Ack","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"remove api restriction"},{"line_number":223,"context_line":"update api sample tests"},{"line_number":224,"context_line":"update osc"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Dependencies"},{"line_number":227,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ec8cdfdb_caa89ed1","line":224,"updated":"2022-10-27 16:28:59.000000000","message":"Make a list? This is also probably a little too terse. There\u0027s a microversion in there right?","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"remove api restriction"},{"line_number":223,"context_line":"update api sample tests"},{"line_number":224,"context_line":"update osc"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Dependencies"},{"line_number":227,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e89243ea_3df5549e","line":224,"in_reply_to":"ec8cdfdb_caa89ed1","updated":"2022-11-15 11:01:56.000000000","message":"Ack","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3ed2c9d817cbc4eafb83f9c00c87fab6a5368f40","unresolved":true,"context_lines":[{"line_number":232,"context_line":"Testing"},{"line_number":233,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"This can be entirly tested with api/functional tests."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9024b9b4_469144d8","line":235,"range":{"start_line":235,"start_character":12,"end_line":235,"end_character":19},"updated":"2022-10-27 16:28:59.000000000","message":"\"entirely\"","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f428291d14bfdc5905df2b9166ada39a3cad81b8","unresolved":false,"context_lines":[{"line_number":232,"context_line":"Testing"},{"line_number":233,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"This can be entirly tested with api/functional tests."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bee77c25_8b11b78a","line":235,"range":{"start_line":235,"start_character":12,"end_line":235,"end_character":19},"in_reply_to":"9024b9b4_469144d8","updated":"2022-11-15 11:01:56.000000000","message":"Done","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"60233420ea2dcc40e59798f7711c8f2954219845","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c4ca1631_86bd1689","line":259,"updated":"2022-10-27 10:45:26.000000000","message":"This comment is to mention all typos, moved here so reader can enjoy content without seeing these one liners.\n\nLine_num: typo\n24: guarantee\n26: extend\n42, 46: I \n53: length\n54: legal\n135: valid\n143: length","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1e76c1cb5ec8518ee8c53116b0a9f1630c791be3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"93f0a8b4_758a932b","line":259,"in_reply_to":"93204726_de2ffd98","updated":"2022-10-27 12:11:03.000000000","message":"Ack","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dd604ab76798dc194d10a652d7ef7c025a3619e1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"93204726_de2ffd98","line":259,"in_reply_to":"c4ca1631_86bd1689","updated":"2022-10-27 11:48:57.000000000","message":"thanks but it would be better to mention them directly on the relevent lines in future.","commit_id":"c30201f8b62ff64badf534c1dabd7256b6273bb3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"53557028e41252c7b63ea1304cbd7316da43caca","unresolved":true,"context_lines":[{"line_number":24,"context_line":"Given the filtering of FQDN like strings was not done as a spec or feature"},{"line_number":25,"context_line":"nova never provided an API guarantee that FQDNs can be used when creating a"},{"line_number":26,"context_line":"server. After several bug reports of undesirable interactions with Designate"},{"line_number":27,"context_line":"we decided to extned the normalization that removes non-ASCII alpha-numeric"},{"line_number":28,"context_line":"character to also remove periods ``.`` from the hostname when"},{"line_number":29,"context_line":"initalising it form the display name."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"afd90ef5_f841470e","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":20},"updated":"2022-11-15 14:42:39.000000000","message":"nit: extend","commit_id":"c5ab5bfa69a0b7f104e4d7735db8ac777868dab0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4173828d76b145c97a3e28904dcb10eba2c1dbc6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Given the filtering of FQDN like strings was not done as a spec or feature"},{"line_number":25,"context_line":"nova never provided an API guarantee that FQDNs can be used when creating a"},{"line_number":26,"context_line":"server. After several bug reports of undesirable interactions with Designate"},{"line_number":27,"context_line":"we decided to extned the normalization that removes non-ASCII alpha-numeric"},{"line_number":28,"context_line":"character to also remove periods ``.`` from the hostname when"},{"line_number":29,"context_line":"initalising it form the display name."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ffe74982_10ccab32","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":20},"in_reply_to":"afd90ef5_f841470e","updated":"2022-11-21 16:21:10.000000000","message":"Done","commit_id":"c5ab5bfa69a0b7f104e4d7735db8ac777868dab0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"53557028e41252c7b63ea1304cbd7316da43caca","unresolved":true,"context_lines":[{"line_number":26,"context_line":"server. After several bug reports of undesirable interactions with Designate"},{"line_number":27,"context_line":"we decided to extned the normalization that removes non-ASCII alpha-numeric"},{"line_number":28,"context_line":"character to also remove periods ``.`` from the hostname when"},{"line_number":29,"context_line":"initalising it form the display name."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"In the Xena release we also introduced configurable instance hostnames by"},{"line_number":32,"context_line":"exposing the hostname field directly in the API but maintained our"}],"source_content_type":"text/x-rst","patch_set":2,"id":"8b487058_56dfbc45","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":11},"updated":"2022-11-15 14:42:39.000000000","message":"nit: initialising","commit_id":"c5ab5bfa69a0b7f104e4d7735db8ac777868dab0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4173828d76b145c97a3e28904dcb10eba2c1dbc6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"server. After several bug reports of undesirable interactions with Designate"},{"line_number":27,"context_line":"we decided to extned the normalization that removes non-ASCII alpha-numeric"},{"line_number":28,"context_line":"character to also remove periods ``.`` from the hostname when"},{"line_number":29,"context_line":"initalising it form the display name."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"In the Xena release we also introduced configurable instance hostnames by"},{"line_number":32,"context_line":"exposing the hostname field directly in the API but maintained our"}],"source_content_type":"text/x-rst","patch_set":2,"id":"8325c17e_7a34ec40","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":11},"in_reply_to":"8b487058_56dfbc45","updated":"2022-11-21 16:21:10.000000000","message":"Done","commit_id":"c5ab5bfa69a0b7f104e4d7735db8ac777868dab0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"96d4f7c2a224cab7626478353bff0a2dc11d0960","unresolved":true,"context_lines":[{"line_number":51,"context_line":"Proposed change"},{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":53,"context_line":"- add a new api microversion to opt into using an FQDN in the hostname field."},{"line_number":54,"context_line":"- increase the character length limit on the host name filed form 63 to 255"},{"line_number":55,"context_line":"- remove the rejection of \".\" and other legal characters in a FQDN."},{"line_number":56,"context_line":"- change multi-create instance format to prefix with an index instead"},{"line_number":57,"context_line":"  of suffixing. e.g. ``\u003cindex\u003e-my.instance.example.com``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"a2324e62_3c7b74ce","line":54,"range":{"start_line":54,"start_character":61,"end_line":54,"end_character":65},"updated":"2022-12-14 09:01:09.000000000","message":"nit: from","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"96d4f7c2a224cab7626478353bff0a2dc11d0960","unresolved":true,"context_lines":[{"line_number":54,"context_line":"- increase the character length limit on the host name filed form 63 to 255"},{"line_number":55,"context_line":"- remove the rejection of \".\" and other legal characters in a FQDN."},{"line_number":56,"context_line":"- change multi-create instance format to prefix with an index instead"},{"line_number":57,"context_line":"  of suffixing. e.g. ``\u003cindex\u003e-my.instance.example.com``"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  This is allowed per section 2.1 of"},{"line_number":60,"context_line":"  https://datatracker.ietf.org/doc/html/rfc1123#page-13"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f5ffdd8_9bfeb84b","line":57,"updated":"2022-12-14 09:01:09.000000000","message":"this is unfortunately a huge impact for people using multi-create as I guess they have a lot of python scripts (or other tools).\nMaybe should we just say to not accepting to use FQDN names for multi-create instances ?","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4b9a0ce98a727226f8536de95cd79eacf05c2852","unresolved":true,"context_lines":[{"line_number":54,"context_line":"- increase the character length limit on the host name filed form 63 to 255"},{"line_number":55,"context_line":"- remove the rejection of \".\" and other legal characters in a FQDN."},{"line_number":56,"context_line":"- change multi-create instance format to prefix with an index instead"},{"line_number":57,"context_line":"  of suffixing. e.g. ``\u003cindex\u003e-my.instance.example.com``"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  This is allowed per section 2.1 of"},{"line_number":60,"context_line":"  https://datatracker.ietf.org/doc/html/rfc1123#page-13"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da764579_e01aa98a","line":57,"in_reply_to":"7f5ffdd8_9bfeb84b","updated":"2022-12-14 13:12:59.000000000","message":"that is an option however i am not in favour of allowing it in a speerate microversion\n\ni do not share your consern with changign the format.\nits not part of our public api contract.","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"96d4f7c2a224cab7626478353bff0a2dc11d0960","unresolved":false,"context_lines":[{"line_number":89,"context_line":"e.g. openstack server create --hostname my-host --domain my.domain.com ..."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"This is better then --FQDN but still requires a db and object changes for"},{"line_number":92,"context_line":"little benefit."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Nova could implement the proposed change but block multi-create with FQDNs."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1d78c10a_b51f169b","line":92,"updated":"2022-12-14 09:01:09.000000000","message":"also this parameter should be something like a network value...","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"96d4f7c2a224cab7626478353bff0a2dc11d0960","unresolved":true,"context_lines":[{"line_number":91,"context_line":"This is better then --FQDN but still requires a db and object changes for"},{"line_number":92,"context_line":"little benefit."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Nova could implement the proposed change but block multi-create with FQDNs."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"While this would avoid changing the hostname template form a suffix to prefix"},{"line_number":97,"context_line":"in the new microversion it is a trivial code change and does not add much"}],"source_content_type":"text/x-rst","patch_set":3,"id":"abf32335_19d09fb5","line":94,"updated":"2022-12-14 09:01:09.000000000","message":"yes, please, I\u0027d prefer this.","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4b9a0ce98a727226f8536de95cd79eacf05c2852","unresolved":true,"context_lines":[{"line_number":91,"context_line":"This is better then --FQDN but still requires a db and object changes for"},{"line_number":92,"context_line":"little benefit."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Nova could implement the proposed change but block multi-create with FQDNs."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"While this would avoid changing the hostname template form a suffix to prefix"},{"line_number":97,"context_line":"in the new microversion it is a trivial code change and does not add much"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9bdddc8f_5d1ce739","line":94,"in_reply_to":"abf32335_19d09fb5","updated":"2022-12-14 13:12:59.000000000","message":"if we do this i would not be in favour of ever support FQDN for multi create in the future.","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"96d4f7c2a224cab7626478353bff0a2dc11d0960","unresolved":true,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Nova could implement the proposed change but block multi-create with FQDNs."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"While this would avoid changing the hostname template form a suffix to prefix"},{"line_number":97,"context_line":"in the new microversion it is a trivial code change and does not add much"},{"line_number":98,"context_line":"complexity vs multi-create in general."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fd8e5b2_f9670320","line":96,"range":{"start_line":96,"start_character":54,"end_line":96,"end_character":58},"updated":"2022-12-14 09:01:09.000000000","message":"nit: from","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"96d4f7c2a224cab7626478353bff0a2dc11d0960","unresolved":true,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"While this would avoid changing the hostname template form a suffix to prefix"},{"line_number":97,"context_line":"in the new microversion it is a trivial code change and does not add much"},{"line_number":98,"context_line":"complexity vs multi-create in general."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Nova could try to propagate hostname changes to neutron ports and floating IPs."},{"line_number":101,"context_line":"This is seen as risky, complex and hard to understand."}],"source_content_type":"text/x-rst","patch_set":3,"id":"4de3e8e5_f2d86895","line":98,"updated":"2022-12-14 09:01:09.000000000","message":"well, maybe this should be trivial for our code, but not for operators using multi-creates...","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4b9a0ce98a727226f8536de95cd79eacf05c2852","unresolved":true,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"While this would avoid changing the hostname template form a suffix to prefix"},{"line_number":97,"context_line":"in the new microversion it is a trivial code change and does not add much"},{"line_number":98,"context_line":"complexity vs multi-create in general."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Nova could try to propagate hostname changes to neutron ports and floating IPs."},{"line_number":101,"context_line":"This is seen as risky, complex and hard to understand."}],"source_content_type":"text/x-rst","patch_set":3,"id":"921379c6_a78f8d69","line":98,"in_reply_to":"4de3e8e5_f2d86895","updated":"2022-12-14 13:12:59.000000000","message":"for operators usign multi create theyer code is broken if they are dependin on the hostname formant and not reading the hostname form the server show responce","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"96d4f7c2a224cab7626478353bff0a2dc11d0960","unresolved":true,"context_lines":[{"line_number":175,"context_line":"the metadata API hostname field. It is out of scope of the nova project to"},{"line_number":176,"context_line":"propagate this hostname change to any neutron ports, floating IPs or"},{"line_number":177,"context_line":"dns records."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Performance Impact"},{"line_number":181,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"81ad1ef9_24edaa2c","line":178,"updated":"2022-12-14 09:01:09.000000000","message":"you\u0027re missing the large impact for an end user using multi-create.","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"dfb5d34503333bf4376618f41dcc88cdb7987965","unresolved":true,"context_lines":[{"line_number":175,"context_line":"the metadata API hostname field. It is out of scope of the nova project to"},{"line_number":176,"context_line":"propagate this hostname change to any neutron ports, floating IPs or"},{"line_number":177,"context_line":"dns records."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Performance Impact"},{"line_number":181,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8e2bd64d_e21908e5","line":178,"in_reply_to":"2950ebbf_9ee1b485","updated":"2022-12-14 16:57:36.000000000","message":"\u003e maybe i did not state this properly.\n\nNo, this is who was unclear. See below.\n\n\u003e \n\u003e as such i do not see any upgrade impact since this is garded behind the new microverions.\n\nCorrect. My concern doesn\u0027t come by a behavioural change we missed, but rather by the fact we hit our users on the road for something they probably don\u0027t need.\nI mean, adding FQDNs in our hostname is a maybe nice feature but I don\u0027t see the reason why we should trample our 99% other users that use multicreate and don\u0027t care of FQDNs in hostnames (because they also know this is quite bizarre to add a domain information as a substring of a hostname, but meh).\n\nSo, my proposal would be :\n- add a microversion that will support FQDNs *without* support for multi-create (meaning you can\u0027t do both)\n- add *maybe* later a microversion that would add support for multicreate with FQDNs","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2377a06df90af85a1c3044c6a730ffb13e28609e","unresolved":true,"context_lines":[{"line_number":175,"context_line":"the metadata API hostname field. It is out of scope of the nova project to"},{"line_number":176,"context_line":"propagate this hostname change to any neutron ports, floating IPs or"},{"line_number":177,"context_line":"dns records."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Performance Impact"},{"line_number":181,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d078d76d_ab9a877d","line":178,"in_reply_to":"2b67be04_bdfa9846","updated":"2022-12-14 14:37:37.000000000","message":"Sorry but no, I think it\u0027s not an implementation issue, it\u0027s rather a upgrade modification if they call to the latest API microversion hence my point.","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4b9a0ce98a727226f8536de95cd79eacf05c2852","unresolved":true,"context_lines":[{"line_number":175,"context_line":"the metadata API hostname field. It is out of scope of the nova project to"},{"line_number":176,"context_line":"propagate this hostname change to any neutron ports, floating IPs or"},{"line_number":177,"context_line":"dns records."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Performance Impact"},{"line_number":181,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"2b67be04_bdfa9846","line":178,"in_reply_to":"81ad1ef9_24edaa2c","updated":"2022-12-14 13:12:59.000000000","message":"i disagreee that this is a large or even small impact.\n\nlets see what others think but we provide no garunetees implied or otherwise with regards to hostname format for multi create.\n\n\nits an implmenation detail not a part of our api specifciation.","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3aa6e75e63a0dda971ae77b99ac2599dec9c542e","unresolved":true,"context_lines":[{"line_number":175,"context_line":"the metadata API hostname field. It is out of scope of the nova project to"},{"line_number":176,"context_line":"propagate this hostname change to any neutron ports, floating IPs or"},{"line_number":177,"context_line":"dns records."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Performance Impact"},{"line_number":181,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8df65228_46226fe9","line":178,"in_reply_to":"8e2bd64d_e21908e5","updated":"2022-12-14 17:36:38.000000000","message":"OK, after a few double-checks, I eventually found that we *don\u0027t* have an API contract for how we name our multi-create instances.\nhttps://docs.openstack.org/api-ref/compute/?expanded\u003dcreate-multiple-servers-detail#create-multiple-servers\n\nAccordingly, the naming change isn\u0027t a behavioural change we\u0027re officially needing to do by a microversion.\n\nFor *that* specific reason, I now consider the hostname change as an implementation detail (even if this hurts 99% of users that do multi-create) and I can explain that if they feel they\u0027re impacted, that\u0027s unfortunate but they can later parse the hostname by a server show.\n\nThat said, other cores may share the same concern. I hereby propose then to merge this spec as it is, ask to have the multicreate naming change (suffix to prefix) be done in a specific patch in the series (ideally the last) and let people review that during the implementation phase.\nIf, during those reviews, we may arrive to another solution (like enforcing a third solution, which could be to stick with the suffix on an hostname-like part of the FQDN (guessed magically by Nova)), then we could later modify this spec to make it consistent with the reality.\n\nEither way, I think this is time for us to make a contract on the multicreate naming, which should be done by this API microversion we\u0027re going to write for supporting FQDNs.","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b695467b4fd438da5f9e607f2b83a19739c4e6bb","unresolved":true,"context_lines":[{"line_number":175,"context_line":"the metadata API hostname field. It is out of scope of the nova project to"},{"line_number":176,"context_line":"propagate this hostname change to any neutron ports, floating IPs or"},{"line_number":177,"context_line":"dns records."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"Performance Impact"},{"line_number":181,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"2950ebbf_9ee1b485","line":178,"in_reply_to":"d078d76d_ab9a877d","updated":"2022-12-14 16:45:29.000000000","message":"maybe i did not state this properly.\n\nfrom my persepctive in teh old microversion FQDNs were not supported\n\nsupport for FQDNs will be added in teh new microverison\n\nexisting user of multi create can continue to use teh old api microverion to get the old name format.\n\nby useing the new microverion they are explictly opting in to the new behavior including the new name format.\n\n\nas such i do not see any upgrade impact since this is garded behind the new microverions.","commit_id":"b9e92bb0f0174a622448a684f05f2c450f9829b3"}]}