)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9847,"name":"ricky.bo","email":"boh.ricky@gmail.com","username":"boh.ricky"},"change_message_id":"7f65b9c7acb5aa8e82fd1e14bfe06320485aa0c7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-04-14 18:59:07 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Spec proposal to enable configuring tcp keepalive"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iceb316278069799b8c3ed1ca4c63f83fdf5b444c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAW3%2F%2FT1A%3D","line":8,"updated":"2014-04-15 12:51:39.000000000","message":"please change this to:   \n\nblueprint blueprint_page_name  \n\nThat way gerrit will add the links to this change correctly.","commit_id":"c5793cd5e4af510e6c60ce4262368b7cb3689672"},{"author":{"_account_id":9608,"name":"Pranesh Pandurangan","email":"praneshpg@gmail.com","username":"pran1990"},"change_message_id":"5424bcf80dd62ed7f21646f056ba4794b8e444db","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-04-14 18:59:07 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Spec proposal to enable configuring tcp keepalive"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iceb316278069799b8c3ed1ca4c63f83fdf5b444c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAW3%2F%2FONA%3D","line":8,"in_reply_to":"AAAAW3%2F%2FT1A%3D","updated":"2014-04-15 23:59:09.000000000","message":"Done","commit_id":"c5793cd5e4af510e6c60ce4262368b7cb3689672"}],"specs/juno/configure-tcp-keepalive.rst":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"a7c4cff8145d847a4395c06fe2f6cbfe8fa5167b","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"To avoid socket leaks because of connections being left idle for any reason, "},{"line_number":21,"context_line":"the nova code has tcp keepalive automatically turned on. However, there is "},{"line_number":22,"context_line":"no way to configure keepalive parameters."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAW3%2F%2FWhM%3D","line":22,"updated":"2014-04-15 08:11:02.000000000","message":"Nova uses sockets in many different places. What particular part of Nova are you suggesting use of keepalives for.","commit_id":"c5793cd5e4af510e6c60ce4262368b7cb3689672"},{"author":{"_account_id":9608,"name":"Pranesh Pandurangan","email":"praneshpg@gmail.com","username":"pran1990"},"change_message_id":"4b59f79c0efccbee396941e61480cae8706d0b10","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"To avoid socket leaks because of connections being left idle for any reason, "},{"line_number":21,"context_line":"the nova code has tcp keepalive automatically turned on. However, there is "},{"line_number":22,"context_line":"no way to configure keepalive parameters."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAXH%2F%2F%2F90%3D","line":22,"in_reply_to":"AAAAW3%2F%2FWhM%3D","updated":"2014-04-16 00:07:20.000000000","message":"Hi Daniel, the one particular place i want this change is nova/wsgi.py, which handles things like sockets for horizon. It already has keepalive enabled, I want to be able to configure it. At my company we use values tailored to our setup. This feature should be available *anywhere* tcp keepalive is desired..","commit_id":"c5793cd5e4af510e6c60ce4262368b7cb3689672"},{"author":{"_account_id":9847,"name":"ricky.bo","email":"boh.ricky@gmail.com","username":"boh.ricky"},"change_message_id":"3b95eab2ace4317f7d03e2f718ad9e11a741f6f2","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In order to implement this I propose we specify the following configuration "},{"line_number":29,"context_line":"options:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAW3%2F%2FTww%3D","line":27,"updated":"2014-04-15 12:59:06.000000000","message":"Maybe it\u0027s better to describe the use case of setting TCP keepalive.","commit_id":"c5793cd5e4af510e6c60ce4262368b7cb3689672"},{"author":{"_account_id":9608,"name":"Pranesh Pandurangan","email":"praneshpg@gmail.com","username":"pran1990"},"change_message_id":"4b59f79c0efccbee396941e61480cae8706d0b10","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In order to implement this I propose we specify the following configuration "},{"line_number":29,"context_line":"options:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAXH%2F%2F%2F%2FE%3D","line":27,"in_reply_to":"AAAAW3%2F%2FTww%3D","updated":"2014-04-16 00:07:20.000000000","message":"Hey Ricky, can you expand a bit more? The use case is what I\u0027ve described in the problem description.","commit_id":"c5793cd5e4af510e6c60ce4262368b7cb3689672"},{"author":{"_account_id":9847,"name":"ricky.bo","email":"boh.ricky@gmail.com","username":"boh.ricky"},"change_message_id":"3b95eab2ace4317f7d03e2f718ad9e11a741f6f2","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Documentation Impact"},{"line_number":119,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"None"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAW3%2F%2FTvk%3D","line":120,"updated":"2014-04-15 12:59:06.000000000","message":"Maybe we need the document to tell people the configuration and when and why to use it.","commit_id":"c5793cd5e4af510e6c60ce4262368b7cb3689672"},{"author":{"_account_id":9608,"name":"Pranesh Pandurangan","email":"praneshpg@gmail.com","username":"pran1990"},"change_message_id":"4b59f79c0efccbee396941e61480cae8706d0b10","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Documentation Impact"},{"line_number":119,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"None"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAXH%2F%2F%2F%2B4%3D","line":120,"in_reply_to":"AAAAW3%2F%2FTvk%3D","updated":"2014-04-16 00:07:20.000000000","message":"Yes, should be done. Will update.","commit_id":"c5793cd5e4af510e6c60ce4262368b7cb3689672"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"92ee476f8db35d51074aec2cb80b85e090ec6df3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/configure-tcp-keepalive"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In this blueprint we aim to add configuration options to tune TCP keepalive."},{"line_number":14,"context_line":"These will be used to enable/disable, and tune, TCP keepalive. "},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAXH%2F%2F%2FQE%3D","line":14,"updated":"2014-04-16 02:31:44.000000000","message":"blank","commit_id":"e4c90bec2bb4619b4c408b545be156207145b929"},{"author":{"_account_id":9608,"name":"Pranesh Pandurangan","email":"praneshpg@gmail.com","username":"pran1990"},"change_message_id":"9ef8049784364ec21e5a75d4813d355dc6c3ce00","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/configure-tcp-keepalive"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In this blueprint we aim to add configuration options to tune TCP keepalive."},{"line_number":14,"context_line":"These will be used to enable/disable, and tune, TCP keepalive. "},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAXH%2F%2F%2B5s%3D","line":14,"in_reply_to":"AAAAXH%2F%2F%2FQE%3D","updated":"2014-04-16 05:11:42.000000000","message":"Done\n\nI\u0027m assuming you are talking about the red square. I thought one of the jenkins tests would take care of such things. Fixed.","commit_id":"e4c90bec2bb4619b4c408b545be156207145b929"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"92ee476f8db35d51074aec2cb80b85e090ec6df3","unresolved":false,"context_lines":[{"line_number":31,"context_line":" * tcp_keepintvl"},{"line_number":32,"context_line":" * tcp_keepcnt"},{"line_number":33,"context_line":" * tcp_keepalive_configure"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Alternatives"},{"line_number":37,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAXH%2F%2F%2FQ8%3D","line":34,"updated":"2014-04-16 02:31:44.000000000","message":"maybe a detailed description about each param will be helpful ... at least you need to add descriptions when you add param to nova","commit_id":"e4c90bec2bb4619b4c408b545be156207145b929"},{"author":{"_account_id":9608,"name":"Pranesh Pandurangan","email":"praneshpg@gmail.com","username":"pran1990"},"change_message_id":"9ef8049784364ec21e5a75d4813d355dc6c3ce00","unresolved":false,"context_lines":[{"line_number":31,"context_line":" * tcp_keepintvl"},{"line_number":32,"context_line":" * tcp_keepcnt"},{"line_number":33,"context_line":" * tcp_keepalive_configure"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Alternatives"},{"line_number":37,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAXH%2F%2F%2Bqo%3D","line":34,"in_reply_to":"AAAAXH%2F%2F%2FQ8%3D","updated":"2014-04-16 05:11:42.000000000","message":"Done\n\nAdded a small description about each param.","commit_id":"e4c90bec2bb4619b4c408b545be156207145b929"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"c320d333bc86b2e3eb622260344a35ae762f4f71","unresolved":false,"context_lines":[{"line_number":33,"context_line":"configuration options:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":" * tcp_keepintvl, which is the interval between subsequential keepalive"},{"line_number":36,"context_line":"   probes"},{"line_number":37,"context_line":" * tcp_keepcnt, which is the number of unacknowledged probes to send before the"},{"line_number":38,"context_line":"   connection is considered dead"},{"line_number":39,"context_line":" * tcp_keepalive_configure, which is the switch to turn on configuration of"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAXH%2F%2F9ro%3D","line":36,"updated":"2014-04-16 08:23:59.000000000","message":"Lets not abbreviate this -  tcp_keepalive_interval","commit_id":"fb8d8758334ae30aca9c2e5178e5bc658b13a84a"},{"author":{"_account_id":9608,"name":"Pranesh Pandurangan","email":"praneshpg@gmail.com","username":"pran1990"},"change_message_id":"8790da6ef2475a4c0ffc258aa07efb002297015c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"configuration options:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":" * tcp_keepintvl, which is the interval between subsequential keepalive"},{"line_number":36,"context_line":"   probes"},{"line_number":37,"context_line":" * tcp_keepcnt, which is the number of unacknowledged probes to send before the"},{"line_number":38,"context_line":"   connection is considered dead"},{"line_number":39,"context_line":" * tcp_keepalive_configure, which is the switch to turn on configuration of"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAXH%2F%2F9pU%3D","line":36,"in_reply_to":"AAAAXH%2F%2F9ro%3D","updated":"2014-04-16 08:29:41.000000000","message":"Done","commit_id":"fb8d8758334ae30aca9c2e5178e5bc658b13a84a"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"c320d333bc86b2e3eb622260344a35ae762f4f71","unresolved":false,"context_lines":[{"line_number":35,"context_line":" * tcp_keepintvl, which is the interval between subsequential keepalive"},{"line_number":36,"context_line":"   probes"},{"line_number":37,"context_line":" * tcp_keepcnt, which is the number of unacknowledged probes to send before the"},{"line_number":38,"context_line":"   connection is considered dead"},{"line_number":39,"context_line":" * tcp_keepalive_configure, which is the switch to turn on configuration of"},{"line_number":40,"context_line":"   tcp_keepalive. If this is False, default TCP values would be used."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAXH%2F%2F9rk%3D","line":38,"updated":"2014-04-16 08:23:59.000000000","message":"Likewise tcp_keepalive_count","commit_id":"fb8d8758334ae30aca9c2e5178e5bc658b13a84a"},{"author":{"_account_id":9608,"name":"Pranesh Pandurangan","email":"praneshpg@gmail.com","username":"pran1990"},"change_message_id":"8790da6ef2475a4c0ffc258aa07efb002297015c","unresolved":false,"context_lines":[{"line_number":35,"context_line":" * tcp_keepintvl, which is the interval between subsequential keepalive"},{"line_number":36,"context_line":"   probes"},{"line_number":37,"context_line":" * tcp_keepcnt, which is the number of unacknowledged probes to send before the"},{"line_number":38,"context_line":"   connection is considered dead"},{"line_number":39,"context_line":" * tcp_keepalive_configure, which is the switch to turn on configuration of"},{"line_number":40,"context_line":"   tcp_keepalive. If this is False, default TCP values would be used."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAXH%2F%2F9pQ%3D","line":38,"in_reply_to":"AAAAXH%2F%2F9rk%3D","updated":"2014-04-16 08:29:41.000000000","message":"Done","commit_id":"fb8d8758334ae30aca9c2e5178e5bc658b13a84a"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"c320d333bc86b2e3eb622260344a35ae762f4f71","unresolved":false,"context_lines":[{"line_number":37,"context_line":" * tcp_keepcnt, which is the number of unacknowledged probes to send before the"},{"line_number":38,"context_line":"   connection is considered dead"},{"line_number":39,"context_line":" * tcp_keepalive_configure, which is the switch to turn on configuration of"},{"line_number":40,"context_line":"   tcp_keepalive. If this is False, default TCP values would be used."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAXH%2F%2F9r0%3D","line":40,"updated":"2014-04-16 08:23:59.000000000","message":"Or just have   tcp_keepintval\u003d\u003d0 or tp_keepcnt\u003d\u003d0 mean that it is disabled.","commit_id":"fb8d8758334ae30aca9c2e5178e5bc658b13a84a"},{"author":{"_account_id":9608,"name":"Pranesh Pandurangan","email":"praneshpg@gmail.com","username":"pran1990"},"change_message_id":"8790da6ef2475a4c0ffc258aa07efb002297015c","unresolved":false,"context_lines":[{"line_number":37,"context_line":" * tcp_keepcnt, which is the number of unacknowledged probes to send before the"},{"line_number":38,"context_line":"   connection is considered dead"},{"line_number":39,"context_line":" * tcp_keepalive_configure, which is the switch to turn on configuration of"},{"line_number":40,"context_line":"   tcp_keepalive. If this is False, default TCP values would be used."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAXH%2F%2F9pY%3D","line":40,"in_reply_to":"AAAAXH%2F%2F9r0%3D","updated":"2014-04-16 08:29:41.000000000","message":"I\u0027d like to disagree with this. There is no harm in adding an extra conf setting, in my view. It\u0027s not bad to have an explicit turn off. Is there a reason you suggest this?","commit_id":"fb8d8758334ae30aca9c2e5178e5bc658b13a84a"}]}