)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"5c9d487a63763ec81c44367f173d3cfc680b2b3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"787b577f_bcd131d8","updated":"2023-03-21 15:14:25.000000000","message":"Pretty good for a first draft :) Seeinline for comments, I think Sean had some ideas on the `iothread` attribute to \u003cdriver\u003e as well, but that may be out of scope here.","commit_id":"05fcb49eab6c1e9e56dd4616d8c787581d90ec05"}],"specs/2023.2/approved/libvirt-add-support-for-virtio-scsi-multiqueue.rst":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"5c9d487a63763ec81c44367f173d3cfc680b2b3f","unresolved":true,"context_lines":[{"line_number":59,"context_line":"how many queues will be used. For such purpose, a new parameter is added to an"},{"line_number":60,"context_line":"image properties:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  hw_scsi_queues \u003d 1"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Where its value will be an integer no less than 1, defaulting to that same"},{"line_number":65,"context_line":"value."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3777fb89_34504004","line":62,"updated":"2023-03-21 15:14:25.000000000","message":"The libvirt doc says that best performance is achieved the the number of queues is set to the number of vCPU, and I think that\u0027s the behaviour we have for net multiqueue, so we should replicate this here. Instead of an integer, it should be a boolean, named something like \"hw_scsi_multiqqueue\", and them Nova itself picks a number of queues.","commit_id":"05fcb49eab6c1e9e56dd4616d8c787581d90ec05"},{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"96c0a3a52a0f3b3e04bfc9d0df698112c4c89c2c","unresolved":true,"context_lines":[{"line_number":59,"context_line":"how many queues will be used. For such purpose, a new parameter is added to an"},{"line_number":60,"context_line":"image properties:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  hw_scsi_queues \u003d 1"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Where its value will be an integer no less than 1, defaulting to that same"},{"line_number":65,"context_line":"value."}],"source_content_type":"text/x-rst","patch_set":4,"id":"472edbd7_d3eb6afe","line":62,"in_reply_to":"0a1a4f51_f7877a50","updated":"2023-03-22 09:17:52.000000000","message":"Done.","commit_id":"05fcb49eab6c1e9e56dd4616d8c787581d90ec05"},{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"8597daba8a6e0ff52ccecc2dce894c8d66831f72","unresolved":true,"context_lines":[{"line_number":59,"context_line":"how many queues will be used. For such purpose, a new parameter is added to an"},{"line_number":60,"context_line":"image properties:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  hw_scsi_queues \u003d 1"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Where its value will be an integer no less than 1, defaulting to that same"},{"line_number":65,"context_line":"value."}],"source_content_type":"text/x-rst","patch_set":4,"id":"0a1a4f51_f7877a50","line":62,"in_reply_to":"3777fb89_34504004","updated":"2023-03-21 15:34:34.000000000","message":"All right, should not be a problem changing to that approach.","commit_id":"05fcb49eab6c1e9e56dd4616d8c787581d90ec05"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"5c9d487a63763ec81c44367f173d3cfc680b2b3f","unresolved":true,"context_lines":[{"line_number":145,"context_line":"----------"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"#. Define the property under the image\u0027s configuration object."},{"line_number":148,"context_line":"#. Load the value up and store it under the libvirt driver class."},{"line_number":149,"context_line":"#. Use the stored value to generate the XML that has libvirt activate the"},{"line_number":150,"context_line":"   feature."},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"779fb015_28c47c3c","line":148,"updated":"2023-03-21 15:14:25.000000000","message":"If it\u0027s stored in the image properties I don\u0027t think we need to store it in the driver, unless I\u0027m misunderstanding you.","commit_id":"05fcb49eab6c1e9e56dd4616d8c787581d90ec05"},{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"96c0a3a52a0f3b3e04bfc9d0df698112c4c89c2c","unresolved":true,"context_lines":[{"line_number":145,"context_line":"----------"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"#. Define the property under the image\u0027s configuration object."},{"line_number":148,"context_line":"#. Load the value up and store it under the libvirt driver class."},{"line_number":149,"context_line":"#. Use the stored value to generate the XML that has libvirt activate the"},{"line_number":150,"context_line":"   feature."},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"66b8c868_1381fafe","line":148,"in_reply_to":"4bf8cd89_31faeddf","updated":"2023-03-22 09:17:52.000000000","message":"Done.","commit_id":"05fcb49eab6c1e9e56dd4616d8c787581d90ec05"},{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"8597daba8a6e0ff52ccecc2dce894c8d66831f72","unresolved":true,"context_lines":[{"line_number":145,"context_line":"----------"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"#. Define the property under the image\u0027s configuration object."},{"line_number":148,"context_line":"#. Load the value up and store it under the libvirt driver class."},{"line_number":149,"context_line":"#. Use the stored value to generate the XML that has libvirt activate the"},{"line_number":150,"context_line":"   feature."},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"4bf8cd89_31faeddf","line":148,"in_reply_to":"779fb015_28c47c3c","updated":"2023-03-21 15:34:34.000000000","message":"True, this line just refers to having the property accessible from the libvirt driver. That should be available already from the get-go, so I will remove this step to avoid confusion.","commit_id":"05fcb49eab6c1e9e56dd4616d8c787581d90ec05"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"5c9d487a63763ec81c44367f173d3cfc680b2b3f","unresolved":true,"context_lines":[{"line_number":166,"context_line":"Documentation Impact"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"The new parameter will make an appearance in both flavor extra specs and"},{"line_number":170,"context_line":"on an image parameter override. Some advise should be added recommending"},{"line_number":171,"context_line":"the value to match the number of vCPUs on the VM. A warning can be issued too"},{"line_number":172,"context_line":"saying that high values may lead to worse performance. Finally, a note should"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9c990aec_ae031761","line":169,"updated":"2023-03-21 15:14:25.000000000","message":"I don\u0027t think we need flavor extra specs here, image props will do.","commit_id":"05fcb49eab6c1e9e56dd4616d8c787581d90ec05"},{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"96c0a3a52a0f3b3e04bfc9d0df698112c4c89c2c","unresolved":true,"context_lines":[{"line_number":166,"context_line":"Documentation Impact"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"The new parameter will make an appearance in both flavor extra specs and"},{"line_number":170,"context_line":"on an image parameter override. Some advise should be added recommending"},{"line_number":171,"context_line":"the value to match the number of vCPUs on the VM. A warning can be issued too"},{"line_number":172,"context_line":"saying that high values may lead to worse performance. Finally, a note should"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ee014d7b_f3a532ad","line":169,"in_reply_to":"540e5060_4095a19f","updated":"2023-03-22 09:17:52.000000000","message":"Done.","commit_id":"05fcb49eab6c1e9e56dd4616d8c787581d90ec05"},{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"8597daba8a6e0ff52ccecc2dce894c8d66831f72","unresolved":true,"context_lines":[{"line_number":166,"context_line":"Documentation Impact"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"The new parameter will make an appearance in both flavor extra specs and"},{"line_number":170,"context_line":"on an image parameter override. Some advise should be added recommending"},{"line_number":171,"context_line":"the value to match the number of vCPUs on the VM. A warning can be issued too"},{"line_number":172,"context_line":"saying that high values may lead to worse performance. Finally, a note should"}],"source_content_type":"text/x-rst","patch_set":4,"id":"540e5060_4095a19f","line":169,"in_reply_to":"9c990aec_ae031761","updated":"2023-03-21 15:34:34.000000000","message":"In a similar spec to this one, they had to add the equivalent to: \"hw:scsi_queues\" for a flavor. Do we not want to have such thing on this case?","commit_id":"05fcb49eab6c1e9e56dd4616d8c787581d90ec05"}]}