)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1fa4bb7fb8541123e9db9c32059152eb0b8a6517","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f2b132a9_17eb2a56","updated":"2023-06-27 09:40:09.000000000","message":"lgtm, just a few comments.","commit_id":"c1b640532f5934b107654d3c8e46919a02216ea0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a9aba9ae92c30fef933f00a951124e6e52f61338","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1fc8614f_506b68c9","updated":"2023-07-05 07:33:50.000000000","message":"thanks for adding more some phrases.","commit_id":"15e09863f15271d485d05ab919f83dbfc6952db0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8c5f2abe46fb785d90d22589c2d015396cb79c12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eb6c3c2f_ebe1a6be","updated":"2023-07-06 18:26:37.000000000","message":"there are few nits but i think we can proceed with this.\n\nthose could be address in a followup if needed but i think we can defer the exact name of the command and its arguments to the implementation and documentation.","commit_id":"15e09863f15271d485d05ab919f83dbfc6952db0"}],"specs/2023.2/approved/unified-limits-nova-tool-and-docs.rst":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1fa4bb7fb8541123e9db9c32059152eb0b8a6517","unresolved":true,"context_lines":[{"line_number":18,"context_line":"in Keystone, publish official documentation in the Nova quota documentation,"},{"line_number":19,"context_line":"and removing the note on the ``[quota]driver\u003dnova.quota.UnifiedLimitsDriver``"},{"line_number":20,"context_line":"config option indicating its experimental status."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"85def940_0fa127e3","line":21,"updated":"2023-06-27 09:40:09.000000000","message":"tbc, we don\u0027t want to deprecate *yet* the legacy quota system in nova, just propose a better experience for unified limits :)","commit_id":"c1b640532f5934b107654d3c8e46919a02216ea0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f1401431bf2ca3771c5a68f40c09a3ffa1cd2da5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"in Keystone, publish official documentation in the Nova quota documentation,"},{"line_number":19,"context_line":"and removing the note on the ``[quota]driver\u003dnova.quota.UnifiedLimitsDriver``"},{"line_number":20,"context_line":"config option indicating its experimental status."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"8de3f104_783251c8","line":21,"in_reply_to":"56983d1e_807fdd73","updated":"2023-06-27 22:24:07.000000000","message":"Done","commit_id":"c1b640532f5934b107654d3c8e46919a02216ea0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2f246f019e0b462378f9b2889b39aa861c286813","unresolved":true,"context_lines":[{"line_number":18,"context_line":"in Keystone, publish official documentation in the Nova quota documentation,"},{"line_number":19,"context_line":"and removing the note on the ``[quota]driver\u003dnova.quota.UnifiedLimitsDriver``"},{"line_number":20,"context_line":"config option indicating its experimental status."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"56983d1e_807fdd73","line":21,"in_reply_to":"85def940_0fa127e3","updated":"2023-06-27 18:41:17.000000000","message":"Right. I didn\u0027t mention any deprecation of the legacy system but I can add a sentence stating that explicitly in case someone might think about it.","commit_id":"c1b640532f5934b107654d3c8e46919a02216ea0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1fa4bb7fb8541123e9db9c32059152eb0b8a6517","unresolved":true,"context_lines":[{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"We propose to create an automated tool, for example maybe"},{"line_number":42,"context_line":"``nova-manage limits migrate_to_unified_limits`` that will read existing legacy"},{"line_number":43,"context_line":"quota limits from the Nova database and config options and create equivalent"},{"line_number":44,"context_line":"unified limits for them in Keystone using the Keystone REST API. It will be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6ad1c17a_d5079625","line":41,"range":{"start_line":41,"start_character":52,"end_line":41,"end_character":57},"updated":"2023-06-27 09:40:09.000000000","message":"not sure we should bikeshed on the command name here, but IMHO you should remove the \u0027maybe\u0027.","commit_id":"c1b640532f5934b107654d3c8e46919a02216ea0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2f246f019e0b462378f9b2889b39aa861c286813","unresolved":true,"context_lines":[{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"We propose to create an automated tool, for example maybe"},{"line_number":42,"context_line":"``nova-manage limits migrate_to_unified_limits`` that will read existing legacy"},{"line_number":43,"context_line":"quota limits from the Nova database and config options and create equivalent"},{"line_number":44,"context_line":"unified limits for them in Keystone using the Keystone REST API. It will be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c86f5331_8e4edec4","line":41,"range":{"start_line":41,"start_character":52,"end_line":41,"end_character":57},"in_reply_to":"6ad1c17a_d5079625","updated":"2023-06-27 18:41:17.000000000","message":"OK, sure. It\u0027s something I expect someone will want a different name during code review but yeah, \"for example\" would be enough here to convey the same thing.","commit_id":"c1b640532f5934b107654d3c8e46919a02216ea0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f1401431bf2ca3771c5a68f40c09a3ffa1cd2da5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Proposed change"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"We propose to create an automated tool, for example maybe"},{"line_number":42,"context_line":"``nova-manage limits migrate_to_unified_limits`` that will read existing legacy"},{"line_number":43,"context_line":"quota limits from the Nova database and config options and create equivalent"},{"line_number":44,"context_line":"unified limits for them in Keystone using the Keystone REST API. It will be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"13c4372a_efabee5a","line":41,"range":{"start_line":41,"start_character":52,"end_line":41,"end_character":57},"in_reply_to":"c86f5331_8e4edec4","updated":"2023-06-27 22:24:07.000000000","message":"Done","commit_id":"c1b640532f5934b107654d3c8e46919a02216ea0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1fa4bb7fb8541123e9db9c32059152eb0b8a6517","unresolved":true,"context_lines":[{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"We propose to create an automated tool, for example maybe"},{"line_number":42,"context_line":"``nova-manage limits migrate_to_unified_limits`` that will read existing legacy"},{"line_number":43,"context_line":"quota limits from the Nova database and config options and create equivalent"},{"line_number":44,"context_line":"unified limits for them in Keystone using the Keystone REST API. It will be"},{"line_number":45,"context_line":"able to migrate both default limits and project-scoped limits. It will not"},{"line_number":46,"context_line":"migrate user-scoped limits as they are not supported by unified limits."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"14ad63f8_492e2110","line":44,"range":{"start_line":42,"start_character":0,"end_line":44,"end_character":65},"updated":"2023-06-27 09:40:09.000000000","message":"Sounds a good design (a nova-manage command can call another API, like Placement) but maybe you should explain how the command could call the Keystone API for providing the right limits for the projects and whether every project could have a specific limit for a resource class by this command (I don\u0027t think so)","commit_id":"c1b640532f5934b107654d3c8e46919a02216ea0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2f246f019e0b462378f9b2889b39aa861c286813","unresolved":true,"context_lines":[{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"We propose to create an automated tool, for example maybe"},{"line_number":42,"context_line":"``nova-manage limits migrate_to_unified_limits`` that will read existing legacy"},{"line_number":43,"context_line":"quota limits from the Nova database and config options and create equivalent"},{"line_number":44,"context_line":"unified limits for them in Keystone using the Keystone REST API. It will be"},{"line_number":45,"context_line":"able to migrate both default limits and project-scoped limits. It will not"},{"line_number":46,"context_line":"migrate user-scoped limits as they are not supported by unified limits."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"d999cc5f_a6b6ad30","line":44,"range":{"start_line":42,"start_character":0,"end_line":44,"end_character":65},"in_reply_to":"14ad63f8_492e2110","updated":"2023-06-27 18:41:17.000000000","message":"Do you mean include an example of a migration? Sure, I thought about doing but was rushing through this first draft a bit. I\u0027ll add an example.\n\nEach project can have their own limit per resource class provided they have set project-specific limits through the nova API prior. The nova-manage command will just walk through the database and create each per project limit in keystone. I\u0027ll make sure the example shows this too.","commit_id":"c1b640532f5934b107654d3c8e46919a02216ea0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f1401431bf2ca3771c5a68f40c09a3ffa1cd2da5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"We propose to create an automated tool, for example maybe"},{"line_number":42,"context_line":"``nova-manage limits migrate_to_unified_limits`` that will read existing legacy"},{"line_number":43,"context_line":"quota limits from the Nova database and config options and create equivalent"},{"line_number":44,"context_line":"unified limits for them in Keystone using the Keystone REST API. It will be"},{"line_number":45,"context_line":"able to migrate both default limits and project-scoped limits. It will not"},{"line_number":46,"context_line":"migrate user-scoped limits as they are not supported by unified limits."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"db0a05ce_522ae187","line":44,"range":{"start_line":42,"start_character":0,"end_line":44,"end_character":65},"in_reply_to":"d999cc5f_a6b6ad30","updated":"2023-06-27 22:24:07.000000000","message":"Done","commit_id":"c1b640532f5934b107654d3c8e46919a02216ea0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1fa4bb7fb8541123e9db9c32059152eb0b8a6517","unresolved":true,"context_lines":[{"line_number":101,"context_line":"Upgrade impact"},{"line_number":102,"context_line":"--------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"None"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Implementation"},{"line_number":107,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c87da1ab_5d301254","line":104,"updated":"2023-06-27 09:40:09.000000000","message":"well, that means that if you upgrade, you need to make sure that the Keystone API is running before using the manage command.","commit_id":"c1b640532f5934b107654d3c8e46919a02216ea0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2f246f019e0b462378f9b2889b39aa861c286813","unresolved":true,"context_lines":[{"line_number":101,"context_line":"Upgrade impact"},{"line_number":102,"context_line":"--------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"None"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Implementation"},{"line_number":107,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d0bdb5bf_7a232b29","line":104,"in_reply_to":"c87da1ab_5d301254","updated":"2023-06-27 18:41:17.000000000","message":"I almost wrote something here but the nova-manage tool isn\u0027t upgrade specific and can be run at any time or not at all. You can run it before or after an upgrade and you can also run it without upgrading.\n\nI guess I\u0027ll explain in this section how it\u0027s not related to an upgrade to make it extra clear.","commit_id":"c1b640532f5934b107654d3c8e46919a02216ea0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f1401431bf2ca3771c5a68f40c09a3ffa1cd2da5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"Upgrade impact"},{"line_number":102,"context_line":"--------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"None"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Implementation"},{"line_number":107,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"383ac7ec_42f07acf","line":104,"in_reply_to":"d0bdb5bf_7a232b29","updated":"2023-06-27 22:24:07.000000000","message":"Done","commit_id":"c1b640532f5934b107654d3c8e46919a02216ea0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a9aba9ae92c30fef933f00a951124e6e52f61338","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"   There are no immediate plans to deprecate legacy quota system in Nova at"},{"line_number":25,"context_line":"   this time. The objective of this work is to provide a better experience for"},{"line_number":26,"context_line":"   users who are opting in to using unified limits in Nova."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Problem description"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4747f92c_9ffe52f7","line":26,"updated":"2023-07-05 07:33:50.000000000","message":"++","commit_id":"15e09863f15271d485d05ab919f83dbfc6952db0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8c5f2abe46fb785d90d22589c2d015396cb79c12","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"   There are no immediate plans to deprecate legacy quota system in Nova at"},{"line_number":25,"context_line":"   this time. The objective of this work is to provide a better experience for"},{"line_number":26,"context_line":"   users who are opting in to using unified limits in Nova."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Problem description"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e7a11c14_1c16e5cb","line":26,"in_reply_to":"4747f92c_9ffe52f7","updated":"2023-07-06 18:26:37.000000000","message":"i would consider deprecating it in the C release and making unified limit the default in C  but i agree we are unlikely to remvoe support for the legacy driver in the near term.\n\ni think that is somethign we can decied next release.\n\ni.e. in C we can decied if we are going to change the default and deprecate it\nbut i would expect to keep the legacy driver until the E (2025.1) release.\neither removing it in E or F based on operator feedback in C/D\n\nthis does not need to be captured in the spec beyond what is already in the note.","commit_id":"15e09863f15271d485d05ab919f83dbfc6952db0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6b4421da83bff9ab628d9681775876f828a69b98","unresolved":true,"context_lines":[{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"We propose to create an automated tool, for example,"},{"line_number":48,"context_line":"``nova-manage limits migrate_to_unified_limits`` that will read existing legacy"},{"line_number":49,"context_line":"quota limits from the Nova database and config options and create equivalent"},{"line_number":50,"context_line":"unified limits for them in Keystone using the Keystone REST API. It will be"},{"line_number":51,"context_line":"able to migrate both default limits and project-scoped limits. It will not"}],"source_content_type":"text/x-rst","patch_set":2,"id":"48f5b44f_4ad8c2ff","line":48,"range":{"start_line":48,"start_character":2,"end_line":48,"end_character":47},"updated":"2023-07-06 18:30:32.000000000","message":"fyi i was thinking of something a little shorter\n`nova-manage limit migrate [project]`\nwe also might want \n\n`nova-manage limit show --defaults [project]`\n\nbut as i said in my top level comment that exact names can be deferred to the implementation review.","commit_id":"15e09863f15271d485d05ab919f83dbfc6952db0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8c5f2abe46fb785d90d22589c2d015396cb79c12","unresolved":false,"context_lines":[{"line_number":83,"context_line":"   For each config option, use its set value or default value to call the"},{"line_number":84,"context_line":"   Keystone ``POST /registered_limits`` API with the resource_name and"},{"line_number":85,"context_line":"   default_limit, if the resource_name does not already have a registered limit"},{"line_number":86,"context_line":"   in Keystone. These are default limits that apply to all projects."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"#. The ``nova_api.project_user_quotas`` database table will be ignored because"},{"line_number":89,"context_line":"   user-scoped limits are not supported by unified limits."}],"source_content_type":"text/x-rst","patch_set":2,"id":"0e02dc65_a4e9940d","line":86,"updated":"2023-07-06 18:26:37.000000000","message":"so when running this tool you will need to use the API\u0027s nova.conf to have the correct behaviour with regards to checking the [quota] section.\n\nwe should document that but i think that is implict","commit_id":"15e09863f15271d485d05ab919f83dbfc6952db0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8c5f2abe46fb785d90d22589c2d015396cb79c12","unresolved":true,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"#. The ``nova_api.project_user_quotas`` database table will be ignored because"},{"line_number":89,"context_line":"   user-scoped limits are not supported by unified limits."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":".. _checking quota: https://docs.openstack.org/nova/latest/admin/quotas.html#checking-quota"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"We will add formal docs about unified limits to the Nova docs and remove the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4affe978_6130a92e","line":90,"updated":"2023-07-06 18:26:37.000000000","message":"nit: we could add a command to purge taht table fo data but perhaps it better to just leave it there and drop the table when we remove supprot for the legacy driver in a few releases.","commit_id":"15e09863f15271d485d05ab919f83dbfc6952db0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a9aba9ae92c30fef933f00a951124e6e52f61338","unresolved":false,"context_lines":[{"line_number":88,"context_line":"#. The ``nova_api.project_user_quotas`` database table will be ignored because"},{"line_number":89,"context_line":"   user-scoped limits are not supported by unified limits."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":".. _checking quota: https://docs.openstack.org/nova/latest/admin/quotas.html#checking-quota"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"We will add formal docs about unified limits to the Nova docs and remove the"},{"line_number":94,"context_line":"note on the ``[quota]driver`` config option about the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4cd06ecd_5a6fa725","line":91,"updated":"2023-07-05 07:33:50.000000000","message":"thanks you added more explanations about what the command would do.","commit_id":"15e09863f15271d485d05ab919f83dbfc6952db0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a9aba9ae92c30fef933f00a951124e6e52f61338","unresolved":false,"context_lines":[{"line_number":151,"context_line":"into Keystone at any time, unrelated to an upgrade. The only requirements are"},{"line_number":152,"context_line":"that the Keystone API needs to be available and ``nova-manage`` must have"},{"line_number":153,"context_line":"access to a Nova config that has ``[api_database]connection`` configured so"},{"line_number":154,"context_line":"that it can access the Nova quota database tables."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Implementation"},{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"c66808ba_c1f283bc","line":154,"updated":"2023-07-05 07:33:50.000000000","message":"++","commit_id":"15e09863f15271d485d05ab919f83dbfc6952db0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8c5f2abe46fb785d90d22589c2d015396cb79c12","unresolved":false,"context_lines":[{"line_number":151,"context_line":"into Keystone at any time, unrelated to an upgrade. The only requirements are"},{"line_number":152,"context_line":"that the Keystone API needs to be available and ``nova-manage`` must have"},{"line_number":153,"context_line":"access to a Nova config that has ``[api_database]connection`` configured so"},{"line_number":154,"context_line":"that it can access the Nova quota database tables."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Implementation"},{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"836737d7_b4d56e16","line":154,"in_reply_to":"c66808ba_c1f283bc","updated":"2023-07-06 18:26:37.000000000","message":"it specificaly shoudl use the nova api config so that it can also read the [quota] section of the nova.conf.","commit_id":"15e09863f15271d485d05ab919f83dbfc6952db0"}]}