)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e09d22726a0b02393d6b417e63076ad8ff1280d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bcdcc3c7_52f9f6fb","updated":"2023-11-07 13:42:39.000000000","message":"I\u0027m unclear here about the exact gap we need to fill.","commit_id":"c31366ab3825986065f288908836d9d20758778d"}],"specs/2023.2/approved/evacuate-api-return-migration.rst":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e09d22726a0b02393d6b417e63076ad8ff1280d3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c12a4e86_17cf2400","updated":"2023-11-07 13:42:39.000000000","message":"the file itself needs to be reproposed against 2024.1 directory now that we are on the Caracal timeframe.","commit_id":"c31366ab3825986065f288908836d9d20758778d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e09d22726a0b02393d6b417e63076ad8ff1280d3","unresolved":true,"context_lines":[{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"In nova evacuate api, it creates a migration objects whose status could"},{"line_number":33,"context_line":"represent the evacuation progress."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"For example."},{"line_number":36,"context_line":"* If the migration is in `done` status, it indicates the evacuation succeeded."}],"source_content_type":"text/x-rst","patch_set":3,"id":"aa4d26d2_c66c97e5","line":33,"updated":"2023-11-07 13:42:39.000000000","message":"we already track instance actions using https://docs.openstack.org/api-ref/compute/#list-actions-for-server","commit_id":"c31366ab3825986065f288908836d9d20758778d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4befa6fc3b38fb340d25e6492fb7a1781fc31854","unresolved":true,"context_lines":[{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"In nova evacuate api, it creates a migration objects whose status could"},{"line_number":33,"context_line":"represent the evacuation progress."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"For example."},{"line_number":36,"context_line":"* If the migration is in `done` status, it indicates the evacuation succeeded."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3dd36d2a_0d74b60f","line":33,"in_reply_to":"aa4d26d2_c66c97e5","updated":"2023-12-06 11:21:11.000000000","message":"the problem is that the reponce of the evacutate does not have the migration uuid and the instnace actuion does not have that either.","commit_id":"c31366ab3825986065f288908836d9d20758778d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e1d5cd5615c8b6c1c115832adf63fa5d093aa121","unresolved":true,"context_lines":[{"line_number":40,"context_line":"in progress."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"If Nove could return the migration in the evacuate api, then it could help"},{"line_number":43,"context_line":"Masakari to refactor the evacuation confirmation code."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"},{"line_number":46,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"85d4671c_63f64560","line":43,"updated":"2023-11-07 09:20:00.000000000","message":"Both the instance action list and the migration list already returns the evacuation information. \nhttps://paste.opendev.org/show/b2Tq6TTbmXl7hkIzj6Yi/ What is missing from those APIs?","commit_id":"c31366ab3825986065f288908836d9d20758778d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4befa6fc3b38fb340d25e6492fb7a1781fc31854","unresolved":true,"context_lines":[{"line_number":40,"context_line":"in progress."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"If Nove could return the migration in the evacuate api, then it could help"},{"line_number":43,"context_line":"Masakari to refactor the evacuation confirmation code."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"},{"line_number":46,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d780c117_beecd5dc","line":43,"in_reply_to":"4fe1521f_73f532bf","updated":"2023-12-06 11:21:11.000000000","message":"this is not the first time this has come up our api is hard to use.\n\nwhat massikari need to do i take set the request id when making the evacuate calll then it can find the instance action using that same request id\n\nwhat is missing is the instance action dose not current include the migration uuid so going form step 2 to 3 can only be done by looking at the tiem and selecting the migration that is closed to the instnace action start\n\nthis is a usecase that has come up several times when we were trying to write better tempest tests in the past downstrem for our whitebox tempest plugin.\n\ni would be strongly supportive of adding the migration uuid to the instance action show reponce.","commit_id":"c31366ab3825986065f288908836d9d20758778d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e09d22726a0b02393d6b417e63076ad8ff1280d3","unresolved":true,"context_lines":[{"line_number":40,"context_line":"in progress."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"If Nove could return the migration in the evacuate api, then it could help"},{"line_number":43,"context_line":"Masakari to refactor the evacuation confirmation code."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"},{"line_number":46,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"4fe1521f_73f532bf","line":43,"in_reply_to":"7382ab7e_eba96455","updated":"2023-11-07 13:42:39.000000000","message":"Not sure I understand what you exactly need.\nStep 1 is already existing : https://docs.openstack.org/api-ref/compute/#evacuate-server-evacuate-action\nStep 2 also exists like gibi and I said : https://docs.openstack.org/api-ref/compute/#list-actions-for-server\nStep 3 can be done by getting the request-id from step 3 and then calling https://docs.openstack.org/api-ref/compute/#show-server-action-details","commit_id":"c31366ab3825986065f288908836d9d20758778d"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"8fedf88b993416a581869f3c4a7dacdaf83970e8","unresolved":true,"context_lines":[{"line_number":40,"context_line":"in progress."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"If Nove could return the migration in the evacuate api, then it could help"},{"line_number":43,"context_line":"Masakari to refactor the evacuation confirmation code."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"},{"line_number":46,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7382ab7e_eba96455","line":43,"in_reply_to":"85d4671c_63f64560","updated":"2023-11-07 11:58:12.000000000","message":"For Masakari, it would needs three steps at least,\nStep 1, evacuate the instance.\nStep 2, get the instance action list or migration list. Then it needs to distinguish which action or migration is related to the instance evacuation.  It needs some extra code or checks to ensure the relation.\nStep 3, confirm the progress of instance evacuation by the uuid of the action or migration(evacuation).\n\nThe evacuate migration is created in the nova evacuate api. If evacuate api returns the migration or migration_uuid, then it will make above mechanism in Masakari more simple and direct.","commit_id":"c31366ab3825986065f288908836d9d20758778d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e09d22726a0b02393d6b417e63076ad8ff1280d3","unresolved":true,"context_lines":[{"line_number":80,"context_line":"            \"user_id\": \"5fd9f925-0379-40db-a7f8-786a0b655b2a\","},{"line_number":81,"context_line":"            \"project_id\": \"32bc95ac-858d-460a-b562-7e365391be64\""},{"line_number":82,"context_line":"        }"},{"line_number":83,"context_line":"    }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"f51768b0_7984417e","line":83,"updated":"2023-11-07 13:42:39.000000000","message":"as gibi said, this looks very similar to https://docs.openstack.org/api-ref/compute/#list-migrations","commit_id":"c31366ab3825986065f288908836d9d20758778d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4befa6fc3b38fb340d25e6492fb7a1781fc31854","unresolved":true,"context_lines":[{"line_number":80,"context_line":"            \"user_id\": \"5fd9f925-0379-40db-a7f8-786a0b655b2a\","},{"line_number":81,"context_line":"            \"project_id\": \"32bc95ac-858d-460a-b562-7e365391be64\""},{"line_number":82,"context_line":"        }"},{"line_number":83,"context_line":"    }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9729d79b_49f0dbf5","line":83,"in_reply_to":"f51768b0_7984417e","updated":"2023-12-06 11:21:11.000000000","message":"evacutate like all instance actions is an async api even if it returns a 200.\n\nhttps://opendev.org/openstack/nova/src/branch/master/nova/conductor/rpcapi.py#L468\n\nthe migration object is not created when we retrun from the rest api i belive so i dont think we can return it form the evacuate api sicne we have not select a host yet. that is done by the conductor before it calles the compute to stat the evacuation. i think the migration object is create either by the compute or conductior after the rpc cast is done form the api.","commit_id":"c31366ab3825986065f288908836d9d20758778d"}]}