)]}'
{"specs/2024.1/approved/nova-vnc-support-for-mks.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80f7115fcd28c162056a3189b3c420adac5855e4","unresolved":true,"context_lines":[{"line_number":23,"context_line":"available or correctly configured. Also, KVM provides a better user"},{"line_number":24,"context_line":"experience as compared to serial console."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Horizon\u0027s VNC console is not working for ESXi"},{"line_number":27,"context_line":"nodes provisioned by Nova. This spec intends to extend that to"},{"line_number":28,"context_line":"graphical console via the mks proxy."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"20c9b5fb_aac4a392","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":36},"updated":"2023-07-27 13:32:15.000000000","message":"exactuly how is it broken\nthe vmware driver also has support for mks already\n\nhttps://github.com/openstack/nova/blob/e5ee5e035c0c85654a139131d51be5c4df76f400/nova/virt/vmwareapi/vmops.py#L2154\n\n\ni assume the problem here is that the function currently returns the internal_acces_path\n\nctype.ConsoleMKS(ticket.host, ticket.port, internal_access_path)\n\nand that is not accasable outside the could.\n\nwhich is why you want to add a new proxy server to allow rexporting it via a websocket instead of needign to make it publicly accable correct?","commit_id":"d67db8da0b36dc88beb4ab2f9e94db65ae90c629"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"592f924df124d810b927afa44459cf5f0207f161","unresolved":true,"context_lines":[{"line_number":30,"context_line":"Use Cases"},{"line_number":31,"context_line":"---------"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The end user will be able to get workable mks console url from ESXi"},{"line_number":34,"context_line":"server."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"nova-mksproxy should be deployed"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a0eaeab7_f64b6e87","line":33,"range":{"start_line":33,"start_character":33,"end_line":33,"end_character":45},"updated":"2023-08-18 05:36:58.000000000","message":"can you please provide some examples.\nlike \"As a user I will also be able to perform/do ..... \"","commit_id":"d67db8da0b36dc88beb4ab2f9e94db65ae90c629"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80f7115fcd28c162056a3189b3c420adac5855e4","unresolved":true,"context_lines":[{"line_number":55,"context_line":"REST API impact"},{"line_number":56,"context_line":"---------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"None"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Security impact"},{"line_number":61,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"770b3766_1711c908","line":58,"updated":"2023-07-27 13:32:15.000000000","message":"so i was going to say the protocol field in the https://docs.openstack.org/api-ref/compute/?expanded\u003d#server-consoles\napi will need to be extended to add mks\n\nbut it looks liek that was already done in teh past in microversion 2.8\n\nhttps://github.com/openstack/nova/blob/e5ee5e035c0c85654a139131d51be5c4df76f400/nova/api/openstack/compute/rest_api_version_history.rst#28\n\nthe orginal mks type was enabeld via this spec \nhttps://review.opendev.org/c/openstack/nova-specs/+/127283\nhttps://specs.openstack.org/openstack/nova-specs/specs/liberty/implemented/vmware-webmks-console.html\n\n\ni think your usecase is already coverd by that spec as the webkms type should already provdie the  same security model.","commit_id":"d67db8da0b36dc88beb4ab2f9e94db65ae90c629"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80f7115fcd28c162056a3189b3c420adac5855e4","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"We will use the same security model as for the other types of consoles"},{"line_number":64,"context_line":"which is leveraging nova-consoleauth to authorize tokens generated by"},{"line_number":65,"context_line":"the compute node."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Notifications impact"},{"line_number":68,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3c3c07be_dbf77043","line":65,"updated":"2023-07-27 13:32:15.000000000","message":"this was supposed to already be provided by  https://specs.openstack.org/openstack/nova-specs/specs/liberty/implemented/vmware-webmks-console.html#security-impact\n\nlooking at https://review.opendev.org/q/topic:bp%252Fvmware-webmks-console i dont see it can you confirm that your are propsoing implenting the part of the spec that was missing?\n\nit looks like the orginal author of the vmware supprot maintaiend an out of tree proxy implemantion \n\nhttps://opendev.org/x/nova-mksproxy\n\nis proxy functionality you are proposing adding in https://review.opendev.org/c/openstack/nova/+/863090 related to that in any way.\n\nim not really sure this is somethign that the nova core team want to maintain as we cannot test it.","commit_id":"d67db8da0b36dc88beb4ab2f9e94db65ae90c629"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c69c6458b9efefe4984a2266cdc3328f98f88f73","unresolved":true,"context_lines":[{"line_number":142,"context_line":"Testing"},{"line_number":143,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"None"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Documentation Impact"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6bbb08a1_c47f0e28","line":145,"updated":"2023-07-27 13:38:17.000000000","message":"i also wanted to note that we will need end to end integration testing if we proceed with this.\n\nthe vmware driver is marked as experimental and deprecated for posible removal in a the next release as it is unmaintained.\nhttps://github.com/openstack/nova/commit/713ef7839670bd5d73af52c211a14932adc933ba\n\nso without people siging up to maintian a third party ci indefintly for vmware driver i dont think we shoudl add more functionaltiy to it in tree.","commit_id":"d67db8da0b36dc88beb4ab2f9e94db65ae90c629"}]}