)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"04cdab2bb81f8a180d7006426daef5dad5795fb2","unresolved":true,"context_lines":[{"line_number":7,"context_line":"APIImpact"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add spec for system metadata apis"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"blueprint: system-metadata-apis"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic05f655599e6e2b65d73a3b4ce559eb20cfd1626"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"31e7c433_365f8f80","line":10,"updated":"2023-12-06 12:04:53.000000000","message":"this should be the first line not APIImpact","commit_id":"e46aa9f0a0651417ebaaf86e572feedbc496af70"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"04cdab2bb81f8a180d7006426daef5dad5795fb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e394ef1c_01764eb9","updated":"2023-12-06 12:04:53.000000000","message":"in its current form im -2 on this.\ni have provided an alrenitive approch whihc i would be happy to dicuss more.","commit_id":"e46aa9f0a0651417ebaaf86e572feedbc496af70"}],"specs/2024.1/approved/system-metadata-apis.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"04cdab2bb81f8a180d7006426daef5dad5795fb2","unresolved":true,"context_lines":[{"line_number":18,"context_line":"https://docs.openstack.org/api-ref/compute/#server-metadata-servers-metadata"},{"line_number":19,"context_line":"and only allow admin/privileged users to modify any system"},{"line_number":20,"context_line":"metadata, in order to update an instance\u0027s important properties after the"},{"line_number":21,"context_line":"fact without rebuilding it."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e5cbada5_302506bd","line":21,"updated":"2023-12-06 12:04:53.000000000","message":"the instance system metadata is intentionally an internal data store that\nwe do not allow api access too.\n\nwe use it to store cached copies of image properties to ensure that change to the image after the vm is create are not propagated to existing isntance without executing an instance action.\n\nwe also use it to store some isnternal state and in general it is nto something we would liek to expose even to admin as you can fundemental break the operation of nova by modifying the data incorrectly.","commit_id":"e46aa9f0a0651417ebaaf86e572feedbc496af70"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"04cdab2bb81f8a180d7006426daef5dad5795fb2","unresolved":true,"context_lines":[{"line_number":45,"context_line":"applying enhancements after the fact. Once a VM is created, it has to be either"},{"line_number":46,"context_line":"resized/relaunched, or hard-rebooted after its database entries are updated"},{"line_number":47,"context_line":"manually by an operator. The former is often impractical to enforce on end"},{"line_number":48,"context_line":"users, while the later is dangerous and inefficient."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"As a result, we propose a set of APIs that will grant controlled access to"},{"line_number":51,"context_line":"these database entries while maintaining the ability to live-migrate said VMs."}],"source_content_type":"text/x-rst","patch_set":1,"id":"500bc068_27bc6b64","line":48,"updated":"2023-12-06 12:04:53.000000000","message":"for what its worht we have provided a nova-manage command to do this.\nhttps://docs.openstack.org/nova/latest/cli/nova-manage.html#image-property-set","commit_id":"e46aa9f0a0651417ebaaf86e572feedbc496af70"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"04cdab2bb81f8a180d7006426daef5dad5795fb2","unresolved":true,"context_lines":[{"line_number":53,"context_line":"APIs in Nova. However, this can easily be addressed by only permitting applying"},{"line_number":54,"context_line":"the optimizations when VMs are stopped/shelved, and the applied new features"},{"line_number":55,"context_line":"will be available when the VMs are started again. This simulates a hard-reboot"},{"line_number":56,"context_line":"of VMs, which is a lot more feasible for many machine owners."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Moreover, other public clouds provide similar features for updates to be made"},{"line_number":59,"context_line":"to existing VMs:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"321166b5_c95dc336","line":56,"updated":"2023-12-06 12:04:53.000000000","message":"i dont think this is the correct approch.\nwe could provide a new instance action simialr to rebuild or resize that would update the image properties.\n\nwe have discuss this in the past and said we could extend the resize api to support\nresizeing to the same flavor and optionall having an update-image-meta option\n\nthat would allow you to use resize to adress this use case.\n\ni think that is a much more supprotable option.\n\nthe workflow would be update the glance image metadata\nthen resize the relevnet vms to the same flavor with the ——update-image-metadatta option\n\nthis has the advantage of also allowing you to update the flavor extra spec and using the same procuere to make that take effect.","commit_id":"e46aa9f0a0651417ebaaf86e572feedbc496af70"}]}