)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"06d13ed0c8242048f490ea7e1f8ab02724e3a51c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6924f563_c70b5057","updated":"2023-12-28 16:36:16.000000000","message":"Missing the API and doc impacts (see inline), but otherwise a pretty simple and sensible spec.","commit_id":"114e15854b6eaf0d167d26ca1491ed60cae42c06"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ace99e3958e5b9cced4ed3819b2ec1686b5b915b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"68bbc578_790f210d","updated":"2024-01-09 13:46:19.000000000","message":"I have updated the spec as per your suggestions.\n\nThanks!","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"69776e79cd2ccb118b1eca1082429f2dc235f6f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4ad8362b_931abd90","updated":"2024-01-10 13:52:55.000000000","message":"Reviewed that spec and it sounds pretty clear to me.\nAnd I think that it is really useful for users.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"690d3405e8b8b652eeb8df2b3ce594afd92ff688","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"411041a4_5c4f8585","updated":"2024-01-10 14:03:47.000000000","message":"While I\u0027m quite OK with what the usecase, I still have some concerns by this spec, so please modify this shortly so I can review it again.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"947a983d2686da2b7fccbc3e71a2573f89822522","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e99bc259_25a7dc7e","updated":"2024-01-09 19:03:34.000000000","message":"i think this is fine.\nthe sepc is needed as this is an api change but i dont see anything controversial here.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ed34d88a669b0c4eb9434bd28cae3e4ef1eb6fa3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5b21521b_93d63fbb","updated":"2024-01-11 10:16:04.000000000","message":"Thanks Sylvain, Sean, Dmitriy for your suggestions.\n\nI have updated the spec as mentioned by you guys.","commit_id":"62df72eacecaaadcd3a3d1c4c0dbc6e8eec4b488"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"916d8e0f9ad55b15aac0b1e12aad3c395a9d4102","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6ff54606_cf8bf0b2","updated":"2024-01-11 13:52:09.000000000","message":"i think this proposal is workable in its current form but im not oppsed to addding a policy to contol if this filed is expose as long as its aviabel to the project reader persona by defaul.","commit_id":"62df72eacecaaadcd3a3d1c4c0dbc6e8eec4b488"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f7d3b35127632712592ede54a33e51db1de3d650","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"310688a7_46def797","updated":"2024-01-11 13:47:38.000000000","message":"thanks, lgtm.","commit_id":"62df72eacecaaadcd3a3d1c4c0dbc6e8eec4b488"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"f72029eb7ccca38a281ae7b7518b7b4340837b6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"84aa829b_406df56a","updated":"2024-01-11 14:25:03.000000000","message":"w.r.t to problem description \"There is no way to tell from this information\nthat whether the instance created request included an AZ or not.\" \n\nI think its best to update existing availability_zone with 2 keys from server show presepective - \"requested AZ\" and \"assigned AZ\"\n\nso we can see below on server show\nOS-EXT-AZ:availability_zone         | {\"requested AZ\": nova1,  \"assigned AZ\": \"nova2\"]","commit_id":"62df72eacecaaadcd3a3d1c4c0dbc6e8eec4b488"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b036784721cf23ecb35c5d2ed0f1d504ab9ff598","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"929318d0_581eaca0","in_reply_to":"84aa829b_406df56a","updated":"2024-01-11 19:36:37.000000000","message":"no that would be a breadking api change for no real benifity\nwe will need 2o have 2 seperate keys but not transform the current result into a dict","commit_id":"62df72eacecaaadcd3a3d1c4c0dbc6e8eec4b488"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1f60d98e4784d5ba75b7d86dad22177cea9efd07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4d4380bb_ad9959ed","in_reply_to":"929318d0_581eaca0","updated":"2024-01-12 04:38:10.000000000","message":"ack","commit_id":"62df72eacecaaadcd3a3d1c4c0dbc6e8eec4b488"}],"specs/2024.1/approved/list-requested-az.rst":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"06d13ed0c8242048f490ea7e1f8ab02724e3a51c","unresolved":true,"context_lines":[{"line_number":36,"context_line":"For server show output, use the existing get_by_instance_uuid method from"},{"line_number":37,"context_line":"RequestSpec object and display it in the output."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"For server list --long output, implement a method get_by_instance_uuids for"},{"line_number":40,"context_line":"RequestSpec object, which takes list of instance uuids of instances which"},{"line_number":41,"context_line":"will be shown in the listed output and return a list of RequestSpec objects"},{"line_number":42,"context_line":"of those instances."}],"source_content_type":"text/x-rst","patch_set":2,"id":"cacedfb9_2a6e6e1d","line":39,"updated":"2023-12-28 16:36:16.000000000","message":"I talked about this with Rajesh, and we weren\u0027t able to come up with anything less bad, performance-wise. Open to suggestions :)","commit_id":"114e15854b6eaf0d167d26ca1491ed60cae42c06"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ace99e3958e5b9cced4ed3819b2ec1686b5b915b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"For server show output, use the existing get_by_instance_uuid method from"},{"line_number":37,"context_line":"RequestSpec object and display it in the output."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"For server list --long output, implement a method get_by_instance_uuids for"},{"line_number":40,"context_line":"RequestSpec object, which takes list of instance uuids of instances which"},{"line_number":41,"context_line":"will be shown in the listed output and return a list of RequestSpec objects"},{"line_number":42,"context_line":"of those instances."}],"source_content_type":"text/x-rst","patch_set":2,"id":"0b6819d5_b32b115d","line":39,"in_reply_to":"cacedfb9_2a6e6e1d","updated":"2024-01-09 13:46:19.000000000","message":"Acknowledged","commit_id":"114e15854b6eaf0d167d26ca1491ed60cae42c06"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"06d13ed0c8242048f490ea7e1f8ab02724e3a51c","unresolved":true,"context_lines":[{"line_number":58,"context_line":"REST API impact"},{"line_number":59,"context_line":"---------------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"None"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Security impact"},{"line_number":64,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4813d53f_e48cfade","line":61,"updated":"2023-12-28 16:36:16.000000000","message":"This is adding a field to the server show details and server list responses, which means a new API microversion. Please mention this new microversion here, and ideally includes examples of both responses. Since \u0027None\u0027 is a possibility for the new requested_az field, it needs to be mentioned here.","commit_id":"114e15854b6eaf0d167d26ca1491ed60cae42c06"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ace99e3958e5b9cced4ed3819b2ec1686b5b915b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"REST API impact"},{"line_number":59,"context_line":"---------------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"None"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Security impact"},{"line_number":64,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"f7151c38_c2dcef80","line":61,"in_reply_to":"4813d53f_e48cfade","updated":"2024-01-09 13:46:19.000000000","message":"Done","commit_id":"114e15854b6eaf0d167d26ca1491ed60cae42c06"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"06d13ed0c8242048f490ea7e1f8ab02724e3a51c","unresolved":true,"context_lines":[{"line_number":127,"context_line":"Testing"},{"line_number":128,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"functional"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Documentation Impact"},{"line_number":133,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e1225375_5747fab7","line":130,"updated":"2023-12-28 16:36:16.000000000","message":"Ack, api-samples testing should be enough here.","commit_id":"114e15854b6eaf0d167d26ca1491ed60cae42c06"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ace99e3958e5b9cced4ed3819b2ec1686b5b915b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"Testing"},{"line_number":128,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"functional"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Documentation Impact"},{"line_number":133,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e7db2cf0_e65f2d24","line":130,"in_reply_to":"e1225375_5747fab7","updated":"2024-01-09 13:46:19.000000000","message":"Done","commit_id":"114e15854b6eaf0d167d26ca1491ed60cae42c06"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"06d13ed0c8242048f490ea7e1f8ab02724e3a51c","unresolved":true,"context_lines":[{"line_number":132,"context_line":"Documentation Impact"},{"line_number":133,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"release notes"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"References"},{"line_number":138,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"8a278414_3f8645b9","line":135,"updated":"2023-12-28 16:36:16.000000000","message":"We\u0027ll need to update our api-ref with descriptions of the new field.","commit_id":"114e15854b6eaf0d167d26ca1491ed60cae42c06"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ace99e3958e5b9cced4ed3819b2ec1686b5b915b","unresolved":false,"context_lines":[{"line_number":132,"context_line":"Documentation Impact"},{"line_number":133,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"release notes"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"References"},{"line_number":138,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"65e33ee7_96aab0f4","line":135,"in_reply_to":"8a278414_3f8645b9","updated":"2024-01-09 13:46:19.000000000","message":"Done","commit_id":"114e15854b6eaf0d167d26ca1491ed60cae42c06"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2b5c1ae55692a37f017349d99a7d63e8e81f0c00","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":"As of today, the server show and server list --long output, displays"},{"line_number":19,"context_line":"the current AZ of the instance. That is, the AZ to which the host"},{"line_number":20,"context_line":"of the instance belongs. There is no way to tell from this information"},{"line_number":21,"context_line":"that whether the instance created request included an AZ or not."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1cc66963_4872a2f2","line":21,"range":{"start_line":18,"start_character":0,"end_line":21,"end_character":64},"updated":"2024-01-10 14:59:02.000000000","message":"This is actually a copy/paste of spec header. Can you kindly somehow rephrase bp goal and/or issue description to state more obviously what is the end goal and what is the problem we\u0027re trying to solve, as these 2 are usually different thing. For example:\n\nGoal: \nEnable users to validate that their request for AZ was correctly processed and satisfied, by returning back information not only about current placement of the VM, but also original request\n\nProblem:\n(actually what you have in problem)","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"690d3405e8b8b652eeb8df2b3ce594afd92ff688","unresolved":true,"context_lines":[{"line_number":18,"context_line":"As of today, the server show and server list --long output, displays"},{"line_number":19,"context_line":"the current AZ of the instance. That is, the AZ to which the host"},{"line_number":20,"context_line":"of the instance belongs. There is no way to tell from this information"},{"line_number":21,"context_line":"that whether the instance created request included an AZ or not."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bfcbf580_a997a3a6","line":21,"updated":"2024-01-10 14:03:47.000000000","message":"fwiw, an instance can be pinned to a specific AZ if it\u0027s using a volume and cross_az_attach option is False, even if the user hasn\u0027t asked to a specific AZ.\nAlso, an operator can make sure that by default all instances are pinned to a specific AZ is they modify default_schedule_zone option value.\n\nSo,see my comments below.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ed34d88a669b0c4eb9434bd28cae3e4ef1eb6fa3","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":"As of today, the server show and server list --long output, displays"},{"line_number":19,"context_line":"the current AZ of the instance. That is, the AZ to which the host"},{"line_number":20,"context_line":"of the instance belongs. There is no way to tell from this information"},{"line_number":21,"context_line":"that whether the instance created request included an AZ or not."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"36602a40_1b0301dd","line":21,"range":{"start_line":18,"start_character":0,"end_line":21,"end_character":64},"in_reply_to":"1cc66963_4872a2f2","updated":"2024-01-11 10:16:04.000000000","message":"Done","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ed34d88a669b0c4eb9434bd28cae3e4ef1eb6fa3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"As of today, the server show and server list --long output, displays"},{"line_number":19,"context_line":"the current AZ of the instance. That is, the AZ to which the host"},{"line_number":20,"context_line":"of the instance belongs. There is no way to tell from this information"},{"line_number":21,"context_line":"that whether the instance created request included an AZ or not."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9db954f6_e76ea0c7","line":21,"in_reply_to":"aab7afb8_71006b2a","updated":"2024-01-11 10:16:04.000000000","message":"Done","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"929675dc9a847f123efcd8b5e9f5413233720ea6","unresolved":true,"context_lines":[{"line_number":18,"context_line":"As of today, the server show and server list --long output, displays"},{"line_number":19,"context_line":"the current AZ of the instance. That is, the AZ to which the host"},{"line_number":20,"context_line":"of the instance belongs. There is no way to tell from this information"},{"line_number":21,"context_line":"that whether the instance created request included an AZ or not."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"aab7afb8_71006b2a","line":21,"in_reply_to":"bfcbf580_a997a3a6","updated":"2024-01-10 14:25:32.000000000","message":"technilaly true\n\nfrom my perspective the az is pinned if its in the final request spec\n\nwhere the requested az comes form (user request or injected via the cross_az_feature or configured by the admin as a default) is less imporant\n\nbut your right there are technialy multiple ways for it to be pinned to an az","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"690d3405e8b8b652eeb8df2b3ce594afd92ff688","unresolved":true,"context_lines":[{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"---------"},{"line_number":25,"context_line":"- As an operator, I want to know if the instance create request"},{"line_number":26,"context_line":"  asked for an AZ expliclity or not. And whether the requested AZ and"},{"line_number":27,"context_line":"  current AZ are both same or different."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"f9d3d1ad_f42e930a","line":26,"range":{"start_line":26,"start_character":18,"end_line":26,"end_character":28},"updated":"2024-01-10 14:03:47.000000000","message":"well, as I said in L21, an instance create request could be pinned to an AZ even if it wasn\u0027t explicitly asked by the user.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ed34d88a669b0c4eb9434bd28cae3e4ef1eb6fa3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"---------"},{"line_number":25,"context_line":"- As an operator, I want to know if the instance create request"},{"line_number":26,"context_line":"  asked for an AZ expliclity or not. And whether the requested AZ and"},{"line_number":27,"context_line":"  current AZ are both same or different."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"27f428c5_9373a8ed","line":26,"range":{"start_line":26,"start_character":18,"end_line":26,"end_character":28},"in_reply_to":"e526819c_283216f1","updated":"2024-01-11 10:16:04.000000000","message":"Done","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"929675dc9a847f123efcd8b5e9f5413233720ea6","unresolved":true,"context_lines":[{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"---------"},{"line_number":25,"context_line":"- As an operator, I want to know if the instance create request"},{"line_number":26,"context_line":"  asked for an AZ expliclity or not. And whether the requested AZ and"},{"line_number":27,"context_line":"  current AZ are both same or different."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"e526819c_283216f1","line":26,"range":{"start_line":26,"start_character":18,"end_line":26,"end_character":28},"in_reply_to":"f9d3d1ad_f42e930a","updated":"2024-01-10 14:25:32.000000000","message":"honestly i woudl consider the cross_az_attach and to a lesser degree the config option to also be part of the request but i see you are litraly tinking of just the http post body.\n\nim fine with rewording or perhaps just adding a second and third use case for the cross_az_attach feature and https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.default_schedule_zone would be cleaner.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2010b0c146fbbb2bc6c3758b87b9443481e20b48","unresolved":true,"context_lines":[{"line_number":24,"context_line":"---------"},{"line_number":25,"context_line":"- As an operator, I want to know if the instance create request"},{"line_number":26,"context_line":"  asked for an AZ expliclity or not. And whether the requested AZ and"},{"line_number":27,"context_line":"  current AZ are both same or different."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"a805970a_f5805a10","line":27,"updated":"2024-01-10 12:31:44.000000000","message":"this is especially important to know when the instance resides in the default nova AZ but not because that AZ was requested.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ed34d88a669b0c4eb9434bd28cae3e4ef1eb6fa3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"---------"},{"line_number":25,"context_line":"- As an operator, I want to know if the instance create request"},{"line_number":26,"context_line":"  asked for an AZ expliclity or not. And whether the requested AZ and"},{"line_number":27,"context_line":"  current AZ are both same or different."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"34f44bb6_9c87911f","line":27,"in_reply_to":"a805970a_f5805a10","updated":"2024-01-11 10:16:04.000000000","message":"Acknowledged","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"690d3405e8b8b652eeb8df2b3ce594afd92ff688","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The instances table from nova cell database does not have requested"},{"line_number":33,"context_line":"availability zone information. The same can be get from request_specs"},{"line_number":34,"context_line":"table in nova_api database."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"For server show output, use the existing get_by_instance_uuid method from"}],"source_content_type":"text/x-rst","patch_set":3,"id":"4308383d_ec02d5b2","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":29},"updated":"2024-01-10 14:03:47.000000000","message":"for a design reason :-)","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"690d3405e8b8b652eeb8df2b3ce594afd92ff688","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"},{"line_number":45,"context_line":"------------"},{"line_number":46,"context_line":"As an alternative, we could add the requested availability zone information in"},{"line_number":47,"context_line":"instances table and when doing server list --long or server show use the data"},{"line_number":48,"context_line":"from instances table only and display to users, but it would duplicate the"},{"line_number":49,"context_line":"data in request_specs table as well as in instances table."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c45199f8_f1ba2c73","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":25},"updated":"2024-01-10 14:03:47.000000000","message":"no, we couldn\u0027t : instance.az is just the value of the host AZ that the instance is there, that doesn\u0027t say whether the instance is pinned or not.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ed34d88a669b0c4eb9434bd28cae3e4ef1eb6fa3","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"},{"line_number":45,"context_line":"------------"},{"line_number":46,"context_line":"As an alternative, we could add the requested availability zone information in"},{"line_number":47,"context_line":"instances table and when doing server list --long or server show use the data"},{"line_number":48,"context_line":"from instances table only and display to users, but it would duplicate the"},{"line_number":49,"context_line":"data in request_specs table as well as in instances table."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba0df136_3853b756","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":25},"in_reply_to":"50ee8214_77bd5663","updated":"2024-01-11 10:16:04.000000000","message":"Acknowledged","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"929675dc9a847f123efcd8b5e9f5413233720ea6","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"},{"line_number":45,"context_line":"------------"},{"line_number":46,"context_line":"As an alternative, we could add the requested availability zone information in"},{"line_number":47,"context_line":"instances table and when doing server list --long or server show use the data"},{"line_number":48,"context_line":"from instances table only and display to users, but it would duplicate the"},{"line_number":49,"context_line":"data in request_specs table as well as in instances table."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"50ee8214_77bd5663","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":25},"in_reply_to":"c45199f8_f1ba2c73","updated":"2024-01-10 14:25:32.000000000","message":"i think they were intending to extend the instnace table with a new column hence my commend below. that why they said they woudl need to duplicate data","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"947a983d2686da2b7fccbc3e71a2573f89822522","unresolved":true,"context_lines":[{"line_number":46,"context_line":"As an alternative, we could add the requested availability zone information in"},{"line_number":47,"context_line":"instances table and when doing server list --long or server show use the data"},{"line_number":48,"context_line":"from instances table only and display to users, but it would duplicate the"},{"line_number":49,"context_line":"data in request_specs table as well as in instances table."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Data model impact"},{"line_number":52,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"0e6d1045_fb9a5ef6","line":49,"updated":"2024-01-09 19:03:34.000000000","message":"ya that would require a db migration and i dont think that is really worth it.\n\na better alternative would be to stash the requested AZ in the instance_system_metadata which woudl avoid the db migration.\n\nit would still be duplicated.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ed34d88a669b0c4eb9434bd28cae3e4ef1eb6fa3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"As an alternative, we could add the requested availability zone information in"},{"line_number":47,"context_line":"instances table and when doing server list --long or server show use the data"},{"line_number":48,"context_line":"from instances table only and display to users, but it would duplicate the"},{"line_number":49,"context_line":"data in request_specs table as well as in instances table."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Data model impact"},{"line_number":52,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9daff70d_767daad1","line":49,"in_reply_to":"0e6d1045_fb9a5ef6","updated":"2024-01-11 10:16:04.000000000","message":"Acknowledged","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"690d3405e8b8b652eeb8df2b3ce594afd92ff688","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"For implementation, we need to add a method get_by_instance_uuids to"},{"line_number":55,"context_line":"the RequestSpec object, which takes list of instance uuids as input and"},{"line_number":56,"context_line":"returns list of RequestSpec objects of those instances."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"REST API impact"},{"line_number":59,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d46cdf4c_43e48ac5","line":56,"updated":"2024-01-10 14:03:47.000000000","message":"Just say \"None\".","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ed34d88a669b0c4eb9434bd28cae3e4ef1eb6fa3","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"For implementation, we need to add a method get_by_instance_uuids to"},{"line_number":55,"context_line":"the RequestSpec object, which takes list of instance uuids as input and"},{"line_number":56,"context_line":"returns list of RequestSpec objects of those instances."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"REST API impact"},{"line_number":59,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dbe514ba_73258269","line":56,"in_reply_to":"d46cdf4c_43e48ac5","updated":"2024-01-11 10:16:04.000000000","message":"Done","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"690d3405e8b8b652eeb8df2b3ce594afd92ff688","unresolved":true,"context_lines":[{"line_number":72,"context_line":"     {"},{"line_number":73,"context_line":"       \"server\":"},{"line_number":74,"context_line":"           {"},{"line_number":75,"context_line":"               \"requested_availability_zone\": None"},{"line_number":76,"context_line":"           }"},{"line_number":77,"context_line":"     }"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"6367bcaf_bbd99d46","line":75,"range":{"start_line":75,"start_character":16,"end_line":75,"end_character":43},"updated":"2024-01-10 14:03:47.000000000","message":"I don\u0027t want to nitpick a name here, but as I explained in L21, the RequestSpec value of availability_zone field is not exactly the user \"requested\" value, rather the fact that the instance is either \"pinned\" to an AZ or not.\n\nFor that reason, please change this to \"pinned_availability_zone\" or something else explaining that the instance can\u0027t move off this AZ value.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"79e182bf1cc8dfe0694c088d0b6f6d301100150d","unresolved":true,"context_lines":[{"line_number":72,"context_line":"     {"},{"line_number":73,"context_line":"       \"server\":"},{"line_number":74,"context_line":"           {"},{"line_number":75,"context_line":"               \"requested_availability_zone\": None"},{"line_number":76,"context_line":"           }"},{"line_number":77,"context_line":"     }"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"f9c8567a_af5f3a90","line":75,"range":{"start_line":75,"start_character":16,"end_line":75,"end_character":43},"in_reply_to":"3e1c88f5_30265ac4","updated":"2024-01-10 15:10:16.000000000","message":"+1, `pinned_availability_zone` makes more sense to me as well, since return will not always represent user `request` as Sylvain mentioned.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"929675dc9a847f123efcd8b5e9f5413233720ea6","unresolved":true,"context_lines":[{"line_number":72,"context_line":"     {"},{"line_number":73,"context_line":"       \"server\":"},{"line_number":74,"context_line":"           {"},{"line_number":75,"context_line":"               \"requested_availability_zone\": None"},{"line_number":76,"context_line":"           }"},{"line_number":77,"context_line":"     }"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"6ab05bb6_9c7a6941","line":75,"range":{"start_line":75,"start_character":16,"end_line":75,"end_character":43},"in_reply_to":"6367bcaf_bbd99d46","updated":"2024-01-10 14:25:32.000000000","message":"pinned_availability_zone is fine or requied_availability_zone\n\ni didnt read requested_availability_zone as requested by the user but rather\nas requested by the request spec.\n\ni like the corralation between the api filed name and teh request spec as to me it makes it clear this az is coming form the request spec not the instance table.\n\nif we want to use a diffent name that is oke but i dont nessiarly think a diffent name impovies the clarity here.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1089a4c4e08507083747be005a128b06b9163f45","unresolved":true,"context_lines":[{"line_number":72,"context_line":"     {"},{"line_number":73,"context_line":"       \"server\":"},{"line_number":74,"context_line":"           {"},{"line_number":75,"context_line":"               \"requested_availability_zone\": None"},{"line_number":76,"context_line":"           }"},{"line_number":77,"context_line":"     }"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fe2280a9_57595354","line":75,"range":{"start_line":75,"start_character":16,"end_line":75,"end_character":43},"in_reply_to":"6ab05bb6_9c7a6941","updated":"2024-01-10 14:28:30.000000000","message":"I just want to make sur we explain it correctly.\nFrom an API document point of view, it looks to me that \u0027requested\u0027 means something like \u0027we asked for\u0027.\n\ngiven the name of the config option \u0027cross_az_attach\u0027, I\u0027d also be ok with \u0027attached_availability_zone\u0027 FWIW.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ed34d88a669b0c4eb9434bd28cae3e4ef1eb6fa3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"     {"},{"line_number":73,"context_line":"       \"server\":"},{"line_number":74,"context_line":"           {"},{"line_number":75,"context_line":"               \"requested_availability_zone\": None"},{"line_number":76,"context_line":"           }"},{"line_number":77,"context_line":"     }"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"c5564585_70f2a464","line":75,"range":{"start_line":75,"start_character":16,"end_line":75,"end_character":43},"in_reply_to":"f9c8567a_af5f3a90","updated":"2024-01-11 10:16:04.000000000","message":"Done","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"9ded4332b662700b3f087bb224bf72e1e351f30e","unresolved":true,"context_lines":[{"line_number":72,"context_line":"     {"},{"line_number":73,"context_line":"       \"server\":"},{"line_number":74,"context_line":"           {"},{"line_number":75,"context_line":"               \"requested_availability_zone\": None"},{"line_number":76,"context_line":"           }"},{"line_number":77,"context_line":"     }"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3e1c88f5_30265ac4","line":75,"range":{"start_line":75,"start_character":16,"end_line":75,"end_character":43},"in_reply_to":"fe2280a9_57595354","updated":"2024-01-10 14:36:43.000000000","message":"pinned_availability_zone sounds more in line with the wording in the unshelve api doc (unshelve to host or az). So I would be more in favor of that one.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"690d3405e8b8b652eeb8df2b3ce594afd92ff688","unresolved":true,"context_lines":[{"line_number":86,"context_line":"     {"},{"line_number":87,"context_line":"       \"servers\": ["},{"line_number":88,"context_line":"           {"},{"line_number":89,"context_line":"               \"requested_availability_zone\": None"},{"line_number":90,"context_line":"           }"},{"line_number":91,"context_line":"           {"},{"line_number":92,"context_line":"               \"requested_availability_zone\": None"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ac73e5b_0b3be8e1","line":89,"range":{"start_line":89,"start_character":16,"end_line":89,"end_character":43},"updated":"2024-01-10 14:03:47.000000000","message":"ditto","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ed34d88a669b0c4eb9434bd28cae3e4ef1eb6fa3","unresolved":false,"context_lines":[{"line_number":86,"context_line":"     {"},{"line_number":87,"context_line":"       \"servers\": ["},{"line_number":88,"context_line":"           {"},{"line_number":89,"context_line":"               \"requested_availability_zone\": None"},{"line_number":90,"context_line":"           }"},{"line_number":91,"context_line":"           {"},{"line_number":92,"context_line":"               \"requested_availability_zone\": None"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d4ffccc0_092b545c","line":89,"range":{"start_line":89,"start_character":16,"end_line":89,"end_character":43},"in_reply_to":"9ac73e5b_0b3be8e1","updated":"2024-01-11 10:16:04.000000000","message":"Done","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"947a983d2686da2b7fccbc3e71a2573f89822522","unresolved":true,"context_lines":[{"line_number":93,"context_line":"           }"},{"line_number":94,"context_line":"       ]"},{"line_number":95,"context_line":"     }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"cc8e836d_e3cb7fc5","line":96,"updated":"2024-01-09 19:03:34.000000000","message":"there will obviously be othere feiled in the respocne but this is fine a guess\nif you respine can you add somethign to indicate that like\n\n\"...\"","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ed34d88a669b0c4eb9434bd28cae3e4ef1eb6fa3","unresolved":false,"context_lines":[{"line_number":93,"context_line":"           }"},{"line_number":94,"context_line":"       ]"},{"line_number":95,"context_line":"     }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"34ee19a5_5ba5960e","line":96,"in_reply_to":"cc8e836d_e3cb7fc5","updated":"2024-01-11 10:16:04.000000000","message":"Done","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"2b5c1ae55692a37f017349d99a7d63e8e81f0c00","unresolved":true,"context_lines":[{"line_number":99,"context_line":"Security impact"},{"line_number":100,"context_line":"---------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"None"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Notifications impact"},{"line_number":105,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c127e827_4c57696d","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":4},"updated":"2024-01-10 14:59:02.000000000","message":"I wonder if that should be covered with a policy and be returned only to admin or so.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"916d8e0f9ad55b15aac0b1e12aad3c395a9d4102","unresolved":true,"context_lines":[{"line_number":99,"context_line":"Security impact"},{"line_number":100,"context_line":"---------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"None"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Notifications impact"},{"line_number":105,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8eab063e_666a6515","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":4},"in_reply_to":"046b151c_d96e2ea0","updated":"2024-01-11 13:52:09.000000000","message":"the AZ is a user setable field so it shoudl be presented to a user by default\n\nbut we can add a ploicy to allow you to change that.\n\nif you do not expose az in your cloud in general i cna see not wanting to expose this but this should be aviable to the project_reader role and above.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4c8c6989876401419be4d67d86f15f0a740f4f65","unresolved":true,"context_lines":[{"line_number":99,"context_line":"Security impact"},{"line_number":100,"context_line":"---------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"None"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Notifications impact"},{"line_number":105,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"046b151c_d96e2ea0","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":4},"in_reply_to":"4e735166_a90d1cfc","updated":"2024-01-11 12:40:45.000000000","message":"An admin may not always want to present this information to the user - that what I meant 😊\n\nFor example,\n\nAs Admin I might want to conveniently monitor if all instances are currently running on AZs where they are running\n\nIf something is going off and instance somehow is running not where it is pinned, I might want to not present this information to end user.\n\nBut dunno, maybe this is not valid usecase","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ed34d88a669b0c4eb9434bd28cae3e4ef1eb6fa3","unresolved":true,"context_lines":[{"line_number":99,"context_line":"Security impact"},{"line_number":100,"context_line":"---------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"None"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Notifications impact"},{"line_number":105,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"4e735166_a90d1cfc","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":4},"in_reply_to":"c127e827_4c57696d","updated":"2024-01-11 10:16:04.000000000","message":"IMO an end user wants to know, whether his/her instance is scheduled on requested AZ or not.\n\nAn admin can always check that through other means, like directly accessing db.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"690d3405e8b8b652eeb8df2b3ce594afd92ff688","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"There will be some performance impact when user calls server list --long"},{"line_number":117,"context_line":"because we will be adding another database call to get list of request_specs"},{"line_number":118,"context_line":"of instances."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Other deployer impact"},{"line_number":121,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"b8789fbe_fc21778c","line":118,"updated":"2024-01-10 14:03:47.000000000","message":"meh honestly.","commit_id":"ba74492546ee720811ddbe2bce9acee5ac7b6c11"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3548340ef816dd2febe71ff02595d578b46cff55","unresolved":true,"context_lines":[{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"List requested Availability Zones"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Currently server show and server list --long output, displays the"},{"line_number":12,"context_line":"current AZ of the instance. That is, the AZ to which the host of"},{"line_number":13,"context_line":"the instance belongs. There is no way to tell from this information"}],"source_content_type":"text/x-rst","patch_set":4,"id":"b475b249_23c6197a","line":10,"updated":"2024-01-12 10:41:13.000000000","message":"doh I forgot to request for a blueprint link here.","commit_id":"62df72eacecaaadcd3a3d1c4c0dbc6e8eec4b488"}]}