)]}'
{"specs/juno/tag-instances.rst":[{"author":{"_account_id":4912,"name":"Michael H Wilson","email":"geekinutah@gmail.com","username":"geekinutah"},"change_message_id":"428996a1bd9c494c548b7215cf3b379b4499eb9c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"for an instance."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Add a v2[.1] API extension to allow searching for instances based on one"},{"line_number":41,"context_line":"or more string tags."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad9bd40_24ff2136","line":41,"updated":"2014-04-30 20:21:34.000000000","message":"I like the v2 extension since it snaps right in, should probably look at v3 support for this also.","commit_id":"2320c678f882632bdb31404282c25e3cf0fb9d66"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"d6e79dfcb1f9844d78defe08c5f8177e804ee430","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    CREATE TABLE tags ("},{"line_number":156,"context_line":"        resource_id CHAR(32) NOT NULL PRIMARY KEY,"},{"line_number":157,"context_line":"        tag VARCHAR(80) NOT NULL CHARACTER SET utf8 COLLATION utf8_ci PRIMARY KEY"},{"line_number":158,"context_line":"    );"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Also see `Work Items`_ section below."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad9bd40_13609331","line":157,"updated":"2014-05-01 13:14:10.000000000","message":"jay, this line is failing due \u003e 79 chars","commit_id":"2320c678f882632bdb31404282c25e3cf0fb9d66"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"ce619f7ac058ab17a4e6b1c0041fa73bd962f5e3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"In most popular REST API interfaces, objects in the domain model can be"},{"line_number":20,"context_line":"\"tagged\" with zero or more simple strings. These strings may then be used"},{"line_number":21,"context_line":"to group and categorize objects in the domain model."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In Nova, we have a less user-friendly, more complicated way of adding"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_9630f59f","line":20,"updated":"2014-05-02 16:00:24.000000000","message":"nit: Why \"zero\" or more?  Shouldn\u0027t this be \"one\" or more?","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"84ef6a2e97d9d5a668b393dce9d10d0b1d2d7d74","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"In most popular REST API interfaces, objects in the domain model can be"},{"line_number":20,"context_line":"\"tagged\" with zero or more simple strings. These strings may then be used"},{"line_number":21,"context_line":"to group and categorize objects in the domain model."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In Nova, we have a less user-friendly, more complicated way of adding"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_598cde7f","line":20,"in_reply_to":"9ad9bd40_9630f59f","updated":"2014-05-02 16:30:39.000000000","message":"Oh, just to point out that an instance doesn\u0027t need any tags associated with it... I can change that if you want. It\u0027s a holdover from my days doing entity-relationship diagramming ;)","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"ce619f7ac058ab17a4e6b1c0041fa73bd962f5e3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"In Nova, we have a less user-friendly, more complicated way of adding"},{"line_number":24,"context_line":"taxonomic abilities to the domain model, with key/value pairs of attributes"},{"line_number":25,"context_line":"that are, variously, called \"metadata\", \"system_metadata\", \"extra_specs\","},{"line_number":26,"context_line":"or \"metadetails\"."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In order to align Nova\u0027s REST API with the Internet\u0027s common understanding"},{"line_number":29,"context_line":"of `resource tagging`_, we can add an API extension that allows normal users"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_b6833903","line":26,"updated":"2014-05-02 16:00:24.000000000","message":"Is there any thought on deprecating any of these in favor or the more generic and global solution being proposed in this blueprint? Or are there still cases when you would want/need something in these existing tables but not in the new table you are proposing?","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"84ef6a2e97d9d5a668b393dce9d10d0b1d2d7d74","unresolved":false,"context_lines":[{"line_number":23,"context_line":"In Nova, we have a less user-friendly, more complicated way of adding"},{"line_number":24,"context_line":"taxonomic abilities to the domain model, with key/value pairs of attributes"},{"line_number":25,"context_line":"that are, variously, called \"metadata\", \"system_metadata\", \"extra_specs\","},{"line_number":26,"context_line":"or \"metadetails\"."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In order to align Nova\u0027s REST API with the Internet\u0027s common understanding"},{"line_number":29,"context_line":"of `resource tagging`_, we can add an API extension that allows normal users"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_b9cb2aa4","line":26,"in_reply_to":"9ad9bd40_b6833903","updated":"2014-05-02 16:30:39.000000000","message":"Great question, and something I touched on in one of the ML threads referenced below.\n\nI think there\u0027s definitely a use for the existing key/value attributes -- and that is in the following scenarios:\n\n * When the system itself is storing information\n * To enable \"protected\" key/value pairs that only\n   elevated users may set/change/read\n * To allow normal users to set arbitrary key/value\n   information as opposed to simple string tagging","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"72e908a755136de37e643f3862027e28359e3ea7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"for an instance."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Add a v2[.1] API extension to allow searching for instances based on one"},{"line_number":41,"context_line":"or more string tags."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_083594d9","line":41,"updated":"2014-05-02 22:21:45.000000000","message":"To prevent (a very slow) DoS attack on the system there needs to some upper limit on the number of tags, otherwise a bad user could just spin adding tags to their instance forever and eventually fill up the DB. Not sure it needs to be quota as such, maybe just a system wide config value.","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"872929405fa1f3a6adf3a74c48f6c8b87991049b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"for an instance."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Add a v2[.1] API extension to allow searching for instances based on one"},{"line_number":41,"context_line":"or more string tags."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_dd32565e","line":41,"in_reply_to":"9ad9bd40_083594d9","updated":"2014-05-06 01:21:24.000000000","message":"Sure, that\u0027s doable. I can add a note about that.","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"868c60f969ce0a53dfcc3d458359225cd7148998","unresolved":false,"context_lines":[{"line_number":38,"context_line":"for an instance."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Add a v2[.1] API extension to allow searching for instances based on one"},{"line_number":41,"context_line":"or more string tags."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_2452f266","line":41,"in_reply_to":"9ad9bd40_dd32565e","updated":"2014-05-19 18:59:55.000000000","message":"Done","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"72e908a755136de37e643f3862027e28359e3ea7","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Add a v2[.1] API extension to allow searching for instances based on one"},{"line_number":41,"context_line":"or more string tags."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_48279cb6","line":42,"updated":"2014-05-02 22:21:45.000000000","message":"Can an instance see its own tags via the metadata service ?","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"872929405fa1f3a6adf3a74c48f6c8b87991049b","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Add a v2[.1] API extension to allow searching for instances based on one"},{"line_number":41,"context_line":"or more string tags."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_1d391e41","line":42,"in_reply_to":"9ad9bd40_48279cb6","updated":"2014-05-06 01:21:24.000000000","message":"Not in scope for this particular spec. Could certainly add a metadata resource for it in future.","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"ce619f7ac058ab17a4e6b1c0041fa73bd962f5e3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives to simple string tagging are already available in Nova through"},{"line_number":47,"context_line":"the instance metadata key/value pairs API extension."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Data model impact"},{"line_number":50,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_96bab5be","line":47,"updated":"2014-05-02 16:00:24.000000000","message":"So why do we need another tagging mechanism?  Can you elaborate on why someone would prefer to use this new tagging support instead of the existing metatdata key/value pairs?","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"84ef6a2e97d9d5a668b393dce9d10d0b1d2d7d74","unresolved":false,"context_lines":[{"line_number":44,"context_line":"------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives to simple string tagging are already available in Nova through"},{"line_number":47,"context_line":"the instance metadata key/value pairs API extension."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Data model impact"},{"line_number":50,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_39771a3c","line":47,"in_reply_to":"9ad9bd40_96bab5be","updated":"2014-05-02 16:30:39.000000000","message":"String tagging is by far the most dominant method of categorizing resources in web APIs, and due to that, it\u0027s the most widely understood way of building taxonomies for an object model. It\u0027s simple and popular.","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"72e908a755136de37e643f3862027e28359e3ea7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Data model impact"},{"line_number":50,"context_line":"-----------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"A new `nova.objects.tags.TagList` object would be added to the object model."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The `nova.objects.instance.Instance` object would have a new `tags` field"},{"line_number":55,"context_line":"of type `nova.objects.tags.TagList` that would be populated on-demand (i.e."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_c83acccc","line":52,"updated":"2014-05-02 22:21:45.000000000","message":"Can you explain how this would be persisted in the DB ?   For example is it going to be a new table, new files in instances, etc ?","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"69343722b42341c519acc75dcf88a72825b62dee","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Data model impact"},{"line_number":50,"context_line":"-----------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"A new `nova.objects.tags.TagList` object would be added to the object model."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The `nova.objects.instance.Instance` object would have a new `tags` field"},{"line_number":55,"context_line":"of type `nova.objects.tags.TagList` that would be populated on-demand (i.e."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_f3416b0c","line":52,"in_reply_to":"7adec928_c8af802a","updated":"2014-05-08 21:51:10.000000000","message":"Phil, by \"see below\", I meant the section Implementation, which has a paragraph that begins \"For the database schema...\" :)","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"0271b35391897726f699a85f5b81e9787c81c282","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Data model impact"},{"line_number":50,"context_line":"-----------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"A new `nova.objects.tags.TagList` object would be added to the object model."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The `nova.objects.instance.Instance` object would have a new `tags` field"},{"line_number":55,"context_line":"of type `nova.objects.tags.TagList` that would be populated on-demand (i.e."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_c8af802a","line":52,"in_reply_to":"9ad9bd40_7d478abc","updated":"2014-05-07 17:41:41.000000000","message":"That tells me what your going to change at the Object layer - and I get that objects are mean to hide all that nasty DB cruft away from the code - but there are at least 2 different ways you could be implementing this in the DB layer behind the objects, and the BP should be covering that.","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"872929405fa1f3a6adf3a74c48f6c8b87991049b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Data model impact"},{"line_number":50,"context_line":"-----------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"A new `nova.objects.tags.TagList` object would be added to the object model."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The `nova.objects.instance.Instance` object would have a new `tags` field"},{"line_number":55,"context_line":"of type `nova.objects.tags.TagList` that would be populated on-demand (i.e."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_7d478abc","line":52,"in_reply_to":"9ad9bd40_c83acccc","updated":"2014-05-06 01:21:24.000000000","message":"Please see below. :)","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":9847,"name":"ricky.bo","email":"boh.ricky@gmail.com","username":"boh.ricky"},"change_message_id":"de85f59823d2f83bbc7be7dbd21f8623a7028020","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Return list of tags for a server ::"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    GET /v2/$PROJECT/servers/$SERVER_UUID/tags"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"returns ::"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_8af9c1ca","line":73,"updated":"2014-05-09 06:56:22.000000000","message":"Isn\u0027t the API like this:\n\nGET /v2/?{tenant_id}?/servers/?{server_id}?/tags","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"5be92c248b2b333e2b952cb2c4462427f0d77515","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Return list of tags for a server ::"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    GET /v2/$PROJECT/servers/$SERVER_UUID/tags"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"returns ::"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_eadb17eb","line":73,"in_reply_to":"7adec928_8af9c1ca","updated":"2014-05-09 19:44:30.000000000","message":"Yes, isn\u0027t that the same?","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"ce619f7ac058ab17a4e6b1c0041fa73bd962f5e3","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* `tag` -- One or more strings that will be used to filter results in an"},{"line_number":115,"context_line":"  AND expression."},{"line_number":116,"context_line":"* `tag-any` -- One or more strings that will be used to filter results in"},{"line_number":117,"context_line":"  an OR expression."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_56c02d2a","line":116,"updated":"2014-05-02 16:00:24.000000000","message":"+1\nI like the support for both AND and OR","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"72e908a755136de37e643f3862027e28359e3ea7","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* `tag` -- One or more strings that will be used to filter results in an"},{"line_number":115,"context_line":"  AND expression."},{"line_number":116,"context_line":"* `tag-any` -- One or more strings that will be used to filter results in"},{"line_number":117,"context_line":"  an OR expression."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_b516c153","line":116,"in_reply_to":"9ad9bd40_56c02d2a","updated":"2014-05-02 22:21:45.000000000","message":"Yep - nice idea","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"3e2068c64ca6b953e631b49df7f74b9dd3d19c0d","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  AND expression."},{"line_number":116,"context_line":"* `tag-any` -- One or more strings that will be used to filter results in"},{"line_number":117,"context_line":"  an OR expression."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Security impact"},{"line_number":120,"context_line":"---------------"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_e6f68af8","line":118,"updated":"2014-05-07 05:03:18.000000000","message":"Typically, tagging systems also allow users to both add new tags on demand and to choose from a list of tags already populated in the system. This prevents fragmentation (different spellings of the same tag) and also allows for easy resource searching.  Would there be an API to get a unique set of all tags across instances in a project?\n\nWe\u0027re working on concepts for the following blueprint as part of the Graffiti project https://blueprints.launchpad.net/horizon/+spec/tagging. We\u0027re still in concept exploration phase, but if this existed and we used the widget for nova instances, I think that we could incorporate a lookup to get all available tags for resources of type Nova instances.  It would just be behind our \"dictionary\" API concept.","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"df2bffa618406c5dc546cfea0526b2f768406021","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  AND expression."},{"line_number":116,"context_line":"* `tag-any` -- One or more strings that will be used to filter results in"},{"line_number":117,"context_line":"  an OR expression."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Security impact"},{"line_number":120,"context_line":"---------------"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_ffe9291b","line":118,"in_reply_to":"7adec928_73555bc5","updated":"2014-05-09 04:53:50.000000000","message":"Makes sense to keep this narrow. I actually hope you can attend our Graffiti design session at the Juno summit.  I\u0027ve seen you pop up on various tagging related blueprints and discussions and I\u0027d love to pick your brain!","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"5be92c248b2b333e2b952cb2c4462427f0d77515","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  AND expression."},{"line_number":116,"context_line":"* `tag-any` -- One or more strings that will be used to filter results in"},{"line_number":117,"context_line":"  an OR expression."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Security impact"},{"line_number":120,"context_line":"---------------"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_0ad763c0","line":118,"in_reply_to":"7adec928_ffe9291b","updated":"2014-05-09 19:44:30.000000000","message":"Absolutely, I\u0027d love to attend the Graffiti session. :)","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"69343722b42341c519acc75dcf88a72825b62dee","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  AND expression."},{"line_number":116,"context_line":"* `tag-any` -- One or more strings that will be used to filter results in"},{"line_number":117,"context_line":"  an OR expression."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Security impact"},{"line_number":120,"context_line":"---------------"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_73555bc5","line":118,"in_reply_to":"9ad9bd40_e6f68af8","updated":"2014-05-08 21:51:10.000000000","message":"That\u0027s a great idea, Travis. How about I work on a separate blueprint for that idea, though... to keep the scope of this one as tight as possible?","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"ce619f7ac058ab17a4e6b1c0041fa73bd962f5e3","unresolved":false,"context_lines":[{"line_number":135,"context_line":"------------------"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"None, though REGEXP-based querying on some fields might be modified to"},{"line_number":138,"context_line":"use a faster tag-list filtering query."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Other deployer impact"},{"line_number":141,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_d6027d6e","line":138,"updated":"2014-05-02 16:00:24.000000000","message":"Should this be supported since it opens the door to a DOS attack?  If the idea is that this design would be a \"simple\" tagging support structure then maybe the AND or OR queries would be sufficient.","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"84ef6a2e97d9d5a668b393dce9d10d0b1d2d7d74","unresolved":false,"context_lines":[{"line_number":135,"context_line":"------------------"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"None, though REGEXP-based querying on some fields might be modified to"},{"line_number":138,"context_line":"use a faster tag-list filtering query."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Other deployer impact"},{"line_number":141,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_d9eb8eae","line":138,"in_reply_to":"9ad9bd40_d6027d6e","updated":"2014-05-02 16:30:39.000000000","message":"Well, I mention the REGEXP existing support simply as something that could be avoided with the use of tag-based queries -- and frankly, tag-based queries with support for AND and OR would be more flexible and powerful anyway. But.. that said, removing or deprecating any existing feature is out of scope for this particular spec.","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":9847,"name":"ricky.bo","email":"boh.ricky@gmail.com","username":"boh.ricky"},"change_message_id":"f5a2aed6d2916f9b1a4fcb4ba53e5a724daafa92","unresolved":false,"context_lines":[{"line_number":153,"context_line":"For the database schema, the following table constructs would suffice ::"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    CREATE TABLE tags ("},{"line_number":156,"context_line":"        resource_id CHAR(32) NOT NULL PRIMARY KEY,"},{"line_number":157,"context_line":"        tag VARCHAR(80) NOT NULL CHARACTER SET utf8 PRIMARY KEY"},{"line_number":158,"context_line":"    );"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_eaefa5ae","line":156,"updated":"2014-05-09 06:59:50.000000000","message":"Do you mean this table may be used for other resources in the future?","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"5be92c248b2b333e2b952cb2c4462427f0d77515","unresolved":false,"context_lines":[{"line_number":153,"context_line":"For the database schema, the following table constructs would suffice ::"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    CREATE TABLE tags ("},{"line_number":156,"context_line":"        resource_id CHAR(32) NOT NULL PRIMARY KEY,"},{"line_number":157,"context_line":"        tag VARCHAR(80) NOT NULL CHARACTER SET utf8 PRIMARY KEY"},{"line_number":158,"context_line":"    );"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7adec928_2ae6dfb4","line":156,"in_reply_to":"7adec928_eaefa5ae","updated":"2014-05-09 19:44:30.000000000","message":"Yes, precisely.","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"ce619f7ac058ab17a4e6b1c0041fa73bd962f5e3","unresolved":false,"context_lines":[{"line_number":166,"context_line":"  jaypipes"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Other contributors:"},{"line_number":169,"context_line":"  skaufer"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Work Items"},{"line_number":172,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_36f3a99f","line":169,"updated":"2014-05-02 16:00:24.000000000","message":"Interesting :)","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"84ef6a2e97d9d5a668b393dce9d10d0b1d2d7d74","unresolved":false,"context_lines":[{"line_number":166,"context_line":"  jaypipes"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Other contributors:"},{"line_number":169,"context_line":"  skaufer"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Work Items"},{"line_number":172,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad9bd40_39dc7a12","line":169,"in_reply_to":"9ad9bd40_36f3a99f","updated":"2014-05-02 16:30:39.000000000","message":"Well, you had expressed interest in it :) Sorry!","commit_id":"211ac7bc3fd5b375cf1ac7a0e56633ece1d23074"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"332fd4887ed896ff3bca7c9e1f89336a06bc4f14","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    PUT /v2/{project_id}/servers/{server_id}/tags/{tag}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Returns `204 No Content`. If the number of tags would exceeds 40, shall return"},{"line_number":101,"context_line":"a `400 Bad Request`"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Remove a single tag on a server ::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7adec928_fdf6aa8f","line":100,"updated":"2014-05-21 13:25:17.000000000","message":"The hard coded limit described in the implementation section is 50.  Would be better to just say \"If the number of tags exceeds the per-server limit...\"","commit_id":"18ae2b664a81b5f181ea6989fe11559e95fb19a8"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2350f129929a6a0f1f98dc3cb1d379e042007645","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    PUT /v2/{project_id}/servers/{server_id}/tags/{tag}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Returns `204 No Content`. If the number of tags would exceeds 40, shall return"},{"line_number":101,"context_line":"a `400 Bad Request`"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Remove a single tag on a server ::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7adec928_b7015308","line":100,"in_reply_to":"7adec928_fdf6aa8f","updated":"2014-05-23 15:41:38.000000000","message":"Done","commit_id":"18ae2b664a81b5f181ea6989fe11559e95fb19a8"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"70ac464b6a830357e33c6a016b57662560ae51a7","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Changes would be made, in order, to:"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"1. the database API layer to add support for CRUD operations on instance tags"},{"line_number":186,"context_line":"2. the database API layer to add tag-list filtering support to"},{"line_number":187,"context_line":"   `instance_get_all_by_filters`"},{"line_number":188,"context_line":"3. the nova.objects layer to add support for the new TagList object"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7adec928_47661252","line":185,"updated":"2014-05-20 09:11:46.000000000","message":"If delete an instance, should we delete the related tags for the instance?","commit_id":"18ae2b664a81b5f181ea6989fe11559e95fb19a8"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"59f9490b37ca6d58085e10c38d14c9c11f19ed88","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Changes would be made, in order, to:"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"1. the database API layer to add support for CRUD operations on instance tags"},{"line_number":186,"context_line":"2. the database API layer to add tag-list filtering support to"},{"line_number":187,"context_line":"   `instance_get_all_by_filters`"},{"line_number":188,"context_line":"3. the nova.objects layer to add support for the new TagList object"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7adec928_249bb918","line":185,"in_reply_to":"7adec928_47661252","updated":"2014-05-20 15:42:38.000000000","message":"Yep.","commit_id":"18ae2b664a81b5f181ea6989fe11559e95fb19a8"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"70ac464b6a830357e33c6a016b57662560ae51a7","unresolved":false,"context_lines":[{"line_number":188,"context_line":"3. the nova.objects layer to add support for the new TagList object"},{"line_number":189,"context_line":"4. the nova.objects layer to add support for a tags field of the Instance"},{"line_number":190,"context_line":"   object"},{"line_number":191,"context_line":"5. the API extension for CRUD operations on the tag list"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Dependencies"},{"line_number":194,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7adec928_679eae08","line":191,"updated":"2014-05-20 09:11:46.000000000","message":"You mean the tag API for CRUD? There is no example in \u0027REST API impact\u0027.","commit_id":"18ae2b664a81b5f181ea6989fe11559e95fb19a8"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"59f9490b37ca6d58085e10c38d14c9c11f19ed88","unresolved":false,"context_lines":[{"line_number":188,"context_line":"3. the nova.objects layer to add support for the new TagList object"},{"line_number":189,"context_line":"4. the nova.objects layer to add support for a tags field of the Instance"},{"line_number":190,"context_line":"   object"},{"line_number":191,"context_line":"5. the API extension for CRUD operations on the tag list"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Dependencies"},{"line_number":194,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7adec928_e4f55151","line":191,"in_reply_to":"7adec928_679eae08","updated":"2014-05-20 15:42:38.000000000","message":"The whole section is an example of a CRUD API for server tags, though...","commit_id":"18ae2b664a81b5f181ea6989fe11559e95fb19a8"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"b1239b74625d04374142a152abcbee60c77e86fb","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"},{"line_number":59,"context_line":"length. (This length is entirely arbitrary and could be reduced or expanded"},{"line_number":60,"context_line":"depending on review discussion...)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"REST API impact"},{"line_number":63,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7adec928_75f8a37c","line":60,"updated":"2014-05-23 16:45:00.000000000","message":"I think we need to go with 255 for two reasons.  \n1) Glance image tags are 255.  Having different character lengths for tags in different services is just problematic.  See: https://github.com/openstack/glance/blob/master/glance/db/sqlalchemy/migrate_repo/versions/014_add_image_tags_table.py\n\n2) I know \"tags\" are considered simple, but that doesn\u0027t mean users won\u0027t create long ones.","commit_id":"4a947b9c55724d620146e8a021e4fa0181f0260b"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"3faed3ea6ab7021ff0711dc46ede85e6dcb425d9","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"},{"line_number":59,"context_line":"length. (This length is entirely arbitrary and could be reduced or expanded"},{"line_number":60,"context_line":"depending on review discussion...)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"REST API impact"},{"line_number":63,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7adec928_8877d101","line":60,"in_reply_to":"7adec928_2b107a00","updated":"2014-05-23 19:23:04.000000000","message":"+1 with Jay on this - I\u0027d rather not tempt users into bad habits","commit_id":"4a947b9c55724d620146e8a021e4fa0181f0260b"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"833d30638f48681b53eeb9c83e482d7c0cc25691","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"},{"line_number":59,"context_line":"length. (This length is entirely arbitrary and could be reduced or expanded"},{"line_number":60,"context_line":"depending on review discussion...)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"REST API impact"},{"line_number":63,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7adec928_2b107a00","line":60,"in_reply_to":"7adec928_75f8a37c","updated":"2014-05-23 17:40:28.000000000","message":"I would greatly prefer to keep a shorter-than-255 length :) There are a number of performance reasons (including the fact that MySQL converts all varchar columns to fixed-width columns when doing aggregation and temporary tables containing the varchar columns). In addition, if the tags are UTF-8 (as proposed below), the 255 width will actually be 765 bytes wide (which exacerbates the fixed-width problems on MySQL).\n\nI understand that this is an existing database schema in Glance, but this is greenfield for Nova, and as such, I think it would be better to be more restrictive here.","commit_id":"4a947b9c55724d620146e8a021e4fa0181f0260b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"8145bd1ac5d641899d1a5579068739dab3209f15","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"},{"line_number":59,"context_line":"length. (This length is entirely arbitrary and could be reduced or expanded"},{"line_number":60,"context_line":"depending on review discussion...)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"REST API impact"},{"line_number":63,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7adec928_ab2ac78d","line":60,"in_reply_to":"7adec928_8877d101","updated":"2014-05-23 20:07:48.000000000","message":"Sounds like a good argument to me for the length. If you revise the spec, I\u0027d put that argument into the spec.","commit_id":"4a947b9c55724d620146e8a021e4fa0181f0260b"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9a0b06647d8fd59ea5b2fbbc1dbaafb3144f175f","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"},{"line_number":59,"context_line":"length. (This length is entirely arbitrary and could be reduced or expanded"},{"line_number":60,"context_line":"depending on review discussion...)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"REST API impact"},{"line_number":63,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5adbc538_7cb470f2","line":60,"in_reply_to":"7adec928_ab2ac78d","updated":"2014-05-25 17:54:21.000000000","message":"Done","commit_id":"4a947b9c55724d620146e8a021e4fa0181f0260b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"b1239b74625d04374142a152abcbee60c77e86fb","unresolved":false,"context_lines":[{"line_number":93,"context_line":"Returns a `200 OK`. If the number of tags exceeds 40, shall return a"},{"line_number":94,"context_line":"`400 Bad Request`"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Add/replace a single tag on a server ::"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    PUT /v2/{project_id}/servers/{server_id}/tags/{tag}"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7adec928_95f36f9e","line":96,"updated":"2014-05-23 16:45:00.000000000","message":"Do you just mean \"add\" and not \"add/replace\"?  There isn\u0027t a \"to replace\" tag specified.","commit_id":"4a947b9c55724d620146e8a021e4fa0181f0260b"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"833d30638f48681b53eeb9c83e482d7c0cc25691","unresolved":false,"context_lines":[{"line_number":93,"context_line":"Returns a `200 OK`. If the number of tags exceeds 40, shall return a"},{"line_number":94,"context_line":"`400 Bad Request`"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Add/replace a single tag on a server ::"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    PUT /v2/{project_id}/servers/{server_id}/tags/{tag}"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7adec928_8bf42ed0","line":96,"in_reply_to":"7adec928_95f36f9e","updated":"2014-05-23 17:40:28.000000000","message":"Will expand below. I meant to put below that an existing tag of the same name would be a no-op and return a 204 No Content instead of raising a 400 or 409 Conflict.","commit_id":"4a947b9c55724d620146e8a021e4fa0181f0260b"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"65a7ab09e22056480f662645b70afd70ca80401c","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    PUT /v2/{project_id}/servers/{server_id}/tags/{tag}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Returns `204 No Content`. If the number of tags would exceeds the per-server"},{"line_number":101,"context_line":"limit, shall return a `400 Bad Request`"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Remove a single tag on a server ::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7adec928_dc299b8a","line":100,"updated":"2014-05-23 21:18:00.000000000","message":"You say per server limit here but 40 above. Is the limit a quota or a config option?\n\nI\u0027m assuming config option which defaults to 40?","commit_id":"4a947b9c55724d620146e8a021e4fa0181f0260b"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9a0b06647d8fd59ea5b2fbbc1dbaafb3144f175f","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    PUT /v2/{project_id}/servers/{server_id}/tags/{tag}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Returns `204 No Content`. If the number of tags would exceeds the per-server"},{"line_number":101,"context_line":"limit, shall return a `400 Bad Request`"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Remove a single tag on a server ::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5adbc538_5cbfb4d0","line":100,"in_reply_to":"7adec928_dc299b8a","updated":"2014-05-25 17:54:21.000000000","message":"I didn\u0027t want to add in a new configuration option, since Nova already suffers from config-variable hoarders disease ;)\n\nWill change the above to just say \"per server limit\" and rely on the hard-coded limit (see below in Implementation section)","commit_id":"4a947b9c55724d620146e8a021e4fa0181f0260b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"b1239b74625d04374142a152abcbee60c77e86fb","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        tag VARCHAR(80) NOT NULL CHARACTER SET utf8"},{"line_number":162,"context_line":"         COLLATION utf8_ci PRIMARY KEY"},{"line_number":163,"context_line":"    );"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Also see `Work Items`_ section below."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"There shall be a new hard-coded limit of 50 for the number of tags a user can"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7adec928_350d3b91","line":164,"updated":"2014-05-23 16:45:00.000000000","message":"See comments above on length... but I\u0027ll just paste them here for ease of reading.\n\nI think we need to go with 255 for two reasons.  \n1) Glance image tags are 255.  Having different character lengths for tags in different services is just problematic.  See: https://github.com/openstack/glance/blob/master/glance/db/sqlalchemy/migrate_repo/versions/014_add_image_tags_table.py\n\n2) I know \"tags\" are considered simple, but that doesn\u0027t mean users won\u0027t create long ones.","commit_id":"4a947b9c55724d620146e8a021e4fa0181f0260b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"b1239b74625d04374142a152abcbee60c77e86fb","unresolved":false,"context_lines":[{"line_number":162,"context_line":"         COLLATION utf8_ci PRIMARY KEY"},{"line_number":163,"context_line":"    );"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Also see `Work Items`_ section below."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"There shall be a new hard-coded limit of 50 for the number of tags a user can"},{"line_number":168,"context_line":"use on a server. No need to make this configurable or use the quota system at"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7adec928_5571e7de","line":165,"updated":"2014-05-23 16:45:00.000000000","message":"Quick question the jumps outside the scope of this spec. If we reuse this for flavors or other types of objects that can be shared across projects will there be a way to associate tags visibility across projects?  Or is it assumed that if a flavor is shared across projects that anybody with visibility will be able to tag it and see other projects tags?","commit_id":"4a947b9c55724d620146e8a021e4fa0181f0260b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"8145bd1ac5d641899d1a5579068739dab3209f15","unresolved":false,"context_lines":[{"line_number":162,"context_line":"         COLLATION utf8_ci PRIMARY KEY"},{"line_number":163,"context_line":"    );"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Also see `Work Items`_ section below."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"There shall be a new hard-coded limit of 50 for the number of tags a user can"},{"line_number":168,"context_line":"use on a server. No need to make this configurable or use the quota system at"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7adec928_4e415138","line":165,"in_reply_to":"7adec928_2bdeba3f","updated":"2014-05-23 20:07:48.000000000","message":"Okay!","commit_id":"4a947b9c55724d620146e8a021e4fa0181f0260b"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"833d30638f48681b53eeb9c83e482d7c0cc25691","unresolved":false,"context_lines":[{"line_number":162,"context_line":"         COLLATION utf8_ci PRIMARY KEY"},{"line_number":163,"context_line":"    );"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Also see `Work Items`_ section below."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"There shall be a new hard-coded limit of 50 for the number of tags a user can"},{"line_number":168,"context_line":"use on a server. No need to make this configurable or use the quota system at"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7adec928_2bdeba3f","line":165,"in_reply_to":"7adec928_5571e7de","updated":"2014-05-23 17:40:28.000000000","message":"Good question :)\n\nAs outlined in this blueprint, tags are entirely user-centric. Tags are in no way controlled or set on instances by the system. Cross-project \"capabilities\" consistency shall be handled in an entirely separate effort.","commit_id":"4a947b9c55724d620146e8a021e4fa0181f0260b"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"65a7ab09e22056480f662645b70afd70ca80401c","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"There shall be a new hard-coded limit of 50 for the number of tags a user can"},{"line_number":168,"context_line":"use on a server. No need to make this configurable or use the quota system at"},{"line_number":169,"context_line":"this point."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Assignee(s)"},{"line_number":172,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7adec928_bc74cf9c","line":169,"updated":"2014-05-23 21:18:00.000000000","message":"Ah OK I read further.... maybe need to make it consistent :-)\n\nWhy not make it configurable?","commit_id":"4a947b9c55724d620146e8a021e4fa0181f0260b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"11523afe95d05a0d620fa16c1402a95ffb788464","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. note::"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    Glance already have object tagging functionality, and the database schema"},{"line_number":65,"context_line":"    in that project uses a VARCHAR(255) length for the tag value. I would"},{"line_number":66,"context_line":"    greatly prefer to keep a shorter-than-255 length. There"},{"line_number":67,"context_line":"    are a number of performance reasons (including the fact that MySQL"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3ae8d1ca_d781d44b","line":64,"updated":"2014-05-27 13:33:48.000000000","message":"have \u003d\u003e has","commit_id":"521870b32b2f2b45e614cb29a4ad755dea798b69"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9aac1ef895f84542f0c2f10d1d2159034ce2c06f","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. note::"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    Glance already have object tagging functionality, and the database schema"},{"line_number":65,"context_line":"    in that project uses a VARCHAR(255) length for the tag value. I would"},{"line_number":66,"context_line":"    greatly prefer to keep a shorter-than-255 length. There"},{"line_number":67,"context_line":"    are a number of performance reasons (including the fact that MySQL"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3ae8d1ca_c33af635","line":64,"in_reply_to":"3ae8d1ca_d781d44b","updated":"2014-05-27 15:30:36.000000000","message":"Done","commit_id":"521870b32b2f2b45e614cb29a4ad755dea798b69"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"18f44494f68030c55ce31fb375dbe88ce218a091","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    ["},{"line_number":89,"context_line":"        \u0027tag-one\u0027,"},{"line_number":90,"context_line":"        \u0027tag-two\u0027"},{"line_number":91,"context_line":"    ]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Replace set of tags on a server ::"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5adbc538_7a3c7094","line":91,"updated":"2014-05-26 01:31:48.000000000","message":"Examples are nice, but could you also define the response in JSON schema as this will precisely define what is allowed - and for validation purposes we\u0027ll use json schema anyway","commit_id":"521870b32b2f2b45e614cb29a4ad755dea798b69"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9aac1ef895f84542f0c2f10d1d2159034ce2c06f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    ["},{"line_number":89,"context_line":"        \u0027tag-one\u0027,"},{"line_number":90,"context_line":"        \u0027tag-two\u0027"},{"line_number":91,"context_line":"    ]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Replace set of tags on a server ::"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3ae8d1ca_e33e1229","line":91,"in_reply_to":"5adbc538_7a3c7094","updated":"2014-05-27 15:30:36.000000000","message":"Done","commit_id":"521870b32b2f2b45e614cb29a4ad755dea798b69"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"18f44494f68030c55ce31fb375dbe88ce218a091","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    ["},{"line_number":100,"context_line":"        \u0027tag-one\u0027,"},{"line_number":101,"context_line":"        \u0027tag-three\u0027"},{"line_number":102,"context_line":"    ]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Returns a `200 OK`. If the number of tags exceeds the limit of tags per"},{"line_number":105,"context_line":"server, shall return a `400 Bad Request`"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5adbc538_ba46f821","line":102,"updated":"2014-05-26 01:31:48.000000000","message":"ditto about json schema","commit_id":"521870b32b2f2b45e614cb29a4ad755dea798b69"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9aac1ef895f84542f0c2f10d1d2159034ce2c06f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    ["},{"line_number":100,"context_line":"        \u0027tag-one\u0027,"},{"line_number":101,"context_line":"        \u0027tag-three\u0027"},{"line_number":102,"context_line":"    ]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Returns a `200 OK`. If the number of tags exceeds the limit of tags per"},{"line_number":105,"context_line":"server, shall return a `400 Bad Request`"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3ae8d1ca_b5a0bdf5","line":102,"in_reply_to":"5adbc538_ba46f821","updated":"2014-05-27 15:30:36.000000000","message":"Done","commit_id":"521870b32b2f2b45e614cb29a4ad755dea798b69"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"18f44494f68030c55ce31fb375dbe88ce218a091","unresolved":false,"context_lines":[{"line_number":114,"context_line":"`204 No Content`"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"If the number of tags would exceed the per-server limit, shall return a"},{"line_number":117,"context_line":"`400 Bad Request`"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Remove a single tag on a server ::"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5adbc538_ba1438f6","line":117,"updated":"2014-05-26 01:31:48.000000000","message":"I\u0027m just wondering if it would be confusing for a user if a badly formatted request to add a tag has the same response code as a correctly formatted request but the tag limit has been hit. Some REST APIs seem to use 403 with a description describing the error for quota type limits.","commit_id":"521870b32b2f2b45e614cb29a4ad755dea798b69"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9aac1ef895f84542f0c2f10d1d2159034ce2c06f","unresolved":false,"context_lines":[{"line_number":114,"context_line":"`204 No Content`"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"If the number of tags would exceed the per-server limit, shall return a"},{"line_number":117,"context_line":"`400 Bad Request`"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Remove a single tag on a server ::"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3ae8d1ca_1596d194","line":117,"in_reply_to":"5adbc538_ba1438f6","updated":"2014-05-27 15:30:36.000000000","message":"I\u0027d be happy to use a 403 instead of a 400. Just let me know what is the consistent return code to use in this case, and I\u0027ll change it up :)","commit_id":"521870b32b2f2b45e614cb29a4ad755dea798b69"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"18f44494f68030c55ce31fb375dbe88ce218a091","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Remove a single tag on a server ::"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    DELETE /v2/{project_id}/servers/{server_id}/tags/{tag}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Returns `204 No Content`"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5adbc538_9a585cfc","line":121,"updated":"2014-05-26 01:31:48.000000000","message":"What happens when you attempt to delete a tag which doesn\u0027t exist?","commit_id":"521870b32b2f2b45e614cb29a4ad755dea798b69"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9aac1ef895f84542f0c2f10d1d2159034ce2c06f","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Remove a single tag on a server ::"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    DELETE /v2/{project_id}/servers/{server_id}/tags/{tag}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Returns `204 No Content`"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3ae8d1ca_55905995","line":121,"in_reply_to":"5adbc538_9a585cfc","updated":"2014-05-27 15:30:36.000000000","message":"Done","commit_id":"521870b32b2f2b45e614cb29a4ad755dea798b69"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"18f44494f68030c55ce31fb375dbe88ce218a091","unresolved":false,"context_lines":[{"line_number":181,"context_line":"Also see `Work Items`_ section below."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"There shall be a new hard-coded limit of 50 for the number of tags a user can"},{"line_number":184,"context_line":"use on a server. No need to make this configurable or use the quota system at"},{"line_number":185,"context_line":"this point."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Assignee(s)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5adbc538_dae66416","line":184,"updated":"2014-05-26 01:31:48.000000000","message":"Is 50 a bit on the high side? I agree we want to make consistent across all the openstack based clouds but I\u0027m wondering if we should start with a lower threshold as increasing it is going to be a lot easier than decreasing it later.","commit_id":"521870b32b2f2b45e614cb29a4ad755dea798b69"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9aac1ef895f84542f0c2f10d1d2159034ce2c06f","unresolved":false,"context_lines":[{"line_number":181,"context_line":"Also see `Work Items`_ section below."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"There shall be a new hard-coded limit of 50 for the number of tags a user can"},{"line_number":184,"context_line":"use on a server. No need to make this configurable or use the quota system at"},{"line_number":185,"context_line":"this point."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Assignee(s)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3ae8d1ca_95d02155","line":184,"in_reply_to":"5adbc538_dae66416","updated":"2014-05-27 15:30:36.000000000","message":"It was a totally arbitrary number :) Open to suggestions. How about 20?","commit_id":"521870b32b2f2b45e614cb29a4ad755dea798b69"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"fb929fac5af112f9870ef7e70bde88615c9c508f","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    DELETE /v2/{project_id}/servers/{server_id}/tags"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Returns `204 No Content`, always, even if you attempt to delete a tag"},{"line_number":157,"context_line":"that does not exist."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"The API extension that would allow searching/filtering of the `GET /servers`"},{"line_number":160,"context_line":"REST API call would add the following query parameters:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3ae8d1ca_47d252d3","line":157,"updated":"2014-05-28 09:52:20.000000000","message":"If I am not mistaken in this query we are trying to remove ALL tags. Maybe \"always, even if you attempt to delete a tag that does not exist\" should be a comment to the previous response status, no?","commit_id":"2347f603cc6c4317e4689684747be5aca05628b0"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7acc79ff9c0ede7f1f5fd4180d964c6a54e4c523","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    DELETE /v2/{project_id}/servers/{server_id}/tags"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Returns `204 No Content`, always, even if you attempt to delete a tag"},{"line_number":157,"context_line":"that does not exist."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"The API extension that would allow searching/filtering of the `GET /servers`"},{"line_number":160,"context_line":"REST API call would add the following query parameters:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3ae8d1ca_bd9ddb5b","line":157,"in_reply_to":"3ae8d1ca_47d252d3","updated":"2014-05-28 15:03:49.000000000","message":"Doh, yes, Sergey, you are absolutely correct. I will fix. Thanks!","commit_id":"2347f603cc6c4317e4689684747be5aca05628b0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b131e5d77b77e39e0a92fdc7beaefb79ac17f253","unresolved":false,"context_lines":[{"line_number":23,"context_line":"In Nova, we have a less user-friendly, more complicated way of adding"},{"line_number":24,"context_line":"taxonomic abilities to the domain model, with key/value pairs of attributes"},{"line_number":25,"context_line":"that are, variously, called \"metadata\", \"system_metadata\", \"extra_specs\","},{"line_number":26,"context_line":"or \"metadetails\"."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In order to align Nova\u0027s REST API with the Internet\u0027s common understanding"},{"line_number":29,"context_line":"of `resource tagging`_, we can add an API extension that allows normal users"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ae5cdf2_a925d4ac","line":26,"updated":"2014-05-30 07:58:12.000000000","message":"yeah, I do wonder if we want to remove these from the next major microversion of v2.1 (aka v3). Anyway, thats a different spec.","commit_id":"d5c102ee688a73f6af4b60dacd2f89b11fc1524c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a07c6da0fc663f77cdb355064514a5d3d222ed11","unresolved":false,"context_lines":[{"line_number":23,"context_line":"In Nova, we have a less user-friendly, more complicated way of adding"},{"line_number":24,"context_line":"taxonomic abilities to the domain model, with key/value pairs of attributes"},{"line_number":25,"context_line":"that are, variously, called \"metadata\", \"system_metadata\", \"extra_specs\","},{"line_number":26,"context_line":"or \"metadetails\"."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In order to align Nova\u0027s REST API with the Internet\u0027s common understanding"},{"line_number":29,"context_line":"of `resource tagging`_, we can add an API extension that allows normal users"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ae5cdf2_e6f8944b","line":26,"in_reply_to":"1ae5cdf2_a925d4ac","updated":"2014-06-02 19:09:30.000000000","message":"Note that simple string tagging as proposed here is specifically for users. It\u0027s not for system metadata.","commit_id":"d5c102ee688a73f6af4b60dacd2f89b11fc1524c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a17480efa819ff795be663e818bc03f3e173bd97","unresolved":false,"context_lines":[{"line_number":23,"context_line":"In Nova, we have a less user-friendly, more complicated way of adding"},{"line_number":24,"context_line":"taxonomic abilities to the domain model, with key/value pairs of attributes"},{"line_number":25,"context_line":"that are, variously, called \"metadata\", \"system_metadata\", \"extra_specs\","},{"line_number":26,"context_line":"or \"metadetails\"."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In order to align Nova\u0027s REST API with the Internet\u0027s common understanding"},{"line_number":29,"context_line":"of `resource tagging`_, we can add an API extension that allows normal users"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ae5cdf2_83ba5021","line":26,"in_reply_to":"1ae5cdf2_e6f8944b","updated":"2014-06-03 08:09:39.000000000","message":"Yeah, we have user visible key values already, I just wonder about deprecating those in favour of this more standard approach.","commit_id":"d5c102ee688a73f6af4b60dacd2f89b11fc1524c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b131e5d77b77e39e0a92fdc7beaefb79ac17f253","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Data model impact"},{"line_number":50,"context_line":"-----------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"A new `nova.objects.tags.TagList` object would be added to the object model."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The `nova.objects.instance.Instance` object would have a new `tags` field"},{"line_number":55,"context_line":"of type `nova.objects.tags.TagList` that would be populated on-demand (i.e."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ae5cdf2_e90fdc2c","line":52,"updated":"2014-05-30 07:58:12.000000000","message":"Hmm, interesting, so its tags associated with any old uuid, so this could be reused for Hosts and Cells? Nice (I think...). Maybe pull that out explicitly?","commit_id":"d5c102ee688a73f6af4b60dacd2f89b11fc1524c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a07c6da0fc663f77cdb355064514a5d3d222ed11","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Data model impact"},{"line_number":50,"context_line":"-----------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"A new `nova.objects.tags.TagList` object would be added to the object model."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The `nova.objects.instance.Instance` object would have a new `tags` field"},{"line_number":55,"context_line":"of type `nova.objects.tags.TagList` that would be populated on-demand (i.e."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ae5cdf2_66d644c7","line":52,"in_reply_to":"1ae5cdf2_e90fdc2c","updated":"2014-06-02 19:09:30.000000000","message":"Correct.","commit_id":"d5c102ee688a73f6af4b60dacd2f89b11fc1524c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b131e5d77b77e39e0a92fdc7beaefb79ac17f253","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"},{"line_number":59,"context_line":"length. (This length is entirely arbitrary and could be reduced or expanded"},{"line_number":60,"context_line":"depending on review discussion...)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. note::"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ae5cdf2_896e58c8","line":60,"updated":"2014-05-30 07:58:12.000000000","message":"Hmm, I kinda agree, but we need this for the documentation, and thats meant to be written from this doc. But it seems wrong to force a new spec if you change your mind...","commit_id":"d5c102ee688a73f6af4b60dacd2f89b11fc1524c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b131e5d77b77e39e0a92fdc7beaefb79ac17f253","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    converts all varchar columns to fixed-width columns when doing aggregation"},{"line_number":69,"context_line":"    and temporary tables containing the varchar columns). In addition, if the"},{"line_number":70,"context_line":"    tags are UTF-8 (as proposed above), the 255 width will actually be 765"},{"line_number":71,"context_line":"    bytes wide (which exacerbates the fixed-width problems on MySQL)."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"REST API impact"},{"line_number":74,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ae5cdf2_09b9682e","line":71,"updated":"2014-05-30 07:58:12.000000000","message":"yeah... I just worry about usability of all that.","commit_id":"d5c102ee688a73f6af4b60dacd2f89b11fc1524c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a07c6da0fc663f77cdb355064514a5d3d222ed11","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    converts all varchar columns to fixed-width columns when doing aggregation"},{"line_number":69,"context_line":"    and temporary tables containing the varchar columns). In addition, if the"},{"line_number":70,"context_line":"    tags are UTF-8 (as proposed above), the 255 width will actually be 765"},{"line_number":71,"context_line":"    bytes wide (which exacerbates the fixed-width problems on MySQL)."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"REST API impact"},{"line_number":74,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ae5cdf2_66464425","line":71,"in_reply_to":"1ae5cdf2_09b9682e","updated":"2014-06-02 19:09:30.000000000","message":"What is your concern about the usability of 60-byte-max tags?","commit_id":"d5c102ee688a73f6af4b60dacd2f89b11fc1524c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a17480efa819ff795be663e818bc03f3e173bd97","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    converts all varchar columns to fixed-width columns when doing aggregation"},{"line_number":69,"context_line":"    and temporary tables containing the varchar columns). In addition, if the"},{"line_number":70,"context_line":"    tags are UTF-8 (as proposed above), the 255 width will actually be 765"},{"line_number":71,"context_line":"    bytes wide (which exacerbates the fixed-width problems on MySQL)."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"REST API impact"},{"line_number":74,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ae5cdf2_43de886e","line":71,"in_reply_to":"1ae5cdf2_66464425","updated":"2014-06-03 08:09:39.000000000","message":"honestly don\u0027t remember, I think it was probably me just worrying about nova being different to glance, but I agree with your reasoning about why.","commit_id":"d5c102ee688a73f6af4b60dacd2f89b11fc1524c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b131e5d77b77e39e0a92fdc7beaefb79ac17f253","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        \u0027tag-two\u0027"},{"line_number":91,"context_line":"    ]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"JSONSchema document for response ::"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    {"},{"line_number":96,"context_line":"        \"title\": \"Server tags\","}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ae5cdf2_09e7a841","line":93,"updated":"2014-05-30 07:58:12.000000000","message":"thats cool, I think we only really wanted the scheme for the request, this is nice to have.","commit_id":"d5c102ee688a73f6af4b60dacd2f89b11fc1524c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b131e5d77b77e39e0a92fdc7beaefb79ac17f253","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    DELETE /v2/{project_id}/servers/{server_id}/tags/{tag}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Returns `204 No Content`, always, even if you attempt to delete a tag"},{"line_number":151,"context_line":"that does not exist."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Remove all tags on a server ::"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ae5cdf2_09908894","line":151,"updated":"2014-05-30 07:58:12.000000000","message":"hmm, thats not what we normally do, but I think that makes sense here.\n\nDoes this follow what glance does today? Its worth a note saying if it does or doesn\u0027t","commit_id":"d5c102ee688a73f6af4b60dacd2f89b11fc1524c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a07c6da0fc663f77cdb355064514a5d3d222ed11","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    DELETE /v2/{project_id}/servers/{server_id}/tags/{tag}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Returns `204 No Content`, always, even if you attempt to delete a tag"},{"line_number":151,"context_line":"that does not exist."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Remove all tags on a server ::"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ae5cdf2_a69f6c4f","line":151,"in_reply_to":"1ae5cdf2_09908894","updated":"2014-06-02 19:09:30.000000000","message":"No, Glance returns a 404 Not Found. I\u0027ll update the spec...","commit_id":"d5c102ee688a73f6af4b60dacd2f89b11fc1524c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b131e5d77b77e39e0a92fdc7beaefb79ac17f253","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"There shall be a new hard-coded limit of 50 for the number of tags a user can"},{"line_number":212,"context_line":"use on a server. No need to make this configurable or use the quota system at"},{"line_number":213,"context_line":"this point."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"Assignee(s)"},{"line_number":216,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ae5cdf2_0955e8c5","line":213,"updated":"2014-05-30 07:58:12.000000000","message":"we don\u0027t normally use this bit, and thats kinda confusing, we normally put this detail in the data model impact. (in theory).","commit_id":"d5c102ee688a73f6af4b60dacd2f89b11fc1524c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a07c6da0fc663f77cdb355064514a5d3d222ed11","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"There shall be a new hard-coded limit of 50 for the number of tags a user can"},{"line_number":212,"context_line":"use on a server. No need to make this configurable or use the quota system at"},{"line_number":213,"context_line":"this point."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"Assignee(s)"},{"line_number":216,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ae5cdf2_e6733413","line":213,"in_reply_to":"1ae5cdf2_0955e8c5","updated":"2014-06-02 19:09:30.000000000","message":"Done","commit_id":"d5c102ee688a73f6af4b60dacd2f89b11fc1524c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4f837a680f6c46a7bf1ee9045a03e088174331ca","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"There shall be a new hard-coded limit of 50 for the number of tags a user can"},{"line_number":82,"context_line":"use on a server. No need to make this configurable or use the quota system at"},{"line_number":83,"context_line":"this point."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"REST API impact"},{"line_number":86,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_03280033","line":83,"updated":"2014-06-03 08:27:50.000000000","message":"Seems OK, can always add a quota I guess. I did wonder about re-using the existing key-value quota for the number of tags. But maybe thats just confusing.","commit_id":"dc76660a191bb7f8092d25bbb48f807085eee74d"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c0d7d873a558f57ce1792aa8806d775f170dfb8f","unresolved":false,"context_lines":[{"line_number":153,"context_line":"`204 No Content`"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"If the number of tags would exceed the per-server limit, shall return a"},{"line_number":156,"context_line":"`400 Bad Request`"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Remove a single tag on a server ::"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_dcac2ea3","line":156,"updated":"2014-06-03 11:11:02.000000000","message":"I guess this discussion related to this return code http://lists.openstack.org/pipermail/openstack-dev/2014-June/036557.html","commit_id":"dc76660a191bb7f8092d25bbb48f807085eee74d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4f837a680f6c46a7bf1ee9045a03e088174331ca","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    Glance v2 API exposes different behavior. If a tag does not exist,"},{"line_number":168,"context_line":"    a call to DELETE /v2/images/{image_id}/tags/{tag} will result in"},{"line_number":169,"context_line":"    a 404 Not Found."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Remove all tags on a server ::"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_43fa08be","line":169,"updated":"2014-06-03 08:27:50.000000000","message":"Given the discussion around API consistency between projects, I would love for us to agree something around tags before adding this in.\n\nThat sucks, I know, just feel we should \"get this right\".","commit_id":"dc76660a191bb7f8092d25bbb48f807085eee74d"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c0d7d873a558f57ce1792aa8806d775f170dfb8f","unresolved":false,"context_lines":[{"line_number":180,"context_line":"* `tag` -- One or more strings that will be used to filter results in an"},{"line_number":181,"context_line":"  AND expression."},{"line_number":182,"context_line":"* `tag-any` -- One or more strings that will be used to filter results in"},{"line_number":183,"context_line":"  an OR expression."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Security impact"},{"line_number":186,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_3c227201","line":183,"updated":"2014-06-03 11:11:02.000000000","message":"Can I use them both at same time? \u0027tag\u003da\u0026tag\u003db\u0026tag-any\u003dc\u0026tag-any\u003dd\u0027 should means \u0027(a and b) and (c or d)\u0027?","commit_id":"dc76660a191bb7f8092d25bbb48f807085eee74d"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"543bc279d34cd9a5d9a3bff065f7ef56ae80043c","unresolved":false,"context_lines":[{"line_number":180,"context_line":"* `tag` -- One or more strings that will be used to filter results in an"},{"line_number":181,"context_line":"  AND expression."},{"line_number":182,"context_line":"* `tag-any` -- One or more strings that will be used to filter results in"},{"line_number":183,"context_line":"  an OR expression."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Security impact"},{"line_number":186,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_e78da97d","line":183,"in_reply_to":"1ae5cdf2_3c227201","updated":"2014-06-04 12:49:04.000000000","message":"Good question! I think it would be nice to use both of these parameters together","commit_id":"dc76660a191bb7f8092d25bbb48f807085eee74d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"5f5fbc9be17841b0e9950240ef6dc6cb9d7d3f66","unresolved":false,"context_lines":[{"line_number":180,"context_line":"* `tag` -- One or more strings that will be used to filter results in an"},{"line_number":181,"context_line":"  AND expression."},{"line_number":182,"context_line":"* `tag-any` -- One or more strings that will be used to filter results in"},{"line_number":183,"context_line":"  an OR expression."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Security impact"},{"line_number":186,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ae5cdf2_a0f1bd02","line":183,"in_reply_to":"1ae5cdf2_e78da97d","updated":"2014-06-04 18:36:30.000000000","message":"Yeah, I see no reason why not. :)","commit_id":"dc76660a191bb7f8092d25bbb48f807085eee74d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"957ce369fb7223cf28d2b95644d45d26e1d1cea7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"of type `nova.objects.tags.TagList` that would be populated on-demand (i.e."},{"line_number":56,"context_line":"not eager-loaded)."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"},{"line_number":59,"context_line":"length. (This length is entirely arbitrary and could be reduced or expanded"},{"line_number":60,"context_line":"depending on review discussion...)"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ae5cdf2_78cf5d56","line":58,"updated":"2014-06-05 04:01:02.000000000","message":"just a question: Where does \u002760 bytes\u0027 come from?\nMany items are 255 bytes now, so 60 bytes seems different and I\u0027d like to know the reason.","commit_id":"20d04feb203db419d23c1ae6df45ea8c496f7498"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"27ad1ef40efcf92b29eb7e1b2617645ad2e4a01f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"of type `nova.objects.tags.TagList` that would be populated on-demand (i.e."},{"line_number":56,"context_line":"not eager-loaded)."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"},{"line_number":59,"context_line":"length. (This length is entirely arbitrary and could be reduced or expanded"},{"line_number":60,"context_line":"depending on review discussion...)"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ae5cdf2_7c3491fb","line":58,"in_reply_to":"1ae5cdf2_78cf5d56","updated":"2014-06-05 20:48:57.000000000","message":"255 bytes is not good. See below note.\n\n60 bytes, as noted in the parens below, is arbitrary and could be reduced, but I think it\u0027s a better sizing tha 255 bytes (which gets multiplied to 767 for the popular InnoDB storage engine in MySQL when stored in UTF-8","commit_id":"20d04feb203db419d23c1ae6df45ea8c496f7498"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1c3ed76307cf59c7f96ec731c38318df10a9f78e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"of type `nova.objects.tags.TagList` that would be populated on-demand (i.e."},{"line_number":56,"context_line":"not eager-loaded)."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"},{"line_number":59,"context_line":"length. (This length is entirely arbitrary and could be reduced or expanded"},{"line_number":60,"context_line":"depending on review discussion...)"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ae5cdf2_19e1d529","line":58,"in_reply_to":"1ae5cdf2_7c3491fb","updated":"2014-06-06 05:43:56.000000000","message":"Thanks, Jay. I see.","commit_id":"20d04feb203db419d23c1ae6df45ea8c496f7498"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"957ce369fb7223cf28d2b95644d45d26e1d1cea7","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    }"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Returns a `200 OK`. If the number of tags exceeds the limit of tags per"},{"line_number":144,"context_line":"server, shall return a `400 Bad Request`"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Add a single tag on a server ::"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ae5cdf2_5898e177","line":144,"updated":"2014-06-05 04:01:02.000000000","message":"This case is similar to out of quota, and the similar discussion happened and \u0027403 Forbidden\u0027 would be better instead of \u0027400 Bad Request\u0027. So how about 403 for this case also?\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2014-June/036557.html","commit_id":"20d04feb203db419d23c1ae6df45ea8c496f7498"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"27ad1ef40efcf92b29eb7e1b2617645ad2e4a01f","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    }"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Returns a `200 OK`. If the number of tags exceeds the limit of tags per"},{"line_number":144,"context_line":"server, shall return a `400 Bad Request`"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Add a single tag on a server ::"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ae5cdf2_bc3a99e4","line":144,"in_reply_to":"1ae5cdf2_5898e177","updated":"2014-06-05 20:48:57.000000000","message":"OK, will change.","commit_id":"20d04feb203db419d23c1ae6df45ea8c496f7498"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"957ce369fb7223cf28d2b95644d45d26e1d1cea7","unresolved":false,"context_lines":[{"line_number":150,"context_line":"Returns `204 No Content`."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"If the tag already exists, no error is raised, it just returns the"},{"line_number":153,"context_line":"`204 No Content`"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"If the number of tags would exceed the per-server limit, shall return a"},{"line_number":156,"context_line":"`400 Bad Request`"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ae5cdf2_78a11d93","line":153,"updated":"2014-06-05 04:01:02.000000000","message":"How about \u0027409 Conflict\u0027 like \u0027create a flavor\u0027 API?","commit_id":"20d04feb203db419d23c1ae6df45ea8c496f7498"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"27ad1ef40efcf92b29eb7e1b2617645ad2e4a01f","unresolved":false,"context_lines":[{"line_number":150,"context_line":"Returns `204 No Content`."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"If the tag already exists, no error is raised, it just returns the"},{"line_number":153,"context_line":"`204 No Content`"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"If the number of tags would exceed the per-server limit, shall return a"},{"line_number":156,"context_line":"`400 Bad Request`"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ae5cdf2_5c299599","line":153,"in_reply_to":"1ae5cdf2_23fbd379","updated":"2014-06-05 20:48:57.000000000","message":"Agree with Travis on this one.","commit_id":"20d04feb203db419d23c1ae6df45ea8c496f7498"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1c3ed76307cf59c7f96ec731c38318df10a9f78e","unresolved":false,"context_lines":[{"line_number":150,"context_line":"Returns `204 No Content`."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"If the tag already exists, no error is raised, it just returns the"},{"line_number":153,"context_line":"`204 No Content`"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"If the number of tags would exceed the per-server limit, shall return a"},{"line_number":156,"context_line":"`400 Bad Request`"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ae5cdf2_99432512","line":153,"in_reply_to":"1ae5cdf2_5c299599","updated":"2014-06-06 05:43:56.000000000","message":"Thanks for your explanation, Travis, Jay.\nThat is reasonable, I got it.","commit_id":"20d04feb203db419d23c1ae6df45ea8c496f7498"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"1eaaeabfcf3ccc87ed8816e429a82ecf1b9c46df","unresolved":false,"context_lines":[{"line_number":150,"context_line":"Returns `204 No Content`."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"If the tag already exists, no error is raised, it just returns the"},{"line_number":153,"context_line":"`204 No Content`"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"If the number of tags would exceed the per-server limit, shall return a"},{"line_number":156,"context_line":"`400 Bad Request`"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ae5cdf2_23fbd379","line":153,"in_reply_to":"1ae5cdf2_78a11d93","updated":"2014-06-05 17:15:07.000000000","message":"I think treating it as a non-error code (204) makes sense. A lot of http clients treat any 40x code as an error and will raise the error, which becomes something that will have to be coded around with no error handling logic needed, since the net result is exactly the desired result.\n\nThis could potentially happen in a dirty data state (two people have loaded the same resource in horizon and independently tag it with the same tag or a user has loaded the resource in two browser tabs and happens to tag it from both tabs).  I can\u0027t see how raising this error up to them is desirable instead of just treating at as an idempotent operation.","commit_id":"20d04feb203db419d23c1ae6df45ea8c496f7498"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"957ce369fb7223cf28d2b95644d45d26e1d1cea7","unresolved":false,"context_lines":[{"line_number":153,"context_line":"`204 No Content`"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"If the number of tags would exceed the per-server limit, shall return a"},{"line_number":156,"context_line":"`400 Bad Request`"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Remove a single tag on a server ::"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ae5cdf2_1882d9ff","line":156,"updated":"2014-06-05 04:01:02.000000000","message":"ditto: how about 403?","commit_id":"20d04feb203db419d23c1ae6df45ea8c496f7498"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"27ad1ef40efcf92b29eb7e1b2617645ad2e4a01f","unresolved":false,"context_lines":[{"line_number":153,"context_line":"`204 No Content`"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"If the number of tags would exceed the per-server limit, shall return a"},{"line_number":156,"context_line":"`400 Bad Request`"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Remove a single tag on a server ::"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ae5cdf2_7005950f","line":156,"in_reply_to":"1ae5cdf2_1882d9ff","updated":"2014-06-05 20:48:57.000000000","message":"Done","commit_id":"20d04feb203db419d23c1ae6df45ea8c496f7498"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8dc6ba91dd69326b102f30cb934741bd386c1482","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Add a v2[.1] API extension to allow searching for instances based on one"},{"line_number":41,"context_line":"or more string tags."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_2f461a22","line":42,"updated":"2014-06-16 14:03:17.000000000","message":"As you say, we already have a tagging facility via metadata, extra_specs, etc. So what is your intention wrt these existing mechanisms? Will existing usage of these be switched over to the tagging facility, or will they live side by side forever. If the former, then we could do with info on what will be switched to use tagging. If the latter, then we could do with guidance on the appropriate scenarios for use of each.","commit_id":"655ebef2f0a14a4187612e53c4d7aff856e89a0a"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"4d0a078891c2a024e90a3d4844d52967216765da","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Add a v2[.1] API extension to allow searching for instances based on one"},{"line_number":41,"context_line":"or more string tags."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_1f0d0738","line":42,"in_reply_to":"1ae5cdf2_1baa7cd2","updated":"2014-06-16 15:27:33.000000000","message":"Ok, can you just document that this isn\u0027t intended to replace/obsolete any of the existing metadata facilities. With the way you referenced system metadata/extra_specs/etc it in line 23, it felt like it was targetting replacement, where as I see now it is completely separate.","commit_id":"655ebef2f0a14a4187612e53c4d7aff856e89a0a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"cafa017f05ebff21f9979e016c8d9166c67325c4","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Add a v2[.1] API extension to allow searching for instances based on one"},{"line_number":41,"context_line":"or more string tags."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_dfd39f5d","line":42,"in_reply_to":"1ae5cdf2_1f0d0738","updated":"2014-06-16 15:37:03.000000000","message":"Done","commit_id":"655ebef2f0a14a4187612e53c4d7aff856e89a0a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"ad3325f16362874cf4c778b0ef33a8a291583b17","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Add a v2[.1] API extension to allow searching for instances based on one"},{"line_number":41,"context_line":"or more string tags."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_1baa7cd2","line":42,"in_reply_to":"1ae5cdf2_2f461a22","updated":"2014-06-16 15:13:57.000000000","message":"metadata isn\u0027t tagging. Simple string tagging is the web\u0027s most common and popular way of adding simple user-facing taxonomy to objects.\n\nI\u0027m not proposing we do anything with the metadata or extra_specs functionality at this time. The problem we have right now is there isn\u0027t an easy, common way for *normal users* (not admins, not the system itself) to tag resources in the API. This is what this blueprint is about. It\u0027s for normal users, not system or admin users.","commit_id":"655ebef2f0a14a4187612e53c4d7aff856e89a0a"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8dc6ba91dd69326b102f30cb934741bd386c1482","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"},{"line_number":59,"context_line":"length. (This length is entirely arbitrary and could be reduced or expanded"},{"line_number":60,"context_line":"depending on review discussion...)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. note::"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_2fe29a01","line":60,"updated":"2014-06-16 14:03:17.000000000","message":"You don\u0027t mention restrictions on the content, so will it be permitted for tag strings to in effect be key/value pairs ? ie will \"foo\u003dbar\" be a valid tag. If so, then I\u0027d expect the database model would be better served by having a separate \u0027key\u0027 and \u0027value\u0027 column so you can do exact match on \u0027key\u0027 without having the database do a string-prefix/substring matching.  Conversely if we do not want people using tags for key/value pairs, then it seems we should be more prescriptive on the tag contents to forbid anything except alpha-num + hyphen/underscore.","commit_id":"655ebef2f0a14a4187612e53c4d7aff856e89a0a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"ad3325f16362874cf4c778b0ef33a8a291583b17","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"},{"line_number":59,"context_line":"length. (This length is entirely arbitrary and could be reduced or expanded"},{"line_number":60,"context_line":"depending on review discussion...)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. note::"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_3b53b8e3","line":60,"in_reply_to":"1ae5cdf2_2fe29a01","updated":"2014-06-16 15:13:57.000000000","message":"You are not understanding what a simple string tag is.\n\nPlease see the wiki article linked above. Please also see any popular website, from launchpad to google to youtube to github to facebook, for what a tag is. A tag is not a key/value pair. A tag is a simple string. There are no restrictions on the characters that a tag can contain. If a normal user really wants to tag an instance with the string \"foo\u003dbar\", so be it. It\u0027s just a string.","commit_id":"655ebef2f0a14a4187612e53c4d7aff856e89a0a"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"4d0a078891c2a024e90a3d4844d52967216765da","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"},{"line_number":59,"context_line":"length. (This length is entirely arbitrary and could be reduced or expanded"},{"line_number":60,"context_line":"depending on review discussion...)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. note::"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_9b34ccfc","line":60,"in_reply_to":"1ae5cdf2_3b53b8e3","updated":"2014-06-16 15:27:33.000000000","message":"Ok, so please just document that the tags should be considered completely opaque. Virt drivers should not try to parse them to extract information from them at all.\n\nYou don\u0027t answer my question later about whether the \u0027/\u0027 character in a tag string needs to be considered for escaping in the URL or not.","commit_id":"655ebef2f0a14a4187612e53c4d7aff856e89a0a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"cafa017f05ebff21f9979e016c8d9166c67325c4","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"},{"line_number":59,"context_line":"length. (This length is entirely arbitrary and could be reduced or expanded"},{"line_number":60,"context_line":"depending on review discussion...)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. note::"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_9fc3d756","line":60,"in_reply_to":"1ae5cdf2_9b34ccfc","updated":"2014-06-16 15:37:03.000000000","message":"Done","commit_id":"655ebef2f0a14a4187612e53c4d7aff856e89a0a"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"a38303465fef72c0af2cb4b55812b8f3304b6b5b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        \"definitions\": {"},{"line_number":136,"context_line":"            \"tag\": {"},{"line_number":137,"context_line":"                \"type\": \"string\","},{"line_number":138,"context_line":"                \"maxLength\": 60"},{"line_number":139,"context_line":"            }"},{"line_number":140,"context_line":"        }"},{"line_number":141,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_bc5eeb74","line":138,"updated":"2014-06-07 11:23:54.000000000","message":"Is there any limitation which character we are disallowed?","commit_id":"655ebef2f0a14a4187612e53c4d7aff856e89a0a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"846865a9230d70de11e60ec142a501107e1397ee","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        \"definitions\": {"},{"line_number":136,"context_line":"            \"tag\": {"},{"line_number":137,"context_line":"                \"type\": \"string\","},{"line_number":138,"context_line":"                \"maxLength\": 60"},{"line_number":139,"context_line":"            }"},{"line_number":140,"context_line":"        }"},{"line_number":141,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_76a456b9","line":138,"in_reply_to":"1ae5cdf2_bc5eeb74","updated":"2014-06-09 19:48:51.000000000","message":"nope :)","commit_id":"655ebef2f0a14a4187612e53c4d7aff856e89a0a"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8dc6ba91dd69326b102f30cb934741bd386c1482","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Add a single tag on a server ::"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    PUT /v2/{project_id}/servers/{server_id}/tags/{tag}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Returns `204 No Content`."},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_6fbf42ab","line":148,"updated":"2014-06-16 14:03:17.000000000","message":"Will we allow \u0027/\u0027 in tag names, if so, should the \u0027/\u0027 be required to be escaped, so that we can keep  \"/servers/{server_id}/tags/{tag}/xxxxx\" available for future use.","commit_id":"655ebef2f0a14a4187612e53c4d7aff856e89a0a"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"46551838fcec364e1de4da69b017f0cb7533d72a","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    DELETE /v2/{project_id}/servers/{server_id}/tags/{tag}"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Returns `204 No Content` upon success. Returns a `404 Not Found` if you"},{"line_number":163,"context_line":"attempt to delete a tag that does not exist."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Remove all tags on a server ::"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_c5dcb749","line":162,"updated":"2014-06-08 13:48:57.000000000","message":"Came to this discussion late (based on email thread).  Do we have any documentation on idem potency for Openstack that\u0027s common?\n\nWhile not strictly idem potent it is still manageable from a callers perspective.  Esp. if this is standard, but it should be documented somewhere.  They just need to pass whether it\u0027s 204/404.","commit_id":"655ebef2f0a14a4187612e53c4d7aff856e89a0a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"846865a9230d70de11e60ec142a501107e1397ee","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    DELETE /v2/{project_id}/servers/{server_id}/tags/{tag}"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Returns `204 No Content` upon success. Returns a `404 Not Found` if you"},{"line_number":163,"context_line":"attempt to delete a tag that does not exist."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Remove all tags on a server ::"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_568f5a23","line":162,"in_reply_to":"1ae5cdf2_c5dcb749","updated":"2014-06-09 19:48:51.000000000","message":"not sure, Chris. I\u0027m just following recommendations from reviewers to be consistent with Glance\u0027s API...","commit_id":"655ebef2f0a14a4187612e53c4d7aff856e89a0a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d5f6ea0695c67f6fc5593891b3563aac47e223d2","unresolved":false,"context_lines":[{"line_number":195,"context_line":"------------------"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"None, though REGEXP-based querying on some fields might be modified to"},{"line_number":198,"context_line":"use a faster tag-list filtering query."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Other deployer impact"},{"line_number":201,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1ae5cdf2_2aab68d7","line":198,"updated":"2014-06-08 09:32:13.000000000","message":"When there is more data to be retrieved from the database there is always a performance impact. It may be worthwhile mentioning this.","commit_id":"655ebef2f0a14a4187612e53c4d7aff856e89a0a"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"fea0583c46199033ae582bc3a75a69890c2d5052","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"In most popular REST API interfaces, objects in the domain model can be"},{"line_number":20,"context_line":"\"tagged\" with zero or more simple strings. These strings may then be used"},{"line_number":21,"context_line":"to group and categorize objects in the domain model."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In Nova, we have a less user-friendly, more complicated way of adding"},{"line_number":24,"context_line":"taxonomic abilities to the domain model, with key/value pairs of attributes"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1ae5cdf2_baa66652","line":21,"updated":"2014-06-18 22:35:07.000000000","message":"Amazon uses key value and GCE uses string\n\nhttp://docs.aws.amazon.com/AWSEC2/latest/UserGuide/Using_Tags.html\n\nhttps://developers.google.com/compute/docs/instances#tags\n\nAlso assuming we want to tag other objects in subsequent blueprints will this lay the groundwork for that?","commit_id":"400196d8ef8714dcde7ded23cb8bba9129295bff"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"86d884f1ac53c5a73bce2579cb2196900a1716d0","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"In most popular REST API interfaces, objects in the domain model can be"},{"line_number":20,"context_line":"\"tagged\" with zero or more simple strings. These strings may then be used"},{"line_number":21,"context_line":"to group and categorize objects in the domain model."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In Nova, we have a less user-friendly, more complicated way of adding"},{"line_number":24,"context_line":"taxonomic abilities to the domain model, with key/value pairs of attributes"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1ae5cdf2_a82c2003","line":21,"in_reply_to":"1ae5cdf2_baa66652","updated":"2014-06-20 14:02:48.000000000","message":"Hi Joe,\n\nI suppose one could argue that the work in Glance and the new Catalog program for Solum, Glance, Murano and Heat is laying the groundwork for making consistent the metadata, string tagging, and hierarchical/related/nested schema and metadata discovery.\n\nThis is aligned with the thinking from those projects around user-facing, simple string tagging, yes.\n\nThanks,\n\n-jay","commit_id":"400196d8ef8714dcde7ded23cb8bba9129295bff"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"fea0583c46199033ae582bc3a75a69890c2d5052","unresolved":false,"context_lines":[{"line_number":48,"context_line":"------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Alternatives to simple string tagging are already available in Nova through"},{"line_number":51,"context_line":"the instance metadata key/value pairs API extension."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Data model impact"},{"line_number":54,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1ae5cdf2_9a09aa33","line":51,"updated":"2014-06-18 22:35:07.000000000","message":"Can you expand this section to explain why this isn\u0027t a good alternative (besides the point that you cannot get a list of servers with a specific key).\n\nAfter further discussion in IRC I have a few partial answers to this.\n\n* Some virt drivers may inject data into this space / use data from here. Although I think those should be treated as bugs.\n* Some folks think the main use of this is for getting metadata inside of the VM, as these values are served to instances at http://169.254.169.254/openstack/2013-10-17/meta_data.json\n* We are trying to consolidate tagging formats around strings not key/value pairs\n* database issues?\n\n\nhaving two ways for a user to add tags (key/value or string) to an instance is confusing especially if there isn\u0027t any good documentation on when to use which.","commit_id":"400196d8ef8714dcde7ded23cb8bba9129295bff"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"bbf0847d6ea7b21889197cf933575947900f05a7","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"The `nova.objects.instance.Instance` object would have a new `tags` field"},{"line_number":59,"context_line":"of type `nova.objects.tags.TagList` that would be populated on-demand (i.e."},{"line_number":60,"context_line":"not eager-loaded)."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"},{"line_number":63,"context_line":"length. (This length is entirely arbitrary and could be reduced or expanded"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1ae5cdf2_7c721e7d","line":60,"updated":"2014-06-18 21:23:12.000000000","message":"I don\u0027t think this needs to be a new object. The instance object can have fields.ListOfStrings field that is only loaded if we ask for it, which should be fine here and avoid some complication.\n\nNote that you might be aiming for the length/format normalization here, in which case I think that a new field variant or parameters to the existing string field to enforce a format would be fine.\n\nIs there some reason this should really be an object on its own?","commit_id":"400196d8ef8714dcde7ded23cb8bba9129295bff"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"05509207699d094c8a6c814b69ea247ed8020836","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"The `nova.objects.instance.Instance` object would have a new `tags` field"},{"line_number":59,"context_line":"of type `nova.objects.tags.TagList` that would be populated on-demand (i.e."},{"line_number":60,"context_line":"not eager-loaded)."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"},{"line_number":63,"context_line":"length. (This length is entirely arbitrary and could be reduced or expanded"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1ae5cdf2_bc4586b5","line":60,"in_reply_to":"1ae5cdf2_7c721e7d","updated":"2014-06-18 21:32:35.000000000","message":"Ah, I had not considered that. Yeah, that totally makes for an easier scope of work.\n\nI will update the spec accordingly and make it dependent on a new spec that is scoped to make changes to the existing StringField type to add a max_length constraint.\n\nThanks for the heads up and suggestion.","commit_id":"400196d8ef8714dcde7ded23cb8bba9129295bff"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"86d884f1ac53c5a73bce2579cb2196900a1716d0","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"The `nova.objects.instance.Instance` object would have a new `tags` field"},{"line_number":59,"context_line":"of type `nova.objects.tags.TagList` that would be populated on-demand (i.e."},{"line_number":60,"context_line":"not eager-loaded)."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"},{"line_number":63,"context_line":"length. (This length is entirely arbitrary and could be reduced or expanded"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1ae5cdf2_c8e16cd1","line":60,"in_reply_to":"1ae5cdf2_bc4586b5","updated":"2014-06-20 14:02:48.000000000","message":"Updated to get rid of the TagList object and created a new spec here for the field type validation:\n\nhttps://review.openstack.org/101553","commit_id":"400196d8ef8714dcde7ded23cb8bba9129295bff"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"807176d7a1b572950911f9d68d2ed91f57ef7a0b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    CREATE TABLE tags ("},{"line_number":86,"context_line":"        resource_id CHAR(32) NOT NULL PRIMARY KEY,"},{"line_number":87,"context_line":"        tag VARCHAR(80) NOT NULL CHARACTER SET utf8"},{"line_number":88,"context_line":"         COLLATION utf8_ci PRIMARY KEY"},{"line_number":89,"context_line":"    );"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"There shall be a new hard-coded limit of 50 for the number of tags a user can"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1ae5cdf2_ff88e023","line":88,"updated":"2014-06-18 21:53:45.000000000","message":"I\u0027m not sure I want each tag for the same instance to get its own row in the DB. We already hate this for metadata...   Thoughts?","commit_id":"400196d8ef8714dcde7ded23cb8bba9129295bff"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6788720944462920944107efca59120b2aef44e5","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    CREATE TABLE tags ("},{"line_number":86,"context_line":"        resource_id CHAR(32) NOT NULL PRIMARY KEY,"},{"line_number":87,"context_line":"        tag VARCHAR(80) NOT NULL CHARACTER SET utf8"},{"line_number":88,"context_line":"         COLLATION utf8_ci PRIMARY KEY"},{"line_number":89,"context_line":"    );"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"There shall be a new hard-coded limit of 50 for the number of tags a user can"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1ae5cdf2_ef182d78","line":88,"in_reply_to":"1ae5cdf2_ff88e023","updated":"2014-06-19 00:31:38.000000000","message":"We discussed this in IRC and came back around to per-row being the optimal way to store these for searching performance. IMHO, storing metadata as a blob (because we should never SELECT based on a key) gives us better performance for that, and doesn\u0027t hinder our ability to store tags in that way for searching performance. Since tags would rarely be looked up with the instance itself (in fact, maybe we make it impossible to do so because of the impact to the DB) I think we\u0027re fine with them in rows.\n\nIf we don\u0027t want them in rows, then we\u0027re either going to lose the performance benefit when listing lots of instances/tags or need to explore other backing stores :)","commit_id":"400196d8ef8714dcde7ded23cb8bba9129295bff"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"62da54b254caa58363bc70ad8072e5dc8dd4e9ec","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Returns `204 No Content`."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"The API extension that would allow searching/filtering of the `GET /servers`"},{"line_number":182,"context_line":"REST API call would add the following query parameters:"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"* `tag` -- One or more strings that will be used to filter results in an"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1ae5cdf2_f7872e5f","line":181,"updated":"2014-06-18 20:05:26.000000000","message":"Ahh I missed this the first time because it wasn\u0027t formatted the same way with a detailed example like the other API calls","commit_id":"400196d8ef8714dcde7ded23cb8bba9129295bff"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0e6af535014988a53b8b795a251a3c8f841a3818","unresolved":false,"context_lines":[{"line_number":237,"context_line":"1. the database API layer to add support for CRUD operations on instance tags"},{"line_number":238,"context_line":"2. the database API layer to add tag-list filtering support to"},{"line_number":239,"context_line":"   `instance_get_all_by_filters`"},{"line_number":240,"context_line":"3. the nova.objects layer to add support for the new TagList object"},{"line_number":241,"context_line":"4. the nova.objects layer to add support for a tags field of the Instance"},{"line_number":242,"context_line":"   object"},{"line_number":243,"context_line":"5. the API extension for CRUD operations on the tag list"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1ae5cdf2_67832656","line":240,"updated":"2014-06-20 14:49:13.000000000","message":"This should be removed now, right?","commit_id":"75aecdfd8687fa789297a7fbc5eadd9b5b390a0d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"dc7f999fcf59b5ae4500c59802f44891cb78457a","unresolved":false,"context_lines":[{"line_number":237,"context_line":"1. the database API layer to add support for CRUD operations on instance tags"},{"line_number":238,"context_line":"2. the database API layer to add tag-list filtering support to"},{"line_number":239,"context_line":"   `instance_get_all_by_filters`"},{"line_number":240,"context_line":"3. the nova.objects layer to add support for the new TagList object"},{"line_number":241,"context_line":"4. the nova.objects layer to add support for a tags field of the Instance"},{"line_number":242,"context_line":"   object"},{"line_number":243,"context_line":"5. the API extension for CRUD operations on the tag list"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1ae5cdf2_27ee7eed","line":240,"in_reply_to":"1ae5cdf2_67832656","updated":"2014-06-20 15:04:12.000000000","message":"Nice catch. Done.","commit_id":"75aecdfd8687fa789297a7fbc5eadd9b5b390a0d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0e6af535014988a53b8b795a251a3c8f841a3818","unresolved":false,"context_lines":[{"line_number":249,"context_line":"objects. I say soft because technically this blueprint can be implemented"},{"line_number":250,"context_line":"with the tag string length validation done at the database schema level:"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"https://blueprints.launchpad.net/nova/+spec/field-type-validation"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Testing"},{"line_number":255,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1ae5cdf2_a7f0cefd","line":252,"updated":"2014-06-20 14:49:13.000000000","message":"Maybe mitigate this dependency by hard-coding the limits into the API for the time being until they\u0027re enforced by the actual object? This would avoid CD people from getting a small behavior change if we merge this earlier.","commit_id":"75aecdfd8687fa789297a7fbc5eadd9b5b390a0d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"dc7f999fcf59b5ae4500c59802f44891cb78457a","unresolved":false,"context_lines":[{"line_number":249,"context_line":"objects. I say soft because technically this blueprint can be implemented"},{"line_number":250,"context_line":"with the tag string length validation done at the database schema level:"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"https://blueprints.launchpad.net/nova/+spec/field-type-validation"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Testing"},{"line_number":255,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"1ae5cdf2_2774befc","line":252,"in_reply_to":"1ae5cdf2_a7f0cefd","updated":"2014-06-20 15:04:12.000000000","message":"Done","commit_id":"75aecdfd8687fa789297a7fbc5eadd9b5b390a0d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"be6cad9f7c4a87d132a905d71530413e38ec6c4c","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"In most popular REST API interfaces, objects in the domain model can be"},{"line_number":20,"context_line":"\"tagged\" with zero or more simple strings. These strings may then be used"},{"line_number":21,"context_line":"to group and categorize objects in the domain model."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In Nova, we have a less user-friendly, more complicated way of adding"},{"line_number":24,"context_line":"taxonomic abilities to the domain model, with key/value pairs of attributes"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_cf6bf6b7","line":21,"updated":"2014-06-23 18:05:06.000000000","message":"This shows that tags are to be used to group and categorize instances.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"842f3d13a8322eb8819ec8eda48362db80901522","unresolved":false,"context_lines":[{"line_number":23,"context_line":"In Nova, we have a less user-friendly, more complicated way of adding"},{"line_number":24,"context_line":"taxonomic abilities to the domain model, with key/value pairs of attributes"},{"line_number":25,"context_line":"that are, variously, called \"metadata\", \"system_metadata\", \"extra_specs\","},{"line_number":26,"context_line":"or \"metadetails\"."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In order to align Nova\u0027s REST API with the Internet\u0027s common understanding"},{"line_number":29,"context_line":"of `resource tagging`_, we can add an API extension that allows normal users"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_6203b0be","line":26,"updated":"2014-06-24 16:02:05.000000000","message":"These aren\u0027t all synonymous with what the scope of what you\u0027re proposing with tags - they are just a replacement for \"metadata\" right ?  Kind of feels like you\u0027re stretching a point here to make your case.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"68a44100844c1c34479cdc8d34a57119a95ae076","unresolved":false,"context_lines":[{"line_number":23,"context_line":"In Nova, we have a less user-friendly, more complicated way of adding"},{"line_number":24,"context_line":"taxonomic abilities to the domain model, with key/value pairs of attributes"},{"line_number":25,"context_line":"that are, variously, called \"metadata\", \"system_metadata\", \"extra_specs\","},{"line_number":26,"context_line":"or \"metadetails\"."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In order to align Nova\u0027s REST API with the Internet\u0027s common understanding"},{"line_number":29,"context_line":"of `resource tagging`_, we can add an API extension that allows normal users"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_2062fbac","line":26,"in_reply_to":"1ae5cdf2_6203b0be","updated":"2014-06-27 17:16:31.000000000","message":"OK, removed the paragraph...","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a05575e5d13ec5ed67eb711e8ff25f25658318bf","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"No changes to existing metadata, system_metadata or extra_specs functionality"},{"line_number":38,"context_line":"are being proposed. This is *specfically* for adding a new API for *normal"},{"line_number":39,"context_line":"users* to be able to tag their instances."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Add a v2[.1] API extension that allows a user to add, remove, and list tags"},{"line_number":42,"context_line":"for an instance."}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_cccea42d","line":39,"updated":"2014-06-23 17:58:08.000000000","message":"I think it\u0027s very clear that we\u0027re adding a new thing and not removing the old thing based on this line.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1a028d372f5739088ec88000fc9f944c43d62dad","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"No changes to existing metadata, system_metadata or extra_specs functionality"},{"line_number":38,"context_line":"are being proposed. This is *specfically* for adding a new API for *normal"},{"line_number":39,"context_line":"users* to be able to tag their instances."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Add a v2[.1] API extension that allows a user to add, remove, and list tags"},{"line_number":42,"context_line":"for an instance."}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_b5b24b04","line":39,"in_reply_to":"1ae5cdf2_39b73bf7","updated":"2014-06-24 18:27:25.000000000","message":"I don\u0027t think it makes sense to use the word \"migrate\" at all when talking about metadata and tags. I\u0027m sure that almost 100% of people that use tags will use metadata as well, since they are _different_things_.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"b01cb40e8bfabc93e52ae32e706d12243622ed51","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"No changes to existing metadata, system_metadata or extra_specs functionality"},{"line_number":38,"context_line":"are being proposed. This is *specfically* for adding a new API for *normal"},{"line_number":39,"context_line":"users* to be able to tag their instances."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Add a v2[.1] API extension that allows a user to add, remove, and list tags"},{"line_number":42,"context_line":"for an instance."}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_39b73bf7","line":39,"in_reply_to":"1ae5cdf2_4c2c54ad","updated":"2014-06-23 23:28:13.000000000","message":"I would like to see this spec explain when to use metadata and when to use tags and what the difference is. Currently the spec alludes to it but doesn\u0027t directly address it IMHO.\n\nI was thinking along these lines:\n\nThis spec will not replace our current user facing tagging system,metadata, but rather provide an alternative tagging system. Instance metadata is a user facing API that allows one to assign key/value pairs to instances. This API has a few shortcomings.\n\n * Currently there is no way to filter instances based in key. (but this can be fixed)\n * The API is poorly documented (but this can be fixed)\n * instances can read the key/value pairs in there instance metadata. And this is bad because?\n\n\n\nthe tag API is designed to help support efforts to enable string based tag support across multiple OpenStack project.\n\nIf you are already using the metadata API you can continue to do so, and if you would like to migrate over to the tag API you are responsible for migrating your data over.\n\nIf you are looking for an API to assign user-land metadata to an Instance it is recommended that you use the tags API, as we expect several projects to evolve around the tags API to consume them.\n\n\u003d\u003d\u003d\n\nSo I am not sure about any what I just wrote. But as a user I would like to see something like that explaining when to use what and why the difference is etc.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"1ba15faee1544332e76c619c2a0d67a23a974417","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"No changes to existing metadata, system_metadata or extra_specs functionality"},{"line_number":38,"context_line":"are being proposed. This is *specfically* for adding a new API for *normal"},{"line_number":39,"context_line":"users* to be able to tag their instances."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Add a v2[.1] API extension that allows a user to add, remove, and list tags"},{"line_number":42,"context_line":"for an instance."}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_d0f1a502","line":39,"in_reply_to":"1ae5cdf2_b5b24b04","updated":"2014-06-24 18:47:38.000000000","message":"I still don\u0027t understand how they are different beyond key/value vs string and the fact that metadata is made accessible to the instance and there is no search API (a fixable issue).","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"2108b4feb9de1a53740b3e66db3bf2c284aa6e88","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"No changes to existing metadata, system_metadata or extra_specs functionality"},{"line_number":38,"context_line":"are being proposed. This is *specfically* for adding a new API for *normal"},{"line_number":39,"context_line":"users* to be able to tag their instances."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Add a v2[.1] API extension that allows a user to add, remove, and list tags"},{"line_number":42,"context_line":"for an instance."}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_4c2c54ad","line":39,"in_reply_to":"1ae5cdf2_cccea42d","updated":"2014-06-23 18:01:23.000000000","message":"This still doesn\u0027t explain when one should use metadata and when one should use tags though.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"be6cad9f7c4a87d132a905d71530413e38ec6c4c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"for an instance."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Add a v2[.1] API extension to allow searching for instances based on one"},{"line_number":45,"context_line":"or more string tags."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_2f3b7ac9","line":45,"updated":"2014-06-23 18:05:06.000000000","message":"This makes it clear that if you want to filter instances when listing, you\u0027d use tags and the functions provided by the new API.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"9fd3fc574fa1186b61aa9fc0a6e7056d54ab8300","unresolved":false,"context_lines":[{"line_number":51,"context_line":"the instance metadata key/value pairs API extension. However, these existing"},{"line_number":52,"context_line":"approaches suffer from a few issues:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* There is no ability to filter servers that have a specific key in their"},{"line_number":55,"context_line":"  metadata."},{"line_number":56,"context_line":"* The key/value pairs in the existing server metadata API extension are"},{"line_number":57,"context_line":"  all exposed via the nova-metadata endpoint, and therefore some people"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_990f7c8b","line":54,"updated":"2014-06-23 17:37:16.000000000","message":"This is a fixable issue","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"b01cb40e8bfabc93e52ae32e706d12243622ed51","unresolved":false,"context_lines":[{"line_number":51,"context_line":"the instance metadata key/value pairs API extension. However, these existing"},{"line_number":52,"context_line":"approaches suffer from a few issues:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* There is no ability to filter servers that have a specific key in their"},{"line_number":55,"context_line":"  metadata."},{"line_number":56,"context_line":"* The key/value pairs in the existing server metadata API extension are"},{"line_number":57,"context_line":"  all exposed via the nova-metadata endpoint, and therefore some people"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_8e7e47ae","line":54,"in_reply_to":"1ae5cdf2_7b8c602f","updated":"2014-06-23 23:28:13.000000000","message":"I thought the motiation to move to a JSON blob was because we  send this data all over the place (notifications etc, when we probably shouldn\u0027t)","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"239986056ffce159f1216f987a086331ff520901","unresolved":false,"context_lines":[{"line_number":51,"context_line":"the instance metadata key/value pairs API extension. However, these existing"},{"line_number":52,"context_line":"approaches suffer from a few issues:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* There is no ability to filter servers that have a specific key in their"},{"line_number":55,"context_line":"  metadata."},{"line_number":56,"context_line":"* The key/value pairs in the existing server metadata API extension are"},{"line_number":57,"context_line":"  all exposed via the nova-metadata endpoint, and therefore some people"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_7b8c602f","line":54,"in_reply_to":"1ae5cdf2_8c02dcb8","updated":"2014-06-23 20:08:54.000000000","message":"Isn\u0027t that an implementation detail? The design can include a search mechanism, it will just be complicated by not using the database schema for the values.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1a028d372f5739088ec88000fc9f944c43d62dad","unresolved":false,"context_lines":[{"line_number":51,"context_line":"the instance metadata key/value pairs API extension. However, these existing"},{"line_number":52,"context_line":"approaches suffer from a few issues:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* There is no ability to filter servers that have a specific key in their"},{"line_number":55,"context_line":"  metadata."},{"line_number":56,"context_line":"* The key/value pairs in the existing server metadata API extension are"},{"line_number":57,"context_line":"  all exposed via the nova-metadata endpoint, and therefore some people"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_359d5b67","line":54,"in_reply_to":"1ae5cdf2_8e7e47ae","updated":"2014-06-24 18:27:25.000000000","message":"No, the motivation for the JSON blob is that it will be a much more efficient way to store metadata given the use case for it (i.e. not querying out of the database by key in any circumstance).","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ba7670b9a072ee261b55cc64caa0ee693f911c39","unresolved":false,"context_lines":[{"line_number":51,"context_line":"the instance metadata key/value pairs API extension. However, these existing"},{"line_number":52,"context_line":"approaches suffer from a few issues:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* There is no ability to filter servers that have a specific key in their"},{"line_number":55,"context_line":"  metadata."},{"line_number":56,"context_line":"* The key/value pairs in the existing server metadata API extension are"},{"line_number":57,"context_line":"  all exposed via the nova-metadata endpoint, and therefore some people"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_8c02dcb8","line":54,"in_reply_to":"1ae5cdf2_990f7c8b","updated":"2014-06-23 17:49:49.000000000","message":"It\u0027s not, because we\u0027re going to move metadata to a JSON blob.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"68a44100844c1c34479cdc8d34a57119a95ae076","unresolved":false,"context_lines":[{"line_number":51,"context_line":"the instance metadata key/value pairs API extension. However, these existing"},{"line_number":52,"context_line":"approaches suffer from a few issues:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* There is no ability to filter servers that have a specific key in their"},{"line_number":55,"context_line":"  metadata."},{"line_number":56,"context_line":"* The key/value pairs in the existing server metadata API extension are"},{"line_number":57,"context_line":"  all exposed via the nova-metadata endpoint, and therefore some people"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_c0c4f761","line":54,"in_reply_to":"1ae5cdf2_990f7c8b","updated":"2014-06-27 17:16:31.000000000","message":"OK, I removed this.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"9fd3fc574fa1186b61aa9fc0a6e7056d54ab8300","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* There is no ability to filter servers that have a specific key in their"},{"line_number":55,"context_line":"  metadata."},{"line_number":56,"context_line":"* The key/value pairs in the existing server metadata API extension are"},{"line_number":57,"context_line":"  all exposed via the nova-metadata endpoint, and therefore some people"},{"line_number":58,"context_line":"  think they are limited to being queried only from the 169.254.169.254"},{"line_number":59,"context_line":"  address."}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_f90ec08b","line":56,"updated":"2014-06-23 17:37:16.000000000","message":"This sounds like a documentation issue","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"68a44100844c1c34479cdc8d34a57119a95ae076","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* There is no ability to filter servers that have a specific key in their"},{"line_number":55,"context_line":"  metadata."},{"line_number":56,"context_line":"* The key/value pairs in the existing server metadata API extension are"},{"line_number":57,"context_line":"  all exposed via the nova-metadata endpoint, and therefore some people"},{"line_number":58,"context_line":"  think they are limited to being queried only from the 169.254.169.254"},{"line_number":59,"context_line":"  address."}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_407f0717","line":56,"in_reply_to":"1ae5cdf2_f90ec08b","updated":"2014-06-27 17:16:31.000000000","message":"Weren\u0027t you the one driving the whole \"the API documentation is the code\" thread? If the API itself is confusing due to its complexity and different uses depending on whether a normal user or the system is using it, then that is a problem, no?","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"9fd3fc574fa1186b61aa9fc0a6e7056d54ab8300","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  all exposed via the nova-metadata endpoint, and therefore some people"},{"line_number":58,"context_line":"  think they are limited to being queried only from the 169.254.169.254"},{"line_number":59,"context_line":"  address."},{"line_number":60,"context_line":"* The direction that Glance, Heat, Murano, and Solum are taking is to use"},{"line_number":61,"context_line":"  simple string tagging for user-side categorization of resources, and to"},{"line_number":62,"context_line":"  use key/value pairs, hierarchical metadata, and property bags for describing"},{"line_number":63,"context_line":"  system-side metadata about resources. Property bags are basically enumerated"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_d98024c2","line":60,"updated":"2014-06-23 17:37:16.000000000","message":"murano and solum are currently not incubated today, so this is a strange argument IMHO.\n\nThat being said since heat and glance already use simple string tagging I am fine with nova moving in that direction. But then the question arises what will \u0027metadata\u0027 be used for, and do we need a migration path? Etc.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"ada853acdefeb88dca996855ede816c37d4449c9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  all exposed via the nova-metadata endpoint, and therefore some people"},{"line_number":58,"context_line":"  think they are limited to being queried only from the 169.254.169.254"},{"line_number":59,"context_line":"  address."},{"line_number":60,"context_line":"* The direction that Glance, Heat, Murano, and Solum are taking is to use"},{"line_number":61,"context_line":"  simple string tagging for user-side categorization of resources, and to"},{"line_number":62,"context_line":"  use key/value pairs, hierarchical metadata, and property bags for describing"},{"line_number":63,"context_line":"  system-side metadata about resources. Property bags are basically enumerated"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_c8cda7bc","line":60,"in_reply_to":"1ae5cdf2_a58a4662","updated":"2014-06-23 21:46:20.000000000","message":"Indeed I know about Glance being used to store Heat templates. However, I hadn\u0027t heard of Heat itself supporting or utilizing any of that. AFAIK it is all for UI\u0027s like Horizon.\n\nFWIW I think this is an excellent direction, but it should not be tied to Heat as it is a general need for artifact organization and accessibility for users. Perhaps reword it to suggest that Glance is doing it _for Heat and other users_.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"68a44100844c1c34479cdc8d34a57119a95ae076","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  all exposed via the nova-metadata endpoint, and therefore some people"},{"line_number":58,"context_line":"  think they are limited to being queried only from the 169.254.169.254"},{"line_number":59,"context_line":"  address."},{"line_number":60,"context_line":"* The direction that Glance, Heat, Murano, and Solum are taking is to use"},{"line_number":61,"context_line":"  simple string tagging for user-side categorization of resources, and to"},{"line_number":62,"context_line":"  use key/value pairs, hierarchical metadata, and property bags for describing"},{"line_number":63,"context_line":"  system-side metadata about resources. Property bags are basically enumerated"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_807caf21","line":60,"in_reply_to":"1ae5cdf2_bbe428e1","updated":"2014-06-27 17:16:31.000000000","message":"OK, done.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"518f6302f80c6773e0736027c3be9fabdbe21ccc","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  all exposed via the nova-metadata endpoint, and therefore some people"},{"line_number":58,"context_line":"  think they are limited to being queried only from the 169.254.169.254"},{"line_number":59,"context_line":"  address."},{"line_number":60,"context_line":"* The direction that Glance, Heat, Murano, and Solum are taking is to use"},{"line_number":61,"context_line":"  simple string tagging for user-side categorization of resources, and to"},{"line_number":62,"context_line":"  use key/value pairs, hierarchical metadata, and property bags for describing"},{"line_number":63,"context_line":"  system-side metadata about resources. Property bags are basically enumerated"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_a58a4662","line":60,"in_reply_to":"1ae5cdf2_bbe428e1","updated":"2014-06-23 21:13:28.000000000","message":"The Glance program is moving this direction with its move to a Catalog mission. Heat will be using Glance as its mechanism for storing metadata about templates and other objects -- or at least that was the understanding I had based on the Glance design summit sessions around these ideas.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"239986056ffce159f1216f987a086331ff520901","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  all exposed via the nova-metadata endpoint, and therefore some people"},{"line_number":58,"context_line":"  think they are limited to being queried only from the 169.254.169.254"},{"line_number":59,"context_line":"  address."},{"line_number":60,"context_line":"* The direction that Glance, Heat, Murano, and Solum are taking is to use"},{"line_number":61,"context_line":"  simple string tagging for user-side categorization of resources, and to"},{"line_number":62,"context_line":"  use key/value pairs, hierarchical metadata, and property bags for describing"},{"line_number":63,"context_line":"  system-side metadata about resources. Property bags are basically enumerated"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_bbe428e1","line":60,"in_reply_to":"1ae5cdf2_d98024c2","updated":"2014-06-23 20:08:54.000000000","message":"As a Heat core dev and user, I\u0027m surprised by this statement. Unless I am mistaken, Heat does not provide any such facility.\n\nGlance is adding this specifically for static, standing resources. So I think this reference should be limited entirely to Glance.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"b01cb40e8bfabc93e52ae32e706d12243622ed51","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  proposed Catalog program will be following a strategy used by the Graffiti"},{"line_number":66,"context_line":"  project that is designed to handle metadata/catalog data of various formats"},{"line_number":67,"context_line":"  in a structured way, and leave user-focused taxonomy as simple-string tags"},{"line_number":68,"context_line":"  only."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Data model impact"},{"line_number":71,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_39ae5b99","line":68,"updated":"2014-06-23 23:28:13.000000000","message":"why not add search support to the metadata API, improve its documentation and just use a Value of \u0027None\u0027 and set  keys to specific tags?\n\nso \"Tag1\":None","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"68a44100844c1c34479cdc8d34a57119a95ae076","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  proposed Catalog program will be following a strategy used by the Graffiti"},{"line_number":66,"context_line":"  project that is designed to handle metadata/catalog data of various formats"},{"line_number":67,"context_line":"  in a structured way, and leave user-focused taxonomy as simple-string tags"},{"line_number":68,"context_line":"  only."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Data model impact"},{"line_number":71,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_c0723749","line":68,"in_reply_to":"1ae5cdf2_39ae5b99","updated":"2014-06-27 17:16:31.000000000","message":"Because that is not very friendly?","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"842f3d13a8322eb8819ec8eda48362db80901522","unresolved":false,"context_lines":[{"line_number":71,"context_line":"-----------------"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"The `nova.objects.instance.Instance` object would have a new `tags` field"},{"line_number":74,"context_line":"of type `nova.objects.fields.ListOfStrigs` that would be populated on-demand"},{"line_number":75,"context_line":"(i.e. not eager-loaded)."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_22744835","line":74,"updated":"2014-06-24 16:02:05.000000000","message":"typo: ListofStrigs\n\n(Unless Tags needs a new Strig data type ;-)","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"68a44100844c1c34479cdc8d34a57119a95ae076","unresolved":false,"context_lines":[{"line_number":71,"context_line":"-----------------"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"The `nova.objects.instance.Instance` object would have a new `tags` field"},{"line_number":74,"context_line":"of type `nova.objects.fields.ListOfStrigs` that would be populated on-demand"},{"line_number":75,"context_line":"(i.e. not eager-loaded)."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"A tag shall be defined as a Unicode bytestring no longer than 60 bytes in"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_e06d7368","line":74,"in_reply_to":"1ae5cdf2_22744835","updated":"2014-06-27 17:16:31.000000000","message":":) fixed.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"b01cb40e8bfabc93e52ae32e706d12243622ed51","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"There shall be a new hard-coded limit of 50 for the number of tags a user can"},{"line_number":107,"context_line":"use on a server. No need to make this configurable or use the quota system at"},{"line_number":108,"context_line":"this point."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"REST API impact"},{"line_number":111,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_4e5b5f55","line":108,"updated":"2014-06-23 23:28:13.000000000","message":"so hard coded quotas? I don\u0027t think operators would like that, but I guess we can wait until someone complains before making this dynamic. Works for me but its a only a matter of time IMHO.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1a028d372f5739088ec88000fc9f944c43d62dad","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"There shall be a new hard-coded limit of 50 for the number of tags a user can"},{"line_number":107,"context_line":"use on a server. No need to make this configurable or use the quota system at"},{"line_number":108,"context_line":"this point."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"REST API impact"},{"line_number":111,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_b5808bf8","line":108,"in_reply_to":"1ae5cdf2_4d6505ae","updated":"2014-06-24 18:27:25.000000000","message":"Agreed, I think it\u0027s fine.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"842f3d13a8322eb8819ec8eda48362db80901522","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"There shall be a new hard-coded limit of 50 for the number of tags a user can"},{"line_number":107,"context_line":"use on a server. No need to make this configurable or use the quota system at"},{"line_number":108,"context_line":"this point."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"REST API impact"},{"line_number":111,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_4d6505ae","line":108,"in_reply_to":"1ae5cdf2_4e5b5f55","updated":"2014-06-24 16:02:05.000000000","message":"I did look at this, but I think its OK.  Its hard to see a case for more than 50, and its hard to see 50 per instance as being a problem - so I think Its OK in the interests of avoiding one more configuration value.  Better to have a fixed value than to have no quota value.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ba7670b9a072ee261b55cc64caa0ee693f911c39","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Would return the servers having both the `{tag_a}` AND the `{tag_b}` tag."},{"line_number":224,"context_line":"No change is needed to the JSON response for the"},{"line_number":225,"context_line":"`GET /v2/{project_id}/servers/` call."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"Security impact"},{"line_number":228,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_6cc2f054","line":225,"updated":"2014-06-23 17:49:49.000000000","message":"Can you comment on what would happen if I mix the use of tag\u003d and tag-any\u003d ?","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"68a44100844c1c34479cdc8d34a57119a95ae076","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Would return the servers having both the `{tag_a}` AND the `{tag_b}` tag."},{"line_number":224,"context_line":"No change is needed to the JSON response for the"},{"line_number":225,"context_line":"`GET /v2/{project_id}/servers/` call."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"Security impact"},{"line_number":228,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1ae5cdf2_60fec36b","line":225,"in_reply_to":"1ae5cdf2_6cc2f054","updated":"2014-06-27 17:16:31.000000000","message":"Done.","commit_id":"3fc80fb49d563dfda215a645b1ddd00690cd84cf"}]}
