)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"668e3877205ce9a0135d43882321960469548484","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"898908fd_2bb79059","updated":"2024-11-15 08:35:49.000000000","message":"repropose with minor updates noted in the comments. Looks good.","commit_id":"8b7f072539528bf689c6c86a5b176d56155fd623"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"77215270c8a5a6e20c3d7d453b099970acab29db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"47a716c5_74cf1ede","updated":"2024-10-23 10:46:19.000000000","message":"thanks this is substantivly the same as the previous cycles with the minor nits and adressed and the history section updated.\n\ni see no reason not to proceed with this again this cycle as proposed.","commit_id":"8b7f072539528bf689c6c86a5b176d56155fd623"}],"specs/2025.1/approved/libvirt-spice-direct-consoles.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"77215270c8a5a6e20c3d7d453b099970acab29db","unresolved":false,"context_lines":[{"line_number":98,"context_line":"  I791b16c5bf0e860a188783c863e95dc423998b0a)"},{"line_number":99,"context_line":"* sound support via an extra spec to specify a sound device (WIP implementation"},{"line_number":100,"context_line":"  at I2faeda0fd0fb9c8894d69558a1ccaab8da9f6a1b)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Note that allowing concurrent console access from more than one user is"},{"line_number":103,"context_line":"technically feasbile, but forbidden by Nova\u0027s policy of not manipulating the"},{"line_number":104,"context_line":"`qemu`` command line directly. See I65f94771abdc1a6ef54637ea81f25ce1daaf4963"}],"source_content_type":"text/x-rst","patch_set":1,"id":"55e30b34_a0c47d4f","line":101,"updated":"2024-10-23 10:46:19.000000000","message":"ack this has been updated to remove \n\n* requiring an encrypted connection (WIP implementation at\n  Ica7083b0836f8d66cad8a4b4097613103fc91560)\n* allowing concurrent users as supported by SPICE (WIP implementation at\n  I65f94771abdc1a6ef54637ea81f25ce1daaf4963)\n  \nwhich were removed because both require the use of raw qemu command line arguments which are not allowed in nova\n\nand you have noted that below\n+1","commit_id":"8b7f072539528bf689c6c86a5b176d56155fd623"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"06897c7a47e4db7a4c243829851feba83072168c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"  I791b16c5bf0e860a188783c863e95dc423998b0a)"},{"line_number":99,"context_line":"* sound support via an extra spec to specify a sound device (WIP implementation"},{"line_number":100,"context_line":"  at I2faeda0fd0fb9c8894d69558a1ccaab8da9f6a1b)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Note that allowing concurrent console access from more than one user is"},{"line_number":103,"context_line":"technically feasbile, but forbidden by Nova\u0027s policy of not manipulating the"},{"line_number":104,"context_line":"`qemu`` command line directly. See I65f94771abdc1a6ef54637ea81f25ce1daaf4963"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bfb875e1_4242e67c","line":101,"in_reply_to":"3ed72bae_03cc694c","updated":"2024-11-14 20:44:24.000000000","message":"ah thanks for clarifying \nstill +2 on this","commit_id":"8b7f072539528bf689c6c86a5b176d56155fd623"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"239d28da0349c2d4498dab533dad231887e41e1c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"  I791b16c5bf0e860a188783c863e95dc423998b0a)"},{"line_number":99,"context_line":"* sound support via an extra spec to specify a sound device (WIP implementation"},{"line_number":100,"context_line":"  at I2faeda0fd0fb9c8894d69558a1ccaab8da9f6a1b)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Note that allowing concurrent console access from more than one user is"},{"line_number":103,"context_line":"technically feasbile, but forbidden by Nova\u0027s policy of not manipulating the"},{"line_number":104,"context_line":"`qemu`` command line directly. See I65f94771abdc1a6ef54637ea81f25ce1daaf4963"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ed72bae_03cc694c","line":101,"in_reply_to":"55e30b34_a0c47d4f","updated":"2024-10-26 06:42:40.000000000","message":"Mostly true. Requiring an encrypted connection was merged. Concurrent users requires qemu command line arguments and is therefore dropped.","commit_id":"8b7f072539528bf689c6c86a5b176d56155fd623"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"77215270c8a5a6e20c3d7d453b099970acab29db","unresolved":false,"context_lines":[{"line_number":114,"context_line":"deployed there is effectively no change to the network exposure of Nova"},{"line_number":115,"context_line":"hypervisors."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"When implemented, a user can fetch a Kerbside connection URL like this:"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"```"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9c0d1e35_2a2d5bc8","line":117,"updated":"2024-10-23 10:46:19.000000000","message":"references to the prototype patches have been removed which is appropriate\n\nhttps://review.opendev.org/c/openstack/nova-specs/+/915190/13/specs/2024.2/approved/libvirt-spice-direct-consoles.rst#108\n\nthey were not required in the orginal spec and this version is cleaner for not including them so +1","commit_id":"8b7f072539528bf689c6c86a5b176d56155fd623"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"77215270c8a5a6e20c3d7d453b099970acab29db","unresolved":true,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"The following configuration options are added by the proposed changes:"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"* `spice.spice_direct_proxy_base_url`: defaults to an example URL which"},{"line_number":256,"context_line":"  wouldn\u0027t actually work for a non-trivial installation (just as the HTML5"},{"line_number":257,"context_line":"  transcoding proxy does). This is the base URL for the Kerbside URLs handed"},{"line_number":258,"context_line":"  out by Nova."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a03f594_c6df464b","line":255,"updated":"2024-10-23 10:46:19.000000000","message":"ack this is updated based on sylvains prior request.\n+1\n\nhttps://review.opendev.org/c/openstack/nova-specs/+/915190/13/specs/2024.2/approved/libvirt-spice-direct-consoles.rst#265","commit_id":"8b7f072539528bf689c6c86a5b176d56155fd623"}]}