)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"30cd5464d54f5094ad1a9f7ba3ff11b26c2f8a4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"75e34bca_91230411","updated":"2025-01-10 21:43:43.000000000","message":"This looks consistent with what was discussed in the follow up patch that was squashed into the vTPM live migration patch [1]. It is necessary for the vTPM live migration spec to proceed and has significant usefulness anyway outside of that. LGTM\n\n[1] https://review.opendev.org/c/openstack/nova-specs/+/938843","commit_id":"99be7f9b68fce70af3bf978cbd886d479029f3f5"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a93ff2e8416110b605b57a1a23b6274f8e7c9138","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a684729a_edda95c7","updated":"2025-01-13 12:44:45.000000000","message":"Approved as as spec freeze exception due to the fact that two cores were already accepting this spec last week.","commit_id":"7bbf54e6bf6298c97cc4cf6e524e86ccb2ba7050"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4327737aa147c1b0143b90c31409cd8a86ad1e8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f301cb9e_1abfebb6","updated":"2025-01-10 21:52:31.000000000","message":"I just noticed in IRC that this is supposed to wait for a spec freeze exception, so I have pulled it from the gate. I leave my +2:\n\nhttps://meetings.opendev.org/irclogs/%23openstack-nova/%23openstack-nova.2025-01-10.log.html#t2025-01-10T15:17:47","commit_id":"7bbf54e6bf6298c97cc4cf6e524e86ccb2ba7050"}],"specs/2025.1/approved/image-props-in-server-show.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"203b4e159e3494851d471d369b765757f12b4ae9","unresolved":true,"context_lines":[{"line_number":33,"context_line":"  nova when scheduling and building my VM even after the image is changed or"},{"line_number":34,"context_line":"  deleted in glance."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Especially I as the owner of an existing VM want to see the required traits"},{"line_number":37,"context_line":"  in the embedded image properties so that I can observe the default vTPM"},{"line_number":38,"context_line":"  security mode applied to of my VM before I consent to such security change."},{"line_number":39,"context_line":"  See `vTPM live migration \u003chttps://review.opendev.org/c/openstack/nova-specs/+/936775\u003e`_"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5e555a4d_1f6c1744","line":36,"range":{"start_line":36,"start_character":62,"end_line":36,"end_character":77},"updated":"2025-01-10 16:28:19.000000000","message":"I guess we agreed that we will have that stored as the image property `hw_vtpm_secret_security` so I need to change this.","commit_id":"7e3ef9b6a3e12ef3732835043c9cdb788b1a8bfa"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b8ee29fb6ef7d33eeefb767620c28dbb77a38995","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  nova when scheduling and building my VM even after the image is changed or"},{"line_number":34,"context_line":"  deleted in glance."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Especially I as the owner of an existing VM want to see the required traits"},{"line_number":37,"context_line":"  in the embedded image properties so that I can observe the default vTPM"},{"line_number":38,"context_line":"  security mode applied to of my VM before I consent to such security change."},{"line_number":39,"context_line":"  See `vTPM live migration \u003chttps://review.opendev.org/c/openstack/nova-specs/+/936775\u003e`_"}],"source_content_type":"text/x-rst","patch_set":2,"id":"6840008f_a7aca059","line":36,"range":{"start_line":36,"start_character":62,"end_line":36,"end_character":77},"in_reply_to":"5e555a4d_1f6c1744","updated":"2025-01-10 17:00:16.000000000","message":"Done","commit_id":"7e3ef9b6a3e12ef3732835043c9cdb788b1a8bfa"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"32218ac7c5c3ee7290916c77d496bbf850664fb6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  nova when scheduling and building my VM even after the image is changed or"},{"line_number":34,"context_line":"  deleted in glance."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Especially I as the owner of an existing VM want to see the required traits"},{"line_number":37,"context_line":"  in the embedded image properties so that I can observe the default vTPM"},{"line_number":38,"context_line":"  security mode applied to of my VM before I consent to such security change."},{"line_number":39,"context_line":"  See `vTPM live migration \u003chttps://review.opendev.org/c/openstack/nova-specs/+/936775\u003e`_"}],"source_content_type":"text/x-rst","patch_set":2,"id":"faa0a4d9_b96f0a37","line":36,"range":{"start_line":36,"start_character":62,"end_line":36,"end_character":77},"in_reply_to":"5e555a4d_1f6c1744","updated":"2025-01-10 19:40:41.000000000","message":"Done","commit_id":"7e3ef9b6a3e12ef3732835043c9cdb788b1a8bfa"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6452c793ff5f7189c5cdf40b5e0aac504e181908","unresolved":true,"context_lines":[{"line_number":37,"context_line":"  in the embedded image properties so that I can observe the default vTPM"},{"line_number":38,"context_line":"  security mode applied to of my VM before I consent to such security change."},{"line_number":39,"context_line":"  See `vTPM live migration \u003chttps://review.opendev.org/c/openstack/nova-specs/+/936775\u003e`_"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1afe88f3_bbceea99","line":40,"updated":"2025-01-10 16:46:09.000000000","message":"Maybe also another one about image properties the admin may have needed to change on my behalf? Could be security-related or just other stuff that impacts the user.","commit_id":"7e3ef9b6a3e12ef3732835043c9cdb788b1a8bfa"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"32218ac7c5c3ee7290916c77d496bbf850664fb6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  in the embedded image properties so that I can observe the default vTPM"},{"line_number":38,"context_line":"  security mode applied to of my VM before I consent to such security change."},{"line_number":39,"context_line":"  See `vTPM live migration \u003chttps://review.opendev.org/c/openstack/nova-specs/+/936775\u003e`_"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"8f02cdf1_e0e047b6","line":40,"in_reply_to":"1afe88f3_bbceea99","updated":"2025-01-10 19:40:41.000000000","message":"Done","commit_id":"7e3ef9b6a3e12ef3732835043c9cdb788b1a8bfa"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b8ee29fb6ef7d33eeefb767620c28dbb77a38995","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  in the embedded image properties so that I can observe the default vTPM"},{"line_number":38,"context_line":"  security mode applied to of my VM before I consent to such security change."},{"line_number":39,"context_line":"  See `vTPM live migration \u003chttps://review.opendev.org/c/openstack/nova-specs/+/936775\u003e`_"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"b8b30fcf_c901baeb","line":40,"in_reply_to":"1afe88f3_bbceea99","updated":"2025-01-10 17:00:16.000000000","message":"Done","commit_id":"7e3ef9b6a3e12ef3732835043c9cdb788b1a8bfa"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6452c793ff5f7189c5cdf40b5e0aac504e181908","unresolved":true,"context_lines":[{"line_number":44,"context_line":"In a new API microversion return the embedded image properties in the"},{"line_number":45,"context_line":"``GET /server/details`` and ``/server/{server_id}`` responses."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The implementation needs to copy each key value pairs form"},{"line_number":48,"context_line":"``instance.system_metadata`` to the response where the key is prefixed with"},{"line_number":49,"context_line":"``image_``."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"4391e5c5_cf0b81a0","line":47,"range":{"start_line":47,"start_character":54,"end_line":47,"end_character":58},"updated":"2025-01-10 16:46:09.000000000","message":"\"from\"","commit_id":"7e3ef9b6a3e12ef3732835043c9cdb788b1a8bfa"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"32218ac7c5c3ee7290916c77d496bbf850664fb6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"In a new API microversion return the embedded image properties in the"},{"line_number":45,"context_line":"``GET /server/details`` and ``/server/{server_id}`` responses."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The implementation needs to copy each key value pairs form"},{"line_number":48,"context_line":"``instance.system_metadata`` to the response where the key is prefixed with"},{"line_number":49,"context_line":"``image_``."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"29664a01_2ba2af25","line":47,"range":{"start_line":47,"start_character":54,"end_line":47,"end_character":58},"in_reply_to":"4391e5c5_cf0b81a0","updated":"2025-01-10 19:40:41.000000000","message":"Done","commit_id":"7e3ef9b6a3e12ef3732835043c9cdb788b1a8bfa"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b8ee29fb6ef7d33eeefb767620c28dbb77a38995","unresolved":false,"context_lines":[{"line_number":44,"context_line":"In a new API microversion return the embedded image properties in the"},{"line_number":45,"context_line":"``GET /server/details`` and ``/server/{server_id}`` responses."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The implementation needs to copy each key value pairs form"},{"line_number":48,"context_line":"``instance.system_metadata`` to the response where the key is prefixed with"},{"line_number":49,"context_line":"``image_``."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"c08ebf91_d1cb4a7d","line":47,"range":{"start_line":47,"start_character":54,"end_line":47,"end_character":58},"in_reply_to":"4391e5c5_cf0b81a0","updated":"2025-01-10 17:00:16.000000000","message":"Done","commit_id":"7e3ef9b6a3e12ef3732835043c9cdb788b1a8bfa"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6452c793ff5f7189c5cdf40b5e0aac504e181908","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The implementation needs to copy each key value pairs form"},{"line_number":48,"context_line":"``instance.system_metadata`` to the response where the key is prefixed with"},{"line_number":49,"context_line":"``image_``."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Alternatives"},{"line_number":52,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"aa89a56b_d8048b79","line":49,"updated":"2025-01-10 16:46:09.000000000","message":"I think this is referring to the fact that we namespace these in sysmeta with `image_`. It\u0027s clear below since you don\u0027t have them similarly namespaced in the api response (of course) but I think this is confusing. Personally, I would just remove all of this and say \"populate the part of the api response from our cache of the image details\" or something and not get too detailed about how and from where it comes.","commit_id":"7e3ef9b6a3e12ef3732835043c9cdb788b1a8bfa"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b8ee29fb6ef7d33eeefb767620c28dbb77a38995","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The implementation needs to copy each key value pairs form"},{"line_number":48,"context_line":"``instance.system_metadata`` to the response where the key is prefixed with"},{"line_number":49,"context_line":"``image_``."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Alternatives"},{"line_number":52,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"34454f41_895ab271","line":49,"in_reply_to":"aa89a56b_d8048b79","updated":"2025-01-10 17:00:16.000000000","message":"Done","commit_id":"7e3ef9b6a3e12ef3732835043c9cdb788b1a8bfa"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"32218ac7c5c3ee7290916c77d496bbf850664fb6","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The implementation needs to copy each key value pairs form"},{"line_number":48,"context_line":"``instance.system_metadata`` to the response where the key is prefixed with"},{"line_number":49,"context_line":"``image_``."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Alternatives"},{"line_number":52,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"427a927b_6572cca1","line":49,"in_reply_to":"aa89a56b_d8048b79","updated":"2025-01-10 19:40:41.000000000","message":"Yes. Done.","commit_id":"7e3ef9b6a3e12ef3732835043c9cdb788b1a8bfa"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"30cd5464d54f5094ad1a9f7ba3ff11b26c2f8a4b","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Image properties in server show"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/image-properties-in-server-show"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes to show an instance\u0027s embedded image properties in the"},{"line_number":14,"context_line":"server show API. This has lots of uses, but is particularly required for `vTPM"}],"source_content_type":"text/x-rst","patch_set":3,"id":"0a098d15_7b9c4f67","line":11,"updated":"2025-01-10 21:43:43.000000000","message":"I note that this link is currently broken, either a typo or the blueprint has not been created yet.","commit_id":"99be7f9b68fce70af3bf978cbd886d479029f3f5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dcf44dc8d9b879a96325137d2e67acdf69aa6c80","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Image properties in server show"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/nova/+spec/image-properties-in-server-show"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This spec proposes to show an instance\u0027s embedded image properties in the"},{"line_number":14,"context_line":"server show API. This has lots of uses, but is particularly required for `vTPM"}],"source_content_type":"text/x-rst","patch_set":3,"id":"16b907c0_f39a79d7","line":11,"in_reply_to":"0a098d15_7b9c4f67","updated":"2025-01-13 08:33:04.000000000","message":"I\u0027v registered the BP now.","commit_id":"99be7f9b68fce70af3bf978cbd886d479029f3f5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e92a687bb828f2fc79709f2a5965d7dc6912d6a3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  to such security change. See `vTPM live migration \u003chttps://review.opendev.org/c/openstack/nova-specs/+/936775\u003e`_."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* I as the owner of the VM want to detect if the admin needed to change"},{"line_number":42,"context_line":"  any image properties in my behalf via ``nova-mange image_property set``."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Proposed change"},{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ceba739_6cfb4454","line":42,"updated":"2025-01-10 22:04:22.000000000","message":"other use cases include\n\nas a developer of an external optimisation service (watcher), I may want to be able to inspect the image properties associated with an instance to inform what policies I should implement when selecting a host.\n\nas a support contact debugging a customer issue iw would like to be able to inspect the image properties without needing to retrieve them directly from the db.\n\nwe don\u0027t need to add either of these but those are some of the other use cases that come to mind.\n\nit\u0027s rare that when I have debugged a customer issue the issue was caused by an image property and the embedded ones were different than the one currently in a glance but it has happened at least 5 or 6 times that I personally recall and having this makes it simpler to debug.","commit_id":"7bbf54e6bf6298c97cc4cf6e524e86ccb2ba7050"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e92a687bb828f2fc79709f2a5965d7dc6912d6a3","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    ..."},{"line_number":102,"context_line":"        }"},{"line_number":103,"context_line":"      ]"},{"line_number":104,"context_line":"    }"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Security impact"},{"line_number":107,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"4236f1bf_67117a2c","line":104,"updated":"2025-01-10 22:04:22.000000000","message":"as an aside, (we don\u0027t need to update the spec with this), the way the image works with BFV is kind of weird so if we can during the implementation i would like these image properties to be shown when using the new micro version consistently.\n\ni.e. if we can provide this for BFV or non-BFV instances we should try.\n\nI believe they are always stored in the instance system metadata table regardless of how we boot so that should just work but just wanted to call this out.","commit_id":"7bbf54e6bf6298c97cc4cf6e524e86ccb2ba7050"}]}