)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2394a74651b6e57ba53f7d8cd979901e3767ef2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"579c4b4d_8ef355f7","updated":"2025-01-31 12:18:28.000000000","message":"Open question: do we want to add this filter to anything else? Currently only the os-hypervisor API supports filtering by name. Perhaps we should do every non-deprecated API while we\u0027re at it?","commit_id":"825f1b68a31da7cc9df8dfe65bf6884e462bf50b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"15ea1f122687f2de45280cc121ee7512850ddb02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0e8b11da_ddb7453a","in_reply_to":"07b0998b_9feadc4a","updated":"2025-04-15 11:13:00.000000000","message":"Updated the spec to reference this.","commit_id":"825f1b68a31da7cc9df8dfe65bf6884e462bf50b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a925f449b2747dc90635ae4b1ec3eaa0331a80ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"07b0998b_9feadc4a","in_reply_to":"579c4b4d_8ef355f7","updated":"2025-04-15 11:04:54.000000000","message":"This isn\u0027t actually true. The `/servers` API also supports this. The `/os-hypervisors` API is actually unique in that it uses the `LIKE` syntax.","commit_id":"825f1b68a31da7cc9df8dfe65bf6884e462bf50b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8eb4b1747f07c55165b85c6213e722478aba33c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cbf58420_3e7dd69c","updated":"2025-04-15 11:59:33.000000000","message":"some minor nits on testing but over all i think this makes logical sense.","commit_id":"0ffd37d85ef3d5924cf03d3d93f39cdc13f4da32"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"480ce8afa808c7fd94332bc9e53e8f48fed4a2c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ae74ec15_1f5c237b","updated":"2025-05-14 09:39:48.000000000","message":"Hi Stephen,\nCould you please create the associated BP and add it in the commit msg.","commit_id":"79b7e76ca17f5bdd94b8706522f55c1fb998098f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5fac094e1c31be3cb5eda97c74022813fc2bfa67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3a8fb519_1e81d8b8","updated":"2025-05-29 16:05:14.000000000","message":"im still ok with this proposal as is so readding +2","commit_id":"012cc198c64e5a60b71cd3da55748701d2d24747"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"89fb46230b99405157f0948e3546539d49579598","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b7afc204_a520cdab","updated":"2025-05-29 20:07:11.000000000","message":"proposal lgtm to me but I will say let\u0027s disable additionalProperties for all new query schema (similar to 2.75 microversion) (-1 for that only). \n\n- https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id68","commit_id":"012cc198c64e5a60b71cd3da55748701d2d24747"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"41157639c7646fa028ebe91fbb2ce2f12c422fb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9d57f2b7_9ad57f6e","updated":"2025-06-09 16:57:53.000000000","message":"waiting for additionalProperties updates otherwise this looks good to me.","commit_id":"012cc198c64e5a60b71cd3da55748701d2d24747"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c0d785044f542969822a592ed75e8379117a3c73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ecd924ac_8256e7c8","updated":"2025-06-17 18:40:20.000000000","message":"I am fine with current version. I am waiting for other DB points to be discussed before +2.","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f7bd409096bd8952ed0154818b8e05e66cb0e5d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"63f60402_edbadc1e","updated":"2025-06-17 14:37:07.000000000","message":"i think most of the nits have been adressed. i was ok with it before so restoring my +2","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"dceedeec9d146fc759520f5567171bcccbbeea95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4ebec4df_82c3f90a","updated":"2025-06-17 16:03:56.000000000","message":"just a few open questions","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"172987574f82629efbdc31e2eed2373bf6d57a9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d8811f61_0c9cbdd8","updated":"2025-06-17 18:03:59.000000000","message":"sylvain has some question so dropign to +1 while those are discussed.","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fbbba16d19d5bf025bcc50e1f87f63070bb12857","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5720e4de_03d5f449","updated":"2025-06-20 18:07:10.000000000","message":"lgtm, leaving +W to Slyvain to check reply/update for this comment about DB/performance.","commit_id":"33cbcb66184235f778b266a398a5b3d4e09191e6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"07a5cd46d8d42ca8fd7eb41c95df2056cde78d0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f0871ebb_edcee833","updated":"2025-07-02 12:16:14.000000000","message":"we normlaly only hold patches for 2-3 days for a core to review.\n\n@sbauza@redhat.com has now had 11 days. if there are no objects before i finish today im going to add +w as i htink there has been ample time to review.","commit_id":"33cbcb66184235f778b266a398a5b3d4e09191e6"}],"specs/2025.2/approved/flavor-search-by-name.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b6426738ea82c05cac9da644c83797a55f57af15","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Modify the ``GET /flavors`` API to add support for a new ``name`` query string"},{"line_number":34,"context_line":"filter parameter. This will be implemented using ``LIKE`` at the DB layer,"},{"line_number":35,"context_line":"allowing for partial name matches."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"828312a0_923a6a50","line":35,"updated":"2025-04-14 10:54:26.000000000","message":"this perhaps the only part i wonder about.\n\nthis is fine and will work.\nthe other option whouls be to use the fact that sqlachemy support python regex format and can translate to the db specific format.\n\nare you sure a simple substring match is what you want or do you want to start with regex supprot.","commit_id":"825f1b68a31da7cc9df8dfe65bf6884e462bf50b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"70a91e19ce45ce6adc9548528ff74e3a2bbc736c","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Modify the ``GET /flavors`` API to add support for a new ``name`` query string"},{"line_number":34,"context_line":"filter parameter. This will be implemented using ``LIKE`` at the DB layer,"},{"line_number":35,"context_line":"allowing for partial name matches."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"793d43cc_a8da43dd","line":35,"in_reply_to":"1c42e926_e43dd24d","updated":"2025-04-15 11:50:17.000000000","message":"Done","commit_id":"825f1b68a31da7cc9df8dfe65bf6884e462bf50b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e883274994149f4d63efd99d889e251a8a3a4d4b","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Modify the ``GET /flavors`` API to add support for a new ``name`` query string"},{"line_number":34,"context_line":"filter parameter. This will be implemented using ``LIKE`` at the DB layer,"},{"line_number":35,"context_line":"allowing for partial name matches."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b5d6d1fb_037135b0","line":35,"in_reply_to":"828312a0_923a6a50","updated":"2025-04-15 10:32:11.000000000","message":"It\u0027s a good point. My plan was not expose any of this. Characters would be escaped and the `LIKE` syntax would be done internally (i.e. `%{escaped version of what the user gave us}%`). However, looking at the api-ref, I see a number of places where we use regexes, such as [the `name` filter for `GET /servers`](https://docs.openstack.org/api-ref/compute/#list-servers). It would be best to be consistent here. Let me respin.","commit_id":"825f1b68a31da7cc9df8dfe65bf6884e462bf50b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a925f449b2747dc90635ae4b1ec3eaa0331a80ec","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Modify the ``GET /flavors`` API to add support for a new ``name`` query string"},{"line_number":34,"context_line":"filter parameter. This will be implemented using ``LIKE`` at the DB layer,"},{"line_number":35,"context_line":"allowing for partial name matches."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"448f90a7_6f994180","line":35,"in_reply_to":"b5d6d1fb_037135b0","updated":"2025-04-15 11:04:54.000000000","message":"Done","commit_id":"825f1b68a31da7cc9df8dfe65bf6884e462bf50b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1f3581b3bfbbded93c8aabc6d99a782c8a0ffec9","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Modify the ``GET /flavors`` API to add support for a new ``name`` query string"},{"line_number":34,"context_line":"filter parameter. This will be implemented using ``LIKE`` at the DB layer,"},{"line_number":35,"context_line":"allowing for partial name matches."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1c42e926_e43dd24d","line":35,"in_reply_to":"b5d6d1fb_037135b0","updated":"2025-04-15 11:11:44.000000000","message":"well before you do.\n\nThe existing places require you to use the regxes in the database\u0027s native format\nAs a api user you need to know which database is being used.\nNow yes its almost always going to be Mariadb or Mysql\nbut thats something to consider or at least document\n\nhttps://docs.sqlalchemy.org/en/20/core/sqlelement.html#sqlalchemy.sql.expression.ColumnOperators.regexp_match\n\nso +1 for consitency. its unfortunetly exsting tech debt but at least you would not be making it worse","commit_id":"825f1b68a31da7cc9df8dfe65bf6884e462bf50b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8eb4b1747f07c55165b85c6213e722478aba33c7","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    \u003e\u003e\u003e"},{"line_number":51,"context_line":"    \u003e\u003e\u003e [f[\u0027name\u0027] for f in conn.compute.get(r\u0027/flavors?name\u003d^m1\u0027).json()[\u0027flavors\u0027]]"},{"line_number":52,"context_line":"    [\u0027m1.small\u0027, \u0027m1.medium\u0027]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"While we are introducing a new microversion, we will also take the opportunity"},{"line_number":55,"context_line":"to address some other tech debt with the schema:"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa4afd50_3d9ef269","line":53,"updated":"2025-04-15 11:59:33.000000000","message":"+1 nice examples","commit_id":"0ffd37d85ef3d5924cf03d3d93f39cdc13f4da32"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f7bd409096bd8952ed0154818b8e05e66cb0e5d6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \u003e\u003e\u003e"},{"line_number":51,"context_line":"    \u003e\u003e\u003e [f[\u0027name\u0027] for f in conn.compute.get(r\u0027/flavors?name\u003d^m1\u0027).json()[\u0027flavors\u0027]]"},{"line_number":52,"context_line":"    [\u0027m1.small\u0027, \u0027m1.medium\u0027]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"While we are introducing a new microversion, we will also take the opportunity"},{"line_number":55,"context_line":"to address some other tech debt with the schema:"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"66047f22_afeac462","line":53,"in_reply_to":"fa4afd50_3d9ef269","updated":"2025-06-17 14:37:07.000000000","message":"Acknowledged","commit_id":"0ffd37d85ef3d5924cf03d3d93f39cdc13f4da32"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8eb4b1747f07c55165b85c6213e722478aba33c7","unresolved":true,"context_lines":[{"line_number":62,"context_line":"  from the list of valid sort keys for the flavor list (``GET /flavors``) and"},{"line_number":63,"context_line":"  flavor list with details (``GET /flavors/detail``) APIs. This field was only"},{"line_number":64,"context_line":"  supported by the long since removed XenAPI driver and is a no-op in modern"},{"line_number":65,"context_line":"  Nova."},{"line_number":66,"context_line":"- We will remove the ``OS-FLV-DISABLED:disabled`` field from the flavor list"},{"line_number":67,"context_line":"  with details (``GET /flavors/detail``) and flavor show (``GET"},{"line_number":68,"context_line":"  /flavors/{flavor_id}``) APIs. There has never been a way to set this field,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"85274797_5a957b23","line":65,"updated":"2025-04-15 11:59:33.000000000","message":"these both make sense","commit_id":"0ffd37d85ef3d5924cf03d3d93f39cdc13f4da32"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f7bd409096bd8952ed0154818b8e05e66cb0e5d6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  from the list of valid sort keys for the flavor list (``GET /flavors``) and"},{"line_number":63,"context_line":"  flavor list with details (``GET /flavors/detail``) APIs. This field was only"},{"line_number":64,"context_line":"  supported by the long since removed XenAPI driver and is a no-op in modern"},{"line_number":65,"context_line":"  Nova."},{"line_number":66,"context_line":"- We will remove the ``OS-FLV-DISABLED:disabled`` field from the flavor list"},{"line_number":67,"context_line":"  with details (``GET /flavors/detail``) and flavor show (``GET"},{"line_number":68,"context_line":"  /flavors/{flavor_id}``) APIs. There has never been a way to set this field,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"2a3b0a6d_126a8bd3","line":65,"in_reply_to":"85274797_5a957b23","updated":"2025-06-17 14:37:07.000000000","message":"Acknowledged","commit_id":"0ffd37d85ef3d5924cf03d3d93f39cdc13f4da32"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8eb4b1747f07c55165b85c6213e722478aba33c7","unresolved":true,"context_lines":[{"line_number":66,"context_line":"- We will remove the ``OS-FLV-DISABLED:disabled`` field from the flavor list"},{"line_number":67,"context_line":"  with details (``GET /flavors/detail``) and flavor show (``GET"},{"line_number":68,"context_line":"  /flavors/{flavor_id}``) APIs. There has never been a way to set this field,"},{"line_number":69,"context_line":"  making it a no-op."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Alternatives"},{"line_number":72,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fc6c19ae_da7520a2","line":69,"updated":"2025-04-15 11:59:33.000000000","message":"This makes logical sense, the only reason i hesitate is we did dicussion teh idea of disabling flavors when you can nolonger creeate isntance of them using some external mechanisum\n\nim personally ok with removing disabeld for now\n\nand if we every supprot disabling for real we can add it and the disabeld reason filed in a future microversion\n\nbut we shoudl see how others feel.","commit_id":"0ffd37d85ef3d5924cf03d3d93f39cdc13f4da32"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"41157639c7646fa028ebe91fbb2ce2f12c422fb1","unresolved":true,"context_lines":[{"line_number":66,"context_line":"- We will remove the ``OS-FLV-DISABLED:disabled`` field from the flavor list"},{"line_number":67,"context_line":"  with details (``GET /flavors/detail``) and flavor show (``GET"},{"line_number":68,"context_line":"  /flavors/{flavor_id}``) APIs. There has never been a way to set this field,"},{"line_number":69,"context_line":"  making it a no-op."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Alternatives"},{"line_number":72,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba820ffb_4be77953","line":69,"in_reply_to":"8340ca5c_eaaeae13","updated":"2025-06-09 16:57:53.000000000","message":"I also did not find any reported request for this but Sean might know better. Anyways, I agree not to keep it in the assumption of future/operator need. I am ok to remove it.\n\nIt did not provide any value (notset) so there is no current user of it. If needed in future then it will be a chance to add it without **OS-FLV-DISABLED** and along with disable-reason field.","commit_id":"0ffd37d85ef3d5924cf03d3d93f39cdc13f4da32"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f7bd409096bd8952ed0154818b8e05e66cb0e5d6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"- We will remove the ``OS-FLV-DISABLED:disabled`` field from the flavor list"},{"line_number":67,"context_line":"  with details (``GET /flavors/detail``) and flavor show (``GET"},{"line_number":68,"context_line":"  /flavors/{flavor_id}``) APIs. There has never been a way to set this field,"},{"line_number":69,"context_line":"  making it a no-op."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Alternatives"},{"line_number":72,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"63996770_9551236e","line":69,"in_reply_to":"ba820ffb_4be77953","updated":"2025-06-17 14:37:07.000000000","message":"so i am aware of a usecase for this.but honestly i would prefer to remove OS-FLV-DISABLED \n\nand if we want to have a disabled value actually add a new one called `disabled` not `OS-FLV-DISABLED:disabled` with an optional `disabled_reason` in the relevant microversions that will use it.\n\ni do not really really like keeping field that dont do anything that we _might_ use someday espically when we likely would reame it anyway.","commit_id":"0ffd37d85ef3d5924cf03d3d93f39cdc13f4da32"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b9d323b555c48e23e0f12c2320af0657a33089aa","unresolved":true,"context_lines":[{"line_number":66,"context_line":"- We will remove the ``OS-FLV-DISABLED:disabled`` field from the flavor list"},{"line_number":67,"context_line":"  with details (``GET /flavors/detail``) and flavor show (``GET"},{"line_number":68,"context_line":"  /flavors/{flavor_id}``) APIs. There has never been a way to set this field,"},{"line_number":69,"context_line":"  making it a no-op."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Alternatives"},{"line_number":72,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"8340ca5c_eaaeae13","line":69,"in_reply_to":"e3886173_3c4297b9","updated":"2025-06-05 21:16:37.000000000","message":"@gmaan@ghanshyammann.com @smooney@redhat.com What about this?","commit_id":"0ffd37d85ef3d5924cf03d3d93f39cdc13f4da32"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7eb9180d36762e5521960e39ceca843ab7e1ac04","unresolved":false,"context_lines":[{"line_number":66,"context_line":"- We will remove the ``OS-FLV-DISABLED:disabled`` field from the flavor list"},{"line_number":67,"context_line":"  with details (``GET /flavors/detail``) and flavor show (``GET"},{"line_number":68,"context_line":"  /flavors/{flavor_id}``) APIs. There has never been a way to set this field,"},{"line_number":69,"context_line":"  making it a no-op."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Alternatives"},{"line_number":72,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"e3886173_3c4297b9","line":69,"in_reply_to":"ef61594b_a0f26642","updated":"2025-06-05 13:16:33.000000000","message":"Not that I\u0027m aware of. I don\u0027t see the point in keeping a useless field around on the off-chance we might change that in a future microversion (since we can re-add the field in that future microversion). I would therefore personally prefer to either (a) fix the feature disable feature or (b) remove the flag. I don\u0027t know if we want to do this in the same effort, particularly if there\u0027s no operator ask for this? Thoughts?","commit_id":"0ffd37d85ef3d5924cf03d3d93f39cdc13f4da32"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"89fb46230b99405157f0948e3546539d49579598","unresolved":true,"context_lines":[{"line_number":66,"context_line":"- We will remove the ``OS-FLV-DISABLED:disabled`` field from the flavor list"},{"line_number":67,"context_line":"  with details (``GET /flavors/detail``) and flavor show (``GET"},{"line_number":68,"context_line":"  /flavors/{flavor_id}``) APIs. There has never been a way to set this field,"},{"line_number":69,"context_line":"  making it a no-op."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Alternatives"},{"line_number":72,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ef61594b_a0f26642","line":69,"in_reply_to":"fc6c19ae_da7520a2","updated":"2025-05-29 20:07:11.000000000","message":"I think, if there is plan to add the flavor disable ability then we should not remove it. it will be duplicate work to remove and re-add this field specially field in flavor objects/doc etc.\n\nDo we have any ref/discussion/proposal about flavor disable ability?","commit_id":"0ffd37d85ef3d5924cf03d3d93f39cdc13f4da32"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8eb4b1747f07c55165b85c6213e722478aba33c7","unresolved":true,"context_lines":[{"line_number":172,"context_line":"Testing"},{"line_number":173,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Unit tests."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Documentation Impact"},{"line_number":178,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"486adbbd_2d26f58e","line":175,"updated":"2025-04-15 11:59:33.000000000","message":"It would be good to have a tempest test for this also\n+ The tempest schema changes at a minimum since you are removing several fields from the responses.\n\ni agree that most of this can be covered by unit tests and api sample tests but it wold be good to do at leat the schema change on the tempest side.","commit_id":"0ffd37d85ef3d5924cf03d3d93f39cdc13f4da32"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"dceedeec9d146fc759520f5567171bcccbbeea95","unresolved":true,"context_lines":[{"line_number":172,"context_line":"Testing"},{"line_number":173,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Unit tests."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Documentation Impact"},{"line_number":178,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7b81fb8a_4c56fe9c","line":175,"in_reply_to":"1432bdb7_9b317234","updated":"2025-06-17 16:03:56.000000000","message":"yeah, agreed","commit_id":"0ffd37d85ef3d5924cf03d3d93f39cdc13f4da32"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"89fb46230b99405157f0948e3546539d49579598","unresolved":true,"context_lines":[{"line_number":172,"context_line":"Testing"},{"line_number":173,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Unit tests."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Documentation Impact"},{"line_number":178,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1432bdb7_9b317234","line":175,"in_reply_to":"486adbbd_2d26f58e","updated":"2025-05-29 20:07:11.000000000","message":"++. let\u0027s add tempest schema/test also.","commit_id":"0ffd37d85ef3d5924cf03d3d93f39cdc13f4da32"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ed6d5d317e83d0ac6db1817b7dd2a763fa447b95","unresolved":false,"context_lines":[{"line_number":172,"context_line":"Testing"},{"line_number":173,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Unit tests."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Documentation Impact"},{"line_number":178,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"85e4aabc_514c8c16","line":175,"in_reply_to":"7b81fb8a_4c56fe9c","updated":"2025-06-20 13:57:16.000000000","message":"Done","commit_id":"0ffd37d85ef3d5924cf03d3d93f39cdc13f4da32"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"89fb46230b99405157f0948e3546539d49579598","unresolved":true,"context_lines":[{"line_number":54,"context_line":"While we are introducing a new microversion, we will also take the opportunity"},{"line_number":55,"context_line":"to address some other tech debt with the schema:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- We will set ``additionalProperties`` to ``False`` for the flavor show (``GET"},{"line_number":58,"context_line":"  /flavors/{flavor_id}``) API"},{"line_number":59,"context_line":"- We will remove the ``rxtx_factor`` field from the flavor create (``POST"},{"line_number":60,"context_line":"  /flavors``), flavor list with details (``GET /flavors/detail``) and flavor"},{"line_number":61,"context_line":"  show (``GET /flavors/{flavor_id}``) APIs. We will also remove ``rxtx_factor``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"01e97b6a_8ec05cc7","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":29},"updated":"2025-05-29 20:07:11.000000000","message":"As you know we have additionalProperties True for many new new query schemas, I will suggest to update all those schema (not just flavor) to disable additionalProperties. For example, we have done similar same changes for multiple APIs in 2.75 microversion\n\n- https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id68","commit_id":"012cc198c64e5a60b71cd3da55748701d2d24747"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7eb9180d36762e5521960e39ceca843ab7e1ac04","unresolved":true,"context_lines":[{"line_number":54,"context_line":"While we are introducing a new microversion, we will also take the opportunity"},{"line_number":55,"context_line":"to address some other tech debt with the schema:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- We will set ``additionalProperties`` to ``False`` for the flavor show (``GET"},{"line_number":58,"context_line":"  /flavors/{flavor_id}``) API"},{"line_number":59,"context_line":"- We will remove the ``rxtx_factor`` field from the flavor create (``POST"},{"line_number":60,"context_line":"  /flavors``), flavor list with details (``GET /flavors/detail``) and flavor"},{"line_number":61,"context_line":"  show (``GET /flavors/{flavor_id}``) APIs. We will also remove ``rxtx_factor``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"d8614073_e209d530","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":29},"in_reply_to":"01e97b6a_8ec05cc7","updated":"2025-06-05 13:16:33.000000000","message":"I contemplated that, but I thought it was a little *too* broad. If you\u0027re happy to review this, I\u0027m happy to do it.","commit_id":"012cc198c64e5a60b71cd3da55748701d2d24747"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f7bd409096bd8952ed0154818b8e05e66cb0e5d6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"While we are introducing a new microversion, we will also take the opportunity"},{"line_number":55,"context_line":"to address some other tech debt with the schema:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- We will set ``additionalProperties`` to ``False`` for the flavor show (``GET"},{"line_number":58,"context_line":"  /flavors/{flavor_id}``) API"},{"line_number":59,"context_line":"- We will remove the ``rxtx_factor`` field from the flavor create (``POST"},{"line_number":60,"context_line":"  /flavors``), flavor list with details (``GET /flavors/detail``) and flavor"},{"line_number":61,"context_line":"  show (``GET /flavors/{flavor_id}``) APIs. We will also remove ``rxtx_factor``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"fee083e4_158f4ff5","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":29},"in_reply_to":"90f35fb7_0c48a913","updated":"2025-06-17 14:37:07.000000000","message":"Done","commit_id":"012cc198c64e5a60b71cd3da55748701d2d24747"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"36b8228a08129d7f15c31783770458be4d4e6e4c","unresolved":true,"context_lines":[{"line_number":54,"context_line":"While we are introducing a new microversion, we will also take the opportunity"},{"line_number":55,"context_line":"to address some other tech debt with the schema:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- We will set ``additionalProperties`` to ``False`` for the flavor show (``GET"},{"line_number":58,"context_line":"  /flavors/{flavor_id}``) API"},{"line_number":59,"context_line":"- We will remove the ``rxtx_factor`` field from the flavor create (``POST"},{"line_number":60,"context_line":"  /flavors``), flavor list with details (``GET /flavors/detail``) and flavor"},{"line_number":61,"context_line":"  show (``GET /flavors/{flavor_id}``) APIs. We will also remove ``rxtx_factor``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"90f35fb7_0c48a913","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":29},"in_reply_to":"b235d66d_a42e3508","updated":"2025-06-05 17:45:14.000000000","message":"sure, I will be happy to cover those in review.","commit_id":"012cc198c64e5a60b71cd3da55748701d2d24747"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2d74cb61179dc99793b412466d29e9ca55c0563","unresolved":true,"context_lines":[{"line_number":54,"context_line":"While we are introducing a new microversion, we will also take the opportunity"},{"line_number":55,"context_line":"to address some other tech debt with the schema:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- We will set ``additionalProperties`` to ``False`` for the flavor show (``GET"},{"line_number":58,"context_line":"  /flavors/{flavor_id}``) API"},{"line_number":59,"context_line":"- We will remove the ``rxtx_factor`` field from the flavor create (``POST"},{"line_number":60,"context_line":"  /flavors``), flavor list with details (``GET /flavors/detail``) and flavor"},{"line_number":61,"context_line":"  show (``GET /flavors/{flavor_id}``) APIs. We will also remove ``rxtx_factor``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"b235d66d_a42e3508","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":29},"in_reply_to":"d8614073_e209d530","updated":"2025-06-05 17:32:06.000000000","message":"if fine either way so if we want to take this opertunity to do that then sure\nwhy not.","commit_id":"012cc198c64e5a60b71cd3da55748701d2d24747"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"dceedeec9d146fc759520f5567171bcccbbeea95","unresolved":false,"context_lines":[{"line_number":55,"context_line":"to address some other tech debt with the schema:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- We will set ``additionalProperties`` to ``False`` for the flavor show (``GET"},{"line_number":58,"context_line":"  /flavors/{flavor_id}``) API"},{"line_number":59,"context_line":"- We will remove the ``rxtx_factor`` field from the flavor create (``POST"},{"line_number":60,"context_line":"  /flavors``), flavor list with details (``GET /flavors/detail``) and flavor"},{"line_number":61,"context_line":"  show (``GET /flavors/{flavor_id}``) APIs. We will also remove ``rxtx_factor``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"293baa18_b38b5a0e","line":58,"updated":"2025-06-17 16:03:56.000000000","message":"agreed","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"91d65385426b3f83f56c62b5ed4fb26f66d11877","unresolved":true,"context_lines":[{"line_number":55,"context_line":"to address some other tech debt with the schema:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- We will set ``additionalProperties`` to ``False`` for the flavor show (``GET"},{"line_number":58,"context_line":"  /flavors/{flavor_id}``) API"},{"line_number":59,"context_line":"- We will remove the ``rxtx_factor`` field from the flavor create (``POST"},{"line_number":60,"context_line":"  /flavors``), flavor list with details (``GET /flavors/detail``) and flavor"},{"line_number":61,"context_line":"  show (``GET /flavors/{flavor_id}``) APIs. We will also remove ``rxtx_factor``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7df287da_f3900331","line":58,"in_reply_to":"293baa18_b38b5a0e","updated":"2025-06-20 10:19:39.000000000","message":"Is additionalPropoerties True there to support extra_specs?","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c5f981a030d3d438505b202135f05646fcce080","unresolved":true,"context_lines":[{"line_number":55,"context_line":"to address some other tech debt with the schema:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- We will set ``additionalProperties`` to ``False`` for the flavor show (``GET"},{"line_number":58,"context_line":"  /flavors/{flavor_id}``) API"},{"line_number":59,"context_line":"- We will remove the ``rxtx_factor`` field from the flavor create (``POST"},{"line_number":60,"context_line":"  /flavors``), flavor list with details (``GET /flavors/detail``) and flavor"},{"line_number":61,"context_line":"  show (``GET /flavors/{flavor_id}``) APIs. We will also remove ``rxtx_factor``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"8c749288_e03c0d2c","line":58,"in_reply_to":"7df287da_f3900331","updated":"2025-06-20 11:33:47.000000000","message":"noe extra specs are in a subfiled of the flavor called extra_specs\n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/flavors.py#L226-L232\n\nadditional properties true is just legacy.\n\nit may have orgianlly been there form when we breifly had extentiosn in v3 but i suspect this was more of a transitionaly artifact form creating the schemas initially and not actually intentionally in that regard.","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ed6d5d317e83d0ac6db1817b7dd2a763fa447b95","unresolved":false,"context_lines":[{"line_number":55,"context_line":"to address some other tech debt with the schema:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- We will set ``additionalProperties`` to ``False`` for the flavor show (``GET"},{"line_number":58,"context_line":"  /flavors/{flavor_id}``) API"},{"line_number":59,"context_line":"- We will remove the ``rxtx_factor`` field from the flavor create (``POST"},{"line_number":60,"context_line":"  /flavors``), flavor list with details (``GET /flavors/detail``) and flavor"},{"line_number":61,"context_line":"  show (``GET /flavors/{flavor_id}``) APIs. We will also remove ``rxtx_factor``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"90d25ead_1562ed2b","line":58,"in_reply_to":"8c749288_e03c0d2c","updated":"2025-06-20 13:57:16.000000000","message":"Yeah, this was missed in many places. I think we just didn\u0027t know any better at the time 😄","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"dceedeec9d146fc759520f5567171bcccbbeea95","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  from the list of valid sort keys for the flavor list (``GET /flavors``) and"},{"line_number":63,"context_line":"  flavor list with details (``GET /flavors/detail``) APIs. This field was only"},{"line_number":64,"context_line":"  supported by the long since removed XenAPI driver and is a no-op in modern"},{"line_number":65,"context_line":"  Nova."},{"line_number":66,"context_line":"- We will remove the ``OS-FLV-DISABLED:disabled`` field from the flavor list"},{"line_number":67,"context_line":"  with details (``GET /flavors/detail``) and flavor show (``GET"},{"line_number":68,"context_line":"  /flavors/{flavor_id}``) APIs. There has never been a way to set this field,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"aec96e4f_a1d29985","line":65,"updated":"2025-06-17 16:03:56.000000000","message":"agreed","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"dceedeec9d146fc759520f5567171bcccbbeea95","unresolved":false,"context_lines":[{"line_number":66,"context_line":"- We will remove the ``OS-FLV-DISABLED:disabled`` field from the flavor list"},{"line_number":67,"context_line":"  with details (``GET /flavors/detail``) and flavor show (``GET"},{"line_number":68,"context_line":"  /flavors/{flavor_id}``) APIs. There has never been a way to set this field,"},{"line_number":69,"context_line":"  making it a no-op."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Finally, we will build on one of the above items and address some tech debt"},{"line_number":72,"context_line":"with other schemas:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"4d78d623_6f52df54","line":69,"updated":"2025-06-17 16:03:56.000000000","message":"agreed","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"91d65385426b3f83f56c62b5ed4fb26f66d11877","unresolved":true,"context_lines":[{"line_number":66,"context_line":"- We will remove the ``OS-FLV-DISABLED:disabled`` field from the flavor list"},{"line_number":67,"context_line":"  with details (``GET /flavors/detail``) and flavor show (``GET"},{"line_number":68,"context_line":"  /flavors/{flavor_id}``) APIs. There has never been a way to set this field,"},{"line_number":69,"context_line":"  making it a no-op."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Finally, we will build on one of the above items and address some tech debt"},{"line_number":72,"context_line":"with other schemas:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"cef603ab_81814dad","line":69,"in_reply_to":"4d78d623_6f52df54","updated":"2025-06-20 10:19:39.000000000","message":"Hm, there was recent discussion about a feature allow disabling flavors. I\u0027m not sure if that is progressing anywhere but we need to sync before we remove a field that might be added back soonish.","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c5f981a030d3d438505b202135f05646fcce080","unresolved":false,"context_lines":[{"line_number":66,"context_line":"- We will remove the ``OS-FLV-DISABLED:disabled`` field from the flavor list"},{"line_number":67,"context_line":"  with details (``GET /flavors/detail``) and flavor show (``GET"},{"line_number":68,"context_line":"  /flavors/{flavor_id}``) APIs. There has never been a way to set this field,"},{"line_number":69,"context_line":"  making it a no-op."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Finally, we will build on one of the above items and address some tech debt"},{"line_number":72,"context_line":"with other schemas:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ef52aa05_8b14e143","line":69,"in_reply_to":"b94c4cd7_8b089d33","updated":"2025-06-20 11:33:47.000000000","message":"i woudl be more open to keeping this if it was actuly setable in the api but its not. give that will require a new microverion ot ever use this i want to clean up the api scheam. but im fine with not touchign the object/db part so we can avoid any db scema contractions\n\nif we decied ot use this again in the future that will also reduce the work.\n\nin the object and db its actully called disabled\n\nhttps://github.com/openstack/nova/blob/master/nova/db/api/models.py#L243\nhttps://github.com/openstack/nova/blob/master/nova/objects/flavor.py#L218\n\nwhich is what i woudl really want the filed to be in the api as well rather then the old extension name `OS-FLV-DISABLED:disabled``","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c8d925d4df65e48a3b49548c5ac3fd50cb199633","unresolved":false,"context_lines":[{"line_number":66,"context_line":"- We will remove the ``OS-FLV-DISABLED:disabled`` field from the flavor list"},{"line_number":67,"context_line":"  with details (``GET /flavors/detail``) and flavor show (``GET"},{"line_number":68,"context_line":"  /flavors/{flavor_id}``) APIs. There has never been a way to set this field,"},{"line_number":69,"context_line":"  making it a no-op."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Finally, we will build on one of the above items and address some tech debt"},{"line_number":72,"context_line":"with other schemas:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"b94c4cd7_8b089d33","line":69,"in_reply_to":"cef603ab_81814dad","updated":"2025-06-20 11:04:47.000000000","message":"OK Sean and Stephen convinced me to better remove it from the API now and add it back later when we implement it.","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f7bd409096bd8952ed0154818b8e05e66cb0e5d6","unresolved":true,"context_lines":[{"line_number":72,"context_line":"with other schemas:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"- We will set ``additionalProperties`` to ``False`` for all query string"},{"line_number":75,"context_line":"  schemas."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- We will restrict all action bodies to ``null`` values except those where a"},{"line_number":78,"context_line":"  value is actually expected."}],"source_content_type":"text/x-rst","patch_set":7,"id":"b9c3550e_5ec7e5b3","line":75,"updated":"2025-06-17 14:37:07.000000000","message":"this was gmanns main request so i think that is now addresed","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c0d785044f542969822a592ed75e8379117a3c73","unresolved":false,"context_lines":[{"line_number":72,"context_line":"with other schemas:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"- We will set ``additionalProperties`` to ``False`` for all query string"},{"line_number":75,"context_line":"  schemas."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- We will restrict all action bodies to ``null`` values except those where a"},{"line_number":78,"context_line":"  value is actually expected."}],"source_content_type":"text/x-rst","patch_set":7,"id":"e45204a9_60922158","line":75,"in_reply_to":"b9c3550e_5ec7e5b3","updated":"2025-06-17 18:40:20.000000000","message":"Acknowledged","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"dceedeec9d146fc759520f5567171bcccbbeea95","unresolved":true,"context_lines":[{"line_number":75,"context_line":"  schemas."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- We will restrict all action bodies to ``null`` values except those where a"},{"line_number":78,"context_line":"  value is actually expected."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Alternatives"},{"line_number":81,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"d458a88c_bd7b149b","line":78,"updated":"2025-06-17 16:03:56.000000000","message":"that\u0027s debatable but ok","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c0d785044f542969822a592ed75e8379117a3c73","unresolved":false,"context_lines":[{"line_number":74,"context_line":"- We will set ``additionalProperties`` to ``False`` for all query string"},{"line_number":75,"context_line":"  schemas."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- We will restrict all action bodies to ``null`` values except those where a"},{"line_number":78,"context_line":"  value is actually expected."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Alternatives"},{"line_number":81,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"11d54c0d_8a583415","line":78,"range":{"start_line":77,"start_character":0,"end_line":78,"end_character":29},"updated":"2025-06-17 18:40:20.000000000","message":"this is something extra you added :) but as we are doing it in microversion (will not impact existing user with older microverions) and this is not big change, I am ok to cleanup this.","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ed6d5d317e83d0ac6db1817b7dd2a763fa447b95","unresolved":false,"context_lines":[{"line_number":74,"context_line":"- We will set ``additionalProperties`` to ``False`` for all query string"},{"line_number":75,"context_line":"  schemas."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- We will restrict all action bodies to ``null`` values except those where a"},{"line_number":78,"context_line":"  value is actually expected."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Alternatives"},{"line_number":81,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"25628d02_8f947a49","line":78,"range":{"start_line":77,"start_character":0,"end_line":78,"end_character":29},"in_reply_to":"11d54c0d_8a583415","updated":"2025-06-20 13:57:16.000000000","message":"Yeah, I spotted this series of TODOs while working on the `additionalProperties` changes. I think it makes sense to lump it in too.","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ed6d5d317e83d0ac6db1817b7dd2a763fa447b95","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  schemas."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- We will restrict all action bodies to ``null`` values except those where a"},{"line_number":78,"context_line":"  value is actually expected."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Alternatives"},{"line_number":81,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba8ab09b_ff6779c8","line":78,"in_reply_to":"d458a88c_bd7b149b","updated":"2025-06-20 13:57:16.000000000","message":"I think it\u0027s worth doing. At the moment, you can do e.g.:\n\n```\nPOST /servers/{serverID}/action\n\n{\n    \"os-start\": {\"reason\": \"Don\u0027t ask me my business\"}\n}\n```\n\nand it\u0027ll work but the value is ignored. This can be confusing for end-users who might attempt to pass value that are valid for other actions. Silently ignoring stuff is a bad idea.","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"dceedeec9d146fc759520f5567171bcccbbeea95","unresolved":true,"context_lines":[{"line_number":105,"context_line":"Data model impact"},{"line_number":106,"context_line":"-----------------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"None."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"REST API impact"},{"line_number":111,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5fed6b6a_7a90625a","line":108,"updated":"2025-06-17 16:03:56.000000000","message":"fortunately because name is indexed as it\u0027s a UniqueConstraint in SQLA, right?\n\nhttps://github.com/openstack/nova/blob/64ca204c9cf497b0dcfff2d3a24b0dd795a57d1d/nova/db/api/models.py#L231","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"172987574f82629efbdc31e2eed2373bf6d57a9b","unresolved":true,"context_lines":[{"line_number":105,"context_line":"Data model impact"},{"line_number":106,"context_line":"-----------------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"None."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"REST API impact"},{"line_number":111,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"a7d3317b_6b653e36","line":108,"in_reply_to":"5fed6b6a_7a90625a","updated":"2025-06-17 18:03:59.000000000","message":"i general woudl not consider adding an index to be a data model change for what its worth but you could consider it a perfomance impact\n\nthe unique constrati will create an index as a side effect so we are good i think.","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ed6d5d317e83d0ac6db1817b7dd2a763fa447b95","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Data model impact"},{"line_number":106,"context_line":"-----------------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"None."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"REST API impact"},{"line_number":111,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"f900bcc3_bfd83b52","line":108,"in_reply_to":"a7d3317b_6b653e36","updated":"2025-06-20 13:57:16.000000000","message":"Yeah, iirc all of our ID fields and the vast majority of our name fields are indexed, either directly or indirectly (via unique constraints).","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"91d65385426b3f83f56c62b5ed4fb26f66d11877","unresolved":true,"context_lines":[{"line_number":106,"context_line":"-----------------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"None."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"REST API impact"},{"line_number":111,"context_line":"---------------"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"0ea1123c_62abde9c","line":109,"updated":"2025-06-20 10:19:39.000000000","message":"rxtx_factor is a field on the Flavor ovo. I guess this patch is not aiming to remove that ovo field and bump ovo major version. But I want to confirm.","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c5f981a030d3d438505b202135f05646fcce080","unresolved":true,"context_lines":[{"line_number":106,"context_line":"-----------------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"None."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"REST API impact"},{"line_number":111,"context_line":"---------------"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"c5ac367d_600f0ef9","line":109,"in_reply_to":"0ea1123c_62abde9c","updated":"2025-06-20 11:33:47.000000000","message":"well we cant do removals without bumping the major version\n\nwhile we coudl do that i think we shoudl not and just stop accpating it in the create in the new micove version and leave it at its defautl of 1.0\n\nwe can drop the value on serialiastion if you wanted i guess but im not sure it really buy us anythign so i woudl keep this just to the api for now and add a comment to remove the feild when we do a 2.0 of the flavor object.","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ed6d5d317e83d0ac6db1817b7dd2a763fa447b95","unresolved":false,"context_lines":[{"line_number":106,"context_line":"-----------------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"None."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"REST API impact"},{"line_number":111,"context_line":"---------------"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"cfb363fe_382480a3","line":109,"in_reply_to":"c5ac367d_600f0ef9","updated":"2025-06-20 13:57:16.000000000","message":"Yeah, what @smooney@redhat.com said.","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"dceedeec9d146fc759520f5567171bcccbbeea95","unresolved":true,"context_lines":[{"line_number":140,"context_line":"Performance Impact"},{"line_number":141,"context_line":"------------------"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"None."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Other deployer impact"},{"line_number":146,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dfe66033_824ceba0","line":143,"updated":"2025-06-17 16:03:56.000000000","message":"ditto here, we\u0027re fortunate to already index the flavor name","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ed6d5d317e83d0ac6db1817b7dd2a763fa447b95","unresolved":false,"context_lines":[{"line_number":140,"context_line":"Performance Impact"},{"line_number":141,"context_line":"------------------"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"None."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Other deployer impact"},{"line_number":146,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"16fe8e14_20664b6e","line":143,"in_reply_to":"77a6b1de_c12885c4","updated":"2025-06-20 13:57:16.000000000","message":"Done","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"172987574f82629efbdc31e2eed2373bf6d57a9b","unresolved":true,"context_lines":[{"line_number":140,"context_line":"Performance Impact"},{"line_number":141,"context_line":"------------------"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"None."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Other deployer impact"},{"line_number":146,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"77a6b1de_c12885c4","line":143,"in_reply_to":"dfe66033_824ceba0","updated":"2025-06-17 18:03:59.000000000","message":"if we did not have an index you could argure that its a performance impact but currently i think the way this si implated is a flavor list with client side filtering and that shoudl be more expisneve.\n\nbut fiar there can be a perfomance impact to this even if we hope its positive vs today.","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"dceedeec9d146fc759520f5567171bcccbbeea95","unresolved":true,"context_lines":[{"line_number":179,"context_line":"----------"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"* Extend API"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Dependencies"},{"line_number":184,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"f39ac135_9efb41f3","line":182,"updated":"2025-06-17 16:03:56.000000000","message":"could you please explain how you would query the DB ?","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ed6d5d317e83d0ac6db1817b7dd2a763fa447b95","unresolved":false,"context_lines":[{"line_number":179,"context_line":"----------"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"* Extend API"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Dependencies"},{"line_number":184,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"bf515e54_c73367af","line":182,"in_reply_to":"f39ac135_9efb41f3","updated":"2025-06-20 13:57:16.000000000","message":"Done (in the *Proposed Change* section)","commit_id":"32306441c90ae158f2d147dab2cbb30267477266"}]}