)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a0bc594b53ef869536bb21484880a0c1ee6cbb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0c912fbf_afb9558f","updated":"2025-07-24 14:42:17.000000000","message":"some general comment inline but im supprotive of the direction","commit_id":"6402b4045a41547d23a49bc4cfe7552230e41b68"}],"specs/libvirt-parallel-migrate.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a0bc594b53ef869536bb21484880a0c1ee6cbb5","unresolved":true,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"d56759aa_260b6b22","line":1,"updated":"2025-07-24 14:42:17.000000000","message":"this will need to be propesed again the correct release folder when that is created but you already know that :)","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b411acdcd0d6e9263ba4a99680de8855d70ec7b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"d243e46d_abce78de","line":1,"in_reply_to":"d56759aa_260b6b22","updated":"2025-07-25 13:42:03.000000000","message":"Done","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a0bc594b53ef869536bb21484880a0c1ee6cbb5","unresolved":true,"context_lines":[{"line_number":43,"context_line":"* Native libvirt migration, with TLS enabled, 2 connections: ~10 Gbit/s"},{"line_number":44,"context_line":"* Native libvirt migration, without TLS, 2 connections: ~30 Gbit/s"},{"line_number":45,"context_line":"* Native libvirt migration, with TLS enabled, 5 connections: ~20 Gbit/s"},{"line_number":46,"context_line":"* Native libvirt migration, without TLS, 5 connections: ~50 Gbit/s"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Proposed change"},{"line_number":49,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5cfa8ac0_f80b33a6","line":46,"updated":"2025-07-24 14:42:17.000000000","message":"interesting\n\nso not perfect scaling but it pretty linear\n\nwhat is the bandwidth between the source and target host.\n\nare we hitting the line rate of the nics or is this falloff cpu/memory bandwith limited.","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b86eec40bb1235a900f686d2016b1c1d560022ae","unresolved":true,"context_lines":[{"line_number":43,"context_line":"* Native libvirt migration, with TLS enabled, 2 connections: ~10 Gbit/s"},{"line_number":44,"context_line":"* Native libvirt migration, without TLS, 2 connections: ~30 Gbit/s"},{"line_number":45,"context_line":"* Native libvirt migration, with TLS enabled, 5 connections: ~20 Gbit/s"},{"line_number":46,"context_line":"* Native libvirt migration, without TLS, 5 connections: ~50 Gbit/s"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Proposed change"},{"line_number":49,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6b7de3b7_937cd5a8","line":46,"in_reply_to":"5cfa8ac0_f80b33a6","updated":"2025-07-24 14:57:01.000000000","message":"NICs are 100GBits ConnectX 6.\n\nI _think_ we are hitting CPU limit with TLS still. As on 5 connections I do see qemu domain consuming up to 800% of CPU during migration - test VM is 4 cores and 400% utilization comes from stress running on it.\n\nWithout TLS I\u0027m pretty sure we\u0027re hitting the bandwith limit, which by default is 10gbit/s, so we get around 50 as a result of 5 connections.","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a0bc594b53ef869536bb21484880a0c1ee6cbb5","unresolved":true,"context_lines":[{"line_number":52,"context_line":"with default value of `0`."},{"line_number":53,"context_line":"In case value is larger than 0, `VIR_MIGRATE_PARALLEL` is added to migrate flags and"},{"line_number":54,"context_line":"`VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS` is being defined only when the value to the value"},{"line_number":55,"context_line":"of the configuration parameter when it is set to more than 1."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"This preserves current behavior while allowing to fine control the parameter while minimizing"},{"line_number":58,"context_line":"amount of parameters that needs to be introduced."}],"source_content_type":"text/x-rst","patch_set":1,"id":"50a5e3cc_d024bedc","line":55,"updated":"2025-07-24 14:42:17.000000000","message":"ok so 0 is we do not pass the flag at all allowing libvirts default behvior to take effect\n\nadn anything larger will allow the operator to contol this\n\nthat sounds correct to me from an upgrade point of view.\n\nis there a problem with setting VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS when its set to 1?\n\nif not we shoudl besically define that any time we defien VIR_MIGRATE_PARALLEL\n\ni.e. if we can avoid making 1 special we should.\n\nif we wanted to have a case for VIR_MIGRATE_PARALLEL without VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS \nto allow libvirt to choose wwe would model that as -1 or a similar sentenil","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b86eec40bb1235a900f686d2016b1c1d560022ae","unresolved":true,"context_lines":[{"line_number":52,"context_line":"with default value of `0`."},{"line_number":53,"context_line":"In case value is larger than 0, `VIR_MIGRATE_PARALLEL` is added to migrate flags and"},{"line_number":54,"context_line":"`VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS` is being defined only when the value to the value"},{"line_number":55,"context_line":"of the configuration parameter when it is set to more than 1."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"This preserves current behavior while allowing to fine control the parameter while minimizing"},{"line_number":58,"context_line":"amount of parameters that needs to be introduced."}],"source_content_type":"text/x-rst","patch_set":1,"id":"c2708fe5_4e7fa8cc","line":55,"in_reply_to":"50a5e3cc_d024bedc","updated":"2025-07-24 14:57:01.000000000","message":"Frankly - I have not tested this usecase, when `VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS \u003d 1`. As, if only flag is passed, it seemed to use 2 connections \"by default\".\n\nThough I originally thought to default the value to 1 and go from there, until I realized that `VIR_MIGRATE_PARALLEL` does work without `VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS`.\n\nSo it could be that we want to have a minimum of 1 here, as it\u0027s more intuitive from operator perspective and not have this special case indeed?","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b411acdcd0d6e9263ba4a99680de8855d70ec7b7","unresolved":false,"context_lines":[{"line_number":52,"context_line":"with default value of `0`."},{"line_number":53,"context_line":"In case value is larger than 0, `VIR_MIGRATE_PARALLEL` is added to migrate flags and"},{"line_number":54,"context_line":"`VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS` is being defined only when the value to the value"},{"line_number":55,"context_line":"of the configuration parameter when it is set to more than 1."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"This preserves current behavior while allowing to fine control the parameter while minimizing"},{"line_number":58,"context_line":"amount of parameters that needs to be introduced."}],"source_content_type":"text/x-rst","patch_set":1,"id":"f41cf923_6dab716b","line":55,"in_reply_to":"c2708fe5_4e7fa8cc","updated":"2025-07-25 13:42:03.000000000","message":"So I tested this usecase, and you can do that, but have no benefit at all over not enabling it.\n\nThus, I\u0027d rather set default to 1 and then setting more then 1 enable parallel. This sounds like most logical behavior without special cases.","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a0bc594b53ef869536bb21484880a0c1ee6cbb5","unresolved":true,"context_lines":[{"line_number":72,"context_line":"Data model impact"},{"line_number":73,"context_line":"-----------------"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"None"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"REST API impact"},{"line_number":78,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0dc1aff6_e92d9156","line":75,"updated":"2025-07-24 14:42:17.000000000","message":"i guess there is no datamodel impact because this is actully transparent to the reciving nova given it happens at the libvirt level and therefor based on the versions we can simple look at the souce nodes config and dont need to include anything in the migration data object.\n\nin other word we do not need to have a pre live migration check and pass back any data.\n\nwe also dont need ot account for this with mixed comptue service version\n\nyes you will get asymmetric live migration speed depending on if the souce compute has an updated nova but that perfectly acceptable. we just need to document that when documenting the feature.\n\n\nbecause of the versions of libvirt and qemu we also do not need traits to schduler on this and since there is no api change to \"opt into this on a specific live-migration\" there is no need to do other data modeel change or even a compute service verion bump.","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b411acdcd0d6e9263ba4a99680de8855d70ec7b7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Data model impact"},{"line_number":73,"context_line":"-----------------"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"None"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"REST API impact"},{"line_number":78,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c80b29e8_58267dc8","line":75,"in_reply_to":"0dc1aff6_e92d9156","updated":"2025-07-25 13:42:03.000000000","message":"Done","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a0bc594b53ef869536bb21484880a0c1ee6cbb5","unresolved":true,"context_lines":[{"line_number":77,"context_line":"REST API impact"},{"line_number":78,"context_line":"---------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"None"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Security impact"},{"line_number":83,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7216417b_fd4738ca","line":80,"updated":"2025-07-24 14:42:17.000000000","message":"+1\n\ni dont know if there is a usecase to allow setting the number of coonection via the api request but i stongly agree with defering any api changes until there is a dembonstrated need for this. i.e. start with config options only and revisit if operator really really want this at the api.","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b411acdcd0d6e9263ba4a99680de8855d70ec7b7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"REST API impact"},{"line_number":78,"context_line":"---------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"None"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Security impact"},{"line_number":83,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a310167c_1d7b596f","line":80,"in_reply_to":"3be66643_ab946d05","updated":"2025-07-25 13:42:03.000000000","message":"Done","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b86eec40bb1235a900f686d2016b1c1d560022ae","unresolved":true,"context_lines":[{"line_number":77,"context_line":"REST API impact"},{"line_number":78,"context_line":"---------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"None"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Security impact"},{"line_number":83,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3be66643_ab946d05","line":80,"in_reply_to":"7216417b_fd4738ca","updated":"2025-07-24 14:57:01.000000000","message":"I don\u0027t think there is such need, no. Also I don\u0027t think there is a precedence for such parameter to be passed with the request. I\u0027d say that live migration bandwidth is quite similar parameter.","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a0bc594b53ef869536bb21484880a0c1ee6cbb5","unresolved":true,"context_lines":[{"line_number":116,"context_line":"around default value for ``[libvirt]/live_migration_parallel_connections``,"},{"line_number":117,"context_line":"as there might be a correlation with ``reserved_host_cpus`` and/or"},{"line_number":118,"context_line":"``cpu_allocation_ratio``, to ensure out of the box that there is enough"},{"line_number":119,"context_line":"CPU time available to hypervisor, to perform parallel live migration."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Developer impact"},{"line_number":122,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9919b7c2_4e5705bb","line":119,"updated":"2025-07-24 14:42:17.000000000","message":"i think the more impatant factor is actully the number of concurrent migrations\n\nwe have recommend never setting it above 1 unless you can prove a signel live mgiration cant satuate the link used for the migration\n\ni.e. it better to migrate vms serially then in parrallel in general.\n\ni think this make that advice even more ture.\n\nif you can make each migration run fast by haveing multiple connections you shoudl prefer to do that over haveing multiple sepreate live migrations on the same host.\n\n\nin general i dont think deployment tools shoudl have logic to try an caludate the defaults. they will very likely get this wrong. but its valid to say that they shoudl consider the inpact on cpus avaibel to nova to use.\n\nby the way you shoudl perfer using [compute]/cpu_shared_set over reserved_host_cpus\n\neven if you are not usign cpu pinning.\n\ni effectivly treat reserved_host_cpus as a legacy config option that shoudl not be used anymore but it exist purly for backward compatiblity.\n\nthe fact that you have to multiply reserved_host_cpus by the cpu_allocation_ratio to reserve the correct amount of cores alwasy catches people out.\nand that does not work well if you set the vcpu allocation ratio via the placement api instead of via config.","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b411acdcd0d6e9263ba4a99680de8855d70ec7b7","unresolved":true,"context_lines":[{"line_number":116,"context_line":"around default value for ``[libvirt]/live_migration_parallel_connections``,"},{"line_number":117,"context_line":"as there might be a correlation with ``reserved_host_cpus`` and/or"},{"line_number":118,"context_line":"``cpu_allocation_ratio``, to ensure out of the box that there is enough"},{"line_number":119,"context_line":"CPU time available to hypervisor, to perform parallel live migration."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Developer impact"},{"line_number":122,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b45ff2f9_09c74b0b","line":119,"in_reply_to":"9919b7c2_4e5705bb","updated":"2025-07-25 13:42:03.000000000","message":"For me main blocker not to use `cpu_shared_set` is it\u0027s format, as you can only exclude from previously defined range. Because usually what you actually want to do, is `$all - N`.\n\nBut the way `cpu_shared_set` is defined is kinda static/hardcoded on the contrary to `N * cpu_allocation_ratio` which will be kinda static at all times.\n\nFor instance, engineer during compute firmware upgrade decided that from now on will not use hyper threading and disabled it silently in UEFI.","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"653f552e54782f421eebeebf8ff812a274039951","unresolved":false,"context_lines":[{"line_number":116,"context_line":"around default value for ``[libvirt]/live_migration_parallel_connections``,"},{"line_number":117,"context_line":"as there might be a correlation with ``reserved_host_cpus`` and/or"},{"line_number":118,"context_line":"``cpu_allocation_ratio``, to ensure out of the box that there is enough"},{"line_number":119,"context_line":"CPU time available to hypervisor, to perform parallel live migration."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Developer impact"},{"line_number":122,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"75132552_b322762a","line":119,"in_reply_to":"b45ff2f9_09c74b0b","updated":"2025-07-25 13:55:45.000000000","message":"Done","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a0bc594b53ef869536bb21484880a0c1ee6cbb5","unresolved":true,"context_lines":[{"line_number":130,"context_line":"nodes are upgraded to the version including the feature."},{"line_number":131,"context_line":"Otherwise, non-upgraded computes will ignore the parameter and perform"},{"line_number":132,"context_line":"non-parallel migrations regardless of the ``[libvirt]/live_migration_parallel_connections``"},{"line_number":133,"context_line":"value."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Implementation"},{"line_number":136,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"24a49801_6fc5034f","line":133,"updated":"2025-07-24 14:42:17.000000000","message":"its possibel that we would modify it to a small value like 2 or 4 everntlly but\ni supect we will not change it form 0/1\n\nits too deployment sepcific.\nnova shoudl not try to auto cacluate the value the operator should jsut set it based on there own perfroamce messuerments.","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b411acdcd0d6e9263ba4a99680de8855d70ec7b7","unresolved":false,"context_lines":[{"line_number":130,"context_line":"nodes are upgraded to the version including the feature."},{"line_number":131,"context_line":"Otherwise, non-upgraded computes will ignore the parameter and perform"},{"line_number":132,"context_line":"non-parallel migrations regardless of the ``[libvirt]/live_migration_parallel_connections``"},{"line_number":133,"context_line":"value."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Implementation"},{"line_number":136,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"d88854f5_bb893ec3","line":133,"in_reply_to":"24a49801_6fc5034f","updated":"2025-07-25 13:42:03.000000000","message":"Done","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a0bc594b53ef869536bb21484880a0c1ee6cbb5","unresolved":true,"context_lines":[{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Corresponding unit testing needs to be implemented to ensure that defined"},{"line_number":160,"context_line":"config parameter does pass expected flags to the libvirt."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1b62d39e_0da0c115","line":160,"updated":"2025-07-24 14:42:17.000000000","message":"we likely shoudl test this by modifying one fo our live migration jobs to enable it too\n\nso either nova-hybrid-plug nova-next or the nova ceph live migration job.\n\nmost jobs should use the default be we can select one of the exsting tempest josb to secifically test this.","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b411acdcd0d6e9263ba4a99680de8855d70ec7b7","unresolved":true,"context_lines":[{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Corresponding unit testing needs to be implemented to ensure that defined"},{"line_number":160,"context_line":"config parameter does pass expected flags to the libvirt."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3e90610d_ce20611f","line":160,"in_reply_to":"1b62d39e_0da0c115","updated":"2025-07-25 13:42:03.000000000","message":"I would likely need some help with that then...","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a0bc594b53ef869536bb21484880a0c1ee6cbb5","unresolved":true,"context_lines":[{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"No explicit documentation changes are expected, except help for the introduced"},{"line_number":167,"context_line":"option, which will propagate to Nova configuration reference."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a9548b81_6addba7b","line":167,"updated":"2025-07-24 14:42:17.000000000","message":"i guess we can review that in the code change we may want to see if there is anythin in the install guide or similar that shoudl be updated to refence it\n\ni think we have a section that descibe how to configure nova for live migation and we may just want to add a link to the config option there.","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"b411acdcd0d6e9263ba4a99680de8855d70ec7b7","unresolved":false,"context_lines":[{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"No explicit documentation changes are expected, except help for the introduced"},{"line_number":167,"context_line":"option, which will propagate to Nova configuration reference."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":1,"id":"72fdc4d3_a060bd99","line":167,"in_reply_to":"a9548b81_6addba7b","updated":"2025-07-25 13:42:03.000000000","message":"Done","commit_id":"47a24170a42cd6f1c2b45a8c0170a421d39e4907"}]}