)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e161a940c92424dccb801ab4b42f0604474225b7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ian Wells \u003ciawells@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-04 01:50:21 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"2 interfaces, 1 net"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow Nova to create two interfaces on a single network from one VM."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_898161c5","line":7,"updated":"2014-06-04 09:44:11.000000000","message":"The subject line should exactly match the title used in the spec document\n\nThe body of the commit should be a copy of the first paragraph from the spec.","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"2cc750bd78b149c0089f8d15bd8a123c19867668","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ian Wells \u003ciawells@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-18 22:01:44 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"2 interfaces, 1 net"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow Nova to create two interfaces on a single network from one VM."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ae5cdf2_2c2bf6eb","line":7,"updated":"2014-06-19 08:57:12.000000000","message":"I suggest you modify the title","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"d14fcb20ababe48bc9548268cfc938a213bc9318","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ian Wells \u003ciawells@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-18 22:01:44 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"2 interfaces, 1 net"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow Nova to create two interfaces on a single network from one VM."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ae5cdf2_e2eb6410","line":7,"in_reply_to":"1ae5cdf2_2c2bf6eb","updated":"2014-06-23 20:55:31.000000000","message":"Dammit.  Missed the commit message.","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"2f017191bd209507e9bf06ddaa5d42519066b131","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ian Wells \u003ciawells@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-18 22:01:44 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"2 interfaces, 1 net"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow Nova to create two interfaces on a single network from one VM."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"baada198_c82709b5","line":7,"in_reply_to":"1ae5cdf2_2c2bf6eb","updated":"2014-07-05 07:01:03.000000000","message":"Done","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a3a0b9ddd8dcf57586eeaa81c38a913bb4a59f0e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow Nova to create two interfaces on a single network from one VM."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"NFVImpact"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I986c84e355dec1c78389661ff480f4de93869447"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ae5cdf2_844e7a6d","line":11,"updated":"2014-06-20 09:15:58.000000000","message":"Please link to the nova blueprint in the standard way in the commit message:\n\nblueprint xyz\n\nGerrit/jenkins will add you a nice link to this spec in your nova blueprint that way.","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"2f017191bd209507e9bf06ddaa5d42519066b131","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow Nova to create two interfaces on a single network from one VM."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"NFVImpact"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I986c84e355dec1c78389661ff480f4de93869447"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"baada198_ac470276","line":11,"in_reply_to":"1ae5cdf2_844e7a6d","updated":"2014-07-05 07:01:03.000000000","message":"Done","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"}],"specs/juno/nfv-2-if-1-net.rst":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e161a940c92424dccb801ab4b42f0604474225b7","unresolved":false,"context_lines":[{"line_number":4,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"Support two interfaces from one VM attached to the same network"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"https://blueprints.launchpad.net/nova/+spec/2-if-1-net"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_09f0f18f","line":7,"updated":"2014-06-04 09:44:11.000000000","message":"s/two/multiple/ since you\u0027re removing the restriction of only-1 and will thus allow an arbitrary number of connections.","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"a8d5bbfbbfff368c5cd2215acb90c4633de68e9b","unresolved":false,"context_lines":[{"line_number":4,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"Support two interfaces from one VM attached to the same network"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"https://blueprints.launchpad.net/nova/+spec/2-if-1-net"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_14958a3f","line":7,"in_reply_to":"1ae5cdf2_09f0f18f","updated":"2014-06-18 13:37:34.000000000","message":"Done","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e161a940c92424dccb801ab4b42f0604474225b7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support two interfaces from one VM attached to the same network"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"https://blueprints.launchpad.net/nova/+spec/2-if-1-net"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Permit VMs to attach two interfaces to one network to facilitate use"},{"line_number":13,"context_line":"of common NFV network function VMs that require this form of attachment."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_a938dd3d","line":10,"updated":"2014-06-04 09:44:11.000000000","message":"Please give this blueprint a more appropriate name. eg   \u0027attach-multiple-guest-interfaces-per-network\u0027\n\nLikewise rename this spec file to match","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"a8d5bbfbbfff368c5cd2215acb90c4633de68e9b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support two interfaces from one VM attached to the same network"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"https://blueprints.launchpad.net/nova/+spec/2-if-1-net"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Permit VMs to attach two interfaces to one network to facilitate use"},{"line_number":13,"context_line":"of common NFV network function VMs that require this form of attachment."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_549b9272","line":10,"in_reply_to":"1ae5cdf2_a938dd3d","updated":"2014-06-18 13:37:34.000000000","message":"Done","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e161a940c92424dccb801ab4b42f0604474225b7","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"https://blueprints.launchpad.net/nova/+spec/2-if-1-net"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Permit VMs to attach two interfaces to one network to facilitate use"},{"line_number":13,"context_line":"of common NFV network function VMs that require this form of attachment."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_e93d852c","line":12,"updated":"2014-06-04 09:44:11.000000000","message":"s/two/multiple/","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"a8d5bbfbbfff368c5cd2215acb90c4633de68e9b","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"https://blueprints.launchpad.net/nova/+spec/2-if-1-net"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Permit VMs to attach two interfaces to one network to facilitate use"},{"line_number":13,"context_line":"of common NFV network function VMs that require this form of attachment."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_b48db633","line":12,"in_reply_to":"1ae5cdf2_e93d852c","updated":"2014-06-18 13:37:34.000000000","message":"Done","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"967056f26f94e3619b61f03ef787e68f8d115ba2","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"At present, Nova only permits a single VIF from each VM to be attached to a"},{"line_number":19,"context_line":"given Neutron network.  If you attempt to attach two VIFs to the same network,"},{"line_number":20,"context_line":"a \u0027404 Not Found\u0027 error is issued, meaning that the second network is not"},{"line_number":21,"context_line":"found from the list of networks remaining after the first network is not used."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"NFV functions occasionally require two interfaces to be attached to a single"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_18048f48","line":20,"updated":"2014-06-13 04:06:54.000000000","message":"fwiw I think a bad request error is actually raised instead\n\nhttps://github.com/openstack/nova/blob/master/nova/exception.py#L573","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"a8d5bbfbbfff368c5cd2215acb90c4633de68e9b","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"At present, Nova only permits a single VIF from each VM to be attached to a"},{"line_number":19,"context_line":"given Neutron network.  If you attempt to attach two VIFs to the same network,"},{"line_number":20,"context_line":"a \u0027404 Not Found\u0027 error is issued, meaning that the second network is not"},{"line_number":21,"context_line":"found from the list of networks remaining after the first network is not used."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"NFV functions occasionally require two interfaces to be attached to a single"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_5472b24a","line":20,"in_reply_to":"1ae5cdf2_18048f48","updated":"2014-06-18 13:37:34.000000000","message":"OK - used to be not found.  Made less specific.","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e161a940c92424dccb801ab4b42f0604474225b7","unresolved":false,"context_lines":[{"line_number":57,"context_line":"When the attempt is made to attach two interfaces to a single network, Nova"},{"line_number":58,"context_line":"will, instead of returning the 404 error, attach two interfaces to the same"},{"line_number":59,"context_line":"network and return a normal success code to the \u0027nova boot\u0027 attempt."},{"line_number":60,"context_line":" "},{"line_number":61,"context_line":"Alternatives"},{"line_number":62,"context_line":"------------"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_094711bd","line":60,"updated":"2014-06-04 09:44:11.000000000","message":"nitpick - trailing whitespace here.","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"a8d5bbfbbfff368c5cd2215acb90c4633de68e9b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"When the attempt is made to attach two interfaces to a single network, Nova"},{"line_number":58,"context_line":"will, instead of returning the 404 error, attach two interfaces to the same"},{"line_number":59,"context_line":"network and return a normal success code to the \u0027nova boot\u0027 attempt."},{"line_number":60,"context_line":" "},{"line_number":61,"context_line":"Alternatives"},{"line_number":62,"context_line":"------------"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_942b5aea","line":60,"in_reply_to":"1ae5cdf2_094711bd","updated":"2014-06-18 13:37:34.000000000","message":"Done","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"967056f26f94e3619b61f03ef787e68f8d115ba2","unresolved":false,"context_lines":[{"line_number":79,"context_line":"network and return a normal success code to the \u0027nova boot\u0027 attempt."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Security impact"},{"line_number":82,"context_line":"---------------"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"None."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_38adcb31","line":82,"updated":"2014-06-13 04:06:54.000000000","message":"I think we should also take into consideration that the reason it\u0027s this way today in nova to to prevent one from bridging these interfaces and looping the network. no?","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":8499,"name":"Racha Ben Ali","email":"benali@gmail.com","username":"rbenali"},"change_message_id":"69c6c0ed724eea06b83782bfdfa4b828287dcc2c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"network and return a normal success code to the \u0027nova boot\u0027 attempt."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Security impact"},{"line_number":82,"context_line":"---------------"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"None."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_093bfa9c","line":82,"in_reply_to":"1ae5cdf2_38adcb31","updated":"2014-06-17 08:13:04.000000000","message":"Aaron, with today’s way, is it possible for a root to run a script that will configure on VM’s kernel some MAC header rewriting (to comply with what is allowed on each vnics MAC filtering) to, rather than consume frames locally, send all of what it receives from vnic0 on first L2 network net0 to a second vnic1 on a DIFFERENT L2 network net1 (vnic0 rx --\u003e vnic 1 tx : after MAC header rewrite) and do the same in a second VM in a cross connect way (vnic1 rx --\u003e vnic0 tx): One single frame will end up indefinitely duplicated with this loop with a growing snow ball effect limited by the least of two VMs MAC rewrite/non0copy performance, probably not abusing a 10gig NIC without SR-IOV or DPDK... Can a tenant still be affected by the other looping tenant without having a rate limiter?\n\nI think it is mandatory to prevent “one” from looping the network, but this use case is not for “one” among tenants but for a single tenant “network function” that is already responsible of any undesirable side effects (brd storms etc..), if only the infra admin could have the non default option to allow it for NFV…  I marked https://bugs.launchpad.net/nova/+bug/1187244 as duplicate of https://bugs.launchpad.net/nova/+bug/1166110.\nAnd here https://review.openstack.org/#/c/98488/ I added that config flag that by default prevents that unless the NFV infra admin needs to allow it at his own risk. Please do not mark it “-1” too soon unless you have to :/","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"a8d5bbfbbfff368c5cd2215acb90c4633de68e9b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"network and return a normal success code to the \u0027nova boot\u0027 attempt."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Security impact"},{"line_number":82,"context_line":"---------------"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"None."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_348606ba","line":82,"in_reply_to":"1ae5cdf2_38adcb31","updated":"2014-06-18 13:37:34.000000000","message":"The effect is the same as spamming the network with packets deliberately.  I don\u0027t think it\u0027s an added risk, just a thing that\u0027s now easier to do accidentally.  Added comment.","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e161a940c92424dccb801ab4b42f0604474225b7","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Independently of this spec, tests should be added to Tempest:"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"*  minimally, to ensure that traffic can be passed between the two"},{"line_number":142,"context_line":"  interfaces on a VM created in this fashion"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"* optionally, traffic flow should be tested from another VM or"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_291bedca","line":141,"updated":"2014-06-04 09:44:11.000000000","message":"nitpick - only 1 space after \u0027*\u0027 not 2","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"a8d5bbfbbfff368c5cd2215acb90c4633de68e9b","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Independently of this spec, tests should be added to Tempest:"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"*  minimally, to ensure that traffic can be passed between the two"},{"line_number":142,"context_line":"  interfaces on a VM created in this fashion"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"* optionally, traffic flow should be tested from another VM or"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_54a63255","line":141,"in_reply_to":"1ae5cdf2_291bedca","updated":"2014-06-18 13:37:34.000000000","message":"Done","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":6772,"name":"Stephen Gordon","email":"sgordon@redhat.com","username":"sgordon"},"change_message_id":"485198b72ead834b656ee15d01aac9ec6b7218e4","unresolved":false,"context_lines":[{"line_number":149,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"The change can be documented, but since the current behaviour is not"},{"line_number":152,"context_line":"documented at present no change is actually required."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"References"},{"line_number":155,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_89f065ca","line":152,"updated":"2014-06-04 23:00:28.000000000","message":"At some point recently I answered an ask.o.o question about this functionality (or the lack there of) and found that there was in fact documentation saying:\n\n\"Each VIF is representative of a separate network with its own IP block. Every network mode introduces it\u0027s own set of changes regarding the mulitnic usage...\"\n\nIt\u0027s in this section of the admin-cloud-guide:\n\nhttp://docs.openstack.org/admin-guide-cloud/content/section_use-multi-nics.html\n\nSo we would probably need to update that, in my mind, because we\u0027re now enabling the situation where each VIF is *not* necessarily a completely separate network?","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"89b1d3acbafb2605ef5068ef02497603807d9c8e","unresolved":false,"context_lines":[{"line_number":149,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"The change can be documented, but since the current behaviour is not"},{"line_number":152,"context_line":"documented at present no change is actually required."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"References"},{"line_number":155,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_cecf8656","line":152,"in_reply_to":"1ae5cdf2_89f065ca","updated":"2014-06-06 21:33:01.000000000","message":"That\u0027s documenting, specifically, nova-network multinic - it\u0027s exactly correct for multinic setups and doesn\u0027t want changing.  This would only affect neutron configs, I believe.","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":6772,"name":"Stephen Gordon","email":"sgordon@redhat.com","username":"sgordon"},"change_message_id":"485198b72ead834b656ee15d01aac9ec6b7218e4","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"References"},{"line_number":155,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"* https://github.com/openstack/oslo.vmware"},{"line_number":158,"context_line":"* https://blueprints.launchpad.net/nova/+spec/vmware-spawn-refactor"},{"line_number":159,"context_line":"* https://wiki.openstack.org/wiki/NovaVMware/Minesweeper"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_0941b50a","line":156,"updated":"2014-06-04 23:00:28.000000000","message":"Probably worth also referencing the bug where this behaviour was previously noted/tracked:\n\nhttps://bugs.launchpad.net/nova/+bug/1166110\n\nRelates to the abandoned code submission referenced above.","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":6772,"name":"Stephen Gordon","email":"sgordon@redhat.com","username":"sgordon"},"change_message_id":"485198b72ead834b656ee15d01aac9ec6b7218e4","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"* https://github.com/openstack/oslo.vmware"},{"line_number":158,"context_line":"* https://blueprints.launchpad.net/nova/+spec/vmware-spawn-refactor"},{"line_number":159,"context_line":"* https://wiki.openstack.org/wiki/NovaVMware/Minesweeper"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_0958d5f8","line":159,"updated":"2014-06-04 23:00:28.000000000","message":"Not *immediately* clear to me what the relationship to these is, were these copied across accidentally?","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"89b1d3acbafb2605ef5068ef02497603807d9c8e","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"* https://github.com/openstack/oslo.vmware"},{"line_number":158,"context_line":"* https://blueprints.launchpad.net/nova/+spec/vmware-spawn-refactor"},{"line_number":159,"context_line":"* https://wiki.openstack.org/wiki/NovaVMware/Minesweeper"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_2ed70aef","line":159,"updated":"2014-06-06 21:33:01.000000000","message":"Out of the template, in fact.  Oops.","commit_id":"9c03cd6a3b81bbb37094d0913fe6ab504c2f748f"}],"specs/juno/nfv-multiple-if-1-net.rst":[{"author":{"_account_id":6772,"name":"Stephen Gordon","email":"sgordon@redhat.com","username":"sgordon"},"change_message_id":"44b56eb90be0f1e46feabd730e176ee5e69cac35","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"It is now going to be possible to bridge multiple interfaces together"},{"line_number":90,"context_line":"within a VM and cause a broadcast storm.  It was always possible to"},{"line_number":91,"context_line":"flood a Neutron neteork from a VM; this makes it easier.  It doesn\u0027t"},{"line_number":92,"context_line":"make a security issue in and of itself but it certainly does make it a"},{"line_number":93,"context_line":"little more straightforward to trigger one that arguably already"},{"line_number":94,"context_line":"exists."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_57f8e27b","line":91,"updated":"2014-06-18 19:42:54.000000000","message":"s/neteork/network/","commit_id":"b9fcc5fef53369573a8c636ad37f1f94f0b9bf99"},{"author":{"_account_id":8499,"name":"Racha Ben Ali","email":"benali@gmail.com","username":"rbenali"},"change_message_id":"ddfc10328bf4d185abff38480b6b0037ad915c0d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  forward from the code in question to the current trunk."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"* Add unit tests, which are missing from the abandoned patch."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Dependencies"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_b2de94d8","line":140,"updated":"2014-06-18 20:15:13.000000000","message":"done here https://review.openstack.org/98488","commit_id":"b9fcc5fef53369573a8c636ad37f1f94f0b9bf99"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"c92c1156a73e82b1cbc95336c52405c773358b2b","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  forward from the code in question to the current trunk."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"* Add unit tests, which are missing from the abandoned patch."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Dependencies"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_9e3c35e3","line":140,"in_reply_to":"1ae5cdf2_b2de94d8","updated":"2014-06-19 05:03:01.000000000","message":"All good - please link that to this BP so that no-one quibbles that it hasn\u0027t got a spec.  I\u0027ll refix this with the typo above and if you\u0027re doing previsely what this says then please +1 the spec review.","commit_id":"b9fcc5fef53369573a8c636ad37f1f94f0b9bf99"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"0f23ac3631aa11a27e84e9426258d829aecf6ba8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"to a given Neutron network.  If you attempt to attach multiple VIFs to"},{"line_number":21,"context_line":"the same network, an error is issued, meaning that the second network"},{"line_number":22,"context_line":"is not found from the list of networks remaining after the first"},{"line_number":23,"context_line":"network is not used."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NFV functions occasionally require multiple interfaces to be attached"},{"line_number":26,"context_line":"to a single network from the same VM, for reasons described below in"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_4c94c236","line":23,"updated":"2014-06-19 08:54:12.000000000","message":"if attach multiple VIFs to the same network when boot VM, nova will raise error \"Duplicate networks are not allowed\".\nWe also have the same needs for this issue, I have asked this problem in mailist, https://www.mail-archive.com/openstack-dev%40lists.openstack.org/msg14737.html.\nI am very glad to help you if you need!","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"d14fcb20ababe48bc9548268cfc938a213bc9318","unresolved":false,"context_lines":[{"line_number":20,"context_line":"to a given Neutron network.  If you attempt to attach multiple VIFs to"},{"line_number":21,"context_line":"the same network, an error is issued, meaning that the second network"},{"line_number":22,"context_line":"is not found from the list of networks remaining after the first"},{"line_number":23,"context_line":"network is not used."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NFV functions occasionally require multiple interfaces to be attached"},{"line_number":26,"context_line":"to a single network from the same VM, for reasons described below in"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_62be7402","line":23,"in_reply_to":"1ae5cdf2_4c94c236","updated":"2014-06-23 20:55:31.000000000","message":"Apparently that messages varies by version (I\u0027m told it\u0027s not that in Havana) so the paragraph has been worded vaguely about the error type.","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"4e417eccd5ed1c9430bc1af6c68a4354d75d2372","unresolved":false,"context_lines":[{"line_number":21,"context_line":"the same network, an error is issued, meaning that the second network"},{"line_number":22,"context_line":"is not found from the list of networks remaining after the first"},{"line_number":23,"context_line":"network is not used."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NFV functions occasionally require multiple interfaces to be attached"},{"line_number":26,"context_line":"to a single network from the same VM, for reasons described below in"},{"line_number":27,"context_line":"the \u0027use cases\u0027 section.  When this is required, the VNF generally"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_5eadf183","line":24,"updated":"2014-06-23 05:50:29.000000000","message":"exactly to say, currently nova support attach multiple interfaces to one vm. It can be done by \u0027nova attach-interface\u0027. It only didn\u0027t support that from \u0027nova boot\u0027","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"2f017191bd209507e9bf06ddaa5d42519066b131","unresolved":false,"context_lines":[{"line_number":21,"context_line":"the same network, an error is issued, meaning that the second network"},{"line_number":22,"context_line":"is not found from the list of networks remaining after the first"},{"line_number":23,"context_line":"network is not used."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NFV functions occasionally require multiple interfaces to be attached"},{"line_number":26,"context_line":"to a single network from the same VM, for reasons described below in"},{"line_number":27,"context_line":"the \u0027use cases\u0027 section.  When this is required, the VNF generally"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_6cc32aed","line":24,"in_reply_to":"1ae5cdf2_5eadf183","updated":"2014-07-05 07:01:03.000000000","message":"Done","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a3a0b9ddd8dcf57586eeaa81c38a913bb4a59f0e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"is often prohibitive.  VNFs are large, complex pieces of code, and often the"},{"line_number":44,"context_line":"supplier of the VNF is not the same organisation as that trying to use"},{"line_number":45,"context_line":"the VNF within Openstack, necessitating a feature change request which may"},{"line_number":46,"context_line":"well not be possible within reasonable timescales."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"We propose changing the code within Nova to remove this limitation."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_49f9eb4c","line":46,"updated":"2014-06-20 09:15:58.000000000","message":"So another use case to discuss:\n\nYou might want two passthrough NICs going to the same VM, but ensuring the two passthrough connections are from separate physical NICs on the hypervisor.\n\nI presume this is not something that you want to add here, you just want to loosen the restriction?","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"bc5b4b5128550cdec289a8f9edf876266c848e84","unresolved":false,"context_lines":[{"line_number":43,"context_line":"is often prohibitive.  VNFs are large, complex pieces of code, and often the"},{"line_number":44,"context_line":"supplier of the VNF is not the same organisation as that trying to use"},{"line_number":45,"context_line":"the VNF within Openstack, necessitating a feature change request which may"},{"line_number":46,"context_line":"well not be possible within reasonable timescales."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"We propose changing the code within Nova to remove this limitation."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_a53a6fca","line":46,"in_reply_to":"1ae5cdf2_49f9eb4c","updated":"2014-06-22 11:50:04.000000000","message":"+1 for the suggested use case. I would agree that it probably deserves its own spec.","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"d14fcb20ababe48bc9548268cfc938a213bc9318","unresolved":false,"context_lines":[{"line_number":43,"context_line":"is often prohibitive.  VNFs are large, complex pieces of code, and often the"},{"line_number":44,"context_line":"supplier of the VNF is not the same organisation as that trying to use"},{"line_number":45,"context_line":"the VNF within Openstack, necessitating a feature change request which may"},{"line_number":46,"context_line":"well not be possible within reasonable timescales."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"We propose changing the code within Nova to remove this limitation."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_a266bcb9","line":46,"in_reply_to":"1ae5cdf2_a53a6fca","updated":"2014-06-23 20:55:31.000000000","message":"This would appear to be a scheduling issue related to anti-affinity, affecting the selection of PCI devices.  Interesting; not relevant here, but you\u0027ll need this as a dependency.","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"bc5b4b5128550cdec289a8f9edf876266c848e84","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"We propose removing the limitation, which exists in Nova (Neutron has no such"},{"line_number":54,"context_line":"limitation), allowing any number of VIFs to be attached to the same network."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"API changes"},{"line_number":57,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_c535bbdb","line":54,"updated":"2014-06-22 11:50:04.000000000","message":"I think it worth to mention that VM NICs order should be kept according to the appearance in \u0027nova boot\u0027 command.","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"2f017191bd209507e9bf06ddaa5d42519066b131","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"We propose removing the limitation, which exists in Nova (Neutron has no such"},{"line_number":54,"context_line":"limitation), allowing any number of VIFs to be attached to the same network."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"API changes"},{"line_number":57,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_762db794","line":54,"in_reply_to":"1ae5cdf2_c535bbdb","updated":"2014-07-05 07:01:03.000000000","message":"Done","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"d14fcb20ababe48bc9548268cfc938a213bc9318","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"We propose removing the limitation, which exists in Nova (Neutron has no such"},{"line_number":54,"context_line":"limitation), allowing any number of VIFs to be attached to the same network."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"API changes"},{"line_number":57,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_c202e8b9","line":54,"in_reply_to":"1ae5cdf2_c535bbdb","updated":"2014-06-23 20:55:31.000000000","message":"Fair.","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"dd8c866fab322c0670986e086cb707f2dd4cb062","unresolved":false,"context_lines":[{"line_number":59,"context_line":"When the attempt is made to attach multiple interfaces to a single"},{"line_number":60,"context_line":"network, Nova will, instead of returning the error, attach multiple"},{"line_number":61,"context_line":"interfaces to the same network and return a normal success code to the"},{"line_number":62,"context_line":"\u0027nova boot\u0027 attempt."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_ae08de2d","line":62,"updated":"2014-06-19 08:01:46.000000000","message":"Can you add \u0027nova interface-attach\u0027? Both commands kick the same method in Nova (allocate_port_for_instance) witch makes the limit. So we don\u0027t need addtional development for it, but it\u0027s good to note here that we also make it available through \u0027nova interface-attach\u0027.","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"d14fcb20ababe48bc9548268cfc938a213bc9318","unresolved":false,"context_lines":[{"line_number":59,"context_line":"When the attempt is made to attach multiple interfaces to a single"},{"line_number":60,"context_line":"network, Nova will, instead of returning the error, attach multiple"},{"line_number":61,"context_line":"interfaces to the same network and return a normal success code to the"},{"line_number":62,"context_line":"\u0027nova boot\u0027 attempt."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_62f3d4e7","line":62,"in_reply_to":"1ae5cdf2_1e8c492e","updated":"2014-06-23 20:55:31.000000000","message":"I can at least say that \u0027nova interface-attach\u0027 abides by the same rules; also that --nic port-id should work with identical networks...","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"4e417eccd5ed1c9430bc1af6c68a4354d75d2372","unresolved":false,"context_lines":[{"line_number":59,"context_line":"When the attempt is made to attach multiple interfaces to a single"},{"line_number":60,"context_line":"network, Nova will, instead of returning the error, attach multiple"},{"line_number":61,"context_line":"interfaces to the same network and return a normal success code to the"},{"line_number":62,"context_line":"\u0027nova boot\u0027 attempt."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_1e8c492e","line":62,"in_reply_to":"1ae5cdf2_a9998f20","updated":"2014-06-23 05:50:29.000000000","message":"actually we can attach multple port at same network by \u0027nova interface-attch\u0027 now.","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a3a0b9ddd8dcf57586eeaa81c38a913bb4a59f0e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"When the attempt is made to attach multiple interfaces to a single"},{"line_number":60,"context_line":"network, Nova will, instead of returning the error, attach multiple"},{"line_number":61,"context_line":"interfaces to the same network and return a normal success code to the"},{"line_number":62,"context_line":"\u0027nova boot\u0027 attempt."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_a9998f20","line":62,"in_reply_to":"1ae5cdf2_ae08de2d","updated":"2014-06-20 09:15:58.000000000","message":"+1","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"2f017191bd209507e9bf06ddaa5d42519066b131","unresolved":false,"context_lines":[{"line_number":59,"context_line":"When the attempt is made to attach multiple interfaces to a single"},{"line_number":60,"context_line":"network, Nova will, instead of returning the error, attach multiple"},{"line_number":61,"context_line":"interfaces to the same network and return a normal success code to the"},{"line_number":62,"context_line":"\u0027nova boot\u0027 attempt."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_d63be3ce","line":62,"in_reply_to":"1ae5cdf2_ae08de2d","updated":"2014-07-05 07:01:03.000000000","message":"Done","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a3a0b9ddd8dcf57586eeaa81c38a913bb4a59f0e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"ports on the same network and attach the VM to the ports, rather than"},{"line_number":69,"context_line":"the same network twice.  This has not been tested.  On the other hand,"},{"line_number":70,"context_line":"this indicates that the limitation is highly artificial and should, in"},{"line_number":71,"context_line":"any case, be removed."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Data model impact"},{"line_number":74,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_8964d322","line":71,"updated":"2014-06-20 09:15:58.000000000","message":"In fact I think you should make sure that is also possible, as part of testing this feature.","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"d14fcb20ababe48bc9548268cfc938a213bc9318","unresolved":false,"context_lines":[{"line_number":68,"context_line":"ports on the same network and attach the VM to the ports, rather than"},{"line_number":69,"context_line":"the same network twice.  This has not been tested.  On the other hand,"},{"line_number":70,"context_line":"this indicates that the limitation is highly artificial and should, in"},{"line_number":71,"context_line":"any case, be removed."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Data model impact"},{"line_number":74,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_0224d05e","line":71,"in_reply_to":"1ae5cdf2_8964d322","updated":"2014-06-23 20:55:31.000000000","message":"Heh, guess which comment I just added ;)","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a3a0b9ddd8dcf57586eeaa81c38a913bb4a59f0e","unresolved":false,"context_lines":[{"line_number":133,"context_line":"----------"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"* Change the Nova code, per the existing abandoned patch in"},{"line_number":136,"context_line":"  https://review.openstack.org/#/c/26370 - which requires porting"},{"line_number":137,"context_line":"  forward from the code in question to the current trunk."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"* Add unit tests, which are missing from the abandoned patch."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_49556b1c","line":136,"updated":"2014-06-20 09:15:58.000000000","message":"I don\u0027t really like seeing these links in specs, as things change, but this link could be broken, and this text still makes sense, so that fine.","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a3a0b9ddd8dcf57586eeaa81c38a913bb4a59f0e","unresolved":false,"context_lines":[{"line_number":149,"context_line":"Independently of this spec, tests should be added to Tempest:"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"* minimally, to ensure that traffic can be passed between the two"},{"line_number":152,"context_line":"  interfaces on a VM created in this fashion"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"* optionally, traffic flow should be tested from another VM or"},{"line_number":155,"context_line":"  external packet supplier to either of the interfaces."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_a9350ff8","line":152,"updated":"2014-06-20 09:15:58.000000000","message":"Do you mean, \"ensure you can ssh through both interfaces\"? Tempest doesn\u0027t tend to do much invasive testing on the guest.\n\nIt would be good to test all the cases, boot multiple networks, multiple ports (attached to the same network), hotplug a port to the same network, etc.","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"d14fcb20ababe48bc9548268cfc938a213bc9318","unresolved":false,"context_lines":[{"line_number":149,"context_line":"Independently of this spec, tests should be added to Tempest:"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"* minimally, to ensure that traffic can be passed between the two"},{"line_number":152,"context_line":"  interfaces on a VM created in this fashion"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"* optionally, traffic flow should be tested from another VM or"},{"line_number":155,"context_line":"  external packet supplier to either of the interfaces."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_62e114fc","line":152,"in_reply_to":"1ae5cdf2_a9350ff8","updated":"2014-06-23 20:55:31.000000000","message":"Pass traffic from one port on a VM to a second port on the same VM, was what I said.  And note \u0027minimally\u0027.  This is a Nova spec, it can require nothing of Tempest, and I\u0027m making weak recommendations really so that Tempest gets something instantly, even if it\u0027s not comprehensive.","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a3a0b9ddd8dcf57586eeaa81c38a913bb4a59f0e","unresolved":false,"context_lines":[{"line_number":161,"context_line":"The change can be documented, but since the current behaviour is not"},{"line_number":162,"context_line":"documented at present no change is actually required.  Documentation"},{"line_number":163,"context_line":"exists for nova-network multinic saying that VIFs are attached to"},{"line_number":164,"context_line":"separate networks but this is specific to nova-network."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"References"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_e409fe2b","line":164,"updated":"2014-06-20 09:15:58.000000000","message":"Hmm, OK.","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"},{"author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"change_message_id":"d14fcb20ababe48bc9548268cfc938a213bc9318","unresolved":false,"context_lines":[{"line_number":161,"context_line":"The change can be documented, but since the current behaviour is not"},{"line_number":162,"context_line":"documented at present no change is actually required.  Documentation"},{"line_number":163,"context_line":"exists for nova-network multinic saying that VIFs are attached to"},{"line_number":164,"context_line":"separate networks but this is specific to nova-network."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"References"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_02a93090","line":164,"in_reply_to":"1ae5cdf2_e409fe2b","updated":"2014-06-23 20:55:31.000000000","message":"Really needs documenting.  I\u0027m simply saying the change doesn\u0027t render the documentation incorrect immediately.","commit_id":"752d8a7598262efe3d5c3450712b84dc15564e19"}]}