)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ce0748aa8e7b81787a42381bcb997490518c767f","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Renames reject_sev_instances to the more generic"},{"line_number":10,"context_line":"reject_mem_enc_instances. The logic in reject_sev_instances already"},{"line_number":11,"context_line":"covered all types of memory encryption instances. Intel TDX and AMD SEV"},{"line_number":12,"context_line":"share limitations for now and thus this is fine. In the future dedicated"},{"line_number":13,"context_line":"rejection functions might be needed per memory encryption model."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial-Implements: blueprint intel-tdx-libvirt-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"d6fdb738_64790788","line":12,"range":{"start_line":11,"start_character":51,"end_line":12,"end_character":47},"updated":"2026-08-18 22:58:13.000000000","message":"in the specific context of the reject_mem_enc_instances decoratort that is true but TDX has mroe limiation in general.\n\nwe shoudl avoid implyting that the limaition on TDX and SEV guests are generaly the same\nSEV supprot hw_disk_bus\u003dscsi with hw_scsi_model\u003dvirtio-scsi as an example and vnc/spice concoles.\n\n\nif concole log does not work for TDX guest we may want to block that with a TDX specifc decorator today instead of sharing one.","commit_id":"cb9b255afc8fba3077dd7b38099e3435e5fd2f34"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38744,"name":"Anton Iacobaeus","display_name":"antia","email":"anton.iacobaeus@canarybit.eu","username":"antia","status":"Canary Bit"},"change_message_id":"8c559d01283a634567e8925b868b128994f3130b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"28e48533_2d88764a","updated":"2026-08-07 11:02:26.000000000","message":"The alternative to this would be to introduce a separate rejection function for TDX and update the logic of reject_sev_instances to only handle SEV.","commit_id":"f638e9c32d681eb546c65c32de9c6452b365c9a0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"675decce93d3d8030f850c84486287de56d80a85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f2af2333_4aae083d","updated":"2026-08-13 13:48:48.000000000","message":"looks good","commit_id":"34008877f87055ec8e91335e2fb8d074bd99e4cc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d69bbe28f3292c54c29885af636acdc66a2de7f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4e1ccca3_25e275ce","updated":"2026-08-13 15:05:16.000000000","message":"At this moment I don\u0027t know the same limitation is applied to Arm CCA but I agree with this generalization for models we knows detail about.","commit_id":"cb9b255afc8fba3077dd7b38099e3435e5fd2f34"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"68f8c4d86ec243abe24021f44c41651a15a0c238","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"84e1e4d7_4214df62","updated":"2026-08-22 03:07:26.000000000","message":"lgtm, leaving +W to Sean for their open comment.","commit_id":"f3472bafc7e445cf8853a5ac6ed9b3433738aac6"}],"nova/exception.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"769935ce9163d90bb9abc349f5899d92d21b59ce","unresolved":true,"context_lines":[{"line_number":596,"context_line":"                \"to current host (%(host)s).\")"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"class OperationNotSupportedForMemEncryption(NotSupported):"},{"line_number":600,"context_line":"    msg_fmt \u003d _(\"Operation \u0027%(operation)s\u0027 not supported for mem encryption \""},{"line_number":601,"context_line":"                \"enabled instance (%(instance_uuid)s).\")"},{"line_number":602,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffa91be7_82378e87","line":599,"updated":"2026-08-07 13:24:22.000000000","message":"do we need to update some `except OperationNotSupportedForSEV` blocks due to this rename?","commit_id":"f638e9c32d681eb546c65c32de9c6452b365c9a0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"150cf99bfcbda6aa5d2f3b3c6bf085c995fe15c2","unresolved":false,"context_lines":[{"line_number":596,"context_line":"                \"to current host (%(host)s).\")"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"class OperationNotSupportedForMemEncryption(NotSupported):"},{"line_number":600,"context_line":"    msg_fmt \u003d _(\"Operation \u0027%(operation)s\u0027 not supported for mem encryption \""},{"line_number":601,"context_line":"                \"enabled instance (%(instance_uuid)s).\")"},{"line_number":602,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ce3325ee_4f09ac94","line":599,"in_reply_to":"dce021ac_214fccd4","updated":"2026-08-11 14:27:41.000000000","message":"OK. I guess it is handled as the base exception NotSupport that automatically translates to HTTP 400 on the API.","commit_id":"f638e9c32d681eb546c65c32de9c6452b365c9a0"},{"author":{"_account_id":38744,"name":"Anton Iacobaeus","display_name":"antia","email":"anton.iacobaeus@canarybit.eu","username":"antia","status":"Canary Bit"},"change_message_id":"4877d893e8e2080e696d80153d179d67f96c8e37","unresolved":true,"context_lines":[{"line_number":596,"context_line":"                \"to current host (%(host)s).\")"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"class OperationNotSupportedForMemEncryption(NotSupported):"},{"line_number":600,"context_line":"    msg_fmt \u003d _(\"Operation \u0027%(operation)s\u0027 not supported for mem encryption \""},{"line_number":601,"context_line":"                \"enabled instance (%(instance_uuid)s).\")"},{"line_number":602,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dce021ac_214fccd4","line":599,"in_reply_to":"ffa91be7_82378e87","updated":"2026-08-10 15:06:36.000000000","message":"I couldn\u0027t find any more mentions of it. Would this be outside of Nova?","commit_id":"f638e9c32d681eb546c65c32de9c6452b365c9a0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"675decce93d3d8030f850c84486287de56d80a85","unresolved":false,"context_lines":[{"line_number":598,"context_line":""},{"line_number":599,"context_line":"class OperationNotSupportedForMemEncryption(NotSupported):"},{"line_number":600,"context_line":"    msg_fmt \u003d _(\"Operation \u0027%(operation)s\u0027 not supported for mem encryption \""},{"line_number":601,"context_line":"                \"enabled instance (%(instance_uuid)s).\")"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"class OperationNotSupportedForVTPM(NotSupported):"}],"source_content_type":"text/x-python","patch_set":3,"id":"e92c7964_6f7f3650","line":601,"updated":"2026-08-13 13:48:48.000000000","message":"this change actually fixes the UX but that the rejection message for TDX instances was confusing as it talks about SEV\n```\nBadRequestException: 400: Client Error for url: http://10.37.137.8/compute/v2.1/servers/f3df97d8-02bb-4bcb-9aec-82d97082ce82/action, Operation \u0027live-migration\u0027 not supported for SEV-enabled instance (f3df97d8-02bb-4bcb-9aec-82d97082ce82).\n```\n\nAfter this change:\n```\nBadRequestException: 400: Client Error for url: http://10.37.137.8/compute/v2.1/servers/602f7062-9517-4d3b-963f-79a26b7c9766/action, Operation \u0027live-migration\u0027 not supported for mem encryption enabled instance (602f7062-9517-4d3b-963f-79a26b7c9766).\n```\n\nwhich is much better","commit_id":"34008877f87055ec8e91335e2fb8d074bd99e4cc"}]}