)]}'
{"nova/virt/libvirt/config.py":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"2a47beea25a85ecf42551d0c48a328c5e6467b0e","unresolved":true,"context_lines":[{"line_number":2064,"context_line":"        # pinned to keep vNIC ordering stable across domain XML regeneration)."},{"line_number":2065,"context_line":"        # parse_dom() already reads it back; without emitting it here setting"},{"line_number":2066,"context_line":"        # device_addr would silently have no effect on the generated XML."},{"line_number":2067,"context_line":"        if self.device_addr:"},{"line_number":2068,"context_line":"            dev.append(self.device_addr.format_dom())"},{"line_number":2069,"context_line":""},{"line_number":2070,"context_line":"        return dev"}],"source_content_type":"text/x-python","patch_set":1,"id":"2acf175e_1f7356a8","line":2067,"updated":"2026-08-14 12:17:46.000000000","message":"Where does this self.device_addr comes from?","commit_id":"fbd4a81be3a34c04fdafd2b7c0d434102be18d34"},{"author":{"_account_id":33607,"name":"Pierre Libeau","email":"pierre.libeau@ovhcloud.com","username":"plibeau"},"change_message_id":"6374093df66e426b2619914cfc784731939de34d","unresolved":false,"context_lines":[{"line_number":2064,"context_line":"        # pinned to keep vNIC ordering stable across domain XML regeneration)."},{"line_number":2065,"context_line":"        # parse_dom() already reads it back; without emitting it here setting"},{"line_number":2066,"context_line":"        # device_addr would silently have no effect on the generated XML."},{"line_number":2067,"context_line":"        if self.device_addr:"},{"line_number":2068,"context_line":"            dev.append(self.device_addr.format_dom())"},{"line_number":2069,"context_line":""},{"line_number":2070,"context_line":"        return dev"}],"source_content_type":"text/x-python","patch_set":1,"id":"e6e74085_46ed2f01","line":2067,"in_reply_to":"2acf175e_1f7356a8","updated":"2026-08-17 12:20:24.000000000","message":"It is not introduced here, self.device_addr is declared in __init__() since 7b6f7ecfa6c (2016) and populated by parse_dom() a few lines below (a221eb4cc6), but format_dom() never emitted it, so the attribute was parse-only and setting it had no effect on the XML.\n\nThis patch just makes the interface class symmetric with LibvirtConfigGuestDisk, which already parses *and* formats it.\n\nThe only caller that sets it comes in the next change of the series (I3e4a0e39ddda3e2d15fe6aba7e6f328c79b5d3f9), which re-pins each vNIC to the PCI\naddress it had in the previous domain.","commit_id":"fbd4a81be3a34c04fdafd2b7c0d434102be18d34"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"7735795fd38b6796f363e5684d7b97c4204cc942","unresolved":false,"context_lines":[{"line_number":2064,"context_line":"        # pinned to keep vNIC ordering stable across domain XML regeneration)."},{"line_number":2065,"context_line":"        # parse_dom() already reads it back; without emitting it here setting"},{"line_number":2066,"context_line":"        # device_addr would silently have no effect on the generated XML."},{"line_number":2067,"context_line":"        if self.device_addr:"},{"line_number":2068,"context_line":"            dev.append(self.device_addr.format_dom())"},{"line_number":2069,"context_line":""},{"line_number":2070,"context_line":"        return dev"}],"source_content_type":"text/x-python","patch_set":1,"id":"fd4bf949_4614083f","line":2067,"in_reply_to":"e6e74085_46ed2f01","updated":"2026-08-17 12:26:30.000000000","message":"Ok, so if I understand correctly, this is needed now to make sure the order is preserved (the next change in the series)","commit_id":"fbd4a81be3a34c04fdafd2b7c0d434102be18d34"}]}