)]}'
{"nova/tests/virt/vmwareapi/test_vm_util.py":[{"author":{"_account_id":6498,"name":"Divakar Padiyar Nandavar","email":"divakar.padiyar-nandavar@hpe.com","username":"divakar-padiyar-nandavar"},"change_message_id":"c85f2a632f7ec61f4a0ed969e69bc0568dad0552","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        self.assertFalse(self._test_is_datastore_valid(True,"},{"line_number":376,"context_line":"                                                      \"normal\","},{"line_number":377,"context_line":"                                                      \"vfat\"))"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def test_get_resize_spec(self):"},{"line_number":380,"context_line":"        fake_instance \u003d {\u0027id\u0027: 7, \u0027name\u0027: \u0027fake!\u0027,"},{"line_number":381,"context_line":"                         \u0027uuid\u0027: \u0027bda5fb9e-b347-40e8-8256-42397848cb00\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_7882caff","line":378,"updated":"2014-06-22 16:32:58.000000000","message":"Do we need to add test case with all allowed values for datastore type \"VMFS\" and \"NFS\"?   In case one removes say \"NFS\" from the allowed values then tests will still go through but no tests will identify that...","commit_id":"781d46435ed45bd43c58a2033edd07ff05a8ec66"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"0181ec1fda8546d39ad8e9903584820c69b9a10d","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        self.assertFalse(self._test_is_datastore_valid(True,"},{"line_number":376,"context_line":"                                                      \"normal\","},{"line_number":377,"context_line":"                                                      \"vfat\"))"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def test_get_resize_spec(self):"},{"line_number":380,"context_line":"        fake_instance \u003d {\u0027id\u0027: 7, \u0027name\u0027: \u0027fake!\u0027,"},{"line_number":381,"context_line":"                         \u0027uuid\u0027: \u0027bda5fb9e-b347-40e8-8256-42397848cb00\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_2da0d090","line":378,"in_reply_to":"1ae5cdf2_7882caff","updated":"2014-06-24 07:03:32.000000000","message":"Done","commit_id":"781d46435ed45bd43c58a2033edd07ff05a8ec66"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"efcb7bb5d076f0431412c3e982c56a73d719d736","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                                                      \"VMFS\","},{"line_number":393,"context_line":"                                                      datastore_regex))"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    def test_allowed_ds_types(self):"},{"line_number":396,"context_line":"        self.assertEqual([\u0027VMFS\u0027, \u0027NFS\u0027],"},{"line_number":397,"context_line":"                         vm_util.ALLOWED_DATASTORE_TYPES)"},{"line_number":398,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_11177855","line":395,"updated":"2014-06-25 11:24:12.000000000","message":"remove this test","commit_id":"c48cf3501f904a38c9e84df7e783351a458107c2"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"c5d1a30e3449f3cdf22719acb5072dc826e5c82a","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                                                      \"VMFS\","},{"line_number":393,"context_line":"                                                      datastore_regex))"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    def test_allowed_ds_types(self):"},{"line_number":396,"context_line":"        self.assertEqual([\u0027VMFS\u0027, \u0027NFS\u0027],"},{"line_number":397,"context_line":"                         vm_util.ALLOWED_DATASTORE_TYPES)"},{"line_number":398,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_b6deb5d8","line":395,"in_reply_to":"1ae5cdf2_11177855","updated":"2014-06-25 13:09:59.000000000","message":"This test was added based on a review comment received in patchset 2.\nShould i still remove it.\nOne way to still implement the review comment received is to modify any one test case to pass NFS instead of VMFS.\nIs that fine","commit_id":"c48cf3501f904a38c9e84df7e783351a458107c2"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"be2d22d51c0906fb961ff08d1e9ea6b92981e839","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                                                      \"VMFS\","},{"line_number":393,"context_line":"                                                      datastore_regex))"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    def test_allowed_ds_types(self):"},{"line_number":396,"context_line":"        self.assertEqual([\u0027VMFS\u0027, \u0027NFS\u0027],"},{"line_number":397,"context_line":"                         vm_util.ALLOWED_DATASTORE_TYPES)"},{"line_number":398,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_4a3dc2dc","line":395,"in_reply_to":"1ae5cdf2_19815afb","updated":"2014-06-25 14:39:46.000000000","message":"Done","commit_id":"c48cf3501f904a38c9e84df7e783351a458107c2"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"cffaadd03d4880028d34ff8bd5e3aa35df2e23b8","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                                                      \"VMFS\","},{"line_number":393,"context_line":"                                                      datastore_regex))"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    def test_allowed_ds_types(self):"},{"line_number":396,"context_line":"        self.assertEqual([\u0027VMFS\u0027, \u0027NFS\u0027],"},{"line_number":397,"context_line":"                         vm_util.ALLOWED_DATASTORE_TYPES)"},{"line_number":398,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_19815afb","line":395,"in_reply_to":"1ae5cdf2_b6deb5d8","updated":"2014-06-25 13:24:10.000000000","message":"you can change test_is_datastore_valid to something like:\n\n  for ds_type in vm_util.ALLOWED_DATASTORE_TYPES:\n     self.assertTrue(self._test_is_datastore_valid(True, \u0027normal\u0027, ds_type))","commit_id":"c48cf3501f904a38c9e84df7e783351a458107c2"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d5a4e3d91c8a742a76634e9ecd7cadcb0c281e59","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"    return best_match"},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"def _datastore_summary_valid(propdict):"},{"line_number":1102,"context_line":"    \"\"\"Checks if a datastore is valid based on various criteria."},{"line_number":1103,"context_line":"        :param propdict: datastore summary dict"},{"line_number":1104,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_db0033ae","line":1101,"updated":"2014-06-15 16:59:57.000000000","message":"consider: _is_datastore_valid\n\nwould it be possible to write tests for this specific method.\ni think that would make the patch set complete. \n\nyou could also do:\n\nreturn (propdict.get(\u0027summary.accessible\u0027) and\n           propdict.get(\u0027summary.maintenanceMode\u0027) \u003d\u003d \u0027normal\u0027 and\n           propdict[\u0027summary.type\u0027] in ALLOWED_DATASTORE_TYPES)","commit_id":"8dab2d2111d9c191e69831aa555e9ea1323e18be"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"9911353ec00608ca068b61a277712394504c618e","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"    return best_match"},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"def _datastore_summary_valid(propdict):"},{"line_number":1102,"context_line":"    \"\"\"Checks if a datastore is valid based on various criteria."},{"line_number":1103,"context_line":"        :param propdict: datastore summary dict"},{"line_number":1104,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_9d0f7688","line":1101,"in_reply_to":"1ae5cdf2_db0033ae","updated":"2014-06-16 08:00:08.000000000","message":"Done","commit_id":"8dab2d2111d9c191e69831aa555e9ea1323e18be"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d5a4e3d91c8a742a76634e9ecd7cadcb0c281e59","unresolved":false,"context_lines":[{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"def _datastore_summary_valid(propdict):"},{"line_number":1102,"context_line":"    \"\"\"Checks if a datastore is valid based on various criteria."},{"line_number":1103,"context_line":"        :param propdict: datastore summary dict"},{"line_number":1104,"context_line":"    \"\"\""},{"line_number":1105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_7b5b9ff6","line":1102,"updated":"2014-06-15 16:59:57.000000000","message":"please add a new line here","commit_id":"8dab2d2111d9c191e69831aa555e9ea1323e18be"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"9911353ec00608ca068b61a277712394504c618e","unresolved":false,"context_lines":[{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"def _datastore_summary_valid(propdict):"},{"line_number":1102,"context_line":"    \"\"\"Checks if a datastore is valid based on various criteria."},{"line_number":1103,"context_line":"        :param propdict: datastore summary dict"},{"line_number":1104,"context_line":"    \"\"\""},{"line_number":1105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_bd235205","line":1102,"in_reply_to":"1ae5cdf2_7b5b9ff6","updated":"2014-06-16 08:00:08.000000000","message":"Done","commit_id":"8dab2d2111d9c191e69831aa555e9ea1323e18be"},{"author":{"_account_id":6498,"name":"Divakar Padiyar Nandavar","email":"divakar.padiyar-nandavar@hpe.com","username":"divakar-padiyar-nandavar"},"change_message_id":"c85f2a632f7ec61f4a0ed969e69bc0568dad0552","unresolved":false,"context_lines":[{"line_number":1108,"context_line":"    # maintenance mode."},{"line_number":1109,"context_line":"    # Local storage identifier vSphere doesn\u0027t support CIFS or"},{"line_number":1110,"context_line":"    # vfat for datastores, therefore filtered"},{"line_number":1111,"context_line":"    if (propdict.get(\u0027summary.accessible\u0027) and"},{"line_number":1112,"context_line":"        propdict.get(\u0027summary.maintenanceMode\u0027) \u003d\u003d \u0027normal\u0027 and"},{"line_number":1113,"context_line":"        propdict[\u0027summary.type\u0027] in ALLOWED_DATASTORE_TYPES):"},{"line_number":1114,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_f8117af8","line":1111,"updated":"2014-06-22 16:32:58.000000000","message":"You can avoid if else stmt here","commit_id":"781d46435ed45bd43c58a2033edd07ff05a8ec66"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"0181ec1fda8546d39ad8e9903584820c69b9a10d","unresolved":false,"context_lines":[{"line_number":1108,"context_line":"    # maintenance mode."},{"line_number":1109,"context_line":"    # Local storage identifier vSphere doesn\u0027t support CIFS or"},{"line_number":1110,"context_line":"    # vfat for datastores, therefore filtered"},{"line_number":1111,"context_line":"    if (propdict.get(\u0027summary.accessible\u0027) and"},{"line_number":1112,"context_line":"        propdict.get(\u0027summary.maintenanceMode\u0027) \u003d\u003d \u0027normal\u0027 and"},{"line_number":1113,"context_line":"        propdict[\u0027summary.type\u0027] in ALLOWED_DATASTORE_TYPES):"},{"line_number":1114,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_edfb4879","line":1111,"in_reply_to":"1ae5cdf2_2fe6314b","updated":"2014-06-24 07:03:32.000000000","message":"Done","commit_id":"781d46435ed45bd43c58a2033edd07ff05a8ec66"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"c71cbcb7ee6824c190ee1ec102e052d3dce98a05","unresolved":false,"context_lines":[{"line_number":1108,"context_line":"    # maintenance mode."},{"line_number":1109,"context_line":"    # Local storage identifier vSphere doesn\u0027t support CIFS or"},{"line_number":1110,"context_line":"    # vfat for datastores, therefore filtered"},{"line_number":1111,"context_line":"    if (propdict.get(\u0027summary.accessible\u0027) and"},{"line_number":1112,"context_line":"        propdict.get(\u0027summary.maintenanceMode\u0027) \u003d\u003d \u0027normal\u0027 and"},{"line_number":1113,"context_line":"        propdict[\u0027summary.type\u0027] in ALLOWED_DATASTORE_TYPES):"},{"line_number":1114,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_2fe6314b","line":1111,"in_reply_to":"1ae5cdf2_f8117af8","updated":"2014-06-23 07:35:37.000000000","message":"+1","commit_id":"781d46435ed45bd43c58a2033edd07ff05a8ec66"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"0181ec1fda8546d39ad8e9903584820c69b9a10d","unresolved":false,"context_lines":[{"line_number":1108,"context_line":"    # maintenance mode."},{"line_number":1109,"context_line":"    # Local storage identifier vSphere doesn\u0027t support CIFS or"},{"line_number":1110,"context_line":"    # vfat for datastores, therefore filtered"},{"line_number":1111,"context_line":"    if (propdict.get(\u0027summary.accessible\u0027) and"},{"line_number":1112,"context_line":"        propdict.get(\u0027summary.maintenanceMode\u0027) \u003d\u003d \u0027normal\u0027 and"},{"line_number":1113,"context_line":"        propdict[\u0027summary.type\u0027] in ALLOWED_DATASTORE_TYPES):"},{"line_number":1114,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_2dce105c","line":1111,"in_reply_to":"1ae5cdf2_f8117af8","updated":"2014-06-24 07:03:32.000000000","message":"Done","commit_id":"781d46435ed45bd43c58a2033edd07ff05a8ec66"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"c71cbcb7ee6824c190ee1ec102e052d3dce98a05","unresolved":false,"context_lines":[{"line_number":1168,"context_line":"        raise exception.DatastoreNotFound()"},{"line_number":1169,"context_line":""},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"def _get_allowed_datastores(data_stores, datastore_regex, allowed_types):"},{"line_number":1172,"context_line":"    allowed \u003d []"},{"line_number":1173,"context_line":"    for obj_content in data_stores.objects:"},{"line_number":1174,"context_line":"        # the propset attribute \"need not be set\" by returning API"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_af92419e","line":1171,"updated":"2014-06-23 07:35:37.000000000","message":"the allowed_types parameter is unused","commit_id":"781d46435ed45bd43c58a2033edd07ff05a8ec66"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"0181ec1fda8546d39ad8e9903584820c69b9a10d","unresolved":false,"context_lines":[{"line_number":1168,"context_line":"        raise exception.DatastoreNotFound()"},{"line_number":1169,"context_line":""},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"def _get_allowed_datastores(data_stores, datastore_regex, allowed_types):"},{"line_number":1172,"context_line":"    allowed \u003d []"},{"line_number":1173,"context_line":"    for obj_content in data_stores.objects:"},{"line_number":1174,"context_line":"        # the propset attribute \"need not be set\" by returning API"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_adc4e00e","line":1171,"in_reply_to":"1ae5cdf2_af92419e","updated":"2014-06-24 07:03:32.000000000","message":"Done","commit_id":"781d46435ed45bd43c58a2033edd07ff05a8ec66"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"217c19d01942f2cf46242c6bcd353fc09691f4d5","unresolved":false,"context_lines":[{"line_number":1048,"context_line":"    return best_match"},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":""},{"line_number":1051,"context_line":"def _is_datastore_valid(propdict):"},{"line_number":1052,"context_line":"    \"\"\"Checks if a datastore is valid based on various criteria."},{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"        :param propdict: datastore summary dict"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_745d4079","line":1051,"updated":"2014-06-24 08:03:45.000000000","message":"pass the datastore regex as a second argument and make the relevant checks in this new function; that way we can remove the duplicate code on lines 1038 and 1128","commit_id":"9e3dfaed04cb0b2e4000e9b4c460dcfa538cc57c"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"4185267a8de75d43617899279a98cf0cc71ae453","unresolved":false,"context_lines":[{"line_number":1048,"context_line":"    return best_match"},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":""},{"line_number":1051,"context_line":"def _is_datastore_valid(propdict):"},{"line_number":1052,"context_line":"    \"\"\"Checks if a datastore is valid based on various criteria."},{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"        :param propdict: datastore summary dict"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_86cfd056","line":1051,"in_reply_to":"1ae5cdf2_745d4079","updated":"2014-06-25 10:45:56.000000000","message":"Done","commit_id":"9e3dfaed04cb0b2e4000e9b4c460dcfa538cc57c"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"217c19d01942f2cf46242c6bcd353fc09691f4d5","unresolved":false,"context_lines":[{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":""},{"line_number":1051,"context_line":"def _is_datastore_valid(propdict):"},{"line_number":1052,"context_line":"    \"\"\"Checks if a datastore is valid based on various criteria."},{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"        :param propdict: datastore summary dict"},{"line_number":1055,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_94d80cf2","line":1052,"updated":"2014-06-24 08:03:45.000000000","message":"this docstring doesn\u0027t say anything useful; you should either rework or delete it","commit_id":"9e3dfaed04cb0b2e4000e9b4c460dcfa538cc57c"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"4185267a8de75d43617899279a98cf0cc71ae453","unresolved":false,"context_lines":[{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":""},{"line_number":1051,"context_line":"def _is_datastore_valid(propdict):"},{"line_number":1052,"context_line":"    \"\"\"Checks if a datastore is valid based on various criteria."},{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"        :param propdict: datastore summary dict"},{"line_number":1055,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_a6ca0c44","line":1052,"in_reply_to":"1ae5cdf2_94d80cf2","updated":"2014-06-25 10:45:56.000000000","message":"Done","commit_id":"9e3dfaed04cb0b2e4000e9b4c460dcfa538cc57c"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"efcb7bb5d076f0431412c3e982c56a73d719d736","unresolved":false,"context_lines":[{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":""},{"line_number":1048,"context_line":"def _is_datastore_valid(propdict, datastore_regex):"},{"line_number":1049,"context_line":"    \"\"\"Checks if a datastore is valid based on the following criteria."},{"line_number":1050,"context_line":"       Datastore is accessible"},{"line_number":1051,"context_line":"       Datastore is not in maintenance mode"},{"line_number":1052,"context_line":"       Datastore is of a supported disk type"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_91d9c8f6","line":1049,"updated":"2014-06-25 11:24:12.000000000","message":"nit: the line should end with a colon","commit_id":"c48cf3501f904a38c9e84df7e783351a458107c2"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"be2d22d51c0906fb961ff08d1e9ea6b92981e839","unresolved":false,"context_lines":[{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":""},{"line_number":1048,"context_line":"def _is_datastore_valid(propdict, datastore_regex):"},{"line_number":1049,"context_line":"    \"\"\"Checks if a datastore is valid based on the following criteria."},{"line_number":1050,"context_line":"       Datastore is accessible"},{"line_number":1051,"context_line":"       Datastore is not in maintenance mode"},{"line_number":1052,"context_line":"       Datastore is of a supported disk type"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_6a235ebe","line":1049,"in_reply_to":"1ae5cdf2_91d9c8f6","updated":"2014-06-25 14:39:46.000000000","message":"Done","commit_id":"c48cf3501f904a38c9e84df7e783351a458107c2"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"efcb7bb5d076f0431412c3e982c56a73d719d736","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"        :param datastore_regex : Regex to match the name of a datastore."},{"line_number":1057,"context_line":"    \"\"\""},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"    # Ignore datastore if it is not accessible and if in"},{"line_number":1060,"context_line":"    # maintenance mode."},{"line_number":1061,"context_line":"    # Local storage identifier vSphere doesn\u0027t support CIFS or"},{"line_number":1062,"context_line":"    # vfat for datastores, therefore filtered"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_918708b6","line":1059,"updated":"2014-06-25 11:24:12.000000000","message":"nit: you can delete this line and the next one","commit_id":"c48cf3501f904a38c9e84df7e783351a458107c2"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"be2d22d51c0906fb961ff08d1e9ea6b92981e839","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"        :param datastore_regex : Regex to match the name of a datastore."},{"line_number":1057,"context_line":"    \"\"\""},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"    # Ignore datastore if it is not accessible and if in"},{"line_number":1060,"context_line":"    # maintenance mode."},{"line_number":1061,"context_line":"    # Local storage identifier vSphere doesn\u0027t support CIFS or"},{"line_number":1062,"context_line":"    # vfat for datastores, therefore filtered"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_aa2d66aa","line":1059,"in_reply_to":"1ae5cdf2_918708b6","updated":"2014-06-25 14:39:46.000000000","message":"Done","commit_id":"c48cf3501f904a38c9e84df7e783351a458107c2"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b25bbabca98ba020c592b5f0b93793a269cc1f78","unresolved":false,"context_lines":[{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"        :param propdict: datastore summary dict"},{"line_number":1056,"context_line":"        :param datastore_regex : Regex to match the name of a datastore."},{"line_number":1057,"context_line":"    \"\"\""},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"    # Local storage identifier vSphere doesn\u0027t support CIFS or"},{"line_number":1060,"context_line":"    # vfat for datastores, therefore filtered"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_75c45492","line":1057,"updated":"2014-07-01 17:07:28.000000000","message":"nit: please align the above docstring like so:\n\n \"\"\"Checks if a datastore is valid based on certain criteria.\n\n Criteria:\n  - datastore is accessible\n  - datastore is not in maintenance mode\n  - datastore is of a supported disk type\n  - datastore matches a supplied regex (optional)\n\n :param propdict: datastore summary dict\n :param datastore_regex: Regex to match the name of a datastore\n \"\"\"","commit_id":"6e9110f92af050a5c3e9c8474dc538feca5243db"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"7992908b1b92e7937a5a9cc23095fe4b2b6a5208","unresolved":false,"context_lines":[{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"        :param propdict: datastore summary dict"},{"line_number":1056,"context_line":"        :param datastore_regex : Regex to match the name of a datastore."},{"line_number":1057,"context_line":"    \"\"\""},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"    # Local storage identifier vSphere doesn\u0027t support CIFS or"},{"line_number":1060,"context_line":"    # vfat for datastores, therefore filtered"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_5cc83822","line":1057,"in_reply_to":"baada198_75c45492","updated":"2014-07-02 13:54:59.000000000","message":"Done","commit_id":"6e9110f92af050a5c3e9c8474dc538feca5243db"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"a67ef79cda7133690028b4dfb2997c39441c2d48","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"    # Local storage identifier vSphere doesn\u0027t support CIFS or"},{"line_number":1054,"context_line":"    # vfat for datastores, therefore filtered"},{"line_number":1055,"context_line":"    return (propdict.get(\u0027summary.accessible\u0027) and"},{"line_number":1056,"context_line":"            propdict.get(\u0027summary.maintenanceMode\u0027) \u003d\u003d \u0027normal\u0027 and"},{"line_number":1057,"context_line":"            propdict[\u0027summary.type\u0027] in ALLOWED_DATASTORE_TYPES and"},{"line_number":1058,"context_line":"            (datastore_regex is None or"},{"line_number":1059,"context_line":"             datastore_regex.match(propdict[\u0027summary.name\u0027])))"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_42bb8de4","line":1056,"updated":"2014-07-14 09:11:12.000000000","message":"As per vSphere API, maintenanceMode need not be set.","commit_id":"b15eb00e255b3c05aa014ce7801aa51560e66906"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"13c0315243fe7ecb3e8e00538fc0710bc1c73874","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"    # Local storage identifier vSphere doesn\u0027t support CIFS or"},{"line_number":1054,"context_line":"    # vfat for datastores, therefore filtered"},{"line_number":1055,"context_line":"    return (propdict.get(\u0027summary.accessible\u0027) and"},{"line_number":1056,"context_line":"            propdict.get(\u0027summary.maintenanceMode\u0027) \u003d\u003d \u0027normal\u0027 and"},{"line_number":1057,"context_line":"            propdict[\u0027summary.type\u0027] in ALLOWED_DATASTORE_TYPES and"},{"line_number":1058,"context_line":"            (datastore_regex is None or"},{"line_number":1059,"context_line":"             datastore_regex.match(propdict[\u0027summary.name\u0027])))"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_47c1b14c","line":1056,"in_reply_to":"baada198_42bb8de4","updated":"2014-07-15 08:51:43.000000000","message":"maintenanceMode is set in DatastoreSummary object only in vCenters version above 5.0\n\nVersions below 5.0 need not have maintenanceMode.\nHence also checking for None","commit_id":"b15eb00e255b3c05aa014ce7801aa51560e66906"}]}