)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"76e602f23598435a5d73fb485002d32bae457c05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1ef4919b_98f91c09","updated":"2026-09-01 08:19:57.000000000","message":"lets add those cleanups and then I\u0027m OK to land this","commit_id":"37f7a513453dd57862033ace92db8643cdb822f7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"76e602f23598435a5d73fb485002d32bae457c05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5fada297_46ae7121","updated":"2026-09-01 08:19:57.000000000","message":"lets add those cleanups and then I\u0027m OK to land this.","commit_id":"37f7a513453dd57862033ace92db8643cdb822f7"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"a13ab67f445771eb78ab562f2e2f07b5fbfe5b25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cba145f2_3db4e932","updated":"2026-09-01 11:47:52.000000000","message":"recheck, job timed out","commit_id":"0cb807513b39a59af68e0e9b920adda1d1986599"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a68d410837770e05be61226c9bc4ef0b2195a19d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fdf6070b_ab58d636","updated":"2026-09-02 14:19:20.000000000","message":"sorry this seems to be hanging top of https://review.opendev.org/c/openstack/nova/+/1003266 probably due to interfering with graceful shutdown.","commit_id":"0cb807513b39a59af68e0e9b920adda1d1986599"}],"nova/tests/functional/compute/test_init_host.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"76e602f23598435a5d73fb485002d32bae457c05","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        source_host \u003d server[\u0027OS-EXT-SRV-ATTR:host\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        migrate_started \u003d threading.Event()"},{"line_number":48,"context_line":"        stop \u003d threading.Event()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        def fake_migrate_disk_and_power_off(*args, **kwargs):"},{"line_number":51,"context_line":"            migrate_started.set()"}],"source_content_type":"text/x-python","patch_set":2,"id":"a3685c59_112eb7b9","line":48,"updated":"2026-09-01 08:19:57.000000000","message":"please add a \n```\nself.addCleanup(migrate_started.set)\nself.addCleanup(stop.set)\n```\nso that if the test case fails for some reason the fake_migrate_disk_and_power_off will not hang","commit_id":"37f7a513453dd57862033ace92db8643cdb822f7"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"96a0fecac1d6a7985acf1cf36aff3955fc2ab581","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        source_host \u003d server[\u0027OS-EXT-SRV-ATTR:host\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        migrate_started \u003d threading.Event()"},{"line_number":48,"context_line":"        stop \u003d threading.Event()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        def fake_migrate_disk_and_power_off(*args, **kwargs):"},{"line_number":51,"context_line":"            migrate_started.set()"}],"source_content_type":"text/x-python","patch_set":2,"id":"c2e28f71_ec0feb59","line":48,"in_reply_to":"a3685c59_112eb7b9","updated":"2026-09-01 09:33:38.000000000","message":"Done","commit_id":"37f7a513453dd57862033ace92db8643cdb822f7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5a2c25a07f092a3f6a28efa9750b7f31f3914854","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            # resize_instance runs on the compute-alt RPC topic and a graceful"},{"line_number":61,"context_line":"            # service stop waits for it to finish. Simulate a crash by stopping"},{"line_number":62,"context_line":"            # RPC servers without waiting for the in-flight migration handler."},{"line_number":63,"context_line":"            rpc_server.stop()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        source_driver \u003d self.computes[source_host].manager.driver"},{"line_number":66,"context_line":"        with mock.patch.object(source_driver, \u0027migrate_disk_and_power_off\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f5c3dd47_9bd7fc5f","line":63,"updated":"2026-09-02 14:36:14.000000000","message":"I\u0027m wondering what to do with this as this is the point that messes up the test run top of the other patch. If I remove this then the test passes it just extremely slow as, as you noted the service.stop in the restart call will wait for the graceful shutdown to time out before it continues. Which is sort of understandable. We don\u0027t have a way to really crash the service we make it hang and try to paper over it. So maybe this paper over is something that we need to enhance to avoid the graceful shutdown slowing us down. \n\nCan we change restart_compute_service to allow triggering a service restart in way that it ignores graceful shutdown? Either by setting the timeout to 0 *on the compute that is being restarted* but not on the rest, or by selectively mocking parts of the graceful shutdown for *on the compute that is being restarted* but not on the rest?","commit_id":"0cb807513b39a59af68e0e9b920adda1d1986599"}]}