)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c1114af6ddee5a01d12d12d60d619c23582176d3","unresolved":true,"context_lines":[{"line_number":17,"context_line":"without waiting so the restart models a crash rather than a graceful"},{"line_number":18,"context_line":"shutdown."},{"line_number":19,"context_line":"Remove the test from threading_functional_test_excludes.txt now that"},{"line_number":20,"context_line":"it passes under native threading."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I592392139d8990ff747ed5c37850a6e985ad6d7b"},{"line_number":23,"context_line":"Signed-off-by: Ashish Gupta \u003cashigupt@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"33029d5a_d5244c26","line":20,"range":{"start_line":20,"start_character":32,"end_line":20,"end_character":33},"updated":"2026-09-05 04:39:53.000000000","message":"please add Closes-Bug: #2166439\n\nI reported a bug for that, let\u0027s close it as part of this change- https://bugs.launchpad.net/nova/+bug/2166439","commit_id":"0cb807513b39a59af68e0e9b920adda1d1986599"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"43e1516ef07c5cea5e6f60240a42e92e538bb6e6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"without waiting so the restart models a crash rather than a graceful"},{"line_number":18,"context_line":"shutdown."},{"line_number":19,"context_line":"Remove the test from threading_functional_test_excludes.txt now that"},{"line_number":20,"context_line":"it passes under native threading."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I592392139d8990ff747ed5c37850a6e985ad6d7b"},{"line_number":23,"context_line":"Signed-off-by: Ashish Gupta \u003cashigupt@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9e002313_6a0a4c69","line":20,"range":{"start_line":20,"start_character":32,"end_line":20,"end_character":33},"in_reply_to":"33029d5a_d5244c26","updated":"2026-09-16 21:37:02.000000000","message":"Done","commit_id":"0cb807513b39a59af68e0e9b920adda1d1986599"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aacbbed2a8893f9669f59780b8abe49cf8364e17","unresolved":true,"context_lines":[{"line_number":15,"context_line":"restart from the main test thread after migrate_disk_and_power_off"},{"line_number":16,"context_line":"starts, and patch Service._shutdown_rpc_server to stop RPC servers"},{"line_number":17,"context_line":"without waiting so the restart models a crash rather than a graceful"},{"line_number":18,"context_line":"shutdown."},{"line_number":19,"context_line":"Remove the test from threading_functional_test_excludes.txt now that"},{"line_number":20,"context_line":"it passes under native threading."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"306eef71_080eba24","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":9},"updated":"2026-09-16 03:05:22.000000000","message":"also mention that, we need to set the manager_shutdown_timeout low for this test only as we want to unblock the thread doing shutdown.","commit_id":"8350bfe4dd5eedef15d3948f8bc803f4cf546c8a"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"43e1516ef07c5cea5e6f60240a42e92e538bb6e6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"restart from the main test thread after migrate_disk_and_power_off"},{"line_number":16,"context_line":"starts, and patch Service._shutdown_rpc_server to stop RPC servers"},{"line_number":17,"context_line":"without waiting so the restart models a crash rather than a graceful"},{"line_number":18,"context_line":"shutdown."},{"line_number":19,"context_line":"Remove the test from threading_functional_test_excludes.txt now that"},{"line_number":20,"context_line":"it passes under native threading."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f566632_11959d5f","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":9},"in_reply_to":"306eef71_080eba24","updated":"2026-09-16 21:37:02.000000000","message":"Done","commit_id":"8350bfe4dd5eedef15d3948f8bc803f4cf546c8a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"76e602f23598435a5d73fb485002d32bae457c05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1ef4919b_98f91c09","updated":"2026-09-01 08:19:57.000000000","message":"lets add those cleanups and then I\u0027m OK to land this","commit_id":"37f7a513453dd57862033ace92db8643cdb822f7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"76e602f23598435a5d73fb485002d32bae457c05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5fada297_46ae7121","updated":"2026-09-01 08:19:57.000000000","message":"lets add those cleanups and then I\u0027m OK to land this.","commit_id":"37f7a513453dd57862033ace92db8643cdb822f7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c1114af6ddee5a01d12d12d60d619c23582176d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7b8d6ef8_249f4a44","updated":"2026-09-05 04:39:53.000000000","message":"after attemping other solution, i think this is good options to fix it","commit_id":"0cb807513b39a59af68e0e9b920adda1d1986599"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"a13ab67f445771eb78ab562f2e2f07b5fbfe5b25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cba145f2_3db4e932","updated":"2026-09-01 11:47:52.000000000","message":"recheck, job timed out","commit_id":"0cb807513b39a59af68e0e9b920adda1d1986599"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a68d410837770e05be61226c9bc4ef0b2195a19d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fdf6070b_ab58d636","updated":"2026-09-02 14:19:20.000000000","message":"sorry this seems to be hanging top of https://review.opendev.org/c/openstack/nova/+/1003266 probably due to interfering with graceful shutdown.","commit_id":"0cb807513b39a59af68e0e9b920adda1d1986599"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"aacbbed2a8893f9669f59780b8abe49cf8364e17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0d251ea3_9f20889a","updated":"2026-09-16 03:05:22.000000000","message":"please fix the pep8 error. otherwise I am good on this fix.\n\nAbout fix. test is passing in this change as well as in default manager_shutdown_timeout (as we are limiting this test to use 3 sec manager_shutdown_timeout ) change\n\nhttps://review.opendev.org/c/openstack/nova/+/1003266\n\nThreading mode:\n\n{3} nova.tests.functional.compute.test_init_host.ComputeManagerInitHostTestCase.test_migrate_disk_and_power_off_crash_finish_revert_migration [6.357070s] ... ok\n- https://zuul.opendev.org/t/openstack/build/11b0cb26c8dd480aa05b1c9a168e1a7d/log/job-output.txt#12009\n\nas well as eventlet mode:\n\nhttps://zuul.opendev.org/t/openstack/build/5a037cc714a94a09913c084f2a4ae3ca/log/job-output.txt#11826","commit_id":"8350bfe4dd5eedef15d3948f8bc803f4cf546c8a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"04155b0a0ed485c649c30fa30f519cbe2ad674eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"40ecb6f7_c2fb0a2e","updated":"2026-10-03 03:41:11.000000000","message":"recheck ssh timeout in multi-cell job","commit_id":"1d6b3e078e0857ee54ed49bad3eb278eb5caec46"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8e9322894b921e515b399f69af37ae002ccd2c44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ad8799b8_b719850e","updated":"2026-10-02 09:52:28.000000000","message":"thanks looks good to me. I did some local runs with CPU limits and it seems to be solid.","commit_id":"1d6b3e078e0857ee54ed49bad3eb278eb5caec46"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a642ad3cb6e1fc5147f70ee536eb086e6232b83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6ecd3283_f11ddcc4","updated":"2026-10-02 16:10:16.000000000","message":"thanks, lgtm, nice work Ashish","commit_id":"1d6b3e078e0857ee54ed49bad3eb278eb5caec46"}],"nova/tests/functional/compute/test_init_host.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"76e602f23598435a5d73fb485002d32bae457c05","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        source_host \u003d server[\u0027OS-EXT-SRV-ATTR:host\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        migrate_started \u003d threading.Event()"},{"line_number":48,"context_line":"        stop \u003d threading.Event()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        def fake_migrate_disk_and_power_off(*args, **kwargs):"},{"line_number":51,"context_line":"            migrate_started.set()"}],"source_content_type":"text/x-python","patch_set":2,"id":"a3685c59_112eb7b9","line":48,"updated":"2026-09-01 08:19:57.000000000","message":"please add a \n```\nself.addCleanup(migrate_started.set)\nself.addCleanup(stop.set)\n```\nso that if the test case fails for some reason the fake_migrate_disk_and_power_off will not hang","commit_id":"37f7a513453dd57862033ace92db8643cdb822f7"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"96a0fecac1d6a7985acf1cf36aff3955fc2ab581","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        source_host \u003d server[\u0027OS-EXT-SRV-ATTR:host\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        migrate_started \u003d threading.Event()"},{"line_number":48,"context_line":"        stop \u003d threading.Event()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        def fake_migrate_disk_and_power_off(*args, **kwargs):"},{"line_number":51,"context_line":"            migrate_started.set()"}],"source_content_type":"text/x-python","patch_set":2,"id":"c2e28f71_ec0feb59","line":48,"in_reply_to":"a3685c59_112eb7b9","updated":"2026-09-01 09:33:38.000000000","message":"Done","commit_id":"37f7a513453dd57862033ace92db8643cdb822f7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5a2c25a07f092a3f6a28efa9750b7f31f3914854","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            # resize_instance runs on the compute-alt RPC topic and a graceful"},{"line_number":61,"context_line":"            # service stop waits for it to finish. Simulate a crash by stopping"},{"line_number":62,"context_line":"            # RPC servers without waiting for the in-flight migration handler."},{"line_number":63,"context_line":"            rpc_server.stop()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        source_driver \u003d self.computes[source_host].manager.driver"},{"line_number":66,"context_line":"        with mock.patch.object(source_driver, \u0027migrate_disk_and_power_off\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f5c3dd47_9bd7fc5f","line":63,"updated":"2026-09-02 14:36:14.000000000","message":"I\u0027m wondering what to do with this as this is the point that messes up the test run top of the other patch. If I remove this then the test passes it just extremely slow as, as you noted the service.stop in the restart call will wait for the graceful shutdown to time out before it continues. Which is sort of understandable. We don\u0027t have a way to really crash the service we make it hang and try to paper over it. So maybe this paper over is something that we need to enhance to avoid the graceful shutdown slowing us down. \n\nCan we change restart_compute_service to allow triggering a service restart in way that it ignores graceful shutdown? Either by setting the timeout to 0 *on the compute that is being restarted* but not on the rest, or by selectively mocking parts of the graceful shutdown for *on the compute that is being restarted* but not on the rest?","commit_id":"0cb807513b39a59af68e0e9b920adda1d1986599"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8e9322894b921e515b399f69af37ae002ccd2c44","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            # resize_instance runs on the compute-alt RPC topic and a graceful"},{"line_number":61,"context_line":"            # service stop waits for it to finish. Simulate a crash by stopping"},{"line_number":62,"context_line":"            # RPC servers without waiting for the in-flight migration handler."},{"line_number":63,"context_line":"            rpc_server.stop()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        source_driver \u003d self.computes[source_host].manager.driver"},{"line_number":66,"context_line":"        with mock.patch.object(source_driver, \u0027migrate_disk_and_power_off\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1dfeb3fd_f9df96bd","line":63,"in_reply_to":"0ddafad6_27e7ebc2","updated":"2026-10-02 09:52:28.000000000","message":"Done","commit_id":"0cb807513b39a59af68e0e9b920adda1d1986599"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6b45cc3e98f469723d7378b092ac65eefca7cc9c","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            # resize_instance runs on the compute-alt RPC topic and a graceful"},{"line_number":61,"context_line":"            # service stop waits for it to finish. Simulate a crash by stopping"},{"line_number":62,"context_line":"            # RPC servers without waiting for the in-flight migration handler."},{"line_number":63,"context_line":"            rpc_server.stop()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        source_driver \u003d self.computes[source_host].manager.driver"},{"line_number":66,"context_line":"        with mock.patch.object(source_driver, \u0027migrate_disk_and_power_off\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7431a6e1_d49446bd","line":63,"in_reply_to":"1eae88b2_3e5c2be1","updated":"2026-09-09 03:24:56.000000000","message":"@gibizer@gmail.com no, manager_shutdown_timeout\u003d0 will not fix the issue (I tried it in https://review.opendev.org/c/openstack/nova/+/1003910). We do not need to change manager_shutdown_timeout for this test and let it be the same as default (https://review.opendev.org/c/openstack/nova/+/1003266/7/nova/tests/fixtures/conf.py)\n\nHere problem is that we are slepping on RPC thread and shutdown will wait for RPC thread to finish so deadlock. so once we mock the RPC server wait() (by _crash_shutdown_rpc_server) then it does not block the rpcserver.wait() and let test to proceed correctly. Which is correct way to proceed in this test case.\n\nlet me test this fix in 1003266 also so that we know it will run fine with manager_shutdown_timeout default (160 sec).","commit_id":"0cb807513b39a59af68e0e9b920adda1d1986599"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"064aacbcd66e133e39bd2b148d77374cf3e7b34e","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            # resize_instance runs on the compute-alt RPC topic and a graceful"},{"line_number":61,"context_line":"            # service stop waits for it to finish. Simulate a crash by stopping"},{"line_number":62,"context_line":"            # RPC servers without waiting for the in-flight migration handler."},{"line_number":63,"context_line":"            rpc_server.stop()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        source_driver \u003d self.computes[source_host].manager.driver"},{"line_number":66,"context_line":"        with mock.patch.object(source_driver, \u0027migrate_disk_and_power_off\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1eae88b2_3e5c2be1","line":63,"in_reply_to":"2f29f823_3381a959","updated":"2026-09-08 11:25:51.000000000","message":"Is it solving the problem? Sure it runs fast when manager_shutdown_timeout\u003d0 but when it is set to e.g. 30 the test waits almost the whole shutdown timeout that to me suggests that we have still some deadlocks or never finishing tasks hidden in the test case. @gmaan.os14@gmail.com do you suggest to force manager_shutdown_timeout\u003d0 for this test case while we will not do that for the rest of the test cases in https://review.opendev.org/c/openstack/nova/+/1003266/7/nova/tests/fixtures/conf.py ?","commit_id":"0cb807513b39a59af68e0e9b920adda1d1986599"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5683b552c37264f294d506d6470f52de34632fc0","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            # resize_instance runs on the compute-alt RPC topic and a graceful"},{"line_number":61,"context_line":"            # service stop waits for it to finish. Simulate a crash by stopping"},{"line_number":62,"context_line":"            # RPC servers without waiting for the in-flight migration handler."},{"line_number":63,"context_line":"            rpc_server.stop()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        source_driver \u003d self.computes[source_host].manager.driver"},{"line_number":66,"context_line":"        with mock.patch.object(source_driver, \u0027migrate_disk_and_power_off\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"0ddafad6_27e7ebc2","line":63,"in_reply_to":"7431a6e1_d49446bd","updated":"2026-09-11 20:40:43.000000000","message":"In my testing with default manager_shutdown_timeout, test still hang for long. and breaking the manager graceful shutdown works fine.\n\n@ashigupt@redhat.com if you can make manager_shutdown_timeout to something lower then it will work fine for 1003910 change also\n\n        # This test perform the restart_service from the same\n        # thread runniiiing cold migratiiion operation. Graceful shutdown\n        # will take its full time as it find the cold migration task is\n        # in-progress so reduce the graceful_shutdown_timeout so that\n        # service can berestarted fast.\n        self.flags(graceful_shutdown_timeout\u003d3)","commit_id":"0cb807513b39a59af68e0e9b920adda1d1986599"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c1114af6ddee5a01d12d12d60d619c23582176d3","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            # resize_instance runs on the compute-alt RPC topic and a graceful"},{"line_number":61,"context_line":"            # service stop waits for it to finish. Simulate a crash by stopping"},{"line_number":62,"context_line":"            # RPC servers without waiting for the in-flight migration handler."},{"line_number":63,"context_line":"            rpc_server.stop()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        source_driver \u003d self.computes[source_host].manager.driver"},{"line_number":66,"context_line":"        with mock.patch.object(source_driver, \u0027migrate_disk_and_power_off\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"2f29f823_3381a959","line":63,"in_reply_to":"e6cf6d59_f52d6f61","updated":"2026-09-05 04:39:53.000000000","message":"I think we should go with this solution.\n\nIn other change (https://review.opendev.org/c/openstack/nova/+/1003910), I tried all other options and nothing worked:\n\n1. graceful_shutdown_timeout\u003d0 or 3sec:\n This does not work as test call directly stop on service and it does not go through the oslo.service signal handler and so it does not trigger the SIGALRM when timeout happens.\n\n2. mock the stop() itself:\n This did not work as start_service() has mocked the stop() method and it override the mock here and does not actually mock the stop in this test.\n \nTwo things hanging here:\n- service.stop(): rpc thread wait(): because service stop is called in RPC thread itself whihc is waiting with long sleep of 1000000 sec. mocking the rpc.wait via _crash_shutdown_rpc_server() solve it and stop() return quickly.\n\n- the long sleep of 1000000 whihc is now handled by the event.\n\nThis is fixing the actual root cause of the issue, IMO we can go with this.","commit_id":"0cb807513b39a59af68e0e9b920adda1d1986599"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e8af6be5d44a14d6532b64bb3f334a63317b5651","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            # resize_instance runs on the compute-alt RPC topic and a graceful"},{"line_number":61,"context_line":"            # service stop waits for it to finish. Simulate a crash by stopping"},{"line_number":62,"context_line":"            # RPC servers without waiting for the in-flight migration handler."},{"line_number":63,"context_line":"            rpc_server.stop()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        source_driver \u003d self.computes[source_host].manager.driver"},{"line_number":66,"context_line":"        with mock.patch.object(source_driver, \u0027migrate_disk_and_power_off\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"e6cf6d59_f52d6f61","line":63,"in_reply_to":"f5c3dd47_9bd7fc5f","updated":"2026-09-04 15:34:30.000000000","message":"yes, there is deadlock happening here and graceful shutdown takes full time to timeout. This tests does not consider that case and fail if service is not strated soon and instance task_state is no None in 5 sec of polling. I also debugged this issue as part of failure happening in https://review.opendev.org/c/openstack/nova/+/1003266 and reported the details in bug: https://bugs.launchpad.net/nova/+bug/2166439\n\nI am trying to solve it with proper timeout which should fix this and later we can reduce the manager_shutdown_timeout to lower value for this test so that the execution time will be reduced.","commit_id":"0cb807513b39a59af68e0e9b920adda1d1986599"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"77f51f236732c2dd1fbc7f57021578950b98ab4b","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # This test restarts compute while cold migration is blocked in the"},{"line_number":48,"context_line":"        # mock. Graceful shutdown sees that migration as in-progress and would"},{"line_number":49,"context_line":"        # wait for the full manager_shutdown_timeout from the global test config."},{"line_number":50,"context_line":"        # Use a low graceful_shutdown_timeout so restart completes quickly; we"},{"line_number":51,"context_line":"        # are simulating crash recovery, not graceful shutdown."},{"line_number":52,"context_line":"        self.flags(graceful_shutdown_timeout\u003d3)"}],"source_content_type":"text/x-python","patch_set":5,"id":"2e14d599_ba610324","line":49,"updated":"2026-09-14 21:22:42.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"8350bfe4dd5eedef15d3948f8bc803f4cf546c8a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8e9322894b921e515b399f69af37ae002ccd2c44","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # wait for the full manager_shutdown_timeout from the global test"},{"line_number":50,"context_line":"        # config. Use a low graceful_shutdown_timeout so restart completes"},{"line_number":51,"context_line":"        # quickly; we are simulating crash recovery, not graceful shutdown."},{"line_number":52,"context_line":"        self.flags(graceful_shutdown_timeout\u003d3)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        migrate_started \u003d threading.Event()"},{"line_number":55,"context_line":"        stop \u003d threading.Event()"}],"source_content_type":"text/x-python","patch_set":6,"id":"e851f561_1b6234fe","line":52,"updated":"2026-10-02 09:52:28.000000000","message":"+1 thanks for the excellent comment why we doing this","commit_id":"1d6b3e078e0857ee54ed49bad3eb278eb5caec46"}]}