)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"278ce4eb8260b812d76c7190beeb53d02399c00a","unresolved":true,"context_lines":[{"line_number":11,"context_line":"almost always want the client immediately after creating it. Instead, do"},{"line_number":12,"context_line":"the version check *after* we create the client. This obviates the need"},{"line_number":13,"context_line":"for custom code to do version checking, resulting in a nice LoC drop and"},{"line_number":14,"context_line":"a general simplification of the code ahead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Do note that we now only do version checking for 3.x microversions here."},{"line_number":17,"context_line":"Cinder v2 has been removed since Cinder 19.0.0 (Xena) and was deprecated"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"decda14d_e31bc852","line":14,"updated":"2026-10-09 18:08:59.000000000","message":"i can only speculate we may have done that to skip creating a session/token\ngiven we cna check the microverion endpoint without auth. i think its fien to do it in wither order.","commit_id":"17891d21aeac3d37bad823f9cd34ed91c8c785fd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7d5c9ecf6323f2588a5238b25b8391670b51d175","unresolved":false,"context_lines":[{"line_number":11,"context_line":"almost always want the client immediately after creating it. Instead, do"},{"line_number":12,"context_line":"the version check *after* we create the client. This obviates the need"},{"line_number":13,"context_line":"for custom code to do version checking, resulting in a nice LoC drop and"},{"line_number":14,"context_line":"a general simplification of the code ahead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Do note that we now only do version checking for 3.x microversions here."},{"line_number":17,"context_line":"Cinder v2 has been removed since Cinder 19.0.0 (Xena) and was deprecated"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f11c0633_28e750ae","line":14,"in_reply_to":"decda14d_e31bc852","updated":"2026-10-09 19:31:06.000000000","message":"I\u0027d say it was more that we previously needed to behave differently under v2 and v3. That\u0027s no longer the case.","commit_id":"17891d21aeac3d37bad823f9cd34ed91c8c785fd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"278ce4eb8260b812d76c7190beeb53d02399c00a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"55020793_a5282ca0","updated":"2026-10-09 18:08:59.000000000","message":"can you pull these into a single topic\nalso do we have a tracker for this work? at the very least it would be nice ot have a release note later in the series","commit_id":"17891d21aeac3d37bad823f9cd34ed91c8c785fd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cf7209d58da8b18dbd5fa7121cae3f25a8b8a6cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6bb43cbb_73057793","in_reply_to":"55020793_a5282ca0","updated":"2026-10-09 19:32:09.000000000","message":"I reused the old topic from the ironicclient -\u003e SDK migration. The blueprint has long since been completed but at least it\u0027s something to filter on.\n\nI\u0027ll tack a release note RE: the new options onto the end.","commit_id":"17891d21aeac3d37bad823f9cd34ed91c8c785fd"}],"nova/cmd/status.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"278ce4eb8260b812d76c7190beeb53d02399c00a","unresolved":true,"context_lines":[{"line_number":234,"context_line":"            return upgradecheck.Result(upgradecheck.Code.SUCCESS)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        try:"},{"line_number":237,"context_line":"            # TODO(mriedem): Eventually use get_ksa_adapter here when it"},{"line_number":238,"context_line":"            # supports cinder."},{"line_number":239,"context_line":"            cinder.cinderclient("},{"line_number":240,"context_line":"                nova_context.get_admin_context(), MIN_CINDER_MICROVERSION)"},{"line_number":241,"context_line":"        except exception.CinderAPIVersionNotAvailable:"}],"source_content_type":"text/x-python","patch_set":2,"id":"97f88e59_ab2dd696","line":238,"range":{"start_line":237,"start_character":10,"end_line":238,"end_character":29},"updated":"2026-10-09 18:08:59.000000000","message":"i guess this is also not current anymore and will be remvoed in this serise\nsince we are skiping right past ksa and going to the sdk","commit_id":"17891d21aeac3d37bad823f9cd34ed91c8c785fd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7d5c9ecf6323f2588a5238b25b8391670b51d175","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            return upgradecheck.Result(upgradecheck.Code.SUCCESS)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        try:"},{"line_number":237,"context_line":"            # TODO(mriedem): Eventually use get_ksa_adapter here when it"},{"line_number":238,"context_line":"            # supports cinder."},{"line_number":239,"context_line":"            cinder.cinderclient("},{"line_number":240,"context_line":"                nova_context.get_admin_context(), MIN_CINDER_MICROVERSION)"},{"line_number":241,"context_line":"        except exception.CinderAPIVersionNotAvailable:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a75cf5c_325fa0d7","line":238,"range":{"start_line":237,"start_character":10,"end_line":238,"end_character":29},"in_reply_to":"97f88e59_ab2dd696","updated":"2026-10-09 19:31:06.000000000","message":"I suspect mriedem was talking about migrating to SDK. iirc all the SDK users in here (ironic, neutron, cyborg etc.) use `get_ksa_adapter` to configure the `Connection`.\n\nIn any case, we will remove this before long.","commit_id":"17891d21aeac3d37bad823f9cd34ed91c8c785fd"}],"nova/volume/cinder.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"278ce4eb8260b812d76c7190beeb53d02399c00a","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    return service_auth.get_service_user_token_auth_plugin("},{"line_number":76,"context_line":"            context, user_auth\u003duser_auth)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# NOTE(efried): Bug #1752152"},{"line_number":80,"context_line":"# This method is copied/adapted from cinderclient.client.get_server_version so"},{"line_number":81,"context_line":"# we can use Session.get rather than a raw requests.get to retrieve the"}],"source_content_type":"text/x-python","patch_set":2,"id":"f439076c_ad8f81f8","side":"PARENT","line":78,"updated":"2026-10-09 18:08:59.000000000","message":"i guess we dont need this anymore since we are delgating more of the logic here to cinder clinet directly and using the resutling client ot do the version check.","commit_id":"a865282809c81e3c919ac4013556e5fe7db02daf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7d5c9ecf6323f2588a5238b25b8391670b51d175","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    return service_auth.get_service_user_token_auth_plugin("},{"line_number":76,"context_line":"            context, user_auth\u003duser_auth)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# NOTE(efried): Bug #1752152"},{"line_number":80,"context_line":"# This method is copied/adapted from cinderclient.client.get_server_version so"},{"line_number":81,"context_line":"# we can use Session.get rather than a raw requests.get to retrieve the"}],"source_content_type":"text/x-python","patch_set":2,"id":"8b706b51_13462a31","side":"PARENT","line":78,"in_reply_to":"f439076c_ad8f81f8","updated":"2026-10-09 19:31:06.000000000","message":"Yeah, we now call cinderclient with a specific v3.x (micro)version which means we can forget about v2 and everything related to that (including old version docs)","commit_id":"a865282809c81e3c919ac4013556e5fe7db02daf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"13b57414d7a086fdd8076c1f075fbfa51f728d95","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        global_request_id\u003dcontext.global_id,"},{"line_number":124,"context_line":"        **service_parameters)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    if microversion is not None:"},{"line_number":127,"context_line":"        if not skip_version_check:"},{"line_number":128,"context_line":"            requested \u003d cinder_api_versions.APIVersion(microversion)"},{"line_number":129,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9d21e10f_c6cdf55f","line":126,"range":{"start_line":126,"start_character":7,"end_line":126,"end_character":19},"updated":"2026-10-08 15:02:59.000000000","message":"I\u0027m wondering if we want to cache the discovered api versions at some point to reduce API calls for version check. However I noticed that cinderclient does not provide public interface to obtain lower bound (while it does for upper bound) so we can revisit this later when we replace this by osc.","commit_id":"17891d21aeac3d37bad823f9cd34ed91c8c785fd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"083165a5bc7e6fa981f6bdf6cc32d42ea86826fe","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        global_request_id\u003dcontext.global_id,"},{"line_number":124,"context_line":"        **service_parameters)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    if microversion is not None:"},{"line_number":127,"context_line":"        if not skip_version_check:"},{"line_number":128,"context_line":"            requested \u003d cinder_api_versions.APIVersion(microversion)"},{"line_number":129,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"c7ab3e89_1b5e99aa","line":126,"range":{"start_line":126,"start_character":7,"end_line":126,"end_character":19},"in_reply_to":"77a67980_6df0ba9d","updated":"2026-10-09 18:11:42.000000000","message":"Yes. I meant to mention sdk, not osc...","commit_id":"17891d21aeac3d37bad823f9cd34ed91c8c785fd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"278ce4eb8260b812d76c7190beeb53d02399c00a","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        global_request_id\u003dcontext.global_id,"},{"line_number":124,"context_line":"        **service_parameters)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    if microversion is not None:"},{"line_number":127,"context_line":"        if not skip_version_check:"},{"line_number":128,"context_line":"            requested \u003d cinder_api_versions.APIVersion(microversion)"},{"line_number":129,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"77a67980_6df0ba9d","line":126,"range":{"start_line":126,"start_character":7,"end_line":126,"end_character":19},"in_reply_to":"9d21e10f_c6cdf55f","updated":"2026-10-09 18:08:59.000000000","message":"well we are not going to use osc here\n\ni think you mean when we replace this with the sdk.","commit_id":"17891d21aeac3d37bad823f9cd34ed91c8c785fd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"278ce4eb8260b812d76c7190beeb53d02399c00a","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            if negotiated \u003c requested:"},{"line_number":136,"context_line":"                raise exception.CinderAPIVersionNotAvailable("},{"line_number":137,"context_line":"                    version\u003dmicroversion)"},{"line_number":138,"context_line":"        client.api_version \u003d cinder_api_versions.APIVersion(microversion)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    return client"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9d603e13_bce455bf","line":138,"updated":"2026-10-09 18:08:59.000000000","message":"this looks familar to me we do something similar in the novaclient and other python-service clisnt i think i.e. constcuting APIVersion object and using those ot do the comparison to prerly inderpere micoversion and do a touple comparson fo the part instead of incorrectly comparing them as floats or strings.","commit_id":"17891d21aeac3d37bad823f9cd34ed91c8c785fd"}]}