)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d91179e4e793081b3251449f716c0e11598102ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"18491e45_65bdbad4","updated":"2026-09-18 16:03:24.000000000","message":"it sovle the logging issue on functional job \n\nhttps://zuul.opendev.org/t/openstack/build/0dc6d4b3569640f8b7e3f1fa50e7000b/log/job-output.txt#2299","commit_id":"196a745a5a8b4b5ed65d82a11ba355c0717c7bb2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"706c55f1c34501c75437a87de99ff7eb93aa60c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f9618d17_80b44572","updated":"2026-09-18 16:05:44.000000000","message":"recheck timeout in threading job not sure if it is due to reording of log captruing feature, will come back on that with 2nd run","commit_id":"196a745a5a8b4b5ed65d82a11ba355c0717c7bb2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"362595d7be98513d794e569c7a8eade19a5364a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"748827f3_905f6837","updated":"2026-09-18 20:12:22.000000000","message":"timeout in thrading job not related but it usually hang due to executros waiting for all tasks to finish. Dan, gibi, and I were chating in IRC about converting the hang to failure which seems better option here.","commit_id":"196a745a5a8b4b5ed65d82a11ba355c0717c7bb2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"59f3d2c25d28818f8d026ed56c323043c255dfd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1eaeab9f_880d89b8","updated":"2026-09-24 13:34:27.000000000","message":"recheck try to get a green run","commit_id":"118c31c414f3e6b05ff865ceb077895df3deac9c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9c507e402ea751936259fa9aab12623fb0805469","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fbc9a29a_1f2c8e88","updated":"2026-09-24 22:58:24.000000000","message":"as timeout is reproduced here, let\u0027s check/debug log here","commit_id":"f3b137bb3be820bc3d78bc04c80ec50b86e08eeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9bb8dd552eb98e0a9fafbae0e04d27a232f492e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a2b8a677_d9fede7f","updated":"2026-09-30 01:16:45.000000000","message":"recheck DB deadlock fixed in https://review.opendev.org/c/openstack/nova/+/984480 so let\u0027s see if that was root cause or something else going on here","commit_id":"f3b137bb3be820bc3d78bc04c80ec50b86e08eeb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5be88174f41c433c710cfc5cdb40cc82d46be9c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2d05fc13_dbf9b68f","updated":"2026-09-30 06:31:24.000000000","message":"recheck another run to see if timeout is still happening","commit_id":"cdce48f4565fa7231da6436b205f03961abbb1f6"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f894689e2d60c521eb7be2342bc24968b2ad8c5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"73416138_6a9b56e9","updated":"2026-10-08 15:17:56.000000000","message":"I wondered how we could stop these logs ... thanks!","commit_id":"83a0dc3ec2298a8f16037c8623bdd5a4cba264b3"}],"nova/test.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"cab36062b7c322f5a12bea32096aac7839394461","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        # executor pool shutdown in IsolatedExecutorFixture\u0027s cleanup."},{"line_number":210,"context_line":"        # If any of the fixture needs to log something in cleanup steps or"},{"line_number":211,"context_line":"        # before then we need to re-order the StandardLogging fixture."},{"line_number":212,"context_line":"        self.stdlog \u003d self.useFixture(nova_fixtures.StandardLogging())"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        self.useFixture(nova_fixtures.OpenStackSDKFixture())"},{"line_number":215,"context_line":"        self.useFixture(nova_fixtures.IsolatedExecutorFixture(self.id()))"}],"source_content_type":"text/x-python","patch_set":4,"id":"cca9f3da_0377005d","line":212,"updated":"2026-09-24 13:35:13.000000000","message":"cool. The job run shows that no logs are leaked from passing test cases.","commit_id":"118c31c414f3e6b05ff865ceb077895df3deac9c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a0fd4e2810371edb0e7289e03b45aa120d49a251","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        # executor pool shutdown in IsolatedExecutorFixture\u0027s cleanup."},{"line_number":210,"context_line":"        # If any of the fixture needs to log something in cleanup steps or"},{"line_number":211,"context_line":"        # before then we need to re-order the StandardLogging fixture."},{"line_number":212,"context_line":"        self.stdlog \u003d self.useFixture(nova_fixtures.StandardLogging())"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        self.useFixture(nova_fixtures.OpenStackSDKFixture())"},{"line_number":215,"context_line":"        self.useFixture(nova_fixtures.IsolatedExecutorFixture(self.id()))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3e631726_0772ee45","line":212,"in_reply_to":"cca9f3da_0377005d","updated":"2026-09-24 22:57:45.000000000","message":"yeah this solve that but strange is nova-tox-functional-py313-threading is timoeut in this change which is on top of other change to add failure in tests instead of hanging. Logging re-ordering does not seems to cause timeout, its all strange happening somewhere. I need to debug it more deep, WIP till then.","commit_id":"118c31c414f3e6b05ff865ceb077895df3deac9c"}],"nova/tests/fixtures/nova.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"498871ffbaf189d7c39b8577f59a705325912efe","unresolved":true,"context_lines":[{"line_number":1352,"context_line":"        # reset_all_executors call shutdown(wait\u003dTrue) for all executors."},{"line_number":1353,"context_line":"        # log\u003dFalse as this is a per test cleanup, so each executor shutdown"},{"line_number":1354,"context_line":"        # logs on every test is not needed."},{"line_number":1355,"context_line":"        thread_pool_factory.reset_all_executors(log\u003dFalse)"},{"line_number":1356,"context_line":"        for executor in executors:"},{"line_number":1357,"context_line":"            # NOTE(gibi): we cannot rely on utils.concurrency_mode_threading"},{"line_number":1358,"context_line":"            # as that might have been mocked during the test when the executor"}],"source_content_type":"text/x-python","patch_set":2,"id":"acfd52bf_6ee996eb","line":1355,"updated":"2026-09-07 14:23:27.000000000","message":"the strange thing that these logs are not captured by the normal log capturing in the functional test. Can we change the log capturing somehow?","commit_id":"56f4d81c669c045a50c4ad411c6c5f21085ec5f7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"cab36062b7c322f5a12bea32096aac7839394461","unresolved":false,"context_lines":[{"line_number":1352,"context_line":"        # reset_all_executors call shutdown(wait\u003dTrue) for all executors."},{"line_number":1353,"context_line":"        # log\u003dFalse as this is a per test cleanup, so each executor shutdown"},{"line_number":1354,"context_line":"        # logs on every test is not needed."},{"line_number":1355,"context_line":"        thread_pool_factory.reset_all_executors(log\u003dFalse)"},{"line_number":1356,"context_line":"        for executor in executors:"},{"line_number":1357,"context_line":"            # NOTE(gibi): we cannot rely on utils.concurrency_mode_threading"},{"line_number":1358,"context_line":"            # as that might have been mocked during the test when the executor"}],"source_content_type":"text/x-python","patch_set":2,"id":"2d72c81e_bec1e3ad","line":1355,"in_reply_to":"85632b12_3dd54a98","updated":"2026-09-24 13:35:13.000000000","message":"Done","commit_id":"56f4d81c669c045a50c4ad411c6c5f21085ec5f7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"68021779de3414cb99753ce15343b6491f7889fe","unresolved":true,"context_lines":[{"line_number":1352,"context_line":"        # reset_all_executors call shutdown(wait\u003dTrue) for all executors."},{"line_number":1353,"context_line":"        # log\u003dFalse as this is a per test cleanup, so each executor shutdown"},{"line_number":1354,"context_line":"        # logs on every test is not needed."},{"line_number":1355,"context_line":"        thread_pool_factory.reset_all_executors(log\u003dFalse)"},{"line_number":1356,"context_line":"        for executor in executors:"},{"line_number":1357,"context_line":"            # NOTE(gibi): we cannot rely on utils.concurrency_mode_threading"},{"line_number":1358,"context_line":"            # as that might have been mocked during the test when the executor"}],"source_content_type":"text/x-python","patch_set":2,"id":"85632b12_3dd54a98","line":1355,"in_reply_to":"a5687914_90960295","updated":"2026-09-17 20:57:27.000000000","message":"I get it now, it\u0027s about the ordering of fixtures. The StandardLogging fixture is done after the IsolatedExecutorFixture, which logs these thread pool logs - https://github.com/openstack/nova/blob/94de0576ca02e0668233bedfbe7e18b87316c708/nova/test.py#L208-L213\n\nI can move StandardLogging before IsolatedExecutorFixture and with re-ordering I cannot see any issue as none of the fixture IsolatedExecutorFixture or other which will be moved after StandardLogging  needs to log anything during cleanup steps. if they do in future then we can change. \n\nlet me propose that instead of code change and see if that works fine.","commit_id":"56f4d81c669c045a50c4ad411c6c5f21085ec5f7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f4056816071d569e3e68b4fce5ab8c2b76cb64f1","unresolved":true,"context_lines":[{"line_number":1352,"context_line":"        # reset_all_executors call shutdown(wait\u003dTrue) for all executors."},{"line_number":1353,"context_line":"        # log\u003dFalse as this is a per test cleanup, so each executor shutdown"},{"line_number":1354,"context_line":"        # logs on every test is not needed."},{"line_number":1355,"context_line":"        thread_pool_factory.reset_all_executors(log\u003dFalse)"},{"line_number":1356,"context_line":"        for executor in executors:"},{"line_number":1357,"context_line":"            # NOTE(gibi): we cannot rely on utils.concurrency_mode_threading"},{"line_number":1358,"context_line":"            # as that might have been mocked during the test when the executor"}],"source_content_type":"text/x-python","patch_set":2,"id":"a5687914_90960295","line":1355,"in_reply_to":"acfd52bf_6ee996eb","updated":"2026-09-17 17:34:04.000000000","message":"you mean when running locally? bcz in job we can see them, for example: https://zuul.opendev.org/t/openstack/build/d4b25f3eac0d45b78f7825b07e503cbf/log/job-output.txt#5331-5349","commit_id":"56f4d81c669c045a50c4ad411c6c5f21085ec5f7"}]}