)]}'
{"nova/tests/virt/libvirt/test_driver.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"548ec72ecc88e2500dcaebcaf944d27c38be1ee5","unresolved":false,"context_lines":[{"line_number":4927,"context_line":"        with contextlib.nested("},{"line_number":4928,"context_line":"            mock.patch.object(utils, \u0027execute\u0027),"},{"line_number":4929,"context_line":"            mock.patch.object(conn, \u0027get_info\u0027),"},{"line_number":4930,"context_line":"            mock.patch.object(conn, \u0027_create_domain_and_network\u0027)):"},{"line_number":4931,"context_line":"            self.assertRaises(exception.InvalidBDMFormat, conn._create_image,"},{"line_number":4932,"context_line":"                              context, instance, disk_info[\u0027mapping\u0027],"},{"line_number":4933,"context_line":"                              block_device_info\u003dblock_device_info)"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_12eaf973","line":4930,"updated":"2014-07-18 12:04:18.000000000","message":"indentation here could use one more tab...","commit_id":"b1cde33175bc555e1af822894e8c3f981fbb8ef6"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"548ec72ecc88e2500dcaebcaf944d27c38be1ee5","unresolved":false,"context_lines":[{"line_number":6947,"context_line":"                                               ephemerals, swap,"},{"line_number":6948,"context_line":"                                               block_device_mapping)"},{"line_number":6949,"context_line":""},{"line_number":6950,"context_line":"    def test_is_supported_fs_format(self):"},{"line_number":6951,"context_line":"        supported_fs \u003d [disk.FS_FORMAT_EXT2, disk.FS_FORMAT_EXT3,"},{"line_number":6952,"context_line":"                        disk.FS_FORMAT_EXT4, disk.FS_FORMAT_XFS]"},{"line_number":6953,"context_line":"        conn \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_b295cde5","line":6950,"updated":"2014-07-18 12:04:18.000000000","message":"Not sure how useful this test is...","commit_id":"b1cde33175bc555e1af822894e8c3f981fbb8ef6"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4f0dbfba51483f6e9366aa1d72311fae457d7594","unresolved":false,"context_lines":[{"line_number":2666,"context_line":"            specified_fs \u003d eph.get(\u0027guest_format\u0027)"},{"line_number":2667,"context_line":"            if specified_fs and not self.is_supported_fs_format(specified_fs):"},{"line_number":2668,"context_line":"                msg \u003d _(\"%s format is not supported\") % specified_fs"},{"line_number":2669,"context_line":"                raise exception.InvalidBDMFormat(details\u003dmsg)"},{"line_number":2670,"context_line":""},{"line_number":2671,"context_line":"            fn \u003d functools.partial(self._create_ephemeral,"},{"line_number":2672,"context_line":"                                   fs_label\u003d\u0027ephemeral%d\u0027 % idx,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_658010f8","line":2669,"updated":"2014-06-24 21:03:48.000000000","message":"I feel like the above check should be in the base nova.compute.manager layer or even above that in the nova.compute.api layer, calling in to the driver layer as appropriate to validate the input from the user before ever getting down into the driver\u0027s spawn() method. Otherwise, every single driver is going to be implementing the above 4 lines of code.","commit_id":"27334e482d6384783e3d5fe90aeaeb402f1e5518"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f7b1d4020ed77af6bb6d0cd71aa069f126fad8eb","unresolved":false,"context_lines":[{"line_number":2666,"context_line":"            specified_fs \u003d eph.get(\u0027guest_format\u0027)"},{"line_number":2667,"context_line":"            if specified_fs and not self.is_supported_fs_format(specified_fs):"},{"line_number":2668,"context_line":"                msg \u003d _(\"%s format is not supported\") % specified_fs"},{"line_number":2669,"context_line":"                raise exception.InvalidBDMFormat(details\u003dmsg)"},{"line_number":2670,"context_line":""},{"line_number":2671,"context_line":"            fn \u003d functools.partial(self._create_ephemeral,"},{"line_number":2672,"context_line":"                                   fs_label\u003d\u0027ephemeral%d\u0027 % idx,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_7793545c","line":2669,"in_reply_to":"1ae5cdf2_658010f8","updated":"2014-06-25 08:22:25.000000000","message":"I think it should be moved to compute layer\nbut not API layer because for every compute \nis_supported_fs_format is different\n\nthanks :)","commit_id":"27334e482d6384783e3d5fe90aeaeb402f1e5518"}]}