)]}'
{"nova/service.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3fa8abe13239ce57d5c937ce13d1b4a1e34fea9","unresolved":true,"context_lines":[{"line_number":438,"context_line":"            return False"},{"line_number":439,"context_line":"        return True"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def _run_manager_graceful_shutdown(self):"},{"line_number":442,"context_line":"        timeout \u003d self._get_manager_shutdown_timeout()"},{"line_number":443,"context_line":"        # NOTE(gmaan): manager\u0027s graceful_shutdown does two things 1. wait for"},{"line_number":444,"context_line":"        # in-progress tasks 2. cleanup_host. First one is controlled with"},{"line_number":445,"context_line":"        # timeout but latter one is sync call to drivers cleanup_host which"},{"line_number":446,"context_line":"        # can hang the shutdown so we need to run manager\u0027s graceful_shutdown"},{"line_number":447,"context_line":"        # in a thread with timeout so that we do not hang the overall shutdown."},{"line_number":448,"context_line":"        return self._run_with_timeout("},{"line_number":449,"context_line":"            \u0027manager graceful shutdown\u0027,"},{"line_number":450,"context_line":"            functools.partial(self.manager.graceful_shutdown, timeout),"},{"line_number":451,"context_line":"            timeout)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def stop(self):"},{"line_number":454,"context_line":"        \"\"\"stop the service and clean up.\"\"\""},{"line_number":455,"context_line":"        LOG.info(\u0027%s service graceful shutdown started.\u0027, self.binary)"}],"source_content_type":"text/x-python","patch_set":1,"id":"965e8e28_6e4abf19","line":452,"range":{"start_line":441,"start_character":0,"end_line":452,"end_character":0},"updated":"2026-10-08 20:56:52.000000000","message":"I think we donot need to refactor this, i am commenting it to the next change where it is used in executors shutdown","commit_id":"0e1e42fe1607c1ab1715c516d6a9a5e562f11205"},{"author":{"_account_id":39509,"name":"Lucas HENRY","display_name":"Lucas HENRY","email":"lucas.henry@ovhcloud.com","username":"polyedre"},"change_message_id":"10c7867320f3969bac474e684df8a310951ac895","unresolved":false,"context_lines":[{"line_number":449,"context_line":"            \u0027manager graceful shutdown\u0027,"},{"line_number":450,"context_line":"            functools.partial(self.manager.graceful_shutdown, timeout),"},{"line_number":451,"context_line":"            timeout)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def stop(self):"},{"line_number":454,"context_line":"        \"\"\"stop the service and clean up.\"\"\""},{"line_number":455,"context_line":"        LOG.info(\u0027%s service graceful shutdown started.\u0027, self.binary)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c1018b01_57376bce","line":452,"in_reply_to":"965e8e28_6e4abf19","updated":"2026-10-09 12:25:14.000000000","message":"Done: dropped, the executor shutdown has no timer in 1009164 PS2.","commit_id":"0e1e42fe1607c1ab1715c516d6a9a5e562f11205"}]}
