)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a9e21c40a396829c750a585fbe4e1f2cb6132705","unresolved":true,"context_lines":[{"line_number":16,"context_line":"drained, and only if the manager graceful shutdown, thus the driver"},{"line_number":17,"context_line":"cleanup_host() whose delayed executors still need the main executor,"},{"line_number":18,"context_line":"finished."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The live migrations still queued are now cancelled by"},{"line_number":21,"context_line":"_cleanup_live_migrations_in_pool() instead of being started by the"},{"line_number":22,"context_line":"executor shutdown."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #2169804"},{"line_number":25,"context_line":"Co-Authored-By: Claude Opus 5.5 \u003cnoreply@anthropic.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7bddab62_f247d97e","line":22,"range":{"start_line":19,"start_character":0,"end_line":22,"end_character":18},"updated":"2026-10-09 02:40:03.000000000","message":"this will be the issue, imagine if live migration message was picked up later by the RPC then it will keep populate the live migration list. we need to make sure live migration executor is shutdown before we cleanup live migration from pool.","commit_id":"21825458437a7fc3030ac61f5a2739e2fa949858"},{"author":{"_account_id":39509,"name":"Lucas HENRY","display_name":"Lucas HENRY","email":"lucas.henry@ovhcloud.com","username":"polyedre"},"change_message_id":"fc780150b024fd33731d522ee0a0b594d36a8221","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The live migrations still queued are now cancelled by"},{"line_number":21,"context_line":"_cleanup_live_migrations_in_pool() instead of being started by the"},{"line_number":22,"context_line":"executor shutdown."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #2169804"},{"line_number":25,"context_line":"Co-Authored-By: Claude Opus 5.5 \u003cnoreply@anthropic.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"794b0122_8994a4f3","line":22,"in_reply_to":"7bddab62_f247d97e","updated":"2026-10-09 12:25:13.000000000","message":"Done in 1009164 PS2: shutdown_executor(LIVE_MIGRATION) before _cleanup_live_migrations_in_pool().","commit_id":"21825458437a7fc3030ac61f5a2739e2fa949858"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a9e21c40a396829c750a585fbe4e1f2cb6132705","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"742bbf9b_2761c975","updated":"2026-10-09 02:40:03.000000000","message":"let\u0027s merge this in https://review.opendev.org/c/openstack/nova/+/1009164 only so that we can backport a single change","commit_id":"21825458437a7fc3030ac61f5a2739e2fa949858"}],"nova/compute/manager.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a9e21c40a396829c750a585fbe4e1f2cb6132705","unresolved":true,"context_lines":[{"line_number":1770,"context_line":"        self.driver.register_event_listener(None)"},{"line_number":1771,"context_line":"        self.instance_events.cancel_all_events()"},{"line_number":1772,"context_line":"        self.driver.cleanup_host(host\u003dself.host)"},{"line_number":1773,"context_line":"        # At this stage, manager has done with all the tasks/cleanup"},{"line_number":1774,"context_line":"        # and safe to shutdown all the executors so that no new things"},{"line_number":1775,"context_line":"        # can run now."},{"line_number":1776,"context_line":"        # shutdown_all_executors is done after self.driver.cleanup_host"},{"line_number":1777,"context_line":"        # as that shutdown(wait\u003dTrue) the delayed_executors which will"},{"line_number":1778,"context_line":"        # need the main executor to be up to finish the in-progress things."},{"line_number":1779,"context_line":"        try:"},{"line_number":1780,"context_line":"            thread_pool_factory.shutdown_all_executors()"},{"line_number":1781,"context_line":"        except Exception:"},{"line_number":1782,"context_line":"            LOG.exception("},{"line_number":1783,"context_line":"                \u0027%s service failed to shutdown all thread pool executors.\u0027,"},{"line_number":1784,"context_line":"                self.service_name)"},{"line_number":1785,"context_line":""},{"line_number":1786,"context_line":"        self._cleanup_live_migrations_in_pool()"},{"line_number":1787,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"91cfc6cb_f5ee4e88","side":"PARENT","line":1784,"range":{"start_line":1773,"start_character":0,"end_line":1784,"end_character":34},"updated":"2026-10-09 02:40:03.000000000","message":"moving all other executor in service.stop() is good but we need to shutdown the live migration executor before cleanup so that no new migration is accepted during this cleanup.\n\nFor that, we need to provide a interface from thread_pool_factory to shutdown the single executor something like shutdown_executor(executror_type) and use here to shutdown only live migration executor here.","commit_id":"9a02d39edd99a72e7909662dacacc1be137bac42"},{"author":{"_account_id":39509,"name":"Lucas HENRY","display_name":"Lucas HENRY","email":"lucas.henry@ovhcloud.com","username":"polyedre"},"change_message_id":"fc780150b024fd33731d522ee0a0b594d36a8221","unresolved":false,"context_lines":[{"line_number":1781,"context_line":"            if future.cancel():"},{"line_number":1782,"context_line":"                self._set_migration_status(migration, \u0027cancelled\u0027)"},{"line_number":1783,"context_line":"                LOG.info(\u0027Successfully cancelled queued live migration.\u0027,"},{"line_number":1784,"context_line":"                         instance_uuid\u003dmigration.instance_uuid)"},{"line_number":1785,"context_line":"            else:"},{"line_number":1786,"context_line":"                LOG.warning(\u0027Unable to cancel live migration.\u0027,"},{"line_number":1787,"context_line":"                            instance_uuid\u003dmigration.instance_uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"2df9e869_0f177608","line":1784,"in_reply_to":"91cfc6cb_f5ee4e88","updated":"2026-10-09 12:25:13.000000000","message":"Done in 1009164 PS2: shutdown_executor(LIVE_MIGRATION) before _cleanup_live_migrations_in_pool().","commit_id":"21825458437a7fc3030ac61f5a2739e2fa949858"}]}