)]}'
{"nova/tests/compute/test_compute.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"cbe2a34e040f8b37028f2c4e7e9f0f50798b7385","unresolved":false,"context_lines":[{"line_number":9111,"context_line":""},{"line_number":9112,"context_line":"        db.instance_destroy(self.context, instance[\u0027uuid\u0027])"},{"line_number":9113,"context_line":""},{"line_number":9114,"context_line":"    def test_error_evacuate(self):"},{"line_number":9115,"context_line":"        params \u003d {\u0027vm_state\u0027: vm_states.ERROR}"},{"line_number":9116,"context_line":"        instance \u003d jsonutils.to_primitive(self._create_fake_instance("},{"line_number":9117,"context_line":"                                          params, services\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_d1ea079f","line":9114,"updated":"2014-06-20 04:30:37.000000000","message":"The part, which is different from test_evacuate, is only\n\n +        params \u003d {\u0027vm_state\u0027: vm_states.ERROR}\n          instance \u003d jsonutils.to_primitive(self._create_fake_instance(\n -                                          services\u003dTrue))\n +                                          params, services\u003dTrue))\n\nSo how about renaming test_evacuate to _check_evacuate or something and adding a new argument \"params\" like:\n\n -    def test_evacuate(self):\n +    def _check_evacuate(self, instance_params):\n          instance \u003d jsonutils.to_primitive(self._create_fake_instance(\n -                                          services\u003dTrue))\n +                                          instance_params, services\u003dTrue))\n\nand each test passes instance_params?\n\n  def test_evacuate(self):\n      self._check_evacuate({})\n\n  def test_error_evacuate(self):\n      self._check_evacuate({\u0027vm_state\u0027: vm_states.ERROR})\n\nWe can avoid copy\u0026paste code, and the difference is clear.","commit_id":"dff141aef3ad574c3b27d163ef7d70e3183f8d1b"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"dd0e317cbe49933d550c142145bb89146503830f","unresolved":false,"context_lines":[{"line_number":9111,"context_line":""},{"line_number":9112,"context_line":"        db.instance_destroy(self.context, instance[\u0027uuid\u0027])"},{"line_number":9113,"context_line":""},{"line_number":9114,"context_line":"    def test_error_evacuate(self):"},{"line_number":9115,"context_line":"        params \u003d {\u0027vm_state\u0027: vm_states.ERROR}"},{"line_number":9116,"context_line":"        instance \u003d jsonutils.to_primitive(self._create_fake_instance("},{"line_number":9117,"context_line":"                                          params, services\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_ed9c7a10","line":9114,"in_reply_to":"1ae5cdf2_d1ea079f","updated":"2014-06-20 13:41:51.000000000","message":"makes sense, will do","commit_id":"dff141aef3ad574c3b27d163ef7d70e3183f8d1b"}]}