)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5113785492037a6d1fc7393517928e57a1ad4a77","unresolved":true,"context_lines":[{"line_number":11,"context_line":"the injected rescue password but never attached to the rescued"},{"line_number":12,"context_line":"instance. The original, unmodified disk.config is attached instead,"},{"line_number":13,"context_line":"so the rescue password never reaches the guest. This affects both"},{"line_number":14,"context_line":"image-backed and volume-backed (BFV) instances."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"_get_stable_device_rescue_mapping() now replaces the disk.config"},{"line_number":17,"context_line":"entry with disk.config.rescue in the mapping, and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"240862f9_c1905935","line":14,"updated":"2026-10-13 12:31:20.000000000","message":"sound like a valid bug to me.\n\nwith that said for a cloud with the metadta service deployed,\ndepenign on the contnet of the rescue image i would still expect it to get the password/ssh key form the metadata service\n\nbut yes if it primarily used the config drive it would have the original instance drvive.\n\nthis typicly would not be an issue as resuce is typiclly used by the same user that created so the origanl ssh key woudl have worked so this is easy to miss","commit_id":"04c7efa778fe2f97899191899d9a75387d57dbeb"},{"author":{"_account_id":39168,"name":"Nathan","display_name":"Nathan","email":"nathan.malo@ovhcloud.com","username":"na-te"},"change_message_id":"feeced2f4374f0ec03f84438b95b43d472082750","unresolved":true,"context_lines":[{"line_number":11,"context_line":"the injected rescue password but never attached to the rescued"},{"line_number":12,"context_line":"instance. The original, unmodified disk.config is attached instead,"},{"line_number":13,"context_line":"so the rescue password never reaches the guest. This affects both"},{"line_number":14,"context_line":"image-backed and volume-backed (BFV) instances."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"_get_stable_device_rescue_mapping() now replaces the disk.config"},{"line_number":17,"context_line":"entry with disk.config.rescue in the mapping, and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6dde6c55_0125ee59","line":14,"in_reply_to":"240862f9_c1905935","updated":"2026-10-13 15:32:51.000000000","message":"Yes I agree.\n\nFrom a security perspective, personally, I prefer to have the rescue password attached to the VM via configdrive instead of the metadata service that is more widely accessible across tenants.","commit_id":"04c7efa778fe2f97899191899d9a75387d57dbeb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":39168,"name":"Nathan","display_name":"Nathan","email":"nathan.malo@ovhcloud.com","username":"na-te"},"change_message_id":"1518d94d1f1eb8f0c2ecbfed4ccfed9258350873","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d068710e_4ca1232c","updated":"2026-10-13 08:57:52.000000000","message":"Dear nova-core leaders,\n\nCan you review my patch that would fix the use of device.config generated for rescue when using stable device rescue ?\n\nIt would be much appreciated !\n\nThanks for your help !","commit_id":"04c7efa778fe2f97899191899d9a75387d57dbeb"},{"author":{"_account_id":39168,"name":"Nathan","display_name":"Nathan","email":"nathan.malo@ovhcloud.com","username":"na-te"},"change_message_id":"21be9937963685922f1e98fd502ccc7775b30ce0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3405e4f5_9a3fabb9","updated":"2026-10-09 06:04:08.000000000","message":"recheck","commit_id":"04c7efa778fe2f97899191899d9a75387d57dbeb"},{"author":{"_account_id":39168,"name":"Nathan","display_name":"Nathan","email":"nathan.malo@ovhcloud.com","username":"na-te"},"change_message_id":"66574ed3dd547a4eea71e3ccfca48bf037a33462","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bb2e340a_2dd4ddc1","updated":"2026-10-08 14:40:40.000000000","message":"recheck","commit_id":"04c7efa778fe2f97899191899d9a75387d57dbeb"},{"author":{"_account_id":39168,"name":"Nathan","display_name":"Nathan","email":"nathan.malo@ovhcloud.com","username":"na-te"},"change_message_id":"d07272bd1696f54596efd1fda636acad91c6cee5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fd6b6bf9_3555094a","updated":"2026-10-09 08:32:59.000000000","message":"recheck","commit_id":"04c7efa778fe2f97899191899d9a75387d57dbeb"},{"author":{"_account_id":39168,"name":"Nathan","display_name":"Nathan","email":"nathan.malo@ovhcloud.com","username":"na-te"},"change_message_id":"feeced2f4374f0ec03f84438b95b43d472082750","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"725f7cd3_4341060e","updated":"2026-10-13 15:32:51.000000000","message":"recheck","commit_id":"d2da6d3c0b64530010f66dfed4892d5a49783d75"}],"nova/tests/unit/virt/libvirt/test_blockinfo.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5113785492037a6d1fc7393517928e57a1ad4a77","unresolved":true,"context_lines":[{"line_number":513,"context_line":"        }"},{"line_number":514,"context_line":"        self._test_get_disk_mapping_stable_rescue("},{"line_number":515,"context_line":"            rescue_props, expected, block_info)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"    def test_get_disk_mapping_stable_rescue_virtio_disk_with_everything(self):"},{"line_number":518,"context_line":"        \"\"\"Assert the disk mapping when rescuing using a virtio disk with"},{"line_number":519,"context_line":"           volumes, ephemerals and swap also attached to the instance."}],"source_content_type":"text/x-python","patch_set":1,"id":"97d33a61_20b393a5","line":516,"updated":"2026-10-13 12:31:20.000000000","message":"i wonder if we should also test with setting the force config drive config option rather then just the enableing config drive on the original instance as an api parmater.\n\nhttps://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.force_config_drive","commit_id":"04c7efa778fe2f97899191899d9a75387d57dbeb"},{"author":{"_account_id":39168,"name":"Nathan","display_name":"Nathan","email":"nathan.malo@ovhcloud.com","username":"na-te"},"change_message_id":"feeced2f4374f0ec03f84438b95b43d472082750","unresolved":true,"context_lines":[{"line_number":513,"context_line":"        }"},{"line_number":514,"context_line":"        self._test_get_disk_mapping_stable_rescue("},{"line_number":515,"context_line":"            rescue_props, expected, block_info)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"    def test_get_disk_mapping_stable_rescue_virtio_disk_with_everything(self):"},{"line_number":518,"context_line":"        \"\"\"Assert the disk mapping when rescuing using a virtio disk with"},{"line_number":519,"context_line":"           volumes, ephemerals and swap also attached to the instance."}],"source_content_type":"text/x-python","patch_set":1,"id":"c4d40f67_38567c80","line":516,"in_reply_to":"97d33a61_20b393a5","updated":"2026-10-13 15:32:51.000000000","message":"On the openstack deployments I manage, we have force_config_drive set to true.\nI uploaded new tests to support the force_config_drive scenario.","commit_id":"04c7efa778fe2f97899191899d9a75387d57dbeb"}]}