)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5779a7d0e506fa5884744cf3f67c442686f8dbdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1924cc54_24791ee2","updated":"2026-10-27 01:57:16.000000000","message":"We usually do manager-side changes to drop in the same change, but separating is also ok.","commit_id":"747ea959ed5600c197f92df7abb3fb8d27bde7b4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c334f32a3b987b389bd681d98bfcbdcf55e19ea4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"02769f9b_d9a81403","updated":"2026-10-29 19:59:47.000000000","message":"Thanks, Lucas, for the updates. lgtm.","commit_id":"66117736fd03ea59aba83ad1e267988d89a54bc4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"15ec29830efbdcd7b5d9381c820e71bd47a9202c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"86a63621_23c86837","updated":"2026-10-31 09:16:27.000000000","message":"Two nits inline. We can address those in a follow-up though.","commit_id":"66117736fd03ea59aba83ad1e267988d89a54bc4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"451031c840a1019993612c5e3f12482e575ea06b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6bbb86ae_26437bbf","updated":"2026-11-01 16:59:55.000000000","message":"Ugh, looks like tox 4.67.5 has broken us here (albeit for good reason) https://github.com/tox-dev/tox/pull/4305","commit_id":"66117736fd03ea59aba83ad1e267988d89a54bc4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fd5e524faad0ad18393b765d5127ebe365d76d12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8dc2c346_f4dee027","updated":"2026-11-01 10:12:15.000000000","message":"recheck","commit_id":"66117736fd03ea59aba83ad1e267988d89a54bc4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"902c98b0e2c47d351c8a9f1a3a3ed0e664f0493d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cf4617fe_64fd3525","in_reply_to":"6bbb86ae_26437bbf","updated":"2026-11-01 17:29:07.000000000","message":"https://github.com/tox-dev/tox/issues/4357","commit_id":"66117736fd03ea59aba83ad1e267988d89a54bc4"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5779a7d0e506fa5884744cf3f67c442686f8dbdc","unresolved":true,"context_lines":[{"line_number":466,"context_line":"                    else:"},{"line_number":467,"context_line":"                        version_cap \u003d self.VERSION_ALIASES.get(upgrade_level,"},{"line_number":468,"context_line":"                                                               upgrade_level)"},{"line_number":469,"context_line":"                    if version_cap and ("},{"line_number":470,"context_line":"                        versionutils.convert_version_to_tuple(version_cap) \u003c"},{"line_number":471,"context_line":"                        versionutils.convert_version_to_tuple(target.version)"},{"line_number":472,"context_line":"                    ):"},{"line_number":473,"context_line":"                        raise exception.ComputeRPCVersionCapTooOld("},{"line_number":474,"context_line":"                            version_cap\u003dversion_cap, minimum\u003dtarget.version)"},{"line_number":475,"context_line":"                    serializer \u003d objects_base.NovaObjectSerializer()"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"                    # NOTE(danms): We need to poke this path to register CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"72f30c7e_f3a77667","line":474,"range":{"start_line":469,"start_character":0,"end_line":474,"end_character":76},"updated":"2026-10-27 01:57:16.000000000","message":"i do not think we need to check and raise error here. nova does not allow non supported (\u003c OLDEST_SUPPORTED_SERVICE_VERSION) compute to start.","commit_id":"747ea959ed5600c197f92df7abb3fb8d27bde7b4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c334f32a3b987b389bd681d98bfcbdcf55e19ea4","unresolved":false,"context_lines":[{"line_number":466,"context_line":"                    else:"},{"line_number":467,"context_line":"                        version_cap \u003d self.VERSION_ALIASES.get(upgrade_level,"},{"line_number":468,"context_line":"                                                               upgrade_level)"},{"line_number":469,"context_line":"                    if version_cap and ("},{"line_number":470,"context_line":"                        versionutils.convert_version_to_tuple(version_cap) \u003c"},{"line_number":471,"context_line":"                        versionutils.convert_version_to_tuple(target.version)"},{"line_number":472,"context_line":"                    ):"},{"line_number":473,"context_line":"                        raise exception.ComputeRPCVersionCapTooOld("},{"line_number":474,"context_line":"                            version_cap\u003dversion_cap, minimum\u003dtarget.version)"},{"line_number":475,"context_line":"                    serializer \u003d objects_base.NovaObjectSerializer()"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"                    # NOTE(danms): We need to poke this path to register CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"1e69fe18_759ed737","line":474,"range":{"start_line":469,"start_character":0,"end_line":474,"end_character":76},"in_reply_to":"0898d0a4_e85fcca2","updated":"2026-10-29 19:59:47.000000000","message":"Done","commit_id":"747ea959ed5600c197f92df7abb3fb8d27bde7b4"},{"author":{"_account_id":39509,"name":"Lucas HENRY","display_name":"Lucas HENRY","email":"lucas.henry@ovhcloud.com","username":"polyedre"},"change_message_id":"b236334cf47bc813a0e0179c550088f8c1f83321","unresolved":true,"context_lines":[{"line_number":466,"context_line":"                    else:"},{"line_number":467,"context_line":"                        version_cap \u003d self.VERSION_ALIASES.get(upgrade_level,"},{"line_number":468,"context_line":"                                                               upgrade_level)"},{"line_number":469,"context_line":"                    if version_cap and ("},{"line_number":470,"context_line":"                        versionutils.convert_version_to_tuple(version_cap) \u003c"},{"line_number":471,"context_line":"                        versionutils.convert_version_to_tuple(target.version)"},{"line_number":472,"context_line":"                    ):"},{"line_number":473,"context_line":"                        raise exception.ComputeRPCVersionCapTooOld("},{"line_number":474,"context_line":"                            version_cap\u003dversion_cap, minimum\u003dtarget.version)"},{"line_number":475,"context_line":"                    serializer \u003d objects_base.NovaObjectSerializer()"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"                    # NOTE(danms): We need to poke this path to register CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"0898d0a4_e85fcca2","line":474,"range":{"start_line":469,"start_character":0,"end_line":474,"end_character":76},"in_reply_to":"72f30c7e_f3a77667","updated":"2026-10-27 10:37:02.000000000","message":"Done, removed. A pin older than 6.0 now fails on the oslo.messaging version cap check, like any other unsupported pin.","commit_id":"747ea959ed5600c197f92df7abb3fb8d27bde7b4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"15ec29830efbdcd7b5d9381c820e71bd47a9202c","unresolved":true,"context_lines":[{"line_number":762,"context_line":"        cctxt.cast(ctxt, \u0027finish_revert_resize\u0027, **msg_args)"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    def finish_snapshot_based_resize_at_dest("},{"line_number":765,"context_line":"            self, ctxt, instance, migration, snapshot_id, request_spec):"},{"line_number":766,"context_line":"        \"\"\"Finishes the snapshot-based resize at the destination compute."},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"        Sets up block devices and networking on the destination compute and"}],"source_content_type":"text/x-python","patch_set":2,"id":"ea22a61a_6cfa1a77","line":765,"updated":"2026-10-31 09:16:27.000000000","message":"We can drop this now, right?","commit_id":"66117736fd03ea59aba83ad1e267988d89a54bc4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"957b4692c472529128e05f6ffc525433bd6eb254","unresolved":false,"context_lines":[{"line_number":762,"context_line":"        cctxt.cast(ctxt, \u0027finish_revert_resize\u0027, **msg_args)"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    def finish_snapshot_based_resize_at_dest("},{"line_number":765,"context_line":"            self, ctxt, instance, migration, snapshot_id, request_spec):"},{"line_number":766,"context_line":"        \"\"\"Finishes the snapshot-based resize at the destination compute."},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"        Sets up block devices and networking on the destination compute and"}],"source_content_type":"text/x-python","patch_set":2,"id":"f08f12ce_5c915b3f","line":765,"in_reply_to":"ea22a61a_6cfa1a77","updated":"2026-11-02 10:08:01.000000000","message":"Done in https://review.opendev.org/c/openstack/nova/+/1013414/","commit_id":"66117736fd03ea59aba83ad1e267988d89a54bc4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"15ec29830efbdcd7b5d9381c820e71bd47a9202c","unresolved":true,"context_lines":[{"line_number":981,"context_line":"        return cctxt.call(ctxt, \u0027post_live_migration_at_destination\u0027,"},{"line_number":982,"context_line":"            instance\u003dinstance, block_migration\u003dblock_migration)"},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"    def pre_live_migration(self, ctxt, instance, block_migration, disk,"},{"line_number":985,"context_line":"            host, migrate_data):"},{"line_number":986,"context_line":"        version \u003d \u00276.0\u0027"},{"line_number":987,"context_line":"        client \u003d self.router.client(ctxt)"}],"source_content_type":"text/x-python","patch_set":2,"id":"77a24ce8_9ef0ca33","line":984,"updated":"2026-10-31 09:16:27.000000000","message":"We probably want to remove this too, right?\n\n```suggestion\n    def pre_live_migration(self, ctxt, instance, disk, host, migrate_data):\n```","commit_id":"66117736fd03ea59aba83ad1e267988d89a54bc4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"957b4692c472529128e05f6ffc525433bd6eb254","unresolved":false,"context_lines":[{"line_number":981,"context_line":"        return cctxt.call(ctxt, \u0027post_live_migration_at_destination\u0027,"},{"line_number":982,"context_line":"            instance\u003dinstance, block_migration\u003dblock_migration)"},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"    def pre_live_migration(self, ctxt, instance, block_migration, disk,"},{"line_number":985,"context_line":"            host, migrate_data):"},{"line_number":986,"context_line":"        version \u003d \u00276.0\u0027"},{"line_number":987,"context_line":"        client \u003d self.router.client(ctxt)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9da080ef_9972dd85","line":984,"in_reply_to":"77a24ce8_9ef0ca33","updated":"2026-11-02 10:08:01.000000000","message":"Done in https://review.opendev.org/c/openstack/nova/+/1013414/","commit_id":"66117736fd03ea59aba83ad1e267988d89a54bc4"}],"nova/tests/functional/integrated_helpers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5779a7d0e506fa5884744cf3f67c442686f8dbdc","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import os_traits"},{"line_number":28,"context_line":"from oslo_log import log as logging"},{"line_number":29,"context_line":"import oslo_messaging as messaging"},{"line_number":30,"context_line":"from oslo_utils.fixture import uuidsentinel as uuids"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from nova.compute import instance_actions"}],"source_content_type":"text/x-python","patch_set":1,"id":"c0bfa890_c888bb87","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":34},"updated":"2026-10-27 01:57:16.000000000","message":"this seems unused now and pep8 job failing for that\n\nF401 [*] `oslo_messaging` imported but unused\n  --\u003e nova/tests/functional/integrated_helpers.py:29:26","commit_id":"747ea959ed5600c197f92df7abb3fb8d27bde7b4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c334f32a3b987b389bd681d98bfcbdcf55e19ea4","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import os_traits"},{"line_number":28,"context_line":"from oslo_log import log as logging"},{"line_number":29,"context_line":"import oslo_messaging as messaging"},{"line_number":30,"context_line":"from oslo_utils.fixture import uuidsentinel as uuids"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from nova.compute import instance_actions"}],"source_content_type":"text/x-python","patch_set":1,"id":"a831f70b_27be1efd","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":34},"in_reply_to":"2ac1fe34_60ceb349","updated":"2026-10-29 19:59:47.000000000","message":"Done","commit_id":"747ea959ed5600c197f92df7abb3fb8d27bde7b4"},{"author":{"_account_id":39509,"name":"Lucas HENRY","display_name":"Lucas HENRY","email":"lucas.henry@ovhcloud.com","username":"polyedre"},"change_message_id":"bd432e7f75d986e5d0aa0ed55fd5c22bbdf1beb8","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import os_traits"},{"line_number":28,"context_line":"from oslo_log import log as logging"},{"line_number":29,"context_line":"import oslo_messaging as messaging"},{"line_number":30,"context_line":"from oslo_utils.fixture import uuidsentinel as uuids"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from nova.compute import instance_actions"}],"source_content_type":"text/x-python","patch_set":1,"id":"2ac1fe34_60ceb349","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":34},"in_reply_to":"c0bfa890_c888bb87","updated":"2026-10-27 10:35:53.000000000","message":"Done.","commit_id":"747ea959ed5600c197f92df7abb3fb8d27bde7b4"}],"releasenotes/notes/remove-compute-rpc-5x-compat-fca150bbf4d762e0.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5779a7d0e506fa5884744cf3f67c442686f8dbdc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The compute RPC API client no longer falls back to the 5.x versions of"},{"line_number":5,"context_line":"    the compute RPC API. Services now refuse to send compute RPC messages"},{"line_number":6,"context_line":"    when the compute RPC version cap is older than 6.0, whether it comes from"},{"line_number":7,"context_line":"    an ``[upgrade_levels] compute`` pin older than Wallaby or, with"},{"line_number":8,"context_line":"    ``[workarounds] disable_compute_service_check_for_ffu`` enabled, from a"},{"line_number":9,"context_line":"    pre-Wallaby ``nova-compute`` service still registered. Remove such a pin,"},{"line_number":10,"context_line":"    or set it to ``auto``, and upgrade any such ``nova-compute`` service."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c84cdbc4_174a3446","line":10,"range":{"start_line":2,"start_character":0,"end_line":10,"end_character":73},"updated":"2026-10-27 01:57:16.000000000","message":"i do not think we need release notes for this, i could not see if we did in past but let\u0027s wait for Dan/Sylvain opinion if we need it","commit_id":"747ea959ed5600c197f92df7abb3fb8d27bde7b4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c334f32a3b987b389bd681d98bfcbdcf55e19ea4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The compute RPC API client no longer falls back to the 5.x versions of"},{"line_number":5,"context_line":"    the compute RPC API. Services now refuse to send compute RPC messages"},{"line_number":6,"context_line":"    when the compute RPC version cap is older than 6.0, whether it comes from"},{"line_number":7,"context_line":"    an ``[upgrade_levels] compute`` pin older than Wallaby or, with"},{"line_number":8,"context_line":"    ``[workarounds] disable_compute_service_check_for_ffu`` enabled, from a"},{"line_number":9,"context_line":"    pre-Wallaby ``nova-compute`` service still registered. Remove such a pin,"},{"line_number":10,"context_line":"    or set it to ``auto``, and upgrade any such ``nova-compute`` service."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7ef47765_b62e4225","line":10,"range":{"start_line":2,"start_character":0,"end_line":10,"end_character":73},"in_reply_to":"1509153f_98cf7b27","updated":"2026-10-29 19:59:47.000000000","message":"++","commit_id":"747ea959ed5600c197f92df7abb3fb8d27bde7b4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"15ec29830efbdcd7b5d9381c820e71bd47a9202c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The compute RPC API client no longer falls back to the 5.x versions of"},{"line_number":5,"context_line":"    the compute RPC API. Services now refuse to send compute RPC messages"},{"line_number":6,"context_line":"    when the compute RPC version cap is older than 6.0, whether it comes from"},{"line_number":7,"context_line":"    an ``[upgrade_levels] compute`` pin older than Wallaby or, with"},{"line_number":8,"context_line":"    ``[workarounds] disable_compute_service_check_for_ffu`` enabled, from a"},{"line_number":9,"context_line":"    pre-Wallaby ``nova-compute`` service still registered. Remove such a pin,"},{"line_number":10,"context_line":"    or set it to ``auto``, and upgrade any such ``nova-compute`` service."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"70767afe_9e04c696","line":10,"range":{"start_line":2,"start_character":0,"end_line":10,"end_character":73},"in_reply_to":"7ef47765_b62e4225","updated":"2026-10-31 09:16:27.000000000","message":"Done","commit_id":"747ea959ed5600c197f92df7abb3fb8d27bde7b4"},{"author":{"_account_id":39509,"name":"Lucas HENRY","display_name":"Lucas HENRY","email":"lucas.henry@ovhcloud.com","username":"polyedre"},"change_message_id":"4ecc9ddf065f2ac05e536ba4aefab2120786b539","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The compute RPC API client no longer falls back to the 5.x versions of"},{"line_number":5,"context_line":"    the compute RPC API. Services now refuse to send compute RPC messages"},{"line_number":6,"context_line":"    when the compute RPC version cap is older than 6.0, whether it comes from"},{"line_number":7,"context_line":"    an ``[upgrade_levels] compute`` pin older than Wallaby or, with"},{"line_number":8,"context_line":"    ``[workarounds] disable_compute_service_check_for_ffu`` enabled, from a"},{"line_number":9,"context_line":"    pre-Wallaby ``nova-compute`` service still registered. Remove such a pin,"},{"line_number":10,"context_line":"    or set it to ``auto``, and upgrade any such ``nova-compute`` service."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1509153f_98cf7b27","line":10,"range":{"start_line":2,"start_character":0,"end_line":10,"end_character":73},"in_reply_to":"c84cdbc4_174a3446","updated":"2026-10-27 10:36:53.000000000","message":"I shortened it to only what\u0027s relevant for operators. Happy to drop it if Dan or Sylvain think it\u0027s not needed. I dropped the note from the follow-up change, since this one covers it.","commit_id":"747ea959ed5600c197f92df7abb3fb8d27bde7b4"}]}
