)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"132a87c06adea9281996b91afefd43e4b4c304bb","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Treat ws and wss as http and https on both sides of the comparison, as"},{"line_number":16,"context_line":"was already done for the ws and wss access urls of serial consoles."},{"line_number":17,"context_line":"The forwarded protocol keeps its precedence over the Origin scheme."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change I1639a2400f1614dd102caf7846f79c2f0513473d addresses the same"},{"line_number":20,"context_line":"problem by checking the Origin scheme first and only falling back to"},{"line_number":21,"context_line":"X-Forwarded-Proto. This change keeps the existing precedence instead:"},{"line_number":22,"context_line":"the proxy reports the protocol of the connection it terminated, which"},{"line_number":23,"context_line":"the Origin header of the page does not always reflect."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #2172853"},{"line_number":26,"context_line":"Change-Id: I6e86917c82bc703beba5d303df08e37e5929a1dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ce9e3543_6148ce4e","line":23,"range":{"start_line":18,"start_character":1,"end_line":23,"end_character":54},"updated":"2026-11-04 16:10:24.000000000","message":"that change id may never appears in git log. I\u0027d rather drop it.","commit_id":"62f78b25891b87e442ad4fb879d008a818aef792"},{"author":{"_account_id":39509,"name":"Lucas HENRY","display_name":"Lucas HENRY","email":"lucas.henry@ovhcloud.com","username":"polyedre"},"change_message_id":"61bea895f305d3276c0750acd80e1411895f0732","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Treat ws and wss as http and https on both sides of the comparison, as"},{"line_number":16,"context_line":"was already done for the ws and wss access urls of serial consoles."},{"line_number":17,"context_line":"The forwarded protocol keeps its precedence over the Origin scheme."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change I1639a2400f1614dd102caf7846f79c2f0513473d addresses the same"},{"line_number":20,"context_line":"problem by checking the Origin scheme first and only falling back to"},{"line_number":21,"context_line":"X-Forwarded-Proto. This change keeps the existing precedence instead:"},{"line_number":22,"context_line":"the proxy reports the protocol of the connection it terminated, which"},{"line_number":23,"context_line":"the Origin header of the page does not always reflect."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #2172853"},{"line_number":26,"context_line":"Change-Id: I6e86917c82bc703beba5d303df08e37e5929a1dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"85be6bcd_2e10c99d","line":23,"range":{"start_line":18,"start_character":1,"end_line":23,"end_character":54},"in_reply_to":"5edcb516_524b5b4b","updated":"2026-11-05 09:29:34.000000000","message":"Done","commit_id":"62f78b25891b87e442ad4fb879d008a818aef792"},{"author":{"_account_id":39509,"name":"Lucas HENRY","display_name":"Lucas HENRY","email":"lucas.henry@ovhcloud.com","username":"polyedre"},"change_message_id":"274ea960757dd8a73b57b2bb8987bf9b20e35dbe","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Treat ws and wss as http and https on both sides of the comparison, as"},{"line_number":16,"context_line":"was already done for the ws and wss access urls of serial consoles."},{"line_number":17,"context_line":"The forwarded protocol keeps its precedence over the Origin scheme."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change I1639a2400f1614dd102caf7846f79c2f0513473d addresses the same"},{"line_number":20,"context_line":"problem by checking the Origin scheme first and only falling back to"},{"line_number":21,"context_line":"X-Forwarded-Proto. This change keeps the existing precedence instead:"},{"line_number":22,"context_line":"the proxy reports the protocol of the connection it terminated, which"},{"line_number":23,"context_line":"the Origin header of the page does not always reflect."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: #2172853"},{"line_number":26,"context_line":"Change-Id: I6e86917c82bc703beba5d303df08e37e5929a1dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5edcb516_524b5b4b","line":23,"range":{"start_line":18,"start_character":1,"end_line":23,"end_character":54},"in_reply_to":"ce9e3543_6148ce4e","updated":"2026-11-05 09:28:17.000000000","message":"Done, dropped.","commit_id":"62f78b25891b87e442ad4fb879d008a818aef792"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"132a87c06adea9281996b91afefd43e4b4c304bb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"23a7dc6a_bac7eb16","updated":"2026-11-04 16:10:24.000000000","message":"The change looks good to me. Could you please add a release note ?","commit_id":"62f78b25891b87e442ad4fb879d008a818aef792"},{"author":{"_account_id":39509,"name":"Lucas HENRY","display_name":"Lucas HENRY","email":"lucas.henry@ovhcloud.com","username":"polyedre"},"change_message_id":"61bea895f305d3276c0750acd80e1411895f0732","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c561a9cf_bf670988","in_reply_to":"23a7dc6a_bac7eb16","updated":"2026-11-05 09:29:34.000000000","message":"Done","commit_id":"62f78b25891b87e442ad4fb879d008a818aef792"}],"nova/tests/unit/console/test_websocketproxy.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"132a87c06adea9281996b91afefd43e4b4c304bb","unresolved":false,"context_lines":[{"line_number":556,"context_line":"    @mock.patch(\u0027nova.console.websocketproxy.NovaProxyRequestHandler.\u0027"},{"line_number":557,"context_line":"                \u0027_check_console_port\u0027)"},{"line_number":558,"context_line":"    @mock.patch(\u0027nova.objects.ConsoleAuthToken.validate\u0027)"},{"line_number":559,"context_line":"    def test_new_websocket_client_novnc_https_forwarded_proto_wss("},{"line_number":560,"context_line":"            self, validate, check_port):"},{"line_number":561,"context_line":"        params \u003d {"},{"line_number":562,"context_line":"            \u0027id\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":1,"id":"56d10970_0fb52655","line":559,"range":{"start_line":559,"start_character":8,"end_line":559,"end_character":65},"updated":"2026-11-04 16:10:24.000000000","message":"These tests are quite similar so we could probably create a base helper and reuse it. However the same problem appears in the other tests too so I think we can leave it for follow-up.","commit_id":"62f78b25891b87e442ad4fb879d008a818aef792"}]}
