)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"acb6caa7d15ec620357bccde508c64370b9df950","unresolved":false,"context_lines":[{"line_number":298,"context_line":"class ComputeManager(manager.SchedulerDependentManager):"},{"line_number":299,"context_line":"    \"\"\"Manages the running instances from creation to destruction.\"\"\""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    RPC_API_VERSION \u003d \u00271.6\u0027"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def __init__(self, compute_driver\u003dNone, *args, **kwargs):"},{"line_number":304,"context_line":"        \"\"\"Load configuration options and connect to the hypervisor.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAKn%2F%2F%2F%2B8%3D","line":301,"updated":"2012-07-25 03:30:55.000000000","message":"Urgh. These all have to get merged in the right order, right? Would they be better off as a single large patch?","commit_id":"4f77c77413996cf56c947796982b240a0ac8f19e"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"bbfbdab51c28f92c9eb78d4afd42fddd82169b21","unresolved":false,"context_lines":[{"line_number":298,"context_line":"class ComputeManager(manager.SchedulerDependentManager):"},{"line_number":299,"context_line":"    \"\"\"Manages the running instances from creation to destruction.\"\"\""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    RPC_API_VERSION \u003d \u00271.6\u0027"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def __init__(self, compute_driver\u003dNone, *args, **kwargs):"},{"line_number":304,"context_line":"        \"\"\"Load configuration options and connect to the hypervisor.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAKn%2F%2F%2Fxw%3D","line":301,"in_reply_to":"AAAAKn%2F%2F%2F%2B8%3D","updated":"2012-07-25 12:30:00.000000000","message":"Yes, but the patches are properly dependent on each other in gerrit.  They can\u0027t go in in the wrong order.\n\nA single large patch makes all of these changes harder to review and more difficult to bisect if there are problems.","commit_id":"4f77c77413996cf56c947796982b240a0ac8f19e"}],"nova/tests/compute/test_rpcapi.py":[{"author":{"_account_id":159,"name":"Eric Windisch","email":"ewindisch@docker.com","username":"ewindisch"},"change_message_id":"faabf3c1b6bc7d297791fc419f0d0dbb5a0e4fd8","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_get_console_output(self):"},{"line_number":163,"context_line":"        self._test_compute_api(\u0027get_console_output\u0027, \u0027call\u0027,"},{"line_number":164,"context_line":"                instance\u003dself.fake_instance, tail_length\u003d\u0027tl\u0027, version\u003d\u00271.6\u0027)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def test_get_console_pool_info(self):"},{"line_number":167,"context_line":"        self._test_compute_api(\u0027get_console_pool_info\u0027, \u0027call\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAKn%2F%2F%2FwI%3D","line":164,"updated":"2012-07-25 12:55:05.000000000","message":"Do tests really need to use version numbers? They\u0027re distributed/included with the code being changed. Versions are primarily for communication between installations, not within one.","commit_id":"1ee5b6f3e45413ae5bfeef736083d51946f4521d"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"f85d0ea2931d8c5b53716ce8d63dfa099e1b5cd4","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_get_console_output(self):"},{"line_number":163,"context_line":"        self._test_compute_api(\u0027get_console_output\u0027, \u0027call\u0027,"},{"line_number":164,"context_line":"                instance\u003dself.fake_instance, tail_length\u003d\u0027tl\u0027, version\u003d\u00271.6\u0027)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def test_get_console_pool_info(self):"},{"line_number":167,"context_line":"        self._test_compute_api(\u0027get_console_pool_info\u0027, \u0027call\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAKn%2F%2F%2Ft8%3D","line":164,"in_reply_to":"AAAAKn%2F%2F%2FwI%3D","updated":"2012-07-25 13:35:12.000000000","message":"Yes, because this code is ensuring that the expected version number is placed into the message being sent out via rpc.","commit_id":"1ee5b6f3e45413ae5bfeef736083d51946f4521d"}]}